From nobody Fri Dec 19 07:00:49 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B56A420D5C3; Sun, 24 Mar 2024 23:07:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321652; cv=none; b=b+BDujXSFTmRqX46RKglVPiFQcB/HC6c+EDN7bmPPzQ1G5CvNcnarlSwrEBK8AplbMqlva7ivqQE2KoqZMLLAro/+r4w0UDHFaOXGeBOY82yDiYLVMewJIZGSwQWfuZ+/sFS3b1c+n1TIKSSt8LKqKM2ObCPWuRB6cIq6N1PZa4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321652; c=relaxed/simple; bh=CwWwXVhHyKnLQ10moKJIyAHUeLsBYRK/aKO6LwRtc0U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RDV31UD6EqbTRxS9H708yXL81L5OGlF/0M4fLTuQGDZKFTKDMbUfvLb3jo6pIwvLbGR0qomqnGvWjVSHU7I9zi9V6GE32z6ZjxOxqVrOFj//I82OQxyr2ZUjY8FeUWfxXoU4TNcI4WuJzTqeYFnyNgP816Gwau1fTrEBR5cJRQs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G036siF0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G036siF0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 905C7C43390; Sun, 24 Mar 2024 23:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711321652; bh=CwWwXVhHyKnLQ10moKJIyAHUeLsBYRK/aKO6LwRtc0U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G036siF0eK+ypPBE4oQHsPE147nY1Nk5rfdiwIRC/TECZzEB+rKGwDL5yGtBY+PM6 62pk+Ibz4VN7BJQHPThtXBj32QLw7b3aJUmuFl7sqX7HMTBEP/fuTPtJp+334pkCCP xXy7eKp9syuYN6W00oUxrgE0D99G2yGJu6T/PygtNfdJAQJQ1waFj3nn3Ev2RUB3D9 RBpDgokvCR+bJdgRrIT89uZNkHfJ5+AqCpwPar+pQHSEA4HfMdRB9GqkDtKd+4Z6Q5 CzNPlTYfQYEAYkxYZP3rAAdPOm7Mud8q3bDnNwINFcmvLwiUVAL54/C/V7d8/0qZGt nwAAdf9RvUUOw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nikita Zhandarovich , Mauro Carvalho Chehab , Hans Verkuil , Sasha Levin Subject: [PATCH 6.6 381/638] media: em28xx: annotate unchecked call to media_device_register() Date: Sun, 24 Mar 2024 18:56:58 -0400 Message-ID: <20240324230116.1348576-382-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324230116.1348576-1-sashal@kernel.org> References: <20240324230116.1348576-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Nikita Zhandarovich [ Upstream commit fd61d77a3d28444b2635f0c8b5a2ecd6a4d94026 ] Static analyzers generate alerts for an unchecked call to `media_device_register()`. However, in this case, the device will work reliably without the media controller API. Add a comment above the call to prevent future unnecessary changes. Suggested-by: Mauro Carvalho Chehab Fixes: 37ecc7b1278f ("[media] em28xx: add media controller support") Signed-off-by: Nikita Zhandarovich Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/usb/em28xx/em28xx-cards.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em= 28xx/em28xx-cards.c index 4d037c92af7c5..bae76023cf71d 100644 --- a/drivers/media/usb/em28xx/em28xx-cards.c +++ b/drivers/media/usb/em28xx/em28xx-cards.c @@ -4094,6 +4094,10 @@ static int em28xx_usb_probe(struct usb_interface *in= tf, * topology will likely change after the load of the em28xx subdrivers. */ #ifdef CONFIG_MEDIA_CONTROLLER + /* + * No need to check the return value, the device will still be + * usable without media controller API. + */ retval =3D media_device_register(dev->media_dev); #endif =20 --=20 2.43.0