From nobody Sun Feb 8 20:37:51 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13C002062FE; Sun, 24 Mar 2024 23:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321500; cv=none; b=nIkgcd7+FsUhrEyt4XbxdB7nGFyxtOhac7fbi4wynTHNlZ4OoJjovxAuZ2/O1ax7noShgXJlvBnZPoV29cfaYvdoTuiCqg0oTXz7fKas8A8C2K8Szoe2L7Hvgh+Sz7H5lcyX2soLAjBovGsJspyZvgDVGQlOTSzbsgE83plEK7s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321500; c=relaxed/simple; bh=eOFSIzfqtIpRZNnVVtzJpHLcTC4yIAg2d1c5jY0FyDo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l1YJsLGnzb7yLorWB+k+CEp+q6e7JnuVUwWJWYzvH+rkR7UE5OeAeYIvRz6XTuxLbXbbFgeLwiYp/DgLVnnLlFmnyG1nDFYYMtsWPPEjwv2woFVbPOff4e4cDpUAqhjm4W+zTZ+YDNG8RtjHHLmMXLb6iTKHtHnTS2MVbr+5Enk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jqAEEx7N; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jqAEEx7N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52843C43394; Sun, 24 Mar 2024 23:04:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711321498; bh=eOFSIzfqtIpRZNnVVtzJpHLcTC4yIAg2d1c5jY0FyDo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jqAEEx7NXinHMU0NOVStOBxjPJrblBG3b8CbtxhBrt/5r+/O55+LLWAIT/UrRB6Ej +tsNwSEz6HVpYDc6sStha5QbKKL1Yf/fBDUjWh+EC6K56CrvH3VAfDcucxoCCLDqyJ h0JPWcU9kHLZfLxMES5wtxNI8iTqXbqodmjZo9M7pQSrg12GcyTb5o+zhBookvdUm0 56MOrzsWEvxfPGnvIXen14snyLggzZCBaH+yTWs+49keZAPrnWllxyIhS3a0KX/Xiy fZCw0dTlPPL+aHgMFDNDYuVmPnae+bW9VL+FhwsSTJMOPU8uVY1ja3zOhvKKsPwuhf wIZ2Ho32J/bEQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Arnd Bergmann , Viresh Kumar , Sasha Levin Subject: [PATCH 6.6 224/638] cpufreq: qcom-hw: add CONFIG_COMMON_CLK dependency Date: Sun, 24 Mar 2024 18:54:21 -0400 Message-ID: <20240324230116.1348576-225-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324230116.1348576-1-sashal@kernel.org> References: <20240324230116.1348576-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann [ Upstream commit 3093fa33539b54db77171d2919352ad4f044a1c5 ] It is still possible to compile-test a kernel without CONFIG_COMMON_CLK for some ancient ARM boards or other architectures, but this causes a link failure in the qcom-cpufreq-hw driver: ERROR: modpost: "devm_clk_hw_register" [drivers/cpufreq/qcom-cpufreq-hw.ko]= undefined! ERROR: modpost: "devm_of_clk_add_hw_provider" [drivers/cpufreq/qcom-cpufreq= -hw.ko] undefined! ERROR: modpost: "of_clk_hw_onecell_get" [drivers/cpufreq/qcom-cpufreq-hw.ko= ] undefined! Add a Kconfig dependency here to make sure this always work. Apparently this bug has been in the kernel for a while without me running into it on randconfig builds as COMMON_CLK is almost always enabled. I have cross-checked by building an allmodconfig kernel with COMMON_CLK disabled, which showed no other driver having this problem. Fixes: 4370232c727b ("cpufreq: qcom-hw: Add CPU clock provider support") Signed-off-by: Arnd Bergmann Signed-off-by: Viresh Kumar Signed-off-by: Sasha Levin --- drivers/cpufreq/Kconfig.arm | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index 123b4bbfcfee1..c5cecbd89ba9c 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -173,6 +173,7 @@ config ARM_QCOM_CPUFREQ_NVMEM config ARM_QCOM_CPUFREQ_HW tristate "QCOM CPUFreq HW driver" depends on ARCH_QCOM || COMPILE_TEST + depends on COMMON_CLK help Support for the CPUFreq HW driver. Some QCOM chipsets have a HW engine to offload the steps --=20 2.43.0