From nobody Fri Dec 19 07:01:50 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26E0A147C64; Sun, 24 Mar 2024 22:54:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320874; cv=none; b=YMPhLxtZaJPlVUTFc6QcN8togUKjI2yiruKugGyKlnntccBBnyH5drq814kO0T35brcHp9nxZNO8T3YiLlG6jdqe//vh6F30VKGnLKOqAalsxD6J0NsL+3WKVXYKKOJ6fToy4tlcgfvdzuRP+91yOymIAxGyj6T9Linw1LB0C1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320874; c=relaxed/simple; bh=pCc5yRqiW7zrM8WJbTTAP0OTtZg+beqdp63g2hcZTaQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c7euOzq2I8HbqxTrw6p3/fQevf5HaNfLmzjxNe3D0PuVo1zqgIAlZ8IXpkcCWVDwQ4Sv+Di34Fr0fpr8IXgtg13an3WEXiKYyLjCUDjBpzbIYblK0vOfLUB7AfLHqdwxIDYG2NB0aCMfg61+wCxNWjKk9143zOnjQKvksQIZfZQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n6FmOdJj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n6FmOdJj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 618D0C433F1; Sun, 24 Mar 2024 22:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711320873; bh=pCc5yRqiW7zrM8WJbTTAP0OTtZg+beqdp63g2hcZTaQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n6FmOdJjggZzjLEyNe+x0i14awO9HzgIdIzYJsK/IEgBkVysEUEI5nku5E5dNlrVR ekYYeLmt/BaPsAnoySMw/Vi2zpKihi5BPBeAIT1GuSxyzmQdpqCFkJKUBwqNMx0sYj w71Lv0sW5vPQg5Xr+Qzn6vmybUuHSN8ps+5cBdXltKHdvPkdBjlK2Dy3TqtQSQMht7 LmYPAtgwKPaQTuJwMMJLVAIAkFHKXqHsttSbIO0ej0zqIMACY3VDdA/U5zKwkZv/yZ JQhge7GP8HVp5C5GrqLo4W9iVm+w3OmfneDmA6YNq2PdG1X41VCvSW6e2dNC3ZpXcP N58fY4xlaEy2w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Konrad Dybcio , Bjorn Andersson , Sasha Levin Subject: [PATCH 6.7 437/713] clk: qcom: reset: Ensure write completion on reset de/assertion Date: Sun, 24 Mar 2024 18:42:43 -0400 Message-ID: <20240324224720.1345309-438-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324224720.1345309-1-sashal@kernel.org> References: <20240324224720.1345309-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Konrad Dybcio [ Upstream commit 2f8cf2c3f3e3f7ef61bd19abb4b0bb797ad50aaf ] Trying to toggle the resets in a rapid fashion can lead to the changes not actually arriving at the clock controller block when we expect them to. This was observed at least on SM8250. Read back the value after regmap_update_bits to ensure write completion. Fixes: b36ba30c8ac6 ("clk: qcom: Add reset controller support") Signed-off-by: Konrad Dybcio Link: https://lore.kernel.org/r/20240105-topic-venus_reset-v2-3-c37eba13b5c= e@linaro.org Signed-off-by: Bjorn Andersson Signed-off-by: Sasha Levin --- drivers/clk/qcom/reset.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/clk/qcom/reset.c b/drivers/clk/qcom/reset.c index 20d1d35aaf229..d96c96a9089f4 100644 --- a/drivers/clk/qcom/reset.c +++ b/drivers/clk/qcom/reset.c @@ -33,7 +33,12 @@ static int qcom_reset_set_assert(struct reset_controller= _dev *rcdev, map =3D &rst->reset_map[id]; mask =3D map->bitmask ? map->bitmask : BIT(map->bit); =20 - return regmap_update_bits(rst->regmap, map->reg, mask, assert ? mask : 0); + regmap_update_bits(rst->regmap, map->reg, mask, assert ? mask : 0); + + /* Read back the register to ensure write completion, ignore the value */ + regmap_read(rst->regmap, map->reg, &mask); + + return 0; } =20 static int qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned = long id) --=20 2.43.0