From nobody Sun Feb 8 15:01:36 2026 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2063.outbound.protection.outlook.com [40.107.22.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5687B1798E; Sat, 23 Mar 2024 12:07:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711195655; cv=fail; b=PES6qoJfnATOA3GObWzpfWiWFtnyyjdtNxk3ANleXPk3IvjhCgUwyEYLYFqrcg7d6bmSXiZKtLqIvSJSjjVEarvJwRZ9wr2rtY0lR978LO04wAZFb5td7FNsvpux9OXlOYqFLmbUbqWERohNTQhJ6cU6sw+XdYcfktTr78FdmUI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711195655; c=relaxed/simple; bh=t5HLy5gFexuRUd/gcXkLur0tNUBqrWNFLScENOV0ZWY=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=C0xIIiWQHs/JflWX8VdA4OeBSCSVbTpwgG30kJPd72E+L21CujjD/VQHUp1PvUAYELdOOHjgx08TdcKpRlF/4r2OjQBa5M7w8Qrh2gnH7VcH2X/5FTDjsd2XRyI6zIYESdaINYBfuytXGjUgtVcO5sZlvMkjbR7QQxyRe+W/a3g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=EpaWgE1a; arc=fail smtp.client-ip=40.107.22.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="EpaWgE1a" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OWC8998d4/pI5kq4SLBi89Fowcqov7SDx290PK1xRJ+ubxWFoB/yWbH9QLZWRorGtqlHyLJYABqD5FXD/XkDKsQgUDYKimfXBAXlalPvZAIJrYvPNkCFsKXUdWEVWoDBKM3wNAukmLUfm9oTiU//Kl4flp/DqtwYr/5arhR3xf66KX4Y1KkFGf9DibP9ri2T7fikKVlOWZUJkGH9AHSh5DpCPwxGgje4ejTcw4BOhyGxvjXY2iFwAFSSw9TQ/RKxmtGJTP0vTSDvxapNhqC4fxf2YZ+DZh6tGkEnmqmxciRPzBTQ7wK/71kj2Cj1U6dqbwdU/8biTynWwJOA3vNDMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DkhFzy347CReKh8Y/3De5x5m9e7u839I/9k6SdaIf8U=; b=fysKkYRANQSw3cjTQ08aC23Horpog23LBV8n7PGmAFCHsl3uSn/8s40/VpzWQBPqPzXVOiX4aE6T13oTPZq5XO3PmQd614qdkyjGJO2G5Y9yPH6pDLxbAUupXI2uTYIVJFmGRQ2E939Ow1AzPQl5i1AlQOtEOkxi9XCu6k5d2Fp72E/NOEPLxM3CcRy8xl3JDTavP+1DNCzbEQio8UQU2ShMgY7cEeTlL5+qfm5Hpp2cOpZMcN34S23bbPOgCD8v3jFyzpGMq3gnAUwI6E5QrUkvBW9rJlsszR9lUdeedizlob9OhfNLhBIph9sgf9NRtotNisX4S+Iv/T+J9VvhwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DkhFzy347CReKh8Y/3De5x5m9e7u839I/9k6SdaIf8U=; b=EpaWgE1ax3yjyWdWeWjxGXD+Z1A8d+a06yy7Up25D72VYNqFBnx28vsqvkAiM4WYT2kEEuNq+E+mcGtUfuphf5B4z2/0p8j+bNPACrDV4/fMVxD9PjvYe40pohCdJikqZqrk68889as2DOMqeF2JuBKn23SPGGlYJyyDDADDLSQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by DU0PR04MB9585.eurprd04.prod.outlook.com (2603:10a6:10:316::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.26; Sat, 23 Mar 2024 12:07:30 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.017; Sat, 23 Mar 2024 12:07:30 +0000 From: "Peng Fan (OSS)" Date: Sat, 23 Mar 2024 20:15:14 +0800 Subject: [PATCH v6 1/4] firmware: arm_scmi: introduce helper get_max_msg_size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240323-pinctrl-scmi-v6-1-a895243257c0@nxp.com> References: <20240323-pinctrl-scmi-v6-0-a895243257c0@nxp.com> In-Reply-To: <20240323-pinctrl-scmi-v6-0-a895243257c0@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1711196144; l=2653; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=dKDsMHnM+cuvfvX6K6tAU3ADCasBJe+OHaz6qBQ1Tuc=; b=YCMLoesvvEksAchrZiSgtAE6+ph9Er9HhKtwRJucNf2NYbKuXTtNL5fw03vZ1EUKko+Dj5oF9 68c+d636v0yB4NTZRKEkdkYAxtLIs/XfPY6xpneKjzqpHkKhh/k4oh2 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR06CA0016.apcprd06.prod.outlook.com (2603:1096:4:186::22) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|DU0PR04MB9585:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a1593e5-55f2-44ae-9d65-08dc4b31d0a2 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gy8CVQWIGLPp+K5HqbgaT9+ZowM1+AiyJWp18+tQBA1SClBtvHab2OknIQ+IzYNupCzj6riOq+C4ktWfHNicbeHsU+G/b5v4Bp8Afn+Ra7dqvSYCBkrxfPxZwVg0sYy4O/WySCIxHtfmmVLKDhSZcE7JrSDswDSJZ6NtwUHzHOW540JS+baZgSvnCBF4yxOsgkM3mQw9qsLgU7peynatI2GbwJJBKIXfo5u3DKoEzLmqwm87AoP7drT/yPa7BXb0ny+hFCXRkFqVa1eMXSzoYVyrpzCUc3ishRVbNo8SPTUQXhRrlcDmXr66usDvCtjuA2ycgUZmIPQneoyOxY1R2z2jvNI+89JINcZJu2hKTA7GKuSQoKDzeAoT2Oi/Rp6h45GN2/W7e98l78OBdANC20R9yUW/N+Kyj6W7v21+pW5unvJ0y9DW1lE+l97VPOmk+hRc/Y6nhEGQ4vg1HjClBkXlEv50XHtvIxYyQaw2Kcr7m4vJgOo6azUjqjIXgtZjeHb8669aT6KNN6Im9tDj1+KDMFzQxIrQ17WQqLKKGvpfTLbl8gtRclfGYjCPQiDtHBbupbFRm0bsn5EbqytBssWo3OXHLRTfHJLoqc3m366I3GBOLKZUWhuHfCLrUAe8OE3WTS14FELYmRJIClD86sS6qt9lZ6cYjk1NlkvcbPuZeOxWfQ4TNVprVXjqCl2jEgVMLDNaqtS2I9thg+GfI6nrwPo9eRfCobQHb7WHxVk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(52116005)(7416005)(1800799015)(376005)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkFKV01sYjlLMmRnUnFXTjRHS0xVRTlsTE9FYWJsbTB4SDJBbDhEU09rZXdk?= =?utf-8?B?cDVIK0pwM0tLemtJMURNWlhTdzZlOGQ5dXpGUVZNZXN0M0s5NVZ1cStCaXMy?= =?utf-8?B?UWI4WjBwMEZZdGRKd2dzN2RtYTYyVlJBcmxVZDY5Y0twMFIvOXdWdU14RElB?= =?utf-8?B?Zk1WVkJ1RlZIQ2Nad0V1ZTlycEtiN01XODJsM2pYVjRiMmh2R0owVW5LMU14?= =?utf-8?B?NHdUbEZXZCtWSUdsa04vaUo3S0l1bzVpclhjU3praWxoRzhKSURSTTlJa2kx?= =?utf-8?B?U3ZUZ0RJWUQyaFRRdEZFMDVBVlREK1cwbmFEeElvZFFpTGlaYUtUTzFIRVlZ?= =?utf-8?B?OHdiUXBDMHUrcUYrOHpKSW0rZlkzUllFWExDb2c2cG9DKzVydkV1STZKZnBj?= =?utf-8?B?bGNnWFFML2NMWjF4RlViUVJwQlhsQy9lUHhQNUhvYnVvdkU3Z2pmVERDSmc5?= =?utf-8?B?L0IvQzNGVHh6K3pVaXdwQUVyYy8wZjkycStCb20yRkVKS1RaZUNkdWhIdldw?= =?utf-8?B?S01pN0NEK091Kzk4eTlRbFVzMCsvd1BpcHVEckYvN2pwc3JESkhmSm5PQUNx?= =?utf-8?B?RjZuOTFHQ25ncWNRTnF3MXoxcU1Wb2pCd09tSXNJQ2hHbHZKaE9yTzdrMUp6?= =?utf-8?B?V2pvTkN0VDJhUGdxZWNJRUNTaW92NGxRbWFjWlVwYjFrOWRpejJNQWl0S3Fp?= =?utf-8?B?YXBxa0R5SVBpcTF0MjBhR0tQcmplampISFViRzhaNi9idGJEbDhyeVRkKytD?= =?utf-8?B?eCtvWlpUVnBCNkI5cUhQc2Z3bDNGSFd6bUdMVi9GZkc3VENxVmwvWklzTHN2?= =?utf-8?B?Z2N0d3piL0RQSjVUbzR6RHhmQUFsd0JJYWtGOEpoRVBhWlJoL25SdFFvMThn?= =?utf-8?B?ei83a1VlR0ZoMktKYjRFNEJhSmQybzJGTWwvT3BnaWcvRW5PN2V1TktnYk4z?= =?utf-8?B?eUI2RFhUTG9SNjRyS2tNSktLU1Vqb0dzN2VlanBkeXFjRE9vSjh5YkczOElI?= =?utf-8?B?cjlOMHRKanBsalpHNG0wbTNEdzN5VmVUdSsxM0t1R2ducm9NRCtnOFRnbTZ3?= =?utf-8?B?RVJMaUVld2ErdWh6VjFUL0RPajRTdHFqdWNHQlk2NnVHQlhpR1ZqOHo1ME01?= =?utf-8?B?Z1czNUVYK2VxOHljdEZqQU5kaGpMM3M2NE1mdFNUZmFpRjhXSkx3Z3lKcW9Q?= =?utf-8?B?NGpVZkl3TkwzMkU2RVM4Z1NYS1hRQ0FEcmg4L3RDS0lwZ2dETkxUVnlxZG40?= =?utf-8?B?MWFzaVlqc3JJYmE1WFZzSWxtU0dVR3ExN21nRW9WVnpWTUJlcDQyV09wTGNC?= =?utf-8?B?Sk1CaHZScFB1cUJPQnEwekpWanV6YlkxNWRZVWxMSFVNL2YzOSszeUtrMGZK?= =?utf-8?B?R1pzYzFwRUdUSGYra2E4OWZhUmlwRkMwQ0g3N0E1SVZ1TG5NbkNQMXY2TmpI?= =?utf-8?B?Vm1KR2JpdjdXQThtQnMyRUpSbE5WVmVZK3dqSmx1ZWZHc2FER0VjSkxhVyt3?= =?utf-8?B?TGF0S2dlNWdCMGljbCtpZzEvTHdHOWUzV0wrZFEvdm1QeWNCN0lFNE1pOVV2?= =?utf-8?B?VTJBeisrek8zZ1Y2cENFMm9uR0FPd21CRVhFMGdmVkx5dFN4UStIZERxdU5K?= =?utf-8?B?cC9Gelg5ZjZQVjRoUlE1eFhyT1NGenRrNExJaWx0bnFQZHBJV3BqaTlNV0pU?= =?utf-8?B?eko2VVRpOUwyZFh2SGt0L3JJOVFJdTN4eUhkeGpkaXNOcXcwNHcwNnMvNVMy?= =?utf-8?B?MnpSYzZ5dnJqOTArdDdiNU90a0tpSE85Y3dTQTZYbTBFcjJKVDRudGtYN1RN?= =?utf-8?B?SFpPTjNmSy9kWGdPekdZclhoZDAwbGUvMUtVNjJhSGk0SFpIWVExRnhSNU5m?= =?utf-8?B?cklqeFhsMk5JTmVuRDFXa2htaGFSaHFXMkZ0RVptVTUxUmxIY09PY3ZVZDZW?= =?utf-8?B?SjMvSlFPaDREYUF3d0V1Qi9qamJ3NDdQS25zdURIdzQxanFKWFJrK3BRbXNR?= =?utf-8?B?UVdwMldYeWZuVkxyUHZDNHMxNnFHOU10dmtFSW8zN2xKK2FNZW1JU2o4dTNt?= =?utf-8?B?VTUrKzFOd044OVNPa3lNSDFEOUVDUnRaeXBRdzFMbWZCTkNyMGpzYzFnWmNz?= =?utf-8?Q?iLpNK45N6cXsu2KQ6W+wFGVKW?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a1593e5-55f2-44ae-9d65-08dc4b31d0a2 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2024 12:07:30.6439 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7ZuPV+Bz+eYK+f54PpwXR8xbVhMFaNBJ4YRpv5U84XZFM6RgtYYiz4nHvyGhQsy+oyo28PqPX+zqumoiHWiH3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9585 From: Peng Fan When Agent sending data to SCMI server, the Agent driver could check the size to avoid protocol buffer overflow. So introduce the helper get_max_msg_size. Reviewed-by: Cristian Marussi Signed-off-by: Peng Fan --- drivers/firmware/arm_scmi/driver.c | 15 +++++++++++++++ drivers/firmware/arm_scmi/protocols.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi= /driver.c index 2709598f3008..415e6f510057 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -1488,6 +1488,20 @@ static int scmi_common_extended_name_get(const struc= t scmi_protocol_handle *ph, return ret; } =20 +/** + * scmi_common_get_max_msg_size - Get maximum message size + * @ph: A protocol handle reference. + * + * Return: Maximum message size for the current protocol. + */ +static int scmi_common_get_max_msg_size(const struct scmi_protocol_handle = *ph) +{ + const struct scmi_protocol_instance *pi =3D ph_to_pi(ph); + struct scmi_info *info =3D handle_to_scmi_info(pi->handle); + + return info->desc->max_msg_size; +} + /** * struct scmi_iterator - Iterator descriptor * @msg: A reference to the message TX buffer; filled by @prepare_message = with @@ -1799,6 +1813,7 @@ static int scmi_protocol_msg_check(const struct scmi_= protocol_handle *ph, =20 static const struct scmi_proto_helpers_ops helpers_ops =3D { .extended_name_get =3D scmi_common_extended_name_get, + .get_max_msg_size =3D scmi_common_get_max_msg_size, .iter_response_init =3D scmi_iterator_init, .iter_response_run =3D scmi_iterator_run, .protocol_msg_check =3D scmi_protocol_msg_check, diff --git a/drivers/firmware/arm_scmi/protocols.h b/drivers/firmware/arm_s= cmi/protocols.h index 317d3fb32676..3e91536a77a3 100644 --- a/drivers/firmware/arm_scmi/protocols.h +++ b/drivers/firmware/arm_scmi/protocols.h @@ -258,6 +258,7 @@ struct scmi_fc_info { * @fastchannel_init: A common helper used to initialize FC descriptors by * gathering FC descriptions from the SCMI platform server. * @fastchannel_db_ring: A common helper to ring a FC doorbell. + * @get_max_msg_size: A common helper to get the maximum message size. */ struct scmi_proto_helpers_ops { int (*extended_name_get)(const struct scmi_protocol_handle *ph, @@ -277,6 +278,7 @@ struct scmi_proto_helpers_ops { struct scmi_fc_db_info **p_db, u32 *rate_limit); void (*fastchannel_db_ring)(struct scmi_fc_db_info *db); + int (*get_max_msg_size)(const struct scmi_protocol_handle *ph); }; =20 /** --=20 2.37.1 From nobody Sun Feb 8 15:01:36 2026 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2063.outbound.protection.outlook.com [40.107.22.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B3001B7F3; Sat, 23 Mar 2024 12:07:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711195658; cv=fail; b=H1DbdmvaAafpYjn75ka1DjY9FMZkHOQWjZm351KwJWoMyRchRc3Gw/VC7vYyvkIOuGBKHDJ5vYreFeoZeI2YinQOrfCgIoifs25sxjcPURy3nydQV/xos36NCjbRAPfykwDgALMj+g4oyqX37N6fbpSUCG5yh3as+BqDo50yVFM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711195658; c=relaxed/simple; bh=VyUgp1uqg2sd9efaIWkIGYr2e4EYKfjV9z7DdHViSYo=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=X+Dze/QGgDtasyWYRQHsZVu+AKzj5ZCRKA+05fzRrWx/1eS89ozR3eExABGpyA9yYusjzFe8NNqL2mGiqTzdY7aN6PeTNrhhUwpAawPVYN6+tL/pUYoniUddHu/kzg3JUwlBNlZlVORMpxNMpaPoWg/qxI7YbBg1dCAPLxd9MuY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=AWSgKFFn; arc=fail smtp.client-ip=40.107.22.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="AWSgKFFn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OZrXoPV1Ox9YoUNPV725caJnTOGcm0bOjIXNPejxkEluYEq+0ZNLRXVZIlTSnoAU/1tnZLJXOOgNUsx029Y1v/7xtDyQt7XjS4SRz6P4fu92gCrv1kr7XkIwM/JsllnZdrpGZMNYmXf7glGcslV3MpJkfpY42QnpGHPBJZ0Wrx4MzJ6Wx/K8yOtcgJpb0wCc8XOkRF32slmKTB6DjV8e2lJMzlwlbpBtFUzrAHpXI4EShMYZSHxsSdicrqB5Ao2plqacNTBZoxVdAiAmX1pDn7TFh9SbXQbSYyHlBxZRuikHCaW/g4z3aUVDAKazPdlActTDP2pHCl6CRhdq41v16w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/BzLovi5aKNOiOuw8s4YMGfV7RBPkidh8VfX3S2pYQ=; b=RT8nJ9OjroTHzLo2WWiFNUtZxE8os0XutrbQkVPdFxwAfzSSLNXQ8sK3/e9e0YsR3EDYD11mBz6cZGMy4aFZR3u7subR1O2NGIeME00LvM5biCXyuuTAVIPhXpjlvwDYa160q6r6xTnEM2UschvzRcce7Xx5W8IIlmWqKtWOlMiQLQ5w1Ve62GBQCIoUuZ89E2xrqJi+aK4tJNLJi0+dZu8KGT26VDoZ1TiALIk9e7gaf1qlHIyQNL2xL8Ma2LNwgv9cw9nkKyA0uM27wyIJYMrg7ch4T9FAVSuVcvXEJA6docW4bgUuGjMCy0MZpczS7BW35IxXFy9R9RlUGZ08hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s/BzLovi5aKNOiOuw8s4YMGfV7RBPkidh8VfX3S2pYQ=; b=AWSgKFFnY7wAIwtFl8pq6kLxVbiYAbmXRJKKKjRGFu9LndmmpWa10axMFJzk8YVqjm8f5873GeZJQ/6yCTK0WNNPVOAIb7JaTkQxhAzg7yqq1hgoyH7yrbsX2ZRSFaeLKM/KFajJCfUh6EqHRPjJcQzm6BGesP37To6DgVsmfpw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by DU0PR04MB9585.eurprd04.prod.outlook.com (2603:10a6:10:316::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.26; Sat, 23 Mar 2024 12:07:34 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.017; Sat, 23 Mar 2024 12:07:34 +0000 From: "Peng Fan (OSS)" Date: Sat, 23 Mar 2024 20:15:15 +0800 Subject: [PATCH v6 2/4] dt-bindings: firmware: arm,scmi: support pinctrl protocol Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240323-pinctrl-scmi-v6-2-a895243257c0@nxp.com> References: <20240323-pinctrl-scmi-v6-0-a895243257c0@nxp.com> In-Reply-To: <20240323-pinctrl-scmi-v6-0-a895243257c0@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1711196144; l=2362; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=1H2rME0+2KWUaw0j7tYsXFokSaYx/bEPhCjn1uDoVYo=; b=yXDqUmMho1q94CJjUWs/Y4/Ta6joF+KXkrSg9P6VrL7fy/5buXTzXtrHYb9IXsx7mpsvaJqLs IjtBKb32BO9DH3eS7YvmO+lBHr7TajyVxhAL5h5s1Ys5b+1CPFBANt9 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR06CA0016.apcprd06.prod.outlook.com (2603:1096:4:186::22) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|DU0PR04MB9585:EE_ X-MS-Office365-Filtering-Correlation-Id: 19f366a0-a17e-4275-119e-08dc4b31d2e2 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: peanjtGePulBqxLzrCc44P9/HoOJ0WD16nGAf9FrMsdt4AA4Hgk8w2F5RHlg9+KqKKgvMMVxYc52t+w/kME/P+ch9GH7IvKn/a3dm7UDAPINymLJDn6GR9JGdoTjOReWhJcZ8qmy6RaScfvRn25emu+iu/ZBgGY3atpJUBU/C/VZiHCCFLNv26AoLCVC5CWx/1GERkNatQ3wEtFRdbwiYBZhM72Up+Or4FbTcl55Kv+YyhPUI9S/EBl7JC0/zhvO3BlPLnp0XMSHkpLYB0VbSNGZ3h8LRioNk6Bzo+Dd5dxoduKHqMowFxXtjHwDtcQ3iHN9xxdirX4muWFyVEfPiN1ofbtl9UzmbXUWhlFj/vtAzHhk9xAPF2mcHV0R2pdCS82D0XPcd+p8fp6ot8YnavBtZ6ZniIns3RZK6Qd7EQZfEtFAEVtf1ljJb/KC+tYBFbIDjEv5vflNQ3nShZE1ujoT70e/PBRlAVMWIsIhYIKYt6jX3Owk77WBjH2f+/vtMBs54wfjeBle3kH98MZRAUUpQYGXc0pKoF/9MALvMKgVojgr1HNjAktCCa6Bs4TzMS+aKotIrQqyFqu5/OMpTL6Oq1N67IcG13LcJkyCEKeOP91/O3V2YItMLLf3Yb/XEMEhkenl+hnsGLeuWk8zA7vyl5cHfIqDvq2BTGoK1jUFKqbx5Z3PHbtfrvb9FoS5lkLc49ll30PGAkQvGt9aDG2L4gtlDsI7n0/dp00bMiw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(52116005)(7416005)(1800799015)(376005)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDB2clFYVTBtYy9IL3JwYURDTjlPSUpkT2ovallrc2xTT3BUM2NuUk0xOE5t?= =?utf-8?B?VlRlejlDSTNiSHFENGI4RnNXUVVUREt2M0pzUHVzU3VlU0hKaWhYR3FGZnhj?= =?utf-8?B?S0l2WWJ6dXVUMllYZ3hkNlBpNWo1cDRXeEhLakJhYU9Ra1I3MzlTbFplNkgx?= =?utf-8?B?QjVnWG52WGpUWGRNdWZPTThiWnNSdTBJN2h2OUxOdzY2ZzJPK1dickR6STVv?= =?utf-8?B?aElkWFZBd3JpOXk3Y1JvOHNWZVovTEMvQSs4Z1pnaTgzVW9KTHFOZ29HY1NE?= =?utf-8?B?eUdBS05aWDhOUFlFWEpOeThGRzV6WmVKck5CMVR6aGFLQStCK09WbFFVZjBD?= =?utf-8?B?REFEcWFvcTMwS0FLSHl2azViSCtUTkt2QWgzWnVtaXFKbVdDaTdTa0IyUW5p?= =?utf-8?B?L2srSXo2UGh0anpoN0pxaWdKdCthWFhCWWxWNENtcVFnenJFcGRZL2pQOFYv?= =?utf-8?B?YnlKL0NoTVhXaFhvRWZKWGhzeTEwazdRWU14OXBtdUxIdW9USjMwNHBWaHYr?= =?utf-8?B?TERlbktwQjZVbFVDRmF4YktWZUZuejJYckpNQ3JrNjZGdmJqRjR1K1Vla3Fp?= =?utf-8?B?NVdBNGx4cXd2SHJxOHJUd0crK2VtSWZWWUVpU2JpNHJMZTZFQWsrNjEycXh1?= =?utf-8?B?b3BzUDFLcFpCVEVTckRjUmV3aERpN0VFeGN1ZUxKaTVIbThTemlFNGwyOGRU?= =?utf-8?B?RC8zck1rak5xS1N0eUZCMFNKNjJra1E0VWVTQW56UXU4bmtyVjNBa0h2SVVl?= =?utf-8?B?TExuU0VMMTZaUnk0OFMwTElyZk5TQXROMmR0Q0lHNnNOd3k3KzdQdkRkakk0?= =?utf-8?B?WGJ2M01tOVRsUTNTVkNrT01rZkk2NldTWW5Ra3hsenJOOUpxZEQ1T3ZCMk1Y?= =?utf-8?B?ZnVxVFh5cXRNTEplZCtDa0dzTDNBSURTcnRldWc4S3MxeVcxSnFiRHkwNmpn?= =?utf-8?B?c0E5aXIrL29WelBodWw2emFWclNrRUkyMEEzdW1aU25lRUFjNWFqTUx4MnpC?= =?utf-8?B?WWFKVTJnbmpWd0dPYWZjNHJLL0F2MXE1cFhTMEtpU2IwZEdTaWRwZ1BwOUwz?= =?utf-8?B?OGYxeEplM2lSay8yVTF1UHlWWVFOMmJTdk9sZXI0QkVXdWQzRGRPVnJvakNv?= =?utf-8?B?MmxxSWJvZ0pUZk5EbmFhVzEyMjFHUzhUUEpGYkhrYzc0YW42M2pUdjBWR3Vu?= =?utf-8?B?dkJ5NmM1S3QzSC92ZFB2S1BYZDJnRzA2UTFBSUc5cG05TE16Ky9WMWx0QU9E?= =?utf-8?B?SmNNR1dLRmtjZ0lRelhLZXlJRW9QUmxRSkVlUVZ4UXBFNFNXTHNnREdsaWxs?= =?utf-8?B?ajB1bGp1M3YwU290SnBZVTlYUXUzYTBOQjBPQWJBK0daRXQyU2U4N3p3dk84?= =?utf-8?B?cU9pSTEzU2J2SmZYeFpaT0xwTzR3Z2c3ZVNRSWZmcDk0YUExa3RTZEtVRGY0?= =?utf-8?B?TU8rV1BXR3FaK2dwdnZGT3dIditjUktJc2RyaWczOEphYW56SlNqczM0a05V?= =?utf-8?B?MmdkcXF3ZTlkWVVHUkt3czJyazJ5OWpkOEhjeWovakEzU1NPbFBSNWZybHhw?= =?utf-8?B?VDBWUmlQNk8yKzZSZ2w1Uk13OGZab2ZNQ2ZST3I5Q0VhQzVQYXNOZ1QwRCtj?= =?utf-8?B?QlpnckhzZHhuUmU4U0x3SmpVTlc1VndaeU10dDYxdm1XTmpNdmpNam9BR3Fu?= =?utf-8?B?VkE4QXlpWWtBRWdmalJEWWVEcHY4NHRtWHJHMjlwMlBQZHFBb3VXMXI0VDlZ?= =?utf-8?B?NWVyU2hHUnB0TFFBZmI4YU9nMzk5VjFrYWJOQ2I4N2JtT2lpdVQ2ZDFBSHdh?= =?utf-8?B?bXRCTUIzUVpaOXVhUExCM1d4WVN6dk9mSy9YbUZ5NGZPNWtiQTBod0x5akl2?= =?utf-8?B?SG5yZTZheFZFSjZkaGY5bENZd3N4SmJNV0l6T0pka2d6VzNjNU14ZmYyTlFF?= =?utf-8?B?VnAxdXoyUmRYSk9xYUNNVEkzM2U5TUZxTnphQmR0ZEIySWpYNFg1RFFZa01q?= =?utf-8?B?Zi9nMGF2aTlPcVZNU1p5c2VnTWtvUzdyU1pBWXI2N1dtTEQ1dnI4ZWpvQUsz?= =?utf-8?B?Z3E3T1Q3b3laeW5YNFJ0T0x5Q3RSOEVPdGMzVjFOYWtWN1ZQUS9ESmpZdVBQ?= =?utf-8?Q?pz2QeTxTrbaFQkmI1O6v+V4vu?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19f366a0-a17e-4275-119e-08dc4b31d2e2 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2024 12:07:34.4095 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6GrA2U0ozlBnF0LQ6brQRQgSBryX8T/khWWcJm4Vjwx30FCQPSZKUDEnjna25+S65UW57mJstrd3w3D3PsjADg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9585 From: Peng Fan Add SCMI v3.2 pinctrl protocol bindings and example. Reviewed-by: Rob Herring Reviewed-by: Linus Walleij Signed-off-by: Peng Fan --- .../devicetree/bindings/firmware/arm,scmi.yaml | 50 ++++++++++++++++++= ++++ 1 file changed, 50 insertions(+) diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Doc= umentation/devicetree/bindings/firmware/arm,scmi.yaml index 4591523b51a0..e9d3f043c4ed 100644 --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml @@ -247,6 +247,37 @@ properties: reg: const: 0x18 =20 + protocol@19: + type: object + allOf: + - $ref: '#/$defs/protocol-node' + - $ref: /schemas/pinctrl/pinctrl.yaml + + unevaluatedProperties: false + + properties: + reg: + const: 0x19 + + patternProperties: + '-pins$': + type: object + allOf: + - $ref: /schemas/pinctrl/pincfg-node.yaml# + - $ref: /schemas/pinctrl/pinmux-node.yaml# + unevaluatedProperties: false + + description: + A pin multiplexing sub-node describes how to configure a + set of pins in some desired function. + A single sub-node may define several pin configurations. + This sub-node is using the default pinctrl bindings to configure + pin multiplexing and using SCMI protocol to apply a specified + configuration. + + required: + - reg + additionalProperties: false =20 $defs: @@ -401,6 +432,25 @@ examples: scmi_powercap: protocol@18 { reg =3D <0x18>; }; + + scmi_pinctrl: protocol@19 { + reg =3D <0x19>; + + i2c2-pins { + groups =3D "g_i2c2_a", "g_i2c2_b"; + function =3D "f_i2c2"; + }; + + mdio-pins { + groups =3D "g_avb_mdio"; + drive-strength =3D <24>; + }; + + keys_pins: keys-pins { + pins =3D "gpio_5_17", "gpio_5_20", "gpio_5_22", "gpio_= 2_1"; + bias-pull-up; + }; + }; }; }; =20 --=20 2.37.1 From nobody Sun Feb 8 15:01:36 2026 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2054.outbound.protection.outlook.com [40.107.6.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C6D13D0B9; Sat, 23 Mar 2024 12:07:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.6.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711195664; cv=fail; b=jSBPx67374v0T3Qm1oxGcs8DSkjTaYBEz9+uBeAVB5dqyJea4c9OPqJB6DcUuyDrQux24BolB78D6ESuFrEWA5tXYK3vZ9f/r1SLh+2lD2KH8BQr6eEJBbAkT/f1hfVF16Z5wbdEfPnZMSZHlCd4HkBgWC+5HiiHXfE8Vsc34cM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711195664; c=relaxed/simple; bh=6iY83JrrvGcb22Cnn615upBS9CMBA5OumWERxH8qfXo=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Rvjas0/HcbFOLFqG/y0+ikmTGPJLz2O1IAWB/pIpBkdH58HJCuAayCC3dEZ1/6XSgTBnmrnkcqx5vz3EtWiyrGV7OXMnWzh3nQ2TV4QKA7osFvhVuDzyhStBofDL3HXRe9VTm1ElDXZ5HGxe3njw3iCDellZQcR57wm7Q0qud1I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Ym7wp2f0; arc=fail smtp.client-ip=40.107.6.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Ym7wp2f0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DF+BuFG8KV/kRp0mScuUrc4ITUnD8Ph811M07N+NyDvRC+kk/l7pnGuEhc1f8iGWMOnFjzsCt/uDR3KfH2Uwpk4WKgwuME+Gq+ncfsAA7cOTvVxLJaH7Fv8DhR3LTlPbtdSMng3k7ariougHU/6VaGhRf/odP+IewKP1YdhxUGZkyfaWyZAMacolECqnez6jtZMZpgnyiGw2Rke3gsdpGH3QP4krMckiyRUs92x1hRNbvNL9d1ugN2cxEzYpE7TtWuebidwg2t+E0nDOYsxzhrw50ID0APWaeeZku7rAjWirIbV8f244FtIdW+3xlpAqnlYKA3eOXE5BtClq+EWFeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0W27TpMhgY/YI6AuFaAnNekWgbykmCcfjtmlhPY/368=; b=gKzCPGZQ2CbelzJdzFmD6StkOEMr7ISoH/xt1qblvRxj2sniNVkXp3R9lioCHI4u3icXQBHkUDdkUV6nKq+NxjG9C3TGBSk7VpVNzG6Tq66wwNynSJwGvvC3By2BeTYwUqqAEUewL5Qeyx5KLAJchl+iEWPsgIKpUpdm/1QFG7mdJp0TW/sT9sF5TH8EzbYZXD+SUU1670q54F7moDndH4oP1B1qzYeslDg2CWmOXZO7S/nbaV3m5ysCeCXLQz6ka3WEHOJwuzOHA3PCPNyM6kp4iS+s19Oi9nF4DYOFHUgJUCaWo24LzORETGGRZMmXyeZKbW53btEFQM3izeblow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0W27TpMhgY/YI6AuFaAnNekWgbykmCcfjtmlhPY/368=; b=Ym7wp2f08M5nwBljyShW2I2kHO/KfH5snE6JFYJ1kALza6PXy2fZSQM1H1HyT/RvYsFv/n5ztxVlEtMepNBFl3oafAgjBuMZHQERHV5VFsWpOgJl/UoBPzSx6JsCJXMf/TIqwshX4xl+JWbTz5AZ48NY3lxvZauJBlopWQoMoDw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by DU0PR04MB9585.eurprd04.prod.outlook.com (2603:10a6:10:316::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.26; Sat, 23 Mar 2024 12:07:38 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.017; Sat, 23 Mar 2024 12:07:38 +0000 From: "Peng Fan (OSS)" Date: Sat, 23 Mar 2024 20:15:16 +0800 Subject: [PATCH v6 3/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240323-pinctrl-scmi-v6-3-a895243257c0@nxp.com> References: <20240323-pinctrl-scmi-v6-0-a895243257c0@nxp.com> In-Reply-To: <20240323-pinctrl-scmi-v6-0-a895243257c0@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan , Oleksii Moisieiev X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1711196144; l=29007; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=8G94Udew3uI9UTCk8ZfwJwD1xyZ3uGcFc7OVM/iwQbI=; b=XghEVGNguvdXINQQRvFSQPrOHG1PizjcsyW+OcQlIJhnhTfDXPdkCLMYhFmfnEH2DrZ9snD7h l2vAve4CcaqBPJJEAKJYgM9n3fIcOlQFd132iUOBxQjYdHwTbItS7Vv X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR06CA0016.apcprd06.prod.outlook.com (2603:1096:4:186::22) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|DU0PR04MB9585:EE_ X-MS-Office365-Filtering-Correlation-Id: d7d3b143-05cb-4841-89e9-08dc4b31d552 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ddI1N/xtvdr8EZv8RtZoIU7Te4Mmq89ZK/RTAUGWxK/ZvstPCevqgkDciIWfWj/Ln0v71XzxHFNUhu8D1CgWSFcYIIwEshQk1tnATcsUBfjxp2hTpb+4jwv5M2+t5dfnjJ8KOxfYyNpwaugA8U87uPKxKkIiylWyoDvIZd0VEgLvOlHnKs2PYD2HvTnOliNVeknNPJu8LObcYP9I6bIWTd2FLtpXj7Q1iDv2TTdxM9jZ4gYtnJcMPQeP39FnyWEkCU5Urcvhv/gdXVAtvcKzVzMHbGuefQoV4LdlVwackE44UTnusiE5VlphbapzRDWyQMNwwUPmp6irJE1gwoOsHhn5V+xb87VeH1gjx/8wCd11KYTct0wu8VOslujhCyTGE1J9ums5/XWJqo78/rw6mLvMgsR2Ihc0Mm6pH/2EmN0DWQYfnJP3vyYqQY2BCl8rRbD3uDP0qahB1UsSzcxWz9Qo3KlreowzgmtWAhlUWOdF0IKJ0E5rrhpEdNUYa9Oi97ODXIFS+MwsUwDmiEDk9sYY3p5qSUX0Qg+7l7xHEeHSR9g2rGO+penUPU8Ms4HJ6ItXmgZHhwoxrgyKOTxUceav4s9XkneucRwFRNG8Y2+PVy9B2hOfNFv0NIHjQoGudG8NyOPyCvYEZPpel799SPFNTIZxo1kCpCNJGRKzk5KM2Jol7B2kyMIC/9NHF9jfT+oZbdoT4Q70r9ISo+zA5yKSOuF/CbeeivRMRmYvbLU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(52116005)(7416005)(1800799015)(376005)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0o3aS9uaVlMcStiRi9GRGxUak5XY09jV1NPR2gvclFKcFZ3TkRUbFJZZG1I?= =?utf-8?B?RmgrU0o5ZFhXK0pEZ0F4L1B6NTBNeVVUakhxU0V5OGVtb05mSGRFSDNCVHpO?= =?utf-8?B?anVKSjR2eVAzYnAwZ2JrVURKcWNPMExCWExuRDRZOTZ3c250QUxXRnliZTBs?= =?utf-8?B?aW4zNUxqT3crRUQyaHA4NjQ2eEh5bE1GajNtcm9CbG1FbVYwMm9qLzN5b0NP?= =?utf-8?B?eUhPbm9RbHRLcDViVzk0clVKQW1tUHZDMmo1NFk3Q0pvbm9JUGZzRkxVYlVS?= =?utf-8?B?SUNOTmNQRFRYaHlIMDdYSXU5OFJ1REF5bWFjTXFxeUlTc283c0ovdDhEYzJh?= =?utf-8?B?M0RWQm5SYndBdlJ0djFqalhCenBlVXljQnprbDNuTDErOGViVEFmckh3RGxx?= =?utf-8?B?K05uYkVpNG5MQ2wxcXNjUXkrRUVjSGRFc1lMVG1pbzRKd1dVUjAxUXFWVlZH?= =?utf-8?B?WXRNRE5za2dhSnpJZWJBR1ZMRUIxbWlzUisrQ1VBU1c0NjlyMzMva0NWbnU5?= =?utf-8?B?NjBRdGV0dUpyNmt4ZU0vUXBBbUZGaU8xYkhaYjZhRXNSd0lxK28vMjlJb2xV?= =?utf-8?B?UXk4QTJYdmt1YkxuZjhpeWFyY2U1SkFidHhNQW1GWlhEaFVicWR0eWNGWEVl?= =?utf-8?B?cm1MZlUveWplcGJvdUZ0ZUx4R1F6QkN2U2FFS3RSUTNtK1VvQjd4MFY5T05K?= =?utf-8?B?Z21DSTFON1FZQ3lIUFAwV2MxREhjTmtiK1U0eGVYWHM3KzlZOVdqOXNVb0lS?= =?utf-8?B?akZnOGplWCt2THloOE9jSGVKSG0wZjVYT29pUFlXd3pYNnI3bDVIUDhFK2FV?= =?utf-8?B?S05RS0M3Nmpscm41K1FEK1ZvRERiWk9iWFBXb2phZWdyZUFqWXZTRWdhcUlT?= =?utf-8?B?MlB5VXJEQUMyOFNEUzlmN001UWxRVDRES25oM25LbUV4T28vNDlCK0tLK0VM?= =?utf-8?B?dzVxR0haRzduZUkwNG53em9idnc0S1ZoMXBRRHE1M0tWU1B6NVlmV2E5UFB3?= =?utf-8?B?OFAybk9zOUg4M3VDMUNQejhLMFgvaUI5eDVVZUFYbWd4a0FqVktVK3p4bFRO?= =?utf-8?B?NmpZbWdBNXl1aEZDTVBNcGYrNE9JQlJ4LzUvMnUxQTFwMG5zK1pYZlFPelJY?= =?utf-8?B?SXkxa1NtME5iVVlER1l2VlROQUxwbGN6VVAwd0dCM05xbHQycEk3VlFpeVEz?= =?utf-8?B?ZXR3WlU0UXRUSnJQaXdmaHRFNDdaNUV2QUV6bDgvOVdrb1JEZ3JpbjlNM0Zt?= =?utf-8?B?NFpBVFB2UyswVzB2QmlwdUt4ckRSLzUzRkZ4eTlCbVRnQm9Ocmxocjg1Y1VT?= =?utf-8?B?UVFrT01uaHZpM0thM1M3eENkZ0ZZdFpDb2pFSE5nZ0ltZ1c4ejdXUEFYYXBu?= =?utf-8?B?UFBuZUVXbmVwM3BPK1FzbVVEbkt3M0g3bCszdWR0L1hSM2VIVUJzUDF6Z3U0?= =?utf-8?B?Tmxlc1Z1OU1lYmN3ZWVxZFJobjRkWDVvMTJtaHI2VHdaK1UzVlY1WXhPMGdw?= =?utf-8?B?OC82N1FIQXR3YTlQK1NPRUJhWnZHQ2lybTJOVzBSSVZqTjhFeGl0WGpQbkY5?= =?utf-8?B?Uk04YkR4cGtDMy9MbWdUQWZzUTZVS1k4TUhUTjRwaHpmZURPNVFwZDJRbEVB?= =?utf-8?B?YWhUWUpBRHI2bk5ib2ZoSis4cVdHVEdCRGFyQnZaZDFQMWxVSGpMdi9nUDdH?= =?utf-8?B?cUV5d1BzMGdQV0tUcGZkcDduNk9mdEZWaXBodU5ibTliNnpLTVNMcjFzMEVO?= =?utf-8?B?a1U4Z2VTWkRYTGMreUhITElreXphWWZNbzVuem5nT2tzMFYwSktzTE9ESnZv?= =?utf-8?B?K2tBeXhWNHdGVWJFUDZXYnU0RXhyUEpHcFFBZG96U0ZzM1pqQTdDd3hhMW1N?= =?utf-8?B?WXZKbjl5alAvdk5iNjBMdDMzOEo4UkhCd1Vvd0JOUm96T1kvbDZOTE1rN1d2?= =?utf-8?B?YzhqUFRzV2xiZEdwSXM1QjJycXV2SWVRamVnaHlrekUrN05raWY1T0QvRnpP?= =?utf-8?B?NmZTRmtsZ0IzTFZOSUxnY0Z4RnVJYnd3WXJ0WmJ3K2d4cDRITGZjWWt2NlJX?= =?utf-8?B?TDA3UDFFQWRndGp0MWxBK3JKVXNQYy9PdXQvRkh6N0tiV01qaFVUT1ZFQm8r?= =?utf-8?Q?/Uc0pDfpwEo4+sC/85YChkG6O?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7d3b143-05cb-4841-89e9-08dc4b31d552 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2024 12:07:38.5232 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fskmtEzB/r3AvVawzJZufKiz6erBc1hosnIlhRg6IGJdiB8ygarRgbPeVQNHPU69G6O0IK95hI7KminAwCZZCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9585 From: Peng Fan Add basic implementation of the SCMI v3.2 pincontrol protocol. Co-developed-by: Oleksii Moisieiev Signed-off-by: Oleksii Moisieiev Signed-off-by: Peng Fan --- drivers/firmware/arm_scmi/Makefile | 1 + drivers/firmware/arm_scmi/driver.c | 2 + drivers/firmware/arm_scmi/pinctrl.c | 921 ++++++++++++++++++++++++++++++= ++++ drivers/firmware/arm_scmi/protocols.h | 1 + include/linux/scmi_protocol.h | 75 +++ 5 files changed, 1000 insertions(+) diff --git a/drivers/firmware/arm_scmi/Makefile b/drivers/firmware/arm_scmi= /Makefile index a7bc4796519c..8e3874ff1544 100644 --- a/drivers/firmware/arm_scmi/Makefile +++ b/drivers/firmware/arm_scmi/Makefile @@ -11,6 +11,7 @@ scmi-transport-$(CONFIG_ARM_SCMI_HAVE_MSG) +=3D msg.o scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_VIRTIO) +=3D virtio.o scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_OPTEE) +=3D optee.o scmi-protocols-y =3D base.o clock.o perf.o power.o reset.o sensors.o syste= m.o voltage.o powercap.o +scmi-protocols-y +=3D pinctrl.o scmi-module-objs :=3D $(scmi-driver-y) $(scmi-protocols-y) $(scmi-transpor= t-y) =20 obj-$(CONFIG_ARM_SCMI_PROTOCOL) +=3D scmi-core.o diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi= /driver.c index 415e6f510057..ac2d4b19727c 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -3142,6 +3142,7 @@ static int __init scmi_driver_init(void) scmi_voltage_register(); scmi_system_register(); scmi_powercap_register(); + scmi_pinctrl_register(); =20 return platform_driver_register(&scmi_driver); } @@ -3159,6 +3160,7 @@ static void __exit scmi_driver_exit(void) scmi_voltage_unregister(); scmi_system_unregister(); scmi_powercap_unregister(); + scmi_pinctrl_unregister(); =20 scmi_transports_exit(); =20 diff --git a/drivers/firmware/arm_scmi/pinctrl.c b/drivers/firmware/arm_scm= i/pinctrl.c new file mode 100644 index 000000000000..87d9b89cab13 --- /dev/null +++ b/drivers/firmware/arm_scmi/pinctrl.c @@ -0,0 +1,921 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * System Control and Management Interface (SCMI) Pinctrl Protocol + * + * Copyright (C) 2024 EPAM + * Copyright 2024 NXP + */ + +#include +#include +#include + +#include "common.h" +#include "protocols.h" + +/* Updated only after ALL the mandatory features for that version are merg= ed */ +#define SCMI_PROTOCOL_SUPPORTED_VERSION 0x0 + +#define GET_GROUPS_NR(x) le32_get_bits((x), GENMASK(31, 16)) +#define GET_PINS_NR(x) le32_get_bits((x), GENMASK(15, 0)) +#define GET_FUNCTIONS_NR(x) le32_get_bits((x), GENMASK(15, 0)) + +#define EXT_NAME_FLAG(x) le32_get_bits((x), BIT(31)) +#define NUM_ELEMS(x) le32_get_bits((x), GENMASK(15, 0)) + +#define REMAINING(x) le32_get_bits((x), GENMASK(31, 16)) +#define RETURNED(x) le32_get_bits((x), GENMASK(11, 0)) + +#define CONFIG_FLAG_MASK GENMASK(19, 18) +#define SELECTOR_MASK GENMASK(17, 16) +#define SKIP_CONFIGS_MASK GENMASK(15, 8) +#define CONFIG_TYPE_MASK GENMASK(7, 0) + +enum scmi_pinctrl_protocol_cmd { + PINCTRL_ATTRIBUTES =3D 0x3, + PINCTRL_LIST_ASSOCIATIONS =3D 0x4, + PINCTRL_SETTINGS_GET =3D 0x5, + PINCTRL_SETTINGS_CONFIGURE =3D 0x6, + PINCTRL_REQUEST =3D 0x7, + PINCTRL_RELEASE =3D 0x8, + PINCTRL_NAME_GET =3D 0x9, + PINCTRL_SET_PERMISSIONS =3D 0xa +}; + +struct scmi_msg_settings_conf { + __le32 identifier; + __le32 function_id; + __le32 attributes; + __le32 configs[]; +}; + +struct scmi_msg_settings_get { + __le32 identifier; + __le32 attributes; +}; + +struct scmi_resp_settings_get { + __le32 function_selected; + __le32 num_configs; + __le32 configs[]; +}; + +struct scmi_msg_pinctrl_protocol_attributes { + __le32 attributes_low; + __le32 attributes_high; +}; + +struct scmi_msg_pinctrl_attributes { + __le32 identifier; + __le32 flags; +}; + +struct scmi_resp_pinctrl_attributes { + __le32 attributes; + u8 name[SCMI_SHORT_NAME_MAX_SIZE]; +}; + +struct scmi_msg_pinctrl_list_assoc { + __le32 identifier; + __le32 flags; + __le32 index; +}; + +struct scmi_resp_pinctrl_list_assoc { + __le32 flags; + __le16 array[]; +}; + +struct scmi_msg_func_set { + __le32 identifier; + __le32 function_id; + __le32 flags; +}; + +struct scmi_msg_request { + __le32 identifier; + __le32 flags; +}; + +struct scmi_group_info { + char name[SCMI_MAX_STR_SIZE]; + bool present; + u32 *group_pins; + u32 nr_pins; +}; + +struct scmi_function_info { + char name[SCMI_MAX_STR_SIZE]; + bool present; + u32 *groups; + u32 nr_groups; +}; + +struct scmi_pin_info { + char name[SCMI_MAX_STR_SIZE]; + bool present; +}; + +struct scmi_pinctrl_info { + u32 version; + int nr_groups; + int nr_functions; + int nr_pins; + struct scmi_group_info *groups; + struct scmi_function_info *functions; + struct scmi_pin_info *pins; +}; + +static int scmi_pinctrl_attributes_get(const struct scmi_protocol_handle *= ph, + struct scmi_pinctrl_info *pi) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_pinctrl_protocol_attributes *attr; + + ret =3D ph->xops->xfer_get_init(ph, PROTOCOL_ATTRIBUTES, 0, sizeof(*attr), + &t); + if (ret) + return ret; + + attr =3D t->rx.buf; + + ret =3D ph->xops->do_xfer(ph, t); + if (!ret) { + pi->nr_functions =3D GET_FUNCTIONS_NR(attr->attributes_high); + pi->nr_groups =3D GET_GROUPS_NR(attr->attributes_low); + pi->nr_pins =3D GET_PINS_NR(attr->attributes_low); + } + + ph->xops->xfer_put(ph, t); + return ret; +} + +static int scmi_pinctrl_count_get(const struct scmi_protocol_handle *ph, + enum scmi_pinctrl_selector_type type) +{ + struct scmi_pinctrl_info *pi =3D ph->get_priv(ph); + + switch (type) { + case PIN_TYPE: + return pi->nr_pins; + case GROUP_TYPE: + return pi->nr_groups; + case FUNCTION_TYPE: + return pi->nr_functions; + default: + return -EINVAL; + } +} + +static int scmi_pinctrl_validate_id(const struct scmi_protocol_handle *ph, + u32 identifier, + enum scmi_pinctrl_selector_type type) +{ + int value; + + value =3D scmi_pinctrl_count_get(ph, type); + if (value < 0) + return value; + + if (identifier >=3D value) + return -EINVAL; + + return 0; +} + +static int scmi_pinctrl_attributes(const struct scmi_protocol_handle *ph, + enum scmi_pinctrl_selector_type type, + u32 selector, char *name, + u32 *n_elems) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_pinctrl_attributes *tx; + struct scmi_resp_pinctrl_attributes *rx; + u32 ext_name_flag; + + if (!name) + return -EINVAL; + + ret =3D scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + ret =3D ph->xops->xfer_get_init(ph, PINCTRL_ATTRIBUTES, sizeof(*tx), + sizeof(*rx), &t); + if (ret) + return ret; + + tx =3D t->tx.buf; + rx =3D t->rx.buf; + tx->identifier =3D cpu_to_le32(selector); + tx->flags =3D cpu_to_le32(type); + + ret =3D ph->xops->do_xfer(ph, t); + if (!ret) { + if (n_elems) + *n_elems =3D NUM_ELEMS(rx->attributes); + + strscpy(name, rx->name, SCMI_SHORT_NAME_MAX_SIZE); + + ext_name_flag =3D EXT_NAME_FLAG(rx->attributes); + } else + ext_name_flag =3D 0; + + ph->xops->xfer_put(ph, t); + + /* + * If supported overwrite short name with the extended one; + * on error just carry on and use already provided short name. + */ + if (!ret && ext_name_flag) + ph->hops->extended_name_get(ph, PINCTRL_NAME_GET, selector, + (u32 *)&type, name, + SCMI_MAX_STR_SIZE); + return ret; +} + +struct scmi_pinctrl_ipriv { + u32 selector; + enum scmi_pinctrl_selector_type type; + u32 *array; +}; + +static void iter_pinctrl_assoc_prepare_message(void *message, + u32 desc_index, + const void *priv) +{ + struct scmi_msg_pinctrl_list_assoc *msg =3D message; + const struct scmi_pinctrl_ipriv *p =3D priv; + + msg->identifier =3D cpu_to_le32(p->selector); + msg->flags =3D cpu_to_le32(p->type); + /* Set the number of OPPs to be skipped/already read */ + msg->index =3D cpu_to_le32(desc_index); +} + +static int iter_pinctrl_assoc_update_state(struct scmi_iterator_state *st, + const void *response, void *priv) +{ + const struct scmi_resp_pinctrl_list_assoc *r =3D response; + + st->num_returned =3D RETURNED(r->flags); + st->num_remaining =3D REMAINING(r->flags); + + return 0; +} + +static int +iter_pinctrl_assoc_process_response(const struct scmi_protocol_handle *ph, + const void *response, + struct scmi_iterator_state *st, void *priv) +{ + const struct scmi_resp_pinctrl_list_assoc *r =3D response; + struct scmi_pinctrl_ipriv *p =3D priv; + + p->array[st->desc_index + st->loop_idx] =3D + le16_to_cpu(r->array[st->loop_idx]); + + return 0; +} + +static int scmi_pinctrl_list_associations(const struct scmi_protocol_handl= e *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + u16 size, u32 *array) +{ + int ret; + void *iter; + struct scmi_iterator_ops ops =3D { + .prepare_message =3D iter_pinctrl_assoc_prepare_message, + .update_state =3D iter_pinctrl_assoc_update_state, + .process_response =3D iter_pinctrl_assoc_process_response, + }; + struct scmi_pinctrl_ipriv ipriv =3D { + .selector =3D selector, + .type =3D type, + .array =3D array, + }; + + if (!array || !size || type =3D=3D PIN_TYPE) + return -EINVAL; + + ret =3D scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + iter =3D ph->hops->iter_response_init(ph, &ops, size, + PINCTRL_LIST_ASSOCIATIONS, + sizeof(struct scmi_msg_pinctrl_list_assoc), + &ipriv); + + if (IS_ERR(iter)) + return PTR_ERR(iter); + + return ph->hops->iter_response_run(iter); +} + +struct scmi_settings_get_ipriv { + u32 selector; + enum scmi_pinctrl_selector_type type; + u32 flag; + enum scmi_pinctrl_conf_type *config_types; + u32 *config_values; +}; + +static void +iter_pinctrl_settings_get_prepare_message(void *message, u32 desc_index, + const void *priv) +{ + struct scmi_msg_settings_get *msg =3D message; + const struct scmi_settings_get_ipriv *p =3D priv; + u32 attributes; + + attributes =3D FIELD_PREP(CONFIG_FLAG_MASK, p->flag) | + FIELD_PREP(SELECTOR_MASK, p->type); + + if (p->flag =3D=3D 1) + attributes |=3D FIELD_PREP(SKIP_CONFIGS_MASK, desc_index); + else if (!p->flag) + attributes |=3D FIELD_PREP(CONFIG_TYPE_MASK, p->config_types[0]); + + msg->attributes =3D cpu_to_le32(attributes); + msg->identifier =3D cpu_to_le32(p->selector); +} + +static int +iter_pinctrl_settings_get_update_state(struct scmi_iterator_state *st, + const void *response, void *priv) +{ + const struct scmi_resp_settings_get *r =3D response; + struct scmi_settings_get_ipriv *p =3D priv; + + if (p->flag =3D=3D 1) { + st->num_returned =3D le32_get_bits(r->num_configs, GENMASK(7, 0)); + st->num_remaining =3D le32_get_bits(r->num_configs, + GENMASK(31, 24)); + } else { + st->num_returned =3D 1; + st->num_remaining =3D 0; + } + + return 0; +} + +static int +iter_pinctrl_settings_get_process_response(const struct scmi_protocol_hand= le *ph, + const void *response, + struct scmi_iterator_state *st, + void *priv) +{ + const struct scmi_resp_settings_get *r =3D response; + struct scmi_settings_get_ipriv *p =3D priv; + + if (!p->flag) { + if (p->config_types[0] !=3D + le32_get_bits(r->configs[st->loop_idx * 2], GENMASK(7, 0))) + return -EINVAL; + } else if (p->flag =3D=3D 1) { + p->config_types[st->desc_index + st->loop_idx] =3D + le32_get_bits(r->configs[st->loop_idx * 2], + GENMASK(7, 0)); + } else if (p->flag =3D=3D 2) { + return 0; + } + + p->config_values[st->desc_index + st->loop_idx] =3D + le32_to_cpu(r->configs[st->loop_idx * 2 + 1]); + + return 0; +} + +static int +scmi_pinctrl_settings_get(const struct scmi_protocol_handle *ph, u32 selec= tor, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_conf_type config_type, + u32 *config_value) +{ + int ret; + void *iter; + struct scmi_iterator_ops ops =3D { + .prepare_message =3D iter_pinctrl_settings_get_prepare_message, + .update_state =3D iter_pinctrl_settings_get_update_state, + .process_response =3D iter_pinctrl_settings_get_process_response, + }; + struct scmi_settings_get_ipriv ipriv =3D { + .selector =3D selector, + .type =3D type, + .flag =3D 0, + .config_types =3D &config_type, + .config_values =3D config_value, + }; + + if (!config_value || type =3D=3D FUNCTION_TYPE) + return -EINVAL; + + ret =3D scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + iter =3D ph->hops->iter_response_init(ph, &ops, 1, PINCTRL_SETTINGS_GET, + sizeof(struct scmi_msg_settings_get), + &ipriv); + + if (IS_ERR(iter)) + return PTR_ERR(iter); + + return ph->hops->iter_response_run(iter); +} + +static int +scmi_pinctrl_settings_conf(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + u32 nr_configs, + enum scmi_pinctrl_conf_type *config_type, + u32 *config_value) +{ + struct scmi_xfer *t; + struct scmi_msg_settings_conf *tx; + u32 attributes; + int ret, i; + u32 configs_in_chunk, conf_num =3D 0; + u32 chunk; + int max_msg_size =3D ph->hops->get_max_msg_size(ph); + + if (!config_type || !config_value || type =3D=3D FUNCTION_TYPE) + return -EINVAL; + + ret =3D scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + configs_in_chunk =3D (max_msg_size - sizeof(*tx)) / (sizeof(__le32) * 2); + while (conf_num < nr_configs) { + chunk =3D (nr_configs - conf_num > configs_in_chunk) ? + configs_in_chunk : nr_configs - conf_num; + + ret =3D ph->xops->xfer_get_init(ph, PINCTRL_SETTINGS_CONFIGURE, + sizeof(*tx) + + chunk * 2 * sizeof(__le32), + 0, &t); + if (ret) + return ret; + + tx =3D t->tx.buf; + tx->identifier =3D cpu_to_le32(selector); + attributes =3D FIELD_PREP(GENMASK(1, 0), type) | + FIELD_PREP(GENMASK(9, 2), chunk); + tx->attributes =3D cpu_to_le32(attributes); + + for (i =3D 0; i < chunk; i++) { + tx->configs[i * 2] =3D + cpu_to_le32(config_type[conf_num + i]); + tx->configs[i * 2 + 1] =3D + cpu_to_le32(config_value[conf_num + i]); + } + + ret =3D ph->xops->do_xfer(ph, t); + + ph->xops->xfer_put(ph, t); + + if (ret) + break; + + conf_num +=3D chunk; + } + + return ret; +} + +static int scmi_pinctrl_function_select(const struct scmi_protocol_handle = *ph, + u32 group, + enum scmi_pinctrl_selector_type type, + u32 function_id) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_settings_conf *tx; + u32 attributes; + + ret =3D scmi_pinctrl_validate_id(ph, group, type); + if (ret) + return ret; + + ret =3D ph->xops->xfer_get_init(ph, PINCTRL_SETTINGS_CONFIGURE, + sizeof(*tx), 0, &t); + if (ret) + return ret; + + tx =3D t->tx.buf; + tx->identifier =3D cpu_to_le32(group); + tx->function_id =3D cpu_to_le32(function_id); + attributes =3D FIELD_PREP(GENMASK(1, 0), type) | BIT(10); + tx->attributes =3D cpu_to_le32(attributes); + + ret =3D ph->xops->do_xfer(ph, t); + ph->xops->xfer_put(ph, t); + + return ret; +} + +static int scmi_pinctrl_request(const struct scmi_protocol_handle *ph, + u32 identifier, + enum scmi_pinctrl_selector_type type) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_request *tx; + + if (type =3D=3D FUNCTION_TYPE) + return -EINVAL; + + ret =3D scmi_pinctrl_validate_id(ph, identifier, type); + if (ret) + return ret; + + ret =3D ph->xops->xfer_get_init(ph, PINCTRL_REQUEST, sizeof(*tx), 0, &t); + if (ret) + return ret; + + tx =3D t->tx.buf; + tx->identifier =3D cpu_to_le32(identifier); + tx->flags =3D cpu_to_le32(type); + + ret =3D ph->xops->do_xfer(ph, t); + ph->xops->xfer_put(ph, t); + + return ret; +} + +static int scmi_pinctrl_pin_request(const struct scmi_protocol_handle *ph, + u32 pin) +{ + return scmi_pinctrl_request(ph, pin, PIN_TYPE); +} + +static int scmi_pinctrl_free(const struct scmi_protocol_handle *ph, + u32 identifier, + enum scmi_pinctrl_selector_type type) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_request *tx; + + if (type =3D=3D FUNCTION_TYPE) + return -EINVAL; + + ret =3D scmi_pinctrl_validate_id(ph, identifier, type); + if (ret) + return ret; + + ret =3D ph->xops->xfer_get_init(ph, PINCTRL_RELEASE, sizeof(*tx), 0, &t); + if (ret) + return ret; + + tx =3D t->tx.buf; + tx->identifier =3D cpu_to_le32(identifier); + tx->flags =3D cpu_to_le32(type); + + ret =3D ph->xops->do_xfer(ph, t); + ph->xops->xfer_put(ph, t); + + return ret; +} + +static int scmi_pinctrl_pin_free(const struct scmi_protocol_handle *ph, u3= 2 pin) +{ + return scmi_pinctrl_free(ph, pin, PIN_TYPE); +} + +static int scmi_pinctrl_get_group_info(const struct scmi_protocol_handle *= ph, + u32 selector, + struct scmi_group_info *group) +{ + int ret; + + if (!group) + return -EINVAL; + + ret =3D scmi_pinctrl_attributes(ph, GROUP_TYPE, selector, + group->name, + &group->nr_pins); + if (ret) + return ret; + + if (!group->nr_pins) { + dev_err(ph->dev, "Group %d has 0 elements", selector); + return -ENODATA; + } + + group->group_pins =3D kmalloc_array(group->nr_pins, + sizeof(*group->group_pins), + GFP_KERNEL); + if (!group->group_pins) + return -ENOMEM; + + ret =3D scmi_pinctrl_list_associations(ph, selector, GROUP_TYPE, + group->nr_pins, group->group_pins); + if (ret) { + kfree(group->group_pins); + return ret; + } + + group->present =3D true; + return 0; +} + +static int scmi_pinctrl_get_group_name(const struct scmi_protocol_handle *= ph, + u32 selector, const char **name) +{ + struct scmi_pinctrl_info *pi =3D ph->get_priv(ph); + + if (!name) + return -EINVAL; + + if (selector >=3D pi->nr_groups) + return -EINVAL; + + if (!pi->groups[selector].present) { + int ret; + + ret =3D scmi_pinctrl_get_group_info(ph, selector, + &pi->groups[selector]); + if (ret) + return ret; + } + + *name =3D pi->groups[selector].name; + + return 0; +} + +static int scmi_pinctrl_group_pins_get(const struct scmi_protocol_handle *= ph, + u32 selector, const u32 **pins, + u32 *nr_pins) +{ + struct scmi_pinctrl_info *pi =3D ph->get_priv(ph); + + if (!pins || !nr_pins) + return -EINVAL; + + if (selector >=3D pi->nr_groups) + return -EINVAL; + + if (!pi->groups[selector].present) { + int ret; + + ret =3D scmi_pinctrl_get_group_info(ph, selector, + &pi->groups[selector]); + if (ret) + return ret; + } + + *pins =3D pi->groups[selector].group_pins; + *nr_pins =3D pi->groups[selector].nr_pins; + + return 0; +} + +static int scmi_pinctrl_get_function_info(const struct scmi_protocol_handl= e *ph, + u32 selector, + struct scmi_function_info *func) +{ + int ret; + + if (!func) + return -EINVAL; + + ret =3D scmi_pinctrl_attributes(ph, FUNCTION_TYPE, selector, + func->name, + &func->nr_groups); + if (ret) + return ret; + + if (!func->nr_groups) { + dev_err(ph->dev, "Function %d has 0 elements", selector); + return -ENODATA; + } + + func->groups =3D kmalloc_array(func->nr_groups, sizeof(*func->groups), + GFP_KERNEL); + if (!func->groups) + return -ENOMEM; + + ret =3D scmi_pinctrl_list_associations(ph, selector, FUNCTION_TYPE, + func->nr_groups, func->groups); + if (ret) { + kfree(func->groups); + return ret; + } + + func->present =3D true; + return 0; +} + +static int scmi_pinctrl_get_function_name(const struct scmi_protocol_handl= e *ph, + u32 selector, const char **name) +{ + struct scmi_pinctrl_info *pi =3D ph->get_priv(ph); + + if (!name) + return -EINVAL; + + if (selector >=3D pi->nr_functions) + return -EINVAL; + + if (!pi->functions[selector].present) { + int ret; + + ret =3D scmi_pinctrl_get_function_info(ph, selector, + &pi->functions[selector]); + if (ret) + return ret; + } + + *name =3D pi->functions[selector].name; + return 0; +} + +static int +scmi_pinctrl_function_groups_get(const struct scmi_protocol_handle *ph, + u32 selector, u32 *nr_groups, + const u32 **groups) +{ + struct scmi_pinctrl_info *pi =3D ph->get_priv(ph); + + if (!groups || !nr_groups) + return -EINVAL; + + if (selector >=3D pi->nr_functions) + return -EINVAL; + + if (!pi->functions[selector].present) { + int ret; + + ret =3D scmi_pinctrl_get_function_info(ph, selector, + &pi->functions[selector]); + if (ret) + return ret; + } + + *groups =3D pi->functions[selector].groups; + *nr_groups =3D pi->functions[selector].nr_groups; + + return 0; +} + +static int scmi_pinctrl_mux_set(const struct scmi_protocol_handle *ph, + u32 selector, u32 group) +{ + return scmi_pinctrl_function_select(ph, group, GROUP_TYPE, selector); +} + +static int scmi_pinctrl_get_pin_info(const struct scmi_protocol_handle *ph, + u32 selector, struct scmi_pin_info *pin) +{ + int ret; + + if (!pin) + return -EINVAL; + + ret =3D scmi_pinctrl_attributes(ph, PIN_TYPE, selector, + pin->name, NULL); + if (ret) + return ret; + + pin->present =3D true; + return 0; +} + +static int scmi_pinctrl_get_pin_name(const struct scmi_protocol_handle *ph, + u32 selector, const char **name) +{ + struct scmi_pinctrl_info *pi =3D ph->get_priv(ph); + + if (!name) + return -EINVAL; + + if (selector >=3D pi->nr_pins) + return -EINVAL; + + if (!pi->pins[selector].present) { + int ret; + + ret =3D scmi_pinctrl_get_pin_info(ph, selector, + &pi->pins[selector]); + if (ret) + return ret; + } + + *name =3D pi->pins[selector].name; + + return 0; +} + +static int scmi_pinctrl_name_get(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + const char **name) +{ + switch (type) { + case PIN_TYPE: + return scmi_pinctrl_get_pin_name(ph, selector, name); + case GROUP_TYPE: + return scmi_pinctrl_get_group_name(ph, selector, name); + case FUNCTION_TYPE: + return scmi_pinctrl_get_function_name(ph, selector, name); + default: + return -EINVAL; + } +} + +static const struct scmi_pinctrl_proto_ops pinctrl_proto_ops =3D { + .count_get =3D scmi_pinctrl_count_get, + .name_get =3D scmi_pinctrl_name_get, + .group_pins_get =3D scmi_pinctrl_group_pins_get, + .function_groups_get =3D scmi_pinctrl_function_groups_get, + .mux_set =3D scmi_pinctrl_mux_set, + .settings_get =3D scmi_pinctrl_settings_get, + .settings_conf =3D scmi_pinctrl_settings_conf, + .pin_request =3D scmi_pinctrl_pin_request, + .pin_free =3D scmi_pinctrl_pin_free, +}; + +static int scmi_pinctrl_protocol_init(const struct scmi_protocol_handle *p= h) +{ + int ret; + u32 version; + struct scmi_pinctrl_info *pinfo; + + ret =3D ph->xops->version_get(ph, &version); + if (ret) + return ret; + + dev_dbg(ph->dev, "Pinctrl Version %d.%d\n", + PROTOCOL_REV_MAJOR(version), PROTOCOL_REV_MINOR(version)); + + pinfo =3D devm_kzalloc(ph->dev, sizeof(*pinfo), GFP_KERNEL); + if (!pinfo) + return -ENOMEM; + + ret =3D scmi_pinctrl_attributes_get(ph, pinfo); + if (ret) + return ret; + + pinfo->pins =3D devm_kcalloc(ph->dev, pinfo->nr_pins, + sizeof(*pinfo->pins), + GFP_KERNEL); + if (!pinfo->pins) + return -ENOMEM; + + pinfo->groups =3D devm_kcalloc(ph->dev, pinfo->nr_groups, + sizeof(*pinfo->groups), + GFP_KERNEL); + if (!pinfo->groups) + return -ENOMEM; + + pinfo->functions =3D devm_kcalloc(ph->dev, pinfo->nr_functions, + sizeof(*pinfo->functions), + GFP_KERNEL); + if (!pinfo->functions) + return -ENOMEM; + + pinfo->version =3D version; + + return ph->set_priv(ph, pinfo, version); +} + +static int scmi_pinctrl_protocol_deinit(const struct scmi_protocol_handle = *ph) +{ + int i; + struct scmi_pinctrl_info *pi =3D ph->get_priv(ph); + + for (i =3D 0; i < pi->nr_groups; i++) { + if (pi->groups[i].present) { + kfree(pi->groups[i].group_pins); + pi->groups[i].present =3D false; + } + } + + for (i =3D 0; i < pi->nr_functions; i++) { + if (pi->functions[i].present) { + kfree(pi->functions[i].groups); + pi->functions[i].present =3D false; + } + } + + return 0; +} + +static const struct scmi_protocol scmi_pinctrl =3D { + .id =3D SCMI_PROTOCOL_PINCTRL, + .owner =3D THIS_MODULE, + .instance_init =3D &scmi_pinctrl_protocol_init, + .instance_deinit =3D &scmi_pinctrl_protocol_deinit, + .ops =3D &pinctrl_proto_ops, + .supported_version =3D SCMI_PROTOCOL_SUPPORTED_VERSION, +}; + +DEFINE_SCMI_PROTOCOL_REGISTER_UNREGISTER(pinctrl, scmi_pinctrl) diff --git a/drivers/firmware/arm_scmi/protocols.h b/drivers/firmware/arm_s= cmi/protocols.h index 3e91536a77a3..c02cbfd2bb03 100644 --- a/drivers/firmware/arm_scmi/protocols.h +++ b/drivers/firmware/arm_scmi/protocols.h @@ -355,6 +355,7 @@ void __exit scmi_##name##_unregister(void) \ DECLARE_SCMI_REGISTER_UNREGISTER(base); DECLARE_SCMI_REGISTER_UNREGISTER(clock); DECLARE_SCMI_REGISTER_UNREGISTER(perf); +DECLARE_SCMI_REGISTER_UNREGISTER(pinctrl); DECLARE_SCMI_REGISTER_UNREGISTER(power); DECLARE_SCMI_REGISTER_UNREGISTER(reset); DECLARE_SCMI_REGISTER_UNREGISTER(sensors); diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h index b807141acc14..64043e269701 100644 --- a/include/linux/scmi_protocol.h +++ b/include/linux/scmi_protocol.h @@ -737,6 +737,80 @@ struct scmi_powercap_proto_ops { u32 *power_thresh_high); }; =20 +enum scmi_pinctrl_selector_type { + PIN_TYPE =3D 0, + GROUP_TYPE, + FUNCTION_TYPE, +}; + +enum scmi_pinctrl_conf_type { + SCMI_PIN_DEFAULT =3D 0, + SCMI_PIN_BIAS_BUS_HOLD =3D 1, + SCMI_PIN_BIAS_DISABLE =3D 2, + SCMI_PIN_BIAS_HIGH_IMPEDANCE =3D 3, + SCMI_PIN_BIAS_PULL_UP =3D 4, + SCMI_PIN_BIAS_PULL_DEFAULT =3D 5, + SCMI_PIN_BIAS_PULL_DOWN =3D 6, + SCMI_PIN_DRIVE_OPEN_DRAIN =3D 7, + SCMI_PIN_DRIVE_OPEN_SOURCE =3D 8, + SCMI_PIN_DRIVE_PUSH_PULL =3D 9, + SCMI_PIN_DRIVE_STRENGTH =3D 10, + SCMI_PIN_INPUT_DEBOUNCE =3D 11, + SCMI_PIN_INPUT_MODE =3D 12, + SCMI_PIN_PULL_MODE =3D 13, + SCMI_PIN_INPUT_VALUE =3D 14, + SCMI_PIN_INPUT_SCHMITT =3D 15, + SCMI_PIN_LOW_POWER_MODE =3D 16, + SCMI_PIN_OUTPUT_MODE =3D 17, + SCMI_PIN_OUTPUT_VALUE =3D 18, + SCMI_PIN_POWER_SOURCE =3D 19, + SCMI_PIN_SLEW_RATE =3D 20, + SCMI_PIN_OEM_START =3D 192, + SCMI_PIN_OEM_END =3D 255, +}; + +/** + * struct scmi_pinctrl_proto_ops - represents the various operations provi= ded + * by SCMI Pinctrl Protocol + * + * @count_get: returns count of the registered elements in given type + * @name_get: returns name by index of given type + * @group_pins_get: returns the set of pins, assigned to the specified gro= up + * @function_groups_get: returns the set of groups, assigned to the specif= ied + * function + * @mux_set: set muxing function for groups of pins + * @config_get: returns configuration parameter for pin or group + * @config_set: sets the configuration parameter for pin or group + * @pin_request: aquire pin before selecting mux setting + * @pin_free: frees pin, acquired by request_pin call + */ +struct scmi_pinctrl_proto_ops { + int (*count_get)(const struct scmi_protocol_handle *ph, + enum scmi_pinctrl_selector_type type); + int (*name_get)(const struct scmi_protocol_handle *ph, u32 selector, + enum scmi_pinctrl_selector_type type, + const char **name); + int (*group_pins_get)(const struct scmi_protocol_handle *ph, + u32 selector, const unsigned int **pins, + unsigned int *nr_pins); + int (*function_groups_get)(const struct scmi_protocol_handle *ph, + u32 selector, unsigned int *nr_groups, + const unsigned int **groups); + int (*mux_set)(const struct scmi_protocol_handle *ph, u32 selector, + u32 group); + int (*settings_get)(const struct scmi_protocol_handle *ph, u32 selector, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_conf_type config_type, + u32 *config_value); + int (*settings_conf)(const struct scmi_protocol_handle *ph, + u32 selector, enum scmi_pinctrl_selector_type type, + unsigned int nr_configs, + enum scmi_pinctrl_conf_type *config_type, + u32 *config_value); + int (*pin_request)(const struct scmi_protocol_handle *ph, u32 pin); + int (*pin_free)(const struct scmi_protocol_handle *ph, u32 pin); +}; + /** * struct scmi_notify_ops - represents notifications' operations provided= by * SCMI core @@ -844,6 +918,7 @@ enum scmi_std_protocol { SCMI_PROTOCOL_RESET =3D 0x16, SCMI_PROTOCOL_VOLTAGE =3D 0x17, SCMI_PROTOCOL_POWERCAP =3D 0x18, + SCMI_PROTOCOL_PINCTRL =3D 0x19, }; =20 enum scmi_system_events { --=20 2.37.1 From nobody Sun Feb 8 15:01:36 2026 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2054.outbound.protection.outlook.com [40.107.6.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B54A718659; Sat, 23 Mar 2024 12:07:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.6.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711195667; cv=fail; b=OOH7Ec4Y5OURlmDhLjJypxVCdnBHsWtQtq8FyfLxa5SlHrmVrTEDoarLDdvtZ5+CIIptYaDn3sOv9AHGZ0OC0Fryv+tGLLp+o4uuheKXx33GztUQ35Bz5f+8vZ2Ybk8Agxlr1KOCNrmcFG7bo8t1gkO10FUXyqXeI5hvDCwqZ/A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711195667; c=relaxed/simple; bh=qjTs8qUzl7EwnxIdGYafwnlcF95X9rt0+iZVibIBUbg=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Jwd355Y9p7ropWDxkt95oMO0/jtSEgQPVBf3V0c7UtmZZwbCR3+PMLH/6ONJ7x1xFbVp4t4QtWbk2a2QQKv/8rJulFd6LZxaMRG03+HJKmwcyxuhqexQoT85hke1GZwdFOEAttdLAdG2PW2pFB64+ydDHBzxirP2B9yGK1MO3E8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=HDtr/cMl; arc=fail smtp.client-ip=40.107.6.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="HDtr/cMl" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U+Kdy+q/UhTCbpuSKdf5IZ83UTKEaj8O2nmgPz9V77HS2vm/LJ1phTLbFeO/XiMprOupIs9YXfaBBXHeNEPyXyK1VqkAaxX2JRWnOa6sRr6UfX+5zFsz4BAiEiaeFpjNbulXEyA+o7xMWeOMALPqAR+/OFCJYee0yFVQ1IiYKTA/eHnmSMdfS49UPxv6cyTayHglBpo0318dyn2q1jVoOiJEx07SQFiHcndKM1Yxq7cE3fkUNTY0kAovPGa7T1U+EdsSx7imiIxDxKjgUBFI3Y+X6zANVIs+BQQDPvGPDnrBu1ey1Z6tP5BJwHMT7bfEHKP2nOC7SZjRBvL3T8MEnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nHNPcWftLWLkAPGzxEJd0Ra+N8iCWeIB6WzKxpGVt0E=; b=Et6eHrD2l6McztzjnX5iqurfuEWnsxTbN53F/EV1w/Xxb7MZkjJOYM58QFXUVtsmn9LFmkSCkYiSOPkwdUEdk7VQC8MCXfk6SB77BiD+25LwaWpjD/nL8jNaLC9Kw7SUdPl/SK6j9Akl/NUJsEzHudoRY9xbU5ZhNnt2TPcdciB7uODaBYCQBbNTrDm1OeF/ZZWXewhtF21GJlb8GbD7xxwcBWwPrVYl6s6GgOnLsy3YWdFEvvq5xsp7Wjtie0D/4Q8uAt5gnbHBXqfYUbWzlgqNowIAwvnTW9AN+ia/k4KW1LrjfnRpRMfrVLEu3DDlyEiHDBk6xaEHamqIgjpO0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nHNPcWftLWLkAPGzxEJd0Ra+N8iCWeIB6WzKxpGVt0E=; b=HDtr/cMl4fwvn5rJLFMLMpn7u3/uB3cRP66ibDKmUi8GE3afgv+nRMkHE3Gp/jf6iuPOXQ0Rqr0pXye7rwf5gpOsn2RzSvZvF3x0P5hTw5DJ85UKuxJlrWQqhDt3/8ABtuOCElFlqTYiUncu+fbN66+CKfhJr87ooetF+JCARn4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by DU0PR04MB9585.eurprd04.prod.outlook.com (2603:10a6:10:316::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.26; Sat, 23 Mar 2024 12:07:42 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.017; Sat, 23 Mar 2024 12:07:42 +0000 From: "Peng Fan (OSS)" Date: Sat, 23 Mar 2024 20:15:17 +0800 Subject: [PATCH v6 4/4] pinctrl: Implementation of the generic scmi-pinctrl driver Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240323-pinctrl-scmi-v6-4-a895243257c0@nxp.com> References: <20240323-pinctrl-scmi-v6-0-a895243257c0@nxp.com> In-Reply-To: <20240323-pinctrl-scmi-v6-0-a895243257c0@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan , Oleksii Moisieiev X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1711196144; l=18822; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=CC/Ed22/gPMkDQdaZQ+VKjMKDbtmNv4mvTyv3eV3s0k=; b=gInnj1qN5lHrtMY6nUSCvkbArwX9FYihGGSeC1LOyi/qOPkULWdmNyWxLeBsxIYIuO+wH/lKA 28fRJNb7Iy5BUFEcm4VFruwUycDMAPYUwqkOOco2CROj/jPb0EFY30U X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR06CA0016.apcprd06.prod.outlook.com (2603:1096:4:186::22) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|DU0PR04MB9585:EE_ X-MS-Office365-Filtering-Correlation-Id: aba87ca8-2571-43ff-3e90-08dc4b31d7b8 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oVNBUvxCq+XlroWBY6CXF2C0Vf2t1XoqD24Gz9KToB/z06JOoksXrbp6XUax5U9KJBfY5fALYGl27G5DK+t8+5DeXkTBHEBWM5c5RncU2rXgLBhJPhspWj+NehczObsdBziExpAkaY2en+1osXEA/9CvlGJhjKbH336B2xEh4hkp8g3nn1Be0bm570X5PFN2VHqrH7vJvuqkzP1LKRiwoHLN5utalxo3fCBZazzWDW/6QGbb+9zf79ocOP/Pu3OiFuQLOxEFnQPEiN5x0iwIStNs4XuHBNkiLJMCymO0r5Gy/7dkrXhT3dayyqTB3TEQOVt6yn0EYrw7R2jr1PIt7SNeUsRf2/BX1vpScPEinNAMT1dsoX6nBynY27GNpreGLfFOFY4zcwHD5BE1wCI6nJiJtG0aGosOhS18slHI+G5BDU4sbJq+TjK2aHl1xyPH1aQ3RP6KspM9b7SE38QJwpb1rylVOVz4NuWV38kARvHkux7rXNGlcayOyGpjPJXi18Oh5ZY2ZdtywGw3FX4ixXOAC3YdWXIPcYJRuxnPRuhFoqcFpFUelm4l0gaf84qub3Fkffi9dYRccYQsaPMq3StbgmIe3wMFP3hUaXF4+Aw6eocmDt+dHI33Hn3DnxWqgKxgyIfWhAsubjG/sZX19evqSOLoZeI0TjhtC7pHOyO0wZ8I259q+qWhV8qO0OCz1WP5jrW8c7Tp5cPAaEw7gGzAJmeJTzB1qrxu/WdVcn0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(52116005)(7416005)(1800799015)(376005)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEZLVndManZlOU1RMkVOaVhIdXdsRTcxcENoMzduQ0xhYmxubWovMVZCWkxH?= =?utf-8?B?WkhuL0RBV2tqTUpoTDNEdlNNTUZnWlg4OURTT1FqT2FZai92MENFU0NicUwx?= =?utf-8?B?ZmxlS1p1ZE5DOEVVUWExQTBDL09MK1JlVTlPRVNTZXZmdVAzZDVRS2pMLzBE?= =?utf-8?B?NVhnczBqZjEyYmJBWlZsRVY2MkJoaktOQW8yUlkrVzJuZ0ZPTXp6TzJUdjc3?= =?utf-8?B?cHJWbmhFRitxc0xtd1dIdWJnVmxHY1ljaldXY3lQekdZM1NoNHNIR09iaDdK?= =?utf-8?B?Z1Vvc25mbitZMVFjaE0rdXBSOXE4MERERkVOQ0ROeEZ2V3JER0pET0dOYlh4?= =?utf-8?B?TEFQWURNL0FFcExDeUErc1BKcU9SU2ZRT1huVlNVSDQ5M3p6WVAzWDhFMmFk?= =?utf-8?B?ZEQxS2FQZUdJT1A1WENLdDVpNW50cURyVkxEdlNreEdXUmIrZjU1ekFsKytS?= =?utf-8?B?NG84QndidUdMMEthckMvK0l0Zm1wSTkvUC9iZmxKTFJ5djlQNGNudXNzYzIw?= =?utf-8?B?T0h4YzdiT3ZwTFp5cU9qMkRXVXJBMHVsUm54RlE1bDY2ZW1qc2N4UkVrdHRT?= =?utf-8?B?OGl5bFlPSzJmRXdOQWJrNWVQYUU2emNyTDNnL0RxYVRZODNhVkdpM0J2UmNF?= =?utf-8?B?UDBXUzEwSmN0cktVdkc3dWZ1SWp4YTlMUWJUUHFVNXZ6NDlOY255aEhUaEgv?= =?utf-8?B?LzViK3BIYk42N094K2h5Z0RjU0VGUjJQTVU2REdOZVNvbHFpUS93R3pDY3dL?= =?utf-8?B?dlo1OXc2MmRKZjRtM1k1bzcycE1ISEJreUJhQ0xYZHVKK3FwanE1enpJTnY1?= =?utf-8?B?d0Z2VVJIVlRrM1BYcDczem95QjJaRXJETVZGUks4OUljUHg5L2FudU5aY2t6?= =?utf-8?B?WkNkUDBmNE1WUVNOZjZ4RDlJM3pPQjNYd1Q2eWZVMEFiYnJPL0pPODZwLzZn?= =?utf-8?B?YVpEZzgrZW1EUG5ERlB0UWFKQjcwQ3N6ZFJTeUtmb3lQSjlXNHFBeTFVd2ty?= =?utf-8?B?amdHRS8wY3VqWWdGK3VDSC9HY2VzMGZVWkt1QmEvUUdmcHNNRVVUNW5kNlQ5?= =?utf-8?B?TmVrNmJKY3ZScENYakRZMEhldkQvWnFzMzV4R0E0N0QzTXRoTVh4bTM0WUhI?= =?utf-8?B?SEM3Ti9ZUWxXeWI2QzFObk91YnpBb3RiK25JdVpnN2c2QzFiRjh0cDVpekNF?= =?utf-8?B?OGpFa0RWbTZ0MHlYODVoY01FUllycm9JWXlUYk1jMWVGM3pPdnArbjAzeXV0?= =?utf-8?B?UWM2YmRkdi80cHJpdXZiNDFNUjFmZFJuSUp6bUtyOVk4TGFlSmoxUmRXQVdp?= =?utf-8?B?WW1PTzdTdG1FakVVSVp6bWxhZWVBekZDaGJ3ZXpGUlJrUW92cmlENldQTVJW?= =?utf-8?B?Vkp0d2RhWStpclB5T0RvQUlrQy9ieGJpYVB6UUJxRXAxZDM1MVJQTmZNOXRM?= =?utf-8?B?clFLRVFmdXY4S09ObUtnczlBQXhVV1pPczlmUkhXR2RlQmV4Y00xTHR1NWhi?= =?utf-8?B?RGloZEdIYkFuMHFvUlJYK0pLbHUzR2hoQXJ4cGl5dXRjOXFlQng5RlpqaWVo?= =?utf-8?B?c2tqWnF4OTdhTGsyQmdjeWZHRDRWd2wvUUF2UVNjMDhqLzRhTllqZlF5Yndo?= =?utf-8?B?TUlIaGtOS0V1MUNueWc5dW5PYVljaXRNUXNpYjNGSTUvaFU4MHo2ME1XTVJR?= =?utf-8?B?QVZuMk4yK09VeFlvWk5xKzVKT1lBUlpGckFzZmdtM1JIK1hGVU5ycTRKcGo2?= =?utf-8?B?YVRUM3RCUmppYkgrc2Uyb0Q4M3RzbzYydm1CMFdjYjdwQkJFRDNQMEoxTDA0?= =?utf-8?B?dzVNejFaS2VWTE5VOFJIcmMwZ3FHUDNyT0xrcUE0c2VmTG5vbG1tRTRtck1F?= =?utf-8?B?N0NlbG41SmtxeFpDVGNqNUtJU0VSSkVqWkN2K1N1RDFvYm9LbmdpZWh2SUhN?= =?utf-8?B?OXdTNjZ5S2RGVG5GSHlZZ2Z0T0liUVRQNFVqNnYzbS9vLzVHbmYxY2s2aE5V?= =?utf-8?B?SktoNFdXRjFjN240WkloTnJla0plQVRTV2g0QittTzI0L0hhb3FmbUdNYXE1?= =?utf-8?B?U0JFR2FydXdXbk5aMkxRYVBLSDJqRlIyZk5MMW50ZzA0a0RreGNseitPSWhz?= =?utf-8?Q?Bt3fABHIDFozetk6IX/cKkbfl?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: aba87ca8-2571-43ff-3e90-08dc4b31d7b8 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2024 12:07:42.6198 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6iAnwUM82qpPQcplqnNLKD7fP7q27LvhiuO/AnIjQZ5QNulyhhdD5jInPViMuiqIcHaTMe5HWyxYur30eYJUpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9585 From: Peng Fan scmi-pinctrl driver implements pinctrl driver interface and using SCMI protocol to redirect messages from pinctrl subsystem SDK to SCMI platform firmware, which does the changes in HW. Co-developed-by: Oleksii Moisieiev Signed-off-by: Oleksii Moisieiev Signed-off-by: Peng Fan --- MAINTAINERS | 1 + drivers/firmware/arm_scmi/pinctrl.c | 1 + drivers/pinctrl/Kconfig | 11 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-scmi.c | 564 ++++++++++++++++++++++++++++++++= ++++ 5 files changed, 578 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4b511a55101c..d8270ac6651a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21457,6 +21457,7 @@ F: drivers/cpufreq/sc[mp]i-cpufreq.c F: drivers/firmware/arm_scmi/ F: drivers/firmware/arm_scpi.c F: drivers/hwmon/scmi-hwmon.c +F: drivers/pinctrl/pinctrl-scmi.c F: drivers/pmdomain/arm/ F: drivers/powercap/arm_scmi_powercap.c F: drivers/regulator/scmi-regulator.c diff --git a/drivers/firmware/arm_scmi/pinctrl.c b/drivers/firmware/arm_scm= i/pinctrl.c index 87d9b89cab13..0ecefe855432 100644 --- a/drivers/firmware/arm_scmi/pinctrl.c +++ b/drivers/firmware/arm_scmi/pinctrl.c @@ -465,6 +465,7 @@ scmi_pinctrl_settings_conf(const struct scmi_protocol_h= andle *ph, =20 tx =3D t->tx.buf; tx->identifier =3D cpu_to_le32(selector); + tx->function_id =3D cpu_to_le32(0xFFFFFFFF); attributes =3D FIELD_PREP(GENMASK(1, 0), type) | FIELD_PREP(GENMASK(9, 2), chunk); tx->attributes =3D cpu_to_le32(attributes); diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index d45657aa986a..4e6f65cf0e76 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -450,6 +450,17 @@ config PINCTRL_ROCKCHIP help This support pinctrl and GPIO driver for Rockchip SoCs. =20 +config PINCTRL_SCMI + tristate "Pinctrl driver using SCMI protocol interface" + depends on ARM_SCMI_PROTOCOL || COMPILE_TEST + select PINMUX + select GENERIC_PINCONF + help + This driver provides support for pinctrl which is controlled + by firmware that implements the SCMI interface. + It uses SCMI Message Protocol to interact with the + firmware providing all the pinctrl controls. + config PINCTRL_SINGLE tristate "One-register-per-pin type device tree based pinctrl driver" depends on OF diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile index 2152539b53d5..cc809669405a 100644 --- a/drivers/pinctrl/Makefile +++ b/drivers/pinctrl/Makefile @@ -45,6 +45,7 @@ obj-$(CONFIG_PINCTRL_PIC32) +=3D pinctrl-pic32.o obj-$(CONFIG_PINCTRL_PISTACHIO) +=3D pinctrl-pistachio.o obj-$(CONFIG_PINCTRL_RK805) +=3D pinctrl-rk805.o obj-$(CONFIG_PINCTRL_ROCKCHIP) +=3D pinctrl-rockchip.o +obj-$(CONFIG_PINCTRL_SCMI) +=3D pinctrl-scmi.o obj-$(CONFIG_PINCTRL_SINGLE) +=3D pinctrl-single.o obj-$(CONFIG_PINCTRL_ST) +=3D pinctrl-st.o obj-$(CONFIG_PINCTRL_STMFX) +=3D pinctrl-stmfx.o diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c new file mode 100644 index 000000000000..b23533bff63a --- /dev/null +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -0,0 +1,564 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * System Control and Power Interface (SCMI) Protocol based pinctrl driver + * + * Copyright (C) 2024 EPAM + * Copyright 2024 NXP + */ + +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +#include "pinctrl-utils.h" +#include "core.h" +#include "pinconf.h" + +#define DRV_NAME "scmi-pinctrl" + +/* Define num configs, if not large than 4 use stack, else use kcalloc */ +#define SCMI_NUM_CONFIGS 4 + +static const struct scmi_pinctrl_proto_ops *pinctrl_ops; + +struct scmi_pinctrl_funcs { + unsigned int num_groups; + const char **groups; +}; + +struct scmi_pinctrl { + struct device *dev; + struct scmi_protocol_handle *ph; + struct pinctrl_dev *pctldev; + struct pinctrl_desc pctl_desc; + struct scmi_pinctrl_funcs *functions; + unsigned int nr_functions; + struct pinctrl_pin_desc *pins; + unsigned int nr_pins; +}; + +static int pinctrl_scmi_get_groups_count(struct pinctrl_dev *pctldev) +{ + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->count_get(pmx->ph, GROUP_TYPE); +} + +static const char *pinctrl_scmi_get_group_name(struct pinctrl_dev *pctldev, + unsigned int selector) +{ + int ret; + const char *name; + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + ret =3D pinctrl_ops->name_get(pmx->ph, selector, GROUP_TYPE, &name); + if (ret) { + dev_err(pmx->dev, "get name failed with err %d", ret); + return NULL; + } + + return name; +} + +static int pinctrl_scmi_get_group_pins(struct pinctrl_dev *pctldev, + unsigned int selector, + const unsigned int **pins, + unsigned int *num_pins) +{ + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->group_pins_get(pmx->ph, selector, pins, num_pins); +} + +static const struct pinctrl_ops pinctrl_scmi_pinctrl_ops =3D { + .get_groups_count =3D pinctrl_scmi_get_groups_count, + .get_group_name =3D pinctrl_scmi_get_group_name, + .get_group_pins =3D pinctrl_scmi_get_group_pins, +#ifdef CONFIG_OF + .dt_node_to_map =3D pinconf_generic_dt_node_to_map_all, + .dt_free_map =3D pinconf_generic_dt_free_map, +#endif +}; + +static int pinctrl_scmi_get_functions_count(struct pinctrl_dev *pctldev) +{ + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->count_get(pmx->ph, FUNCTION_TYPE); +} + +static const char *pinctrl_scmi_get_function_name(struct pinctrl_dev *pctl= dev, + unsigned int selector) +{ + int ret; + const char *name; + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + ret =3D pinctrl_ops->name_get(pmx->ph, selector, FUNCTION_TYPE, &name); + if (ret) { + dev_err(pmx->dev, "get name failed with err %d", ret); + return NULL; + } + + return name; +} + +static int pinctrl_scmi_get_function_groups(struct pinctrl_dev *pctldev, + unsigned int selector, + const char * const **p_groups, + unsigned int * const p_num_groups) +{ + struct scmi_pinctrl_funcs *func; + const unsigned int *group_ids; + unsigned int num_groups; + const char **groups; + int ret, i; + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + if (!p_groups || !p_num_groups) + return -EINVAL; + + if (selector >=3D pmx->nr_functions) + return -EINVAL; + + func =3D &pmx->functions[selector]; + if (func->num_groups) + goto done; + + ret =3D pinctrl_ops->function_groups_get(pmx->ph, selector, &num_groups, + &group_ids); + if (ret) { + dev_err(pmx->dev, "Unable to get function groups, err %d", ret); + return ret; + } + if (!num_groups) + return -EINVAL; + + groups =3D devm_kcalloc(pmx->dev, num_groups, sizeof(*groups), GFP_KERNEL= ); + if (!groups) + return -ENOMEM; + + for (i =3D 0; i < num_groups; i++) { + groups[i] =3D pinctrl_scmi_get_group_name(pctldev, group_ids[i]); + if (!groups[i]) { + ret =3D -EINVAL; + goto err_free; + } + } + + func->num_groups =3D num_groups; + func->groups =3D groups; +done: + *p_groups =3D (const char * const *)func->groups; + *p_num_groups =3D func->num_groups; + + return 0; + +err_free: + devm_kfree(pmx->dev, groups); + + return ret; +} + +static int pinctrl_scmi_func_set_mux(struct pinctrl_dev *pctldev, + unsigned int selector, unsigned int group) +{ + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->mux_set(pmx->ph, selector, group); +} + +static int pinctrl_scmi_request(struct pinctrl_dev *pctldev, + unsigned int offset) +{ + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->pin_request(pmx->ph, offset); +} + +static int pinctrl_scmi_free(struct pinctrl_dev *pctldev, unsigned int off= set) +{ + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->pin_free(pmx->ph, offset); +} + +static const struct pinmux_ops pinctrl_scmi_pinmux_ops =3D { + .request =3D pinctrl_scmi_request, + .free =3D pinctrl_scmi_free, + .get_functions_count =3D pinctrl_scmi_get_functions_count, + .get_function_name =3D pinctrl_scmi_get_function_name, + .get_function_groups =3D pinctrl_scmi_get_function_groups, + .set_mux =3D pinctrl_scmi_func_set_mux, +}; + +static int pinctrl_scmi_map_pinconf_type(enum pin_config_param param, + enum scmi_pinctrl_conf_type *type) +{ + u32 arg =3D param; + + switch (arg) { + case PIN_CONFIG_BIAS_BUS_HOLD: + *type =3D SCMI_PIN_BIAS_BUS_HOLD; + break; + case PIN_CONFIG_BIAS_DISABLE: + *type =3D SCMI_PIN_BIAS_DISABLE; + break; + case PIN_CONFIG_BIAS_HIGH_IMPEDANCE: + *type =3D SCMI_PIN_BIAS_HIGH_IMPEDANCE; + break; + case PIN_CONFIG_BIAS_PULL_DOWN: + *type =3D SCMI_PIN_BIAS_PULL_DOWN; + break; + case PIN_CONFIG_BIAS_PULL_PIN_DEFAULT: + *type =3D SCMI_PIN_BIAS_PULL_DEFAULT; + break; + case PIN_CONFIG_BIAS_PULL_UP: + *type =3D SCMI_PIN_BIAS_PULL_UP; + break; + case PIN_CONFIG_DRIVE_OPEN_DRAIN: + *type =3D SCMI_PIN_DRIVE_OPEN_DRAIN; + break; + case PIN_CONFIG_DRIVE_OPEN_SOURCE: + *type =3D SCMI_PIN_DRIVE_OPEN_SOURCE; + break; + case PIN_CONFIG_DRIVE_PUSH_PULL: + *type =3D SCMI_PIN_DRIVE_PUSH_PULL; + break; + case PIN_CONFIG_DRIVE_STRENGTH: + *type =3D SCMI_PIN_DRIVE_STRENGTH; + break; + case PIN_CONFIG_DRIVE_STRENGTH_UA: + *type =3D SCMI_PIN_DRIVE_STRENGTH; + break; + case PIN_CONFIG_INPUT_DEBOUNCE: + *type =3D SCMI_PIN_INPUT_DEBOUNCE; + break; + case PIN_CONFIG_INPUT_ENABLE: + *type =3D SCMI_PIN_INPUT_MODE; + break; + case PIN_CONFIG_INPUT_SCHMITT: + *type =3D SCMI_PIN_INPUT_SCHMITT; + break; + case PIN_CONFIG_INPUT_SCHMITT_ENABLE: + *type =3D SCMI_PIN_INPUT_MODE; + break; + case PIN_CONFIG_MODE_LOW_POWER: + *type =3D SCMI_PIN_LOW_POWER_MODE; + break; + case PIN_CONFIG_OUTPUT: + *type =3D SCMI_PIN_OUTPUT_VALUE; + break; + case PIN_CONFIG_OUTPUT_ENABLE: + *type =3D SCMI_PIN_OUTPUT_MODE; + break; + case PIN_CONFIG_OUTPUT_IMPEDANCE_OHMS: + *type =3D SCMI_PIN_OUTPUT_VALUE; + break; + case PIN_CONFIG_POWER_SOURCE: + *type =3D SCMI_PIN_POWER_SOURCE; + break; + case PIN_CONFIG_SLEW_RATE: + *type =3D SCMI_PIN_SLEW_RATE; + break; + case SCMI_PIN_OEM_START ... SCMI_PIN_OEM_END: + *type =3D arg; + break; + default: + return -EINVAL; + } + + return 0; +} + +static int pinctrl_scmi_pinconf_get(struct pinctrl_dev *pctldev, + unsigned int _pin, unsigned long *config) +{ + int ret; + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + enum pin_config_param config_type; + enum scmi_pinctrl_conf_type type; + u32 config_value; + + if (!config) + return -EINVAL; + + config_type =3D pinconf_to_config_param(*config); + + ret =3D pinctrl_scmi_map_pinconf_type(config_type, &type); + if (ret) + return ret; + + ret =3D pinctrl_ops->settings_get(pmx->ph, _pin, PIN_TYPE, type, + &config_value); + if (ret) + return ret; + + *config =3D pinconf_to_config_packed(config_type, config_value); + + return 0; +} + +static int +pinctrl_scmi_alloc_configs(struct pinctrl_dev *pctldev, u32 num_configs, + u32 **p_config_value, + enum scmi_pinctrl_conf_type **p_config_type) +{ + if (num_configs <=3D SCMI_NUM_CONFIGS) + return 0; + + *p_config_value =3D kcalloc(num_configs, sizeof(u32), GFP_KERNEL); + *p_config_type =3D kcalloc(num_configs, + sizeof(enum scmi_pinctrl_conf_type), + GFP_KERNEL); + + if (!*p_config_value || !*p_config_type) { + kfree(*p_config_value); + kfree(*p_config_type); + return -ENOMEM; + } + + return 0; +} + +static void +pinctrl_scmi_free_configs(struct pinctrl_dev *pctldev, u32 num_configs, + u32 **p_config_value, + enum scmi_pinctrl_conf_type **p_config_type) +{ + if (num_configs <=3D SCMI_NUM_CONFIGS) + return; + + kfree(*p_config_value); + kfree(*p_config_type); +} + +static int pinctrl_scmi_pinconf_set(struct pinctrl_dev *pctldev, + unsigned int _pin, + unsigned long *configs, + unsigned int num_configs) +{ + int i, ret; + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + enum scmi_pinctrl_conf_type config_type[SCMI_NUM_CONFIGS]; + u32 config_value[SCMI_NUM_CONFIGS]; + enum scmi_pinctrl_conf_type *p_config_type =3D config_type; + u32 *p_config_value =3D config_value; + enum pin_config_param param; + + if (!configs || !num_configs) + return -EINVAL; + + ret =3D pinctrl_scmi_alloc_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + if (ret) + return ret; + + for (i =3D 0; i < num_configs; i++) { + param =3D pinconf_to_config_param(configs[i]); + ret =3D pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + if (ret) { + dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); + goto free_config; + } + p_config_value[i] =3D pinconf_to_config_argument(configs[i]); + } + + ret =3D pinctrl_ops->settings_conf(pmx->ph, _pin, PIN_TYPE, num_configs, + p_config_type, p_config_value); + if (ret) + dev_err(pmx->dev, "Error parsing config %d\n", ret); + +free_config: + pinctrl_scmi_free_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + return ret; +} + +static int pinctrl_scmi_pinconf_group_set(struct pinctrl_dev *pctldev, + unsigned int group, + unsigned long *configs, + unsigned int num_configs) +{ + int i, ret; + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + enum scmi_pinctrl_conf_type config_type[SCMI_NUM_CONFIGS]; + u32 config_value[SCMI_NUM_CONFIGS]; + enum scmi_pinctrl_conf_type *p_config_type =3D config_type; + u32 *p_config_value =3D config_value; + enum pin_config_param param; + + if (!configs || !num_configs) + return -EINVAL; + + ret =3D pinctrl_scmi_alloc_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + if (ret) + return ret; + + for (i =3D 0; i < num_configs; i++) { + param =3D pinconf_to_config_param(configs[i]); + ret =3D pinctrl_scmi_map_pinconf_type(param, + &p_config_type[i]); + if (ret) { + dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); + goto free_config; + } + + p_config_value[i] =3D pinconf_to_config_argument(configs[i]); + } + + ret =3D pinctrl_ops->settings_conf(pmx->ph, group, GROUP_TYPE, + num_configs, p_config_type, + p_config_value); + if (ret) + dev_err(pmx->dev, "Error parsing config %d", ret); + +free_config: + pinctrl_scmi_free_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + return ret; +}; + +static int pinctrl_scmi_pinconf_group_get(struct pinctrl_dev *pctldev, + unsigned int group, + unsigned long *config) +{ + int ret; + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + enum pin_config_param config_type; + enum scmi_pinctrl_conf_type type; + u32 config_value; + + if (!config) + return -EINVAL; + + config_type =3D pinconf_to_config_param(*config); + ret =3D pinctrl_scmi_map_pinconf_type(config_type, &type); + if (ret) { + dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); + return ret; + } + + ret =3D pinctrl_ops->settings_get(pmx->ph, group, GROUP_TYPE, type, + &config_value); + if (ret) + return ret; + + *config =3D pinconf_to_config_packed(config_type, config_value); + + return 0; +} + +static const struct pinconf_ops pinctrl_scmi_pinconf_ops =3D { + .is_generic =3D true, + .pin_config_get =3D pinctrl_scmi_pinconf_get, + .pin_config_set =3D pinctrl_scmi_pinconf_set, + .pin_config_group_set =3D pinctrl_scmi_pinconf_group_set, + .pin_config_group_get =3D pinctrl_scmi_pinconf_group_get, + .pin_config_config_dbg_show =3D pinconf_generic_dump_config, +}; + +static int pinctrl_scmi_get_pins(struct scmi_pinctrl *pmx, + struct pinctrl_desc *desc) +{ + struct pinctrl_pin_desc *pins; + unsigned int npins; + int ret, i; + + npins =3D pinctrl_ops->count_get(pmx->ph, PIN_TYPE); + pins =3D devm_kmalloc_array(pmx->dev, npins, sizeof(*pins), GFP_KERNEL); + if (!pins) + return -ENOMEM; + + for (i =3D 0; i < npins; i++) { + pins[i].number =3D i; + ret =3D pinctrl_ops->name_get(pmx->ph, i, PIN_TYPE, &pins[i].name); + if (ret) + return dev_err_probe(pmx->dev, ret, + "Can't get name for pin %d", i); + } + + desc->npins =3D npins; + desc->pins =3D pins; + dev_dbg(pmx->dev, "got pins %d", npins); + + return 0; +} + +static const struct scmi_device_id scmi_id_table[] =3D { + { SCMI_PROTOCOL_PINCTRL, "pinctrl" }, + { } +}; +MODULE_DEVICE_TABLE(scmi, scmi_id_table); + +static int scmi_pinctrl_probe(struct scmi_device *sdev) +{ + int ret; + struct device *dev =3D &sdev->dev; + struct scmi_pinctrl *pmx; + const struct scmi_handle *handle; + struct scmi_protocol_handle *ph; + + if (!sdev || !sdev->handle) + return -EINVAL; + + handle =3D sdev->handle; + + pinctrl_ops =3D handle->devm_protocol_get(sdev, SCMI_PROTOCOL_PINCTRL, + &ph); + if (IS_ERR(pinctrl_ops)) + return PTR_ERR(pinctrl_ops); + + pmx =3D devm_kzalloc(dev, sizeof(*pmx), GFP_KERNEL); + if (!pmx) + return -ENOMEM; + + pmx->ph =3D ph; + + pmx->dev =3D dev; + pmx->pctl_desc.name =3D DRV_NAME; + pmx->pctl_desc.owner =3D THIS_MODULE; + pmx->pctl_desc.pctlops =3D &pinctrl_scmi_pinctrl_ops; + pmx->pctl_desc.pmxops =3D &pinctrl_scmi_pinmux_ops; + pmx->pctl_desc.confops =3D &pinctrl_scmi_pinconf_ops; + + ret =3D pinctrl_scmi_get_pins(pmx, &pmx->pctl_desc); + if (ret) + return ret; + + ret =3D devm_pinctrl_register_and_init(dev, &pmx->pctl_desc, pmx, + &pmx->pctldev); + if (ret) + return dev_err_probe(dev, ret, "Failed to register pinctrl\n"); + + pmx->nr_functions =3D pinctrl_scmi_get_functions_count(pmx->pctldev); + pmx->functions =3D devm_kcalloc(dev, pmx->nr_functions, + sizeof(*pmx->functions), + GFP_KERNEL); + if (!pmx->functions) + return -ENOMEM; + + return pinctrl_enable(pmx->pctldev); +} + +static struct scmi_driver scmi_pinctrl_driver =3D { + .name =3D DRV_NAME, + .probe =3D scmi_pinctrl_probe, + .id_table =3D scmi_id_table, +}; +module_scmi_driver(scmi_pinctrl_driver); + +MODULE_AUTHOR("Oleksii Moisieiev "); +MODULE_AUTHOR("Peng Fan "); +MODULE_DESCRIPTION("ARM SCMI pin controller driver"); +MODULE_LICENSE("GPL"); --=20 2.37.1