From nobody Fri Sep 20 03:45:45 2024 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8EA847A74 for ; Fri, 22 Mar 2024 13:26:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711114004; cv=none; b=N/uR23vjOrgOil2slO15yx9pv87XYqJ6AyFbMwkkKwcRimj9OKD78FVctS0guP0pDONTZvck6Kx1AZs4pHq/1TV68Ahn1CO5+ZBxD3vcwQsiePknIWoYXCWAKj2v7ztBupFcE1a//RErHLY6cUecqMHRPwgdLuZz8JOnj2WqNOw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711114004; c=relaxed/simple; bh=ym3gtFYbdGqQAg20b+BWubWlBx3M58XIGmfXCrpju9I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q6F/QtxlUMhx/GalGqOPQt4u1aneflas1nMKpmIm27EihkkKo4tqo45BlJGto53vzugW4AwqDB0eh8P/fTWjbIcRI+kGXrJ8uJpDSwhSJDdrGmDIbyQXWunPv06fu6SWkxGmf7jnbG6wMyeaiHWEdJNwKUiWUtmx5qGkAG9OWI8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=Vfk35MJS; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="Vfk35MJS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=+9eJDPYcvheHFhVWSeTXcV93NuGaWmWAwekU/Oh9CJ4=; b=Vfk35M JSUL85oEwdUpaoZywSUhRxjNWZFf91x1byAkI9WKNyJM/QbM1VfS2Fxb6cb2IvHT 1/EXdQaz2aj2f0uLFipQE/ze0asri/1BS+RMssCl4QWqbgQ2Xoa2z1IuQcT7oEFx jDeYf1s2IZJm0VYbTrom+PO5KqjUsZMIYQEhFIQ2FlGgoQ//LRU9/8CgWVdfQ67w mRKX5szDSTQWxcLnn+m7bw0lgL75+Tt1gb10JGDFSy5jiygKviWP/zbmJyLWToBt 7f79pX+sQ0F0Hl139XavzX7SymVIaIUVHIyDTZ3uCmjboWaGdqNZjk5CfBZjy896 Zl7wVryR1CdTCnQg== Received: (qmail 3870202 invoked from network); 22 Mar 2024 14:26:26 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 22 Mar 2024 14:26:26 +0100 X-UD-Smtp-Session: l3s3148p1@tj9VxT8UdJNehhtF From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andi Shyti , Ray Jui , Scott Branden , Broadcom internal kernel review list , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/64] i2c: bcm-iproc: reword according to newest specification Date: Fri, 22 Mar 2024 14:25:00 +0100 Message-ID: <20240322132619.6389-8-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240322132619.6389-1-wsa+renesas@sang-engineering.com> References: <20240322132619.6389-1-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Match the wording of this driver wrt. the newest I2C v7, SMBus 3.2, I3C specifications and replace "master/slave" with more appropriate terms. They are also more specific because we distinguish now between a remote entity ("client") and a local one ("target"). Signed-off-by: Wolfram Sang Reviewed-by: Andi Shyti --- drivers/i2c/busses/i2c-bcm-iproc.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bc= m-iproc.c index e905734c26a0..3c68d4df029f 100644 --- a/drivers/i2c/busses/i2c-bcm-iproc.c +++ b/drivers/i2c/busses/i2c-bcm-iproc.c @@ -224,8 +224,8 @@ static void slave_rx_tasklet_fn(unsigned long); | BIT(IS_S_TX_UNDERRUN_SHIFT) | BIT(IS_S_RX_FIFO_FULL_SHIFT)\ | BIT(IS_S_RX_THLD_SHIFT)) =20 -static int bcm_iproc_i2c_reg_slave(struct i2c_client *slave); -static int bcm_iproc_i2c_unreg_slave(struct i2c_client *slave); +static int bcm_iproc_i2c_reg_target(struct i2c_client *slave); +static int bcm_iproc_i2c_unreg_target(struct i2c_client *slave); static void bcm_iproc_i2c_enable_disable(struct bcm_iproc_i2c_dev *iproc_i= 2c, bool enable); =20 @@ -987,17 +987,17 @@ static uint32_t bcm_iproc_i2c_functionality(struct i2= c_adapter *adap) =20 val =3D I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; =20 - if (adap->algo->reg_slave) + if (adap->algo->reg_target) val |=3D I2C_FUNC_SLAVE; =20 return val; } =20 static struct i2c_algorithm bcm_iproc_algo =3D { - .master_xfer =3D bcm_iproc_i2c_xfer, + .xfer =3D bcm_iproc_i2c_xfer, .functionality =3D bcm_iproc_i2c_functionality, - .reg_slave =3D bcm_iproc_i2c_reg_slave, - .unreg_slave =3D bcm_iproc_i2c_unreg_slave, + .reg_target =3D bcm_iproc_i2c_reg_target, + .unreg_target =3D bcm_iproc_i2c_unreg_target, }; =20 static const struct i2c_adapter_quirks bcm_iproc_i2c_quirks =3D { @@ -1079,8 +1079,8 @@ static int bcm_iproc_i2c_probe(struct platform_device= *pdev) spin_lock_init(&iproc_i2c->idm_lock); =20 /* no slave support */ - bcm_iproc_algo.reg_slave =3D NULL; - bcm_iproc_algo.unreg_slave =3D NULL; + bcm_iproc_algo.reg_target =3D NULL; + bcm_iproc_algo.unreg_target =3D NULL; } =20 ret =3D bcm_iproc_i2c_init(iproc_i2c); @@ -1191,7 +1191,7 @@ static const struct dev_pm_ops bcm_iproc_i2c_pm_ops = =3D { .resume_early =3D &bcm_iproc_i2c_resume }; =20 -static int bcm_iproc_i2c_reg_slave(struct i2c_client *slave) +static int bcm_iproc_i2c_reg_target(struct i2c_client *slave) { struct bcm_iproc_i2c_dev *iproc_i2c =3D i2c_get_adapdata(slave->adapter); =20 @@ -1210,7 +1210,7 @@ static int bcm_iproc_i2c_reg_slave(struct i2c_client = *slave) return 0; } =20 -static int bcm_iproc_i2c_unreg_slave(struct i2c_client *slave) +static int bcm_iproc_i2c_unreg_target(struct i2c_client *slave) { u32 tmp; struct bcm_iproc_i2c_dev *iproc_i2c =3D i2c_get_adapdata(slave->adapter); --=20 2.43.0