From nobody Sun Feb 8 18:32:18 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F050664CF6 for ; Tue, 19 Mar 2024 08:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710837073; cv=none; b=fwwQesuqW4Eras5/8mehmA+skXVNcfjsjiaNtjjfXP34/SLyi4oN8f23ZogyqmQvpM24o0dgWptSnIMYKLJKaa25r6nBKD1mh+fT+EMiymS/VNtDOa17RegKCtcfJArJCh6/Xb6kkCnURT9Dve58z9pbNVnJxjrwy9hQiWZEPD8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710837073; c=relaxed/simple; bh=fmOWfAiXn5JgIfZTOxYLm6UhsznWCAvx11y3kFTcU98=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HyY0tq61aFmUEyKhQKADW5dHjmFBZJ3pET+9ZnKtzhVtG9Zepk/5pV/FWx8T+7Cpe1H7JwfavaXXk8f+Eh9+Ek5rf0QmVs3MaGhwXDp1Ez48kWIyhd0fBOEuPGobe23U1Nz5dMu1Kuaw9KnC74JpKass/FZBorwzQQKk9eic3iY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=shopee.com; spf=pass smtp.mailfrom=shopee.com; dkim=pass (2048-bit key) header.d=shopee.com header.i=@shopee.com header.b=UpSlbMZ3; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=shopee.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shopee.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shopee.com header.i=@shopee.com header.b="UpSlbMZ3" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-5e152c757a5so3210770a12.2 for ; Tue, 19 Mar 2024 01:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1710837071; x=1711441871; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uhlePUyQMcGbwxIcmHkKRTvaFKRtl8DibzkuUhf5pmI=; b=UpSlbMZ3bsa73I1F1Clvrs9HnTxaAGsG5tUOy35eO7XEgAUitq9HGPMQWY/6dFwGwa YRI0kuSIp3fgOJ7HJklgcDU+wnucZQJeoFANQzBuxG1ldzwL5TzpKcrdJ9LoLvy0hg9w +FFexWnuP9OkDTqSVgy3yQvZUtnr5FYiQph7WjpYsIxZ2B5y9nz+wNed17ur3yst2H65 UZTYRhQ8hQIF0jxB+6jCm4mo6Ad178ttFi5oSj2L3R2KzhZmnsmIIhYmAWwnAkXw5gMw CjvwhsX9KYSYuof7d/bQP8opl4EoIceUypee670YhoVUaYlQ3FRI/N4OrbynecLezWsB uU2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710837071; x=1711441871; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uhlePUyQMcGbwxIcmHkKRTvaFKRtl8DibzkuUhf5pmI=; b=kWb01AjABxPHTjVBj2LVEUHqinWRdJEWC5B7qbkzGHwBmDUcWaj1a0FwjTqNBoeHwv dXhIbOiAN9fQjpaw2OLblCdWZ4cD2xc9ECMotGunMltBbjfmJBztbIA2oA/H5FXWu9Er GbWqSflN1WEkf/HSqAKuoK3phzIW16DlvI91QD1i/CS7jn1lp5s84yLq99kOX49miu+y H+6e7E4mKEMP/h3VhmHfqjA9rHN3NYYeOAMSl1hLOoyFQ1hyjF8iRhTkpixRD1ToRiFS jG0lsY8291N6VQc3UpSPKwphwzNQv30igN7Sq396JMMmsGudJTBWN9ifRJcJ6sdYYNVZ jx5g== X-Forwarded-Encrypted: i=1; AJvYcCX1LinLJjMJja7kmdTPW7wr9tX+Zi5CMki9VciCmwsYfqSt1ea076gN2UV1LwL8n4X9i6bQExwjT9CanQfu6RkdK4TWvtHrPgzDV9aU X-Gm-Message-State: AOJu0YwJZyS2gJK9VZdY+C85b3ZKTyDB7aXJ7VtLXXDLv373SYRpu7v0 QtRb0G2Lj17QKezBIMJPg+RVjDAX6tthdbIhPBt0aoc/LO/HtbAXhZA3zhzkh/M= X-Google-Smtp-Source: AGHT+IEEOx1QN+FnvnNHyn5wv9Yey+cdtr0ZipoHpMBzfmj2SYIVkorS1uiwzI7pKA3FF5HOyUnCJQ== X-Received: by 2002:a17:90b:4c06:b0:29f:e024:8f48 with SMTP id na6-20020a17090b4c0600b0029fe0248f48mr456943pjb.35.1710837071435; Tue, 19 Mar 2024 01:31:11 -0700 (PDT) Received: from seacloud.vm ([143.92.64.20]) by smtp.gmail.com with ESMTPSA id k90-20020a17090a4ce300b0029ddd0a6ed4sm9941249pjh.38.2024.03.19.01.31.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 01:31:11 -0700 (PDT) From: Haifeng Xu To: reinette.chatre@intel.com, james.morse@arm.com Cc: fenghua.yu@intel.com, babu.moger@amd.com, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com, peternewman@google.com, x86@kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, Haifeng Xu Subject: [PATCH v6 1/2] x86/resctrl: Rename pseudo_lock_event.h to trace.h Date: Tue, 19 Mar 2024 16:30:38 +0800 Message-Id: <20240319083039.223088-2-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240319083039.223088-1-haifeng.xu@shopee.com> References: <20240319083039.223088-1-haifeng.xu@shopee.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now only pseudo-locking part uses tracepoints to do event tracking, but other parts of resctrl may need new tracepoints. It is unnecessary to create separate header files and define CREATE_TRACE_POINTS in different c files which fragments the resctrl tracing. Therefore, give the resctrl tracepoint header file a generic name to support its use for tracepoints that are not specific to pseudo-locking. No functional change. Signed-off-by: Haifeng Xu Suggested-by: Reinette Chatre --- arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 2 +- .../kernel/cpu/resctrl/{pseudo_lock_event.h =3D> trace.h} | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) rename arch/x86/kernel/cpu/resctrl/{pseudo_lock_event.h =3D> trace.h} (86%) diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cp= u/resctrl/pseudo_lock.c index 884b88e25141..492c8e28c4ce 100644 --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c +++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c @@ -31,7 +31,7 @@ #include "internal.h" =20 #define CREATE_TRACE_POINTS -#include "pseudo_lock_event.h" +#include "trace.h" =20 /* * The bits needed to disable hardware prefetching varies based on the diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock_event.h b/arch/x86/ker= nel/cpu/resctrl/trace.h similarity index 86% rename from arch/x86/kernel/cpu/resctrl/pseudo_lock_event.h rename to arch/x86/kernel/cpu/resctrl/trace.h index 428ebbd4270b..495fb90c8572 100644 --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock_event.h +++ b/arch/x86/kernel/cpu/resctrl/trace.h @@ -2,8 +2,8 @@ #undef TRACE_SYSTEM #define TRACE_SYSTEM resctrl =20 -#if !defined(_TRACE_PSEUDO_LOCK_H) || defined(TRACE_HEADER_MULTI_READ) -#define _TRACE_PSEUDO_LOCK_H +#if !defined(_TRACE_RESCTRL_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_RESCTRL_H =20 #include =20 @@ -35,9 +35,9 @@ TRACE_EVENT(pseudo_lock_l3, TP_printk("hits=3D%llu miss=3D%llu", __entry->l3_hits, __entry->l3_miss)); =20 -#endif /* _TRACE_PSEUDO_LOCK_H */ +#endif /* _TRACE_RESCTRL_H */ =20 #undef TRACE_INCLUDE_PATH #define TRACE_INCLUDE_PATH . -#define TRACE_INCLUDE_FILE pseudo_lock_event +#define TRACE_INCLUDE_FILE trace #include --=20 2.25.1 From nobody Sun Feb 8 18:32:18 2026 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D5927CF2B for ; Tue, 19 Mar 2024 08:31:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710837078; cv=none; b=U6co1rpz+nLv6SHhyqk/7SWY5rSQi2qF6jbN7DhdueaIb+g4x5e/vgrsHlEvae8S8TB8k/3h91cm2/w6b3JIvIKYIwecEVnTAsZM+VEOQ5Yek750uejKG+Q6cNOqz2Snv/3td2dcnBpZGU8Dze9RcLRMsBfRv/KI/9Z+rCj75vk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710837078; c=relaxed/simple; bh=J2se5fvnUGcTj0hc0l9rWZF4ioGXQ1l7de9vUtV2PYg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QOEQqXM4cfLDp/mlu+AdHnTK4/4i2Ci/A2UztxtxCxaaaZwbTc7sRD4N2RURxpbiSX3os4wsN7z+riiHkcAKboBbwjdKmSe6upoAgNxHmsCvvLmH/KtL8GUgMWUIRBalou3cUgB66NZLQ6EQGp1yjoDN9wKkTvK0j4qqHfaLEYs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=shopee.com; spf=pass smtp.mailfrom=shopee.com; dkim=pass (2048-bit key) header.d=shopee.com header.i=@shopee.com header.b=hBzbMK8w; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=shopee.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shopee.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shopee.com header.i=@shopee.com header.b="hBzbMK8w" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-29de4e12d12so3687712a91.3 for ; Tue, 19 Mar 2024 01:31:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1710837076; x=1711441876; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E+qIFovagdwOaZudBEiFBEikr4wHyxCWEpm+zwt1qQg=; b=hBzbMK8weHs27yZM65hMQd5OO+v3dMLv8OAUqMD2J/BFiZDfub+Zx3M+50r/QBFan3 5cMZ7QzpCAZhKVr+RYLw2XYrckQjdD+FfUw17Wo3zUJo2VggLh56rNBu3YO6s08fksFk RyKO8BU9dXtCuSM2thDDsbJaFV6IIpOFpQuStW0DMlU2vsqTVg4y3+1a0TuMiPAmgEbX YB0xyG4ghjRXVSWfZIBb7bhC4U3B1BloRfTfV0PtHsx89f52wh2ODn/7Xnn/3hH2i/K0 77CQm36amMkVCmTaL/bmk1qgqDNwhJ8ssk2asXbAjYJQOXhLvY66Pn5lDnB5gsXNHwzB S96A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710837076; x=1711441876; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E+qIFovagdwOaZudBEiFBEikr4wHyxCWEpm+zwt1qQg=; b=DBzcSRvS8tUaldn0nEHBdAd9G5PiD7L+V5+15BJ0rlCEcFYcaIa8g4StgHBksdo618 qVKsyN8eo+wCv3wKt3j/2Ri4FsZ9Wy6QPVPZGjcZRMTOgYfcdOp5R/KEG9s+LZy8Jpmq BYY3S4ZL0b1WWLMQT3E3CfxcTtl7YSZSWSuE90o6cc+UjkV4TQDU+0puvxKY6gvkilH3 ATz9gJnQh8WAucJw7qWYLKVE7iZo20aAm3wrC/PFE/R9FInsBk8XXJpJtHMk21GPfFnk nFoOuSFkd8fNTWIEL68mtzI9M0BUv3wMvCkVzBCxOZd6F2GQAytUER7GQAMS7Zc0ELtt cZTA== X-Forwarded-Encrypted: i=1; AJvYcCUrzuiFIL9/PIgNgXMzgQdKTdyBuhwDNreKW+JCIYmOPYNRv4rvVebRu0CRkRLIYX12DmlGPN3sTYHis1VNxptZGuRKscVyQzp1y8dh X-Gm-Message-State: AOJu0YzJz5UyFXxAGc6VyEQbTzAMV2rpwslQstjrO3n62UkDcLf46z/j S9lsp/P/HKeJLxH78bvvpsijDKCach6fuaDoTDyLiTDsuhPKZ261buXyo4E9bTM= X-Google-Smtp-Source: AGHT+IFex9atMmMmBhVDdqnil0ivUGoZhIUaQrm1iwnIvGqQ8WVv5b4Rs80bhy9hzT8WQ85RtyWiiA== X-Received: by 2002:a17:90b:2d0c:b0:29f:6d8d:dacb with SMTP id sy12-20020a17090b2d0c00b0029f6d8ddacbmr5914625pjb.4.1710837076439; Tue, 19 Mar 2024 01:31:16 -0700 (PDT) Received: from seacloud.vm ([143.92.64.20]) by smtp.gmail.com with ESMTPSA id k90-20020a17090a4ce300b0029ddd0a6ed4sm9941249pjh.38.2024.03.19.01.31.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 01:31:16 -0700 (PDT) From: Haifeng Xu To: reinette.chatre@intel.com, james.morse@arm.com Cc: fenghua.yu@intel.com, babu.moger@amd.com, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com, peternewman@google.com, x86@kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, Haifeng Xu Subject: [PATCH v6 2/2] x86/resctrl: Add tracepoint for llc_occupancy tracking Date: Tue, 19 Mar 2024 16:30:39 +0800 Message-Id: <20240319083039.223088-3-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240319083039.223088-1-haifeng.xu@shopee.com> References: <20240319083039.223088-1-haifeng.xu@shopee.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In our production environment, after removing monitor groups, those unused RMIDs get stuck in the limbo list forever because their llc_occupancy are always larger than the threshold. But the unused RMIDs can be successfully freed by turning up the threshold. In order to know how much the threshold should be, perf can be used to acquire the llc_occupancy of RMIDs in each rdt domain. Instead of using perf tool to track llc_occupancy and filter the log manually, it is more convenient for users to use tracepoint to do this work. So add a new tracepoint that shows the llc_occupancy of busy RMIDs when scanning the limbo list. Signed-off-by: Haifeng Xu Suggested-by: Reinette Chatre Suggested-by: James Morse Reviewed-by: James Morse --- Documentation/arch/x86/resctrl.rst | 6 ++++++ arch/x86/kernel/cpu/resctrl/monitor.c | 11 +++++++++++ arch/x86/kernel/cpu/resctrl/trace.h | 16 ++++++++++++++++ 3 files changed, 33 insertions(+) diff --git a/Documentation/arch/x86/resctrl.rst b/Documentation/arch/x86/re= sctrl.rst index a6279df64a9d..bcdbd23cd8a7 100644 --- a/Documentation/arch/x86/resctrl.rst +++ b/Documentation/arch/x86/resctrl.rst @@ -446,6 +446,12 @@ during mkdir. max_threshold_occupancy is a user configurable value to determine the occupancy at which an RMID can be freed. =20 +The mon_llc_occupancy_limbo tracepoint gives the precise occupancy in bytes +for a subset of RMID that are not immediately available for allocation. +This can't be relied on to produce output every second, it may be necessary +to attempt to create an empty monitor group to force an update. Output may +only be produced if creation of a control or monitor group fails. + Schemata files - general concepts --------------------------------- Each line in the file describes one resource. The line starts with diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/re= sctrl/monitor.c index c34a35ec0f03..2345e6836593 100644 --- a/arch/x86/kernel/cpu/resctrl/monitor.c +++ b/arch/x86/kernel/cpu/resctrl/monitor.c @@ -24,6 +24,7 @@ #include =20 #include "internal.h" +#include "trace.h" =20 /** * struct rmid_entry - dirty tracking for all RMID. @@ -354,6 +355,16 @@ void __check_limbo(struct rdt_domain *d, bool force_fr= ee) rmid_dirty =3D true; } else { rmid_dirty =3D (val >=3D resctrl_rmid_realloc_threshold); + + /* + * x86's CLOSID and RMID are independent numbers, so the entry's + * CLOSID is an empty CLOSID (X86_RESCTRL_EMPTY_CLOSID). On Arm the + * RMID (PMG) extends the CLOSID (PARTID) space with bits that aren't + * used to select the configuration. It is thus necessary to track both + * CLOSID and RMID because there may be dependencies between them + * on some architectures. + */ + trace_mon_llc_occupancy_limbo(entry->closid, entry->rmid, d->id, val); } =20 if (force_free || !rmid_dirty) { diff --git a/arch/x86/kernel/cpu/resctrl/trace.h b/arch/x86/kernel/cpu/resc= trl/trace.h index 495fb90c8572..2a506316b303 100644 --- a/arch/x86/kernel/cpu/resctrl/trace.h +++ b/arch/x86/kernel/cpu/resctrl/trace.h @@ -35,6 +35,22 @@ TRACE_EVENT(pseudo_lock_l3, TP_printk("hits=3D%llu miss=3D%llu", __entry->l3_hits, __entry->l3_miss)); =20 +TRACE_EVENT(mon_llc_occupancy_limbo, + TP_PROTO(u32 ctrl_hw_id, u32 mon_hw_id, int domain_id, u64 llc_occupa= ncy_bytes), + TP_ARGS(ctrl_hw_id, mon_hw_id, domain_id, llc_occupancy_bytes), + TP_STRUCT__entry(__field(u32, ctrl_hw_id) + __field(u32, mon_hw_id) + __field(int, domain_id) + __field(u64, llc_occupancy_bytes)), + TP_fast_assign(__entry->ctrl_hw_id =3D ctrl_hw_id; + __entry->mon_hw_id =3D mon_hw_id; + __entry->domain_id =3D domain_id; + __entry->llc_occupancy_bytes =3D llc_occupancy_bytes;), + TP_printk("ctrl_hw_id=3D%u mon_hw_id=3D%u domain_id=3D%d llc_occupanc= y_bytes=3D%llu", + __entry->ctrl_hw_id, __entry->mon_hw_id, __entry->domain_id, + __entry->llc_occupancy_bytes) + ); + #endif /* _TRACE_RESCTRL_H */ =20 #undef TRACE_INCLUDE_PATH --=20 2.25.1