From nobody Mon Feb 9 19:53:51 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BB497C093 for ; Tue, 19 Mar 2024 07:27:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710833263; cv=none; b=Sb/Qm6754rhVf/zKUUlx94tk+31cWgYacJQANFV7+e5Wvk68hebYxOgmHcFB0xWEam8afu80J5Oydsc0yOJdWFzh0gEcXLTW0enChs7JmlM3ufRtag3lEgOp1YDSmOK2CGrE7L6Gi5nbi4a1rtWpLc0QGcpdDDNUx+GdIv83qeY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710833263; c=relaxed/simple; bh=44YruKIFMTjc0cJLAC1iQg1GbtFM4OBpdvY6e1NRpRU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PVkgWyidS//ZKB3Nncw/7Y0gi1AdusdRKHUk5oodwSSpIQjGt8i5j+Auj4OC5WCDmG62qfdsTlXy090s1zJbRgjpJ9ccrjjsMBq5QBWI1ml7n57VRt9fAZyXmuie0W47jncbmuV+euii3tYbZ+4H7OzoqR/+viL3ety2TZpnT4o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=h4zSvmL5; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="h4zSvmL5" Received: from umang.jain (unknown [103.86.18.138]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AB6FFC80; Tue, 19 Mar 2024 08:27:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1710833234; bh=44YruKIFMTjc0cJLAC1iQg1GbtFM4OBpdvY6e1NRpRU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h4zSvmL5jjsgHzVvn8+aA4K3gRg+FMBiX8waAAikkisV3lIBlEKusWPGJQpJN+vdZ KxkhT0ydv2d8yu0pSqZApXX3/i8k/uu03OrhtZ7ONWJSsaPkTujk6zGml5kpB1XBqE kfC/5BYVk/SixUBNSaEEwSQwkzphMqdHtdHh9VXg= From: Umang Jain To: Alexander Shiyan , Kieran Bingham , Sakari Ailus , open list , Dave Stevenson Cc: Umang Jain Subject: [PATCH v3 5/6] media: imx335: Fix active area height discrepency Date: Tue, 19 Mar 2024 12:57:11 +0530 Message-ID: <20240319072712.133449-6-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240319072712.133449-1-umang.jain@ideasonboard.com> References: <20240319072712.133449-1-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The imx335 reports a recommended pixel area of - 2592x1944. The driver supported mode however limits it to height=3D1940. Fix the height discrepency by correctly the value of height (with updates to vblank and mode registers). Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham --- drivers/media/i2c/imx335.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c index 7609dbc537b1..10a09830dbd6 100644 --- a/drivers/media/i2c/imx335.c +++ b/drivers/media/i2c/imx335.c @@ -247,13 +247,13 @@ static const int imx335_tpg_val[] =3D { }; =20 /* Sensor mode registers */ -static const struct cci_reg_sequence mode_2592x1940_regs[] =3D { +static const struct cci_reg_sequence mode_2592x1944_regs[] =3D { {IMX335_REG_MODE_SELECT, 0x01}, {IMX335_REG_MASTER_MODE, 0x00}, - {IMX335_REG_WINMODE, 0x04}, - {IMX335_REG_HTRIMMING_START, 384}, + {IMX335_REG_WINMODE, 0x00}, + {IMX335_REG_HTRIMMING_START, 48}, {IMX335_REG_HNUM, 2592}, - {IMX335_REG_Y_OUT_SIZE, 1940}, + {IMX335_REG_Y_OUT_SIZE, 1944}, {IMX335_REG_AREA3_ST_ADR_1, 176}, {IMX335_REG_AREA3_WIDTH_1, 3928}, {IMX335_REG_OPB_SIZE_V, 0}, @@ -404,15 +404,15 @@ static const u32 imx335_mbus_codes[] =3D { /* Supported sensor mode configurations */ static const struct imx335_mode supported_mode =3D { .width =3D 2592, - .height =3D 1940, + .height =3D 1944, .hblank =3D 342, - .vblank =3D 2560, - .vblank_min =3D 2560, + .vblank =3D 2556, + .vblank_min =3D 2556, .vblank_max =3D 133060, .pclk =3D 396000000, .reg_list =3D { - .num_of_regs =3D ARRAY_SIZE(mode_2592x1940_regs), - .regs =3D mode_2592x1940_regs, + .num_of_regs =3D ARRAY_SIZE(mode_2592x1944_regs), + .regs =3D mode_2592x1944_regs, }, }; =20 --=20 2.43.0