From nobody Mon Feb 9 06:08:09 2026 Received: from wfout8-smtp.messagingengine.com (wfout8-smtp.messagingengine.com [64.147.123.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5665D2C18F for ; Mon, 18 Mar 2024 09:18:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.123.151 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710753488; cv=none; b=Fg0Prh4uZhjK/5Ffbz9QHBdNErzGMCnVHQ9Yjq6SWXwUVTeDdCGTwZHCyLWaYhsKy1TIPbHYe8fABYkRW9i4RfF1qF9yG+UcWWUshv9ejaH65e4AqqW6+O82cS1mDfLJwXxN+gSVGKOY8p6EoH10Z90w6rB0jZlwwJdsO+nWlFc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710753488; c=relaxed/simple; bh=ScHSHwihvRsqyvfslSI+2wXoLFxmTbTzzKqARaQ7TsA=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PbRnAjdqaBezXy8m+knQ25u8uka8roWpsZxtSrfV3D305L/RvUNP/4Qn1bNB24SUbQXebE4ZZHO3uSVhCz+TioswHrCpS+yJLRCujZ+WKOHkME82AqEnvj0Iub+JqKYfnSGCWKWOGwbepjTmwGThH0v28+Ksa8NrWhf/Mqoy/+s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=W+VR4C0e; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=EnLSYf1e; arc=none smtp.client-ip=64.147.123.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="W+VR4C0e"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="EnLSYf1e" Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.west.internal (Postfix) with ESMTP id 380841C0009B; Mon, 18 Mar 2024 05:18:05 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 18 Mar 2024 05:18:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1710753484; x= 1710839884; bh=0RFvEZpgNJ5bK7Ro7X/Ka3XCibshAo7oB/5HUK+KVBQ=; b=W +VR4C0elU/mSiDZEMxJNgm8ecHs24zUwrCfoKXI6jHzCUup1ZQwHlsFExsw3PExE Td62LmG0S7JZWIeXnHfLH8GgGppcOwO31tSPu9B2RIC2wZJH9Gg1LDvnFoJEOyto oi5A7fXOFYN1lQC8hNrIxH13YGVY4Lc+3fXxs77BqfE3+Wx0lvOr4ykMQBdoOIqu Rs/JPLqTSz8MAwIaX+MLf8jPOfuF7nDhKF/R1oa8OHumeS635rZplq33arIc+RjC fYkgzYjjdf6DJttZAa+/4/J4i20DHun0qd6/NYro7RcLtvToDJAy03YdNF4d0fqQ balp2nQ8aFaLuAj4wqp2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1710753484; x=1710839884; bh=0RFvEZpgNJ5bK 7Ro7X/Ka3XCibshAo7oB/5HUK+KVBQ=; b=EnLSYf1e1waplDHDfU5zLBTOlmZ84 TPUujIVTZER0+vNoZwDUgpNpOJJ7SaUdoq0QIVamwDPwKZHtOrmLOFjtVLMCIhR2 IUSF+vh9TOqtXpNgF93o7NjsvpswJeypir6G7K8rfUthULAnKn6cY3W4YMVDMrwW +jgIl8TWkqC/XWcMkzNPw8HJDpkYLWyRFoLJ4MpubEZsq61MDNNZ6+p9sGjhRgaC iUgzmZQojp45rnEumFjfDeJxfFgUC2gTQ11kaj5O2+2xrQmVXsolY1sXdffAO9uJ uiqhm0allXYsdfV73xi7SB15KGfL6SZgYqB5HJXi6FgNZolouxdXSF2fw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrkeejgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtkeertd ertddtnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohhtohcuoehoqdhtrghkrghs hhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrghtthgvrhhnpeevfefffeekte fgveegfeelheffhfeujedtjeevtefhkeevkedtjeejvddtjefhjeenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqdhtrghkrghshhhisehsrg hkrghmohgttghhihdrjhhp X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Mar 2024 05:18:03 -0400 (EDT) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH] firewire: core: add memo about the caller of show functions for device attributes Date: Mon, 18 Mar 2024 18:17:58 +0900 Message-ID: <20240318091759.678326-1-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240318044609.GA659599@workstation.local> References: <20240318044609.GA659599@workstation.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the case of firewire core function, the caller of show functions for device attributes is not only sysfs user, but also device initialization. This commit adds memo about it against the typical assumption that the functions are just dedicated to sysfs user. Signed-off-by: Takashi Sakamoto --- drivers/firewire/core-device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/firewire/core-device.c b/drivers/firewire/core-device.c index f208a02d0ebf..a8172a6c2caa 100644 --- a/drivers/firewire/core-device.c +++ b/drivers/firewire/core-device.c @@ -322,6 +322,7 @@ static ssize_t show_immediate(struct device *dev, if (value < 0) return -ENOENT; =20 + // Note that this function is called by init_fw_attribute_group() with NU= LL pointer. return buf ? sysfs_emit(buf, "0x%06x\n", value) : 0; } =20 @@ -357,6 +358,7 @@ static ssize_t show_text_leaf(struct device *dev, } } =20 + // Note that this function is called by init_fw_attribute_group() with NU= LL pointer. if (buf) { bufsize =3D PAGE_SIZE - 1; } else { --=20 2.43.0