From nobody Fri Dec 19 04:18:34 2025 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA7A622EFD for ; Mon, 18 Mar 2024 07:19:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710746355; cv=none; b=cL0EFBHC8q6Hl0z+tFS/N+YPOZYNYACAnIg7BVIHK+rbWlR9fNiC0y0pCD6pVHHIcKPe5lTFbLB9lkjzKbEInFC50RsAhLrME0kF55AHl4Ip8HJ9rAtzPUnqfqPDqQdDaYNZH8IzKdLfohMisKmXZGPWF80nS88Ub4sjPMQwMfU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710746355; c=relaxed/simple; bh=1v1aQLIYP8b+mI95hKqjB4PDKnC2GI6VXXU3JQllGfA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=u3l04j8JbHOtFlVNqTEqHyswuJNb1GMm+NWeHVyK43CFYPHlWRSa8+310smbrEOmf+NWzhrHiuLLuyFtq0FI9sn4QSzWcQp9m6J5ni+1VAgAoaBD1MOudTztNcAtX8hU4D7qAhLfWTQUmgAJ1H6uu/inLgd/RyS0zUVB1PINwrI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NFkWht3e; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NFkWht3e" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6e6bee809b8so3770960b3a.1 for ; Mon, 18 Mar 2024 00:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710746353; x=1711351153; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vq5Dos6DoYH4j6IedoqEyUOn4weuKjM4Z19kQDTr6Y0=; b=NFkWht3eQAH7ntsZchDqrXm7b+aU3x2abErjZN1B2hjh6Dj5F0/lNefQLmsEG3PsJC EIEiZNsW+H6uIWrC7irhlk48bTz6HIae7mzPhCDHh70VCztxxM/zXpBhcSMJdhmhqwmv l8DQ/5qz2lXCFPR+zG+OMTnQaT9NSto0RXGtjuB/8ifeN3luKeFMYO8I8St8mt4dGyHG O+pCeSCB6NrhYwzhonjvYYB2yg0npp1IpSJL1Y1qne9um1LXfJRDW80jQPA6zq7m7LsF duzYWQhvghyh6NxIms9HxB7wKij90B0PNIsnFjUN/TnLJ9aM8JDfJot+HvLoXdvI7CT+ /cEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710746353; x=1711351153; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vq5Dos6DoYH4j6IedoqEyUOn4weuKjM4Z19kQDTr6Y0=; b=h4F5s2OZlTGWyibbQ8nDPmHNfcGhOh5YHfphOtI9Qb6NDh/1Nx9gEAZrcuDHQzwnvj bJQnnWFzm1eewZvrHIOkAhLvcteUgrnSlQB9BEG9emO91GNgOBGwss+HJNj08KfS99HA mkJiK4L3iMDuc2iVuoizI0g/LicMmTJehJxNApavfQQbRbpAnENeWptVMR6PZHn9zevd 71WijyHlWXGbJxma5nTpflBGIpmdtTK9U4wMZHKzB7OLdlJT0ARM9B80VaAW/lkJqrLC ll8BIxdErOtbobKh48YPCKcxQhWRNMH3cLor2a49PS0JHiMsXvPUMKzOfIncf1tMEJM+ vh5A== X-Forwarded-Encrypted: i=1; AJvYcCVLspGFZBrruuS4lx0ZRy1wL4UPCzA467JsThrrVMGsFwJufhqe4b3sHyBAqsU6eolFIEfzigjRnE2M+yBtpdjze7uJArFg1xcqTEBN X-Gm-Message-State: AOJu0YzVry9o791Dby80SnOPZiUlhZDWq3Tq1KAaWhnK2iUEJ21PGyXY 6vvKJ9TIFTZaPj/Lq1UORuLNg/ppKrP1rSstwVyiRLpjV8roYUK6YrbH/vid0A== X-Google-Smtp-Source: AGHT+IFSMGfgI9ewcyB/Piyi5+UjAAibSDaWTk/5HkiYLVv/0ABTPRS3zbdmrJt1hEWYLIHu2wy2aQ== X-Received: by 2002:a05:6a00:2387:b0:6e6:a0de:563a with SMTP id f7-20020a056a00238700b006e6a0de563amr13811975pfc.15.1710746352955; Mon, 18 Mar 2024 00:19:12 -0700 (PDT) Received: from [127.0.1.1] ([103.246.195.160]) by smtp.gmail.com with ESMTPSA id x16-20020aa784d0000000b006e66c9bb00dsm7387515pfn.179.2024.03.18.00.19.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 00:19:12 -0700 (PDT) From: Manivannan Sadhasivam Date: Mon, 18 Mar 2024 12:49:03 +0530 Subject: [PATCH 1/3] arm64: dts: qcom: sm8450: Fix the msi-map entries Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240318-pci-bdf-sid-fix-v1-1-acca6c5d9cf1@linaro.org> References: <20240318-pci-bdf-sid-fix-v1-0-acca6c5d9cf1@linaro.org> In-Reply-To: <20240318-pci-bdf-sid-fix-v1-0-acca6c5d9cf1@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , stable@vger.kernel.org X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=2236; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=1v1aQLIYP8b+mI95hKqjB4PDKnC2GI6VXXU3JQllGfA=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBl9+rpsZJOD5LdQA2yEn0WyWcaDrhLmj04RjjXG pK/74qvqrSJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZffq6QAKCRBVnxHm/pHO 9S3KB/42QV76nv/mS1H0u1J7geOMOVeURxPRrCxDsTk47fvKgH/rXwLsRQb0ZmpAhlX+4wtI1i3 rzTYnJr+CZGzVYIWktiszpGZ+V2/CH7igul/6ekvW7QUKOa3xLUKRObTi/K8+MDNxQs8x0olJ6v JWKyOZ1JyWvQrGZB2+zIhAKKlURRRK0V/yfHzOktZQLH3DZXsHUOaBthHOPxDVIAXLDaqdPgBQv VzvW7ZBYviiTHCnUXHcrSFpIeo1o2qRpV28hL0FFdyB8OGyMgyGAfNDXFHqlV5GOQ3nhyQCSlOJ WxC8S2xcnpDAQISj7XlJGE3jaZxbpJ5Giu8m+KgVpXBKFzUn X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 While adding the GIC ITS MSI support, it was found that the msi-map entries needed to be swapped to receive MSIs from the endpoint. But later it was identified that the swapping was needed due to a bug in the Qualcomm PCIe controller driver. And since the bug is now fixed with commit bf79e33cdd89 ("PCI: qcom: Enable BDF to SID translation properly"), let's fix the msi-map entries also to reflect the actual mapping in the hardware. Cc: # 6.3: bf79e33cdd89 ("PCI: qcom: Enable BDF to= SID translation properly") Fixes: ff384ab56f16 ("arm64: dts: qcom: sm8450: Use GIC-ITS for PCIe0 and P= CIe1") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qco= m/sm8450.dtsi index b86be34a912b..024d2653cc30 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -1777,12 +1777,8 @@ pcie0: pcie@1c00000 { ranges =3D <0x01000000 0x0 0x00000000 0x0 0x60200000 0x0 0x100000>, <0x02000000 0x0 0x60300000 0x0 0x60300000 0x0 0x3d00000>; =20 - /* - * MSIs for BDF (1:0.0) only works with Device ID 0x5980. - * Hence, the IDs are swapped. - */ - msi-map =3D <0x0 &gic_its 0x5981 0x1>, - <0x100 &gic_its 0x5980 0x1>; + msi-map =3D <0x0 &gic_its 0x5980 0x1>, + <0x100 &gic_its 0x5981 0x1>; msi-map-mask =3D <0xff00>; interrupts =3D , , @@ -1900,12 +1896,8 @@ pcie1: pcie@1c08000 { ranges =3D <0x01000000 0x0 0x00000000 0x0 0x40200000 0x0 0x100000>, <0x02000000 0x0 0x40300000 0x0 0x40300000 0x0 0x1fd00000>; =20 - /* - * MSIs for BDF (1:0.0) only works with Device ID 0x5a00. - * Hence, the IDs are swapped. - */ - msi-map =3D <0x0 &gic_its 0x5a01 0x1>, - <0x100 &gic_its 0x5a00 0x1>; + msi-map =3D <0x0 &gic_its 0x5a00 0x1>, + <0x100 &gic_its 0x5a01 0x1>; msi-map-mask =3D <0xff00>; interrupts =3D , , --=20 2.25.1 From nobody Fri Dec 19 04:18:34 2025 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10E9424A08 for ; Mon, 18 Mar 2024 07:19:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710746358; cv=none; b=kyIU5uCExBmjPMH7mfKI3jzKAuVpQjge+l9R0I5qfqGeXMHMVThr5nPclwpM4j4at8Xdp2EMib2dV9TctZThE9hm2gNBmP2+nLUYpB5/GFjjueZ/MBDgxEfbRYQQmXgTfqo72R0xroueM3wt4fM2KZUP/xl86zerBBSawniTKoA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710746358; c=relaxed/simple; bh=T8yctEwOPXumvWXkHLXlcJBaV/u14z5lA6ODl0lFm9E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jj20YSHLfkR9GINS5Htb3HkYmH4HuVrq1yl/hKvgtbm3SHnEx8O6tyJz1It4N7csNE21ZOgzLp1JmN61fS28ljJm2AlcJRHNWK5A+ZHY7rBCz70rnW7FgqHdTJyKzGKU2tf9tbczCDlbIhcfUx4zjROuQjPEyj7ZTr3MgIuwLhE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oCXTHpq+; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oCXTHpq+" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3c37970b52aso1735265b6e.0 for ; Mon, 18 Mar 2024 00:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710746356; x=1711351156; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kH/SjGlGieE/UE0Ur3+4AtAfyoXMqizrw8NzFP+1cro=; b=oCXTHpq+tFaBzF425NcV+fNK/l272zvU3UNU8MTTqPfEjQf9KvQzdSg8uaijVfYlqF tEqLdqqcHwtOh8Ft8+JPGibpBE0gOYrKWN6jjyZM8KJSCGus2FwUldvIU8wQ4kDT4cn2 jRgVWDw7JaSRDncW7rdPYfg22MZfU7OYYOipSEvyke0RIMj3ajCXvZQQSQ/MFvIuO4hW +DXDMiftZGP6jlXbYnMlo3GJPtoPeCOkrFSDfftgnUUIGITSHNUqrt+Yh3xzEcdM4ZNc kWR5gROyoAnnsnj784ZV/BkgB3PxHj3Ergelkz0F21EncX2rEe00M3sChfMcvmst7l8u 9ZeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710746356; x=1711351156; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kH/SjGlGieE/UE0Ur3+4AtAfyoXMqizrw8NzFP+1cro=; b=wA8OGxy3+l3nuP5oNYpdrdcxnWg/9SKNt6CQKNIyuniFiJ6N/kbZ2ztmj5gZGLHf9l y6eDLci3YxkdJdAx7kGoY2AOH75XqpsNlKeamx0g1MFJVTa0iVsSYef2Gn7wvKlYc2tA MPiVYwOGPM6DyDkNGns9hX+y8udydcfQPe1l0W0tJeRoFqaXyKqrVDkbmQ/Edh2Rvbs5 kwYyNi/KHL8Sub2YJuP/p8WOWyEayYpJoECkUT7m/miCLFRFWF+j36BHefIbu90dates bEvpzThB1iEN+PE8lr6Axy6GVd8iMm4vPjA2bYAwBWgC6H5fhGCL/gk5J1cbQaMJXOzK u8+A== X-Forwarded-Encrypted: i=1; AJvYcCUBIoCAMTTsII4AsZ7IOlYuO34KRxW9dVyNJXE+hA+oEScuu55n5trKn7R/9G3mmJc5eqZgSQlvSzUpubtLTBKmUBE0nbtxJa7QgskP X-Gm-Message-State: AOJu0YwzcS4jhfPcbMDE3ucmYu8QRYAAO3yvIc5JxGGNwoxlAv9/bBQf daXhuWfpLELq8fjCgmCbNcZTDBwkhc0fHcB6Y8ZLT+nZADYoeMkpsTgKq+RI8A== X-Google-Smtp-Source: AGHT+IHxIQYzpr8+IRSVJKRQ1OUJWPiVuU+PBuEqfPt1lpHXTTs1DYOuDa4MdLLc0F7nvNoFemUNmg== X-Received: by 2002:a05:6871:64e:b0:221:6840:d131 with SMTP id x14-20020a056871064e00b002216840d131mr12314329oan.58.1710746356117; Mon, 18 Mar 2024 00:19:16 -0700 (PDT) Received: from [127.0.1.1] ([103.246.195.160]) by smtp.gmail.com with ESMTPSA id x16-20020aa784d0000000b006e66c9bb00dsm7387515pfn.179.2024.03.18.00.19.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 00:19:15 -0700 (PDT) From: Manivannan Sadhasivam Date: Mon, 18 Mar 2024 12:49:04 +0530 Subject: [PATCH 2/3] arm64: dts: qcom: sm8550: Fix the msi-map entries Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240318-pci-bdf-sid-fix-v1-2-acca6c5d9cf1@linaro.org> References: <20240318-pci-bdf-sid-fix-v1-0-acca6c5d9cf1@linaro.org> In-Reply-To: <20240318-pci-bdf-sid-fix-v1-0-acca6c5d9cf1@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1920; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=T8yctEwOPXumvWXkHLXlcJBaV/u14z5lA6ODl0lFm9E=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBl9+rpAPsEYVnQhIgS4XnxvfwLqtT1wLbJRKpe2 7uJrOvc7IeJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZffq6QAKCRBVnxHm/pHO 9d1TB/9+1iI7pQ3wD5B9FCFbbI1bPHp7Hgji13iYVbWt1Enxa7RJY1mGNo5a6waNiXyGNH77GPZ trh92uH6U8Ogdsa/gen7bSlpQu1895kCKDuXZ9VBWeJeiVGsa/84Y8xT62HuWk7Tf3bC+temrF7 6URzlYlbT/Aq3X34zsWumRfOX9kbM/IooL50T9gaAH8fgEUrwuAjAybVkgk9Nhq7CpbVQxa7neY lFxgBjW/BPd3+NknijLFn9cu6FZytJ1C9Xb30uo0iaXoAfxGNEYjPaX4uLeSPExjNvV3xv1wkQL e7r/tpZLFX8tNfZFbWKhhVJm4UNSUrqJJhbxNMOjxpIfQoB7 X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 While adding the GIC ITS MSI support, it was found that the msi-map entries needed to be swapped to receive MSIs from the endpoint. But later it was identified that the swapping was needed due to a bug in the Qualcomm PCIe controller driver. And since the bug is now fixed with commit bf79e33cdd89 ("PCI: qcom: Enable BDF to SID translation properly"), let's fix the msi-map entries also to reflect the actual mapping in the hardware. Fixes: 114990ce3edf ("arm64: dts: qcom: sm8550: Use GIC-ITS for PCIe0 and P= CIe1") Signed-off-by: Manivannan Sadhasivam Acked-by: Neil Armstrong Tested-by: Neil Armstrong # on SM8550-QRD --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qco= m/sm8550.dtsi index 3904348075f6..3348bc06db48 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -1755,9 +1755,8 @@ pcie0: pcie@1c00000 { <&gem_noc MASTER_APPSS_PROC 0 &cnoc_main SLAVE_PCIE_0 0>; interconnect-names =3D "pcie-mem", "cpu-pcie"; =20 - /* Entries are reversed due to the unusual ITS DeviceID encoding */ - msi-map =3D <0x0 &gic_its 0x1401 0x1>, - <0x100 &gic_its 0x1400 0x1>; + msi-map =3D <0x0 &gic_its 0x1400 0x1>, + <0x100 &gic_its 0x1401 0x1>; iommu-map =3D <0x0 &apps_smmu 0x1400 0x1>, <0x100 &apps_smmu 0x1401 0x1>; =20 @@ -1867,9 +1866,8 @@ pcie1: pcie@1c08000 { <&gem_noc MASTER_APPSS_PROC 0 &cnoc_main SLAVE_PCIE_1 0>; interconnect-names =3D "pcie-mem", "cpu-pcie"; =20 - /* Entries are reversed due to the unusual ITS DeviceID encoding */ - msi-map =3D <0x0 &gic_its 0x1481 0x1>, - <0x100 &gic_its 0x1480 0x1>; + msi-map =3D <0x0 &gic_its 0x1480 0x1>, + <0x100 &gic_its 0x1481 0x1>; iommu-map =3D <0x0 &apps_smmu 0x1480 0x1>, <0x100 &apps_smmu 0x1481 0x1>; =20 --=20 2.25.1 From nobody Fri Dec 19 04:18:34 2025 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 389A025763 for ; Mon, 18 Mar 2024 07:19:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710746362; cv=none; b=sHyMGrLQHNcjcU7VQz72cQ3X+gtylztJm0ioNCZzrk4OhWoZe0NdRfREnVZnva4PXnfz8C4rskpJ183Glxy7m7icIdr6DzQp06cuKN0+pY+9LFBx5yth5Vra3/cERWfp8A8ArUPatH8o8hARB6Ntv2jHaZ6avGUJ/al3twj4yt4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710746362; c=relaxed/simple; bh=rq/JWeJfwa+47UTE5z66gjbDrTKJLAljsi84x0YRn1E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aAjvT5NoEOlt+U4Atu1hAqkdASpqbYmPBpowkP9vVhzbs1xUKAvVIzpyNS5ADSEQV8d/3QL4OdtRBrXA5HI9rV6TsrsNf1GFV8t7oDFETPNqBZN6x4mwQQ9UI1mL/ejtaQrPoKxNtG4iW7bHZqqb+rsIP9ns1ic9Gl7y0zXN4/4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EHeZtgPE; arc=none smtp.client-ip=209.85.167.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EHeZtgPE" Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-3bd72353d9fso2436374b6e.3 for ; Mon, 18 Mar 2024 00:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710746359; x=1711351159; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=peDqrf3lDzXyT27A8hkXTSlSS0NQMm0NYY4FTf2ze+I=; b=EHeZtgPEE3EiEuSLPsy3uMr0EVavsgo7zuRtpsiH8kZyEMaXnU7DG7QVOW3Y5TuPum NZGiPP6xAjSU6GFCdyHH17a0CKDoyDeioSyYMfoFET28RzGAaMoaLaayPOH5NyRTsMVm 0mUxKqQL3BuYBrJ9gVmFwCII5HMPDEg5kI7VC1rlPLfFTATif/G9KY5ch/d/tAheR1HQ TfgKov1KM+J+tSrK5nSkxKPj+hLQ7JonqRkoKB3VuqQfrzdAB655qI9F+DFRGyFbKTFw a0vNTqgOVdkj4gnFwe2BxK+zH8J/L14i0+gGgA8VsQU/lhcL3UvH8MxSv5CWfwC7M8ni 4YCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710746359; x=1711351159; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=peDqrf3lDzXyT27A8hkXTSlSS0NQMm0NYY4FTf2ze+I=; b=boysI8S+4cBtxhyXtjxUnhvRr/2JXE15Db/S9BC/7bxHaHvrtFC/Yp2Jsk4gXG736A 5P7ihHg02Y0kslROeKiyHBgSU4stLN27yt5EqBX3r+D4aa+abF9c+qLddWyHiF4J79ke a1psenrVI5MXY3fJI70yMEjCUQSCz3r7eFEhP7iLX4nPMs2Pph9wWpu/yQ6dEEMtoflH 6OTCsWfLF9H0MmwJJGJfBbd6o2do3zeel9fEx0x6AjF7at3XdBFdN2EuNcjAFlMadJ/H bv5lKA07EevD7C3oaqjds6lj5uGc0iI9uytZAhZmq835soX9ALawHMelAG1SUPMfUpZz 2uSg== X-Forwarded-Encrypted: i=1; AJvYcCWnPkwRfJPe17fo+R6/VlIlorRj09XlOB4fBjU+zYCaUhLjNTyr0kmUuIWJnMq7j2UpsEN6mCIs9MLPbpnMBi4PMiREZFzDb39sHbKP X-Gm-Message-State: AOJu0Yzky6WolciHEyf+94cqeseSAKo4z4PTC033oV3+RcR/fxbAbLAJ WLSJQltOUe8KOjCXcfRfp4SBdwlu8sQWqsLMVpIsTFHhctRq2lO5bgYzN8htjw== X-Google-Smtp-Source: AGHT+IHCEXCkkicFHPqzMoJYtv957hUagwd50f9Vz56pVIGqLDE1HWdz5aTIjyYY+wc/RBG4HywTog== X-Received: by 2002:a05:6808:2e4b:b0:3c3:8830:86fe with SMTP id gp11-20020a0568082e4b00b003c3883086femr3449028oib.12.1710746359276; Mon, 18 Mar 2024 00:19:19 -0700 (PDT) Received: from [127.0.1.1] ([103.246.195.160]) by smtp.gmail.com with ESMTPSA id x16-20020aa784d0000000b006e66c9bb00dsm7387515pfn.179.2024.03.18.00.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 00:19:18 -0700 (PDT) From: Manivannan Sadhasivam Date: Mon, 18 Mar 2024 12:49:05 +0530 Subject: [PATCH 3/3] arm64: dts: qcom: sm8650: Fix the msi-map entries Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240318-pci-bdf-sid-fix-v1-3-acca6c5d9cf1@linaro.org> References: <20240318-pci-bdf-sid-fix-v1-0-acca6c5d9cf1@linaro.org> In-Reply-To: <20240318-pci-bdf-sid-fix-v1-0-acca6c5d9cf1@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1806; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=rq/JWeJfwa+47UTE5z66gjbDrTKJLAljsi84x0YRn1E=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBl9+rqpS3tSZyn5nT5m8XnYf433vP7qur3M016c weAuR6t29WJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZffq6gAKCRBVnxHm/pHO 9Sm0CACbPTZu35ob3v4W4ZENolLAtUV5EG/zM1Pxidibyfa06T/ak/gljL32kJjKT/+kwc+ZAxg IXs2VabHIxsQ6rgqmVa2OqMRjU1E8gLzDTpBCmAC/0afS/qdj3fsmIXGpZd9xqp68SzDbthmBLG Zr+jVZDmNWSh7sqtyqT6NDJZlPy5KbyBnZ4RU5lnYq5S4guFnl+FB/NvJyIK0ox2T6z/P14fJxU 4eSgmVm0aZESSDPdHGMUrIL8LUOnC4pZUaBMTtbr8ah1vhRCGln5l+r9xHaWbrbfYVMsq8bepyq 7QImZZoJeVD2853iiC/klWcHXkUNiMiicYZ/y9OkidjzVfez X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 While adding the GIC ITS MSI support, it was found that the msi-map entries needed to be swapped to receive MSIs from the endpoint. But later it was identified that the swapping was needed due to a bug in the Qualcomm PCIe controller driver. And since the bug is now fixed with commit bf79e33cdd89 ("PCI: qcom: Enable BDF to SID translation properly"), let's fix the msi-map entries also to reflect the actual mapping in the hardware. Fixes: a33a532b3b1e ("arm64: dts: qcom: sm8650: Use GIC-ITS for PCIe0 and P= CIe1") Signed-off-by: Manivannan Sadhasivam Acked-by: Neil Armstrong Tested-by: Neil Armstrong # on SM8650-QRD --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qco= m/sm8650.dtsi index ba72d8f38420..eb117866e59f 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -2274,9 +2274,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, interrupt-map-mask =3D <0 0 0 0x7>; #interrupt-cells =3D <1>; =20 - /* Entries are reversed due to the unusual ITS DeviceID encoding */ - msi-map =3D <0x0 &gic_its 0x1401 0x1>, - <0x100 &gic_its 0x1400 0x1>; + msi-map =3D <0x0 &gic_its 0x1400 0x1>, + <0x100 &gic_its 0x1401 0x1>; msi-map-mask =3D <0xff00>; =20 linux,pci-domain =3D <0>; @@ -2402,9 +2401,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, interrupt-map-mask =3D <0 0 0 0x7>; #interrupt-cells =3D <1>; =20 - /* Entries are reversed due to the unusual ITS DeviceID encoding */ - msi-map =3D <0x0 &gic_its 0x1481 0x1>, - <0x100 &gic_its 0x1480 0x1>; + msi-map =3D <0x0 &gic_its 0x1480 0x1>, + <0x100 &gic_its 0x1481 0x1>; msi-map-mask =3D <0xff00>; =20 linux,pci-domain =3D <1>; --=20 2.25.1