From nobody Sun Feb 8 20:32:40 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFFF46FE0D for ; Thu, 14 Mar 2024 14:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710426084; cv=none; b=Ip6k00wM/pNONuzfDJkmNMKfMpJmM59WelPQAlrPGlmGx2pYbzHEXKQ/4hC2eFZ1zjp+8JQ4YRWB38u+0Ib92/qWkb/w9Eqdy4WsxyCrF9CkQbZ7YopIU5reqkN2r8L/WLc0dUoK8F205uy64pwiB6QvPq2X5rEndWxhUGcaF1A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710426084; c=relaxed/simple; bh=6FabPEmpFyErLk7bCi4d6jupuxTDRYUNdQe7UwgjFms=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=K/eYb0c2AYXj4Ux9GJXdAnkl1A4ElUNPrCW+c8oLLBN9RV1gOg3m+QbEZnBXSLzI8TRuPUJmMNv/F+LrL1UGzJY+ND/1qmA7bcziA5hTiy65+UHyJx72byANGDKgVVkg7sGHLq/u9C7QLQcd1usqcecnJZ+kDyObe+n3NBdKf4w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB5CEC43399; Thu, 14 Mar 2024 14:21:23 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.97) (envelope-from ) id 1rklzb-00000002ddy-0ftb; Thu, 14 Mar 2024 10:23:35 -0400 Message-ID: <20240314142335.022580885@goodmis.org> User-Agent: quilt/0.67 Date: Thu, 14 Mar 2024 10:23:04 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Thorsten Blum Subject: [for-next][PATCH 3/8] tracing: Use div64_u64() instead of do_div() References: <20240314142301.170713485@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Thorsten Blum Fixes Coccinelle/coccicheck warnings reported by do_div.cocci. Compared to do_div(), div64_u64() does not implicitly cast the divisor and does not unnecessarily calculate the remainder. Link: https://lore.kernel.org/linux-trace-kernel/20240225164507.232942-2-th= orsten.blum@toblux.com Cc: Mathieu Desnoyers Signed-off-by: Thorsten Blum Acked-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_benchmark.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/trace/trace_benchmark.c b/kernel/trace/trace_benchmark.c index 54d5fa35c90a..811b08439406 100644 --- a/kernel/trace/trace_benchmark.c +++ b/kernel/trace/trace_benchmark.c @@ -92,7 +92,6 @@ static void trace_do_benchmark(void) bm_total +=3D delta; bm_totalsq +=3D delta * delta; =20 - if (bm_cnt > 1) { /* * Apply Welford's method to calculate standard deviation: @@ -105,7 +104,7 @@ static void trace_do_benchmark(void) stddev =3D 0; =20 delta =3D bm_total; - do_div(delta, bm_cnt); + delta =3D div64_u64(delta, bm_cnt); avg =3D delta; =20 if (stddev > 0) { @@ -127,7 +126,7 @@ static void trace_do_benchmark(void) seed =3D stddev; if (!last_seed) break; - do_div(seed, last_seed); + seed =3D div64_u64(seed, last_seed); seed +=3D last_seed; do_div(seed, 2); } while (i++ < 10 && last_seed !=3D seed); --=20 2.43.0