From nobody Mon Feb 9 13:57:19 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 749BF18C31 for ; Thu, 14 Mar 2024 05:59:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710395948; cv=none; b=nr7CR2Bt7FES36PjARLQb284do1Kemd0o0RwiETupgY0AiWhg0F6exMj78nQmhKHsgxLhEz4L0DExXPKwVvSAaV9Gs94ZDKS9xspLOY6038jVQ/DOubiva+sCNqfDVlmhEbpyovW9SVjoKeNIv2rClE1dhi0tIu8Alkg+XEtaK8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710395948; c=relaxed/simple; bh=QxznQlTiwxvRoxcxuNV3lrLzfe9XcWRO0Ze5cmywbq8=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=eVTz7DgsJcFMrmvXcB4ty17k274GtkqdREH+jr8YmJSrIZk0UX8s8bztweUJ2RfKpfIeD/c86+eZxxNg9KLgBSZjkLlMRIL4rtujakH0DTtc7SnotFrGQl4+CquLPA+QGBWMLek6yJALYV/hkgMq0eUeMtsIYgO0D74BbqfiLFA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=AXtggZ7d; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AXtggZ7d" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dd0ae66422fso1349719276.0 for ; Wed, 13 Mar 2024 22:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710395946; x=1711000746; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=Oeo18tfO4V4k4hOOFEDEBLHaBjdn7guPG+ER0JNnTTc=; b=AXtggZ7dttyMt4bYoWmOC8WKi5bzydN51AuI0T2mYTHbiZGP06bWd7kV7W2mSqb+vD b83ToA41KA6PFuTUJ3Rvf992spXrF6ESWUEPfbFfqcTlsHB+D/HHcaHS6geGd2ve2waX FXB3rtrdzE89GByO4la9XkUH5e4gWqVTH7o8jZ94dAuSDjdEZyqPhahWsKkZyVfsqHX3 3CR5Hb5yLfeJapfMZcL6yzB6LAe7CT1PpSqJOQrRb2RtjoR2WcBd4HVNtVKXs4h4915U P//ZKxamqjT5jOWxoygL5cF8eCASlge/8J3hLG5iYJXxjJfZ3Tnfrs47uohwmeC48uMq dNtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710395946; x=1711000746; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Oeo18tfO4V4k4hOOFEDEBLHaBjdn7guPG+ER0JNnTTc=; b=Stz6VYcXJiS3/RNhyqoAed2JpsbySdAgEW/gqf4xvBCR9AsxC2IrCcRk7Z/rInE8jN NfJvVRpwpR0oxRk07ChgXPkXDrVf6euPbv0EzOu6t9czr5Ckx2vuwHrxksDihcdD7fWF xmxg52qGdvFzjC2R/XkgZ+pg8U9d11MKd6ahZT1gvHqTGV+N7ewWcdX+ofdesN3EvB/6 EGzRIX9b5wWEarITlaQqnAViwqiWoeKYwC5Ndw649Up3bANguOf3Dw77N2ibjw/Ofrsj Jji4LYZ2v7vk3VMFY7ZOlK7r5RedTDycWOrVmJT4KmSZqhwQijs80bSP0Bjog/5anrxQ 7JSg== X-Forwarded-Encrypted: i=1; AJvYcCWVxo3aSwZbs+g+6jP1NeS/m/XQ7LHTYB0Cy3ZTPMdGwCnyBFSkhfmpoemcfi6O277Dbz9GlcfCTURawO7Raq+iaETcPCPC8z5R8g9J X-Gm-Message-State: AOJu0YxgxY34qbYEC7ssB3VqR0ZCUhq/pIY9jr65MGc4Su8LE7lcP6XU EUz7uMhr1BLf6KOi80DKomXhD4BJv2Byx4BPAuYLBS1l6IaRIEOw97XH82X/bQ43BGNNI4i258Y KO1nAnQ== X-Google-Smtp-Source: AGHT+IG/XogiODg03QMgLQSvsA9HqjPkCurw8x+4o9RsmV5BB/Z3oRwYqk0vvwKt62C06+05JF1JG6gPS+px X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:449f:3bde:a4cd:806a]) (user=irogers job=sendgmr) by 2002:a05:6902:2504:b0:dbf:4359:326a with SMTP id dt4-20020a056902250400b00dbf4359326amr261294ybb.1.1710395946496; Wed, 13 Mar 2024 22:59:06 -0700 (PDT) Date: Wed, 13 Mar 2024 22:58:37 -0700 In-Reply-To: <20240314055839.1975063-1-irogers@google.com> Message-Id: <20240314055839.1975063-11-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240314055839.1975063-1-irogers@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Subject: [PATCH v3 10/12] perf jevents: Add load store breakdown metrics ldst for AMD From: Ian Rogers To: Sandipan Das , Ravi Bangoria , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , John Garry , Kan Liang , Jing Zhang , Thomas Richter , James Clark , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Stephane Eranian Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Give breakdown of number of instructions. Use the counter mask (cmask) to show the number of cycles taken to retire the instructions. Signed-off-by: Ian Rogers --- tools/perf/pmu-events/amd_metrics.py | 75 ++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) diff --git a/tools/perf/pmu-events/amd_metrics.py b/tools/perf/pmu-events/a= md_metrics.py index 79312e33c2d0..2fc8064e4fc0 100755 --- a/tools/perf/pmu-events/amd_metrics.py +++ b/tools/perf/pmu-events/amd_metrics.py @@ -275,6 +275,80 @@ def AmdItlb(): ], description=3D"Instruction TLB breakdown") =20 =20 +def AmdLdSt() -> MetricGroup: + ldst_ld =3D Event("ls_dispatch.ld_dispatch") + ldst_st =3D Event("ls_dispatch.store_dispatch") + ldst_ldc1 =3D Event(f"{ldst_ld}/cmask=3D1/") + ldst_stc1 =3D Event(f"{ldst_st}/cmask=3D1/") + ldst_ldc2 =3D Event(f"{ldst_ld}/cmask=3D2/") + ldst_stc2 =3D Event(f"{ldst_st}/cmask=3D2/") + ldst_ldc3 =3D Event(f"{ldst_ld}/cmask=3D3/") + ldst_stc3 =3D Event(f"{ldst_st}/cmask=3D3/") + ldst_cyc =3D Event("ls_not_halted_cyc") + + ld_rate =3D d_ratio(ldst_ld, interval_sec) + st_rate =3D d_ratio(ldst_st, interval_sec) + + ld_v1 =3D max(ldst_ldc1 - ldst_ldc2, 0) + ld_v2 =3D max(ldst_ldc2 - ldst_ldc3, 0) + ld_v3 =3D ldst_ldc3 + + st_v1 =3D max(ldst_stc1 - ldst_stc2, 0) + st_v2 =3D max(ldst_stc2 - ldst_stc3, 0) + st_v3 =3D ldst_stc3 + + return MetricGroup("ldst", [ + MetricGroup("ldst_total", [ + Metric("ldst_total_ld", "Number of loads dispatched per second.", + ld_rate, "insns/sec"), + Metric("ldst_total_st", "Number of stores dispatched per second.= ", + st_rate, "insns/sec"), + ]), + MetricGroup("ldst_percent_insn", [ + Metric("ldst_percent_insn_ld", + "Load instructions as a percentage of all instructions.", + d_ratio(ldst_ld, ins), "100%"), + Metric("ldst_percent_insn_st", + "Store instructions as a percentage of all instructions.", + d_ratio(ldst_st, ins), "100%"), + ]), + MetricGroup("ldst_ret_loads_per_cycle", [ + Metric( + "ldst_ret_loads_per_cycle_1", + "Load instructions retiring in 1 cycle as a percentage of al= l " + "unhalted cycles.", d_ratio(ld_v1, ldst_cyc), "100%"), + Metric( + "ldst_ret_loads_per_cycle_2", + "Load instructions retiring in 2 cycles as a percentage of a= ll " + "unhalted cycles.", d_ratio(ld_v2, ldst_cyc), "100%"), + Metric( + "ldst_ret_loads_per_cycle_3", + "Load instructions retiring in 3 or more cycles as a percent= age" + "of all unhalted cycles.", d_ratio(ld_v3, ldst_cyc), "100%"), + ]), + MetricGroup("ldst_ret_stores_per_cycle", [ + Metric( + "ldst_ret_stores_per_cycle_1", + "Store instructions retiring in 1 cycle as a percentage of a= ll " + "unhalted cycles.", d_ratio(st_v1, ldst_cyc), "100%"), + Metric( + "ldst_ret_stores_per_cycle_2", + "Store instructions retiring in 2 cycles as a percentage of = all " + "unhalted cycles.", d_ratio(st_v2, ldst_cyc), "100%"), + Metric( + "ldst_ret_stores_per_cycle_3", + "Store instructions retiring in 3 or more cycles as a percen= tage" + "of all unhalted cycles.", d_ratio(st_v3, ldst_cyc), "100%"), + ]), + MetricGroup("ldst_insn_bt", [ + Metric("ldst_insn_bt_ld", "Number of instructions between loads.= ", + d_ratio(ins, ldst_ld), "insns"), + Metric("ldst_insn_bt_st", "Number of instructions between stores= .", + d_ratio(ins, ldst_st), "insns"), + ]) + ], description=3D"Breakdown of load/store instructions") + + def AmdHwpf(): """Returns a MetricGroup representing AMD hardware prefetch metrics.""" global _zen_model @@ -512,6 +586,7 @@ def main() -> None: AmdBr(), AmdDtlb(), AmdItlb(), + AmdLdSt(), AmdHwpf(), AmdSwpf(), AmdUpc(), --=20 2.44.0.278.ge034bb2e1d-goog