From nobody Sat Feb 7 23:12:04 2026 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B87D224C9 for ; Mon, 11 Mar 2024 09:49:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710150601; cv=none; b=H9JuqwCAEWJAEpoaHR345kOgcGftUet5/HZ6nj2IFEQdtAAgD7CC/R1L8WGIJkO8GP4vg2j+djFcfgQ0Sep31Saex9u+IkEZ4CjHnECMTwARMtKFhnFc9nk99QAaX46NtVswsNxeUz2jgZnYUZmwCC+Qnmg7DAClOT+XvENIG8o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710150601; c=relaxed/simple; bh=ErXM/xCqChIXuI/reXCOq5YLubZuZxj1O0AlcJ3LwU4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=FGIyGaFlN17A+OV8T+qGdDmVgNDLhLImA6MRSWTyUaHIoXWn4+L9RKiVckPowhcMrn6tw6e6lEjms6KU5vcmiLrOcsjy5xxGjx4S+i3EQMzSgxb+HJR3C7uxuJDw4y5aaxBLpl8g8P3/ZHaesPCtK2dAafDbilOcDDE7AaR0u6c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--howardyen.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=oRBU6NcT; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--howardyen.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="oRBU6NcT" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-60a20c33f07so24680017b3.3 for ; Mon, 11 Mar 2024 02:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710150599; x=1710755399; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=hAGyZk4wDoLUijxbM5TEZd0Agy/9efRjEZc3xhOwTeE=; b=oRBU6NcTgVDlwR4+E5qFBTacDxzclrguf1ipSpVBd74OAD9IxGufSnZdSXwVDfr5qH 8KQCoL8ypfZKlcCSyTkLJcVWdlW/WKWqLY88pONFeFWAQvfe5cfeUoCNB20theq81QO6 FFQTEBdrgRgthP3lN+2wBv2J5dCUwhQYOgfx7yNODpXa4q8bn8zLn+uBZE8q8ozTTfoM UKTvoqYwQTLiYXjH2H3xrbzyOuSL0BKybOgDKCp7Orc24ZAE4jc4DQBgita9YrEkewMY dtN5Upk6WTSeyxpvKDKkvSBJREWaVhSC0pUKU3iwV+WB1xrqVRYIXe8t102PBkC9OcPT iEoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710150599; x=1710755399; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hAGyZk4wDoLUijxbM5TEZd0Agy/9efRjEZc3xhOwTeE=; b=LAPqxX6xIwQoEzB7bpH6NGjnmSOp8J47XO0RbuTkr3yu2n4ebIU7uVx4G2YmjU+wKs /7F8mAXkri61h6HEogCJgMuwRw5czGIKDjMCmgpeT9cV/zCVj1UTlusLIrNfZOO54wz+ 4NixjG5C98QekVGxhF7qrtrQefbUPVxfo8bVCOeqTkuODiO3Fdlin00vz8j+yzn9zSwo f+uzV3MrKUyb0znuZScQTKN5PDjlsr08lvQMceGVH6kSjVMzHMDKWnRYxymEfU6jAi3m s7IIbNrKz871PN7aAwJc8odOroEjlM4Ozusy5J9g4DT0GxeMosMgBviGHSk1c+XJ5BKe u94A== X-Gm-Message-State: AOJu0YwGKTdqPdha7Nc9aHUeIBi69uieWBmC5gPla4USxHf7JALU+tw+ 0Necmcx4Kg2iUB9S4w+nJXueiIHPT6GePl8Mhx+r02GCJ+V1r7pyIR06mqr/2rbAlyLlLhrwDeL ga6zES0x8WQlosA== X-Google-Smtp-Source: AGHT+IE6jcflp9fRCKJ0gJHRuFbcchVasL4L61tzVdhEWWl/adPMpMiCXsQ0hTXzFp5hlU/ryT6buk71g33IePo= X-Received: from howardyen2.c.googlers.com ([fda3:e722:ac3:cc00:3:22c1:c0a8:16f7]) (user=howardyen job=sendgmr) by 2002:a05:6902:10c2:b0:dc6:e1ed:bd1a with SMTP id w2-20020a05690210c200b00dc6e1edbd1amr1726976ybu.2.1710150598548; Mon, 11 Mar 2024 02:49:58 -0700 (PDT) Date: Mon, 11 Mar 2024 09:49:46 +0000 In-Reply-To: <20240311094947.3738200-1-howardyen@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240311094947.3738200-1-howardyen@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240311094947.3738200-2-howardyen@google.com> Subject: [PATCH v5 1/2] dma-coherent: add support for multi coherent rmems per dev From: Howard Yen To: gregkh@linuxfoundation.org, rafael@kernel.org, mathias.nyman@intel.com, hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com, andriy.shevchenko@linux.intel.com, petr.tesarik.ext@huawei.com, broonie@kernel.org, james@equiv.tech, james.clark@arm.com, masahiroy@kernel.org Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, iommu@lists.linux.dev, Howard Yen Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add support for multiple coherent rmems per device. This patch replaces original dma_mem with dma_mems list in device structure to store multiple rmems. These multiple rmems can be assigned to the device one by one by of_reserved_mem_device_init_by_idx() with the memory-region declaration in device tree as below and store the rmem to the dma_mems list. device1@0 { ... memory-region =3D <&reserved_mem0>, <&reserved_mem1>; ... }; When driver tries to allocate memory from the rmems, looks for the first available rmem and allocates the memory from this rmem. Then if driver removed, of_reserved_mem_device_release() needs to be invoked to release all the rmems assigned to the device. Signed-off-by: Howard Yen --- drivers/base/core.c | 3 ++ include/linux/device.h | 5 +-- kernel/dma/coherent.c | 92 +++++++++++++++++++++++++++--------------- 3 files changed, 64 insertions(+), 36 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 14d46af40f9a..d9af38d7b870 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -3108,6 +3108,9 @@ void device_initialize(struct device *dev) defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU) || \ defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL) dev->dma_coherent =3D dma_default_coherent; +#endif +#ifdef CONFIG_DMA_DECLARE_COHERENT + INIT_LIST_HEAD(&dev->dma_mems); #endif swiotlb_dev_init(dev); } diff --git a/include/linux/device.h b/include/linux/device.h index 97c4b046c09d..5fa15e5adbdc 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -648,7 +648,7 @@ struct device_physical_location { * @dma_parms: A low level driver may set these to teach IOMMU code about * segment limitations. * @dma_pools: Dma pools (if dma'ble device). - * @dma_mem: Internal for coherent mem override. + * @dma_mems: Internal for coherent mems. * @cma_area: Contiguous memory area for dma allocations * @dma_io_tlb_mem: Software IO TLB allocator. Not for driver use. * @dma_io_tlb_pools: List of transient swiotlb memory pools. @@ -749,8 +749,7 @@ struct device { struct list_head dma_pools; /* dma pools (if dma'ble) */ =20 #ifdef CONFIG_DMA_DECLARE_COHERENT - struct dma_coherent_mem *dma_mem; /* internal for coherent mem - override */ + struct list_head dma_mems; /* Internal for coherent mems */ #endif #ifdef CONFIG_DMA_CMA struct cma *cma_area; /* contiguous memory area for dma diff --git a/kernel/dma/coherent.c b/kernel/dma/coherent.c index ff5683a57f77..f6748a3a5eb1 100644 --- a/kernel/dma/coherent.c +++ b/kernel/dma/coherent.c @@ -11,22 +11,16 @@ #include =20 struct dma_coherent_mem { - void *virt_base; - dma_addr_t device_base; - unsigned long pfn_base; - int size; - unsigned long *bitmap; - spinlock_t spinlock; - bool use_dev_dma_pfn_offset; + struct list_head node; + void *virt_base; + dma_addr_t device_base; + unsigned long pfn_base; + int size; + spinlock_t spinlock; + unsigned long *bitmap; + bool use_dev_dma_pfn_offset; }; =20 -static inline struct dma_coherent_mem *dev_get_coherent_memory(struct devi= ce *dev) -{ - if (dev && dev->dma_mem) - return dev->dma_mem; - return NULL; -} - static inline dma_addr_t dma_get_device_base(struct device *dev, struct dma_coherent_mem * mem) { @@ -61,6 +55,7 @@ static struct dma_coherent_mem *dma_init_coherent_memory(= phys_addr_t phys_addr, dma_mem->pfn_base =3D PFN_DOWN(phys_addr); dma_mem->size =3D pages; dma_mem->use_dev_dma_pfn_offset =3D use_dma_pfn_offset; + INIT_LIST_HEAD(&dma_mem->node); spin_lock_init(&dma_mem->spinlock); =20 return dma_mem; @@ -90,10 +85,8 @@ static int dma_assign_coherent_memory(struct device *dev, if (!dev) return -ENODEV; =20 - if (dev->dma_mem) - return -EBUSY; + list_add_tail(&mem->node, &dev->dma_mems); =20 - dev->dma_mem =3D mem; return 0; } =20 @@ -118,23 +111,28 @@ int dma_declare_coherent_memory(struct device *dev, p= hys_addr_t phys_addr, dma_addr_t device_addr, size_t size) { struct dma_coherent_mem *mem; - int ret; + int retval; =20 mem =3D dma_init_coherent_memory(phys_addr, device_addr, size, false); if (IS_ERR(mem)) return PTR_ERR(mem); =20 - ret =3D dma_assign_coherent_memory(dev, mem); - if (ret) + retval =3D dma_assign_coherent_memory(dev, mem); + if (retval) _dma_release_coherent_memory(mem); - return ret; + return retval; } =20 void dma_release_coherent_memory(struct device *dev) { - if (dev) { - _dma_release_coherent_memory(dev->dma_mem); - dev->dma_mem =3D NULL; + struct dma_coherent_mem *mem_tmp, *q; + + if (!dev) + return; + + list_for_each_entry_safe(mem_tmp, q, &dev->dma_mems, node) { + list_del_init(&mem_tmp->node); + _dma_release_coherent_memory(mem_tmp); } } =20 @@ -187,12 +185,17 @@ static void *__dma_alloc_from_coherent(struct device = *dev, int dma_alloc_from_dev_coherent(struct device *dev, ssize_t size, dma_addr_t *dma_handle, void **ret) { - struct dma_coherent_mem *mem =3D dev_get_coherent_memory(dev); + struct dma_coherent_mem *mem_tmp; =20 - if (!mem) + if (list_empty(&dev->dma_mems)) return 0; =20 - *ret =3D __dma_alloc_from_coherent(dev, mem, size, dma_handle); + list_for_each_entry(mem_tmp, &dev->dma_mems, node) { + *ret =3D __dma_alloc_from_coherent(dev, mem_tmp, size, dma_handle); + if (*ret) + break; + } + return 1; } =20 @@ -226,9 +229,16 @@ static int __dma_release_from_coherent(struct dma_cohe= rent_mem *mem, */ int dma_release_from_dev_coherent(struct device *dev, int order, void *vad= dr) { - struct dma_coherent_mem *mem =3D dev_get_coherent_memory(dev); + struct dma_coherent_mem *mem_tmp; + int retval =3D 0; =20 - return __dma_release_from_coherent(mem, order, vaddr); + list_for_each_entry(mem_tmp, &dev->dma_mems, node) { + retval =3D __dma_release_from_coherent(mem_tmp, order, vaddr); + if (retval =3D=3D 1) + break; + } + + return retval; } =20 static int __dma_mmap_from_coherent(struct dma_coherent_mem *mem, @@ -271,9 +281,16 @@ static int __dma_mmap_from_coherent(struct dma_coheren= t_mem *mem, int dma_mmap_from_dev_coherent(struct device *dev, struct vm_area_struct *= vma, void *vaddr, size_t size, int *ret) { - struct dma_coherent_mem *mem =3D dev_get_coherent_memory(dev); + struct dma_coherent_mem *mem_tmp; + int retval =3D 0; =20 - return __dma_mmap_from_coherent(mem, vma, vaddr, size, ret); + list_for_each_entry(mem_tmp, &dev->dma_mems, node) { + retval =3D __dma_mmap_from_coherent(mem_tmp, vma, vaddr, size, ret); + if (retval =3D=3D 1) + break; + } + + return retval; } =20 #ifdef CONFIG_DMA_GLOBAL_POOL @@ -351,8 +368,17 @@ static int rmem_dma_device_init(struct reserved_mem *r= mem, struct device *dev) static void rmem_dma_device_release(struct reserved_mem *rmem, struct device *dev) { - if (dev) - dev->dma_mem =3D NULL; + struct dma_coherent_mem *mem_tmp, *q; + + if (!dev) + return; + + list_for_each_entry_safe(mem_tmp, q, &dev->dma_mems, node) { + if (mem_tmp =3D=3D rmem->priv) { + list_del_init(&mem_tmp->node); + break; + } + } } =20 static const struct reserved_mem_ops rmem_dma_ops =3D { --=20 2.44.0.278.ge034bb2e1d-goog From nobody Sat Feb 7 23:12:04 2026 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A67492BAF8 for ; Mon, 11 Mar 2024 09:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710150605; cv=none; b=Dz1TLZOaf0jwclaKxTNWmAG0whBMkNsyJ+wr5KPDn+1ecEJi9T5pFda/RYp2nJ8mIL3HhYYM59jrzWmsjzbWEFbB2nArhSBwgThnMwh00xlZgAIdTJCTSn97YQaEU0Fe4I5fSqvbikXzrGw76j3sC0ibvrwRfqchu7+yeOajUBE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710150605; c=relaxed/simple; bh=uvJ2hakYbHneCq8YNG7tuA44/YBDsJTeR/dxao+/8HQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=R/GIgRuMaiysuKI/u7KYCJCKzccloxT6aLWCwCyRV8m5cSINnJBH8Ko/rdyybsg/Xy7/RPJmwlpKHZNsCtaMzI2yoe5PxuxSvT/dblFqP1NSYNJh0EtKCyAdAJfD4OAtdohKvr/I/cImnjrjePrTeBv3eC6y18kWWdSPDVDWKyE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--howardyen.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Jdwn2ad8; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--howardyen.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Jdwn2ad8" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-5cec8bc5c66so2940631a12.1 for ; Mon, 11 Mar 2024 02:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710150603; x=1710755403; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=U9nKgRIKf+zajKM49T+JUxDbdLW2EfnvvMithLFK/Yc=; b=Jdwn2ad8Yjvze3A/IsjvHJzhvSbO1gi9QO23jsfDhj2r9A+5kvu3/nu7UlL+mMgNRr o9aagpGNLo0caS1btUv5dxPFRAwhK3etIZPjHQZucQRvtmdJxRp7rGN8JwmttVmvJdvP iAVlxg5z1fMOEnBOsIXBau2LHW7FmpBbZeh2VDZywnr2AZVqWe7qFKybaeWy9l2RklQB BjPRHVExc3+YhznWIJyIosgOsLSa8gi583oo24vSp6xaEoJ5uNB/y27N1yAKNVSUoK/r CUbKNBrKcRLBd+oUVul8GFhk+PvCzDiY8WkwXr9kXq4SEDJbhypRgykOVMu3UU3hQQ+g IkzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710150603; x=1710755403; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U9nKgRIKf+zajKM49T+JUxDbdLW2EfnvvMithLFK/Yc=; b=mzRiJUpeHOOskiutqCvN/tX9YDR8xcmB3RcV8zJ3B7iJ0stu9as9SDCA69R5zDamgk hFFLXDfAzHZde1g5P2WrAQjJM2sIEcc9aD18S+GPl1KU1gHotY5C1zeuC98N5d67YLB2 Hk0ftOsH9s+OAsfZmz85K4ayqiGHbmB4mWQVuTXaAARKNG74z6JJajPnFKnyfHtEOKqu 3PkKweHjuf7E87ffFoP4nJP07CInJZOiEnNHjzw6DgNLYLxLqkIYpeldbz+GrgytyEnW 6nU3MWPogLTgy9v+kDTNE3e/jfQOKBaawbSZkMyGTN32RFbP+DAYkPP7LUchriEm3dY/ 197g== X-Gm-Message-State: AOJu0YwSRODyN9WZudQSaOu+EhULxXk3bE0Qv3qRlYgOFuMolpxag4QV TjCh9WdBO6M4XQ4t3dUd2A2Rt/hxR7sKkC5rcfhcmkXb+t8lATzGpVVrsYLlGId7figVE8dHBN3 yJ42QSo5RjWuV8g== X-Google-Smtp-Source: AGHT+IE5C8YFsWfQeFn6ZmMrCYM8EsZdK0R7B2x7aijsSo9T46qxw3LGysRAMLa17HQzOWxQTbFW0fvfbLQGTOw= X-Received: from howardyen2.c.googlers.com ([fda3:e722:ac3:cc00:3:22c1:c0a8:16f7]) (user=howardyen job=sendgmr) by 2002:a63:de0b:0:b0:5dc:aa2a:7790 with SMTP id f11-20020a63de0b000000b005dcaa2a7790mr17226pgg.2.1710150602720; Mon, 11 Mar 2024 02:50:02 -0700 (PDT) Date: Mon, 11 Mar 2024 09:49:47 +0000 In-Reply-To: <20240311094947.3738200-1-howardyen@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240311094947.3738200-1-howardyen@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240311094947.3738200-3-howardyen@google.com> Subject: [PATCH v5 2/2] usb: host: xhci-plat: add support for multi memory regions From: Howard Yen To: gregkh@linuxfoundation.org, rafael@kernel.org, mathias.nyman@intel.com, hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com, andriy.shevchenko@linux.intel.com, petr.tesarik.ext@huawei.com, broonie@kernel.org, james@equiv.tech, james.clark@arm.com, masahiroy@kernel.org Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, iommu@lists.linux.dev, Howard Yen Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The reason why it needs multiple regions is that in my system there is an always-on subsystem which includes a small size memory, and several functions need to run and occupy the memory from the small memory if they need to run on the always-on subsystem. These functions must allocate the memory from the small memory region, so that they can get benefit from the always-on subsystem. So the small memory is split for multiple functions which are satisfied with their generic use cases. But in specific use cases, like USB3 devices which support the stream trasnsfer or multiple devices connect to the host, they required more memory than their pre-allocated memory region, so I tried to propose this patch to give it the ability to get the memory from the other larger memory to solve the issue. Signed-off-by: Howard Yen --- drivers/usb/host/xhci-plat.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index 3d071b875308..7892d3eb26d2 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/drivers/usb/host/xhci-plat.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include #include @@ -149,7 +150,7 @@ int xhci_plat_probe(struct platform_device *pdev, struc= t device *sysdev, const s struct xhci_hcd *xhci; struct resource *res; struct usb_hcd *hcd, *usb3_hcd; - int ret; + int i, count, ret; int irq; struct xhci_plat_priv *priv =3D NULL; bool of_match; @@ -194,6 +195,19 @@ int xhci_plat_probe(struct platform_device *pdev, stru= ct device *sysdev, const s =20 xhci->allow_single_roothub =3D 1; =20 + count =3D of_property_count_u32_elems(sysdev->of_node, "memory-region"); + + for (i =3D 0; i < count; i++) { + ret =3D of_reserved_mem_device_init_by_idx(sysdev, sysdev->of_node, i); + if (ret) { + dev_err(sysdev, "Could not get reserved memory\n"); + if (i > 0) + of_reserved_mem_device_release(sysdev); + + return ret; + } + } + /* * Not all platforms have clks so it is not an error if the * clock do not exist. @@ -431,6 +445,9 @@ void xhci_plat_remove(struct platform_device *dev) clk_disable_unprepare(clk); clk_disable_unprepare(reg_clk); reset_control_assert(xhci->reset); + + of_reserved_mem_device_release(hcd->self.sysdev); + usb_put_hcd(hcd); =20 pm_runtime_disable(&dev->dev); --=20 2.44.0.278.ge034bb2e1d-goog