From nobody Sun Feb 8 00:49:28 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 902832260A for ; Mon, 11 Mar 2024 09:23:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710149011; cv=none; b=ROG/H7wdDgNn6kSb4wfDJQ0mKE0EN/CDdaU7i4uYlEuDtJzKUP3Z7rKyK0S0DBahuxPI7Xywu5CLPMGUwmgxU0Q1SwL5h5XelluyT2h0JFidFOsvT0qS3akPunyYLXhc9EvpYX8j2C20T5JpPZY2p0FSBqOMMffeXKhHQLrVodY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710149011; c=relaxed/simple; bh=E7XSj0pyzwRnbhEItgfs1Biw2IzEoXA27lamXCSeXf8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GCkMwQKWW4zEuBWmigmmLshcbeaC0pnuIqDfB20TsG2XUh1sv2/olaJac+T7R14wFH+T4IJNV5qjgk1Yi1pBsZKRKwTUP2OH+NqzwhD0inqQJb56znDAqj/lYP9TdGE94uJJIPlu8rBdL3+qncXJmHz4fyz3qqOyzD16XfYXapU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=9elements.com; spf=pass smtp.mailfrom=9elements.com; dkim=pass (2048-bit key) header.d=9elements.com header.i=@9elements.com header.b=RNrMsOVw; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=9elements.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=9elements.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=9elements.com header.i=@9elements.com header.b="RNrMsOVw" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-33e17342ea7so1463488f8f.2 for ; Mon, 11 Mar 2024 02:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1710149008; x=1710753808; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aWgXcsCIwNB8quceeSPfUi0wO64rrOVtbtRuUW+5aHM=; b=RNrMsOVwayeimLU72AzysCc7zW4jVvLZeH/OClzalKduO43mU8XnMcvJXHsVjgC9CZ dOTy5wNAMD5lcfs36huzqxuQJhlBV7RXgqu6r810x+8M0V6vKA6hs2EgHCQrx20aPTcV MuwBrYm5AmmHYCviu37kQl+UZaFQWrbrwfyHQYdAhO91KPJVk9Yc8QfbKb51hU4BIO04 zrdqJZYhcewGl2/48haYC0qOk610MprOKvS1S+j4PnBlVT8KGcn3jB96OrA2LtmrTzF8 BfkXj8iNXgcpYAYXXhL56pcM+Jel1Je5NltljqVz+jKW0FbvwV5WRyuj4l/BrethS6N/ nSeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710149008; x=1710753808; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aWgXcsCIwNB8quceeSPfUi0wO64rrOVtbtRuUW+5aHM=; b=S9jaXLOGnndpQZGbU3N/WNBrr1THLGH3ua29E+sJRdso3/TmMz6oHwpm8NBi6DjoLd v0j6Ujxf0JGv3MBmgRYCLzeaf1I6hnMGioOVgnRQBm9mtYbBHUMpOxA/EC7rWX/pPvF/ qndcWCCs6Qbp8+jKl9DkoWpdqGGdk0zCbsCX4pkwjJgOO/h4UQRl0XHPcQh3IjpeEpaY 41uzyMwiEJesBhrZkTooqk+X6ORS/TbLWONw5iVT9Zdq7XJwQ+zjjCDU4TVRLN4yjVuR mbRg7avtmPKRqV5dFMeUZ5nagvKK8/rz6xvnWOIvbtFWL0fe0LHNiFq7f2ueucf9aiyW afOQ== X-Forwarded-Encrypted: i=1; AJvYcCX5jHmQd/xSCAh/sDFmrKvdrLcQbeeM4K33Dxt2w327j0i1kgEBTWAOqkCKUrtaXDvUFXDoUTUGqeMB2+uMAGYA4SBlZjDyyqfG3Fjy X-Gm-Message-State: AOJu0YxQ/d8+1ajA2EQnax/zV8o0bqyV0gZHsEe+wU/sUNW37TolUSsQ MBw9tsdiV6fFDgkG2Fr61NExT+JfE9wAkR4DXlv+6wnssla6KpUjQIMPIDfqNa8= X-Google-Smtp-Source: AGHT+IEBVfmDyFFFPxjqooOh+1r0l5Xrnogd3rg+LM5RteCOwT8JZJQu9VwLkib2ZQNjIGnu5lsYuA== X-Received: by 2002:adf:e483:0:b0:33e:67c7:e2c0 with SMTP id i3-20020adfe483000000b0033e67c7e2c0mr3767524wrm.38.1710149007639; Mon, 11 Mar 2024 02:23:27 -0700 (PDT) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id c18-20020a5d4152000000b0033e745176f5sm5912370wrq.110.2024.03.11.02.23.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 02:23:27 -0700 (PDT) From: Naresh Solanki To: Jean Delvare , Guenter Roeck Cc: mazziesaccount@gmail.com, Patrick Rudolph , Naresh Solanki , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] hwmon: (pmbus/mp2975) Fix IRQ masking Date: Mon, 11 Mar 2024 14:53:23 +0530 Message-ID: <20240311092323.3606694-1-naresh.solanki@9elements.com> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Patrick Rudolph The MP2971/MP2973 use a custom 16bit register format for SMBALERT_MASK which doesn't follow the PMBUS specification. Map the PMBUS defined bits used by the common code onto the custom format used by MPS and since the SMBALERT_MASK is currently never read by common code only implement the mapping for write transactions. Signed-off-by: Patrick Rudolph Signed-off-by: Naresh Solanki --- Changes in V3: 1. Avoid precedence issues in Macro 2. Optimise macro. Changes in V2: 1. Add/Update comment 2. Update SWAP define to include both variable. 3. Add defines for each bits of SMBALERT mask. --- drivers/hwmon/pmbus/mp2975.c | 77 ++++++++++++++++++++++++++++++++++++ 1 file changed, 77 insertions(+) diff --git a/drivers/hwmon/pmbus/mp2975.c b/drivers/hwmon/pmbus/mp2975.c index e5fa10b3b8bc..953c02a2aeb5 100644 --- a/drivers/hwmon/pmbus/mp2975.c +++ b/drivers/hwmon/pmbus/mp2975.c @@ -392,6 +392,82 @@ static int mp2973_read_word_data(struct i2c_client *cl= ient, int page, return ret; } =20 +static int mp2973_write_word_data(struct i2c_client *client, int page, + int reg, u16 word) +{ + u8 target, mask; + int ret; + + if (reg !=3D PMBUS_SMBALERT_MASK) + return -ENODATA; + + /* + * Vendor-specific SMBALERT_MASK register with 16 maskable bits. + */ + ret =3D pmbus_read_word_data(client, 0, 0, PMBUS_SMBALERT_MASK); + if (ret < 0) + return ret; + + target =3D word & 0xff; + mask =3D word >> 8; + +/* + * Set/Clear 'bit' in 'ret' based on condition followed by define for each= bit in SMBALERT_MASK. + * Also bit 2 & 15 are reserved. + */ +#define SWAP(val, mask, cond, bit) (((mask) & (cond)) ? ((val) & ~BIT(bit)= ) : ((val) | BIT(bit))) + +#define MP2973_TEMP_OT 0 +#define MP2973_VIN_UVLO 1 +#define MP2973_VIN_OVP 3 +#define MP2973_MTP_FAULT 4 +#define MP2973_OTHER_COMM 5 +#define MP2973_MTP_BLK_TRIG 6 +#define MP2973_PACKET_ERROR 7 +#define MP2973_INVALID_DATA 8 +#define MP2973_INVALID_COMMAND 9 +#define MP2973_IOUT_OC_LV 10 +#define MP2973_IOUT_OC 11 +#define MP2973_VOUT_MAX_MIN_WARNING 12 +#define MP2973_VOLTAGE_UV 13 +#define MP2973_VOLTAGE_OV 14 + + switch (target) { + case PMBUS_STATUS_CML: + ret =3D SWAP(ret, mask, PB_CML_FAULT_INVALID_DATA, MP2973_INVALID_DATA); + ret =3D SWAP(ret, mask, PB_CML_FAULT_INVALID_COMMAND, MP2973_INVALID_CO= MMAND); + ret =3D SWAP(ret, mask, PB_CML_FAULT_OTHER_COMM, MP2973_OTHER_COMM); + ret =3D SWAP(ret, mask, PB_CML_FAULT_PACKET_ERROR, MP2973_PACKET_ERROR); + break; + case PMBUS_STATUS_VOUT: + ret =3D SWAP(ret, mask, PB_VOLTAGE_UV_FAULT, MP2973_VOLTAGE_UV); + ret =3D SWAP(ret, mask, PB_VOLTAGE_OV_FAULT, MP2973_VOLTAGE_OV); + break; + case PMBUS_STATUS_IOUT: + ret =3D SWAP(ret, mask, PB_IOUT_OC_FAULT, MP2973_IOUT_OC); + ret =3D SWAP(ret, mask, PB_IOUT_OC_LV_FAULT, MP2973_IOUT_OC_LV); + break; + case PMBUS_STATUS_TEMPERATURE: + ret =3D SWAP(ret, mask, PB_TEMP_OT_FAULT, MP2973_TEMP_OT); + break; + /* + * Map remaining bits to MFR specific to let the PMBUS core mask + * those bits by default. + */ + case PMBUS_STATUS_MFR_SPECIFIC: + ret =3D SWAP(ret, mask, BIT(1), MP2973_VIN_UVLO); + ret =3D SWAP(ret, mask, BIT(3), MP2973_VIN_OVP); + ret =3D SWAP(ret, mask, BIT(4), MP2973_MTP_FAULT); + ret =3D SWAP(ret, mask, BIT(6), MP2973_MTP_BLK_TRIG); + break; + default: + return 0; + } +#undef SWAP + + return pmbus_write_word_data(client, 0, PMBUS_SMBALERT_MASK, ret); +} + static int mp2975_read_word_data(struct i2c_client *client, int page, int phase, int reg) { @@ -907,6 +983,7 @@ static struct pmbus_driver_info mp2973_info =3D { PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP | PMBUS_HAVE_POUT | PMBUS_HAVE_PIN | PMBUS_HAVE_STATUS_INPUT, .read_word_data =3D mp2973_read_word_data, + .write_word_data =3D mp2973_write_word_data, #if IS_ENABLED(CONFIG_SENSORS_MP2975_REGULATOR) .num_regulators =3D 1, .reg_desc =3D mp2975_reg_desc, base-commit: 8debe3c1295ef36958dae77487eed9cf6584c008 --=20 2.42.0