From nobody Sun Feb 8 05:59:07 2026 Received: from out-175.mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5C595E09D for ; Fri, 8 Mar 2024 21:00:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709931646; cv=none; b=CYwrmJimI6xHQ337lT/+RGlmplUxbeAhIzr/4aBH7jj8nRnt6XrM0V0lpjGLOTgEdOuBK/ZZI3PiY0ZptDyCnMfuy9HUEsrYV4G50Tan2tIsBsIsXl3aakLr6q/WVixlt4K0Hr5p3d2Cii4WsLy9b/V+TW20CGSrLkPISD2pqKY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709931646; c=relaxed/simple; bh=h3ZwvO18NqzlYxQLvrQ+ixy5YP9uezWH5/IU5Z2QUJk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ISWsniMG87rcEGGE3CQAyXOtRb7YtTcc7Xn3vc1WxwpTP70BM37s05ALp4MRtgPO3Ib3hsneihJC4KIk1v/DUfqY6v+YV4JPEKrXsdrpxXkcXaUXkrf3kUS/mv+9sPpNPBs2jCaGhv0/kccsCBTL0JKA0S7pJ34HDUbuTJBz3uY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fHPAY1k5; arc=none smtp.client-ip=95.215.58.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fHPAY1k5" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1709931643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+ucTS9a0V+bG0ban2Mlf24ZePa15zebSakjUo97bJDM=; b=fHPAY1k5DxR4UlbR9W2J4KQi1tb2ggwkCtCcDAhfYJ/njlbkCp5JfxueFctt5mztZc0oO9 1xgmywoHsxosTSN84IozbPv3HCnrdlzHmLUlHYvX+KiGzJOnExfFqYPGzoNjhriiSKKMAl YOAKPo0b8IgCpkchLLdk2rR7XVFvrL8= From: Sean Anderson To: Laurent Pinchart , Vinod Koul , dmaengine@vger.kernel.org Cc: Michal Simek , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sean Anderson Subject: [PATCH 2/3] dma: xilinx_dpdma: Remove unnecessary use of irqsave/restore Date: Fri, 8 Mar 2024 16:00:33 -0500 Message-Id: <20240308210034.3634938-3-sean.anderson@linux.dev> In-Reply-To: <20240308210034.3634938-1-sean.anderson@linux.dev> References: <20240308210034.3634938-1-sean.anderson@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" xilinx_dpdma_chan_done_irq and xilinx_dpdma_chan_vsync_irq are always called with IRQs disabled from xilinx_dpdma_irq_handler. Therefore we don't need to save/restore the IRQ flags. Signed-off-by: Sean Anderson Reviewed-by: Tomi Valkeinen --- drivers/dma/xilinx/xilinx_dpdma.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_= dpdma.c index eb0637d90342..36bd4825d389 100644 --- a/drivers/dma/xilinx/xilinx_dpdma.c +++ b/drivers/dma/xilinx/xilinx_dpdma.c @@ -1043,9 +1043,8 @@ static int xilinx_dpdma_chan_stop(struct xilinx_dpdma= _chan *chan) static void xilinx_dpdma_chan_done_irq(struct xilinx_dpdma_chan *chan) { struct xilinx_dpdma_tx_desc *active; - unsigned long flags; =20 - spin_lock_irqsave(&chan->lock, flags); + spin_lock(&chan->lock); =20 xilinx_dpdma_debugfs_desc_done_irq(chan); =20 @@ -1057,7 +1056,7 @@ static void xilinx_dpdma_chan_done_irq(struct xilinx_= dpdma_chan *chan) "chan%u: DONE IRQ with no active descriptor!\n", chan->id); =20 - spin_unlock_irqrestore(&chan->lock, flags); + spin_unlock(&chan->lock); } =20 /** @@ -1072,10 +1071,9 @@ static void xilinx_dpdma_chan_vsync_irq(struct xili= nx_dpdma_chan *chan) { struct xilinx_dpdma_tx_desc *pending; struct xilinx_dpdma_sw_desc *sw_desc; - unsigned long flags; u32 desc_id; =20 - spin_lock_irqsave(&chan->lock, flags); + spin_lock(&chan->lock); =20 pending =3D chan->desc.pending; if (!chan->running || !pending) @@ -1108,7 +1106,7 @@ static void xilinx_dpdma_chan_vsync_irq(struct xilin= x_dpdma_chan *chan) spin_unlock(&chan->vchan.lock); =20 out: - spin_unlock_irqrestore(&chan->lock, flags); + spin_unlock(&chan->lock); } =20 /** --=20 2.35.1.1320.gc452695387.dirty