From nobody Sun Feb 8 19:35:47 2026 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 165044C90 for ; Fri, 8 Mar 2024 14:56:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709909775; cv=none; b=iu/oYDNLQZflqkq6QVmKS2MDdffYKFYUUTYHpLBDOa9ZwBSp/mx9gUhLvYUyLdtaxUFbd5249TL7SmhyJJxpHKhwJfJ+QYt/uSe5wWXmb12A9V/yQO9gv8aor/a+h4o4b5YRxpi0rmMP5syVSqiErHihnPrcYhJjt5QiKQg1VL0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709909775; c=relaxed/simple; bh=GuJytFwSCI7IAd2cG0GrQp6NqcFum5PQWvL4VQCu4CE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dPE7EfEfUGOPc3PTgc1wTP7FoPS5hjgP8v71M7NjMfaoDL2e/e+b1ZUowAfAbiysCxPBtCumCmOMfgiekUMayRAyVHPQP+8kzcbEryl9bKNUX4NJh4wwMhYp1ivNW+VIIbaCdGm6frWItXZdyvMAUD2YC033VREyKzkvjBIPJv4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=amqk+UvB; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="amqk+UvB" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=R+C5C00hqwaItnGEh4nhXpDi1vrMiefpdzqj2L/NgqM=; b=amqk+UvB+WUvrusoCbz188aBRH RjR9wHoPGJhAcrg9Pnq5qBtjfC8jqb2OYMjbwvjNqXMt9a4sh550+IFisn/xBWld9a5ZbkrAsMeRz KQNB/oH97dAnpAuQE9yGwrS5e1zhTPt9KAB/2OXRlLzQrD0orZqJwpldbUIKIvh/Jd8IH0qv4e2oI 3XTH70d/rJspVhNV5YFfRSCLKVgeuWnZeesD2oYD97SCv98PedmlcvvIPcZFRIlHkfx7wrvdDv/rS a9alOKvL0Uqgy88zv1B0ka4cR/BN6QX7wVwYeNt5D1zOoFvjmDXBDIVkGyoj/5MVsyyzgv0cDUXmQ C/3vpw8w==; Received: from [152.249.135.210] (helo=steammachine.lan) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1ribdp-007p93-8a; Fri, 08 Mar 2024 15:56:09 +0100 From: =?UTF-8?q?Andr=C3=A9=20Almeida?= To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, Simon Ser , Pekka Paalanen , daniel@ffwll.ch, Daniel Stone , =?UTF-8?q?=27Marek=20Ol=C5=A1=C3=A1k=27?= , Dave Airlie , ville.syrjala@linux.intel.com, Xaver Hugl , Joshua Ashton , =?UTF-8?q?Michel=20D=C3=A4nzer?= , =?UTF-8?q?Andr=C3=A9=20Almeida?= Subject: [RESEND PATCH v4 1/3] drm/atomic: Allow userspace to use explicit sync with atomic async flips Date: Fri, 8 Mar 2024 11:55:51 -0300 Message-ID: <20240308145553.194165-2-andrealmeid@igalia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240308145553.194165-1-andrealmeid@igalia.com> References: <20240308145553.194165-1-andrealmeid@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Allow userspace to use explicit synchronization with atomic async flips. That means that the flip will wait for some hardware fence, and then will flip as soon as possible (async) in regard of the vblank. Signed-off-by: Andr=C3=A9 Almeida --- v4: no changes drivers/gpu/drm/drm_atomic_uapi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic= _uapi.c index 29d4940188d4..1eecfb9e240d 100644 --- a/drivers/gpu/drm/drm_atomic_uapi.c +++ b/drivers/gpu/drm/drm_atomic_uapi.c @@ -1066,7 +1066,9 @@ int drm_atomic_set_property(struct drm_atomic_state *= state, break; } =20 - if (async_flip && prop !=3D config->prop_fb_id) { + if (async_flip && + prop !=3D config->prop_fb_id && + prop !=3D config->prop_in_fence_fd) { ret =3D drm_atomic_plane_get_property(plane, plane_state, prop, &old_val); ret =3D drm_atomic_check_prop_changes(ret, old_val, prop_value, prop); --=20 2.43.0 From nobody Sun Feb 8 19:35:47 2026 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E8FC4C7B for ; Fri, 8 Mar 2024 14:56:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709909779; cv=none; b=IWxGK6tQoi6b1TLJx3nu2wLjY6WzeiI7eK59q/X5CEKp5/zK4mJiKEt4iBEJE4q6DA3TuJeBpH8bPe2GkTRCWly932PHPIb+Str9HbN84ey8U1ZWTb3RMQ1aszjdhXoE1CYPry1hmXKNbdgOL6wDwMPQUqcpB+Dcng9GX3/xqjQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709909779; c=relaxed/simple; bh=5ThtQbWLBgHmpYKWBlCX/ig9OsKqfKuNyKhycD5kgVI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=INBWxAHfrOIQHZ/cvtss7gOdJLvpD9qf+3zDFQG+ufrmHnzatAFRsOx4m0QaUOHUw6VRttzaDc2NCxtIs8+8h6rIQGNGHUfpTmwhpyY8+z7LOkZRqvP0OxWVM01JTa7G56HTqeFF6DbrIneVmDEb4mJoEeJWRISkElvCsVIWOAc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=ma7RYtqG; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="ma7RYtqG" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=krDIRYgU1uLFsIvNtqFMjTjuXBLodI3PgcqmjvYIA64=; b=ma7RYtqGTddCWW/HzBOmsnL5Ut cpRud3IdvZ/c3pm3joUw6CwSSPeRodpDnGoKBQbAExK6ObI17EF5vq2qqqgbecfUF8g9mnspAHfsv AEnNry+B+spRFExeOeJ7Feu0pW6Ka7CMDBjuQumO1dHn0bodi43ZgI49zkYZ1iyf9YD+XfuuittVq LI1/4BSoF54VL0KUVUMZ+baz4xTH+8/CxfTLaj7MmV1oigMDTT+UEqAR8QjYkeMkWDl9HI+iv0cfY ZpdyKtnv/weyNo+o6G0ZLuPMbcsWObrzPZK1DrEIt7/LuVWax2a3GySvway+4buP7PHI849iQ3b0H od/OUN9g==; Received: from [152.249.135.210] (helo=steammachine.lan) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1ribdu-007p93-5S; Fri, 08 Mar 2024 15:56:14 +0100 From: =?UTF-8?q?Andr=C3=A9=20Almeida?= To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, Simon Ser , Pekka Paalanen , daniel@ffwll.ch, Daniel Stone , =?UTF-8?q?=27Marek=20Ol=C5=A1=C3=A1k=27?= , Dave Airlie , ville.syrjala@linux.intel.com, Xaver Hugl , Joshua Ashton , =?UTF-8?q?Michel=20D=C3=A4nzer?= , =?UTF-8?q?Andr=C3=A9=20Almeida?= Subject: [RESEND PATCH v4 2/3] drm: Allow drivers to choose plane types to async flip Date: Fri, 8 Mar 2024 11:55:52 -0300 Message-ID: <20240308145553.194165-3-andrealmeid@igalia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240308145553.194165-1-andrealmeid@igalia.com> References: <20240308145553.194165-1-andrealmeid@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Different planes may have different capabilities of doing async flips, so create a field to let drivers allow async flip per plane type. Signed-off-by: Andr=C3=A9 Almeida --- v4: new patch drivers/gpu/drm/drm_atomic_uapi.c | 4 ++-- drivers/gpu/drm/drm_plane.c | 3 +++ include/drm/drm_plane.h | 5 +++++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic= _uapi.c index 1eecfb9e240d..5c66289188be 100644 --- a/drivers/gpu/drm/drm_atomic_uapi.c +++ b/drivers/gpu/drm/drm_atomic_uapi.c @@ -1075,9 +1075,9 @@ int drm_atomic_set_property(struct drm_atomic_state *= state, break; } =20 - if (async_flip && plane_state->plane->type !=3D DRM_PLANE_TYPE_PRIMARY) { + if (async_flip && !plane_state->plane->async_flip) { drm_dbg_atomic(prop->dev, - "[OBJECT:%d] Only primary planes can be changed during async fl= ip\n", + "[OBJECT:%d] This type of plane cannot be changed during async = flip\n", obj->id); ret =3D -EINVAL; break; diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index 672c655c7a8e..71ada690222a 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -366,6 +366,9 @@ static int __drm_universal_plane_init(struct drm_device= *dev, =20 drm_modeset_lock_init(&plane->mutex); =20 + if (type =3D=3D DRM_PLANE_TYPE_PRIMARY) + plane->async_flip =3D true; + plane->base.properties =3D &plane->properties; plane->dev =3D dev; plane->funcs =3D funcs; diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index 641fe298052d..5e9efb7321ac 100644 --- a/include/drm/drm_plane.h +++ b/include/drm/drm_plane.h @@ -779,6 +779,11 @@ struct drm_plane { * @hotspot_y_property: property to set mouse hotspot y offset. */ struct drm_property *hotspot_y_property; + + /** + * @async_flip: indicates if a plane can do async flips + */ + bool async_flip; }; =20 #define obj_to_plane(x) container_of(x, struct drm_plane, base) --=20 2.43.0 From nobody Sun Feb 8 19:35:47 2026 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3480F20314 for ; Fri, 8 Mar 2024 14:56:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709909784; cv=none; b=rvZFBeWK1c8wINrSEOAlMM58Y4fBO6nOZuNt61/p8bPOviVqL2hw+jjDAkjgA+ZQUaawRanE+rrDI6pCBJA/KgUxy2vgHQKcE5I+YxYLztzsQQ/5c3GklcF3Q46g4qqe9Ps+/gmcP1ZF7C4PkUPIIZrGMH3Af1OWFm+7hsFckxY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709909784; c=relaxed/simple; bh=y80heCwbhAQqqtJAfYk/nrQDwtR1qybFYBcIOVhCOMA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dhpYWj6F74CzwDUYPS0F4fnBGABBja4JasSRZNj4JdspfSBrT3ImmkRhNZuIODSS9wwoDW0++yBvrA0Y/Uw2KFo7ut6uDeXPu5cv6GYAVlLRa0cl9vIwthH/ueC7hjz42+senFQaxpXmNxfJE21FuTS4557EUTH/TP+61fWhWyY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=EzhGPudl; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="EzhGPudl" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yRF44PAwuObJjETXmhstoHPr/yI6S4jcqxgx+14ydL0=; b=EzhGPudlVcIyYE0mO/lcVrqegM F8nFLKO3qO83O6C/zNC/BB2q4TzqXb5kf+kNT+CdO5/fRtyxL6sfEg2XCz21VVJUnquqldXqqiJb9 EnXVU12DNjwcv8jlFotFRw+IZLh7RPOW1nKl8ROwBGT4pHtjeRYzcp7UmimWfRD6CIIM1CjgfYiT1 4xWSIKCJfKsF3gucCVzoIq6JV8DoO7Jr2+6ww0RGsGJ/qZF3O5TwD/3v+AEZMS9lga4BjM0v5Du/q OUeigFkntJ9NPX82nexlacVgHWbeuldHjWKCI3dIHA750BEtePOAOLdtu/VNjxcCs+SfuKob8eyY0 0Kf/oeng==; Received: from [152.249.135.210] (helo=steammachine.lan) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1ribdz-007p93-2D; Fri, 08 Mar 2024 15:56:19 +0100 From: =?UTF-8?q?Andr=C3=A9=20Almeida?= To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, Simon Ser , Pekka Paalanen , daniel@ffwll.ch, Daniel Stone , =?UTF-8?q?=27Marek=20Ol=C5=A1=C3=A1k=27?= , Dave Airlie , ville.syrjala@linux.intel.com, Xaver Hugl , Joshua Ashton , =?UTF-8?q?Michel=20D=C3=A4nzer?= , =?UTF-8?q?Andr=C3=A9=20Almeida?= Subject: [RESEND PATCH v4 3/3] drm/amdgpu: Make it possible to async flip overlay planes Date: Fri, 8 Mar 2024 11:55:53 -0300 Message-ID: <20240308145553.194165-4-andrealmeid@igalia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240308145553.194165-1-andrealmeid@igalia.com> References: <20240308145553.194165-1-andrealmeid@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable amdgpu can handle async flips on overlay planes, so mark it as true during the plane initialization. Signed-off-by: Andr=C3=A9 Almeida --- v4: new patch drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/driv= ers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c index 8a4c40b4c27e..dc5392c08a87 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c @@ -1708,6 +1708,7 @@ int amdgpu_dm_plane_init(struct amdgpu_display_manage= r *dm, } else if (plane->type =3D=3D DRM_PLANE_TYPE_OVERLAY) { unsigned int zpos =3D 1 + drm_plane_index(plane); drm_plane_create_zpos_property(plane, zpos, 1, 254); + plane->async_flip =3D true; } else if (plane->type =3D=3D DRM_PLANE_TYPE_CURSOR) { drm_plane_create_zpos_immutable_property(plane, 255); } --=20 2.43.0