From nobody Fri Dec 19 21:52:01 2025 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E571113B7AB for ; Thu, 7 Mar 2024 21:44:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847869; cv=none; b=fx9N1CeUjz2jDf65ixWPWatbhpQLk7e8MqJdzAIzoeZ3t+jXZV3kMsEaCAgYCwXzZEY7wAYzHFPtpAEbUL3xiO0P963uLWJbKnOcOm0vXdKEcQvxMxu/MgE/OCPdukXx3ITcgv6LPl/kU9BWDQej+TrkTbkU48WfhVezTazz2zc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847869; c=relaxed/simple; bh=G0ZUJP/ZkBCOmzQOJc1xI74aPKgFFLAXayJWxtULjxc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=F5R9Jcgbj/muBjNvRC5Je1zDVe6pN0pf+WAZVFT3pQynVvCMXduukaUE+9D2ecgUjRwwsrmgLfxOHzKko5pLztL3IAn8Pxv/tbvi+t52f0b8mUnUYEW1P8QbmbtntbKn3z75pGJvyG7HsbYuFIdVDkm0sqt57z2E9hO6AMSeUtM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=NBcSLfu1; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NBcSLfu1" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-609ea26233dso26265807b3.0 for ; Thu, 07 Mar 2024 13:44:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709847866; x=1710452666; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=6LhSYtY6QZt6fH5eAYaAFVA5m0RDdwnpK0pNKamW+So=; b=NBcSLfu1DLWTObnvS35sATCi8ie+/+raGwP2HjT+e32a757kLP7q+JNHbd/dphXARy 6gK7WnjH/lIugobtSSeQMTRTWSDeQH4zP9O1c11EOHH73kb1QxZdHe8PNBawWCBy2RVV ACqGFm6L/nTH/r2NSyVjH0a4/LSxJRMt8gu5KKW0Gzs77aAxEYl19Z5e8+cpmCgRBVPN 2trFWG/N5M7TAW5RBC8o2yRnAeZ4vD6CQCifH2FXO3XJKeBEa5MMpevJNwcHztIrU21E u0rdTEiowvo6lilOyVTHzOISuLfdxfJy4OEtXfmybHqOQD2aefzV5gFgBAjQs9gxKNh8 e4aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709847866; x=1710452666; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6LhSYtY6QZt6fH5eAYaAFVA5m0RDdwnpK0pNKamW+So=; b=X00ZPzTgiY4nCPyd6dflP2+s5lcWYI6LmK6iUH+sEZGdgUZbji3W+OYufUTgp/xtZ0 ZiT3CWcPk0dUHPIIGx5y4RMNbYVX5s+Ln1edCQkvsEPzO2y/0gHXnFtrOpFCjFo6bn6X 2G1JdBOoYt8dgNe7PgcFr2ZIZJqxQyx7hU/2LKGDM00tq6y2ZOlDEN9xR9g59Wguc3Sq ex/UpsYnHz3KISWwsxhDvFGp10LwEtX8XxXEeGPkGQKrqg1fU8V8/3MHDv5DnRicrcSW +v+F6+49qiKqfMlMTaZrHn26yi/ejH9aH/FV4hBntqKhzb+ZjKJQx0rB/pNlmgilHHE2 jd4g== X-Forwarded-Encrypted: i=1; AJvYcCV6f8cb34FpmFOgszGkR0yeamsxU86SyCbU60HGkU5DOSX2mkvdpc2wI6F2buOhM0UbiWHxTYd+th77hheQoC+Oi8tc/RJS5X+FKdxX X-Gm-Message-State: AOJu0Yxy6gPJJyoE1s7DdclRel1+Sg6kZdyA9S4nlP26kzX2zAksJpl1 LKe0rhedLAWu/ME3d/o2Yr4rFZrGnIdKUkiy/uitEIAzpPnilku95H1XF2Rqsrx0Pm8Sh7BbNSz vbfDC53H6lA== X-Google-Smtp-Source: AGHT+IH27M/JdvXhcgEPeKFtc+MyRJkzfUjHkwRS3/BAdp+NGrPpYuJmdjyCUfGJsC+OS42qDiD9lhL2aaJPzg== X-Received: from ipylypiv.svl.corp.google.com ([2620:15c:2c5:13:69c0:c447:593d:278c]) (user=ipylypiv job=sendgmr) by 2002:a0d:d801:0:b0:609:ed23:8658 with SMTP id a1-20020a0dd801000000b00609ed238658mr944033ywe.8.1709847866113; Thu, 07 Mar 2024 13:44:26 -0800 (PST) Date: Thu, 7 Mar 2024 13:44:12 -0800 In-Reply-To: <20240307214418.3812290-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240307214418.3812290-1-ipylypiv@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240307214418.3812290-2-ipylypiv@google.com> Subject: [PATCH v8 1/7] ata: libata-sata: Factor out NCQ Priority configuration helpers From: Igor Pylypiv To: Damien Le Moal , Niklas Cassel , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke , Xiang Chen , Artur Paszkiewicz , Bart Van Assche Cc: TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Export libata NCQ Priority configuration helpers to be reused for libsas managed SATA devices. Switched locking from spin_lock_irq() to spin_lock_irqsave(). In the future someone might call these helper functions when interrupts are disabled. spin_unlock_irq() could lead to a premature re-enabling of interrupts, whereas spin_unlock_irqrestore() restores the interrupt state to its condition prior to the spin_lock_irqsave() call. Acked-by: Damien Le Moal Reviewed-by: Jason Yan Reviewed-by: Hannes Reinecke Signed-off-by: Igor Pylypiv Reviewed-by: Niklas Cassel --- drivers/ata/libata-sata.c | 160 +++++++++++++++++++++++++++++--------- include/linux/libata.h | 6 ++ 2 files changed, 128 insertions(+), 38 deletions(-) diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c index 0fb1934875f2..a8d773003d74 100644 --- a/drivers/ata/libata-sata.c +++ b/drivers/ata/libata-sata.c @@ -848,80 +848,143 @@ DEVICE_ATTR(link_power_management_policy, S_IRUGO | = S_IWUSR, ata_scsi_lpm_show, ata_scsi_lpm_store); EXPORT_SYMBOL_GPL(dev_attr_link_power_management_policy); =20 -static ssize_t ata_ncq_prio_supported_show(struct device *device, - struct device_attribute *attr, - char *buf) +/** + * ata_ncq_prio_supported - Check if device supports NCQ Priority + * @ap: ATA port of the target device + * @sdev: SCSI device + * @supported: Address of a boolean to store the result + * + * Helper to check if device supports NCQ Priority feature. + * + * Context: Any context. Takes and releases @ap->lock. + * + * Return: + * * %0 - OK. Status is stored into @supported + * * %-ENODEV - Failed to find the ATA device + */ +int ata_ncq_prio_supported(struct ata_port *ap, struct scsi_device *sdev, + bool *supported) { - struct scsi_device *sdev =3D to_scsi_device(device); - struct ata_port *ap =3D ata_shost_to_port(sdev->host); struct ata_device *dev; - bool ncq_prio_supported; + unsigned long flags; int rc =3D 0; =20 - spin_lock_irq(ap->lock); + spin_lock_irqsave(ap->lock, flags); dev =3D ata_scsi_find_dev(ap, sdev); if (!dev) rc =3D -ENODEV; else - ncq_prio_supported =3D dev->flags & ATA_DFLAG_NCQ_PRIO; - spin_unlock_irq(ap->lock); + *supported =3D dev->flags & ATA_DFLAG_NCQ_PRIO; + spin_unlock_irqrestore(ap->lock, flags); + + return rc; +} +EXPORT_SYMBOL_GPL(ata_ncq_prio_supported); + +static ssize_t ata_ncq_prio_supported_show(struct device *device, + struct device_attribute *attr, + char *buf) +{ + struct scsi_device *sdev =3D to_scsi_device(device); + struct ata_port *ap =3D ata_shost_to_port(sdev->host); + bool supported; + int rc; + + rc =3D ata_ncq_prio_supported(ap, sdev, &supported); + if (rc) + return rc; =20 - return rc ? rc : sysfs_emit(buf, "%u\n", ncq_prio_supported); + return sysfs_emit(buf, "%d\n", supported); } =20 DEVICE_ATTR(ncq_prio_supported, S_IRUGO, ata_ncq_prio_supported_show, NULL= ); EXPORT_SYMBOL_GPL(dev_attr_ncq_prio_supported); =20 -static ssize_t ata_ncq_prio_enable_show(struct device *device, - struct device_attribute *attr, - char *buf) +/** + * ata_ncq_prio_enabled - Check if NCQ Priority is enabled + * @ap: ATA port of the target device + * @sdev: SCSI device + * @enabled: Address of a boolean to store the result + * + * Helper to check if NCQ Priority feature is enabled. + * + * Context: Any context. Takes and releases @ap->lock. + * + * Return: + * * %0 - OK. Status is stored into @enabled + * * %-ENODEV - Failed to find the ATA device + */ +int ata_ncq_prio_enabled(struct ata_port *ap, struct scsi_device *sdev, + bool *enabled) { - struct scsi_device *sdev =3D to_scsi_device(device); - struct ata_port *ap =3D ata_shost_to_port(sdev->host); struct ata_device *dev; - bool ncq_prio_enable; + unsigned long flags; int rc =3D 0; =20 - spin_lock_irq(ap->lock); + spin_lock_irqsave(ap->lock, flags); dev =3D ata_scsi_find_dev(ap, sdev); if (!dev) rc =3D -ENODEV; else - ncq_prio_enable =3D dev->flags & ATA_DFLAG_NCQ_PRIO_ENABLED; - spin_unlock_irq(ap->lock); + *enabled =3D dev->flags & ATA_DFLAG_NCQ_PRIO_ENABLED; + spin_unlock_irqrestore(ap->lock, flags); =20 - return rc ? rc : sysfs_emit(buf, "%u\n", ncq_prio_enable); + return rc; } +EXPORT_SYMBOL_GPL(ata_ncq_prio_enabled); =20 -static ssize_t ata_ncq_prio_enable_store(struct device *device, - struct device_attribute *attr, - const char *buf, size_t len) +static ssize_t ata_ncq_prio_enable_show(struct device *device, + struct device_attribute *attr, + char *buf) { struct scsi_device *sdev =3D to_scsi_device(device); - struct ata_port *ap; - struct ata_device *dev; - long int input; - int rc =3D 0; + struct ata_port *ap =3D ata_shost_to_port(sdev->host); + bool enabled; + int rc; =20 - rc =3D kstrtol(buf, 10, &input); + rc =3D ata_ncq_prio_enabled(ap, sdev, &enabled); if (rc) return rc; - if ((input < 0) || (input > 1)) - return -EINVAL; =20 - ap =3D ata_shost_to_port(sdev->host); - dev =3D ata_scsi_find_dev(ap, sdev); - if (unlikely(!dev)) - return -ENODEV; + return sysfs_emit(buf, "%d\n", enabled); +} + +/** + * ata_ncq_prio_enable - Enable/disable NCQ Priority + * @ap: ATA port of the target device + * @sdev: SCSI device + * @enable: true - enable NCQ Priority, false - disable NCQ Priority + * + * Helper to enable/disable NCQ Priority feature. + * + * Context: Any context. Takes and releases @ap->lock. + * + * Return: + * * %0 - OK. Status is stored into @enabled + * * %-ENODEV - Failed to find the ATA device + * * %-EINVAL - NCQ Priority is not supported or CDL is enabled + */ +int ata_ncq_prio_enable(struct ata_port *ap, struct scsi_device *sdev, + bool enable) +{ + struct ata_device *dev; + unsigned long flags; + int rc =3D 0; + + spin_lock_irqsave(ap->lock, flags); =20 - spin_lock_irq(ap->lock); + dev =3D ata_scsi_find_dev(ap, sdev); + if (!dev) { + rc =3D -ENODEV; + goto unlock; + } =20 if (!(dev->flags & ATA_DFLAG_NCQ_PRIO)) { rc =3D -EINVAL; goto unlock; } =20 - if (input) { + if (enable) { if (dev->flags & ATA_DFLAG_CDL_ENABLED) { ata_dev_err(dev, "CDL must be disabled to enable NCQ priority\n"); @@ -934,9 +997,30 @@ static ssize_t ata_ncq_prio_enable_store(struct device= *device, } =20 unlock: - spin_unlock_irq(ap->lock); + spin_unlock_irqrestore(ap->lock, flags); + + return rc; +} +EXPORT_SYMBOL_GPL(ata_ncq_prio_enable); + +static ssize_t ata_ncq_prio_enable_store(struct device *device, + struct device_attribute *attr, + const char *buf, size_t len) +{ + struct scsi_device *sdev =3D to_scsi_device(device); + struct ata_port *ap =3D ata_shost_to_port(sdev->host); + bool enable; + int rc; + + rc =3D kstrtobool(buf, &enable); + if (rc) + return rc; + + rc =3D ata_ncq_prio_enable(ap, sdev, enable); + if (rc) + return rc; =20 - return rc ? rc : len; + return len; } =20 DEVICE_ATTR(ncq_prio_enable, S_IRUGO | S_IWUSR, diff --git a/include/linux/libata.h b/include/linux/libata.h index 26d68115afb8..6dd9a4f9ca7c 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -1157,6 +1157,12 @@ extern int ata_scsi_change_queue_depth(struct scsi_d= evice *sdev, int queue_depth); extern int ata_change_queue_depth(struct ata_port *ap, struct scsi_device = *sdev, int queue_depth); +extern int ata_ncq_prio_supported(struct ata_port *ap, struct scsi_device = *sdev, + bool *supported); +extern int ata_ncq_prio_enabled(struct ata_port *ap, struct scsi_device *s= dev, + bool *enabled); +extern int ata_ncq_prio_enable(struct ata_port *ap, struct scsi_device *sd= ev, + bool enable); extern struct ata_device *ata_dev_pair(struct ata_device *adev); extern int ata_do_set_mode(struct ata_link *link, struct ata_device **r_fa= iled_dev); extern void ata_scsi_port_error_handler(struct Scsi_Host *host, struct ata= _port *ap); --=20 2.44.0.278.ge034bb2e1d-goog From nobody Fri Dec 19 21:52:01 2025 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4422813E7DA for ; Thu, 7 Mar 2024 21:44:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847871; cv=none; b=e/4wc5AkDgLZTdnn/zf0VaWD1lRg7Cg0F1IKN4JK0aebRc12zWmFfyLYl2RFxvvmkSGfcS+DyhEJmLV/tz9PF00BDznIjUWPunaePo7lqr4Et++hHpQNh5Vc6sG5n/JPFqVVLdZL3CynjHySxxvbpE1Ouu9mFaeb9wLeUPYLFDo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847871; c=relaxed/simple; bh=YSRhJbkprUQQfCWFGDumNRfHglngYq6Oc0DzcoBcuzk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=m5Oe83SEU4Ao7df9BTP254dvp+i7tghQOLGo3xNXroBGQ+9sjYpLZBeMArtDwNIMn2m+T8n2t6F43NXb30SydiN1Xjk2bvr/JbtkboM3zazI68MHfWsfeKJzEHgz0RmXopAjtkkTxPFkAF0LUYcMf+yxss/avr3/JY1eRl8YyZk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=UNg3IrAZ; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UNg3IrAZ" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dd0ae66422fso2856253276.0 for ; Thu, 07 Mar 2024 13:44:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709847868; x=1710452668; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=D/UjozYWsvAN/C5p7VPWLV1GhNI2WpC2ansFPUNxUuY=; b=UNg3IrAZIrKJGu0prw6rH31+vj6uMSMTvHYqHzzrTwsCiFFMY6hNGdMSSKRXFILu/8 hWToUy1UiPES++7Yg5l6bQeDmz9y7l2U5m275rV2L/DY/4T1eTr0JjmOw3Nf2eQns8+l b9qiHu68JlaQBCwsAwQt1X/Hlwrzsegg+3Q937fxUsF6WePy5A4seEiT4eht9yWIo6/L A8bFBaq8JnUQKkI0y2ogPt8euS/02lVhX25TDLA4IRZuiFKJo+hXC0fQ2WfEhWrFdgeb 3at+1xADEjBTquij7n0qq6cqvJB7Hi4MSevX8i3zrl2hxr4OpYW62CGl+6P817mxSyuT ENuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709847868; x=1710452668; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D/UjozYWsvAN/C5p7VPWLV1GhNI2WpC2ansFPUNxUuY=; b=cAt+bwoNOUpks6BLKypIU0EaAPIDfxdONwyyI+JfuKOILeYmYw6xikBjqu+TjJMStv jVcPipGLb/Jmf5jtfD934Yb+Zizhe4fvCwEya316wDa70ePt4u4VU7HiXOlByVjXi1VT HYSWxN9ynG2yG8Pd51VvKNw73DE0rNPDRtRdOukE9Xv4si60KbgwXWX73FPo7jpopHgl j6c8hpbQgFDeaUpVW/zGyYTl9DcsIjafeKN9j/oN0HvqeF5eE4YH21AAXcjc4ySMzzpt JzWB3jVkjUMaSgGoZI7uaVxHHekv7sZm9tsKoVnT4pvy5LH7eBLMb0BWFdL6+nvjTdcn QmqA== X-Forwarded-Encrypted: i=1; AJvYcCWbvgQhOy87Kqk4lv1Rc2jfrOcUb1x3dh6tVhuzPOxgl/wwWPqu5t2zVZARRxeRl9z7f5j5POMVt+SF8AFUOB21+ztgRJyqrHTuX9h3 X-Gm-Message-State: AOJu0YxwIlvgzu1V/ybeYNGnxb7MoRyvgdAfU33q8g2nx0NyCpW5/p6b wDHbjJV2AQIgmvjUHIzq6XQonlvP8uXO0IH5zGfL5LenqlTCdKVsE9aYRYdEY8OgyUtOh7lOB8s +HY5+7ca+OQ== X-Google-Smtp-Source: AGHT+IFw8QcatIQRdLsa6m2Kc7Ojj+5jjhwEI1+rXhke6KtmZMw7oScCyZHQIs5JY2TCjpz6Lgak40Ld5ysn2w== X-Received: from ipylypiv.svl.corp.google.com ([2620:15c:2c5:13:69c0:c447:593d:278c]) (user=ipylypiv job=sendgmr) by 2002:a25:4d45:0:b0:dc6:e884:2342 with SMTP id a66-20020a254d45000000b00dc6e8842342mr731884ybb.5.1709847868286; Thu, 07 Mar 2024 13:44:28 -0800 (PST) Date: Thu, 7 Mar 2024 13:44:13 -0800 In-Reply-To: <20240307214418.3812290-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240307214418.3812290-1-ipylypiv@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240307214418.3812290-3-ipylypiv@google.com> Subject: [PATCH v8 2/7] scsi: libsas: Define NCQ Priority sysfs attributes for SATA devices From: Igor Pylypiv To: Damien Le Moal , Niklas Cassel , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke , Xiang Chen , Artur Paszkiewicz , Bart Van Assche Cc: TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Libata sysfs attributes cannot be used for libsas managed SATA devices because the ata_port location is different for libsas. Defined sysfs attributes (visible for SATA devices only): - /sys/block/sda/device/ncq_prio_enable - /sys/block/sda/device/ncq_prio_supported The newly defined attributes will pass the correct ata_port to libata helper functions. Reviewed-by: John Garry Reviewed-by: Damien Le Moal Reviewed-by: Jason Yan Signed-off-by: Igor Pylypiv Reviewed-by: Niklas Cassel --- drivers/scsi/libsas/sas_ata.c | 82 +++++++++++++++++++++++++++++++++++ include/scsi/sas_ata.h | 6 +++ 2 files changed, 88 insertions(+) diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index 12e2653846e3..b57c041a5544 100644 --- a/drivers/scsi/libsas/sas_ata.c +++ b/drivers/scsi/libsas/sas_ata.c @@ -964,3 +964,85 @@ int sas_execute_ata_cmd(struct domain_device *device, = u8 *fis, int force_phy_id) force_phy_id, &tmf_task); } EXPORT_SYMBOL_GPL(sas_execute_ata_cmd); + +static ssize_t sas_ncq_prio_supported_show(struct device *device, + struct device_attribute *attr, + char *buf) +{ + struct scsi_device *sdev =3D to_scsi_device(device); + struct domain_device *ddev =3D sdev_to_domain_dev(sdev); + bool supported; + int rc; + + rc =3D ata_ncq_prio_supported(ddev->sata_dev.ap, sdev, &supported); + if (rc) + return rc; + + return sysfs_emit(buf, "%d\n", supported); +} + +DEVICE_ATTR(ncq_prio_supported, S_IRUGO, sas_ncq_prio_supported_show, NULL= ); + +static ssize_t sas_ncq_prio_enable_show(struct device *device, + struct device_attribute *attr, + char *buf) +{ + struct scsi_device *sdev =3D to_scsi_device(device); + struct domain_device *ddev =3D sdev_to_domain_dev(sdev); + bool enabled; + int rc; + + rc =3D ata_ncq_prio_enabled(ddev->sata_dev.ap, sdev, &enabled); + if (rc) + return rc; + + return sysfs_emit(buf, "%d\n", enabled); +} + +static ssize_t sas_ncq_prio_enable_store(struct device *device, + struct device_attribute *attr, + const char *buf, size_t len) +{ + struct scsi_device *sdev =3D to_scsi_device(device); + struct domain_device *ddev =3D sdev_to_domain_dev(sdev); + bool enable; + int rc; + + rc =3D kstrtobool(buf, &enable); + if (rc) + return rc; + + rc =3D ata_ncq_prio_enable(ddev->sata_dev.ap, sdev, enable); + if (rc) + return rc; + + return len; +} + +DEVICE_ATTR(ncq_prio_enable, S_IRUGO | S_IWUSR, + sas_ncq_prio_enable_show, sas_ncq_prio_enable_store); + +static struct attribute *sas_ata_sdev_attrs[] =3D { + &dev_attr_ncq_prio_supported.attr, + &dev_attr_ncq_prio_enable.attr, + NULL +}; + +static umode_t sas_ata_attr_is_visible(struct kobject *kobj, + struct attribute *attr, int i) +{ + struct device *dev =3D kobj_to_dev(kobj); + struct scsi_device *sdev =3D to_scsi_device(dev); + struct domain_device *ddev =3D sdev_to_domain_dev(sdev); + + if (!dev_is_sata(ddev)) + return 0; + + return attr->mode; +} + +const struct attribute_group sas_ata_sdev_attr_group =3D { + .attrs =3D sas_ata_sdev_attrs, + .is_visible =3D sas_ata_attr_is_visible, +}; +EXPORT_SYMBOL_GPL(sas_ata_sdev_attr_group); diff --git a/include/scsi/sas_ata.h b/include/scsi/sas_ata.h index 2f8c719840a6..92e27e7bf088 100644 --- a/include/scsi/sas_ata.h +++ b/include/scsi/sas_ata.h @@ -39,6 +39,9 @@ int smp_ata_check_ready_type(struct ata_link *link); int sas_discover_sata(struct domain_device *dev); int sas_ata_add_dev(struct domain_device *parent, struct ex_phy *phy, struct domain_device *child, int phy_id); + +extern const struct attribute_group sas_ata_sdev_attr_group; + #else =20 static inline void sas_ata_disabled_notice(void) @@ -123,6 +126,9 @@ static inline int sas_ata_add_dev(struct domain_device = *parent, struct ex_phy *p sas_ata_disabled_notice(); return -ENODEV; } + +#define sas_ata_sdev_attr_group ((struct attribute_group) {}) + #endif =20 #endif /* _SAS_ATA_H_ */ --=20 2.44.0.278.ge034bb2e1d-goog From nobody Fri Dec 19 21:52:01 2025 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 787BD13F45A for ; Thu, 7 Mar 2024 21:44:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847873; cv=none; b=IR5v35qyKIx8ECeV8AjExNHDviOxkw1gIhrscwnqAJZ5RRjs9+eoY3jPY0Cw8HZR8xprrNhznoEpaVJPJdf3CbVSwajLO3bXWDlbDaJsFCmsHiCJeOHqBtpS50B84X5twq1wWYells/x1TZrTzm36SPLcodpgYUeAKlApJtCcuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847873; c=relaxed/simple; bh=kXKDe8j9cFkvG0Qo2NNWFPNOx8lWfLmANEVe8Lz+sfQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=fg7JFjR7QO5QR/MRUwmp9umGDRSTEnRTRBUODoWuFBbngy/6JVhCwVLgtjtjZQUQ253mBppDLoGWpzk1JerklzJqLgjNER+uSvBJ5rH9ak/oPqQJ6UWxUYF6Kjwt63rCLvNmUVet5OV8GpESKtypvtT0flVriUC2I2unxajzK3E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=D1DpE+ab; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="D1DpE+ab" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dce775fa8adso2442034276.1 for ; Thu, 07 Mar 2024 13:44:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709847870; x=1710452670; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=DmnC3uyU6x6FeNu8iM8omlazV5ryfMaj3jlXFhUGyaE=; b=D1DpE+ab+naWXQGjUzfPh4S+YlIk9qcfq8LDHSB/f1uQ9eUR8Ygi+mN6oF/Lc7VdPF CatRjXqAkrTeqZ1RK/umviv3x5Xtxv2h0E8oYXbmJg9zETztI2mPu/a568tCcs/ouXFO k4aTNmdcfspyXKrT93aEA14zPP2fOFpY3TKRbiQ10NHnDX3Op7arGzcnHtnahPxG5duv lSCOO2kG34dwqYgueUiWshmJEM4M1iJwWDZEj/YpK/xta9xUSHZbjSFI5EYX+POahYcK HDbAyRGHnjLqSwlH/rwC6T0L+vbEWP5MBcst7dledXwMJMIRADqvgOSghpWttN+I1/9O 39bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709847870; x=1710452670; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DmnC3uyU6x6FeNu8iM8omlazV5ryfMaj3jlXFhUGyaE=; b=Gu4l5s7WhP2E6wEmnFEpQ/eiRKv6Ahp5QIQkWQpQrDfYAeLRghZKBvaLP45rLrjFsv z5eciyGgfhPwuberv4sBMg46rbjH0JUzI+UGDdGfvVtHfUqHUo7w5kB7uHUsvtlz3Pwy PSgNh/RvpkdtTNB8CpDrYosvvxYW3+xOeq8UAsGdjDekrsGk2xVqH2ObBdQz88H8HRv0 ndXNXyNCgpRffOmFqSw0mX9GVZvLqctOsclru+lvluBVPB8gqtavlG8nMN9TpPhFgeMy 4J4uj6KTOYaBVv0Uq1R3LP+YVwV5iR4/WZnxx088uBQOYqTV6hSCZ5Llg/3tSIvDKWYr f9DA== X-Forwarded-Encrypted: i=1; AJvYcCW8ZF2+WjA8HiB5VTQVyGJyZwgjHfAnap1DB8DMVA4rlPaFqNMpSw5vIRGBxxBcvYunwG2yUOSKHCB/upJVVc9Dp+xrUHMI6oskwKr3 X-Gm-Message-State: AOJu0YwsS5XGb2WtOSpLww2nzudj1gbfH1UBX0C1BrQOcw5FHarsCv6h tBVK/KyAjM33qSBT0kvUDJn0d65qMq+hATsGNghAt7CpSh6TyFAbukgyCwYbB3M0RNPz3aAECnJ zmiK8ShbzCw== X-Google-Smtp-Source: AGHT+IGtgGYTjr9pq4RmsTDLnlYdDyhrwsA9Ej+IKG1Z6YxiyO5O6tRc0vDyQXeFVxteRRR1yu9MazcedogGQA== X-Received: from ipylypiv.svl.corp.google.com ([2620:15c:2c5:13:69c0:c447:593d:278c]) (user=ipylypiv job=sendgmr) by 2002:a05:6902:1004:b0:dc2:3441:897f with SMTP id w4-20020a056902100400b00dc23441897fmr4675217ybt.6.1709847870576; Thu, 07 Mar 2024 13:44:30 -0800 (PST) Date: Thu, 7 Mar 2024 13:44:14 -0800 In-Reply-To: <20240307214418.3812290-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240307214418.3812290-1-ipylypiv@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240307214418.3812290-4-ipylypiv@google.com> Subject: [PATCH v8 3/7] scsi: pm80xx: Add libsas SATA sysfs attributes group From: Igor Pylypiv To: Damien Le Moal , Niklas Cassel , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke , Xiang Chen , Artur Paszkiewicz , Bart Van Assche Cc: TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv , Jack Wang Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Acked-by: Jack Wang Reviewed-by: John Garry Reviewed-by: Damien Le Moal Reviewed-by: Jason Yan Reviewed-by: Hannes Reinecke Reviewed-by: Niklas Cassel Signed-off-by: Igor Pylypiv --- drivers/scsi/pm8001/pm8001_ctl.c | 5 +++++ drivers/scsi/pm8001/pm8001_init.c | 1 + drivers/scsi/pm8001/pm8001_sas.h | 1 + 3 files changed, 7 insertions(+) diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_= ctl.c index 5c26a13ffbd2..9ffe1a868d0f 100644 --- a/drivers/scsi/pm8001/pm8001_ctl.c +++ b/drivers/scsi/pm8001/pm8001_ctl.c @@ -1039,3 +1039,8 @@ const struct attribute_group *pm8001_host_groups[] = =3D { &pm8001_host_attr_group, NULL }; + +const struct attribute_group *pm8001_sdev_groups[] =3D { + &sas_ata_sdev_attr_group, + NULL +}; diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001= _init.c index ed6b7d954dda..e6b1108f6117 100644 --- a/drivers/scsi/pm8001/pm8001_init.c +++ b/drivers/scsi/pm8001/pm8001_init.c @@ -134,6 +134,7 @@ static const struct scsi_host_template pm8001_sht =3D { .compat_ioctl =3D sas_ioctl, #endif .shost_groups =3D pm8001_host_groups, + .sdev_groups =3D pm8001_sdev_groups, .track_queue_depth =3D 1, .cmd_per_lun =3D 32, .map_queues =3D pm8001_map_queues, diff --git a/drivers/scsi/pm8001/pm8001_sas.h b/drivers/scsi/pm8001/pm8001_= sas.h index 3ccb7371902f..ced6721380a8 100644 --- a/drivers/scsi/pm8001/pm8001_sas.h +++ b/drivers/scsi/pm8001/pm8001_sas.h @@ -717,6 +717,7 @@ int pm80xx_fatal_errors(struct pm8001_hba_info *pm8001_= ha); void pm8001_free_dev(struct pm8001_device *pm8001_dev); /* ctl shared API */ extern const struct attribute_group *pm8001_host_groups[]; +extern const struct attribute_group *pm8001_sdev_groups[]; =20 #define PM8001_INVALID_TAG ((u32)-1) =20 --=20 2.44.0.278.ge034bb2e1d-goog From nobody Fri Dec 19 21:52:01 2025 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46BCD13E7CD for ; Thu, 7 Mar 2024 21:44:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847875; cv=none; b=rPdmEkf9e8aoiJYHUc4bU3yQlr7D5NQloozWWWGvJh601kgKfgrQ8fBDICQ7jNFh1VbUzURmr7qPXdEVuZnvGQeQiHmPyE3J80dneUyOTpsBKFEdjvUm6/kBslLglbgWqyy77WHW8MjC4ruyY/CXTy3WQqfaAE7Dr7uaAhg0RUc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847875; c=relaxed/simple; bh=2cCuW0dKXiDPC1nTNSQxTi3GScOXsxTSOfJ1DyyKmYo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ROLIz8N64Jb1BnwqsEWMKFtRlLUguer3H60BkOr+S08WuYrVHQPznz44oyhWNLQBMWm2lsMV0OTz/gyGNJIouEuVO0WpD2MjMyzM04xiJtw5akmC/P9hhozalN9grzIU6nsrGYkVebti8FumucUmp+OijKESVmSuDrhM7eiGYAg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=DbowNptD; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DbowNptD" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-608e4171382so21737337b3.3 for ; Thu, 07 Mar 2024 13:44:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709847872; x=1710452672; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=xCVD89QW7GNEyZMm3uxDu0K7SFt0NpK9jCVrU7O98fk=; b=DbowNptDu6GvfsIZLO4YQ2liRah+Fqru+SdAchb/1kbO6ATGPXFMWAABtOZb+Wv/ac ysVlcDkKiUmTamNNsu0E4QyFhfhE0eUDSye22dmEXTgBENkVn2R7k4b6sTQNZj9SteFZ GnO1kvIEg1AtJn89E3PvxoHxy698YepXVHU6Pi6vqMBUvilbytJSe/mdA743WwDckPZn T49OdtSvKRqz7o8kHO9br/jRQpb+/A7FfNK34MYtXiAqs68Hcm3hhbq1MgkjQFPQM/+5 0mKaGjsdIAmKe/8iJj21GiGU6zn7uUFXErZC+F0iztbXY7mwN3rzIIiyDKAKFnj9euYF WuIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709847872; x=1710452672; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xCVD89QW7GNEyZMm3uxDu0K7SFt0NpK9jCVrU7O98fk=; b=JuMKWMelVDxGX55aTmKCygdChGjG+ApkSncLBUAfIrPMV1kYUmBhdwclXKzlBP/tuF gWDdWXbXwqDijOtd11xL2Dgi1Hmu1etonasBcgFVzQlqB46LNplbPQeOcyQDrUb0k2kr w5n49v2B64mKDbRf8Xgm4ryjf0DaorfypdcdPSKUoD7D2/kjud2RizdImMnfr5LX9gn2 kuy/ua9jvGHLqCEFEbwlZUI75x5w/Bo/hwzLxPxisnJugHU3486nR5OkzYPyvwMIR0Hc s/Veg50uxlWh4YCNlzXnd7GUEJAt3hhew/Cws/lkDLFmDicfz15RnLZmyFgAPfTAmtqF ogLA== X-Forwarded-Encrypted: i=1; AJvYcCWVRDrKP3B9da2v9b8ewcr+cOxQkQ9h7q3nSSzn7H0ox+BwMuhuoPCW7YmgoRtyCqVI2M64/J8FQcpNdd3HPZ1lkU9Il8YZpMHShf39 X-Gm-Message-State: AOJu0YxWnaYPS0nMFronatZwLRADrTtoMIFguJvzv0FMfRDDfKL28iIj oQxu9jK6gjyr35vIpaRuOMcnR8R6fCCHf9pTnYUFVU9svOpfMrm15ddv5TO+AxgAjBcOv0hzl5M cO74vLRG5VQ== X-Google-Smtp-Source: AGHT+IHFQpQPPxJUddGyW0JiXEzVAvGBFFo64g+1nPyj7FNywLHMbgXYRR0N15fZG9B2KbpTYVn4kNRzaytYCg== X-Received: from ipylypiv.svl.corp.google.com ([2620:15c:2c5:13:69c0:c447:593d:278c]) (user=ipylypiv job=sendgmr) by 2002:a05:690c:d0c:b0:607:d300:77c1 with SMTP id cn12-20020a05690c0d0c00b00607d30077c1mr4165254ywb.4.1709847872495; Thu, 07 Mar 2024 13:44:32 -0800 (PST) Date: Thu, 7 Mar 2024 13:44:15 -0800 In-Reply-To: <20240307214418.3812290-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240307214418.3812290-1-ipylypiv@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240307214418.3812290-5-ipylypiv@google.com> Subject: [PATCH v8 4/7] scsi: mvsas: Add libsas SATA sysfs attributes group From: Igor Pylypiv To: Damien Le Moal , Niklas Cassel , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke , Xiang Chen , Artur Paszkiewicz , Bart Van Assche Cc: TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Reviewed-by: John Garry Reviewed-by: Damien Le Moal Reviewed-by: Jason Yan Reviewed-by: Hannes Reinecke Signed-off-by: Igor Pylypiv Reviewed-by: Niklas Cassel --- drivers/scsi/mvsas/mv_init.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c index 43ebb331e216..f1090bb5f2c9 100644 --- a/drivers/scsi/mvsas/mv_init.c +++ b/drivers/scsi/mvsas/mv_init.c @@ -26,6 +26,7 @@ static const struct mvs_chip_info mvs_chips[] =3D { }; =20 static const struct attribute_group *mvst_host_groups[]; +static const struct attribute_group *mvst_sdev_groups[]; =20 #define SOC_SAS_NUM 2 =20 @@ -53,6 +54,7 @@ static const struct scsi_host_template mvs_sht =3D { .compat_ioctl =3D sas_ioctl, #endif .shost_groups =3D mvst_host_groups, + .sdev_groups =3D mvst_sdev_groups, .track_queue_depth =3D 1, }; =20 @@ -779,6 +781,11 @@ static struct attribute *mvst_host_attrs[] =3D { =20 ATTRIBUTE_GROUPS(mvst_host); =20 +static const struct attribute_group *mvst_sdev_groups[] =3D { + &sas_ata_sdev_attr_group, + NULL +}; + module_init(mvs_init); module_exit(mvs_exit); =20 --=20 2.44.0.278.ge034bb2e1d-goog From nobody Fri Dec 19 21:52:01 2025 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 993BF14263A for ; Thu, 7 Mar 2024 21:44:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847877; cv=none; b=mOj640PyXA3fIa7qHtIpkd+Fr1Z6A1LPXyx/6xDSGPmx0sfChENF9lsBKyK83ZLeGhMON43ytfwEncwy267cOXF0OYKvFvvSw2rFv7nR70VVjDjAr82hpEDGjwxRQM9B7Jm5odtrC21SS9MllUAZZ30v/RQY7dt7xxjxxum0Mrc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847877; c=relaxed/simple; bh=kCUyYic0llMdCDm2+Ue48zOf2WyrmeyB/4BoGeE0niE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=mxIA+YnlAh5Dc/uLOn1xP5ZrLV3ShiRnwwrGbhywAryQqkTexef1y6ruxA4v+54JtHD2FFjwZEVThQM1QkfQ4/7Y6yXVjNtcNzwjOcGqGQRgA5tcw2LBTirfO3pheKQcFtrst0fZo2bHhLnP/8OIvrpgzkUwvZl4dbwavVOQHKo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=eTf1iMg5; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eTf1iMg5" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dced704f17cso2397091276.1 for ; Thu, 07 Mar 2024 13:44:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709847874; x=1710452674; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=FNHEYmkbDz44hYs4zD+M5ZgpK+WL/ZuC9mDgGa4D+bI=; b=eTf1iMg57mQ4/JCiUJ7Nuotf3smmBrRbtU2SVGdND6v7bkC15iFwiUnhy+msB/m3C9 6uy84ky5YtTTlDI13rgnYz7XbqoMXougOd38vtCxF0Av6rGLn7n380MWlHnhgax6TWhL IaW0hJkJyU6+2cV6A13DDVZjQv7+6x/ZUQhhWbW7NJYkIS1PhqiXkDJZG4X4/JovSkFM MEL1hSVuDX2iO3ilaXMvPeGfmysbLaJq5wxIx3e1ldQFdcho14EpiYK+0BoOwQXSb8Yj 6ZHHMLTzF+Hvk5tUMsH/XOMRVDA7Aljha1Jjy9qQUygZV+QGRma/yH8nn0TYE3Zs/PIO lcnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709847874; x=1710452674; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FNHEYmkbDz44hYs4zD+M5ZgpK+WL/ZuC9mDgGa4D+bI=; b=s1tQHIiDKOWQa5AoQRgeLXmtfpENxsAOGUCWutFwMHCzFiyWuULzuGRTFl5zMg5rkF m3gaQl8Re9ZdML0hTCsdvlf6rgd8Kwu+5eZgOloIv7XHefPiVdGX080yB+SMGIJpbZWi FgUc+dseaJZxFaQbIYC+c06wa5XvuePzSr06OG8RAavdkk15xQkQTFAAlhoGNSJ/174n YAQpT282csNAUVP1QIROSOsRwBuFa2YqLig15h+Dvi+jYcn/06Yxj2k1r8pfknbsxVnq 3S9ZCckiIigVNBoXNFfsS+k8jU/UatiDF/JvrnZlh5syuUb2T6iTNWZrc81D1KhcBVZE Regg== X-Forwarded-Encrypted: i=1; AJvYcCXq6aQ0aYr45SxIAcEWulCQRnnQqqo4GRBQc/lWvkot5+Xr3PnOKRCROe79b1g5P9DGUJ5CzZKqNChCfxkE0gs996ZV2UfNqsEq1ZnO X-Gm-Message-State: AOJu0YwyMWDeOMy/03sc9i+NCbf2r6XNzjnOwLOZv70wYIvDAh6VGYaM m8lWgtjM4yy2pIWIOfjC2ibr8KLe6qejTRPQN6YMU8Q0sPwUnuUYomI+RzsMLqWGwmEvtOMVdPh GerWDxlN//g== X-Google-Smtp-Source: AGHT+IFtnbGMiVxBhyZl+UF8YJm4Nl++uoxkJhVo05Ue3MkENEDojQCqlrApHQ4o+1Clhjzk7BciZ1hWB3GZfw== X-Received: from ipylypiv.svl.corp.google.com ([2620:15c:2c5:13:69c0:c447:593d:278c]) (user=ipylypiv job=sendgmr) by 2002:a25:f307:0:b0:dc7:4af0:8c6c with SMTP id c7-20020a25f307000000b00dc74af08c6cmr784505ybs.6.1709847874683; Thu, 07 Mar 2024 13:44:34 -0800 (PST) Date: Thu, 7 Mar 2024 13:44:16 -0800 In-Reply-To: <20240307214418.3812290-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240307214418.3812290-1-ipylypiv@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240307214418.3812290-6-ipylypiv@google.com> Subject: [PATCH v8 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes group From: Igor Pylypiv To: Damien Le Moal , Niklas Cassel , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke , Xiang Chen , Artur Paszkiewicz , Bart Van Assche Cc: TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Omitted hisi_sas_v1_hw.c because v1 HW doesn't support SATA. Reviewed-by: John Garry Reviewed-by: Damien Le Moal Reviewed-by: Jason Yan Reviewed-by: Hannes Reinecke Signed-off-by: Igor Pylypiv Reviewed-by: Niklas Cassel --- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ++++++ drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas= /hisi_sas_v2_hw.c index 73b378837da7..b5d379ebe05d 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c @@ -3544,6 +3544,11 @@ static struct attribute *host_v2_hw_attrs[] =3D { =20 ATTRIBUTE_GROUPS(host_v2_hw); =20 +static const struct attribute_group *sdev_groups_v2_hw[] =3D { + &sas_ata_sdev_attr_group, + NULL +}; + static void map_queues_v2_hw(struct Scsi_Host *shost) { struct hisi_hba *hisi_hba =3D shost_priv(shost); @@ -3585,6 +3590,7 @@ static const struct scsi_host_template sht_v2_hw =3D { .compat_ioctl =3D sas_ioctl, #endif .shost_groups =3D host_v2_hw_groups, + .sdev_groups =3D sdev_groups_v2_hw, .host_reset =3D hisi_sas_host_reset, .map_queues =3D map_queues_v2_hw, .host_tagset =3D 1, diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas= /hisi_sas_v3_hw.c index b56fbc61a15a..9b69ea16a1e6 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c @@ -2929,6 +2929,11 @@ static struct attribute *host_v3_hw_attrs[] =3D { =20 ATTRIBUTE_GROUPS(host_v3_hw); =20 +static const struct attribute_group *sdev_groups_v3_hw[] =3D { + &sas_ata_sdev_attr_group, + NULL +}; + #define HISI_SAS_DEBUGFS_REG(x) {#x, x} =20 struct hisi_sas_debugfs_reg_lu { @@ -3340,6 +3345,7 @@ static const struct scsi_host_template sht_v3_hw =3D { .compat_ioctl =3D sas_ioctl, #endif .shost_groups =3D host_v3_hw_groups, + .sdev_groups =3D sdev_groups_v3_hw, .tag_alloc_policy =3D BLK_TAG_ALLOC_RR, .host_reset =3D hisi_sas_host_reset, .host_tagset =3D 1, --=20 2.44.0.278.ge034bb2e1d-goog From nobody Fri Dec 19 21:52:01 2025 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DC831428F1 for ; Thu, 7 Mar 2024 21:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847879; cv=none; b=qaesXpn8rlr4JZ0c1eHf7bJSHaNuqsOC+0uyvYNANZBFfAq0jaLBWC8usyN7kAA4wRkZGa0OHH3X3zu7PWoR0JjgE9TdLHmzQmGk5MwwS42K/aGmFoeKcNA/g+xMv+/i301pLxxXRD8U5HBdjxXzgyE88I/6Q2LKvJRAVI/R+N0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847879; c=relaxed/simple; bh=3IHdm2Kbt7Oqnq7hLlZmkndR1cR6l2HysmJJhv/D7aw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=e2y/LiDQx8wlDt1wfzctwMflN7N3pxdnXoY3Mp9lnEazNNF4x2YHXP3BBvJPDzoMdxkIs+mxurGpVAy6mQtsnuVuT2qeFSXG73WemhQkqDRrtBptuLQ9EUt4KEIJ2YUuvu1lodP/YsbZFeIHifQir4PDgaka3CkMrJ7kKIlmLdQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=t12Sbg0f; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="t12Sbg0f" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dcbee93a3e1so416263276.3 for ; Thu, 07 Mar 2024 13:44:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709847876; x=1710452676; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=bwEvId1GeDg0DYsAPfhWaL+EMmX4DxPU1q6ezkgbZrY=; b=t12Sbg0fmiaJ8ZPu1iNR/moz/Rv7t0woY9Uo/tp3vQRv3UYDh+D9Mz37JF4+D2vR8d gGL6Hd5oT741qaEVFSpJVAOXrlAhgrwQSXvkaIHINhnV87bbHBvUp9p/+bf+Noxs5H0i 7XRRQZsqZPmvS8wi8b1Ran6Ern7ffGEV5XEkbPqNiXUI/PjhI/VOuRhaRBmbMXrtEgR4 2hsbygjgg8akvUdHVewVHGQZ2/I9d4QpcN0B3ZJTNsW0Y1GGwYfp7/CY7nxgNsN4RPxL AOkjER25vHQcwAk0qdGv7eDY8NZAPzAUuTZ6OocIgLz5Co5MjCpSeQt8oIswcVBublTn nrTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709847876; x=1710452676; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bwEvId1GeDg0DYsAPfhWaL+EMmX4DxPU1q6ezkgbZrY=; b=AnqZoba3FQQJ3gXCMlo2qRL9GZnFMlun8CcgkUpExGyzBYohnjFyNZ0AoyOFYSrNVl IvI1m+JNFBSlD3+uLjWjlblFjWxdpLIQa/fo+G8g4QpDAzQ7fKqGliAKGFgxPYF0sOqt v1Z330LFGrjzYuo6smTb0jBkWr0eihGEkznjyhA+pfP+A/z4MrNZLfEoCwyfr3nw2dpG a8PGPdGGiwqo24oF0N+PF6kym/CdmuEZSHlKF8G7WVG6MTOarxCHx94qjNg+pgK2Ox2N SdV+oT/udQudRV1qT5PT0tw3QssV61GVi3h0MWAWwL06h58xCRH36VRQxZ0adeE7S9SD Yqhw== X-Forwarded-Encrypted: i=1; AJvYcCWHNCfriJ8kaUK8tuR25gkuuzDCZbDHUeI8TzJUukJTFDir1hYWSd4VI7byJQNo6QdRnFx/IZM1zNX89jHqKqilRmZMTuGmaW9A4TsL X-Gm-Message-State: AOJu0Yww/W1k3JAAxFkNYXDTAhNu3xXrwvrUOV1kI7hIexvbj/DiNP0P JFSBzU4dr+XIzQZHM9f0KynRUErhdOWFWJm5YLYkJvdpdGAYvNRlw0ZcJtxayZRulfi+YQtfhzA dGpybjL4R5g== X-Google-Smtp-Source: AGHT+IFayAfHaKkEPZo+rNikCLiHI2VeVbBzc8tGK0HM4m0xNsouXgxkmZIRd60W1RhGlE+CFfrrZUPbCKvAZQ== X-Received: from ipylypiv.svl.corp.google.com ([2620:15c:2c5:13:69c0:c447:593d:278c]) (user=ipylypiv job=sendgmr) by 2002:a05:6902:1209:b0:dc6:e20f:80cb with SMTP id s9-20020a056902120900b00dc6e20f80cbmr701381ybu.3.1709847876592; Thu, 07 Mar 2024 13:44:36 -0800 (PST) Date: Thu, 7 Mar 2024 13:44:17 -0800 In-Reply-To: <20240307214418.3812290-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240307214418.3812290-1-ipylypiv@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240307214418.3812290-7-ipylypiv@google.com> Subject: [PATCH v8 6/7] scsi: aic94xx: Add libsas SATA sysfs attributes group From: Igor Pylypiv To: Damien Le Moal , Niklas Cassel , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke , Xiang Chen , Artur Paszkiewicz , Bart Van Assche Cc: TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Reviewed-by: John Garry Reviewed-by: Damien Le Moal Reviewed-by: Jason Yan Reviewed-by: Hannes Reinecke Signed-off-by: Igor Pylypiv Reviewed-by: Niklas Cassel --- drivers/scsi/aic94xx/aic94xx_init.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic= 94xx_init.c index 8a3340d8d7ad..ccccd0eb6275 100644 --- a/drivers/scsi/aic94xx/aic94xx_init.c +++ b/drivers/scsi/aic94xx/aic94xx_init.c @@ -14,6 +14,7 @@ #include #include =20 +#include #include =20 #include "aic94xx.h" @@ -34,6 +35,7 @@ MODULE_PARM_DESC(use_msi, "\n" static struct scsi_transport_template *aic94xx_transport_template; static int asd_scan_finished(struct Scsi_Host *, unsigned long); static void asd_scan_start(struct Scsi_Host *); +static const struct attribute_group *asd_sdev_groups[]; =20 static const struct scsi_host_template aic94xx_sht =3D { .module =3D THIS_MODULE, @@ -60,6 +62,7 @@ static const struct scsi_host_template aic94xx_sht =3D { .compat_ioctl =3D sas_ioctl, #endif .track_queue_depth =3D 1, + .sdev_groups =3D asd_sdev_groups, }; =20 static int asd_map_memio(struct asd_ha_struct *asd_ha) @@ -951,6 +954,11 @@ static void asd_remove_driver_attrs(struct device_driv= er *driver) driver_remove_file(driver, &driver_attr_version); } =20 +static const struct attribute_group *asd_sdev_groups[] =3D { + &sas_ata_sdev_attr_group, + NULL +}; + static struct sas_domain_function_template aic94xx_transport_functions =3D= { .lldd_dev_found =3D asd_dev_found, .lldd_dev_gone =3D asd_dev_gone, --=20 2.44.0.278.ge034bb2e1d-goog From nobody Fri Dec 19 21:52:01 2025 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8203914291F for ; Thu, 7 Mar 2024 21:44:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847881; cv=none; b=uMsMwjHBIUAEpCI1kGDqt5u52pECItdB2s/aYj9pOIyX038+G9ryyRY7Et4RZtHq1p37rQjdm2iPKYhNcW6k7nCowtPy1d84ub3MKdxAE0bWM7Z7L0qpO7CZE5ITTzjhQ2EzIAzPHbGPz1DgBDhJRTtB4xNe5y2ICka15FnOtDE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709847881; c=relaxed/simple; bh=oKUWwFJtdtWNhMzwdWgAICCV9qWEtrIx7hjp1hett1A=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=tf+fM5Cj2aCoktOfXiGNbowfAi++qwPEw1yOp12vcFeTmhIlykqFu01mwbEbdZmsFqJOLmqpmwwTF5/1nJLr5o7AsR5QRWp+dM/FuaCdfPodJTmzY85iEQKBeu85JssFdAbQCm4Na9RBFXJuFEcm3n/wJ2wn0sQflKfEZ9LpsYU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=q7lLRLLL; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="q7lLRLLL" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dc6b267bf11so423558276.2 for ; Thu, 07 Mar 2024 13:44:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709847878; x=1710452678; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=2vpzIuphj8BSvlf66XaaBIKXyJGCME8GN7Op/FUvHdM=; b=q7lLRLLLqj4ZixcWweKKNskOKVXZYteWJ2f6RkN2f18wlyun41QTyc/lZd7UOpdT+D xEa0hyQtbsXCoK7Z9w4+jgv2M6zAJV+FEeMUK5aqLq0dmkl79bSF0M60VYy/EGHaOoNF vDAqT47BnwLK4wZ0Mm2+ilSBUaMcrPKuDIxzDdQzBu8QkBFYTjMt2RA010cHSEMlEiKT gR/Q6gD11MhTmpRYbBM8PbRbH2f+FRE5vrYLWTxYCnywtF35vTe2q5PdHbOQcwgyxWut XRFv2MqTMY25YDDHfns1TzHISy3dhAR395zZ8w/wqHTujVvy/anEjgZjUYSIrbDkzXZT wFbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709847878; x=1710452678; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2vpzIuphj8BSvlf66XaaBIKXyJGCME8GN7Op/FUvHdM=; b=pWmp74ghVu9EYi6bDaJsow5fBepQ9DD+fh6r+GHNsZZ0QgZyxSnxdYXUYHeByMPjQs 3c34nQSBIUD7oANcOOyOOl/VDENLZwmmzpCGjo0goxiCB//mJou6BLTWCAsUsOb5VrlR Sta135eooQ1jD3Hze/wKm1RWPk++ryFoIBnV/IPt++a0uhtVT71+45Ca5rJPjpznJncB aS1PBvO7vCzyzeBCwgaJUN3au/EEK86deHM6Knu1adSE1lzrkCfk9qj+lk5yiun+fhB7 5SQL+LFcr1S+LJtnbcFJex6BYPZmSadj1OuDSs4Druf46O8FzSjHqbs1xFxK/ZelCmpS a28Q== X-Forwarded-Encrypted: i=1; AJvYcCWiIvolXHrfDL9mhKG9+VISbwDVz4bCADuCPaxCM4OnLI1V8q9nA5TJQmiZJepIhcJTK8jMP7QenTDNTsPqJDUslnkh8kE4v0zkVvdN X-Gm-Message-State: AOJu0YwxKef0IhJfnYaL9WvxWTG86RBMVOVKTrG3kvgdNiAzrgO1ziZ1 h3j8P4C8OHLx7ujOvp7OZfdahaykbZHh/KYcQ5/StIDnBzyt9w4pupgxHF8u783ms/d9JrjHHFF pvCpE209VPQ== X-Google-Smtp-Source: AGHT+IEJLNyfct4IVxJM1xng3J7p5UWMEzEo7qnqC43CO2vkdOobv3kRmpH4aDa8M7rwEpAdkiwZw+qBIcq8/Q== X-Received: from ipylypiv.svl.corp.google.com ([2620:15c:2c5:13:69c0:c447:593d:278c]) (user=ipylypiv job=sendgmr) by 2002:a05:6902:1009:b0:dbe:387d:a8ef with SMTP id w9-20020a056902100900b00dbe387da8efmr656689ybt.1.1709847878739; Thu, 07 Mar 2024 13:44:38 -0800 (PST) Date: Thu, 7 Mar 2024 13:44:18 -0800 In-Reply-To: <20240307214418.3812290-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240307214418.3812290-1-ipylypiv@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240307214418.3812290-8-ipylypiv@google.com> Subject: [PATCH v8 7/7] scsi: isci: Add libsas SATA sysfs attributes group From: Igor Pylypiv To: Damien Le Moal , Niklas Cassel , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke , Xiang Chen , Artur Paszkiewicz , Bart Van Assche Cc: TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Reviewed-by: John Garry Reviewed-by: Damien Le Moal Reviewed-by: Jason Yan Reviewed-by: Hannes Reinecke Reviewed-by: Niklas Cassel Signed-off-by: Igor Pylypiv --- drivers/scsi/isci/init.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c index 6277162a028b..8658dcd61b87 100644 --- a/drivers/scsi/isci/init.c +++ b/drivers/scsi/isci/init.c @@ -149,6 +149,11 @@ static struct attribute *isci_host_attrs[] =3D { =20 ATTRIBUTE_GROUPS(isci_host); =20 +static const struct attribute_group *isci_sdev_groups[] =3D { + &sas_ata_sdev_attr_group, + NULL +}; + static const struct scsi_host_template isci_sht =3D { =20 .module =3D THIS_MODULE, @@ -176,6 +181,7 @@ static const struct scsi_host_template isci_sht =3D { .compat_ioctl =3D sas_ioctl, #endif .shost_groups =3D isci_host_groups, + .sdev_groups =3D isci_sdev_groups, .track_queue_depth =3D 1, }; =20 --=20 2.44.0.278.ge034bb2e1d-goog