From nobody Tue Dec 23 12:35:56 2025 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21C19130E24 for ; Thu, 7 Mar 2024 17:40:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709833227; cv=none; b=QAmWR6OJy2Dn+T4hVPEnT910g1tHIkQme+6pKdn80nCzeD6kg82O82MenYagnWDHDDS+NO51+VM4NHYyJInCU299X21yHIX28FhC4hNy3XOvwIvdwOWkAXPcUfN08FpOjphHOW11YnjsDw/ByFQB3Gwbeuqkbqk6m5pi7hqLZXU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709833227; c=relaxed/simple; bh=zZMAjPThw9neF0rFKQqn5K77WjJlmrho8flUA6F99+Y=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=e23nT8dzgDa9BTLgjueFt11TbTHuySx4Ih/vXYZ9ezQ6Zp21U9N4DNH9JWlyLY3Zui/FLg0zCn6JtbNvj4JMCxNc/JYZiJcmgMkopUqYwa2TjhghzzIZNpyKVA/s5ickY4a13Yb1vU97nzkCmInrvwZ3hJ6JdB5C5rdehyMAQE4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=BBCU+VEa; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BBCU+VEa" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-6047fed0132so18474117b3.1 for ; Thu, 07 Mar 2024 09:40:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709833225; x=1710438025; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=N0YwbzbP5FZTLjIONNJPfeJ1/VNBa3uXm6yCLCKpsEw=; b=BBCU+VEabxMteTfQQ0YbHVlpHHe8FZCvBBaJuRl4Dd2futHm+M7gLFgEm9cbD5HfRv AkTTF1anKkI8rsJM60PhVXHTQKXIZQ/76oHeCipPZiyPPHX4pMTP+1a4KBt+K3dlTxyp DHdahlfx6ZGDQ8Y18lRdQlPJHx18P8Md6fYB/aWVXLcPfwSyS45VAwjyexZZ2h3nWIO1 MorSdSMkWEea2ckkLN8JCqDjlDMd86pKrPwksEoVB8DlfLwqitQmCIXYQEc9uL/NVm0q W5QUaao5yRj6qWEguF41Tg2Ec3d59IYeM4PpGJGsDMVOhebrvk3fWLOJxYClev8/mIMl Rd1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709833225; x=1710438025; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N0YwbzbP5FZTLjIONNJPfeJ1/VNBa3uXm6yCLCKpsEw=; b=TBY2S+XXa2ICtv49fQdJvZhXoIUSvrzpPUgsFXobLdjeST69MYhk6SLyEUEhecoVB6 /8qV2FwgrL8yLAmB6pKyJXDSXcJ1IiAtZm0TD32lDIYGMypU1/QbgrfN+W5z4KGo580Q DkFS4OVlXISRk3cZ0Qv3m1eehIXn2WbaMy55F9qnGI6RgHFMArdUPe6pfDr43dEBTv+l sH4s7sxYj+4eybPYVYJMX9d/sEc+il9EV342bV1wwVI8eAzcKZAn62HJwT2gaT551fcJ hmYx0BwKQbhQ7h5OivfTPdjrYGqdn8neDcaGdUVW9uHn/+4CMmxeZY/X/Vi/IlclnpVq Tcyg== X-Forwarded-Encrypted: i=1; AJvYcCW+bBIzRUPN2JywwUbZOxdvoHOyBciKnFUSW8uJqwpx1JEwxY+eDH8vlgIbaI0yeZ9TKxDUwFotf0xDWoO8yi5b5fxFvg7BDIvh8VTj X-Gm-Message-State: AOJu0YwBJHzB0t/hhqYCwcnpW2MaivmkN6fB9dybFQ4t2InIHQ8P7xCt A0pMAed3++ZFqjoaURdQko14CtEJPsnjJjk5bb+Z0BiT0mil8w9VPk5oh9kJhszdM/zm7UZESL6 85XjWFA== X-Google-Smtp-Source: AGHT+IFi8pCz2tpIMM3csNv3mom/3CvP1+s6BJFEc09p5I4T6sVJFww7h8sxsrG+ozo/wb7E1npkw5pklwNz X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:47d6:1de1:237a:6728]) (user=irogers job=sendgmr) by 2002:a05:690c:3581:b0:609:4293:23eb with SMTP id fr1-20020a05690c358100b00609429323ebmr4024349ywb.10.1709833225272; Thu, 07 Mar 2024 09:40:25 -0800 (PST) Date: Thu, 7 Mar 2024 09:39:50 -0800 In-Reply-To: <20240307173955.3982040-1-irogers@google.com> Message-Id: <20240307173955.3982040-2-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240307173955.3982040-1-irogers@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Subject: [PATCH v2 1/6] perf list: Add tracepoint encoding to detailed output From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Yang Jihong , Kan Liang , James Clark , Ravi Bangoria , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The tracepoint id holds the config value and is probed in determining what an event is. Add reading of the id so that we can display the event encoding as: ``` $ perf list --details ... alarmtimer:alarmtimer_cancel [Tracepoint event] tracepoint/config=3D0x18c/ ... ``` Signed-off-by: Ian Rogers --- tools/perf/util/print-events.c | 35 ++++++++++++++++++++++++---------- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/tools/perf/util/print-events.c b/tools/perf/util/print-events.c index 7b54e9385442..e0d2b49bab66 100644 --- a/tools/perf/util/print-events.c +++ b/tools/perf/util/print-events.c @@ -9,6 +9,7 @@ #include =20 #include +#include #include #include #include @@ -92,34 +93,48 @@ void print_tracepoint_events(const struct print_callbac= ks *print_cb __maybe_unus =20 evt_items =3D scandirat(events_fd, sys_dirent->d_name, &evt_namelist, NU= LL, alphasort); for (int j =3D 0; j < evt_items; j++) { + /* + * Buffer sized at twice the max filename length + 1 + * separator + 1 \0 terminator. + */ + char buf[NAME_MAX * 2 + 2]; + /* 16 possible hex digits and 22 other characters and \0. */ + char encoding[16 + 22]; struct dirent *evt_dirent =3D evt_namelist[j]; - char evt_path[MAXPATHLEN]; - int evt_fd; + struct io id; + __u64 config; =20 if (evt_dirent->d_type !=3D DT_DIR || !strcmp(evt_dirent->d_name, ".") || !strcmp(evt_dirent->d_name, "..")) goto next_evt; =20 - snprintf(evt_path, sizeof(evt_path), "%s/id", evt_dirent->d_name); - evt_fd =3D openat(dir_fd, evt_path, O_RDONLY); - if (evt_fd < 0) + snprintf(buf, sizeof(buf), "%s/id", evt_dirent->d_name); + io__init(&id, openat(dir_fd, buf, O_RDONLY), buf, sizeof(buf)); + + if (id.fd < 0) + goto next_evt; + + if (io__get_dec(&id, &config) < 0) { + close(id.fd); goto next_evt; - close(evt_fd); + } + close(id.fd); =20 - snprintf(evt_path, MAXPATHLEN, "%s:%s", + snprintf(buf, sizeof(buf), "%s:%s", sys_dirent->d_name, evt_dirent->d_name); + snprintf(encoding, sizeof(encoding), "tracepoint/config=3D0x%llx/", con= fig); print_cb->print_event(print_state, /*topic=3D*/NULL, - /*pmu_name=3D*/NULL, - evt_path, + /*pmu_name=3D*/NULL, /* really "tracepoint" */ + /*event_name=3D*/buf, /*event_alias=3D*/NULL, /*scale_unit=3D*/NULL, /*deprecated=3D*/false, "Tracepoint event", /*desc=3D*/NULL, /*long_desc=3D*/NULL, - /*encoding_desc=3D*/NULL); + encoding); next_evt: free(evt_namelist[j]); } --=20 2.44.0.278.ge034bb2e1d-goog