From nobody Sat Feb 7 09:12:14 2026 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E78063C8 for ; Tue, 5 Mar 2024 00:51:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599872; cv=none; b=nufdFpXzSIpUOn96/mDkMnzOIU13jdG+aEP7GWq0t1O40DjlEdrbXfupTBmyR269tzzXo/xbEIx+DBE4itufXEzAz3gw7i2CztNQal/V1vc432tePBP29SXRj0sAEM0fA2NCrqwPdY5xCFiOm2t7I/wKcvQ+c0Z0Gg6aaqI1TjM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599872; c=relaxed/simple; bh=4Wx/6B3zZCXye3rApBiOXYExLJx00xF0c05Ex3qDfC0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=sH6HLu+zIjXl9HoXtnCUh/mHuHvQTTIZUn1ozJLHS6SAYvmUTqIRqcu3W8+dEvFEq6QxsNyEp7FkvOwXPt58lYvWCPBGReTolQvNRDCGIqKYKPrwLDZSYSTsbui/0tvSJqgiRdMSjFPmisR5dHI+s46ZXesmnR0roMgGxjQqDfM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=0Y0hEL0c; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="0Y0hEL0c" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6092bf785d7so95328417b3.0 for ; Mon, 04 Mar 2024 16:51:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709599869; x=1710204669; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=lq5KdOW2n6/uRJ2XLw3ji0Kzg2Wa90eF3I/52cGKVKA=; b=0Y0hEL0ciXdYqKSRpep0VnbzPyLN3t3FrLho/+Rm6FzKPbxt+oYC5nsuMzKjeuA2vZ s+SyteeC79E+f/C6dRPwYqYRz/Brz/C4ul7xJwNYtIEDDRr8XQkMluaHZpFX2ro1m7I6 7ZWwLd7MrIQhMIcEwHWkEt4sz+lebZMRk64RzEi8mVHoVNOQowQzvgR/P7CG+0exAP6Q RPwYaiK1YxSFYwVkGl4Bq0oXhtXVp6VmbKnfA16ggVUU3UPYL7v3bV9yEOdYwEJmKbE8 u2UFH6UGKeyefgqqzDyHPSFx9eJD8v3Uctj4zdg2KbbWtGs9h2IvsvgF0I8KOiRX6ru5 cjMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709599869; x=1710204669; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lq5KdOW2n6/uRJ2XLw3ji0Kzg2Wa90eF3I/52cGKVKA=; b=vfPJ8CQ4kNGNxBMZGAjaQA/a7iDNbuIUbgx1YfQUG8xEvpTcvTbvVVuLk0BesUWVpd kEoQQzQeMS8wcZNhN+JdDZs04YJFbK64FlrxXeMOBSofOY/m5V4O67V6qtK+iOW7JObp XXMiVocwRFnaXa/QFrtz3yoCIQD1+PPx9aSMOKUWR5g2S9335hjumckfnQRPfRErgoSA ZW7tuLX10wsnsjBjhc2PAwpNTQsmSodDDpA+QCZzmeHAnws0TC/uCUZNSxj9Z/ycsTfj I33XYCRmK/DH9kDL2yQfL0Xv9e21OblpfwC1WConUOH9pPINaMa/y1JHfCYZFt+qCA2+ n/Rw== X-Forwarded-Encrypted: i=1; AJvYcCVtyFaJhapPmCYqWf4EBhq+FrHgRG3Dbv2YHSxB+S9tL+UxZKo1e1VJWUk1eBfbHmzCWzFn4/G54grq9+87vxZ5iL6dYLc/z019+Ru+ X-Gm-Message-State: AOJu0YwhvMxn+dk3/2mYVBwHGGWscRnDGteY+CgLddbQoeaDQ0UGn0yb LZx5MG6/5KXuXQHL636VYs22ZuRfJC1o+bvGn1C5cTCr7In8F4QQJmxMbD1EpJnRk5eWt1WqwZz VPpPG+v+eMA== X-Google-Smtp-Source: AGHT+IETC0ilKp0VGNwzeHzXpNduZxbFkDR1iqMOurCmEF3CmB/y1el4/RowlH133UVUWhxNfGTKeJfaWGachg== X-Received: from ipylypiv.svl.corp.google.com ([2620:15c:2c5:13:e901:e760:20cd:d870]) (user=ipylypiv job=sendgmr) by 2002:a05:690c:c17:b0:609:3834:e0f4 with SMTP id cl23-20020a05690c0c1700b006093834e0f4mr3273696ywb.7.1709599869416; Mon, 04 Mar 2024 16:51:09 -0800 (PST) Date: Mon, 4 Mar 2024 16:50:57 -0800 In-Reply-To: <20240305005103.1849325-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240305005103.1849325-1-ipylypiv@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240305005103.1849325-2-ipylypiv@google.com> Subject: [PATCH v5 1/7] ata: libata-sata: Factor out NCQ Priority configuration helpers From: Igor Pylypiv To: Damien Le Moal , Niklas Cassel , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke , Xiang Chen , Artur Paszkiewicz , Bart Van Assche Cc: TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Export libata NCQ Priority configuration helpers to be reused for libsas managed SATA devices. Acked-by: Damien Le Moal Signed-off-by: Igor Pylypiv Reviewed-by: Jason Yan --- drivers/ata/libata-sata.c | 140 +++++++++++++++++++++++++++----------- include/linux/libata.h | 6 ++ 2 files changed, 107 insertions(+), 39 deletions(-) diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c index 0fb1934875f2..f00dd02dc6f8 100644 --- a/drivers/ata/libata-sata.c +++ b/drivers/ata/libata-sata.c @@ -848,80 +848,122 @@ DEVICE_ATTR(link_power_management_policy, S_IRUGO | = S_IWUSR, ata_scsi_lpm_show, ata_scsi_lpm_store); EXPORT_SYMBOL_GPL(dev_attr_link_power_management_policy); =20 -static ssize_t ata_ncq_prio_supported_show(struct device *device, - struct device_attribute *attr, - char *buf) +/** + * ata_ncq_prio_supported - Check if device supports NCQ Priority + * @ap: ATA port of the target device + * @sdev: SCSI device + * @supported: Address of a boolean to store the result + * + * Helper to check if device supports NCQ Priority feature. + */ +int ata_ncq_prio_supported(struct ata_port *ap, struct scsi_device *sdev, + bool *supported) { - struct scsi_device *sdev =3D to_scsi_device(device); - struct ata_port *ap =3D ata_shost_to_port(sdev->host); struct ata_device *dev; - bool ncq_prio_supported; + unsigned long flags; int rc =3D 0; =20 - spin_lock_irq(ap->lock); + spin_lock_irqsave(ap->lock, flags); dev =3D ata_scsi_find_dev(ap, sdev); if (!dev) rc =3D -ENODEV; else - ncq_prio_supported =3D dev->flags & ATA_DFLAG_NCQ_PRIO; - spin_unlock_irq(ap->lock); + *supported =3D dev->flags & ATA_DFLAG_NCQ_PRIO; + spin_unlock_irqrestore(ap->lock, flags); + return rc; +} +EXPORT_SYMBOL_GPL(ata_ncq_prio_supported); + +static ssize_t ata_ncq_prio_supported_show(struct device *device, + struct device_attribute *attr, + char *buf) +{ + struct scsi_device *sdev =3D to_scsi_device(device); + struct ata_port *ap =3D ata_shost_to_port(sdev->host); + bool supported; + int rc; =20 - return rc ? rc : sysfs_emit(buf, "%u\n", ncq_prio_supported); + rc =3D ata_ncq_prio_supported(ap, sdev, &supported); + if (rc) + return rc; + + return sysfs_emit(buf, "%d\n", supported); } =20 DEVICE_ATTR(ncq_prio_supported, S_IRUGO, ata_ncq_prio_supported_show, NULL= ); EXPORT_SYMBOL_GPL(dev_attr_ncq_prio_supported); =20 -static ssize_t ata_ncq_prio_enable_show(struct device *device, - struct device_attribute *attr, - char *buf) +/** + * ata_ncq_prio_enabled - Check if NCQ Priority is enabled + * @ap: ATA port of the target device + * @sdev: SCSI device + * @enabled: Address of a boolean to store the result + * + * Helper to check if NCQ Priority feature is enabled. + */ +int ata_ncq_prio_enabled(struct ata_port *ap, struct scsi_device *sdev, + bool *enabled) { - struct scsi_device *sdev =3D to_scsi_device(device); - struct ata_port *ap =3D ata_shost_to_port(sdev->host); struct ata_device *dev; - bool ncq_prio_enable; + unsigned long flags; int rc =3D 0; =20 - spin_lock_irq(ap->lock); + spin_lock_irqsave(ap->lock, flags); dev =3D ata_scsi_find_dev(ap, sdev); if (!dev) rc =3D -ENODEV; else - ncq_prio_enable =3D dev->flags & ATA_DFLAG_NCQ_PRIO_ENABLED; - spin_unlock_irq(ap->lock); - - return rc ? rc : sysfs_emit(buf, "%u\n", ncq_prio_enable); + *enabled =3D dev->flags & ATA_DFLAG_NCQ_PRIO_ENABLED; + spin_unlock_irqrestore(ap->lock, flags); + return rc; } +EXPORT_SYMBOL_GPL(ata_ncq_prio_enabled); =20 -static ssize_t ata_ncq_prio_enable_store(struct device *device, - struct device_attribute *attr, - const char *buf, size_t len) +static ssize_t ata_ncq_prio_enable_show(struct device *device, + struct device_attribute *attr, + char *buf) { struct scsi_device *sdev =3D to_scsi_device(device); - struct ata_port *ap; - struct ata_device *dev; - long int input; - int rc =3D 0; + struct ata_port *ap =3D ata_shost_to_port(sdev->host); + bool enabled; + int rc; =20 - rc =3D kstrtol(buf, 10, &input); + rc =3D ata_ncq_prio_enabled(ap, sdev, &enabled); if (rc) return rc; - if ((input < 0) || (input > 1)) - return -EINVAL; =20 - ap =3D ata_shost_to_port(sdev->host); - dev =3D ata_scsi_find_dev(ap, sdev); - if (unlikely(!dev)) - return -ENODEV; + return sysfs_emit(buf, "%d\n", enabled); +} + +/** + * ata_ncq_prio_enable - Enable/disable NCQ Priority + * @ap: ATA port of the target device + * @sdev: SCSI device + * @enable: true - enable NCQ Priority, false - disable NCQ Priority + * + * Helper to enable/disable NCQ Priority feature. + */ +int ata_ncq_prio_enable(struct ata_port *ap, struct scsi_device *sdev, + bool enable) +{ + struct ata_device *dev; + unsigned long flags; + int rc =3D 0; + + spin_lock_irqsave(ap->lock, flags); =20 - spin_lock_irq(ap->lock); + dev =3D ata_scsi_find_dev(ap, sdev); + if (!dev) { + rc =3D -ENODEV; + goto unlock; + } =20 if (!(dev->flags & ATA_DFLAG_NCQ_PRIO)) { rc =3D -EINVAL; goto unlock; } =20 - if (input) { + if (enable) { if (dev->flags & ATA_DFLAG_CDL_ENABLED) { ata_dev_err(dev, "CDL must be disabled to enable NCQ priority\n"); @@ -934,9 +976,29 @@ static ssize_t ata_ncq_prio_enable_store(struct device= *device, } =20 unlock: - spin_unlock_irq(ap->lock); + spin_unlock_irqrestore(ap->lock, flags); + return rc; +} +EXPORT_SYMBOL_GPL(ata_ncq_prio_enable); + +static ssize_t ata_ncq_prio_enable_store(struct device *device, + struct device_attribute *attr, + const char *buf, size_t len) +{ + struct scsi_device *sdev =3D to_scsi_device(device); + struct ata_port *ap =3D ata_shost_to_port(sdev->host); + bool enable; + int rc; + + rc =3D kstrtobool(buf, &enable); + if (rc) + return rc; + + rc =3D ata_ncq_prio_enable(ap, sdev, enable); + if (rc) + return rc; =20 - return rc ? rc : len; + return len; } =20 DEVICE_ATTR(ncq_prio_enable, S_IRUGO | S_IWUSR, diff --git a/include/linux/libata.h b/include/linux/libata.h index 26d68115afb8..6dd9a4f9ca7c 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -1157,6 +1157,12 @@ extern int ata_scsi_change_queue_depth(struct scsi_d= evice *sdev, int queue_depth); extern int ata_change_queue_depth(struct ata_port *ap, struct scsi_device = *sdev, int queue_depth); +extern int ata_ncq_prio_supported(struct ata_port *ap, struct scsi_device = *sdev, + bool *supported); +extern int ata_ncq_prio_enabled(struct ata_port *ap, struct scsi_device *s= dev, + bool *enabled); +extern int ata_ncq_prio_enable(struct ata_port *ap, struct scsi_device *sd= ev, + bool enable); extern struct ata_device *ata_dev_pair(struct ata_device *adev); extern int ata_do_set_mode(struct ata_link *link, struct ata_device **r_fa= iled_dev); extern void ata_scsi_port_error_handler(struct Scsi_Host *host, struct ata= _port *ap); --=20 2.44.0.278.ge034bb2e1d-goog From nobody Sat Feb 7 09:12:14 2026 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B801944E for ; Tue, 5 Mar 2024 00:51:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599873; cv=none; b=rEnIxhppRvpwpl7PkZ2M1by91/6ibCBEe6gkb8F05fgHX7moxRLNsW2RmZiahWk87a/yzFaUOazRuD7ExwcIMCx/I8UQoJHfPTMP9GMWFQcPJcSOyePoORfgWB3dbl3u4xCDpxK4mssEF2ZJ/6a8MY9Iup2bQP97dPINWzhnfT8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599873; c=relaxed/simple; bh=YTgx3WEe4nP8Np9FZNVT4X89BHfmUTsxsDDNkC5GZ1c=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=NmXxQLg/Jmtb0tZ99soMC9UujBa08m/qq1l7nSd9HZJs6ThwPZtU6cx86JztZdV4hI8cDHvn+bcFlsK9ObdZJfDfrR1UUp8gWnHzPWITIusCXPMVj7QlMrzj3XJCYHQ/Ri4SW6j4civg6troVdqrt+d0xyWXYO1qr2vB61w/3iY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=x9KHuD5s; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="x9KHuD5s" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dcc05887ee9so6966499276.1 for ; Mon, 04 Mar 2024 16:51:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709599871; x=1710204671; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=4Rvi5ygT6WAyce3RYZ1KHwBcishPIpdItYF4EiC3R2c=; b=x9KHuD5sysZFEmVAIS3VKO8Sg/YFwZrLKm6i9lTjSXxJR7AaOTTwGuOK2J7DxPHCJh 0pBCZ+SxoHjQBY0CtIMw069uMQZwEsyv9Y/76yoh6MiJkTs3TV6FLtAHZv8u3aUUFq/1 5z9V6jPY86q+qbbCYGPcw2hsGQFTDFwYBb3wsgjLI0DtahEVWX6g1o8U3MUp87jKlpdN VfOXp42BvmqjflzzDYfyhnT11DIH7aVOLDCvMQZ+qHqRR13pIEYSp3DEVXgCXn05GjOJ f4EgYrdIeNcaqNeAx/002dVtm7L0y2TBDsK1SM7TBBKkIyB5q5/bFyZ7wqxBl1vCWzyh b1jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709599871; x=1710204671; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4Rvi5ygT6WAyce3RYZ1KHwBcishPIpdItYF4EiC3R2c=; b=J0o+4yCiERdvE5sRmp1lg5sDGcldTvMEaapukxcsTkmIcoQ/9kX6KvQUXg2xwVuX4F TZjy7lWX3v67MCLIDoa5abf8P/4G4CdB1dsos42ziXVQCISS42zdZp4ZWOsZIR/LZ1zm UgJzaEZdsZ9/LXfTnDo0uUyFbk5C8MlZ1fiSGTsNA9DMMBGbps3ywPEFuXF9PDC5GJaf 8BrKROlKCb5IcYUQF6wsAHKUFh2F/3KjFpnWVDq4ht0xDebmhHboTwbgUBsnAzZx9jZt zp1RHQTVQ4lOX+/kjnnt0YNBcRqVtaK45c+cR9HP2KxgjD5B++Un2pCNqJeV/lZ7d1bN 6qsQ== X-Forwarded-Encrypted: i=1; AJvYcCWsSHkjIITGcqOIB+LZ2K+GFbNPdd3No3kfUbuV3oRPdqX5SbIkShaDVzqdR7SalJuPxC8+lzz/srFWXjFE3biB4e0y0CH4t127QTZ5 X-Gm-Message-State: AOJu0YyeSjsRf91XUKEXPo4EJYbAAT4Hduhb16y23yXqPPpFzIqc0bd8 53+nNdZ3GN/klIvSsPdFLcJvfvpEmGVKdkC6dNhjlwGri0XxRjUjrifqomIm8jzZ6k+XF+8yGdc SFmjsfe9W1A== X-Google-Smtp-Source: AGHT+IFJjsZYiWXboDnHwWPLxZRDjqhfWxS4gVjqhuk3la2dYUeCqDR/H3YDuZseHOnChRDRlRD8ggqzL2MK6Q== X-Received: from ipylypiv.svl.corp.google.com ([2620:15c:2c5:13:e901:e760:20cd:d870]) (user=ipylypiv job=sendgmr) by 2002:a05:6902:154e:b0:dc7:3189:4e75 with SMTP id r14-20020a056902154e00b00dc731894e75mr362935ybu.3.1709599871454; Mon, 04 Mar 2024 16:51:11 -0800 (PST) Date: Mon, 4 Mar 2024 16:50:58 -0800 In-Reply-To: <20240305005103.1849325-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240305005103.1849325-1-ipylypiv@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240305005103.1849325-3-ipylypiv@google.com> Subject: [PATCH v5 2/7] scsi: libsas: Define NCQ Priority sysfs attributes for SATA devices From: Igor Pylypiv To: Damien Le Moal , Niklas Cassel , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke , Xiang Chen , Artur Paszkiewicz , Bart Van Assche Cc: TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Libata sysfs attributes cannot be used for libsas managed SATA devices because the ata_port location is different for libsas. Defined sysfs attributes (visible for SATA devices only): - /sys/block/sda/device/ncq_prio_enable - /sys/block/sda/device/ncq_prio_supported The newly defined attributes will pass the correct ata_port to libata helper functions. Reviewed-by: John Garry Reviewed-by: Damien Le Moal Signed-off-by: Igor Pylypiv Reviewed-by: Jason Yan --- drivers/scsi/libsas/sas_ata.c | 94 +++++++++++++++++++++++++++++++++++ include/scsi/sas_ata.h | 6 +++ 2 files changed, 100 insertions(+) diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index 12e2653846e3..04b0bd9a4e01 100644 --- a/drivers/scsi/libsas/sas_ata.c +++ b/drivers/scsi/libsas/sas_ata.c @@ -964,3 +964,97 @@ int sas_execute_ata_cmd(struct domain_device *device, = u8 *fis, int force_phy_id) force_phy_id, &tmf_task); } EXPORT_SYMBOL_GPL(sas_execute_ata_cmd); + +static ssize_t sas_ncq_prio_supported_show(struct device *device, + struct device_attribute *attr, + char *buf) +{ + struct scsi_device *sdev =3D to_scsi_device(device); + struct domain_device *ddev =3D sdev_to_domain_dev(sdev); + bool supported; + int rc; + + /* This attribute shall be visible for SATA devices only */ + if (WARN_ON_ONCE(!dev_is_sata(ddev))) + return -EINVAL; + + rc =3D ata_ncq_prio_supported(ddev->sata_dev.ap, sdev, &supported); + if (rc) + return rc; + + return sysfs_emit(buf, "%d\n", supported); +} + +DEVICE_ATTR(ncq_prio_supported, S_IRUGO, sas_ncq_prio_supported_show, NULL= ); + +static ssize_t sas_ncq_prio_enable_show(struct device *device, + struct device_attribute *attr, + char *buf) +{ + struct scsi_device *sdev =3D to_scsi_device(device); + struct domain_device *ddev =3D sdev_to_domain_dev(sdev); + bool enabled; + int rc; + + /* This attribute shall be visible for SATA devices only */ + if (WARN_ON_ONCE(!dev_is_sata(ddev))) + return -EINVAL; + + rc =3D ata_ncq_prio_enabled(ddev->sata_dev.ap, sdev, &enabled); + if (rc) + return rc; + + return sysfs_emit(buf, "%d\n", enabled); +} + +static ssize_t sas_ncq_prio_enable_store(struct device *device, + struct device_attribute *attr, + const char *buf, size_t len) +{ + struct scsi_device *sdev =3D to_scsi_device(device); + struct domain_device *ddev =3D sdev_to_domain_dev(sdev); + bool enable; + int rc; + + /* This attribute shall be visible for SATA devices only */ + if (WARN_ON_ONCE(!dev_is_sata(ddev))) + return -EINVAL; + + rc =3D kstrtobool(buf, &enable); + if (rc) + return rc; + + rc =3D ata_ncq_prio_enable(ddev->sata_dev.ap, sdev, enable); + if (rc) + return rc; + + return len; +} + +DEVICE_ATTR(ncq_prio_enable, S_IRUGO | S_IWUSR, + sas_ncq_prio_enable_show, sas_ncq_prio_enable_store); + +static struct attribute *sas_ata_sdev_attrs[] =3D { + &dev_attr_ncq_prio_supported.attr, + &dev_attr_ncq_prio_enable.attr, + NULL +}; + +static umode_t sas_ata_attr_is_visible(struct kobject *kobj, + struct attribute *attr, int i) +{ + struct device *dev =3D kobj_to_dev(kobj); + struct scsi_device *sdev =3D to_scsi_device(dev); + struct domain_device *ddev =3D sdev_to_domain_dev(sdev); + + if (!dev_is_sata(ddev)) + return 0; + + return attr->mode; +} + +const struct attribute_group sas_ata_sdev_attr_group =3D { + .attrs =3D sas_ata_sdev_attrs, + .is_visible =3D sas_ata_attr_is_visible, +}; +EXPORT_SYMBOL_GPL(sas_ata_sdev_attr_group); diff --git a/include/scsi/sas_ata.h b/include/scsi/sas_ata.h index 2f8c719840a6..cded782fdf33 100644 --- a/include/scsi/sas_ata.h +++ b/include/scsi/sas_ata.h @@ -39,6 +39,8 @@ int smp_ata_check_ready_type(struct ata_link *link); int sas_discover_sata(struct domain_device *dev); int sas_ata_add_dev(struct domain_device *parent, struct ex_phy *phy, struct domain_device *child, int phy_id); + +extern const struct attribute_group sas_ata_sdev_attr_group; #else =20 static inline void sas_ata_disabled_notice(void) @@ -123,6 +125,10 @@ static inline int sas_ata_add_dev(struct domain_device= *parent, struct ex_phy *p sas_ata_disabled_notice(); return -ENODEV; } + +static const struct attribute_group sas_ata_sdev_attr_group =3D { + .attrs =3D NULL, +}; #endif =20 #endif /* _SAS_ATA_H_ */ --=20 2.44.0.278.ge034bb2e1d-goog From nobody Sat Feb 7 09:12:14 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69164DDA1 for ; Tue, 5 Mar 2024 00:51:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599876; cv=none; b=pztYBbtUqLx2CnYvbw9/cuPWbtM4JYCupRNBGvM2jxER1SzoBMV5iyIx1sr7A78rssUZhPKFJbzibCNSYTFoKZ7Cy9KAyAxguI2T7YAaDgZQcdHD/Th0CmS4n31NG96T2fM7JQLUAMqCFSE/Vs5U7S9Fco2KxkmrsI5vWlqtrgQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599876; c=relaxed/simple; bh=x2hilrY6KpOzbV02gq6hK1kGpEZfvE2peqVvFcuy54o=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=t/J+h16p74fpI3WuBh2JUHkRqyaRPFAxM7VaURqvAIKzmPGDijEWbWfleiW4ybIzrGzutfOuEFCRYwTnmRe5UdA2/rFNU0QfcmcFG4f5oEe4j11od8w8Q5xDLChu6dnI5Zvh23eQ7grxJhGNapqrXXvx27634pasO3c7csKHcJ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lpnhucVh; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lpnhucVh" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dc743cc50a6so6648020276.2 for ; Mon, 04 Mar 2024 16:51:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709599873; x=1710204673; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=lC7LnbzAeSHiH+Q2OB99L1Wy9pJ7fHavEqwaSfllwSM=; b=lpnhucVh3uqp+iAk90K17N6Xzme5PLZQYEG5LVyx5icpMABjqQFj3oJXv6kTd3O4h3 CfnGU/uWrbK/jwnuG3XvzXV2N/1rykgMXHJ3afE0BMnI3rA5n2+pXxW24ON4m8LtoZ3M bgyNOXpVIQbrkvy2HcEn8HLJOmK8J8ki3VAuOTUgbPfgz9klw0HQyrAzilzMUiABu9wD W4Ad1T2cYpkBXeqUoCQ+zCVMGJCUGA+mLHT/Kj3XNy+srgWJe1Zqg7u79wZdhV7JEJcU m4RmIdeeUUlSqjI5ZslZtXulkTKMnmb0uehL6DiryEeBQu/D1Igb7XWzTIip58jMGOdz vlWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709599873; x=1710204673; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lC7LnbzAeSHiH+Q2OB99L1Wy9pJ7fHavEqwaSfllwSM=; b=GTZGtM6ff++iESqaT5L3lVlp2Bh8fpHQ9OFi0Gwswl1byup3zKZUE91pTHeYPGo/uk qkAyuhXMk9doZgIGWkSn/JhJdZ5J/St+u/EXGixW5jAo7zO1SFHIrVxwUNa9LmKtlQM/ rmqIk77X9QMWwCz3/OJyfQ82FetAWeSadqvmLexdpDyRMAFfA5YQ7Da6QASWhOZ/nQK2 rIgTY6yFrNCsbTg7uJ/OwufETnd08ZQT5Vm0YThUpIQsdJ1LlUsF1aRp3k2tcah3UmmE QMVd4Bdg2FAA8w5kFQRpIRLgs7XPWGbzD4VqBoISapqTc5I/xJiml+9kwrHnHQFlYcNq Kidg== X-Forwarded-Encrypted: i=1; AJvYcCWd2nsoct/Fs1D4+lDyol1uUTzTZ/hI46KmIiCFkuorecTT+bUWNr+g38ZvwQAlvoZq0XujPZYuDnfVUIHKWoz0bDrSUOZafp2uVVsJ X-Gm-Message-State: AOJu0YzL6nrSp2BgFuhzggYLvzHlUF0qhMtgFsM+cf+u7F5v9Mj87KZL zSvDRC01Q6PmkGjvJlbF1+Xws5iyNeSgHVFB00Qi5TtnRRX5mvIeLTiczG9bOHJdT1SY4RQNlB3 0HYOv2pc9rQ== X-Google-Smtp-Source: AGHT+IHkvvrou4Sz7eyD4ve2xHQ0fzUP9Va/aVVoMDauBZqMVhzlZCI+ssSFGnQhQ9fD64bXbprrz0Tv/s/FQw== X-Received: from ipylypiv.svl.corp.google.com ([2620:15c:2c5:13:e901:e760:20cd:d870]) (user=ipylypiv job=sendgmr) by 2002:a25:e095:0:b0:dc6:4bf5:5a74 with SMTP id x143-20020a25e095000000b00dc64bf55a74mr406631ybg.11.1709599873516; Mon, 04 Mar 2024 16:51:13 -0800 (PST) Date: Mon, 4 Mar 2024 16:50:59 -0800 In-Reply-To: <20240305005103.1849325-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240305005103.1849325-1-ipylypiv@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240305005103.1849325-4-ipylypiv@google.com> Subject: [PATCH v5 3/7] scsi: pm80xx: Add libsas SATA sysfs attributes group From: Igor Pylypiv To: Damien Le Moal , Niklas Cassel , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke , Xiang Chen , Artur Paszkiewicz , Bart Van Assche Cc: TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv , Jack Wang Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Acked-by: Jack Wang Reviewed-by: John Garry Reviewed-by: Damien Le Moal Signed-off-by: Igor Pylypiv Reviewed-by: Jason Yan --- drivers/scsi/pm8001/pm8001_ctl.c | 5 +++++ drivers/scsi/pm8001/pm8001_init.c | 1 + drivers/scsi/pm8001/pm8001_sas.h | 1 + 3 files changed, 7 insertions(+) diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_= ctl.c index 5c26a13ffbd2..9ffe1a868d0f 100644 --- a/drivers/scsi/pm8001/pm8001_ctl.c +++ b/drivers/scsi/pm8001/pm8001_ctl.c @@ -1039,3 +1039,8 @@ const struct attribute_group *pm8001_host_groups[] = =3D { &pm8001_host_attr_group, NULL }; + +const struct attribute_group *pm8001_sdev_groups[] =3D { + &sas_ata_sdev_attr_group, + NULL +}; diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001= _init.c index ed6b7d954dda..e6b1108f6117 100644 --- a/drivers/scsi/pm8001/pm8001_init.c +++ b/drivers/scsi/pm8001/pm8001_init.c @@ -134,6 +134,7 @@ static const struct scsi_host_template pm8001_sht =3D { .compat_ioctl =3D sas_ioctl, #endif .shost_groups =3D pm8001_host_groups, + .sdev_groups =3D pm8001_sdev_groups, .track_queue_depth =3D 1, .cmd_per_lun =3D 32, .map_queues =3D pm8001_map_queues, diff --git a/drivers/scsi/pm8001/pm8001_sas.h b/drivers/scsi/pm8001/pm8001_= sas.h index 3ccb7371902f..ced6721380a8 100644 --- a/drivers/scsi/pm8001/pm8001_sas.h +++ b/drivers/scsi/pm8001/pm8001_sas.h @@ -717,6 +717,7 @@ int pm80xx_fatal_errors(struct pm8001_hba_info *pm8001_= ha); void pm8001_free_dev(struct pm8001_device *pm8001_dev); /* ctl shared API */ extern const struct attribute_group *pm8001_host_groups[]; +extern const struct attribute_group *pm8001_sdev_groups[]; =20 #define PM8001_INVALID_TAG ((u32)-1) =20 --=20 2.44.0.278.ge034bb2e1d-goog From nobody Sat Feb 7 09:12:14 2026 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A62C0FBFC for ; Tue, 5 Mar 2024 00:51:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599879; cv=none; b=Ee+gwz++Gji+b2veFBaivq6rvThrMFcABNTf+JD6fUS3ut/grsELJhc4RtTLt2Kg825hdRE7pOl80Arw2hM6HNudDJabrnxv1OvYO9pSJ+VUkbSd44sCT0rb7cl9Rw5aHpto7/Y5KSXn9BRJc8pt4VXYU8Nf3yuoHzh+q6HMas8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599879; c=relaxed/simple; bh=aLtlNr+1l6B3hxzUR9P9kYxIKT0n3xMBf3jWVQlgYvU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=uBwWz4zB6xLTKFdfa+WMeoK/bpFjBMY6secjcbcbdvCmjJErSfUwRiYBIG6OkyMml/t4w0GsjPffn4z/+NSMZk6PYKgCQxuIBcHGuj2vfnlprF3gDZFL1p5HID7yxd9y2VvfAmy9E9PTb+9WiCGQxAn8Jx7CDzU8SzPj52NDDSU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=oxGUfsj+; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="oxGUfsj+" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-608ab197437so79596257b3.1 for ; Mon, 04 Mar 2024 16:51:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709599876; x=1710204676; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=qnc29GOaNlgSeW09Vh8SN3Fp8isMCFvcbYSFbDWlfBM=; b=oxGUfsj+QYXgE92OqVw+J7XKAvJJxIWlBczs0LmObEqvHI6GaHZDaO23wfXpIZ6gVh 3w7hiAMtU2YEP5KVl/BmOS/Cf7AevdMlqD9estfdBJYOzlJu7PIDz+GP0VcxkVp6WWWf Bx0kNiisaeBo3bAFC6amsEvNfqu3T27E5ECbIPR9iDseoQmYhyg6UM84o7Vj9Mfk3PAb IAwXSWWe/LZ+YDeNOfI7viycluTff1IhK0UsBDq5eFAsM5GG2mMVik1z/+Z5W12nyLjX NSQMTQ236q36ld7Fb1s5lNQO9XxWkbb6DyK0kBxYCgnbumhT5eOEtKT1sQ+ExzSqte07 fh0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709599876; x=1710204676; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qnc29GOaNlgSeW09Vh8SN3Fp8isMCFvcbYSFbDWlfBM=; b=Aa6pPn4+u1YN1SGpBGeBJ8TNKX4YybIhGq62VeLnfpAZR85DNoqEo4Ov62Aw8Ktm1M A9PRiOwivXb3eQnp3CJ6BjMHCBfAjWj6pWYCXCRdc696IqcSeE8ptqmDHqQ66RVxBD/O AnPpjVX7+snGgscDxW8KC/A/Rb00tFBGV9BDSrwaZywTBCETnzLswDF4kv5ZJVAzSUuT tFz8DncEZAr21pgV+pO0UW9nxkWS+OZgYPe3/uqQLzg89pTn6BbVm4Ai3Y4kCU2g5Xwf WHbZJrRsozCHooPr6zFgmPLwN+c6qDUOSpgdZIQCi8E1KWiE9JTAGL/m9bKqAE6HeDjf oNVw== X-Forwarded-Encrypted: i=1; AJvYcCW/n1SrxSPcj/nqChxnrvfAiYmRMyP3Y4Rt21Nk6wfC+8sQ0StanraJET6Qvs2KIDJjMqLcRVP9fvr1tQeqpWWYGHYElrRR4213yAUw X-Gm-Message-State: AOJu0Yw4URM1sBt7jE/gpwKxrK3EjE26GaD6U4GqL3Nc97TkYolv16bL P9nl5SA29hGU8HdXl1Y4JcSud+mGZyQSRPQwTlTNODz/FD9TEnsX0hmMt0rB3xWx43IF5Lopxyj JkgrqIKRsWA== X-Google-Smtp-Source: AGHT+IGZSbdF2pSwc+4EzWStbZeghU2//j/2zWX2HQSKUA0vm+Yo3YKGSF39AsfdaP2nXqgALpckPtLnyivnaA== X-Received: from ipylypiv.svl.corp.google.com ([2620:15c:2c5:13:e901:e760:20cd:d870]) (user=ipylypiv job=sendgmr) by 2002:a05:690c:fcd:b0:609:33af:cca8 with SMTP id dg13-20020a05690c0fcd00b0060933afcca8mr3011166ywb.2.1709599875824; Mon, 04 Mar 2024 16:51:15 -0800 (PST) Date: Mon, 4 Mar 2024 16:51:00 -0800 In-Reply-To: <20240305005103.1849325-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240305005103.1849325-1-ipylypiv@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240305005103.1849325-5-ipylypiv@google.com> Subject: [PATCH v5 4/7] scsi: mvsas: Add libsas SATA sysfs attributes group From: Igor Pylypiv To: Damien Le Moal , Niklas Cassel , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke , Xiang Chen , Artur Paszkiewicz , Bart Van Assche Cc: TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Reviewed-by: John Garry Reviewed-by: Damien Le Moal Signed-off-by: Igor Pylypiv Reviewed-by: Jason Yan --- drivers/scsi/mvsas/mv_init.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c index 43ebb331e216..f1090bb5f2c9 100644 --- a/drivers/scsi/mvsas/mv_init.c +++ b/drivers/scsi/mvsas/mv_init.c @@ -26,6 +26,7 @@ static const struct mvs_chip_info mvs_chips[] =3D { }; =20 static const struct attribute_group *mvst_host_groups[]; +static const struct attribute_group *mvst_sdev_groups[]; =20 #define SOC_SAS_NUM 2 =20 @@ -53,6 +54,7 @@ static const struct scsi_host_template mvs_sht =3D { .compat_ioctl =3D sas_ioctl, #endif .shost_groups =3D mvst_host_groups, + .sdev_groups =3D mvst_sdev_groups, .track_queue_depth =3D 1, }; =20 @@ -779,6 +781,11 @@ static struct attribute *mvst_host_attrs[] =3D { =20 ATTRIBUTE_GROUPS(mvst_host); =20 +static const struct attribute_group *mvst_sdev_groups[] =3D { + &sas_ata_sdev_attr_group, + NULL +}; + module_init(mvs_init); module_exit(mvs_exit); =20 --=20 2.44.0.278.ge034bb2e1d-goog From nobody Sat Feb 7 09:12:14 2026 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A30DD10957 for ; Tue, 5 Mar 2024 00:51:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599880; cv=none; b=eEIYmKUKbnf9tDfwb+CW4p/vka265EqPKPCYgKf2Jhq3N9114we6fa7hgNgYpoYqz9VvlD1tavgsshQDlsFkDoUdjAibb76f9b4Y/Dcl0P4ZL4fD9s+ArnzrosNb/ga1R9ZYaXkHVHW602bqeEloFSFheF40MW5XChREbjYBmZE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599880; c=relaxed/simple; bh=OT0sYnaxo68fwSHaMwnL2hKn2Ef03StrkDYOYiAnOZA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=PtXnLG6Nd+yxDCXvh2dIRlh1+TSguGob/5Y5i+CDf2FYrB+sZAU/2vFpr2PhUumVxXmLXQnuUvT9tKWWvywabdwt1ztLJwWwAuMi4zynTtJRgqGrwzC64iqj5jZjTFGnbRpH7UYwyvoCkeJMVizZzGzYroyBK7Yxbu4Ta7bqmLs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=vuUL+kKM; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vuUL+kKM" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-608ac8c5781so89026077b3.3 for ; Mon, 04 Mar 2024 16:51:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709599878; x=1710204678; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=N68FGvP0mTMlTYCB47N23MbfsmIOzAcUrBUD9J/J0rI=; b=vuUL+kKMTWCSKu8wgxMV6bhdGgD8wgo13IAS+PYUzIbITKmHOppd5JNW5kNThf+sdg C/TOVUyNKdlAk18BWqkAn3iqvEhDvl/Ci49nTLVRP2amLLxTs1qrTExflTQLLbF0t/g0 Zh20E8MzIx5BBgpTxvmDvVnzIxESJuh8y0enycwR7CHc5737aMBrcQc5Bi5BlH2n2WY2 GDzkTdCh/yaUTdPIr1mWnDixY/+WkhFakvhJlUByJY7Eq6LHJDCpewvR9xv1JvQC3Ve7 lt4qLjdxkxbtrWD3Sy9y+ZGMLoz2bJw1yGg6rHldyxkzVjDsYi2u0/yzLK3jV2xgO+6j Au2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709599878; x=1710204678; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N68FGvP0mTMlTYCB47N23MbfsmIOzAcUrBUD9J/J0rI=; b=KStROuXjHcdXDuTHlxelw8CsWM78PWp0cfmFoENQBCp685SfjZ8cBxinNlp/y6VERW fRTv20dGuJiRvIdAvBHG5+wIvfFKEL1ZjbwQUyVs9yfpB0oQbpDXlccbpiNhsnvy/efl he4cODCYqYBgrr6DL4H7IkiMp0vk+FaFk+/nji4JHA71JruBKD0UKJQJUeUttNDuHp/P RMN/WUOafu7xqYFO0WvSyGo1VcYqwqKXkAOhthFlAO6ilBOJnLnDnB3kN/aPMjSQ8WKl ardG95AgTmtJ6bCx6wSY9py2JriRyQ7DyoEfrQvcg8OrFbW8Yvyiu8nrfUYERaks3Nk/ Yb9Q== X-Forwarded-Encrypted: i=1; AJvYcCX6K26Ye2sWjpe3kdKyvsHWoCglFo3vtT/S9b1NfL+iz9Y0VyKCR540uvY2MPPtgcTc5FJiFmzPWwH0GXh0ATsKtIvBvjX92HMjHuql X-Gm-Message-State: AOJu0Yw6aG/ulyG+YbzzatjW8XUm7Bx76eS6FYZOsbio0CMYwSfKkM+m NDGd7qXejLHaYJkc+cROfztJmtSJBm0pRiegaOQPQLLe7MVWRHI7QdlgtKVCbSRALSAS57rzwbp 19vNoesLUHg== X-Google-Smtp-Source: AGHT+IEifz6iQ1XIfSyfq986HxT9PrXO9y0tP1HA/K2Izo+X7mbBAMA6q5VgAVEkRE6I0se5mkm5O2wOX543Lg== X-Received: from ipylypiv.svl.corp.google.com ([2620:15c:2c5:13:e901:e760:20cd:d870]) (user=ipylypiv job=sendgmr) by 2002:a05:6902:1004:b0:dc2:3441:897f with SMTP id w4-20020a056902100400b00dc23441897fmr2682137ybt.6.1709599877900; Mon, 04 Mar 2024 16:51:17 -0800 (PST) Date: Mon, 4 Mar 2024 16:51:01 -0800 In-Reply-To: <20240305005103.1849325-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240305005103.1849325-1-ipylypiv@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240305005103.1849325-6-ipylypiv@google.com> Subject: [PATCH v5 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes group From: Igor Pylypiv To: Damien Le Moal , Niklas Cassel , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke , Xiang Chen , Artur Paszkiewicz , Bart Van Assche Cc: TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Reviewed-by: John Garry Reviewed-by: Damien Le Moal Signed-off-by: Igor Pylypiv Reviewed-by: Jason Yan --- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ++++++ drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas= /hisi_sas_v2_hw.c index 73b378837da7..b5d379ebe05d 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c @@ -3544,6 +3544,11 @@ static struct attribute *host_v2_hw_attrs[] =3D { =20 ATTRIBUTE_GROUPS(host_v2_hw); =20 +static const struct attribute_group *sdev_groups_v2_hw[] =3D { + &sas_ata_sdev_attr_group, + NULL +}; + static void map_queues_v2_hw(struct Scsi_Host *shost) { struct hisi_hba *hisi_hba =3D shost_priv(shost); @@ -3585,6 +3590,7 @@ static const struct scsi_host_template sht_v2_hw =3D { .compat_ioctl =3D sas_ioctl, #endif .shost_groups =3D host_v2_hw_groups, + .sdev_groups =3D sdev_groups_v2_hw, .host_reset =3D hisi_sas_host_reset, .map_queues =3D map_queues_v2_hw, .host_tagset =3D 1, diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas= /hisi_sas_v3_hw.c index b56fbc61a15a..9b69ea16a1e6 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c @@ -2929,6 +2929,11 @@ static struct attribute *host_v3_hw_attrs[] =3D { =20 ATTRIBUTE_GROUPS(host_v3_hw); =20 +static const struct attribute_group *sdev_groups_v3_hw[] =3D { + &sas_ata_sdev_attr_group, + NULL +}; + #define HISI_SAS_DEBUGFS_REG(x) {#x, x} =20 struct hisi_sas_debugfs_reg_lu { @@ -3340,6 +3345,7 @@ static const struct scsi_host_template sht_v3_hw =3D { .compat_ioctl =3D sas_ioctl, #endif .shost_groups =3D host_v3_hw_groups, + .sdev_groups =3D sdev_groups_v3_hw, .tag_alloc_policy =3D BLK_TAG_ALLOC_RR, .host_reset =3D hisi_sas_host_reset, .host_tagset =3D 1, --=20 2.44.0.278.ge034bb2e1d-goog From nobody Sat Feb 7 09:12:14 2026 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E328F12B6C for ; Tue, 5 Mar 2024 00:51:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599883; cv=none; b=a0xbpc4a/z2bRSa8zeyW1QJbx9Ff50HYZJfbMYGgjnxrAk1TWHk4ev7K3wy+izyq54SBz94JAK2BgwQKdsay2KgLqFs3cdndZpE4foksCC70QlKq94tQvyue536CpNZ5uIw6KnQuyLw/HmSfhglckZHRWL1tO7yq5RRe6T/2M4E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599883; c=relaxed/simple; bh=l1B7DL+QxZKXAInqPgoxYQhQfMm3hZjNqcIgYcFRiA0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=eXmnBzpGzhkFCc/rH32QuMxWpo4H8Qz+uo71iuA2L9Ub6zC4xiPfBYwwEf3/HkBWJ2fPBuGw0ohI2mFwjC/16JfNGhlMFIDNYlyMJYENVn1vkSHESfd9ylsDlNnlXLAF+nBJ+Aq6zw+jqUzT7RDhxPQvps0IUH86bgLo9+3ax7o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ln1VZLKu; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ln1VZLKu" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-60987370f06so39918687b3.1 for ; Mon, 04 Mar 2024 16:51:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709599880; x=1710204680; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=/rSrKaEP0cu2EEhDxf63kSlEB7iQAh36Fr8Ir9gTxu4=; b=ln1VZLKu5+RmXA1sFmdN5RLOFSeHEvBQQuxNFPSMvRvaOrd0Pk4eLH082LtqedwjXJ 9H91dKjKnun1LO9vq57Xkr5j2VjJ07C5pkiDWieMvRYt3lBhAv0hNJNffY6yz+ZLgTai DNWjUluuL5AsxpqwO9IpLg6FSsLdr+ynR1DwGcEN4K0subUdDnBM9TrlquJrFNxzOkI9 rprR0cVzZDWvUbVmh1HVE1Ng2o0sSOJE4YSh1HJI0CjudrtbVI6qcqA+Ee5eKy8Mx2Q5 shdvR3IMqByi9uCkYIZ8zqPq3lf8zeQQ7r+h58i8DYbCsk35g39fmSTJsCyyfPXTkxBf /BLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709599880; x=1710204680; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/rSrKaEP0cu2EEhDxf63kSlEB7iQAh36Fr8Ir9gTxu4=; b=tYhq1h4GvZBI7rDX5a22ZWEgE8WUgIO2OPgwTPzs8b5UzfRcvl5cO7Qm7TlWY1gQ4f d9Uozg77b0FLsRidgMWxq9szRu9li1Y2Zq9wn44jXiGXOqoep2DqwKXIOo4EAnkwNIat l+9cKYF6+k2BvPPXNYNeaGalyhi0/3GHpg2T2xUFY8+kiFpS0sLOBwLOfQC1qxxltQ0u W/35KnjKo4CXFHb9dEiFZKmYpF2ctd6thrO7T8lWHAIILnpnkcP5YkfNH+azi/0cX2HH 2N959j0Onz2iHLQbT0vGlcgEjArMffEcBkEahX8aJJmasp+cESQpWUPgXZHH5aCGRRfl NmAw== X-Forwarded-Encrypted: i=1; AJvYcCVwP72M9P2QaQTj1Je+7r61CBKt+gjAFeMTRy9wH1ORIrUhZgyrPhMXFmnPiGedA42rpXwumMLjpvR6FVZg2xZt3MpSHXy2LWV0TCI2 X-Gm-Message-State: AOJu0YzBwsEKkhV8oGr/3ATYa+ca7zYkove6+Xiz11W7tuPkJXSji5B8 BXXjrbZTtuB4KR6uPSXxLmLb0mjney6ASYMMWmgzWsuhxYFkyPlaj+nAOrZdT4LkBlRNVy7HmFZ YysgpEkHUJQ== X-Google-Smtp-Source: AGHT+IH0taBqeMsbYKpUMKAKLG8w3t/pn1bQnH1/UJUTTJL6q6kvljHPQbPcYP7rtlwNxzaYSsc13QQM44B3KA== X-Received: from ipylypiv.svl.corp.google.com ([2620:15c:2c5:13:e901:e760:20cd:d870]) (user=ipylypiv job=sendgmr) by 2002:a81:9a05:0:b0:608:2ad5:cd28 with SMTP id r5-20020a819a05000000b006082ad5cd28mr2227317ywg.4.1709599880122; Mon, 04 Mar 2024 16:51:20 -0800 (PST) Date: Mon, 4 Mar 2024 16:51:02 -0800 In-Reply-To: <20240305005103.1849325-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240305005103.1849325-1-ipylypiv@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240305005103.1849325-7-ipylypiv@google.com> Subject: [PATCH v5 6/7] scsi: aic94xx: Add libsas SATA sysfs attributes group From: Igor Pylypiv To: Damien Le Moal , Niklas Cassel , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke , Xiang Chen , Artur Paszkiewicz , Bart Van Assche Cc: TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Reviewed-by: John Garry Reviewed-by: Damien Le Moal Signed-off-by: Igor Pylypiv Reviewed-by: Jason Yan --- drivers/scsi/aic94xx/aic94xx_init.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic= 94xx_init.c index 8a3340d8d7ad..ccccd0eb6275 100644 --- a/drivers/scsi/aic94xx/aic94xx_init.c +++ b/drivers/scsi/aic94xx/aic94xx_init.c @@ -14,6 +14,7 @@ #include #include =20 +#include #include =20 #include "aic94xx.h" @@ -34,6 +35,7 @@ MODULE_PARM_DESC(use_msi, "\n" static struct scsi_transport_template *aic94xx_transport_template; static int asd_scan_finished(struct Scsi_Host *, unsigned long); static void asd_scan_start(struct Scsi_Host *); +static const struct attribute_group *asd_sdev_groups[]; =20 static const struct scsi_host_template aic94xx_sht =3D { .module =3D THIS_MODULE, @@ -60,6 +62,7 @@ static const struct scsi_host_template aic94xx_sht =3D { .compat_ioctl =3D sas_ioctl, #endif .track_queue_depth =3D 1, + .sdev_groups =3D asd_sdev_groups, }; =20 static int asd_map_memio(struct asd_ha_struct *asd_ha) @@ -951,6 +954,11 @@ static void asd_remove_driver_attrs(struct device_driv= er *driver) driver_remove_file(driver, &driver_attr_version); } =20 +static const struct attribute_group *asd_sdev_groups[] =3D { + &sas_ata_sdev_attr_group, + NULL +}; + static struct sas_domain_function_template aic94xx_transport_functions =3D= { .lldd_dev_found =3D asd_dev_found, .lldd_dev_gone =3D asd_dev_gone, --=20 2.44.0.278.ge034bb2e1d-goog From nobody Sat Feb 7 09:12:14 2026 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45E098F55 for ; Tue, 5 Mar 2024 00:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599884; cv=none; b=pcs6fF9g+SvJ2f04M5Ov6Qv2OBsOO99oL3qYCkGzedzRv54463RPf/9cZZyYFL1/14tzQVbKCXjXJOj1lxC21AkLdQtWAh8mdeQhjTfjIbrt4huInNfDJWweno9WlQKxjeZHWJWFDFaI5MYBMf6W08CmloA5Yw+4WBt/lNsuZYs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599884; c=relaxed/simple; bh=JK5ZL4PnU5QeI+1YMzB3uaBk//5D5vcBBN1SI7nMnwU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=cVeqiuY5/zVT9nubPLDmN75E4r+gkiR1DDbUN0uZugvbOdqDLjqHx7cHfV9Z6RhBp3rOL0EBhaRwPmgaQSih7MVUhGWcWRSUGJxN6S9Nev+4cRSVxz88P96GTdMFCB57Uy/sFAqz9VEIOGGfW6HPItfr1Y+ZaLQfptr6WNWXyf4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=zGTq+ph1; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="zGTq+ph1" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-607e613a1baso89859967b3.1 for ; Mon, 04 Mar 2024 16:51:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709599882; x=1710204682; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=uY5VRSDJS+IotGAZM4PBm3CjluNBdRiBTTCOlg+57LQ=; b=zGTq+ph1Gt70cMez1/KmQsCju6MOn1yHDUKz8BGOzj8khX4msGBh50eXZTILZoQggV zNzK8E0InmCpWO1aodtcdShw2yyxFs8zuUCTOHuaCe7TPdTz4UcQ8Ne//PEqeS/ZFvmU /r4gQIpgdnK3ooK+gyRibZ10mRWtX2DMs0U1i9ALw3D4Wgh6n27Sdtq193dLc0gaepCF 2yzPFl7O5jn3RvZ7Ki0LAI2uvovNcfBc8RALvq/TZqUzPXYR3dEYS4cnv45MpuMNocbC gLsp/Fa5YlMx5vnXamD6HO/GHCz0dppimHbdYcIgLuP8muVILGcyuDMLvWy2iWPdEZWS clAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709599882; x=1710204682; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uY5VRSDJS+IotGAZM4PBm3CjluNBdRiBTTCOlg+57LQ=; b=GgUyN4wV09Tollrk6P93t/pGEVeDDEmUGxJAry0nmpPbzJUN//tcbr46LqgQTLQBLw 9oDeN2Ejrw9BIJvLobZreNECiUeBtBBZT221Mlz0j1AtWm3THHVmeGGxTTnbZXsmcP/I t02VdUGO0Ig5F+0GEa7banKrLYZedM1X/Q1ivvgPeDFF4kCU/g0JRYQ2EAaG5i2JYdlh ck970zYKW+gyJ8TH6FfNNaPg0o2VPYsTYGoHi22SRn2DFId9tDr0rF0+Zs5PbiiOG29S MKk8upA+XuKBOGUNAbVr0GQXp1Ng+31oS3cCNEpMO9ZOsmlHw3vRYwXHz6Vr990TCOUI uIeQ== X-Forwarded-Encrypted: i=1; AJvYcCVOWICZ5JPrpichnIBX/uKcJ1hLSxN8N+C8N4KMN/bfPzCL17QQFmujfZ8boN+S6s6t3JKEyp4qiHDCx6j/waqU4b/KUscZm+0VriZz X-Gm-Message-State: AOJu0YwIfZYm0lpHyFt1KI0grI8skCzUtT2mxEOzKDZHZof04aNpOk/Q N+Y2QsAq4ls5GJRpyznaR176zkvc0GOHe1706j95BgusRErmkF8mWAv7YtSiG8sD05Aidi5H9J1 iVVapFwhqFw== X-Google-Smtp-Source: AGHT+IFlhgHHWVA1TkUHFLU46HuPh9Pm+a647sbF3wlljbxMV51Ln2wZuV9e2Yf7mOeLRXIgQSgT+g4jkbhtQA== X-Received: from ipylypiv.svl.corp.google.com ([2620:15c:2c5:13:e901:e760:20cd:d870]) (user=ipylypiv job=sendgmr) by 2002:a05:6902:1885:b0:dc6:207e:e8b1 with SMTP id cj5-20020a056902188500b00dc6207ee8b1mr2710413ybb.2.1709599882317; Mon, 04 Mar 2024 16:51:22 -0800 (PST) Date: Mon, 4 Mar 2024 16:51:03 -0800 In-Reply-To: <20240305005103.1849325-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240305005103.1849325-1-ipylypiv@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240305005103.1849325-8-ipylypiv@google.com> Subject: [PATCH v5 7/7] scsi: isci: Add libsas SATA sysfs attributes group From: Igor Pylypiv To: Damien Le Moal , Niklas Cassel , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke , Xiang Chen , Artur Paszkiewicz , Bart Van Assche Cc: TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Reviewed-by: John Garry Reviewed-by: Damien Le Moal Signed-off-by: Igor Pylypiv Reviewed-by: Jason Yan --- drivers/scsi/isci/init.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c index 6277162a028b..8658dcd61b87 100644 --- a/drivers/scsi/isci/init.c +++ b/drivers/scsi/isci/init.c @@ -149,6 +149,11 @@ static struct attribute *isci_host_attrs[] =3D { =20 ATTRIBUTE_GROUPS(isci_host); =20 +static const struct attribute_group *isci_sdev_groups[] =3D { + &sas_ata_sdev_attr_group, + NULL +}; + static const struct scsi_host_template isci_sht =3D { =20 .module =3D THIS_MODULE, @@ -176,6 +181,7 @@ static const struct scsi_host_template isci_sht =3D { .compat_ioctl =3D sas_ioctl, #endif .shost_groups =3D isci_host_groups, + .sdev_groups =3D isci_sdev_groups, .track_queue_depth =3D 1, }; =20 --=20 2.44.0.278.ge034bb2e1d-goog