From nobody Fri Dec 19 21:46:40 2025 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0726D8F5B for ; Tue, 5 Mar 2024 22:22:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709677323; cv=none; b=SVYMklj+ZdQRVPiHlL07C7DzxFsCmapAe/KEIAcVQ9jXzW+DQjHkCCebUdw3Q69RI+xbUZ4YVM0hBnHmfxhOKY5ftYzFcBjOvLsuPdbDPnEXEXIeovhsaf3KGngJfWlOdtk3Iqih9fhh5UsMV0/xEDAUxOL16qizKZ5PGmhLOz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709677323; c=relaxed/simple; bh=y1/vGn2yIX/dLhzLAE0Ukdc4XMhIZMZnvnOhZTS8K80=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NU3LAFssIyxhrpU8JfxJc8+ym1y0L0jv713zcxa5XwTJynmuQ2TBQd0UD9Cg/a8d8ZexcnQpUUqrk0H1POy0bbXtZchB+audJG93LnnPRnkTX9ZLOl8iitycgKapdd6PP6r3ANUIyGpn6NViwjcmHYzmE1gUhUZBZdtet9AlLBo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=dwLCmJGq; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="dwLCmJGq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709677320; bh=y1/vGn2yIX/dLhzLAE0Ukdc4XMhIZMZnvnOhZTS8K80=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=dwLCmJGqky+gKuTBc5IimZaDkvq5zh4OcaQCf9tQUsDNFAhhdQv4WQgXxEdHadiNZ 7/ZiGIFTyZ4oC9Htphq3Wb+nOg4LiseJ85kusRxliOyOI9/mz/Pnyqqfl7otiSr2nI 3GstyPzmOEWoAJo1EMK74+ABASBfZnE82bnQKntfk3Ox0vuj962p8IWVZbTwfKrbnv NOrQ0U6JsYKPVahMAEcSYPVZ8sldvpuozyYa9go0W79u37nTFTPVNP4jl8l/hWxYmD SAolCGErVwlexMvRi/dSx+OJJmQrEDu72G6CskXfMqpxJNr6Y696iv4DBBxzEGKbVh gUDLlD5X4p+Pw== Received: from [192.168.1.241] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 17AB23782066; Tue, 5 Mar 2024 22:21:58 +0000 (UTC) From: =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= Date: Tue, 05 Mar 2024 17:21:36 -0500 Subject: [PATCH 1/3] driver: core: Log probe failure as error and with device metadata Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240305-device-probe-error-v1-1-a06d8722bf19@collabora.com> References: <20240305-device-probe-error-v1-0-a06d8722bf19@collabora.com> In-Reply-To: <20240305-device-probe-error-v1-0-a06d8722bf19@collabora.com> To: Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= X-Mailer: b4 0.13.0 Drivers can return -ENODEV or -ENXIO from their probe to reject a device match, and return -EPROBE_DEFER if probe should be retried. Any other error code is not expected during normal behavior and indicates an issue occurred, so it should be logged at the error level. Also make use of the device variant, dev_err(), so that the device metadata is attached to the log message. Signed-off-by: N=C3=ADcolas F. R. A. Prado --- drivers/base/dd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 85152537dbf1..0b7cf4516796 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -592,8 +592,8 @@ static int call_driver_probe(struct device *dev, struct= device_driver *drv) break; default: /* driver matched but the probe failed */ - pr_warn("%s: probe of %s failed with error %d\n", - drv->name, dev_name(dev), ret); + dev_err(dev, "probe with driver %s failed with error %d\n", + drv->name, ret); break; } =20 --=20 2.44.0 From nobody Fri Dec 19 21:46:40 2025 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E74F12D201 for ; Tue, 5 Mar 2024 22:22:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709677325; cv=none; b=AzNRRXjmiBbr56eepf+WcVOmsFlU0z+2AAiGgSyvyho+buDOs9yd0dLCkVMB6FBdLwGO0boML3ORRhrnqobRDxqsbiKn9P4oKaeM1DqrJ440WnbWAeYTdZxIomGJd7Cp1JpbdBhn/tJe2yCOvC9EoEz8138AqNQCaMuC0xCinrw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709677325; c=relaxed/simple; bh=DRDImxWl8vn15NlvIm9eIMlnD+dji8ldOjVhWtbbgSQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ovx7Hpr+VdbPDBAZXyhg08559MHKsqEB00pDcmXap1U6fYB2UqlGKe/aBa5zkuyOLwyUp+/sHwcvMtn6hmh8CktU8MbOgaYdX5aXGQwT0hg/UTPQllK4FBEn+EH9hS49K/x0EKUrEqJhNs+rbSLNaWJERxDvSDqSABvs9UKfD8A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=JLnwv52E; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="JLnwv52E" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709677321; bh=DRDImxWl8vn15NlvIm9eIMlnD+dji8ldOjVhWtbbgSQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=JLnwv52E58pFQiAQQYV3pIwlCdxHeWne9Vmxa8yhIQFo6RR7b6qDKT15NuW2monqX 7WUJEh8+3bwiWRDZ9438U0vbcvv+htFCBNyv9GbGUAU54CIUtXyAPyWAlP6cDAapGj BCkTEkr2JRWSpl3xMWe/vRdUIC6NlHoiYca+DeQgFELBur54n1/gpSHnTDAO3JTcGs Cc5auHRH4USZgFzAiW5J3G0EGNXgQCpO0SD0kaYkxReW4YYAPsL6s96UNIqF/cakNH vVV5oMAfbX8caDIEks42CW6oW408pGPaxNe+MuD5FqZWdTTNNknLI9Ks/DZ1FJNcgF EAeU1IJKCDmHA== Received: from [192.168.1.241] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id A769D3782089; Tue, 5 Mar 2024 22:22:00 +0000 (UTC) From: =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= Date: Tue, 05 Mar 2024 17:21:37 -0500 Subject: [PATCH 2/3] driver: core: Use dev_* instead of pr_* so device metadata is added Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240305-device-probe-error-v1-2-a06d8722bf19@collabora.com> References: <20240305-device-probe-error-v1-0-a06d8722bf19@collabora.com> In-Reply-To: <20240305-device-probe-error-v1-0-a06d8722bf19@collabora.com> To: Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= X-Mailer: b4 0.13.0 Use the dev_* instead of the pr_* functions to log the status of device probe so that the log message gets the device metadata attached to it. Signed-off-by: N=C3=ADcolas F. R. A. Prado --- drivers/base/dd.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 0b7cf4516796..d6e7933e2521 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -397,13 +397,12 @@ bool device_is_bound(struct device *dev) static void driver_bound(struct device *dev) { if (device_is_bound(dev)) { - pr_warn("%s: device %s already bound\n", - __func__, kobject_name(&dev->kobj)); + dev_warn(dev, "%s: device already bound\n", __func__); return; } =20 - pr_debug("driver: '%s': %s: bound to device '%s'\n", dev->driver->name, - __func__, dev_name(dev)); + dev_dbg(dev, "driver: '%s': %s: bound to device\n", dev->driver->name, + __func__); =20 klist_add_tail(&dev->p->knode_driver, &dev->driver->p->klist_devices); device_links_driver_bound(dev); @@ -587,8 +586,8 @@ static int call_driver_probe(struct device *dev, struct= device_driver *drv) break; case -ENODEV: case -ENXIO: - pr_debug("%s: probe of %s rejects match %d\n", - drv->name, dev_name(dev), ret); + dev_dbg(dev, "probe with driver %s rejects match %d\n", + drv->name, ret); break; default: /* driver matched but the probe failed */ @@ -620,8 +619,8 @@ static int really_probe(struct device *dev, struct devi= ce_driver *drv) if (link_ret =3D=3D -EPROBE_DEFER) return link_ret; =20 - pr_debug("bus: '%s': %s: probing driver %s with device %s\n", - drv->bus->name, __func__, drv->name, dev_name(dev)); + dev_dbg(dev, "bus: '%s': %s: probing driver %s with device\n", + drv->bus->name, __func__, drv->name); if (!list_empty(&dev->devres_head)) { dev_crit(dev, "Resources present before probing\n"); ret =3D -EBUSY; @@ -644,8 +643,7 @@ static int really_probe(struct device *dev, struct devi= ce_driver *drv) =20 ret =3D driver_sysfs_add(dev); if (ret) { - pr_err("%s: driver_sysfs_add(%s) failed\n", - __func__, dev_name(dev)); + dev_err(dev, "%s: driver_sysfs_add failed\n", __func__); goto sysfs_failed; } =20 @@ -706,8 +704,8 @@ static int really_probe(struct device *dev, struct devi= ce_driver *drv) dev->pm_domain->sync(dev); =20 driver_bound(dev); - pr_debug("bus: '%s': %s: bound device %s to driver %s\n", - drv->bus->name, __func__, dev_name(dev), drv->name); + dev_dbg(dev, "bus: '%s': %s: bound device to driver %s\n", + drv->bus->name, __func__, drv->name); goto done; =20 dev_sysfs_state_synced_failed: @@ -786,8 +784,8 @@ static int __driver_probe_device(struct device_driver *= drv, struct device *dev) return -EBUSY; =20 dev->can_match =3D true; - pr_debug("bus: '%s': %s: matched device %s with driver %s\n", - drv->bus->name, __func__, dev_name(dev), drv->name); + dev_dbg(dev, "bus: '%s': %s: matched device with driver %s\n", + drv->bus->name, __func__, drv->name); =20 pm_runtime_get_suppliers(dev); if (dev->parent) --=20 2.44.0 From nobody Fri Dec 19 21:46:40 2025 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDCA712D21C for ; Tue, 5 Mar 2024 22:22:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709677326; cv=none; b=lMoEwYhhRAFmizzufNm5qw1VWFP976hKxt1QId7cqt3ZBj8Ffv7UFOFSHOdnmBgfAXIQoFsxxEj+erb5RgeS8TJWgwm8H8bWzMF1N0Rc5AbVatREhvv2FURFsJpy/TuB4D6GrLjbLbA+psn6LyLWSwHbelrwxg0Vw/E2FvQ9sQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709677326; c=relaxed/simple; bh=ueJ7QuGdrFeDy9rt+nAOirnh5rRQTBpmmXZN2CyaBvo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rVMcI5Nn39eqoyHWeYrSESCb87pc5N19EaJc4+isHwN6eTjrXfQnRCLIYxxfCSa1M1KrMxTDzg+S5VahR/ur04Mzcff6SFpyxffEUbPU/fy2c6ozQwvLq4+ucjlRTC8SZLCcOlbBXxe7BrqnDv76OFRUyCcS+6nqrVyLTCeeYB4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=gnupJWDc; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="gnupJWDc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709677323; bh=ueJ7QuGdrFeDy9rt+nAOirnh5rRQTBpmmXZN2CyaBvo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=gnupJWDcNFoB36925/ihi/i+LnyCE75fEmpr1Sakh3nLN4R6/mQzcdiCmlYeyrkFz Y7foQZut5Xhz9fByaqxguV8w0ZkMM7zmmWz0RTcYbqQ5ERsFC2o3cEO5C4f7cMQa4T LlR747HjtiY41JP0C50pKaeeSUrufQynfTwcm0TGi7QWpJPrlbtMYqMIaNwElK33Oe SF42KdOm8PmeLgVGIsaJhOL5bz6JKoKVKkarT43h06OPU7MXb/t3RvVJGTnS+PAmip mKMCsLhmeeLQiW19zvkVOn7V8iAM7G3wtwljKG2cLVlS8kc2KNBAztvEVD/gwtI/LE 57ubmy3VmKxDg== Received: from [192.168.1.241] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 427413781FCE; Tue, 5 Mar 2024 22:22:02 +0000 (UTC) From: =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= Date: Tue, 05 Mar 2024 17:21:38 -0500 Subject: [PATCH 3/3] device: core: Log warning for devices pending deferred probe on timeout Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240305-device-probe-error-v1-3-a06d8722bf19@collabora.com> References: <20240305-device-probe-error-v1-0-a06d8722bf19@collabora.com> In-Reply-To: <20240305-device-probe-error-v1-0-a06d8722bf19@collabora.com> To: Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= X-Mailer: b4 0.13.0 Once the deferred probe timeout has elapsed it is very likely that the devices that are still deferring probe won't ever be probed. Therefore log the defer probe pending reason at the warning level instead to bring attention to the issue. Signed-off-by: N=C3=ADcolas F. R. A. Prado --- drivers/base/dd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index d6e7933e2521..83d352394fdf 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -313,7 +313,7 @@ static void deferred_probe_timeout_work_func(struct wor= k_struct *work) =20 mutex_lock(&deferred_probe_mutex); list_for_each_entry(p, &deferred_probe_pending_list, deferred_probe) - dev_info(p->device, "deferred probe pending: %s", p->deferred_probe_reas= on ?: "(reason unknown)\n"); + dev_warn(p->device, "deferred probe pending: %s", p->deferred_probe_reas= on ?: "(reason unknown)\n"); mutex_unlock(&deferred_probe_mutex); =20 fw_devlink_probing_done(); --=20 2.44.0