From nobody Sun Feb 8 10:35:00 2026 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 212457EF0B for ; Tue, 5 Mar 2024 08:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709626338; cv=none; b=WcnQ4Cv07DAy5hS+jN+RAMTZNUB2aMel9O+aREsQkEy3kvVk5nwZlPVyXPG+vl2UL5DEZHbVzWLDeBotl7SFxQ4hGyet5LahLuGYJp2ZI00ie0BHOhDuVekYX/IvFhmGPokweCFPje6GASi4lBKg0NJmIPgpjxUwndy0B1otlGw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709626338; c=relaxed/simple; bh=opt8++1g0VChwtIB/Fz1GiYx24pMTFMe80pujvPzm0s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=asb0zWPmaSqseakPSyoNW5JQgP1+cPxh96LID0Ph98mmQvVfvcK6zZjCwv/0l6V7wTD2QGwwvL88RoxP3eEK3WSB7Aa5373A/OkhdPCIQvf1XzG1xiupwwy71pbqFnAKZr4m5nU15uRuAaMkgLjXnK0XzZQYAmdoC6ezQKcRDIY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mMSoDi4B; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mMSoDi4B" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a45aa7cb2b3so32298066b.3 for ; Tue, 05 Mar 2024 00:12:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709626335; x=1710231135; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qZhcPKgdyjL8bhk28jJde1fP1o5dZ8nODM9Ogpw/oLw=; b=mMSoDi4B0ScoqRdIq65JbZqWxhBN2tGRGDPmnZFCLZcMnk1dGHvUpdXTKK23eQS1rz 14hBX01gsecwrSo9qQY34bm5BEPuGzI+7yAF6/ZzsCpkJcQn4FuFXGIxGX/crNeULE9D wOpplKJ6hPI3swtCqMVb7Upxwyo340RSIoVKQHaEj01izNvgQ4vv6hQU+JsQjQR7yw4a Ep6Nr9IV6oxcZc0uYWIPJjmbtnnhtsi/CosKkJp5xzAOpLW2MlEmnCddwFzeEry0YvdI Gel5BHDTg/VyIY2rkqgfpdUm/QI5IIesm3X7NphtJN3wKSukxbsQ7ril6MDuRBpoxKys b4xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709626335; x=1710231135; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qZhcPKgdyjL8bhk28jJde1fP1o5dZ8nODM9Ogpw/oLw=; b=aTq9RHZbxWUF4Vg906kWEVgnyOO8pWKeYEQAlQd6f1voFoPOy/wxgN0q/5l9BOGfBw PC6c5PoIVV35fio6Fy2VAgNJ6qYxwMZDYsYMTYJsQdbSamFr96L2TvdG/z0iCGSDx5SX 0vAxYcZgG20rv0gxGBzxwruxIsf3k5I3EBps+U8Y/yo2cU97NUJpQ4B7VMGxnzQto+y+ 6/OEgEbEtjH6KH44HCtzke2nPTtfp4rpDmmQQkCTlSQ0M00OkdosXihCrYpD4eeSGsic zbfUQPlKP8Rg9h4lHyP+Tb2sgjy3i1ugXdtylQGAgccMVyClHmQKNRIthNdr8cqQAg8a YgXw== X-Forwarded-Encrypted: i=1; AJvYcCVy5VfrP7k9DYqh8L7CIyc8C5kDVlK3cE3aWnd69f5e91CVFuSQKGHmwabXcc3lLt2krJMKTwx1QLCNCeWJOqTzI90GmqplTMiTyO2f X-Gm-Message-State: AOJu0YxtaV47Ce43tEgp56aqthEh8OvmZ9z8rOEtsBVgZccR26PbKsU+ tNf0YzqIqR9XXTZKCUPoF94hfc2Dzf1pL1Q7mVyfwCRcZhDE4Dx4C3fy8/lWTOs= X-Google-Smtp-Source: AGHT+IEuX6cKf625yCSFdJGJles12Fo1Zc/Eyc8YTMuYE42QgS4ym9vrzIj3xWMG/qe66D6f3pwLmg== X-Received: by 2002:a17:906:cc93:b0:a43:e46b:7a80 with SMTP id oq19-20020a170906cc9300b00a43e46b7a80mr7105432ejb.43.1709626335333; Tue, 05 Mar 2024 00:12:15 -0800 (PST) Received: from [127.0.1.1] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id cq16-20020a056402221000b005672a346a8fsm2761557edb.57.2024.03.05.00.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 00:12:14 -0800 (PST) From: Krzysztof Kozlowski Date: Tue, 05 Mar 2024 09:11:56 +0100 Subject: [PATCH v2 1/7] backlight: gpio: Simplify with dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240305-backlight-probe-v2-1-609b0cf24bde@linaro.org> References: <20240305-backlight-probe-v2-0-609b0cf24bde@linaro.org> In-Reply-To: <20240305-backlight-probe-v2-0-609b0cf24bde@linaro.org> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1168; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=opt8++1g0VChwtIB/Fz1GiYx24pMTFMe80pujvPzm0s=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBl5tPWa6sw7b/TOSWZwZZYFLYG0BNvTG0TlbZoC 8bMfcQFWxqJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZebT1gAKCRDBN2bmhouD 14vBD/9cqYKdrTAFMz6KcpOJxJ61CvuYnUPyihjwAG5ODNJ/TVWyi23DB4xZuL9d5a1Ff1xPt0K xenDTpvWcGV4PuNDjXe+sLUd0VWaBr/u/qSnQgDEhzYBbP095TSe7svObyzpsA6qK3c6YpxWv4J jRHXI5HShKxxPH2EqrqgzFx+xQOhmJAcBuWDyOCQDkJwGjvNShtjm/Bucp04ehxnXM2pmmdSTKV uH20IKKiZvxuOfnllFf117Iet3e0cK7KCMmcAy4CNi8N4Fyyo8+KcX1o2jwaYEJBzGqjSZJfHEc vRjVzwLQg2mBtty/lc4PwvvKabGqaIqiW9nDsqg7s8StjZZ2C1Xj6tWBgvGJiPJrOPscB0anvRo //2hXe/fq7N4168QtWlzL4qnPMBVMP7xjIFwwXCFasHOgBBuaYcWRYSmydbuT+8E+Ca5g7LWTSx Yt+0Nk5JLCTQ2cRZVdB7GYf93YoNlJ3mm2LS/bSDlBWQWuR5RMeuGTY680tY+ZGlCfbWp+mZxyX brBg1fFJMyxwb2hPg8YaH8BWgaqQHz2M/jMeap2g8W3xYqSJcrwk82QrnNzfw95/w0o5ejrpADE KKV05pkeESvkDdw0gNi+Jl++3PUHsLFtdS/Zt0LRqULopfstN3o6duCsIifq2E558izCkBczLjg m6Eh1t0XIs2hpyA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson --- drivers/video/backlight/gpio_backlight.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backl= ight/gpio_backlight.c index d28c30b2a35d..e0c8c2a3f5dc 100644 --- a/drivers/video/backlight/gpio_backlight.c +++ b/drivers/video/backlight/gpio_backlight.c @@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *= pdev) def_value =3D device_property_read_bool(dev, "default-on"); =20 gbl->gpiod =3D devm_gpiod_get(dev, NULL, GPIOD_ASIS); - if (IS_ERR(gbl->gpiod)) { - ret =3D PTR_ERR(gbl->gpiod); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, - "Error: The gpios parameter is missing or invalid.\n"); - return ret; - } + if (IS_ERR(gbl->gpiod)) + return dev_err_probe(dev, PTR_ERR(gbl->gpiod), + "The gpios parameter is missing or invalid\n"); =20 memset(&props, 0, sizeof(props)); props.type =3D BACKLIGHT_RAW; --=20 2.34.1 From nobody Sun Feb 8 10:35:00 2026 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BA767F47B for ; Tue, 5 Mar 2024 08:12:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709626340; cv=none; b=kRj455jtqIODVblfUtjrsNTfILmm4bI5OOCsrJDRrVyjw8ti+ZICmBSR+FHDYnial4BqWHycJ4GARb2cABrQvh3rnI/YK+W7RVXuvgSWS3Y/sCXaCyt2yTkhWFZKfNXc43ziimKLbgtTdKThoguJJafOauQKLegBZuKzPGzyRxQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709626340; c=relaxed/simple; bh=V74J1dzwFo5ezSQUueHMb1/NFOrfZ3e7TgmXv0EuHDM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=X4qywKavoTVRFbpaDMZ4fUj7/MB/jVlVXHVD6WRqFi/ofk6FNOLhYoEu9YEwYHFaGxx0+uyHPHQAKnj5F3IJ03HcZe6Z8TclytgalGyFglrwf9BDL6QoeBRyQ+PWvYoTaIF6p8AM2G6YaQ9v+um/Iyq9icNSeLvWdH72JkxDV34= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JszRfOl8; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JszRfOl8" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-565b434f90aso7694619a12.3 for ; Tue, 05 Mar 2024 00:12:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709626337; x=1710231137; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=licg3hUE5I9iVSUhaQvUY/ICMniTjfaDb2iJSuUjn84=; b=JszRfOl8muCp7VQKPgIzMJOLmQjd1jZqB0KcgJVUBUI1gaQpxCIzDBf1XEuH6R0jc/ ngbu9MEQGph3g6BBGKhvbP9jXXIU0SasqrW/D5j3/dVuVjlCtcFDrtJnVq/oetLFGKeM qbHIcy5FTABOfnJfdhWc+wtTCIhSvY5fQArQRGpd5tfDpdqRSeRftw7/bws2qyimttzr Uw/71zfjBka5wbM0Jfpxz6+qawJAjx0HmLqT5OxIr0GOWZtl6fqFPTgw8V/220qVxS35 plSqUjTyyk4Vmpqlfzp/OOeJVMDW6nww9xcJtl2L2JM1nwqga5lk4S7D+0NvkzDe3yJo F5eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709626337; x=1710231137; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=licg3hUE5I9iVSUhaQvUY/ICMniTjfaDb2iJSuUjn84=; b=id43smsp4vzaTEn2uAFVLfa66Yqh/skXKA9qntpdrD29L0uziEiTQJfDO4ulxq5awO dPQoFDlIsTHZLZhCoI9qRm+sCPmjCirOnvl51EjL7dUxGdZ93sPvSMnQ6EQeXzugwVZM FQ4dzXouK9+EUiC2AaD/7KBIKW38imq0tM+cF67esngrJo8kNUM1NmAzEo+tUmREvgPW TqilOLyyIleeIe3yiY2caWyi9Ws0sTkjibR+KScyAfW/cB/i3ORg4y1YQ2KRIttKrIja kgTYjMBqxMzi8O+AinSvh63h6bvLJYT149BNC0yOI93t4CGHwUe3J0q91OMsRC/GnWfP yCfw== X-Forwarded-Encrypted: i=1; AJvYcCW/fbHOgqJSdIVOLSZlNNMEhv9vekTJK0IIlpODzWCnVYszIK26ivtFdI2o7Kq+hDeJl6IcYDSGQ52QiB74+6tFJ8D4ohYGWHzo/k45 X-Gm-Message-State: AOJu0YwwOuvSzeRDc8njq2BzaNlK0KXuVtmgXBri28V70d4fYp+V3TsD g99mjJ0KXojh5OpDEPRA5+GXUCS7FmI8wpMXNCr1e3UB8X2L+5fre5MTqBoM4RwoovdeMPVZGwd c X-Google-Smtp-Source: AGHT+IGfm7sGGkR9kUh8su5+o2QBu2BkEz27QYtpHoYuWXB8OY86QmE12Had2uOqdDw7VGaIixtjVw== X-Received: by 2002:a50:fa83:0:b0:566:51fa:3647 with SMTP id w3-20020a50fa83000000b0056651fa3647mr6968122edr.10.1709626336755; Tue, 05 Mar 2024 00:12:16 -0800 (PST) Received: from [127.0.1.1] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id cq16-20020a056402221000b005672a346a8fsm2761557edb.57.2024.03.05.00.12.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 00:12:16 -0800 (PST) From: Krzysztof Kozlowski Date: Tue, 05 Mar 2024 09:11:57 +0100 Subject: [PATCH v2 2/7] backlight: l4f00242t03: Simplify with dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240305-backlight-probe-v2-2-609b0cf24bde@linaro.org> References: <20240305-backlight-probe-v2-0-609b0cf24bde@linaro.org> In-Reply-To: <20240305-backlight-probe-v2-0-609b0cf24bde@linaro.org> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=2489; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=V74J1dzwFo5ezSQUueHMb1/NFOrfZ3e7TgmXv0EuHDM=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBl5tPXy6RPQ//PsVb4IYTUFFLKfQGgTqhNZjAe5 k8y1iiltayJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZebT1wAKCRDBN2bmhouD 1wKfEACbULmem8OvAeK+RHjlMayIwaUJM+uAeRNpZGPV6L4vyj8fGOfNFabiu5jtYwEOD8P1n5k sjmhuOectJ71wUf1KLkpU9jYUFDRIpF3IWplDn352HLVqkZevuejVUTS0D7zb2MHcs4HWf8ecI+ PRDIH87OTbGXXS6/CswU1Bnr83esrM05RJ94hfM5vkoom10EeTaCuD/GbCm0Qddi6VxMKnQF05U 5aUspkmJRq3JTIbZqpLsqcGJ4gZOBk10m+KXHEw66rRsimBz9hpnzyf3DC7dzmAxMZF9VUKY1xS fG25pvaOChS3UhIT3RjRcLUBElvel8TWrUIDXFIesd4bvewciUkRXPxlZm7iwzJv7rApgw93sNi fJPm2n0H5nbA+SXXlDfMgP3/QcVtfqkY6mtVyY/yU/j97vmq1tzodZVZZu0zDt9DWSfRXug6DZI OGULgir2GA6xgNGtufI4T115U3XlFPYpuzrLL9UawHvNJXlDcogHTMpjOZjvJHxHRa/9DdiVie2 goA++dpv0wqlnpInjDBFjh8MPlEqceV/nA/SkU4QAFi73i0HOQrDVdlUCrM+5cqHu/L+aeqCzX5 5ibcScLzNg7LET3QCv/K78ESsxWMz5U8T9vxWV8VAOaA8ILZkwLdjspJP344Bi4UQcBxiO//n1j GY2+W8LLtWpqZxw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/l4f00242t03.c | 34 ++++++++++++++-----------------= --- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backligh= t/l4f00242t03.c index cc763cf15f53..bd5137ee203b 100644 --- a/drivers/video/backlight/l4f00242t03.c +++ b/drivers/video/backlight/l4f00242t03.c @@ -179,34 +179,28 @@ static int l4f00242t03_probe(struct spi_device *spi) priv->spi =3D spi; =20 priv->reset =3D devm_gpiod_get(&spi->dev, "reset", GPIOD_OUT_HIGH); - if (IS_ERR(priv->reset)) { - dev_err(&spi->dev, - "Unable to get the lcd l4f00242t03 reset gpio.\n"); - return PTR_ERR(priv->reset); - } + if (IS_ERR(priv->reset)) + return dev_err_probe(&spi->dev, PTR_ERR(priv->reset), + "Unable to get the lcd l4f00242t03 reset gpio.\n"); gpiod_set_consumer_name(priv->reset, "lcd l4f00242t03 reset"); =20 priv->enable =3D devm_gpiod_get(&spi->dev, "enable", GPIOD_OUT_LOW); - if (IS_ERR(priv->enable)) { - dev_err(&spi->dev, - "Unable to get the lcd l4f00242t03 data en gpio.\n"); - return PTR_ERR(priv->enable); - } + if (IS_ERR(priv->enable)) + return dev_err_probe(&spi->dev, PTR_ERR(priv->enable), + "Unable to get the lcd l4f00242t03 data en gpio.\n"); gpiod_set_consumer_name(priv->enable, "lcd l4f00242t03 data enable"); =20 priv->io_reg =3D devm_regulator_get(&spi->dev, "vdd"); - if (IS_ERR(priv->io_reg)) { - dev_err(&spi->dev, "%s: Unable to get the IO regulator\n", - __func__); - return PTR_ERR(priv->io_reg); - } + if (IS_ERR(priv->io_reg)) + return dev_err_probe(&spi->dev, PTR_ERR(priv->io_reg), + "%s: Unable to get the IO regulator\n", + __func__); =20 priv->core_reg =3D devm_regulator_get(&spi->dev, "vcore"); - if (IS_ERR(priv->core_reg)) { - dev_err(&spi->dev, "%s: Unable to get the core regulator\n", - __func__); - return PTR_ERR(priv->core_reg); - } + if (IS_ERR(priv->core_reg)) + return dev_err_probe(&spi->dev, PTR_ERR(priv->core_reg), + "%s: Unable to get the core regulator\n", + __func__); =20 priv->ld =3D devm_lcd_device_register(&spi->dev, "l4f00242t03", &spi->dev, priv, &l4f_ops); --=20 2.34.1 From nobody Sun Feb 8 10:35:00 2026 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C16047F7CB for ; Tue, 5 Mar 2024 08:12:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709626341; cv=none; b=pw9/UV9jRn0h2wPnaEvRXeh2o4oWE7isk8/FsK2owMQXo2eUkuY1ht0ZLumgLKLhNW6vxM/hWrcNTexPbl2VaGDjyW7MkSNIWyLxonmwMi2grQ3gZfjbunWSHS/dDfa5Q5tTQNfoYQbq3GquGDkdjtTfM8pR43o35fFoes99mv4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709626341; c=relaxed/simple; bh=utYDuw34nGuToY7y1IT+NIEhf3NsXvVlpcJR4JW2mxc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YB3MX+QcjmXaEgNDWcMDqNZMV7zyPm/rWksgYQ1J1Qfkb3hHKi69YQoxpKKLmSJ1aYCNNl8zGC3A0ZN7K+R+q+VWrKlq0AEbDQ4eV0m4Q7XlHf/uGClqYigzUvBx9jgrK68pWAhlOKt57egj8OGxD2y9rUXfNi4Yvs6x8jxvJz4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xaOdjqdK; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xaOdjqdK" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-563d56ee65cso8065320a12.2 for ; Tue, 05 Mar 2024 00:12:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709626338; x=1710231138; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SGEzMDVs2SuhSNZcHsDkwLnjMMEuR/jN0H7FBJN5bdE=; b=xaOdjqdKeSrEDN5EsXI1rOFIuFmaVVGeb8MFUy3rcMTOTyplJ/ijHe5Bc00gnDrrcb PSixhRLrJjvKGOVnD8KKI5V26V9l+afRUZ3RCYREe1a3kHRw0I8htCOyAxwHdY81ri5J fTBDp5X8q00Tn3N6aE9kSHifuSxLJbZ2zq8JKAcYrxNcwCjQMjtP9/PH6KBL9Y1gMGh2 /oUL7NS1QTUdvpIi2AtrlhrgUn4v2JukZl84O5D91fiRkgrZ/cgD+8jpi2/T6w72EmrF hycW8Awu2BIA7zeS+tJnUEHdugc3JDLRI4BCQfEKJFJfBG0ujoT0McYQvE9HXV6e3oFg 7LxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709626338; x=1710231138; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SGEzMDVs2SuhSNZcHsDkwLnjMMEuR/jN0H7FBJN5bdE=; b=rri2ouWvgZ4AoKWSDOr7KYVDW45WjYnzGa13ksrHWaBrBKB7zL3L/sQ/6vnpBNjyVK fackcc+jp5v8vW+GMU2H6gmvrE0VMx1FXptIUAL8TL+dXOlrV5q0p+l8xlKZoX1vxWwe fv13SBHKu3CWGBai8A24sW3yTmFBgWCRmnqTTogQPL2L7lYXZt3L7wZlwo1ADaJkfouh HQ4WlxOT/EfrYjNxvfvyzg9gyr/Uyf82RH8Fwh45wz7znhccEkK2smiX71uPvdYXMaZ2 XXqD+TIcB7dFU0JiXfZ47BuzMgs3CaLJ3S/mygQ4h0tregZLN9uFQ6LGANbY8yIMxCIw d1AQ== X-Forwarded-Encrypted: i=1; AJvYcCUkd8sOQxxtBYhfEohruQD6Rdrj063BXNyi5O4H8bM7ZNr5L+t8Fdpa3CUBUXY0Aplb9n1hsvosFV0ElJ+5C6cV7HDet8o15D1+2XWB X-Gm-Message-State: AOJu0YxptqgAW5WFvLbFnVoL2EBI2Epigv8EYXogOgXiLYSRE5hW4wD/ t32I3eDkPvIx9Oy/UMJXNjwlu8gP1qE05/AU4a6dROlfy4PbeRz/6P7a09ndN5I= X-Google-Smtp-Source: AGHT+IGPoDsTMtd30w/DOshzWoUEHpx/Q/pa5sDpp/arpdkYcoyWSkhqspl63v7mKF9KA18tbb+Y6g== X-Received: by 2002:a50:c88c:0:b0:566:44ca:9f5c with SMTP id d12-20020a50c88c000000b0056644ca9f5cmr6893675edh.8.1709626338138; Tue, 05 Mar 2024 00:12:18 -0800 (PST) Received: from [127.0.1.1] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id cq16-20020a056402221000b005672a346a8fsm2761557edb.57.2024.03.05.00.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 00:12:17 -0800 (PST) From: Krzysztof Kozlowski Date: Tue, 05 Mar 2024 09:11:58 +0100 Subject: [PATCH v2 3/7] backlight: bd6107: Handle deferred probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240305-backlight-probe-v2-3-609b0cf24bde@linaro.org> References: <20240305-backlight-probe-v2-0-609b0cf24bde@linaro.org> In-Reply-To: <20240305-backlight-probe-v2-0-609b0cf24bde@linaro.org> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1306; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=utYDuw34nGuToY7y1IT+NIEhf3NsXvVlpcJR4JW2mxc=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBl5tPX0BTP6R7BZf+T2A19wNFHqlTtCuGUa2M9E W+LsqYM6eyJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZebT1wAKCRDBN2bmhouD 17l9D/9V3Rtsc9kSl3ihhdhQ3TA7WjcTHaWmAnmked6/2v/yRSimxEfAaz+db9sq1EZ23XaHlA6 ICFtKCF/SvSGy80HnJvGKX1Th7Eem6h1onaS0Zip0WVVyrRzkoIKYfLbHRge29FExq6ycEcDF7O 5bu0FL7MaiwjmEbP7Kyb57n+Vp0V/FUbVMJz4dk4QrVSkZyJfUa9PGjURWJN7QZxVgFp2ntwxNT tcnLYB6kr4o9/xezchi5rX1z+tRx5cHZZyr2KTDqRL50k6xeE6lL3WYyfQNyNaObvGZeuAn9rbA TOqHm44+n4QD1zGM2jG+9qTb3MCttYy3J3ix6WXhUl2VOzA3IUYARp7Gy09+r3EH2JDwWAHWkf6 OrNM3MxYy9jAmkXNxPkcOoHxm0Mynoz5IQlX9kwcwruj1Eu7Y+rSgjrd9hg+fgc2CuNsb/VPkR5 Pb2gsGKYCLQSj3akNr6JTu7T9ch2H+scaP40a169Nc5mjwqXNWTqx5vw17OjuUy3+xYkFmS1QFc tnLVTBhUXjpum518RA9w30D1JkVK5K82wlOAKZdiwgZ16oREN6NXUIOMZwXW9zsQu4X+ZL8SqXP IOa1VEKXQ+H9MIVu0sgGul2COHGnhRJgbOc1dJZrgbXQ7WS6XOhzflJhcl/ct4yrxqnepmw2Dxh MgoyRlqN12K8NdQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Don't pollute dmesg on deferred probe and simplify the code with dev_err_probe(). Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/bd6107.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/video/backlight/bd6107.c b/drivers/video/backlight/bd6= 107.c index c95a12bf0ce2..b1e7126380ef 100644 --- a/drivers/video/backlight/bd6107.c +++ b/drivers/video/backlight/bd6107.c @@ -119,7 +119,6 @@ static int bd6107_probe(struct i2c_client *client) struct backlight_device *backlight; struct backlight_properties props; struct bd6107 *bd; - int ret; =20 if (pdata =3D=3D NULL) { dev_err(&client->dev, "No platform data\n"); @@ -147,11 +146,9 @@ static int bd6107_probe(struct i2c_client *client) * the reset. */ bd->reset =3D devm_gpiod_get(&client->dev, "reset", GPIOD_OUT_HIGH); - if (IS_ERR(bd->reset)) { - dev_err(&client->dev, "unable to request reset GPIO\n"); - ret =3D PTR_ERR(bd->reset); - return ret; - } + if (IS_ERR(bd->reset)) + return dev_err_probe(&client->dev, PTR_ERR(bd->reset), + "unable to request reset GPIO\n"); =20 memset(&props, 0, sizeof(props)); props.type =3D BACKLIGHT_RAW; --=20 2.34.1 From nobody Sun Feb 8 10:35:00 2026 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 089D27F483 for ; Tue, 5 Mar 2024 08:12:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709626342; cv=none; b=amw+kRsBayyoFRaxzv/WhZ7pbhHLFW9i/dvcJriNVhr6SH2tP15LGie2j1kHT9nAbJDLBW0kUGgR3iCt+tK97mGV82ViFapZ+9hUrOM6Ql03UBr6sfYvAtYudE+ZQ7zjD1AOOT3YFWsyVwNMNMfAhDfKt4RbFMyHMcz1k/tNLs8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709626342; c=relaxed/simple; bh=rLcNWyHrJ59PgQVMQdROdn158veQsUOWpOpARELHPHY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FoF429LragTRWmOR8L/j3U1rbJPAAJ22hZYVNgubTUC5LbhMjXS9/g9hfgowYeU8REm3E5WDSHKvneXnAvWxtIQDPcZJn2rG27iROooVgqwJsxkwm5at+QyDE8Jhgtd8T27NtoPyI841C4lUNOcKGN2HY0USMFXefcte7xHfHjA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QvAtfn06; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QvAtfn06" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5656e5754ccso6769502a12.0 for ; Tue, 05 Mar 2024 00:12:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709626339; x=1710231139; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=POVvCdCwqgBsDTzLmq+xlV1vSpeRHUQ3tEhlOTxlYcU=; b=QvAtfn06hEOHBpAMfE3/7kgoGVh4zy1rORx419jY+4HqbmgU5soklIL/gLPkLVBsgA 1B0reUcaWoJs5C4HXl01KeavQtYhuimdgh2+iWxcrWIlVP/fQcAhe0QfegdAGt4dTyWr uJucD5jGULN8nr/z7sP47+RSvK5WRzJ21bLrOcIYo6Ajbps4amTtcL6iIbA8Shl+LmrD 9CI/dXkmA+wRYV/uD0IyaVOBjJeeHJC5aSvlAMU8v486b4uuzQzZKkClCGl9PQFuIYEa QsUlyG7vUJm1CALR8m5jIeh+xcwFMx/9D1LlQ4Z7T25ltR2DP932mswo0tcXZApQMNIv C/aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709626339; x=1710231139; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=POVvCdCwqgBsDTzLmq+xlV1vSpeRHUQ3tEhlOTxlYcU=; b=NHIIu3m/8lToBw/NteN3pTKt3dshX+zir7dHPa54KuInPwuhufknGLmLFs/32BSMGw Qv1xsQQ16BUIXE5454ai2YWJDAPPS5Uvmd6+xTFvZBN6+2gW3+43Ba2/+HnO/Z4RJJPB +0tFLz39RnR8Az8tGhcAETa7GmExNSdXObV+ZfURiWLdEtOQ+LibSKKG5E8YhkfT3ffA wXSr22W0hg4/FTUUzO6l5vh57vjV2V1Uf++XJzNhAnXd5a0c8a7CQI7VaFVzg+cNfA8I pOw36mgg7s5Ya/ikGx0m7lLK8957gtvIcnISCOzsKMsJDx0QbDbWtipz/7RzzL3BIJuo KETw== X-Forwarded-Encrypted: i=1; AJvYcCVHMmqJU2XaB2bmMvSlnhujStBOn7He0mWwbz1EHWEWzL1rqSh0JpDYA53187c0NrwVbcrLSvXpmXvolApcx1MHVePBLppJDQdo3Wh4 X-Gm-Message-State: AOJu0YwqwWaQGhABqnMbifjBGTZFpnFF2Bra8WYBmorzF+lsO9Cma+9j Ftq379rfymLDGPAUq4mh/das9JdsNtTfl5rE9WFvW967004TLndtEXRbPkHwAqmA294OrCNs2Fp a X-Google-Smtp-Source: AGHT+IGOwgFjm9p+7mY8WcaCSk3d8VXb2bBW8TuCFZ36DSxBXROjoRrcLWhEMUftUIgCJZt6zZLL7w== X-Received: by 2002:aa7:c3d9:0:b0:567:38db:8076 with SMTP id l25-20020aa7c3d9000000b0056738db8076mr4309804edr.21.1709626339498; Tue, 05 Mar 2024 00:12:19 -0800 (PST) Received: from [127.0.1.1] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id cq16-20020a056402221000b005672a346a8fsm2761557edb.57.2024.03.05.00.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 00:12:19 -0800 (PST) From: Krzysztof Kozlowski Date: Tue, 05 Mar 2024 09:11:59 +0100 Subject: [PATCH v2 4/7] backlight: as3711_bl: Handle deferred probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240305-backlight-probe-v2-4-609b0cf24bde@linaro.org> References: <20240305-backlight-probe-v2-0-609b0cf24bde@linaro.org> In-Reply-To: <20240305-backlight-probe-v2-0-609b0cf24bde@linaro.org> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=959; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=rLcNWyHrJ59PgQVMQdROdn158veQsUOWpOpARELHPHY=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBl5tPYiTvjPqEeJttKrU7WiswuUE0dpbgygo9ZR 33m9uiM1euJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZebT2AAKCRDBN2bmhouD 12YgD/9IXBNCquP3bPqgvY8F0d6uhoxY77XF+TciANVjhfSwKpU37EewVGovz0Iqnt6HWaDWN6j F21SWV7MUAEoUrnIsLHKojTKz8CSXamKEGAjPAtUUXOMgjFneB7r1biTAbhkdeLR98b4MUJOdel 816YAtPIwC6d3RgCF19e5h8rGj2fxWNnb/qJTK/DKsNNN8L3m+lczzFyE3aFdcEcW/IrPEFlZ9r M8s6i3GDwbVINPBfSTKmJLYUJyLuyJiohQTgzlU7Nkcp6G2I4ufyiAmZP8/kmMG8w2ZAJ/M3y0e PvQ1z/ZuFfFqLvNZZiuL7IkG5UQJ3FVLtCIsure9tkDLyGUNsHIFutW4dHczc9HvFvi9pVzt6LK 7T6rw/26yrYKfCaBJEGn9zpVaxiAIl2XczCIo3Gz5Aygy/8U4p7y+oUa9qUawoutjLXtTCDbKIt OgbZlnYagsZCtaQGiMG5aFwX586KxBz9a4td3TUSq7L1Osa1d93WVbNetGeaLTTfoB1Rsu0SnSV YgXBWi7SbTL45BS82xRTGDrf+jctkC0oVC1qQELCRTwBzwH6QHUzn8lBPh+mJgViOMMWlqTpblo xumCSjPITNs0L4Yz2T6PqFn/0xK7RlnvQbgPxII4GvtnVm4lCbuJ0yCedULW9uBWchL02hx8wbK R9FlO8clmcCQD2Q== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Don't pollute dmesg on deferred probe and simplify the code with dev_err_probe(). Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/as3711_bl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/as3711_bl.c b/drivers/video/backlight/= as3711_bl.c index 28437c2da0f5..e6f66bb35ef5 100644 --- a/drivers/video/backlight/as3711_bl.c +++ b/drivers/video/backlight/as3711_bl.c @@ -383,10 +383,8 @@ static int as3711_backlight_probe(struct platform_devi= ce *pdev) =20 if (pdev->dev.parent->of_node) { ret =3D as3711_backlight_parse_dt(&pdev->dev); - if (ret < 0) { - dev_err(&pdev->dev, "DT parsing failed: %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "DT parsing failed\n"); } =20 if (!pdata->su1_fb && !pdata->su2_fb) { --=20 2.34.1 From nobody Sun Feb 8 10:35:00 2026 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72AA07F7C2 for ; Tue, 5 Mar 2024 08:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709626345; cv=none; b=Oeq5K1BntgL2xgHhHWo8055HB0KMJ8fkz11X7kBvjEBV6q/MM0Tv3Ks5DghPrAyVjYpNzT8AwLVeXHK0IqFNm+lnBe1RTZLXUW1b3DFuGIo1w7MeZYz012tJswFdeKArf5TH1JC63a0r4Q3SvZC1yJ4GXoUmJ9ykjmV+ESHOIYc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709626345; c=relaxed/simple; bh=zeZODmCY1S1uqMpI2blr7qYy9ZObZCI7jQk2MUKiyFQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ORjcljFhWqMGKzxS7efCMhDWxVlc9w47GDLhvPLjT/qVKB797BFywM13MEkJg1KWtWkIYC9MxxEGUexcY8JMxtuPzal4vZ5x1BK9N0AYrgjPk6a2IB/RlQPju1isJOltnjQrfmnObnVr1h3nHdMbX/Ls1cZHmuz0OTl4i+QxHQ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nIWujsfX; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nIWujsfX" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-56657bcd555so6663045a12.3 for ; Tue, 05 Mar 2024 00:12:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709626341; x=1710231141; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ExK15caTzPYyfdwBopINcQ7SZOSz6etjc7XyN0ZMwpo=; b=nIWujsfXBoMvhjac9aKXXtnFOQBINMhT8PfnX0uMaNLk4qLp6lY6irBboTzhv7ysXE ZN4W+n3A/AGv//Rfvk8J5g0S4AJOkGhHorybOh/0XWj17T8BQYy7vnWTavT8/lOgk+lZ 69RlHZRj+vaID6YGgy3Cx0eDeZd49MZz/hpO+bUCqdI2IoiNCXq+04YWsJKXv0bISOTN duEEoTwHloAk0cROyp10a7rOcL1NcfGjuIefYVfwU+yVXtW0TJqc+9XmtsIUStwhktyD c02Y1JGF37pPjSLJOdh8mtlKF29jDSMz8b3Tgl3KPuy0TkxHm9s+QITIL4aCV6Jh4Gg4 haUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709626341; x=1710231141; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ExK15caTzPYyfdwBopINcQ7SZOSz6etjc7XyN0ZMwpo=; b=p4CdTfg/cJGzunRaM+u0fEdZyZc1eE8XT3GVDM961Cer90wjmwdXp68EFfdZwydEdg BS/jWGO8nQYQyFTH30fBn7Zc+Fg/l7ymw8bhVKERFELwfL5khuYYNkNjdUOL7NwN90QE MgSuEriQOwCYvrx8P1vE9/f8OQLqUWQ4SRm2ADjpOtIf9xeAg2X2T5Xz2njbwCrkqAnr TXj9krkhF2u87fHy+yklFSvy9MOykaeqKDUDMyLyr6xNav5ocCRFugAW0U22eyg4gjzN Hi8G/IbqZKlPP4Wm5vx4UUkYhq6tgyGXrN3FBGABR7hphW2Mh7hCMwMF4GPW4z/ciLnD gyeQ== X-Forwarded-Encrypted: i=1; AJvYcCXD2dDdFrxkOK8Tnuh1DD9HjESXAppuorc7XJG3Jpe/Mm/oBikzD+3h01JL4FATouDtrhHiflYIlK936OwsGRwFlrviRVDkp7cAjqk+ X-Gm-Message-State: AOJu0YzJBeJ+VUFqrtw16/IL+KyVwLPx/1MmKKMNpWglY2Zs0yqkBVXQ RDo19P/+1QRehNpX+i2Xl23iTb69Nu7ufFUm2eDldSzxfDDh+IjDBl1bc1y4jC4= X-Google-Smtp-Source: AGHT+IH/uA8GkUvAAQ9ECD3IzSDFIVVQwU0E2DIbx0rKbCTdLIrwu2V+eRJ+cIeAiM/1pjiB98XZfA== X-Received: by 2002:a05:6402:2315:b0:565:6c72:40a9 with SMTP id l21-20020a056402231500b005656c7240a9mr7989319eda.28.1709626340845; Tue, 05 Mar 2024 00:12:20 -0800 (PST) Received: from [127.0.1.1] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id cq16-20020a056402221000b005672a346a8fsm2761557edb.57.2024.03.05.00.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 00:12:20 -0800 (PST) From: Krzysztof Kozlowski Date: Tue, 05 Mar 2024 09:12:00 +0100 Subject: [PATCH v2 5/7] backlight: lm3630a_bl: Handle deferred probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240305-backlight-probe-v2-5-609b0cf24bde@linaro.org> References: <20240305-backlight-probe-v2-0-609b0cf24bde@linaro.org> In-Reply-To: <20240305-backlight-probe-v2-0-609b0cf24bde@linaro.org> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1069; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=zeZODmCY1S1uqMpI2blr7qYy9ZObZCI7jQk2MUKiyFQ=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBl5tPZD8MWfLYEt6rCWdnIjlfRQIRJw0u4/qqS+ k5T0+JBGS+JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZebT2QAKCRDBN2bmhouD 12fvD/4o0bBt8fofIHD0XpWwJNvU3Os3cazAVsGlsrm4AuCVvGk4aJQUwr2TiCM3Tkz148/bo04 ehgJuqLPlK6rYX4fV7mjoMH5d11p0rH7Ik63fMZSXY6zDeOGCXR3nQQXSJ8Y1boQ0sqOCTS7FcA 4D+RC5tismY1qTv62ISrDmk2aVKW+UwAXM3Kt/rrxfN9sNQNh2XdZrdMN3QCwAsbyTAAM9k+Sah a7MNxdBbIVgGdUN2XZXri41Fy6WZXRCKDY34ISqggHrDp9u1q+JdB3Pvj68dwlBQthT7Cg7wEJP TA+vuZiV9M/TVJJT1sQXUs04vKn0BoVS9z6+h1tjhcNDWlJRFA63MIKJT2mw+v2UzcESTKY4scn ZHNt/lrucx4IoWVrEcqRxuEuvU5EDgG29iOl7BvCUattDGdpScEa5xxY7CCalBMIW26ip0r3jmf iyWE/FslUQjV5eWS4WgWzLeBFcKM7kMXojpndsq2Cl20ZQ9Zbb3wXMAKTlgAVroWrN845KAHvtK Ejq/Tcd680GH8y2/bWK/E9OQD2oP/K12UQltNNyvPVkO2NeQIaNAwRxOP3rBfGtlGhBrN1KYjp4 ZsngSrMfZarGq8cQ6ZjWGWsgbSWrk+CecKiGZLj+kijL6abbj/XTfgUojaUpKnlbDanESNAGN3u obK5/meKgl1VgFg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Don't pollute dmesg on deferred probe and simplify the code with dev_err_probe(). Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/lm3630a_bl.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight= /lm3630a_bl.c index a3412c936ca2..93fd6dbccc28 100644 --- a/drivers/video/backlight/lm3630a_bl.c +++ b/drivers/video/backlight/lm3630a_bl.c @@ -563,10 +563,9 @@ static int lm3630a_probe(struct i2c_client *client) /* pwm */ if (pdata->pwm_ctrl !=3D LM3630A_PWM_DISABLE) { pchip->pwmd =3D devm_pwm_get(pchip->dev, "lm3630a-pwm"); - if (IS_ERR(pchip->pwmd)) { - dev_err(&client->dev, "fail : get pwm device\n"); - return PTR_ERR(pchip->pwmd); - } + if (IS_ERR(pchip->pwmd)) + return dev_err_probe(&client->dev, PTR_ERR(pchip->pwmd), + "fail : get pwm device\n"); =20 pwm_init_state(pchip->pwmd, &pchip->pwmd_state); } --=20 2.34.1 From nobody Sun Feb 8 10:35:00 2026 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0215180639 for ; Tue, 5 Mar 2024 08:12:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709626346; cv=none; b=ClWG4dNhtznIm9HBtFBUM8MmVD72VYkf+5hmd4qJw5RntFaXr6NWhF+AuwtRG/UShu/j2iczGM6y8CsdvgzPB5MWcrerQhUsoxLIQ15Sxg2gePNa1bcjFdbpIjpI9g/G3xKeE1zp3Kj7YKAX1bTwGzxJ6S+wygefx9kF9KGfdlE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709626346; c=relaxed/simple; bh=YHeoQ29NKf22XZpaybrdYUUdK12wkL0lEB4GhWf8FTY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XDa4a+i8euz0IzWqTNd7KxJ1FlN9mtKkTQ3BNIOlFJ8hZD7o5XaV6IxfXq+zwY1wEDy+MYHg7W20Pum+87+pFJ3DoqUfG7PBZVdM5DCHjFXSyP7rTF1JRVgNPjlkRZ3crwwmEKD6paRyQBub09KOxOAn/7Woer8UOLKAwIH42aU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pILB9NXn; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pILB9NXn" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a44628725e3so672560566b.0 for ; Tue, 05 Mar 2024 00:12:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709626342; x=1710231142; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0Fm6lCHtlVIF1F+K0N/OPMuiMCrX8DVXWnanpZaecTQ=; b=pILB9NXnIhHFh4XQLaoHRn0HXZN7TLGIwRq2XAjNoL6bb3QGlYLFEnZg+8KqnqCmY1 Ok+R1MBNIZgnzjKwAWcdEWymPbiiUtlghQ5rKzXEpT2reZZtzK7xVT+wi89Vc5NxNtwT /YaM51xik8wIqw6c6wzviYPHszIx3fYtD5M+TLSwcNlUi0NPP9RUXmClqV3Q7hY7ZIqW xyWCA73FrX7yJgvuJINRIDuNAuhsu2Bwue58srH0CXCo8UnCVWQsWgx/EgeMl3J/QLMQ eaHgaOrvijdqUSMlq5jfalJsLBPwIcFWj4UpXDw6LqnUOkYCEAKRt/dmbb8YYpra8KB0 Xc6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709626342; x=1710231142; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0Fm6lCHtlVIF1F+K0N/OPMuiMCrX8DVXWnanpZaecTQ=; b=pKvapuOVJRcvVMSthOZpfwpqwF2uRIw/9S/kMPOb4v/ECOtKk0yVINpAbGojNfrWbt NeFq5V0cmOC/71LiVV2JFizAykuonWiww2YnnEX7fJMLdZinmmkb+VQ2rj3bVLkKsq7x 3lZFbAaghpffX+ig2V2f+7B3jo7ysK0qv9ZHatK9z56rTq3fqSbRwXsydEFYlIuRVx1E xLPcwCmLtKT8H6J9260lYQLAD9QkSSHQio3oqfVLBuvAs8D7MBaUPwkIgzHm0D3hNtJI VFEkVW42u+d1FhmV1QJ2oitwgyQPtn9FXa0u6cN+Fwi4YdoONRu7W941T+DWG9+UP4BN 7iCA== X-Forwarded-Encrypted: i=1; AJvYcCWczCIggsgyany1M2fZwdCoReEUpkcyJ7mlB3hA8Vhp6PDtw6XV1doEkRXpSMD0Qskj6BUmQc+3z1MVa9jjD/Nnm/YW0e5qnFztjlSf X-Gm-Message-State: AOJu0YxKQo59gpEaWITlqXfzXqxofOWlnLyDqF9reDHT7n1rtxUdrzvH hhf0hhIVz6jNMoc17v5DuTmgnwn93fvLzg63uzIt4Exj6wtksW3PyI9ghLg/O04= X-Google-Smtp-Source: AGHT+IFmQXq9OqnAqZ7n+ipcdaFFZ7KEXlOXnYPr+dCB5rotQlp6U8HU8sJNK8HhuEbg+62y8KfoNQ== X-Received: by 2002:a17:907:367:b0:a43:f020:57ed with SMTP id rs7-20020a170907036700b00a43f02057edmr7581833ejb.73.1709626342374; Tue, 05 Mar 2024 00:12:22 -0800 (PST) Received: from [127.0.1.1] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id cq16-20020a056402221000b005672a346a8fsm2761557edb.57.2024.03.05.00.12.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 00:12:21 -0800 (PST) From: Krzysztof Kozlowski Date: Tue, 05 Mar 2024 09:12:01 +0100 Subject: [PATCH v2 6/7] backlight: lm3630a_bl: Simplify probe return on gpio request error Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240305-backlight-probe-v2-6-609b0cf24bde@linaro.org> References: <20240305-backlight-probe-v2-0-609b0cf24bde@linaro.org> In-Reply-To: <20240305-backlight-probe-v2-0-609b0cf24bde@linaro.org> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=961; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=YHeoQ29NKf22XZpaybrdYUUdK12wkL0lEB4GhWf8FTY=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBl5tPaMO81r5PpyfYzgPlAboOMwxF1eOJg99FdH BQsx0i+aJqJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZebT2gAKCRDBN2bmhouD 17VTD/wMe9QVJLWWgoGJhpJgK0qfzqPtG2LHvEiQKHIc9p4TZH6iIk89FjqgbQmllt/sCIdLPzD 5jCNPAb6QsYi5rBbHw9tXOW/fw/bA1XSeBdKReHR4xtnTd+Lp7ZEMe7thHzzhEXCEW+6AuW5Zh7 vdcnvZPWJcVUV9QokX7gskQsHOTHg8M9L11ICQnn2kgJqtBvffsN4z7tRx0gFY2BFkV390IFTZa hHlBhzDWyYxYAp4I5M7OUld5ga37cX1lmBM8aWaC1lj+UoSNe1XCQPvo2mp/0U+hEZGCkCW9T5c d478MV6wl1sAsoVRUq1VmXpOYK8+oi8beiW5SF7YWtT5knT7Z99N/kfc/MPdrN8WqThf+6TE6oN Cehjm5fjzjvLxM6INXJn34dwTXkGgagvWLL9SQwrOtTMAx3h/PBIGINvCaOzapuZeDwCS4vfvp5 CLS7LbPOYq/0XbEwySMM86UcHe7Is6dZHYqDXfMnEuxh5EPQUnDFiYrs01SINbxX5i/N8rT3ovc xaTofPHKif7mPAFTVBudQKQb0oQQwo14veJnxVLsXfapCKdnDEjrX4uqhtstonC6F3vNX9w97vX 5gsi4DlkZSWtsii/UFMd1cohSPSSv9zx8VS2TAbTXmafKMfVKjf5caGdDisNEoGNN96UoujMDcp krxxRUqlxMNOQRA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Code can be simpler: return directly when devm_gpiod_get_optional() failed. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/lm3630a_bl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight= /lm3630a_bl.c index 93fd6dbccc28..ac0a60e39e39 100644 --- a/drivers/video/backlight/lm3630a_bl.c +++ b/drivers/video/backlight/lm3630a_bl.c @@ -543,10 +543,8 @@ static int lm3630a_probe(struct i2c_client *client) =20 pchip->enable_gpio =3D devm_gpiod_get_optional(&client->dev, "enable", GPIOD_OUT_HIGH); - if (IS_ERR(pchip->enable_gpio)) { - rval =3D PTR_ERR(pchip->enable_gpio); - return rval; - } + if (IS_ERR(pchip->enable_gpio)) + return PTR_ERR(pchip->enable_gpio); =20 /* chip initialize */ rval =3D lm3630a_chip_init(pchip); --=20 2.34.1 From nobody Sun Feb 8 10:35:00 2026 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81EA880633 for ; Tue, 5 Mar 2024 08:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709626347; cv=none; b=mS5g5TCY6eFARHRtXa+/vpFhPRu6xgxDp2wqZTlZLI+dJ6XjecURrE8u7qfo4J0sh4MNjhcnAI9IdJF1UhTogLto6cXhnUR5hjj/kNXB5JrMG5cPvsX70Z8ltwf5OTjHukdRLV59dqZafvbytmAZ+dzsZ6aZ1dnBHMkzV5MoHOw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709626347; c=relaxed/simple; bh=inLsT1VkNNpcQ91Wz4F9uFHvSwYM79hrTLwE/rxQxRQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I6ltk0y3X3A6NPsxkixpy/jM6EFSYFbDszW+NWYerH7oAZOm31mMhhs2JPsv0WGeV+rj6PiCpWx5AHuolvMpBsd39twixd7zwf6FLF04DF5zRZdD3qUZyWY1AzsHw6iM0Kc5PE68SLjmUsyMXl3DowyM2C/ToD4rDWNn3zbYaak= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Pjgd7zpV; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Pjgd7zpV" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-56657bcd555so6663104a12.3 for ; Tue, 05 Mar 2024 00:12:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709626344; x=1710231144; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WIh814IMUk5rVefYqFVUgBnp3hq65uUsqUe2ecL/Y00=; b=Pjgd7zpVB7TIBolZQKc0cHSLkT2lzxIPb7KQHaxsyWYdtnWwIO9K8B3xALdqLklKma nPyejfGHU3UAEkHj3qdgaGWZTvtbggtnlj7mJbEtg9raZL1dIK1mHOMcnKf8g/yOtUiY N0icsDQ2pH+vv4HTWqiEp0BbWYPMFj/Rx54RBhfFrqvPelkiEw5YBk8C0P55X9NXq4dB 6UgybzD1v3afraoegttkeDa1DGXhR3YcyT4puinWyhLfclNOJXcL7CMqu6HP/m9EHqJQ bsIS+ot/cDF650X8radAqRzbthixwfsGhCuDqQGfLDpiUpbk/nZ3gSq36AXLrNCD8ADq X80g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709626344; x=1710231144; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WIh814IMUk5rVefYqFVUgBnp3hq65uUsqUe2ecL/Y00=; b=knVHWeEBwAnM359n8XCyPNxM/cHR0Iqv3z3R7p+i+UYvw9DH0BcxmWVJ7CiUsSbv4+ wFAL5LWanU0LSmx+oR9Jod5hz3+mwFMtARANYh9ehQ0Iy/mg8HFhhYgVAaQFSQf18MJi J+fzaHvaSCt80OX2AJNqXC/ynvL/BujBR2uy7wVl1rIdlzHrJBDEZn5Jd1SZE9B/uPTl 0pQ2g5kIIJe7m32sc3uMGGbzddtMRk1P1LGbiM8GrtMDtUAQ0JvyKAWqFpdZmYt9qKpP UZ0iuTS9sm+V79qnKLf/sbapmI2/f4ZhktWHZQBHTPKhwZazG1kg8h7ks7IwROOZVN+t FQzw== X-Forwarded-Encrypted: i=1; AJvYcCVizTVi9kK+YxCnFlPSxpyTrXJr9R5ddkHmfAaO/z40p57conBi8Cqs3pcKAem8hR5N1sOcHpwNijzSeXJ6m+h8Udbo+URUEYlWGf6g X-Gm-Message-State: AOJu0YzNh0BKOc8P0R71MfpPLOMtLfO+dhWSXASDNZ9det5wDwLmT+B2 K8Myk8JLZ6wwGiIwkdNUZTvnPJUav/LFpXZlQQYKMKtflUA3Cw85ExusG/ewb7wI/FJA5t8TWlO r X-Google-Smtp-Source: AGHT+IF1NY0Hm8ivs7aO2+SykkAen2RzTu+xu239XL5G/CqAmL0kvEQP4pA0JwC31R81oKLIggZO+g== X-Received: by 2002:a50:8d8d:0:b0:565:665b:9c82 with SMTP id r13-20020a508d8d000000b00565665b9c82mr7135380edh.8.1709626343919; Tue, 05 Mar 2024 00:12:23 -0800 (PST) Received: from [127.0.1.1] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id cq16-20020a056402221000b005672a346a8fsm2761557edb.57.2024.03.05.00.12.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 00:12:23 -0800 (PST) From: Krzysztof Kozlowski Date: Tue, 05 Mar 2024 09:12:02 +0100 Subject: [PATCH v2 7/7] backlight: pandora_bl: Drop unneeded ENOMEM error message Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240305-backlight-probe-v2-7-609b0cf24bde@linaro.org> References: <20240305-backlight-probe-v2-0-609b0cf24bde@linaro.org> In-Reply-To: <20240305-backlight-probe-v2-0-609b0cf24bde@linaro.org> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=920; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=inLsT1VkNNpcQ91Wz4F9uFHvSwYM79hrTLwE/rxQxRQ=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBl5tPbyLAGnwidHT2FhDojPQp4jpY01sPQHqOsh 1z/ozH7T0iJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZebT2wAKCRDBN2bmhouD 12mnD/47jc0NyWr3MU/W4BdsljAD/lH82VZh/9UG6ndVSQ118crkgBJGB86mt0+q+Grx5gxZCNN iarLv2GUAyMLnhsbsH0qm9lS0pkbkldTzyH0PDiOZTQ5NqvlHwhsOzSOlnBwx1aTV4jD6cZ3Wre X8lLUBtRlWqBZokl19oxqnNv33aKv5wby2A3pG6NnDT9pQAVhJSPTQKhIU8toq5pJFDZ26+ZR1h Ij3ea7Y2uuFPzhKfX/1F7/4RIHOr1arNpK5UrLfqVYz6U1KW8fSYp1dEXPHtNVAZa/WyNOIvuet qAs4Wbcs7dK9dUwJvYodbX1Mu1rL9eL31DP584V/kvHGD5Fa/QKXSNYZeni9QHR20ePfn51AGtF mwY+6TEK2OeD4bZONtbfdE+rFQczSLeHZrLJR5ikdjpz1jhc4qNtZHt9KykjnmP3ZU0gu+R+OFH aXfu+83AM9jkHbHtXg2tfKmJ2wneXwA/BRsK8pA8uGSYi8xWnWdf3+2vS3U8xYXeC6c3m4ssWeW PgZPuWc9qxZx4oVWeqBtW+8OS7Al0h591hqL5qhY5xaP7nPflBUbJX5nvmTOoXN/sJyxCvWDcT1 eN9R+7hv/QsHEIHSXMoiJzEo08OjuN9VGUeyn3Gf5ljzobDGTG/m0r3R6/1HYdLlXkHEXxLgF4u u9l+0dt1vrXNYpw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Core code already prints detailed information about failure of memory allocation. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/pandora_bl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/backlight/pandora_bl.c b/drivers/video/backlight= /pandora_bl.c index f946470ce9f6..51faa889e01f 100644 --- a/drivers/video/backlight/pandora_bl.c +++ b/drivers/video/backlight/pandora_bl.c @@ -114,10 +114,8 @@ static int pandora_backlight_probe(struct platform_dev= ice *pdev) u8 r; =20 priv =3D devm_kmalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); - if (!priv) { - dev_err(&pdev->dev, "failed to allocate driver private data\n"); + if (!priv) return -ENOMEM; - } =20 memset(&props, 0, sizeof(props)); props.max_brightness =3D MAX_USER_VALUE; --=20 2.34.1