From nobody Sat Feb 7 10:08:36 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8DEE1798F for ; Fri, 1 Mar 2024 17:56:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709315809; cv=none; b=P+/oSYjD8CQkShM1zAQvGPjJUXZCiLm/px5Eryhspnp/yRAfzciDn7sKHVUPFWQT7kGdH9i47puGXUezL1yVimfAcHYY4WpmlP2qLwTJiQXe28i7dzCCZvYs1RVGbWVun1DS7imd03r7V8A/NuvdH0PcAye5l78pcQsVjM3hRTw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709315809; c=relaxed/simple; bh=VrL8Wgn7VCCPQmOga0aArrh/XkhN1vzXIcht0JUG/ec=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OYBhq+Z3hd+2L0qwgXdCAIPUCGXw/ju6kzqnuOdnQj+WPGae4qptjlBdoT7VYHGURwX6kHRvb6oPQpIcwt52tAgD30YVSDpf+p1Bn/EUnyz6P2ji3tH0C03P/O53/96bCUw16ljap4GEyqspsTpfkXfxrdCD3S854clXSwkS1BQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nc9oRtRt; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nc9oRtRt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709315808; x=1740851808; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VrL8Wgn7VCCPQmOga0aArrh/XkhN1vzXIcht0JUG/ec=; b=nc9oRtRtLSdUwG9nGC3nMHDuukoKxVkVLW7cj4kUi+nK5DHRhpRjoXLX +Lf64mitBtwEKmdjQwHeM1r8WUKFY5wej99AKxl8bHr1pj9e+0zVpjl87 4AhfhGlxTVVuXeFKa3/f66oYKT1aHk08zQyDmVCHNynuAyxPHneGek4Lh 0zbgmJeNQLIuVbHNznuzv6LguV1cLuaR7NlZaZApus/VE+6u36VhiKJkA kVIYIj7Xz+N1vPj+aMk1/VSRa/O4uRJoSjiisqSEuEt6BNK+DJkdv70VB ESn3OTJ3cvPM/kqpIP2RfdmQ9HfI+PG5G9DGOXPZE0EeSEQX2px4TM1GF Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11000"; a="7684223" X-IronPort-AV: E=Sophos;i="6.06,196,1705392000"; d="scan'208";a="7684223" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2024 09:56:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11000"; a="937037839" X-IronPort-AV: E=Sophos;i="6.06,196,1705392000"; d="scan'208";a="937037839" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 01 Mar 2024 09:56:43 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id D5BA91A5; Fri, 1 Mar 2024 19:56:42 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Andrew Morton , Philipp Stanner Subject: [PATCH v3 1/2] devres: Switch to use dev_err_probe() for unification Date: Fri, 1 Mar 2024 19:55:36 +0200 Message-ID: <20240301175641.270020-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240301175641.270020-1-andriy.shevchenko@linux.intel.com> References: <20240301175641.270020-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_*() APIs are supposed to be called during the ->probe() stage. Many drivers (especially new ones) have switched to use dev_err_probe() for error messaging for the sake of unification. Let's do the same in the devres APIs. Reviewed-by: Philipp Stanner Signed-off-by: Andy Shevchenko --- lib/devres.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/lib/devres.c b/lib/devres.c index c44f104b58d5..f38e8297ad5a 100644 --- a/lib/devres.c +++ b/lib/devres.c @@ -125,12 +125,13 @@ __devm_ioremap_resource(struct device *dev, const str= uct resource *res, resource_size_t size; void __iomem *dest_ptr; char *pretty_name; + int ret; =20 BUG_ON(!dev); =20 if (!res || resource_type(res) !=3D IORESOURCE_MEM) { - dev_err(dev, "invalid resource %pR\n", res); - return IOMEM_ERR_PTR(-EINVAL); + ret =3D dev_err_probe(dev, -EINVAL, "invalid resource %pR\n", res); + return IOMEM_ERR_PTR(ret); } =20 if (type =3D=3D DEVM_IOREMAP && res->flags & IORESOURCE_MEM_NONPOSTED) @@ -144,20 +145,20 @@ __devm_ioremap_resource(struct device *dev, const str= uct resource *res, else pretty_name =3D devm_kstrdup(dev, dev_name(dev), GFP_KERNEL); if (!pretty_name) { - dev_err(dev, "can't generate pretty name for resource %pR\n", res); - return IOMEM_ERR_PTR(-ENOMEM); + ret =3D dev_err_probe(dev, -ENOMEM, "can't generate pretty name for reso= urce %pR\n", res); + return IOMEM_ERR_PTR(ret); } =20 if (!devm_request_mem_region(dev, res->start, size, pretty_name)) { - dev_err(dev, "can't request region for resource %pR\n", res); - return IOMEM_ERR_PTR(-EBUSY); + ret =3D dev_err_probe(dev, -EBUSY, "can't request region for resource %p= R\n", res); + return IOMEM_ERR_PTR(ret); } =20 dest_ptr =3D __devm_ioremap(dev, res->start, size, type); if (!dest_ptr) { - dev_err(dev, "ioremap failed for resource %pR\n", res); devm_release_mem_region(dev, res->start, size); - dest_ptr =3D IOMEM_ERR_PTR(-ENOMEM); + ret =3D dev_err_probe(dev, -ENOMEM, "ioremap failed for resource %pR\n",= res); + return IOMEM_ERR_PTR(ret); } =20 return dest_ptr; --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 10:08:36 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C04BB1170B for ; Fri, 1 Mar 2024 17:56:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709315807; cv=none; b=dknMGHslK8pOuXH2pZVJAgjm2X8ysovt5epM/nn+X7/q+s2JmPq/kxO5NaIHHSmrb3tTyGTqa5xZyLsqY6H9maSns9/FENCIFqd4tkXDF8qhHqUupO+HA9ukKaUMjW0GOZKllAaZHfp4h4nPz8HexthiKyYqB9ORtfSma3QVnJE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709315807; c=relaxed/simple; bh=h0960NSguWrPaEycEOjNIABQvoLMiDK9fkMLb1z/Dyw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EEA7/pA8CuiC5GD28p97pw6nqbAbgJUkGbp1LYpttpLBFgIzgb50GrKVRHwoUB2SK0yp96kFduDnO2ImiEYpHhl8RgC0gFH/eO4lq1n/YWF1l+Df/htItHEYs/1gTTmVBx0IoYNT9+5fyyA5aXGtDszRVqkThL3TSoK5v7s5Gnc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LpcrB3wv; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LpcrB3wv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709315806; x=1740851806; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=h0960NSguWrPaEycEOjNIABQvoLMiDK9fkMLb1z/Dyw=; b=LpcrB3wvqAxuxA3D3HMdXhBLKlPO0+Ff++Sc/n4wfPmBcebbCaucAgXh J6+w3/aNTz3nj/3E8+tsbAkGX0o+05LC3HEpHVaEHzq0MIDhR69iiF/MR k0oqNCw6nd3f3qfbj0Yizje3zFpBBDQ3y9mCkO88D7n7AWF0TiaOpqNOg 6irsj1mxvSpeRgo6Q34f69vtnAPwJDs0D99mtx6QKBBRCNEsyeMxzU/Bg o44K5Q2TNJN15mbdysNse4Sjxezi5UcKhQtiGYxgGwIXcF3/iCFa0Ghp7 askLe3QEaHG3j9VT+4WGg4ndkFMMKAGL0ijdWkyLhztzAauM2imBvxH6U g==; X-IronPort-AV: E=McAfee;i="6600,9927,11000"; a="7684219" X-IronPort-AV: E=Sophos;i="6.06,196,1705392000"; d="scan'208";a="7684219" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2024 09:56:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11000"; a="937037840" X-IronPort-AV: E=Sophos;i="6.06,196,1705392000"; d="scan'208";a="937037840" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 01 Mar 2024 09:56:43 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id E38075F5; Fri, 1 Mar 2024 19:56:42 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Andrew Morton Subject: [PATCH v3 2/2] devres: Don't use "proxy" headers Date: Fri, 1 Mar 2024 19:55:37 +0200 Message-ID: <20240301175641.270020-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240301175641.270020-1-andriy.shevchenko@linux.intel.com> References: <20240301175641.270020-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Update header inclusions to follow IWYU (Include What You Use) principle. Signed-off-by: Andy Shevchenko --- lib/devres.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/devres.c b/lib/devres.c index f38e8297ad5a..f4b72ad812b5 100644 --- a/lib/devres.c +++ b/lib/devres.c @@ -1,10 +1,14 @@ // SPDX-License-Identifier: GPL-2.0 -#include -#include -#include -#include +#include +#include +#include #include +#include +#include +#include +#include #include +#include =20 enum devm_ioremap_type { DEVM_IOREMAP =3D 0, --=20 2.43.0.rc1.1.gbec44491f096