From nobody Sun Feb 8 03:26:59 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 955812E83C for ; Thu, 29 Feb 2024 02:43:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174615; cv=none; b=WO5u8lJgnFfVRqKyyY1kd+nPJ0qKMMtNOqKfq86vTyCRNGDBYjCyPkKCGNTKEgzvUcrFNZcYsNZ0k3xVAIuaSrYMl6BydJWUiQoueaB+MsxvQvxBYjuZas0t3SWP/QX+uM9GQqSBVnCrAd3PI8nHptPFrKkPpLTgw4OEOaMIB5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174615; c=relaxed/simple; bh=lqZNS1yOfEcElef9Qbe+fs/5cHUb7qamtig04WByLuI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VS4nT1PLB6QgZFxHmRx8Whuu6Idq5cnRtepe7W0afoZWY/SCpfIYFU3GBPYoOTkwtzaDC6c3CM/uTI/RwCklEfPK1gJAJ2n/6yRwhxmp8yow2rjcG3gOzPhCJZkvdvfWF/dNW17Tl9WDJSRIezK9PMu7J6XHt4OeIP8MZoenOz4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=JthqzdTr; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="JthqzdTr" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6e572dbbc5cso354225b3a.0 for ; Wed, 28 Feb 2024 18:43:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1709174613; x=1709779413; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dShJe/rHC9hLgh7lahofGuPzHasSme7uCfvioaO2S60=; b=JthqzdTrXDR9onAM66fDDO98gO6Uu382zM7L4NpeU5K4wssaIYMBKZvNjtLjZaun10 dTvtOUPjoFkGAKwMAPn4gUizsBl0SweT33OrQjGTxM2KXUwBH3JwodiMxvp1hj7d/kCy eM9FfCOMXUf6f267Su96TvzDsRsHHDFSs5p/8VGH9RYK9j3WOua9vcSkvxy+1A44eiHv MVlisfxo+fP78Md3RsHconHUC6cYUBAE/M8sJnim03nQALmSVs80NErZrsToSSfZHpO1 LiBw2gYLCTsZmNH24hjFbGvNnuErEmuyIU2ELJJu4O2ss49Qfalq33lFqlSbjMbP75Bn Tllw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709174613; x=1709779413; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dShJe/rHC9hLgh7lahofGuPzHasSme7uCfvioaO2S60=; b=ePWdQjQMTFIKvkjihAAH2qI+MT2mJveb8Q1aU9nmx8cYb4glnhoTCkXRVLvbKHyPjh cxCjj3VbnDe0mTH9pqndTWtVJRiTkrDUA/J1Q67akabXXNlpOwkOSN/efGnLiiOp9a9S 0FiDQN2u+m0aubrJhza0kP7m6qQv6C2IxZDP3/YTmm9jAGOxrn5/Pp4TVtyZSIZYRN7r 0C7co7VNOVLQ5WaFvgYIR2IVRp59qhby/oRQyyDZsqKYFIRi+/SCGB5lATohZ+LOrTde RBWZ3YfWZaL6d4nUwnCzs/ayNJw5hs6yWM9xtg5AXB4QQfg4t/Av74SPBkz3EotlDvo2 zzDg== X-Forwarded-Encrypted: i=1; AJvYcCWN8mxMHJhPE6MqWjWvL2h+SLObYTEgqDzjX5xcRrZ2AjeB/eDveI7TEbJrUqYYt1XslLa6ybHtUw1kSAQvOQMdvtJLUjsO7xFhx2RP X-Gm-Message-State: AOJu0YzrYYk8HHAjY16kKRnJi26DszDOJTZSSrzblYhNyjNIz3fK3m0P esUDSk0jcxvMsD09ak1Q2KM+V5WX7jiZhM3R5skgHuqTg15bHfayVH/1ZDe7VSc= X-Google-Smtp-Source: AGHT+IHWPijZiBcr6DQ1BP47hzg2vlZk5MSQHoZH2xOBXWCY/ExqymD16AkhD2pptmMe/dhiPqxmyg== X-Received: by 2002:a05:6a00:998:b0:6e5:3f63:8eb8 with SMTP id u24-20020a056a00099800b006e53f638eb8mr844841pfg.14.1709174612871; Wed, 28 Feb 2024 18:43:32 -0800 (PST) Received: from oatmeal.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id u23-20020aa78497000000b006e5092fb3efsm141504pfn.159.2024.02.28.18.43.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 18:43:32 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 1/8] Staging: rtl8192e: Fix 5 chckpatch alignment warnings in rtl819x_BAProc.c Date: Wed, 28 Feb 2024 18:43:18 -0800 Message-Id: <20240229024325.453374-2-tdavies@darkphysics.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240229024325.453374-1-tdavies@darkphysics.net> References: <20240229024325.453374-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add tabs and spaces to fix checkpatch warning: 'Alignment should match open parenthesis' Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- v2: no changes drivers/staging/rtl8192e/rtl819x_BAProc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index bd1d86e0323d..c06633867641 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -254,7 +254,7 @@ int rtllib_rx_add_ba_req(struct rtllib_device *ieee, st= ruct sk_buff *skb) goto OnADDBAReq_Fail; } if (!rtllib_get_ts(ieee, (struct ts_common_info **)&ts, dst, - (u8)(ba_param_set->field.tid), RX_DIR, true)) { + (u8)(ba_param_set->field.tid), RX_DIR, true)) { rc =3D ADDBA_STATUS_REFUSED; netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__); goto OnADDBAReq_Fail; @@ -277,7 +277,7 @@ int rtllib_rx_add_ba_req(struct rtllib_device *ieee, st= ruct sk_buff *skb) ba->ba_start_seq_ctrl =3D *ba_start_seq_ctrl; =20 if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev) || - (ieee->ht_info->iot_action & HT_IOT_ACT_ALLOW_PEER_AGG_ONE_PKT)) + (ieee->ht_info->iot_action & HT_IOT_ACT_ALLOW_PEER_AGG_ONE_PKT)) ba->ba_param_set.field.buffer_size =3D 1; else ba->ba_param_set.field.buffer_size =3D 32; @@ -338,7 +338,7 @@ int rtllib_rx_add_ba_rsp(struct rtllib_device *ieee, st= ruct sk_buff *skb) } =20 if (!rtllib_get_ts(ieee, (struct ts_common_info **)&ts, dst, - (u8)(ba_param_set->field.tid), TX_DIR, false)) { + (u8)(ba_param_set->field.tid), TX_DIR, false)) { netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__); reason_code =3D DELBA_REASON_UNKNOWN_BA; goto OnADDBARsp_Reject; @@ -433,7 +433,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct = sk_buff *skb) struct rx_ts_record *ts; =20 if (!rtllib_get_ts(ieee, (struct ts_common_info **)&ts, dst, - (u8)del_ba_param_set->field.tid, RX_DIR, false)) { + (u8)del_ba_param_set->field.tid, RX_DIR, false)) { netdev_warn(ieee->dev, "%s(): can't get TS for RXTS. dst:%pM TID:%d\n", __func__, dst, @@ -446,7 +446,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct = sk_buff *skb) struct tx_ts_record *ts; =20 if (!rtllib_get_ts(ieee, (struct ts_common_info **)&ts, dst, - (u8)del_ba_param_set->field.tid, TX_DIR, false)) { + (u8)del_ba_param_set->field.tid, TX_DIR, false)) { netdev_warn(ieee->dev, "%s(): can't get TS for TXTS\n", __func__); return -1; --=20 2.39.2 From nobody Sun Feb 8 03:26:59 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA8AF286A7 for ; Thu, 29 Feb 2024 02:43:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174616; cv=none; b=C0mbDqIdCQHBoJIqwpgmBHk8/nl6fGRF8wGAOre7HvkoP+vuqGis/xrQN4wdEILsyHZox1wXD1iO1dpWg/lOTKrZkjEL8SVZ5SNX9bi+EZ51a5YUgpCV3xTQAXZZ3db905bmibL80zXE2yypqOkqKq8WyL+lAB2QkCHJulYJJTs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174616; c=relaxed/simple; bh=srm/OFIg/q2IKVUnLLHmtPyC+Nces81JgQnlTjMD2dQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pfLoVZB6e16aEKr5rI02pRwZNSol9qCFtFdBOK7Vjl8XGIDYl7oitEkkDs0d+JPUWD/7I+1YgdiMWAYmSSERJKxNiH32rSHhdoU1IuXk5QtrhMe0LLcp8h4NoBMq4Ek8HGemK5ycwVloF7nAyVhVl0RH+CEREDZuZz0JWP+TKCs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=W1zUOW8a; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="W1zUOW8a" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6e57ab846a1so257793b3a.3 for ; Wed, 28 Feb 2024 18:43:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1709174614; x=1709779414; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SAMKnLLLOoIxypoohPMOXgHVsRQhwwvK6oUJPHvqkzw=; b=W1zUOW8a4EtbdUogvMBTmeuTGAGVRhjX7ooMolLxoA9Xvg/EHH+tuysMs2PytqF0qU KOqZde0QpLCR/1jG6wWcf8g+wFY0WNK/EISF3hZqXAAs3oBC9ilb1mwLSocmy4Lq+Xm0 5PX/t806YvngFM73Z6fUZbKagaO/i+tRrJU/97cq7HCPFwqGjI7oh3CvN6vt8+sAxx4M oQ3m5fWgRcQ1Iy1ILVvpV46Jkfo9pA3ZlMVzGWtHzvwLvOu4thl6admzDLz0k3JHKz9E yv/+gDiqp5lP8Bmhq65eOXvHGWDNZVnuf3RbgyJn6VfDyZA01ENdTOqoC0PWqem0O7LM 9cSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709174614; x=1709779414; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SAMKnLLLOoIxypoohPMOXgHVsRQhwwvK6oUJPHvqkzw=; b=tv8UvUnYfBR6xrfZU/4UdUex0Q2Hx9OfTi5yhU1uTTe5Txt1vkRwgo3d3QNYajfO9a WJ7pacc4LjgU9NrA2qV/y91sGYH8LkqheWeHKLI1qkfoB5TB8KkeXAZPhmZOtG/cb7Ug GFCMqr/kZQDUb9T2FXsFiem0Hrmp/LLHX1ula/cv5W7b3vZA2Wc2RuWMb8HgejM5hMGj ZbWIg/TdWGENacUTNhOVhPFvobyk2phXgRYLmmvm8tHTKdRB6iEj0YIOlgY9PBsJEcVr yzRqh6bhs7F6Cylpxw87Sw+jX00mNKB10mlkPbmBLr4RIxhrlUPb7lBQ4R1ZLmLNpX9p qMAg== X-Forwarded-Encrypted: i=1; AJvYcCVibYmp32GXDwrILxuLz2GCsbI0oR61LBqAUlTrPteOOTf4Wi/fednbBzEwg8ADvuWoQsY2MQH6jqCaSm8Qz76U8s1JP5DXd3361bUW X-Gm-Message-State: AOJu0Yxv+s/hSMbKDwh2ga1PxHrLTpZBdWgvbfh6ykkZp41dYiHIbCtJ ImMq9per022U3gMHVCOHAMXKvZq1TSXJ+osbEjcMlUSsn4vOxZVOt5DkNlw1QI8= X-Google-Smtp-Source: AGHT+IG4s25AhDsjSTjWYj7p2s1kxiOY3p6T3r9cEUYLMLQfKzmQxsorp4fRg7QZOGAEQ0pdN7mUgg== X-Received: by 2002:a05:6a00:80ce:b0:6e5:799b:17b3 with SMTP id ei14-20020a056a0080ce00b006e5799b17b3mr891299pfb.21.1709174614223; Wed, 28 Feb 2024 18:43:34 -0800 (PST) Received: from oatmeal.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id u23-20020aa78497000000b006e5092fb3efsm141504pfn.159.2024.02.28.18.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 18:43:33 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 2/8] Staging: rtl8192e: Rename variable TxRxSelect Date: Wed, 28 Feb 2024 18:43:19 -0800 Message-Id: <20240229024325.453374-3-tdavies@darkphysics.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240229024325.453374-1-tdavies@darkphysics.net> References: <20240229024325.453374-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable TxRxSelect to tx_rx_select to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- v2: no charges drivers/staging/rtl8192e/rtl819x_BAProc.c | 18 ++++++++--------- drivers/staging/rtl8192e/rtl819x_TSProc.c | 24 +++++++++++------------ drivers/staging/rtl8192e/rtllib.h | 4 ++-- 3 files changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index c06633867641..030e0a87c931 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -125,7 +125,7 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_devic= e *ieee, u8 *dst, =20 static struct sk_buff *rtllib_DELBA(struct rtllib_device *ieee, u8 *dst, struct ba_record *ba, - enum tr_select TxRxSelect, u16 reason_code) + enum tr_select tx_rx_select, u16 reason_code) { union delba_param_set del_ba_param_set; struct sk_buff *skb =3D NULL; @@ -139,7 +139,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_devic= e *ieee, u8 *dst, =20 memset(&del_ba_param_set, 0, 2); =20 - del_ba_param_set.field.initiator =3D (TxRxSelect =3D=3D TX_DIR) ? 1 : 0; + del_ba_param_set.field.initiator =3D (tx_rx_select =3D=3D TX_DIR) ? 1 : 0; del_ba_param_set.field.tid =3D ba->ba_param_set.field.tid; =20 skb =3D dev_alloc_skb(len + sizeof(struct ieee80211_hdr_3addr)); @@ -199,12 +199,12 @@ static void rtllib_send_ADDBARsp(struct rtllib_device= *ieee, u8 *dst, } =20 static void rtllib_send_DELBA(struct rtllib_device *ieee, u8 *dst, - struct ba_record *ba, enum tr_select TxRxSelect, + struct ba_record *ba, enum tr_select tx_rx_select, u16 reason_code) { struct sk_buff *skb; =20 - skb =3D rtllib_DELBA(ieee, dst, ba, TxRxSelect, reason_code); + skb =3D rtllib_DELBA(ieee, dst, ba, tx_rx_select, reason_code); if (skb) softmac_mgmt_xmit(skb, ieee); else @@ -486,9 +486,9 @@ void rtllib_ts_init_add_ba(struct rtllib_device *ieee, = struct tx_ts_record *ts, =20 void rtllib_ts_init_del_ba(struct rtllib_device *ieee, struct ts_common_info *ts_common_info, - enum tr_select TxRxSelect) + enum tr_select tx_rx_select) { - if (TxRxSelect =3D=3D TX_DIR) { + if (tx_rx_select =3D=3D TX_DIR) { struct tx_ts_record *ts =3D (struct tx_ts_record *)ts_common_info; =20 @@ -497,14 +497,14 @@ void rtllib_ts_init_del_ba(struct rtllib_device *ieee, (ts->tx_admitted_ba_record.b_valid) ? (&ts->tx_admitted_ba_record) : (&ts->tx_pending_ba_record), - TxRxSelect, DELBA_REASON_END_BA); - } else if (TxRxSelect =3D=3D RX_DIR) { + tx_rx_select, DELBA_REASON_END_BA); + } else if (tx_rx_select =3D=3D RX_DIR) { struct rx_ts_record *ts =3D (struct rx_ts_record *)ts_common_info; if (rx_ts_delete_ba(ieee, ts)) rtllib_send_DELBA(ieee, ts_common_info->addr, &ts->rx_admitted_ba_record, - TxRxSelect, DELBA_REASON_END_BA); + tx_rx_select, DELBA_REASON_END_BA); } } =20 diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rt= l8192e/rtl819x_TSProc.c index e9a193b5ab10..9903fe3f3c77 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -171,14 +171,14 @@ void rtllib_ts_init(struct rtllib_device *ieee) =20 static struct ts_common_info *SearchAdmitTRStream(struct rtllib_device *ie= ee, u8 *addr, u8 TID, - enum tr_select TxRxSelect) + enum tr_select tx_rx_select) { u8 dir; bool search_dir[4] =3D {0}; struct list_head *psearch_list; struct ts_common_info *pRet =3D NULL; =20 - if (TxRxSelect =3D=3D TX_DIR) { + if (tx_rx_select =3D=3D TX_DIR) { search_dir[DIR_UP] =3D true; search_dir[DIR_BI_DIR] =3D true; search_dir[DIR_DIRECT] =3D true; @@ -188,7 +188,7 @@ static struct ts_common_info *SearchAdmitTRStream(struc= t rtllib_device *ieee, search_dir[DIR_DIRECT] =3D true; } =20 - if (TxRxSelect =3D=3D TX_DIR) + if (tx_rx_select =3D=3D TX_DIR) psearch_list =3D &ieee->Tx_TS_Admit_List; else psearch_list =3D &ieee->Rx_TS_Admit_List; @@ -225,7 +225,7 @@ static void MakeTSEntry(struct ts_common_info *ts_commo= n_info, u8 *addr, } =20 bool rtllib_get_ts(struct rtllib_device *ieee, struct ts_common_info **ppT= S, - u8 *addr, u8 TID, enum tr_select TxRxSelect, bool bAddNewTs) + u8 *addr, u8 TID, enum tr_select tx_rx_select, bool bAddNewTs) { u8 UP =3D 0; struct qos_tsinfo tspec; @@ -265,7 +265,7 @@ bool rtllib_get_ts(struct rtllib_device *ieee, struct t= s_common_info **ppTS, } } =20 - *ppTS =3D SearchAdmitTRStream(ieee, addr, UP, TxRxSelect); + *ppTS =3D SearchAdmitTRStream(ieee, addr, UP, tx_rx_select); if (*ppTS) return true; =20 @@ -274,21 +274,21 @@ bool rtllib_get_ts(struct rtllib_device *ieee, struct= ts_common_info **ppTS, return false; } =20 - pUnusedList =3D (TxRxSelect =3D=3D TX_DIR) ? + pUnusedList =3D (tx_rx_select =3D=3D TX_DIR) ? (&ieee->Tx_TS_Unused_List) : (&ieee->Rx_TS_Unused_List); =20 - pAddmitList =3D (TxRxSelect =3D=3D TX_DIR) ? + pAddmitList =3D (tx_rx_select =3D=3D TX_DIR) ? (&ieee->Tx_TS_Admit_List) : (&ieee->Rx_TS_Admit_List); =20 - Dir =3D ((TxRxSelect =3D=3D TX_DIR) ? DIR_UP : DIR_DOWN); + Dir =3D ((tx_rx_select =3D=3D TX_DIR) ? DIR_UP : DIR_DOWN); =20 if (!list_empty(pUnusedList)) { (*ppTS) =3D list_entry(pUnusedList->next, struct ts_common_info, list); list_del_init(&(*ppTS)->list); - if (TxRxSelect =3D=3D TX_DIR) { + if (tx_rx_select =3D=3D TX_DIR) { struct tx_ts_record *tmp =3D container_of(*ppTS, struct tx_ts_record, @@ -321,11 +321,11 @@ bool rtllib_get_ts(struct rtllib_device *ieee, struct= ts_common_info **ppTS, } =20 static void RemoveTsEntry(struct rtllib_device *ieee, - struct ts_common_info *pTs, enum tr_select TxRxSelect) + struct ts_common_info *pTs, enum tr_select tx_rx_select) { - rtllib_ts_init_del_ba(ieee, pTs, TxRxSelect); + rtllib_ts_init_del_ba(ieee, pTs, tx_rx_select); =20 - if (TxRxSelect =3D=3D RX_DIR) { + if (tx_rx_select =3D=3D RX_DIR) { struct rx_reorder_entry *pRxReorderEntry; struct rx_ts_record *ts =3D (struct rx_ts_record *)pTs; =20 diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 8e2f27b98f30..bbea287df535 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1779,13 +1779,13 @@ void rtllib_ts_init_add_ba(struct rtllib_device *ie= ee, struct tx_ts_record *ts, u8 policy, u8 overwrite_pending); void rtllib_ts_init_del_ba(struct rtllib_device *ieee, struct ts_common_info *ts_common_info, - enum tr_select TxRxSelect); + enum tr_select tx_rx_select); void rtllib_ba_setup_timeout(struct timer_list *t); void rtllib_tx_ba_inact_timeout(struct timer_list *t); void rtllib_rx_ba_inact_timeout(struct timer_list *t); void rtllib_reset_ba_entry(struct ba_record *ba); bool rtllib_get_ts(struct rtllib_device *ieee, struct ts_common_info **ppT= S, u8 *addr, - u8 TID, enum tr_select TxRxSelect, bool bAddNewTs); + u8 TID, enum tr_select tx_rx_select, bool bAddNewTs); void rtllib_ts_init(struct rtllib_device *ieee); void TsStartAddBaProcess(struct rtllib_device *ieee, struct tx_ts_record *pTxTS); --=20 2.39.2 From nobody Sun Feb 8 03:26:59 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1141236AFE for ; Thu, 29 Feb 2024 02:43:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174619; cv=none; b=WYR/DR1D9yXee2qLowIKUkxm2mYGhpEWhiNvO/RIqBSDn9fN7xM6iTpiH2PKiDOUtBAqd/u3D/tvCp4YJJsVuND0zVlDMlarWNqHIlIsxKwnNyA7p0sbUVNE7GjliVeIuBenQ/0D9u4M0jU55GG+v/tlQ7L+CUlzSjV2K2OVyP0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174619; c=relaxed/simple; bh=F1ihdIW8vfyX3y6wO2jcGVCXQ20EA2UlCt9aoxu89jg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jtrwdIr+7dBpuL1Wei4buGfd6W2rUU+zN9HGGMhJ6p3CNkF6Yd/6u9zUQNxKMdua93DYTZOHSV1ErTH1neEONC+7OG+q1XsfdBUFa1WUvZBM/yzsk+G2HFx9N6QvIb5RY2voHVmH8vdxnaGbU9ys1AoL9fZzNsS+8V30wtmPr3Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=dTLHaCDV; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="dTLHaCDV" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6e58d259601so148804b3a.3 for ; Wed, 28 Feb 2024 18:43:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1709174615; x=1709779415; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gNnU7s6E97gQJp6cYkW4MWjfZimKMSlrbqPhhGmgBdY=; b=dTLHaCDV3sxyUkLsLb1s1vg+ygxjlbpfVsTmtUGSGY5KVYdEtjMDTy6u/JCevF5v1N NZonQGDcunG0qdtR23XBJtURCm18YJas4YkOxQvXFzyalr8cEiZBGHmgKPdrkWONdllu yELutproAlzTBBzuKt3QJd5Eg217KmHArUDlOP6GGA4UkY9kDpEaSTbxSXZ44TTDnkfr TuyRA3JasZ/yc8Votb3bHudiQmkQAMmr1Bhgn0hWCFT2r6A/E+aIQIZ7wSIbJaZAYwrB 4n8JJju5y7v6Ta43PnPsRpKbQvhXo2JSDwaWmZSve1Rz8Pb0rW1FJEZY7GTM7FVkDiWz AXog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709174615; x=1709779415; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gNnU7s6E97gQJp6cYkW4MWjfZimKMSlrbqPhhGmgBdY=; b=mQBFxIx34d1jOlGfDePDXNq2kKnRGsQh7MEW0KioW4d5bHYq0NE4m8Rzx/BbEJzzIO x6N8yfhWOW9vVlV/O8A4wyLoGb+QDqmDiNpWycjZX4LJ4inALjBupygM6ujWVBrUePrQ 6bqgjbI7uqemd0PL/35jvAkrPUCWZBgaOBsPNFTG8D/WaPLvt8hJf7qRGQOec/+Q1Ck3 yVtXbhwZBxZgzE2ACaFoYBHUkhpkZ8PU4/5xWjRBezW+MUkM4WJgyuXygLGv0yoG0CuJ nuf3idez6ASCsFKdLOam7FM8DDeRap/7ORaGILr8+OAKa3AvqpQL7yXcPGxHbd6+Q4/f rRuA== X-Forwarded-Encrypted: i=1; AJvYcCXx9XQLzfqerIm4e98XVi18RazAKfAjiVQRiDXRD+o5CxmEPwiduHyjrJC5XdsRqumIpeKKyrTIcr9+ivndJREdfSF77zmBrzehshob X-Gm-Message-State: AOJu0YywVV4vpfhBqJVGFyyxN3aPL/sy7AWIQs2+LXhj9teDHUMUn7vf E4J++YFuvq6PQpN32vSJhJAYKZVgo932mG8vI4oEaszYHn32ZoBRbiJFja2Sye0= X-Google-Smtp-Source: AGHT+IHMTsOxx73ulz3UbIiLluQkOVI4rTeaxBtTz6J4PniE7ZxUgLejbee0Eot7YwVRKHTEC9lP9g== X-Received: by 2002:a05:6a00:bd7:b0:6e5:58cf:89b7 with SMTP id x23-20020a056a000bd700b006e558cf89b7mr871325pfu.4.1709174615438; Wed, 28 Feb 2024 18:43:35 -0800 (PST) Received: from oatmeal.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id u23-20020aa78497000000b006e5092fb3efsm141504pfn.159.2024.02.28.18.43.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 18:43:34 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 3/8] Staging: rtl8192e: Rename function rtllib_send_ADDBAReq() Date: Wed, 28 Feb 2024 18:43:20 -0800 Message-Id: <20240229024325.453374-4-tdavies@darkphysics.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240229024325.453374-1-tdavies@darkphysics.net> References: <20240229024325.453374-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename function rtllib_send_ADDBAReq to rtllib_send_add_ba_req to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- v2: no changes drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 030e0a87c931..1aa57f654b82 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -173,8 +173,8 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_devic= e *ieee, u8 *dst, return skb; } =20 -static void rtllib_send_ADDBAReq(struct rtllib_device *ieee, u8 *dst, - struct ba_record *ba) +static void rtllib_send_add_ba_req(struct rtllib_device *ieee, u8 *dst, + struct ba_record *ba) { struct sk_buff *skb; =20 @@ -481,7 +481,7 @@ void rtllib_ts_init_add_ba(struct rtllib_device *ieee, = struct tx_ts_record *ts, =20 activate_ba_entry(ba, BA_SETUP_TIMEOUT); =20 - rtllib_send_ADDBAReq(ieee, ts->ts_common_info.addr, ba); + rtllib_send_add_ba_req(ieee, ts->ts_common_info.addr, ba); } =20 void rtllib_ts_init_del_ba(struct rtllib_device *ieee, --=20 2.39.2 From nobody Sun Feb 8 03:26:59 2026 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46323374F9 for ; Thu, 29 Feb 2024 02:43:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174619; cv=none; b=fpI5Vavqbm/8FdfQgUWEyNPnz6XRXwJmipYkhAQmY+0l10vk15+QvKe80y41EAcPt9Cc0QrNJrnOfjUb38Yil2EGcS2fc0GuYj+Z9Z9YOKnqxmLqKnOoZPCjYH3wMlQ+CoxoaBQwtYrmf3B/xpBor6jSKm/QnWooRV+rzXpZELs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174619; c=relaxed/simple; bh=4I+zA2OHqdaTai+sBYLEWhHGVtuBmrKy4YAOKKQRL/s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KEsycAkafAWNXmlRAl6w38D+F9FVVJiGkci6wGOxNhqOn5EXR01fXLvPfJADykyKJKub0GDbZ2nUsml6yqGXEpdL0t18ih8j9l/OZo5H7SDxBHKnTDyVDzpLKBQ+z1gUIgHOjDuqFPkYtvGqw675pnEMiFSkg4aaPNwhvHpYzE0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=NQaK3Ce5; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="NQaK3Ce5" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3c1a172e46bso272405b6e.3 for ; Wed, 28 Feb 2024 18:43:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1709174616; x=1709779416; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t9egZkWmt+2eeqbBOMS0LFoFIMdDQ6t+XNJEpny2uS4=; b=NQaK3Ce5BBiWmskNTWl8B1NCXks5btSoxJyLczEd62ZFiZ2pBsRox0wCMMNWWLZqp/ MBOzcoc9GMGxlvCAieOeIEhq/uL+/ZP2uj9pc/M/CYyTPJOEYVG0rhxyXqsS+zznxnt8 NcJt5bQhBKZi0YcV3yXszNX6DFTwjKQZFoq9qsOd9VqozWYMffd06lNcwOvngXoHh6b0 wvb9uM/OxGvOVuqRyXfyMR5BUJsX4EqddQwiQV4cMaOlIJijdAcmD/VJcmgM8HXECYo9 NJi44pOV45Oyn7YSsMmSr7297wj2y5reKmkoC5Avt9ktWIvTeKR461BLKAVQ7nbrqSzF /PtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709174616; x=1709779416; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t9egZkWmt+2eeqbBOMS0LFoFIMdDQ6t+XNJEpny2uS4=; b=uLF04hDVqfIYb3gApcpfALCBHqOVxhpphtNobLyELISCjo421+tIAxevJlBy5Q4h1u tMOFnYKiHgOPTUQ8xrFNBqcwHAuc33mlXAkXmci1wKP44OPa7HFHuTP+eVHHOzpMUnIt Hl7a9x5IVk/Cu/ZGrXuVF6k1Swc3JmqTcx2KpAhY/Aa3x8KVnLdHBTvTCaAfbao0ACXB MnS+KujsLi30JV+IxzF2KRAeux4LcJWtCieWi0YFiBKBLdy28WA/aJottBgVJFRR5Eet DrgFIUWV85NoGjSSwZRKKuN50M/zFTBtxSdaW4Zp23vOA+NTMzU5+fHY/0yKAtQMvkU/ DJig== X-Forwarded-Encrypted: i=1; AJvYcCU6zEr9f7Lx1M6tYXxH755t/2y/9CxD9mhtM4/yAR9Z5ZFrsK37W7PopQvdkHo/47CPWLiEzrRqUvd+ivbL/ppMxMLUk1XwnWQVEWrz X-Gm-Message-State: AOJu0YwMGsFliXRJIiiBvq/CcaXlrUuRa7tdf9roFEdJEfPphhuPyYej jJqLXYOqyV3SzXCJn85Gju9ghQI25J3f6v8v8D7v1sSbwWcydb46Jr0DJ7Ca+K0wSSHM34Sv+AU j X-Google-Smtp-Source: AGHT+IHIbAPIDs71tFfyDPKjn9ApcIM6xi3nbM6oU0uYbTPHLkzfl7xSSt1LzulqUUWZ2S6mAbAJlQ== X-Received: by 2002:a05:6808:1302:b0:3c1:c36e:9ed2 with SMTP id y2-20020a056808130200b003c1c36e9ed2mr934199oiv.36.1709174616381; Wed, 28 Feb 2024 18:43:36 -0800 (PST) Received: from oatmeal.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id u23-20020aa78497000000b006e5092fb3efsm141504pfn.159.2024.02.28.18.43.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 18:43:36 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 4/8] Staging: rtl8192e: Rename function rtllib_send_ADDBARsp() Date: Wed, 28 Feb 2024 18:43:21 -0800 Message-Id: <20240229024325.453374-5-tdavies@darkphysics.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240229024325.453374-1-tdavies@darkphysics.net> References: <20240229024325.453374-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename function rtllib_send_ADDBARsp to rtllib_send_add_ba_rsp to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- v2: no changes drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 1aa57f654b82..c0006daa75ec 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -186,8 +186,8 @@ static void rtllib_send_add_ba_req(struct rtllib_device= *ieee, u8 *dst, netdev_dbg(ieee->dev, "Failed to generate ADDBAReq packet.\n"); } =20 -static void rtllib_send_ADDBARsp(struct rtllib_device *ieee, u8 *dst, - struct ba_record *ba, u16 status_code) +static void rtllib_send_add_ba_rsp(struct rtllib_device *ieee, u8 *dst, + struct ba_record *ba, u16 status_code) { struct sk_buff *skb; =20 @@ -283,7 +283,7 @@ int rtllib_rx_add_ba_req(struct rtllib_device *ieee, st= ruct sk_buff *skb) ba->ba_param_set.field.buffer_size =3D 32; =20 activate_ba_entry(ba, 0); - rtllib_send_ADDBARsp(ieee, dst, ba, ADDBA_STATUS_SUCCESS); + rtllib_send_add_ba_rsp(ieee, dst, ba, ADDBA_STATUS_SUCCESS); =20 return 0; =20 @@ -295,7 +295,7 @@ int rtllib_rx_add_ba_req(struct rtllib_device *ieee, st= ruct sk_buff *skb) BA.ba_timeout_value =3D *ba_timeout_value; BA.dialog_token =3D *dialog_token; BA.ba_param_set.field.ba_policy =3D BA_POLICY_IMMEDIATE; - rtllib_send_ADDBARsp(ieee, dst, &BA, rc); + rtllib_send_add_ba_rsp(ieee, dst, &BA, rc); return 0; } } --=20 2.39.2 From nobody Sun Feb 8 03:26:59 2026 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7DE236B16 for ; Thu, 29 Feb 2024 02:43:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174619; cv=none; b=LVbjr8I4l1kEMrnG3qfKGtCtsWyh20n3VSJycXTos3uHkRcUh1O2FKhww+8Lrc2kH54zBLgBh7IY/3i/ATEaSh0RB4686WcvrVg0ZcAG0UFfk2PbadjWNXTF1jV4EHEwliVpYtusv2UiuNF395ZuJmB2ZS7g0bTf7V9W2FropSs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174619; c=relaxed/simple; bh=TtPGBk36XpX3CmVxUVDkkA32ftSJsHAWNhFPZRbIGyc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SBT63IUpuXWWYgrbc2xI40eh+N7Y104kb14wLERxD7/0fJJxhnNcEbtd/GqUeTidLkWf0dsnCspCS9IES3MwfTwlsr+hKPU8+oTc92FdWvqG84JFhEUGQv+acZKZSCurM5WTN+qhzT7D+aJvNuXYsOcJG0YJT8S3nc0CJ18AAEY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=QX9UehVi; arc=none smtp.client-ip=209.85.166.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="QX9UehVi" Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-3651c1e1022so2492795ab.0 for ; Wed, 28 Feb 2024 18:43:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1709174617; x=1709779417; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FhfHq+TB9JfA9EoJNMTx1D1THIHV8qXBJRS7zjeQSzA=; b=QX9UehVivYX4JKsYd+FHiIwYqCU/EK0AZnEFakzbC1einYD/a1+8DoQNH1eTTXEBpU dBLF9AUxygVVhTl4yxslWWqqN2ZkAsCIpydtnqPy3HGWf0VqDmFiuYBqF8l52CkPeK2N bFwRy0/T49yT571HthEu0BYykyS6Vke85Tar8zH25WHNTTSmOEJk3JaDtr50k7anp6VL KvBEgz/uPrk/QQIDWiOa2K9+mZZdNoIo5Sgt0QGOI9tAvYAoQHMVlZCZ0WtfD3Troep8 PpAWWzOvF9Exzy1krGMcd+y0AFPmHUu5AfWxUyVMlUQM9b3WOgxYGbhZtlhnFWNLWpmw 8qHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709174617; x=1709779417; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FhfHq+TB9JfA9EoJNMTx1D1THIHV8qXBJRS7zjeQSzA=; b=O/OGRFkjFPVKR8xPox+mChgmlIZuaqDIrKx5GdCFPpl5Zkq81pyz6tFBfEcGywzPQm tnz3uedA3FQnNJvxGJ5mhlRx9ZMu1ojvVca5KvKDt13+UjVjIACHoTXj5sA+tG3afy3z MnwUsTf7NFSKmrhPjSp9lPPxnyE7YYvd8oYXKg8+lIgwWouo2x/o/2OTKJ5NpNONsxS7 /kgqzTDQcMuZdkqQEPsP/4Mad585zq0KcDgvI3q5gtjplimaMPf4L1P027VZpt9/ZyKJ gPfHLWPDQ5yKMduTG9yv6qroNgXn3ezqyggxPCLFqzgTZAZa/WX337VJWvjUJp9u/2y2 t2ew== X-Forwarded-Encrypted: i=1; AJvYcCXXfNNSgJ7t9c3sNAR7ceSf69/7HfGPt1T3gplYZXMmyX1kP6U5B4XQ0phdP+R3tuiIctyJo2wpDLR4HUd2LZ323WMR0m0ROGYTOXBc X-Gm-Message-State: AOJu0YxbQehpi0yQh8MJQJpRmhvC1/DYtC6yoUyJCJt2SzypKCINf0hL LNgE53+ENqDj3CnTHjjEVa1PjPDhUSNZxVKsomY74NCJef0g71IVGE+8DV08q78= X-Google-Smtp-Source: AGHT+IGQbkvRl6OZuvq4uMmwaSFBD56Nt80clHOrFAY3/gMfyXFQ//BdYzsq4OM/TELdk50TDDwuxw== X-Received: by 2002:a92:d988:0:b0:365:8513:b6b with SMTP id r8-20020a92d988000000b0036585130b6bmr1130962iln.29.1709174617086; Wed, 28 Feb 2024 18:43:37 -0800 (PST) Received: from oatmeal.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id u23-20020aa78497000000b006e5092fb3efsm141504pfn.159.2024.02.28.18.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 18:43:36 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 5/8] Staging: rtl8192e: Rename goto OnADDBAReq_Fail Date: Wed, 28 Feb 2024 18:43:22 -0800 Message-Id: <20240229024325.453374-6-tdavies@darkphysics.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240229024325.453374-1-tdavies@darkphysics.net> References: <20240229024325.453374-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename goto OnADDBAReq_Fail -> on_add_ba_req_fail to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- v2: no changes drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index c0006daa75ec..a3a2fe72d644 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -251,13 +251,13 @@ int rtllib_rx_add_ba_req(struct rtllib_device *ieee, = struct sk_buff *skb) "Failed to reply on ADDBA_REQ as some capability is not ready(%d, %= d)\n", ieee->current_network.qos_data.active, ieee->ht_info->current_ht_support); - goto OnADDBAReq_Fail; + goto on_add_ba_req_fail; } if (!rtllib_get_ts(ieee, (struct ts_common_info **)&ts, dst, (u8)(ba_param_set->field.tid), RX_DIR, true)) { rc =3D ADDBA_STATUS_REFUSED; netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__); - goto OnADDBAReq_Fail; + goto on_add_ba_req_fail; } ba =3D &ts->rx_admitted_ba_record; =20 @@ -265,7 +265,7 @@ int rtllib_rx_add_ba_req(struct rtllib_device *ieee, st= ruct sk_buff *skb) rc =3D ADDBA_STATUS_INVALID_PARAM; netdev_warn(ieee->dev, "%s(): BA Policy is not correct\n", __func__); - goto OnADDBAReq_Fail; + goto on_add_ba_req_fail; } =20 rtllib_FlushRxTsPendingPkts(ieee, ts); @@ -287,7 +287,7 @@ int rtllib_rx_add_ba_req(struct rtllib_device *ieee, st= ruct sk_buff *skb) =20 return 0; =20 -OnADDBAReq_Fail: +on_add_ba_req_fail: { struct ba_record BA; =20 --=20 2.39.2 From nobody Sun Feb 8 03:26:59 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3DE5381AF for ; Thu, 29 Feb 2024 02:43:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174620; cv=none; b=X/GpC42swrzvEvkEadyobRCO3z2JL2+ukD5Rlw1lgUN8Qdk1NbmSX8HERlSPS+vupdXs4MavlZNQThVMvRGezK+APSCGJpdLd5IxtrGgzUqgH2NMcWW7Czfzm2lNtDZ/1pyEbibI7RHL+CTgk00ajJp5usc4PzULudpRhOBpCX8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174620; c=relaxed/simple; bh=cMCQopxYgTxYu/0amwMiu8cgPaQ+iKgRIdpZaTrEX2g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uIu6XUj6VMBLkJHZXc8hUorTWrPY+EZfSUloq62j9K4K5R6AkUd0oX+w0W8AypIYJTv0WlbDWzg1rHRoHFkNJ9GU7/sKYVhTzfh+PKUIIjmpq9ZrpGzsiaqOfc/F4eZecmZyEiywzH7skfl0JJRXh0y4jF28zngOmIBDJde4HfA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=ZFtBw2Oc; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="ZFtBw2Oc" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6e581ba25e1so329204b3a.1 for ; Wed, 28 Feb 2024 18:43:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1709174618; x=1709779418; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1SNh7/XczwlcyfoaJTDElDItVS6jS2b6ony9kQsRUro=; b=ZFtBw2OcxI6t2KAhSTYju0slhpgFpu3oFL+EI++I3qJfV2+fU2lXini8uLgSGp6fce /EZeTI9q8uhFyc9p9G1gVhWQc9vP2tgLrWG4itsuvC0TOrJ+seYlJwz5FncafcIuM5zm cbs2X9qAOo/kCCbVotdzXKRNntyhrnkVPeLvPyO67OR5Ta38u2esI6dOwvrXMPdoNGvr kYIkDXdZIiTJH/Fy0k1K7R8IVvuH1NGDfnhy70w1t6WA3eERlrYu8Ye795ZyjfvXDA+0 dNQ+Zoe1ikQ06i4axlkep6EpjBMwiZdAkJVMGteSPnDMx6s0lpBIMXshA8VUCXByr0Ib xAbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709174618; x=1709779418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1SNh7/XczwlcyfoaJTDElDItVS6jS2b6ony9kQsRUro=; b=RSBcDX6YYt60hUXOE55eP9f00JMow8t8anZ25x0je9jftQgfDNww9fKn+rUVUfPUHv 2STzRQWc3XvVzTEzWyP7FJYAMMTabTgURqzQrkI0hyVcJpwiI8hnqSoBtvkab0/fOFHw y3FjsW8vTuLwkOwsgLN5NO0SZ3NZ4hHKd9Be1enaLbfpQy/TlwqDp2GrKGcVmb3WPJ7r vaQgrhHsJL4s+v6FF3alGa4HjmeYykYy7VWO1mAphJdSfojw07sTCjzdrYFOvmLb0p6i 5q2l57bpMRydcDGlfw17XOl0C0ZT2BJWbOTXrIQB5QtiFcjTXQnwYH0WJ8+Y8ldwdtmF lpPg== X-Forwarded-Encrypted: i=1; AJvYcCVu2E2cuKOyVMsWClpkxTFVQaQapmkOl4ksBwfVBzGVBR7hbnmloz+zQbXUWdwbdHQmfQkDicJ3Br+urU2EetOqoYlMZKV/VZ9Gqabv X-Gm-Message-State: AOJu0YwFVdIQGnuRYH/XwZ1YI/MOZRIfG/1gxwx+sE9hDi3WpX6RFRfL j3NfhT8mqIby8pcWp4TV62UV/4Ya+8/9s8P2sZJImVUYsImq6BJ4ZlzEdJCg7Zc= X-Google-Smtp-Source: AGHT+IFsh139gp84sHUup4ne0/pwHtdEtWANtNZz0UyWr8AIPlsZpo8fAZ63XIJ14ye3oYU8wy91LA== X-Received: by 2002:a05:6a00:22d0:b0:6e5:9688:8025 with SMTP id f16-20020a056a0022d000b006e596888025mr115514pfj.6.1709174617867; Wed, 28 Feb 2024 18:43:37 -0800 (PST) Received: from oatmeal.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id u23-20020aa78497000000b006e5092fb3efsm141504pfn.159.2024.02.28.18.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 18:43:37 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 6/8] Staging: rtl8192e: Rename goto OnADDBARsp_Reject Date: Wed, 28 Feb 2024 18:43:23 -0800 Message-Id: <20240229024325.453374-7-tdavies@darkphysics.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240229024325.453374-1-tdavies@darkphysics.net> References: <20240229024325.453374-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename goto OnADDBARsp_Reject -> on_add_ba_rsp_reject to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- v2: no changes drivers/staging/rtl8192e/rtl819x_BAProc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index a3a2fe72d644..0581ed1e9ed1 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -334,14 +334,14 @@ int rtllib_rx_add_ba_rsp(struct rtllib_device *ieee, = struct sk_buff *skb) ieee->ht_info->current_ht_support, ieee->ht_info->current_ampdu_enable); reason_code =3D DELBA_REASON_UNKNOWN_BA; - goto OnADDBARsp_Reject; + goto on_add_ba_rsp_reject; } =20 if (!rtllib_get_ts(ieee, (struct ts_common_info **)&ts, dst, (u8)(ba_param_set->field.tid), TX_DIR, false)) { netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__); reason_code =3D DELBA_REASON_UNKNOWN_BA; - goto OnADDBARsp_Reject; + goto on_add_ba_rsp_reject; } =20 ts->add_ba_req_in_progress =3D false; @@ -358,7 +358,7 @@ int rtllib_rx_add_ba_rsp(struct rtllib_device *ieee, st= ruct sk_buff *skb) "%s(): ADDBA Rsp. BA invalid, DELBA!\n", __func__); reason_code =3D DELBA_REASON_UNKNOWN_BA; - goto OnADDBARsp_Reject; + goto on_add_ba_rsp_reject; } else { netdev_dbg(ieee->dev, "%s(): Recv ADDBA Rsp. BA is admitted! Status code:%X\n", @@ -371,7 +371,7 @@ int rtllib_rx_add_ba_rsp(struct rtllib_device *ieee, st= ruct sk_buff *skb) ts->add_ba_req_delayed =3D true; deactivate_ba_entry(ieee, admitted_ba); reason_code =3D DELBA_REASON_END_BA; - goto OnADDBARsp_Reject; + goto on_add_ba_rsp_reject; } =20 admitted_ba->dialog_token =3D *dialog_token; @@ -384,12 +384,12 @@ int rtllib_rx_add_ba_rsp(struct rtllib_device *ieee, = struct sk_buff *skb) ts->add_ba_req_delayed =3D true; ts->disable_add_ba =3D true; reason_code =3D DELBA_REASON_END_BA; - goto OnADDBARsp_Reject; + goto on_add_ba_rsp_reject; } =20 return 0; =20 -OnADDBARsp_Reject: +on_add_ba_rsp_reject: { struct ba_record BA; =20 --=20 2.39.2 From nobody Sun Feb 8 03:26:59 2026 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D362383BE for ; Thu, 29 Feb 2024 02:43:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174621; cv=none; b=g+zSFRj443aD+BUO4EAtBiK2uxcKamhsz7p0TQ6HWXS6Fyo66EY7fupdj53IWNndMW7ijiG6iJ8i/pqRh/yQ3g19msHrAkbDcnH8COOoWtL/wS6QUrCBzgX2kOqmOLWAsvuIXm9bxGRmA6HLyTSyU9z5XvhznuWmAaaNPiN6sdQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174621; c=relaxed/simple; bh=Aphcsg+jCGb/G6Iku1F7m8eyfHQ8NCqN6UuzzT5jlXQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RwXpc4HyV6OY81krWgHqYAQsy6UicaE7lg+MtdE1lcq63uwKnf87pGynXJ9lqRSnQpCRvRVdm41No+doLXBJtg340y1RGk94nMAAJvGuhOuonO/7OoWwON/XjGD/xLk+gJDDSi9lQhgQnyUezM9trkSBMnwKP4CsyB4SHLXL4V4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=GpXCxyiK; arc=none smtp.client-ip=209.85.128.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="GpXCxyiK" Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-608959cfcbfso5384527b3.3 for ; Wed, 28 Feb 2024 18:43:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1709174619; x=1709779419; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E6Dy5NYh5SGhramiBXVD6CBtpLYzXUVrIG3KwaM2w2o=; b=GpXCxyiKGeeCTH7pSKEzIR1uOFhxGCKimuhg1jM8ce2fbCXxKHty/mPTYFJtBsTpeP dqRTU+8Z7+rj2S7gZvqr7NKO41SHxYff5ui2evU2adUskqR7QXZuoxbvswZsDd9ST5Rs jX0XhZkZL0gtA7mjhPyujR7bisLhXaesAl1zlo1XARANAYUiT0E2FrXmmQQYZ35N7eSX TziEXLYRgh5W3S6Jy6n9fJPv5pZaZJfKnQJAIpvfv9Xqru/cHp7qyQi0dNb4shss/JnX AdF9UyS0cDwZMD80S6Lah7eXq1R1snPMYapOAjZpvikMcWtAL6Vd1upH88YiCj0neQ+Y bo+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709174619; x=1709779419; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E6Dy5NYh5SGhramiBXVD6CBtpLYzXUVrIG3KwaM2w2o=; b=nOtiErHN/xCJ5dys5jfbNgZulDBNTn8Z7Chh684fyOgJ6iZHsLbuNTYY77TaV08P2/ LJc+i+YV6MdCamW13vUPRDZqOS/eODUMbItxuOacZ9416LtxfsBI3RGfD7KyLt81+aJi 7bocqGERD6rRDVFbjWLDMohG8KPuNTEIShCJuuRO+cSkSbDnfCGjhFWVJeKYi9gQDWtv BewfYLg1dlzRooi7HEG6TAFTR9obxDAHeZaAUXsecH4U8UH1tkQemLu0dYff6bwQuw7x BORTVSlEqc+FnlHJbE1XJIRoIxjNP/Dy+7W4Hz0/rcssA8mR/bubKHr2yvKdrUfLAKKa wSIw== X-Forwarded-Encrypted: i=1; AJvYcCWjJdn9iu2bOerQIifMJfxvx04fvkq/c3KeoO9Lpe/dpH70U6R8DnKBgMz63NaVlFI+gufzkJAAmmy8p9eJ6TiwVF8GkOaawAOrqlAE X-Gm-Message-State: AOJu0YyIxkWjkjUMEaLKZi40xwSFVBx/OR3eY5HXfCycVnvHs7LW546s rY8DbIilKji+pJ96ikedaPoDSu5dNX+UbfSMsNd/mSOeimCmv0KFV3CLteq3HT8= X-Google-Smtp-Source: AGHT+IFtGs97y0VMDfO2OhQB/ry3UAI4ptI/hO7uxjdRojwZWz8iiYnHMR7bQDffv5SgR7y3tY/Leg== X-Received: by 2002:a0d:dd16:0:b0:608:91d2:e927 with SMTP id g22-20020a0ddd16000000b0060891d2e927mr999220ywe.30.1709174619073; Wed, 28 Feb 2024 18:43:39 -0800 (PST) Received: from oatmeal.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id u23-20020aa78497000000b006e5092fb3efsm141504pfn.159.2024.02.28.18.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 18:43:38 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 7/8] Staging: rtl8192e: Rename function rtllib_FlushRxTsPendingPkts() Date: Wed, 28 Feb 2024 18:43:24 -0800 Message-Id: <20240229024325.453374-8-tdavies@darkphysics.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240229024325.453374-1-tdavies@darkphysics.net> References: <20240229024325.453374-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename function rtllib_FlushRxTsPendingPkts to rtllib_flush_rx_ts_pending_pkts to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- v2: Fix commit message 75 char limit, and alignment warning drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 0581ed1e9ed1..04f3fb54d1b7 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -268,7 +268,7 @@ int rtllib_rx_add_ba_req(struct rtllib_device *ieee, st= ruct sk_buff *skb) goto on_add_ba_req_fail; } =20 - rtllib_FlushRxTsPendingPkts(ieee, ts); + rtllib_flush_rx_ts_pending_pkts(ieee, ts); =20 deactivate_ba_entry(ieee, ba); ba->dialog_token =3D *dialog_token; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index bbea287df535..9d9420f7a371 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1811,8 +1811,8 @@ bool rtllib_mgnt_disconnect(struct rtllib_device *rtl= lib, u8 rsn); /* For the function is more related to hardware setting, it's better to us= e the * ieee handler to refer to it. */ -void rtllib_FlushRxTsPendingPkts(struct rtllib_device *ieee, - struct rx_ts_record *ts); +void rtllib_flush_rx_ts_pending_pkts(struct rtllib_device *ieee, + struct rx_ts_record *ts); int rtllib_parse_info_param(struct rtllib_device *ieee, struct rtllib_info_element *info_element, u16 length, diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 051371e0138c..06992450ef42 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -487,8 +487,8 @@ void rtllib_indicate_packets(struct rtllib_device *ieee, } } =20 -void rtllib_FlushRxTsPendingPkts(struct rtllib_device *ieee, - struct rx_ts_record *ts) +void rtllib_flush_rx_ts_pending_pkts(struct rtllib_device *ieee, + struct rx_ts_record *ts) { struct rx_reorder_entry *pRxReorderEntry; u8 RfdCnt =3D 0; --=20 2.39.2 From nobody Sun Feb 8 03:26:59 2026 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C5AD3BBCF for ; Thu, 29 Feb 2024 02:43:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174623; cv=none; b=Nr9yQkg4DNJrT+yBqRtNHV69h0ntVb93quMKQHqBCsFxvD09s1mNRX3857IewFLT0b1X3eeUutlIwMwecMDsFGfEfr44vw7S8IVI305UCSkpDeJIAH7ma6/cDgaiG3OZ/YRkAKMBoIzNwwmJHBzr2c9ROFERD9MteG6AbpATMV0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709174623; c=relaxed/simple; bh=3Bml3fisOhf12xoHuFgq9dvsIWbtNV/lOg2k7b3U5H4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LSHMRYsjwIwBBPDyg2orgQGWgJt2DNSyNPd5UWmDeKQ0BSbH+dyzgCb4cgOZ+6ye01zzMUI3qZDCf9Am+/tVY/jbsBoWIvgFeHfMEuEKHYvPbPkFpXFQRsRxn9bqgUDDIeBmjpL5Dw5ijQcvqUGOa3O5LL2Endl7Li8CXOAOsHE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=TgQOZxbL; arc=none smtp.client-ip=209.85.166.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="TgQOZxbL" Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-7c7f3f66d17so19602239f.0 for ; Wed, 28 Feb 2024 18:43:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1709174620; x=1709779420; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p0/Uo8bpOofX8j1GcCdenVCAyHrsJbHLlgNs8scFou8=; b=TgQOZxbL+79lTGwM2Zl8pEXWYom9hJA5OztW3zkIaiK3lxViPu0aY8K2q8LXOaMDfT h6MOkRuRuvfZn5Dd8s8j8aLJRzMUWHv1xx9kblr45h9SiAPV3htsF9eviXCkUEYQnqim kq96zYIYL1x0HI8mXJMYC2kvWXfJ+bk+PbRbH2Og+ej4CWcVuJfhP3Kmi2+7YSK68NZs zEVq1SGzigaa6ampzEF7kQ6sot+qIavrq8TNd7q/6cDWKE22UphXlNh2iyCkjY8ZrG8C 7XtaUSrNTxnrA48koJZgJZL4fLO3vHqa3EssEtpFwPOefk8jvXRbF15/67yoIXRVw0St vaWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709174620; x=1709779420; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p0/Uo8bpOofX8j1GcCdenVCAyHrsJbHLlgNs8scFou8=; b=nsMHCXA3Mai0999fZ3zMlEhzGcvPH0U5MppjbtL8x0ZBvRh/dKFHrJJnsShZm4xtlG 0xKuLS337/a/3ilUh+YoD2dUIlQ+qzul7DRDP7V+CgfJX7GiMmYJN4qXtaVNm8YNio1M aet55D4Ws9GDHl2FCC8xXLdr+gcH0X3lrerIqDQX1FqUliFtZ8L7AQZK1wsWRZN3osef vxxEE4uEQy6cZeQC8tA9MPf94thgIYK9iRdIBr9TQzCezW47mTK0Rrg2Ct0gn1gB/rHr zaMqgQUxYWLPp4eaVA/J3s+bKeDNgZguuLgLSCmVA4Pj8RHf2eE/Wvi70U8I/+T6fK0h YEpA== X-Forwarded-Encrypted: i=1; AJvYcCWSvkOsYZwhYZwivAum0zAAAl4MSyhSrzlXrK7AvFDGbKh/uoys5AMwsTy5oo/6V2WTr8lqJ/fsS0RbJgEMbazX+82SfobBF8Pn2wBL X-Gm-Message-State: AOJu0YwS+VRd1xVkXNX0QStv/ZZ5wd7QAlGu202XUyjjG38kqdOi/+IQ m3+GdKVZmFY4njNiN1jXLQIPA67WqxhuciO4rQmx6Ers8lVjKKxKlphytOmkYF8= X-Google-Smtp-Source: AGHT+IFHS+/I2I1geaDiHB0u47wojczAJlRr4O9aK0E5+a2fyLFbLDiHZLmrP7DZFQ/lEpHyiN1qfg== X-Received: by 2002:a92:c990:0:b0:365:1044:4dcd with SMTP id y16-20020a92c990000000b0036510444dcdmr1252439iln.16.1709174619962; Wed, 28 Feb 2024 18:43:39 -0800 (PST) Received: from oatmeal.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id u23-20020aa78497000000b006e5092fb3efsm141504pfn.159.2024.02.28.18.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 18:43:39 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 8/8] Staging: rtl8192e: Rename function GetHalfNmodeSupportByAPsHandler() Date: Wed, 28 Feb 2024 18:43:25 -0800 Message-Id: <20240229024325.453374-9-tdavies@darkphysics.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240229024325.453374-1-tdavies@darkphysics.net> References: <20240229024325.453374-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename function GetHalfNmodeSupportByAPsHandler to get_half_nmode_support_by_aps_handler to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- v2: Fix commit message 75 char limit drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 8 ++++---- drivers/staging/rtl8192e/rtllib.h | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index fc5014f719d7..50a4e1cb8c79 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -657,7 +657,7 @@ static void _rtl92e_init_priv_handler(struct net_device= *dev) priv->rtllib->ps_is_queue_empty =3D _rtl92e_is_tx_queue_empty; =20 priv->rtllib->get_nmode_support_by_sec_cfg =3D rtl92e_get_nmode_support_b= y_sec; - priv->rtllib->GetHalfNmodeSupportByAPsHandler =3D + priv->rtllib->get_half_nmode_support_by_aps_handler =3D rtl92e_is_halfn_supported_by_ap; =20 priv->rtllib->set_hw_reg_handler =3D rtl92e_set_reg; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index 57e1a361a7c9..047da39f730e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -354,7 +354,7 @@ static void _rtl92e_dm_check_rate_adaptive(struct net_d= evice *dev) } } =20 - if (priv->rtllib->GetHalfNmodeSupportByAPsHandler(dev)) + if (priv->rtllib->get_half_nmode_support_by_aps_handler(dev)) target_ratr &=3D 0xf00fffff; =20 current_ratr =3D rtl92e_readl(dev, RATR0); diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 04f3fb54d1b7..834329886ea2 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -276,7 +276,7 @@ int rtllib_rx_add_ba_req(struct rtllib_device *ieee, st= ruct sk_buff *skb) ba->ba_timeout_value =3D *ba_timeout_value; ba->ba_start_seq_ctrl =3D *ba_start_seq_ctrl; =20 - if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev) || + if (ieee->get_half_nmode_support_by_aps_handler(ieee->dev) || (ieee->ht_info->iot_action & HT_IOT_ACT_ALLOW_PEER_AGG_ONE_PKT)) ba->ba_param_set.field.buffer_size =3D 1; else diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index abc21ae49ff7..fa96a2c2c916 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -252,7 +252,7 @@ void ht_construct_capability_element(struct rtllib_devi= ce *ieee, u8 *pos_ht_cap, } =20 cap_ele->AdvCoding =3D 0; - if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) + if (ieee->get_half_nmode_support_by_aps_handler(ieee->dev)) cap_ele->ChlWidth =3D 0; else cap_ele->ChlWidth =3D 1; @@ -301,7 +301,7 @@ void ht_construct_capability_element(struct rtllib_devi= ce *ieee, u8 *pos_ht_cap, if (ht->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI) cap_ele->ShortGI40Mhz =3D 0; =20 - if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) { + if (ieee->get_half_nmode_support_by_aps_handler(ieee->dev)) { cap_ele->ChlWidth =3D 0; cap_ele->MCS[1] =3D 0; } @@ -408,7 +408,7 @@ static u8 ht_filter_mcs_rate(struct rtllib_device *ieee= , u8 *pSupportMCS, =20 ht_pick_mcs_rate(ieee, pOperateMCS); =20 - if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) + if (ieee->get_half_nmode_support_by_aps_handler(ieee->dev)) pOperateMCS[1] =3D 0; =20 for (i =3D 2; i <=3D 15; i++) @@ -666,7 +666,7 @@ void ht_set_connect_bw_mode(struct rtllib_device *ieee, { struct rt_hi_throughput *ht_info =3D ieee->ht_info; =20 - if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) + if (ieee->get_half_nmode_support_by_aps_handler(ieee->dev)) bandwidth =3D HT_CHANNEL_WIDTH_20; =20 if (ht_info->sw_bw_in_progress) { diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 9d9420f7a371..be2615bae6ca 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1486,7 +1486,7 @@ struct rtllib_device { enum ht_extchnl_offset Offset); bool (*get_nmode_support_by_sec_cfg)(struct net_device *dev); void (*set_wireless_mode)(struct net_device *dev, u8 wireless_mode); - bool (*GetHalfNmodeSupportByAPsHandler)(struct net_device *dev); + bool (*get_half_nmode_support_by_aps_handler)(struct net_device *dev); u8 (*rtllib_ap_sec_type)(struct rtllib_device *ieee); void (*init_gain_handler)(struct net_device *dev, u8 Operation); void (*ScanOperationBackupHandler)(struct net_device *dev, --=20 2.39.2