From nobody Sat Feb 7 19:41:38 2026 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFC0F139568; Tue, 27 Feb 2024 11:34:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709033684; cv=none; b=Wjf5uWpF9YxolDCHsFmu68wv79hcZnBwuPal5gs7u5Y2Zb8g8B8yIYGH42X1YfsMDXyyGg//vYyzS2pcP0O/4jrYKzETvRlWEYl1pgrtqPCrDLOuJO1yIZiT5rAdzHyY7A/pvxU5NWSe8rvYZ3dexZeFvyCXxgJP2CQk/OlPYNU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709033684; c=relaxed/simple; bh=kvF+KDgzeivY+RAQ8/BHt2sd41hOYzWE/MAHOlgwnpA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hF5EUpSK9UtWUFX4qy6wX3NFLdw8yfl/1K+FapfgJlSP28SFzc1fb0/2rqQBRF+nzkLr5ltKc2Xn62357sbGGJLbykhd32ua5/t5AkN2sjBuWGkeiW23kKYctTukReYyyUhtv0n7eYyYMijE7JoOkJb7joilqtigX2t7en3YTSc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=RNSH9eQ+; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="RNSH9eQ+" Received: by mail.gandi.net (Postfix) with ESMTPA id 04A831C000B; Tue, 27 Feb 2024 11:34:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709033674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JEy1WKZu79JY8RBIlDzPDmv8Cqag9mXrU8thTH54FTE=; b=RNSH9eQ+4yWnHnVtlpUJNgnp4s9B6XVqsh6exUAL1s6CqvR6ygkEsOH/dQOX/tE6eC/qFr LNMoKg7wTEhXQgA4XChpkYqs+LILCghDtZdR83mOjk0GJAyKs6FgHEotEEFASaW3bLUAmD aJgjIGeDSNCg8VI1xSF/d829mDK+ju2dP4dWYyNTVZZDI2NvMTxooFd4HzclQmz5NruFX6 /i1j+sL46YdFwwEp1uC8/ubaWfZIYGtNc4rsIE+Gp4L8tiBO0+N9dsE7OpgQOEybfKxPFS xn7hxpTDY5ob9FqApPkD8EIyUvSAbYM0pn9bDipErxQNZeUBLz5mybDXpbksiw== From: Herve Codina To: Bartosz Golaszewski , Kent Gibson , Linus Walleij Cc: Saravana Kannan , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Ceresoli , Thomas Petazzoni , Herve Codina Subject: [PATCH v2 1/2] gpiolib: call gcdev_unregister() sooner in the removal operations Date: Tue, 27 Feb 2024 12:34:24 +0100 Message-ID: <20240227113426.253232-2-herve.codina@bootlin.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240227113426.253232-1-herve.codina@bootlin.com> References: <20240227113426.253232-1-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: herve.codina@bootlin.com Content-Type: text/plain; charset="utf-8" When gpio chip device is removed while some related gpio are used by the user-space, the following warning can appear: remove_proc_entry: removing non-empty directory 'irq/233', leaking at lea= st 'gpiomon' WARNING: CPU: 2 PID: 72 at fs/proc/generic.c:717 remove_proc_entry+0x190/= 0x19c ... Call trace: remove_proc_entry+0x190/0x19c unregister_irq_proc+0xd0/0x104 free_desc+0x4c/0xc4 irq_free_descs+0x6c/0x90 irq_dispose_mapping+0x104/0x14c gpiochip_irqchip_remove+0xcc/0x1a4 gpiochip_remove+0x48/0x100 ... Indeed, the gpio cdev uses an IRQ but this IRQ is not released (irq_free() call) before the call to gpiochip_irqchip_remove(). In order to give a chance to the gpio dev driver to release this irq before removing the IRQ mapping, notify the cdev driver about the gpio device removal before the gpiochip_irqchip_remove() call. Signed-off-by: Herve Codina --- drivers/gpio/gpiolib.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 63e793a410e3..4ad3e260dec2 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1118,6 +1118,11 @@ void gpiochip_remove(struct gpio_chip *gc) /* Numb the device, cancelling all outstanding operations */ rcu_assign_pointer(gdev->chip, NULL); synchronize_srcu(&gdev->srcu); + /* + * Tell gcdev that the device is removing. If any gpio resources are in + * use (irqs for instance), it's time for gcdev to release them. + */ + gcdev_unregister(gdev); gpiochip_irqchip_remove(gc); acpi_gpiochip_remove(gc); of_gpiochip_remove(gc); @@ -1135,7 +1140,6 @@ void gpiochip_remove(struct gpio_chip *gc) * be removed, else it will be dangling until the last user is * gone. */ - gcdev_unregister(gdev); gpio_device_put(gdev); } EXPORT_SYMBOL_GPL(gpiochip_remove); --=20 2.43.0 From nobody Sat Feb 7 19:41:38 2026 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 744E0130ADF; Tue, 27 Feb 2024 11:34:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709033683; cv=none; b=NFeIgETMa2T3esTzYSq6yrgttcBiO0bINfbplsWly0G2IHVd/LsZch7Gr23/vgHv21x73cYmYHOn6nuMu88i9N4p8dQePS8YnsJJGmtdszgUWZGfNPVD5MrVTtTs4x1oAUfuOO0rahfcEvn2AfX2+jQvwt1aMMjqszNG6a+hDSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709033683; c=relaxed/simple; bh=Bg7CrCHk8qTVzw8D5kTnaxr6RqBt1zINI31UQ7JKYi4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HyUViIAaolpYHxK7FlW9l6OLO/dtDt3q28HZ2bl0mqBakhQrhMrBkxw6u58yH9mJv9WswRW7aLXXj9cKUnCt6OVdH9gfeFoHZjW/88Nd9CT7WJzjSUpxhfLRHprtuwcTJL2WNyIihPRR/WHMWf4mI9tk5CXUSmV2fPtQV9Icj+s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=MzHA2jzs; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="MzHA2jzs" Received: by mail.gandi.net (Postfix) with ESMTPA id 4176E1C0010; Tue, 27 Feb 2024 11:34:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709033678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q7WNC75978u3FnRvqua2g0x3X53QY3+13gx9/jOUJyE=; b=MzHA2jzsWuaKvAoMqzuVbPeM/fg/szQ9gQSyJdwcwimmuGWmR9iiA6pg8/A3bd7GP6HlqA FT7ofzCj8Dy9vRPQ2o2fKZjt4iYuuyEFn68ulBj9uvc/upMmhJwF7u7RT3phD9sYdFXHqI A0XuAvfXCVefPUH48olX2YcNxAHeo0FKbqE1iBh5fh9H5DUFwwvvlV317/p2+/zm32yb0i L/gg+5t2y9vvmGAMXW32BGDOAtuJdrSnBkcyvbchPbbOEfDObKItUXThnX8GAJGHUNOGtv R3HuO7IxIZ2U3cHrxGeoo0Y2euPdNvZJSrgf1sKnKkk6a6bsb804KhiIY/eJEg== From: Herve Codina To: Bartosz Golaszewski , Kent Gibson , Linus Walleij Cc: Saravana Kannan , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Ceresoli , Thomas Petazzoni , Herve Codina Subject: [PATCH v2 2/2] gpiolib: cdev: release IRQs when the gpio chip device is removed Date: Tue, 27 Feb 2024 12:34:25 +0100 Message-ID: <20240227113426.253232-3-herve.codina@bootlin.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240227113426.253232-1-herve.codina@bootlin.com> References: <20240227113426.253232-1-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: herve.codina@bootlin.com Content-Type: text/plain; charset="utf-8" When gpio chip device is removed while some related gpio are used by the user-space, the following warning can appear: remove_proc_entry: removing non-empty directory 'irq/233', leaking at lea= st 'gpiomon' WARNING: CPU: 2 PID: 72 at fs/proc/generic.c:717 remove_proc_entry+0x190/= 0x19c ... Call trace: remove_proc_entry+0x190/0x19c unregister_irq_proc+0xd0/0x104 free_desc+0x4c/0xc4 irq_free_descs+0x6c/0x90 irq_dispose_mapping+0x104/0x14c gpiochip_irqchip_remove+0xcc/0x1a4 gpiochip_remove+0x48/0x100 ... Indeed, the gpio cdev uses an IRQ but this IRQ is not released when the gpio chip device is removed. Release IRQs used in the device removal notifier functions. Also move one of these function definition in order to avoid a forward declaration (move after the edge_detector_stop() definition). Signed-off-by: Herve Codina --- drivers/gpio/gpiolib-cdev.c | 33 ++++++++++++++++++++++----------- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c index f384fa278764..96c05bd326d0 100644 --- a/drivers/gpio/gpiolib-cdev.c +++ b/drivers/gpio/gpiolib-cdev.c @@ -682,17 +682,6 @@ static void line_set_debounce_period(struct line *line, GPIO_V2_LINE_FLAG_EVENT_CLOCK_HTE | \ GPIO_V2_LINE_EDGE_FLAGS) =20 -static int linereq_unregistered_notify(struct notifier_block *nb, - unsigned long action, void *data) -{ - struct linereq *lr =3D container_of(nb, struct linereq, - device_unregistered_nb); - - wake_up_poll(&lr->wait, EPOLLIN | EPOLLERR); - - return NOTIFY_OK; -} - static void linereq_put_event(struct linereq *lr, struct gpio_v2_line_event *le) { @@ -1183,6 +1172,23 @@ static int edge_detector_update(struct line *line, return edge_detector_setup(line, lc, line_idx, edflags); } =20 +static int linereq_unregistered_notify(struct notifier_block *nb, + unsigned long action, void *data) +{ + struct linereq *lr =3D container_of(nb, struct linereq, + device_unregistered_nb); + int i; + + for (i =3D 0; i < lr->num_lines; i++) { + if (lr->lines[i].desc) + edge_detector_stop(&lr->lines[i]); + } + + wake_up_poll(&lr->wait, EPOLLIN | EPOLLERR); + + return NOTIFY_OK; +} + static u64 gpio_v2_line_config_flags(struct gpio_v2_line_config *lc, unsigned int line_idx) { @@ -1892,6 +1898,11 @@ static int lineevent_unregistered_notify(struct noti= fier_block *nb, struct lineevent_state *le =3D container_of(nb, struct lineevent_state, device_unregistered_nb); =20 + if (le->irq) { + free_irq(le->irq, le); + le->irq =3D 0; + } + wake_up_poll(&le->wait, EPOLLIN | EPOLLERR); =20 return NOTIFY_OK; --=20 2.43.0