From nobody Sun Feb 8 09:26:59 2026 Received: from akranes.kaiser.cx (akranes.kaiser.cx [152.53.16.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 686111DFEB for ; Mon, 26 Feb 2024 19:13:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=152.53.16.207 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708974807; cv=none; b=ugxibMvRUjPZfEwUAZf5PuVQCcrxd0Vw37zB491tClklt1B8C0il7MD+DUwe+m8JXPsK9NVDuRpex22fc8Jm34ndAbUw+pK6jDZxwuY81LuL/aUg66udGw8NeHvm2aVQrzFTmCP052epCm7HLoEW1HQd+SbyrCDDwL24Pca+DaQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708974807; c=relaxed/simple; bh=pAbmOtNM38S5447INZawtgqJysuZCh4Jqm2e5w2+338=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JpQB12jbaZcyu/Wspst+cvBZVpTkvBf9s14SotbV08bZqvtt3ZuL/I9PU4y2ar/mucVPlvNvmEG5HKePEwc5RTh72dQJUWWi6RT9SLVUoT+7ARadghmMEouqGgM513dgoznQ3LqPNstCLB9JtbJaj35sB5EmbBCkNEyyv40F0Wc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kaiser.cx; spf=pass smtp.mailfrom=kaiser.cx; arc=none smtp.client-ip=152.53.16.207 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kaiser.cx Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kaiser.cx Received: from dslb-188-097-209-155.188.097.pools.vodafone-ip.de ([188.97.209.155] helo=martin-debian-2.paytec.ch) by akranes.kaiser.cx with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1regPO-001h9S-0X; Mon, 26 Feb 2024 20:13:02 +0100 From: Martin Kaiser To: Andrew Morton Cc: Uladzislau Rezki , linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 1/3] lib/test_vmalloc.c: fix typo in function name Date: Mon, 26 Feb 2024 20:11:57 +0100 Message-Id: <20240226191159.39509-2-martin@kaiser.cx> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240226191159.39509-1-martin@kaiser.cx> References: <20240226191159.39509-1-martin@kaiser.cx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix a typo and change the function name to init_test_configuration. Both caller and definition have the same typo, so the current code already works. Signed-off-by: Martin Kaiser Reviewed-by: Uladzislau Rezki (Sony) --- lib/test_vmalloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c index 3718d9886407..191b6bd5dff9 100644 --- a/lib/test_vmalloc.c +++ b/lib/test_vmalloc.c @@ -501,7 +501,7 @@ static int test_func(void *private) } =20 static int -init_test_configurtion(void) +init_test_configuration(void) { /* * A maximum number of workers is defined as hard-coded @@ -531,7 +531,7 @@ static void do_concurrent_test(void) /* * Set some basic configurations plus sanity check. */ - ret =3D init_test_configurtion(); + ret =3D init_test_configuration(); if (ret < 0) return; =20 --=20 2.39.2 From nobody Sun Feb 8 09:26:59 2026 Received: from akranes.kaiser.cx (akranes.kaiser.cx [152.53.16.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F6E612FF8E for ; Mon, 26 Feb 2024 19:13:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=152.53.16.207 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708974808; cv=none; b=ZWvhc66Gw6/hU4Mv9CJOMwIa60N22bFCh8isLCqUal+5zNZy3wgOoWNkjlkXr/V3Pn44y405AArp/qrnKC7LC+TWpFYS0TuD1+oSofdyyC8qg+CKmRsXngtR2FFkWdIMkDw/2jVHKZoOfh9Q9BEl5eC9vR0scUjwPsI6aYeoxns= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708974808; c=relaxed/simple; bh=EB1BnjvStlE/zAy+upOpHVeXAZqFpUO5iqpwHdU1S+M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=k3nnahOEMY0iH53t38WL+3F9XWrtn/sB/pW2Hgi4jT2ETdn7L6Dx2SVYyrLy+QEr7ixqUquNeIZIzl3BYiaah+ruEDymWIjsGkT++FbN5V6UOo19gpKsCJSvephifK30K/+rVOSpqxXH9fkHXJ9ITyfBe3yNoBRldj0kK8Mc+Tk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kaiser.cx; spf=pass smtp.mailfrom=kaiser.cx; arc=none smtp.client-ip=152.53.16.207 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kaiser.cx Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kaiser.cx Received: from dslb-188-097-209-155.188.097.pools.vodafone-ip.de ([188.97.209.155] helo=martin-debian-2.paytec.ch) by akranes.kaiser.cx with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1regPP-001h9S-0g; Mon, 26 Feb 2024 20:13:03 +0100 From: Martin Kaiser To: Andrew Morton Cc: Uladzislau Rezki , linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 2/3] lib/test_vmalloc.c: drop empty exit function Date: Mon, 26 Feb 2024 20:11:58 +0100 Message-Id: <20240226191159.39509-3-martin@kaiser.cx> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240226191159.39509-1-martin@kaiser.cx> References: <20240226191159.39509-1-martin@kaiser.cx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The module is never loaded successfully. Therefore, it'll never be unloaded and we can remove the exit function. Signed-off-by: Martin Kaiser Reviewed-by: Uladzislau Rezki (Sony) --- lib/test_vmalloc.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c index 191b6bd5dff9..d0c0cbe1913d 100644 --- a/lib/test_vmalloc.c +++ b/lib/test_vmalloc.c @@ -600,12 +600,7 @@ static int vmalloc_test_init(void) return -EAGAIN; /* Fail will directly unload the module */ } =20 -static void vmalloc_test_exit(void) -{ -} - module_init(vmalloc_test_init) -module_exit(vmalloc_test_exit) =20 MODULE_LICENSE("GPL"); MODULE_AUTHOR("Uladzislau Rezki"); --=20 2.39.2 From nobody Sun Feb 8 09:26:59 2026 Received: from akranes.kaiser.cx (akranes.kaiser.cx [152.53.16.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D5C4130AF3 for ; Mon, 26 Feb 2024 19:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=152.53.16.207 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708974809; cv=none; b=DS/pgP+/wIl9MWfuTaNfTHPNCTDLGlGiJdl4tvWfYhfihPtvUP5UgEgI8pDL3wIQy5k5QbJTGzZLb3Oj9MvCw4IMJ3DcMOhn3EGUZZZXuFJBTZXpvWzOrA9TDVlEkjxkEke1vuBxkj9kVedfrX8U637uYpnU9L4boN3aI+nLurQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708974809; c=relaxed/simple; bh=E1OsgKPBvfp3gZK5Z9YheV3ogwQncmYEzQNRgaWN4iA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=P8PgEiG2WjeZl7sPgqEV3bVAbfT7dWXFjmfklrjgRaUsniPd2gBdrzN7Q568TQBF3Gqo55RTOA1+JqAlx+wQUQDoouJL1zEN8Y0qi28msSLDLQhtXg7gm6qJ8K5E9r5T0/rKvqh280wIUj5V2rAr8Sp6goZBk3vrP9Z2J5Cr2q8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kaiser.cx; spf=pass smtp.mailfrom=kaiser.cx; arc=none smtp.client-ip=152.53.16.207 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kaiser.cx Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kaiser.cx Received: from dslb-188-097-209-155.188.097.pools.vodafone-ip.de ([188.97.209.155] helo=martin-debian-2.paytec.ch) by akranes.kaiser.cx with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1regPQ-001h9S-0w; Mon, 26 Feb 2024 20:13:04 +0100 From: Martin Kaiser To: Andrew Morton Cc: Uladzislau Rezki , linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 3/3] lib/test_vmalloc.c: use unsigned long constant Date: Mon, 26 Feb 2024 20:11:59 +0100 Message-Id: <20240226191159.39509-4-martin@kaiser.cx> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240226191159.39509-1-martin@kaiser.cx> References: <20240226191159.39509-1-martin@kaiser.cx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use an unsigned long constant instead of an int constant and a cast. This fixes the checkpatch warning WARNING: Unnecessary typecast of c90 int constant - '(unsigned long) 1' cou= ld be '1UL' + align =3D ((unsigned long) 1) << i; Signed-off-by: Martin Kaiser Reviewed-by: Uladzislau Rezki (Sony) --- lib/test_vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c index d0c0cbe1913d..4ddf769861ff 100644 --- a/lib/test_vmalloc.c +++ b/lib/test_vmalloc.c @@ -117,7 +117,7 @@ static int align_shift_alloc_test(void) int i; =20 for (i =3D 0; i < BITS_PER_LONG; i++) { - align =3D ((unsigned long) 1) << i; + align =3D 1UL << i; =20 ptr =3D __vmalloc_node(PAGE_SIZE, align, GFP_KERNEL|__GFP_ZERO, 0, __builtin_return_address(0)); --=20 2.39.2