From nobody Sat Feb 7 19:41:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0872C14292 for ; Sun, 25 Feb 2024 15:00:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873205; cv=none; b=GL30Dt5qFOOi53wfX5OYFXuBf5ojOw1iwm+07vFYpff/G+8NrlMVaN3TczOms1z4Tej08gy4LUyw8u6OM8SoyflYX57q1pETynVirjYI6aWJqWK+mdP+lkswGPZuiA84hNuBHfadlXoZ5RFju0bsDYQkXF82q+k7xUSQPuCxUqg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873205; c=relaxed/simple; bh=v/1um5RVar9lfHIiYBKMm3UP7u/wfUbuAs6nd5YLVZQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E5DbAgjYSlHV8Q0chtaldzEYN6QLKVDa8TxFtyaysmgU1ZTA8RWoeb+fa//h/rEkp7Kcju19vLiPTzS7SYOtaD7CO1bPMqp/myJDRsHkjkSVhBKCQwCak8tpMbpubmJAh3McPc6cWJ+io1d6I38+CZ97OJp8NjjBIWOiK0n/8RQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aSGrdNIN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aSGrdNIN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3E5AC433C7; Sun, 25 Feb 2024 15:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708873204; bh=v/1um5RVar9lfHIiYBKMm3UP7u/wfUbuAs6nd5YLVZQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=aSGrdNINQnsr6bxDbxh4tza2MVbLCMYLLndCpkRlfVJq2pb8S+Jj4dcVl6h/3rifT 6QQI4iux20Q9CLowZh58WAQ7XGJjgF7Ck1iHHaYYWy7nQOlEERT6c0mBQ+60Hzy6Nz cdImloRhrDai9hlV9Y3mVpGkx5n6YZDWtoVPO1pDIzlH3ciJY2IMvfR4EL24kudssV Rn138Q1ihiqv7f96jy7/G9amaW/sqgfbjIckZOPnxtj3mmYvCm84xp5r0y/nsNeC2l 1AAW0HzSiRbsvc5/0IKqbwjYCIcjs2Zsqo7QlV/ROnCYfOp1+4Qtq42WcA9dtyYc2y +qIW52LgQizNw== From: Mark Brown Date: Sun, 25 Feb 2024 14:59:27 +0000 Subject: [PATCH 1/8] regulator: mp8859: Specify register accessibility and enable caching Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240225-regulator-mp8859-v1-1-68ee2c839ded@kernel.org> References: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> In-Reply-To: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> To: Liam Girdwood Cc: linux-kernel@vger.kernel.org, Markus Reichl , Mark Brown X-Mailer: b4 0.13-dev-0438c X-Developer-Signature: v=1; a=openpgp-sha256; l=1714; i=broonie@kernel.org; h=from:subject:message-id; bh=v/1um5RVar9lfHIiYBKMm3UP7u/wfUbuAs6nd5YLVZQ=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBl21XqkXCKhTdBGzeg12/P/43zz+1z+7XO8teGX 0jonjO767eJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZdtV6gAKCRAk1otyXVSH 0KNoCACGPXWCCYY4hPTNzfz+xxSJ1j4eWWdwytpFcmB0KZMwSANfB79bGE42PG18kAy4dcxa+dD T5Lvvjv2HQwe4xozIuiq0xOQ5Kv+D3SyPRE02DdLORo89ygAGh8zJl2kI2jdUh131d2jiULrskG IagjBhNgJwQte+aW9M1UA2OtMxNi5MW/XI3TGqD+OBeqoOdY0RPwHiVKCGg3bvrZyWlE6+LvQKl SSxD9MK+yy/kLnfSTbP118ZKwrQA4wX4enXTZlifqQY05CjDNEzRiygFORYTPqmeVB+FN5qFAzw 050t/6cpW4E5DUROtFxMWmaduENXe9VeFlJPhqp5y9WxxfV7 X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB Avoid needless accesses to the hardware by caching register values that we know, marking status registers as volatile as appropriate. Signed-off-by: Mark Brown Tested-by: Markus Reichl --- drivers/regulator/mp8859.c | 38 +++++++++++++++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/mp8859.c b/drivers/regulator/mp8859.c index b820bd6043e5..689b56680d93 100644 --- a/drivers/regulator/mp8859.c +++ b/drivers/regulator/mp8859.c @@ -77,11 +77,47 @@ static const struct linear_range mp8859_dcdc_ranges[] = =3D { REGULATOR_LINEAR_RANGE(0, VOL_MIN_IDX, VOL_MAX_IDX, 10000), }; =20 +static bool mp8859_readable(struct device *dev, unsigned int reg) +{ + switch (reg) { + case MP8859_VOUT_L_REG: + case MP8859_VOUT_H_REG: + case MP8859_VOUT_GO_REG: + case MP8859_IOUT_LIM_REG: + case MP8859_CTL1_REG: + case MP8859_CTL2_REG: + case MP8859_STATUS_REG: + case MP8859_INTERRUPT_REG: + case MP8859_MASK_REG: + case MP8859_ID1_REG: + case MP8859_MFR_ID_REG: + case MP8859_DEV_ID_REG: + case MP8859_IC_REV_REG: + return true; + default: + return false; + } +} + +static bool mp8859_volatile(struct device *dev, unsigned int reg) +{ + switch (reg) { + case MP8859_VOUT_GO_REG: + case MP8859_STATUS_REG: + case MP8859_INTERRUPT_REG: + return true; + default: + return false; + } +} + static const struct regmap_config mp8859_regmap =3D { .reg_bits =3D 8, .val_bits =3D 8, .max_register =3D MP8859_MAX_REG, - .cache_type =3D REGCACHE_RBTREE, + .cache_type =3D REGCACHE_MAPLE, + .readable_reg =3D mp8859_readable, + .volatile_reg =3D mp8859_volatile, }; =20 static const struct regulator_ops mp8859_ops =3D { --=20 2.39.2 From nobody Sat Feb 7 19:41:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B83FE14AB0 for ; Sun, 25 Feb 2024 15:00:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873206; cv=none; b=OGD9COWXFdvOvHNvx7dIUs/TiXz+rks/ZsEN9GJIp0If8whbkhKRyn0ClMmgiKIny/2+Ws4/IFQh6M8WuYy7htPDCFDChlr+lvzEu9THz3eh3jBwWrqU3LNxHr3YRsyO4bI92oSVv5UVNd4wH5+gPL7flp5hBeXfRwywxAK7OYk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873206; c=relaxed/simple; bh=Ri9GKojig0WR0PPAwktljb2h7Sk6O8o1TjFabHp87bo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mrF/MxIuFNf/2VaCom2DDZa+84YdKm9nqzL0yntVKeUTbpo5Ox277H1CJq+1muFf2XtZUWF/Laoe4W/jwHqkBJ4ObdnSp/kWhF3V/Q22z8KB5b+h72Thid9IxaN27qHCWrsIG6Tj55IDqgJ7U6gKscBjRQ+coM//jdjfjuWo7aw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NPR3cbfP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NPR3cbfP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3111BC43399; Sun, 25 Feb 2024 15:00:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708873206; bh=Ri9GKojig0WR0PPAwktljb2h7Sk6O8o1TjFabHp87bo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=NPR3cbfP+76KmJERadOEk+QKYOrTEWk9gSnnBAyh1Z1gvfp2Kn4LXtYZEAIwwqDgb PCcgfBoH9e7j5ltotjnESPIthvdJviVssgG7DeeX/mkw0ERZJuUtJKKQrGpmDxonNy vgXWr7F94sYRHzRPBCOyQrAMYTesb9MepBJ8ukWIwSpKin3/HoxySarJUM2QDdb1Je eTm2RUsv8jf7bbv7f6USZILggvEpVSekMGh4paczf7oHKRaYZ4vJVu7gWn5euqtI0j lf9f8+gPWLB91KDHnKyzd+DEAAErR5WtlDAMPZxhbOfZbnODh+1plMw0y9ax46r08w HXZvVnvlNE3bg== From: Mark Brown Date: Sun, 25 Feb 2024 14:59:28 +0000 Subject: [PATCH 2/8] regulator: mp8859: Validate and log device identifier information Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240225-regulator-mp8859-v1-2-68ee2c839ded@kernel.org> References: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> In-Reply-To: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> To: Liam Girdwood Cc: linux-kernel@vger.kernel.org, Markus Reichl , Mark Brown X-Mailer: b4 0.13-dev-0438c X-Developer-Signature: v=1; a=openpgp-sha256; l=1922; i=broonie@kernel.org; h=from:subject:message-id; bh=Ri9GKojig0WR0PPAwktljb2h7Sk6O8o1TjFabHp87bo=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBl21Xr4gN+ow5UDiTTVaGdF6dFFmdf9eEQ4delN A5Aej/FzU6JATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZdtV6wAKCRAk1otyXVSH 0HDhB/4pt/EWEl8hjTqqKYOtmgG1eQP8VyvSnhdYafgFuvD6w5w6X6f8cTklfD3emSXtTuVYacK Il6A5q58KG71/eP/9zP4AMYXLSgzOb4i1foEZUo03hgPwaDeafdTBE046+JZXoGVXfpM0acLp7A 3DMpvLAeRU+g1cWJAcbZV68/RIdh1V9Zzz/Ri8iEHXnru1TTOsBVG/MRJfqSysHASzfAGbr0JG9 njfpMJvPStMlhz3pYHb7SE11W24qMw1Gr05/iZ4jm61Qf/ye9YVC1cZv+kvddckTqlUNHkjKafT Og0svaJIp+iCHqBasWrpbFlCOdMgx6Aohf9Pvh2h7JCGI1F+ X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB Ensure that we are talking to a device which reports the expected ID register information and log the OTP and revision information for diagnostic purposes. Signed-off-by: Mark Brown Tested-by: Markus Reichl --- drivers/regulator/mp8859.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/drivers/regulator/mp8859.c b/drivers/regulator/mp8859.c index 689b56680d93..b07bc63a25cb 100644 --- a/drivers/regulator/mp8859.c +++ b/drivers/regulator/mp8859.c @@ -147,12 +147,46 @@ static int mp8859_i2c_probe(struct i2c_client *i2c) struct regulator_config config =3D {.dev =3D &i2c->dev}; struct regmap *regmap =3D devm_regmap_init_i2c(i2c, &mp8859_regmap); struct regulator_dev *rdev; + unsigned int val, rev; =20 if (IS_ERR(regmap)) { ret =3D PTR_ERR(regmap); dev_err(&i2c->dev, "regmap init failed: %d\n", ret); return ret; } + + ret =3D regmap_read(regmap, MP8859_MFR_ID_REG, &val); + if (ret !=3D 0) { + dev_err(&i2c->dev, "Failed to read manufacturer ID: %d\n", ret); + return ret; + } + if (val !=3D 0x9) { + dev_err(&i2c->dev, "Manufacturer ID %x !=3D 9\n", val); + return -EINVAL; + } + + ret =3D regmap_read(regmap, MP8859_DEV_ID_REG, &val); + if (ret !=3D 0) { + dev_err(&i2c->dev, "Failed to read device ID: %d\n", ret); + return ret; + } + if (val !=3D 0x58) { + dev_err(&i2c->dev, "Manufacturer ID %x !=3D 0x58\n", val); + return -EINVAL; + } + + ret =3D regmap_read(regmap, MP8859_IC_REV_REG, &rev); + if (ret !=3D 0) { + dev_err(&i2c->dev, "Failed to read device revision: %d\n", ret); + return ret; + } + ret =3D regmap_read(regmap, MP8859_ID1_REG, &val); + if (ret !=3D 0) { + dev_err(&i2c->dev, "Failed to read device ID1: %d\n", ret); + return ret; + } + dev_info(&i2c->dev, "MP8859-%04d revision %d\n", val, rev); + rdev =3D devm_regulator_register(&i2c->dev, &mp8859_regulators[0], &config); =20 --=20 2.39.2 From nobody Sat Feb 7 19:41:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CA0717551 for ; Sun, 25 Feb 2024 15:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873210; cv=none; b=RiHSSKwZQzVjX07WEnNcGuiC4eBltDdMyLsUdhYCd7mInON0i6Cd00vY0rfedX1kN3Bygp7O03/KPmIC6OokF+B0hkGbAHW7jYgbbTnr09KA78LZZ0/c5wVMr2w8Mgf5isqppiVQdhzabCPqg5KGma2ga9EIUSpb82PZJlEbtvE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873210; c=relaxed/simple; bh=nIY3jsVvUGsi7oIbCNHSZsH+xPsRMAgDN59hh2ZbHE8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FZ4dZuL63n4/3u7cRbier89p15Jvk6ltj/Rtzkiq9j0WNVPgpcSWMO/XXz6vpVmKF4RBcrz0i1+c5WGgMTkRRCXnsrbGjvTqU3pGFNZKrlZ9mIOvSJ6/dj5jQ/8sGll3kuWUXYadwNsNByH0Znn7zbk3im5tFHrTRFAOsLgkHM0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A11XjbBT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A11XjbBT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6CCBC43399; Sun, 25 Feb 2024 15:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708873209; bh=nIY3jsVvUGsi7oIbCNHSZsH+xPsRMAgDN59hh2ZbHE8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=A11XjbBTHdWE/A+lOssOXEVwBeUX5K5z6tTQgnPwCU8cun14IkwfBcBfgf7bVTxPh swEPLL+zh+tNSt93/8MINSA8bSdjjkBABctQ90r9zImnJj2c21ortddKG/6NxBijDj /F95/WnQOeJMQZiBDugoIbKr3v42qi3OtjKhAWITd2nbDJHljJwQr+l37pLONXNTgw i++XU0MXINEoK/lPAjEit5MEqO8dnoBq6q4BR+BkPV325nNOo/mPpbpozYb4lzj3kb en2sSr2QcJNtwY274uu/3dQBWYrnH/YIc6J1DT3Y0e981cgd5FT93eY+QwROmhwxq1 8nMze8oSkZa+g== From: Mark Brown Date: Sun, 25 Feb 2024 14:59:29 +0000 Subject: [PATCH 3/8] regulator: mp8859: Support enable control Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240225-regulator-mp8859-v1-3-68ee2c839ded@kernel.org> References: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> In-Reply-To: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> To: Liam Girdwood Cc: linux-kernel@vger.kernel.org, Markus Reichl , Mark Brown X-Mailer: b4 0.13-dev-0438c X-Developer-Signature: v=1; a=openpgp-sha256; l=1352; i=broonie@kernel.org; h=from:subject:message-id; bh=nIY3jsVvUGsi7oIbCNHSZsH+xPsRMAgDN59hh2ZbHE8=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBl21XsUfGsQV9TSfIj/NHZzgGvZfd2Cz/Q9Hqkk GV4vIwR7PWJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZdtV7AAKCRAk1otyXVSH 0JXyB/wNxcohOjIM7Go3L7hry02cxHPCEeY/ZPx7hw2n2xsBfSv5VCciD/zhEGafn/1Bdyz+4E9 CfvmYGel4C663PHdNh9OvLUKbX4t0OtRKxnEgcKnoSofa2dRr0ph8YHKqnR8F5Jfrak4bHkKHcz oG/rtlmvCWYaB8WiOnJv4QN3DJwCencih4hLWm2VH4QdML5AIhX9N+LIHSbrEiGcbskYLgdDq9U EaXNN2nwgbA3AFmxr7dtpQOC5jOJd7WiY2gJo4s1Lkcd81H/g2KBDRmZhTiiSBcsBQHlLEsBfkk 8DGZvrcIUBrvYO+j+QxbROXA8VDYtIFL8IJCHpGJxKDVRbrW X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB The MP8859 provides a software enable control, support it in the regulator driver. Signed-off-by: Mark Brown Tested-by: Markus Reichl --- drivers/regulator/mp8859.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/regulator/mp8859.c b/drivers/regulator/mp8859.c index b07bc63a25cb..a443ebe927c5 100644 --- a/drivers/regulator/mp8859.c +++ b/drivers/regulator/mp8859.c @@ -35,6 +35,7 @@ =20 #define MP8859_GO_BIT 0x01 =20 +#define MP8859_ENABLE_MASK 0x80 =20 static int mp8859_set_voltage_sel(struct regulator_dev *rdev, unsigned int= sel) { @@ -124,6 +125,9 @@ static const struct regulator_ops mp8859_ops =3D { .set_voltage_sel =3D mp8859_set_voltage_sel, .get_voltage_sel =3D mp8859_get_voltage_sel, .list_voltage =3D regulator_list_voltage_linear_range, + .enable =3D regulator_enable_regmap, + .disable =3D regulator_disable_regmap, + .is_enabled =3D regulator_is_enabled_regmap, }; =20 static const struct regulator_desc mp8859_regulators[] =3D { @@ -136,6 +140,9 @@ static const struct regulator_desc mp8859_regulators[] = =3D { .n_voltages =3D VOL_MAX_IDX + 1, .linear_ranges =3D mp8859_dcdc_ranges, .n_linear_ranges =3D 1, + .enable_reg =3D MP8859_CTL1_REG, + .enable_mask =3D MP8859_ENABLE_MASK, + .enable_val =3D MP8859_ENABLE_MASK, .ops =3D &mp8859_ops, .owner =3D THIS_MODULE, }, --=20 2.39.2 From nobody Sat Feb 7 19:41:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAC81175B1 for ; Sun, 25 Feb 2024 15:00:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873212; cv=none; b=fgrxBL1mkPVzwacWpQti5CZ1jUxkMwiSyEobuLVjo93JfAZNTx81A1BXAFUCBIQZxuTxSmSKrA3ORhtED2wCOG+6Qwya2JNlAgo3XPBT+IaXgeTzR+a4zauY7S0itKS6VmnEPVYOch5N8mHqax+UH7J8fz9GV6qKvOfU8Y6ZNcs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873212; c=relaxed/simple; bh=/9Qtfrp2wXu5HlNPGVpCrKTCsuKq/bIXhE9SvbtyD4A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nKUKpGwJhls8O58Koo5sMbYqfv06NDj01UHfo2kfbbW7fUyANGoXOk2mijMbXy4AX3u6aSVXR+SHk9g+QaRl1LTzayiFwIFwyFbDKuwzTqk4yE108N2hc64sH1P22blp/RQ2JFwm5n+snRUXmBdOo1E6NDpl6IEP4Kv4OMXIweQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DoNhRcXt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DoNhRcXt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CBFFC433C7; Sun, 25 Feb 2024 15:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708873212; bh=/9Qtfrp2wXu5HlNPGVpCrKTCsuKq/bIXhE9SvbtyD4A=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=DoNhRcXtsN75f2or3TYH3BLjp5iF/tLu7GknJSEa4wMqdgD0GHH58sOd5ZWgPCY/z PXzOiMy6tkZZMay0W5OO2xTanT91YKUwrO7fQjQ0ertwh/ybEj+ZJ1RhuHtjMDX72l Eiv2XMeMZCZHzVtSuZELPPpWfZYP/zVEAj2qGDFvAGGDpSycMIOs1YvEsArCy6hS52 glfnwpH9ocsy03eoNucdcs00SrSQqPhollPXuAtwLIPtZdV9Gh2yZ/KtYu48vNqklk ydbUKCeWIZaERhwlLSCyYZa5Q35JQV/5H6thmMkfel8l3rBq70gWea06++dE0kfnNT fmc0oR/YS+ilw== From: Mark Brown Date: Sun, 25 Feb 2024 14:59:30 +0000 Subject: [PATCH 4/8] regulator: mp8859: Support mode operations Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240225-regulator-mp8859-v1-4-68ee2c839ded@kernel.org> References: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> In-Reply-To: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> To: Liam Girdwood Cc: linux-kernel@vger.kernel.org, Markus Reichl , Mark Brown X-Mailer: b4 0.13-dev-0438c X-Developer-Signature: v=1; a=openpgp-sha256; l=1976; i=broonie@kernel.org; h=from:subject:message-id; bh=/9Qtfrp2wXu5HlNPGVpCrKTCsuKq/bIXhE9SvbtyD4A=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBl21XsfERsrSmC8mxkIIHybPnRxcTEutHbE1mEX YuwHuy1r8eJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZdtV7AAKCRAk1otyXVSH 0IDXB/91va2SMLdhVzW2gjt5wz+97EDSXgKd6rSNHk+fKOyrJZiijRDqh+CjzGpZJJmafWRvC4b 992Z6fH66uvv1tB0JdANlmqXKy5A5o7IVBBrA5HZHb8bnZQPDgGTdGPqGxFnhl/Xik+QxJIgsaU qxJ6JKPHlj8NVSCHqXNHHAzsnycLr9K88Z60igzE3qy4qsZi5S1GKhuUAxjLe+3JWmU2RXE3RxO x5gMpdoOPjxRGqHDv/tLsmBSxKWop8HH3JYMw2FhzrLL/uuo7dKw0W0b5AxqBCOOJpySgsdxd6s DyHG5XJpGbuyUVNnkPHBuMudFLcXmRrGy9Es4B4lAlMmgpzW X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB The MP8859 provides mode control, implement the relevant regulator API operations. Signed-off-by: Mark Brown Tested-by: Markus Reichl --- drivers/regulator/mp8859.c | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/drivers/regulator/mp8859.c b/drivers/regulator/mp8859.c index a443ebe927c5..b97c00097148 100644 --- a/drivers/regulator/mp8859.c +++ b/drivers/regulator/mp8859.c @@ -36,6 +36,7 @@ #define MP8859_GO_BIT 0x01 =20 #define MP8859_ENABLE_MASK 0x80 +#define MP8859_MODE_MASK 0x08 =20 static int mp8859_set_voltage_sel(struct regulator_dev *rdev, unsigned int= sel) { @@ -74,6 +75,42 @@ static int mp8859_get_voltage_sel(struct regulator_dev *= rdev) return val; } =20 +static unsigned int mp8859_get_mode(struct regulator_dev *rdev) +{ + unsigned int val; + int ret; + + ret =3D regmap_read(rdev->regmap, MP8859_CTL1_REG, &val); + if (ret !=3D 0) { + dev_err(&rdev->dev, "Failed to read mode: %d\n", ret); + return 0; + } + + if (val & MP8859_MODE_MASK) + return REGULATOR_MODE_FAST; + else + return REGULATOR_MODE_NORMAL; +} + +static int mp8859_set_mode(struct regulator_dev *rdev, unsigned int mode) +{ + unsigned int val; + + switch (mode) { + case REGULATOR_MODE_FAST: + val =3D MP8859_MODE_MASK; + break; + case REGULATOR_MODE_NORMAL: + val =3D 0; + break; + default: + return -EINVAL; + } + + return regmap_update_bits(rdev->regmap, MP8859_CTL1_REG, + MP8859_MODE_MASK, val); +} + static const struct linear_range mp8859_dcdc_ranges[] =3D { REGULATOR_LINEAR_RANGE(0, VOL_MIN_IDX, VOL_MAX_IDX, 10000), }; @@ -128,6 +165,8 @@ static const struct regulator_ops mp8859_ops =3D { .enable =3D regulator_enable_regmap, .disable =3D regulator_disable_regmap, .is_enabled =3D regulator_is_enabled_regmap, + .set_mode =3D mp8859_set_mode, + .get_mode =3D mp8859_get_mode, }; =20 static const struct regulator_desc mp8859_regulators[] =3D { --=20 2.39.2 From nobody Sat Feb 7 19:41:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F3D117BB5 for ; Sun, 25 Feb 2024 15:00:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873215; cv=none; b=fZiLrsdS6e8b9mG/ZRnOCzIGmWEow1gXfsh9nNxN+4gM4J9EN3+Oe5RBqaG6p9qdFeJydqxmU405k/Yi0x9Ic58fnVnp9SUyl1nv07s94OTxw7vcFoquh6jLYwPF6qfCJL0K1dx/cEn8R1QOP7FlJZ6n0pPMkd1AY+SJuyb63L8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873215; c=relaxed/simple; bh=X9+qvEO2XEVtcl0Z37unwdXVLozBPbckvKpRaBgpa9c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OGatcKqRQ3mnXbiPDNfG/8i95PNUyK805b6m7TaOQrYU9mqfp2SfzQqET5ox0rAODjHEhuGoYUR7xocHeT21VYh4h7Li4DrPoU6eLucBcgBMxcL/BX/WgACMVMauTIWD/FdVKFlPDDH/9w8cvP/f7Q6cvl3+TNkBr0TrgPAx7gg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KfU40wHC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KfU40wHC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B045EC43390; Sun, 25 Feb 2024 15:00:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708873214; bh=X9+qvEO2XEVtcl0Z37unwdXVLozBPbckvKpRaBgpa9c=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=KfU40wHCwMEnS3HnRuVIWBzGhhBbNMigz4OjNQEGUqUeBlaqP/4Sp7MuVF9Ypp6Oo X24epenmtHJ410NVGI4vZmpNlJCER/XDVmjqPLi+Gf7RDmZ9fihcLPEliyAFg52xJV HhC+QTbcLsBW7GqwfxNTPwmGyjEwmSLN1BqrYc9zRR1jrcm99b2SDCutMmq725OdeU pxcm9/8q7BctGkZhYYE0ptquAy1z2TKZo5JRoQMaoHCQRwvxfxQFWRond7UDHotqTz JhSLC9ChpU+2I5KJMuDn5GVmi2R1fDjqWZxQ8fFMUUDIY5X5WNeLZcoUi7y62Ou0CR kmVOSWHFGMokg== From: Mark Brown Date: Sun, 25 Feb 2024 14:59:31 +0000 Subject: [PATCH 5/8] regulator: mp8859: Support active discharge control Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240225-regulator-mp8859-v1-5-68ee2c839ded@kernel.org> References: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> In-Reply-To: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> To: Liam Girdwood Cc: linux-kernel@vger.kernel.org, Markus Reichl , Mark Brown X-Mailer: b4 0.13-dev-0438c X-Developer-Signature: v=1; a=openpgp-sha256; l=1382; i=broonie@kernel.org; h=from:subject:message-id; bh=X9+qvEO2XEVtcl0Z37unwdXVLozBPbckvKpRaBgpa9c=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBl21XtL09mnouWsPOM5gMsWsesbkXsUDdZmXXvV w/vc6LAiPCJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZdtV7QAKCRAk1otyXVSH 0J2DB/4nEO8nZKFIEwHzKSUMOUN7rEK9/bdPwWeBTOBH0yluUzJaq09BU8iP70DhfqCXoIjZtLJ hMVRgk3lRnbZ+pRBvqfZEzIcjWAl+PSChWuUlkQOuy13bPRyaKJHylNHCFam988r1R+55HXDBTi 78tDSNj/EvcVVhX8pDXgU/Ucg9AzurVXMh+v+4OE8kHpXLXjZYIZ3sQwF4DP/ErI6msdZIgdKjk dMK8tZrtSCBahS5rrFRxpHF53HXguAiWxlHGx4KcPTWWM+aVl7NQqc/foELX/pjeeYgv/On/Y6/ kq0cQViY7cV1ykOlvWDPlFSmw4l2v/03RTnZDcNr7QVvQ/Ji X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB The MP8859 can actively discharge the output when disabled, add support for controlling this feature. Signed-off-by: Mark Brown Tested-by: Markus Reichl --- drivers/regulator/mp8859.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/regulator/mp8859.c b/drivers/regulator/mp8859.c index b97c00097148..87ef34875be1 100644 --- a/drivers/regulator/mp8859.c +++ b/drivers/regulator/mp8859.c @@ -36,6 +36,7 @@ #define MP8859_GO_BIT 0x01 =20 #define MP8859_ENABLE_MASK 0x80 +#define MP8859_DISCHG_EN_MASK 0x10 #define MP8859_MODE_MASK 0x08 =20 static int mp8859_set_voltage_sel(struct regulator_dev *rdev, unsigned int= sel) @@ -167,6 +168,7 @@ static const struct regulator_ops mp8859_ops =3D { .is_enabled =3D regulator_is_enabled_regmap, .set_mode =3D mp8859_set_mode, .get_mode =3D mp8859_get_mode, + .set_active_discharge =3D regulator_set_active_discharge_regmap, }; =20 static const struct regulator_desc mp8859_regulators[] =3D { @@ -182,6 +184,9 @@ static const struct regulator_desc mp8859_regulators[] = =3D { .enable_reg =3D MP8859_CTL1_REG, .enable_mask =3D MP8859_ENABLE_MASK, .enable_val =3D MP8859_ENABLE_MASK, + .active_discharge_reg =3D MP8859_CTL1_REG, + .active_discharge_on =3D MP8859_DISCHG_EN_MASK, + .active_discharge_mask =3D MP8859_DISCHG_EN_MASK, .ops =3D &mp8859_ops, .owner =3D THIS_MODULE, }, --=20 2.39.2 From nobody Sat Feb 7 19:41:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A0C31804F for ; Sun, 25 Feb 2024 15:00:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873217; cv=none; b=Q5T+H9zZ4v0J+5jxFSdTKpT+FwuBY8u+0dS7LRwBctqDCWHxIF0ADeCej9O9N41CgEDOcGVeWaLx8XB1+smK2OUyaq1mPGiqBFxHwvKqsTMPXtQf2SLLo9pN+8xWP1BfavbcRMUJ2vRz6W5DWcPdgRNPbU4v8+8Gvyk4+ncSwvo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873217; c=relaxed/simple; bh=hQozOQk8vKGJhYP2wxfoB44e0P7uPH2YR9fKCY4VQYs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RiVEabEghTViR5hTFKfPvJggFnhyIaQLbI4kBhsJ3sAJUeOMeunoq4KNcS0HJaIdCf6VrLb8M5tyaiwxl4VG46152iU0crXUss4n8jdvgm5tmwJfaj0codlKIQVKuoIOFm4J6u5152WLGZrT3x7pXjwnhbb8Bxf124WE94/mVxI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=amKrzuOr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="amKrzuOr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D740C43394; Sun, 25 Feb 2024 15:00:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708873217; bh=hQozOQk8vKGJhYP2wxfoB44e0P7uPH2YR9fKCY4VQYs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=amKrzuOrRLysty+N0ooO1Z6v8k8BG468ny/Pe7/1ktHSv6YE+XkOsSK27CKbdoPZy IwQ7g9xhGqsYlo+Z7Bj231pT7zP1VeBLEVW1AUeGQaoOUMyMalg3FyZbJLF0GI9bBL xltgsL9YX35Q9nGWl1AAYVUUVDAJw0VqB/KCBi75u0OaIUChd8BXsX++Z0Bv/ORVdw uQCMpu25ac8XM6Bkew96hw+LUuCwb9tDLfqv4ShiPF28D++eibv5TIy6x7osgrJuB1 FRthzD4X4ogQHEE40u0sUlgEHZ/CGGcG2Q+JYENmeQEhuOA2VJvVAvocfXobonnsFG 8eYU9RKbIyAbw== From: Mark Brown Date: Sun, 25 Feb 2024 14:59:32 +0000 Subject: [PATCH 6/8] regulator: mp8859: Support status and error readback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240225-regulator-mp8859-v1-6-68ee2c839ded@kernel.org> References: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> In-Reply-To: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> To: Liam Girdwood Cc: linux-kernel@vger.kernel.org, Markus Reichl , Mark Brown X-Mailer: b4 0.13-dev-0438c X-Developer-Signature: v=1; a=openpgp-sha256; l=2776; i=broonie@kernel.org; h=from:subject:message-id; bh=hQozOQk8vKGJhYP2wxfoB44e0P7uPH2YR9fKCY4VQYs=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBl21Xuto4KgtyF5tu6sqD6TDenynqoZDSUQ+jXR PayVsdHsXWJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZdtV7gAKCRAk1otyXVSH 0OAeCACG62FfYCMT432Vtz/tUWvc0+pvEUbN+QU7mgupuVXBZ7sS1cEG7Hsv2gIdgRhHqHiCac4 OtYif6EAf5j3QTMwxPIWvSAwRJd9AAItJuv1GSRyH8abiqSbyMwNfWXRGu8TLss8N9rc6BQkT5n NTh3qOaHxv49Jw0VBEvVglobKfteHmhJejn9+4mli5CnzOKxQ/H9wklvp/TA5vVYG9UQQ7eqIgV WrzY/f43p84lDKM1jIYE49h9TJiOMUeB/VkXxJGLOfGM5FVnb0qpVSZ9l32NqDSRq3rXx4zATbe AX/7Ahy+/1KpMlxzsVpHeplUqXIzxOR2FSNvS5HTJNU3y4C/ X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB The MP8859 can report if it is in regulation and detect over temperature conditions, report this information via the relevant regulator API calls. Signed-off-by: Mark Brown Tested-by: Markus Reichl --- drivers/regulator/mp8859.c | 59 ++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 59 insertions(+) diff --git a/drivers/regulator/mp8859.c b/drivers/regulator/mp8859.c index 87ef34875be1..fc1636d69bca 100644 --- a/drivers/regulator/mp8859.c +++ b/drivers/regulator/mp8859.c @@ -39,6 +39,11 @@ #define MP8859_DISCHG_EN_MASK 0x10 #define MP8859_MODE_MASK 0x08 =20 +#define MP8859_PG_MASK 0x80 +#define MP8859_OTP_MASK 0x40 +#define MP8859_OTW_MASK 0x20 +#define MP8859_CC_CV_MASK 0x10 + static int mp8859_set_voltage_sel(struct regulator_dev *rdev, unsigned int= sel) { int ret; @@ -112,6 +117,58 @@ static int mp8859_set_mode(struct regulator_dev *rdev,= unsigned int mode) MP8859_MODE_MASK, val); } =20 +static int mp8859_get_status(struct regulator_dev *rdev) +{ + unsigned int val; + int ret; + + /* Output status is only meaingful when enabled */ + ret =3D regmap_read(rdev->regmap, MP8859_CTL1_REG, &val); + if (ret !=3D 0) + return ret; + if (!(val & MP8859_ENABLE_MASK)) + return REGULATOR_STATUS_UNDEFINED; + + ret =3D regmap_read(rdev->regmap, MP8859_STATUS_REG, &val); + if (ret !=3D 0) + return ret; + + if (val & MP8859_PG_MASK) + return REGULATOR_STATUS_ON; + else + return REGULATOR_STATUS_ERROR; +} + +static int mp8859_get_error_flags(struct regulator_dev *rdev, + unsigned int *flags) +{ + unsigned int status, enabled; + int ret; + + *flags =3D 0; + + /* Output status is only meaingful when enabled */ + ret =3D regmap_read(rdev->regmap, MP8859_CTL1_REG, &enabled); + if (ret !=3D 0) + return ret; + enabled &=3D MP8859_ENABLE_MASK; + + ret =3D regmap_read(rdev->regmap, MP8859_STATUS_REG, &status); + if (ret !=3D 0) + return ret; + + if (enabled && !(status & MP8859_PG_MASK)) + status |=3D REGULATOR_ERROR_FAIL; + if (status & MP8859_OTP_MASK) + status |=3D REGULATOR_ERROR_OVER_TEMP; + if (status & MP8859_OTW_MASK) + status |=3D REGULATOR_ERROR_OVER_TEMP_WARN; + if (status & MP8859_CC_CV_MASK) + status |=3D REGULATOR_ERROR_OVER_CURRENT; + + return 0; +} + static const struct linear_range mp8859_dcdc_ranges[] =3D { REGULATOR_LINEAR_RANGE(0, VOL_MIN_IDX, VOL_MAX_IDX, 10000), }; @@ -169,6 +226,8 @@ static const struct regulator_ops mp8859_ops =3D { .set_mode =3D mp8859_set_mode, .get_mode =3D mp8859_get_mode, .set_active_discharge =3D regulator_set_active_discharge_regmap, + .get_status =3D mp8859_get_status, + .get_error_flags =3D mp8859_get_error_flags, }; =20 static const struct regulator_desc mp8859_regulators[] =3D { --=20 2.39.2 From nobody Sat Feb 7 19:41:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1317B18AF9 for ; Sun, 25 Feb 2024 15:00:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873219; cv=none; b=Z5OZpKQWwI3rhEn1aISPh1ACqBcU4Eg2IOotQZo0/ljvmFIVGWxpzc5928dW/vze5D3cAp7e4zmWTlb8bdcvmbylts6TzXcI+lSm2iaZrTAD7LTqHIIIxG+EtaZg+EjKLCcL4F7CJW8P+Lv3I9rHzkj/aRwALyEhCQ4IYEb67pY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873219; c=relaxed/simple; bh=6CinCFKAoCYXsxW9O9gPEeiQ2N+cxWINRDgn5ZKO1nM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=a5LGWkU8CrQbnmU2qsXa54bW+cmykD1r5blq2wO7ho0fA8mK/G73K+4XYGgwSo0gqCoI1L6/aXw7R7p12RYCJdoSJA40Rrd28vtAI6HvqylZsqPciGKhClT5H4OV7AeMwSk0hNAQjQT6l41QqpT/Kp/rD9x+zA90G0jHTiDApp0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=erGDqepY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="erGDqepY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93DE1C433C7; Sun, 25 Feb 2024 15:00:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708873218; bh=6CinCFKAoCYXsxW9O9gPEeiQ2N+cxWINRDgn5ZKO1nM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=erGDqepYet+GW5jazTQFdXEALeq2frVJuSD+rZGWCfNqgoqJYHB5E4o9oEHhlH7SB GyKU1MCNhcmOPIouzeF7t16U405hlv5LS3kKZ1S4tryQdsEcxlOdy3MibL98B/TZeH r55dCIgAyaeuvkOiZrQWzVRw3TP4mGrCLx7TtaYG/44x0kgxuzbrHlVdUSi7DKpeiT zPoAofK9W4PdFoHwsv++LDocbI1LbBYpUXmlV0DfjWkOHWKzm0p4+H6oiWdp2YqZN0 zcM9WZFdrg4OC/ylBS9l0Yi1GAwWz5LDWCX3tFPtUaQGzNXyq5sUSK5vWJbugC6ZZb t29zq/lXtzwzg== From: Mark Brown Date: Sun, 25 Feb 2024 14:59:33 +0000 Subject: [PATCH 7/8] regulator: mp8859: Report slew rate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240225-regulator-mp8859-v1-7-68ee2c839ded@kernel.org> References: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> In-Reply-To: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> To: Liam Girdwood Cc: linux-kernel@vger.kernel.org, Markus Reichl , Mark Brown X-Mailer: b4 0.13-dev-0438c X-Developer-Signature: v=1; a=openpgp-sha256; l=1390; i=broonie@kernel.org; h=from:subject:message-id; bh=6CinCFKAoCYXsxW9O9gPEeiQ2N+cxWINRDgn5ZKO1nM=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBl21XvplZ61zQIvdl7OTNyrlZRkxv916h7KIJ8t B8UxCxQ5cqJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZdtV7wAKCRAk1otyXVSH 0GMZB/0ZL8/Sbs+eXy7b577Yj4n4sf2ipLN+dKfrIu4xv72nJMeCdg27q+qeAzJFej2ZYa/Eurg /LJUAj0UxpasN1xnp5m+wEj7md3CklLYz+parUhjrEu/LGKWxW5969rIqvVKoz0/YtXTRR2hg/L Rl7rew0an36FOqTsrxLISQX/pMtQBD4xdg2scMLj11jnT4lSpHzYPGNnwcYmvXnY9JkNq6CQ4l4 08b700GqIrrbWOvnBwttW9wWLqnk5NdArCTkmeJxXmSN6OibknJZebWTRC96woWXdVdI1sKY5Y/ cKDhoDAkmBJeRpIaUnrDXc4W7QAM3LyUbOcfbspEotImDea4 X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB The MP8859 implements voltage changes at the rate of 1mV/us, tell the core about this so that it can provide appropriate delays on voltage changes. Signed-off-by: Mark Brown Tested-by: Markus Reichl --- drivers/regulator/mp8859.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/regulator/mp8859.c b/drivers/regulator/mp8859.c index fc1636d69bca..3e849e1a172f 100644 --- a/drivers/regulator/mp8859.c +++ b/drivers/regulator/mp8859.c @@ -81,6 +81,20 @@ static int mp8859_get_voltage_sel(struct regulator_dev *= rdev) return val; } =20 +static int mp8859_set_voltage_time_sel(struct regulator_dev *rdev, + unsigned int from, unsigned int to) +{ + int change; + + /* The voltage ramps at 1mV/uS, selectors are 10mV */ + if (from > to) + change =3D from - to; + else + change =3D to - from; + + return change * 10 * 1000; +} + static unsigned int mp8859_get_mode(struct regulator_dev *rdev) { unsigned int val; @@ -220,6 +234,7 @@ static const struct regulator_ops mp8859_ops =3D { .set_voltage_sel =3D mp8859_set_voltage_sel, .get_voltage_sel =3D mp8859_get_voltage_sel, .list_voltage =3D regulator_list_voltage_linear_range, + .set_voltage_time_sel =3D mp8859_set_voltage_time_sel, .enable =3D regulator_enable_regmap, .disable =3D regulator_disable_regmap, .is_enabled =3D regulator_is_enabled_regmap, --=20 2.39.2 From nobody Sat Feb 7 19:41:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A600A1AACD for ; Sun, 25 Feb 2024 15:00:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873220; cv=none; b=PNyaQAAicThiF2ML56Wjyt9rMJN80oHGPO4rLeUYm86CFiVA5vf/59sBbsSP0/ZwzwMQ2T5srPgDqnwL8GgDTeMQU6Wb04G8Kw5ps3EMt9FGOwJlkv97Ci6Gt4w66YDAvDAU01XhC2kzC03WGSxrQhw7WhYsSIq2xgjjaxKJK5Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708873220; c=relaxed/simple; bh=RzDZHw2Jmq0oML0An+44XMs3/ybJDt8lUM/JUMitUeI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BFa/zKbN7T/w4QDfhc+QBq9FJPmgsPmxxEmQYei9/o1lcWIDPfTo2QKqxDdeLz8i+tGdt4qOFfuRTWO895Qiudg5HZtRXQgjyHfQDiN8nVj+9Wtm7F8j4lnkmqFHznjqWePACg0wOtlhlsMO+N9oA5yQRUtgSLBtlIjt2fnb2q0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZvcgrCxC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZvcgrCxC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2828EC43390; Sun, 25 Feb 2024 15:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708873220; bh=RzDZHw2Jmq0oML0An+44XMs3/ybJDt8lUM/JUMitUeI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ZvcgrCxCOKIOPTPjnW8rkIYP92XdjC+BAApOUz37Ri5jflvVlspD5E4woP/7FNK6T cflfOPsMhOFIS3ypSa3rJVDilEHsx0zSyvk/RsodHUH9Ur0vOgQc8iVSdNt457pge/ eXp1HZbnrV4+dhwoevQ6wLID3VNROH84HTWHFEiJW9XJDZgSABxT720aO901xXWWy6 KVwbMDK0J7qU1z70vPlNOvL49zrgQ1DyIfeZlaz87rDx1Ku2pxcfVjJsm8tdK2vH1l wOGH04n7dzA1Bmzjn0ngVHNF56P0A/Z4AIirOiO3Jpeh4Jv4H++TXh+6rQTTIZn5oM ufN0Lyqrw4mzQ== From: Mark Brown Date: Sun, 25 Feb 2024 14:59:34 +0000 Subject: [PATCH 8/8] regulator: mp8859: Implement set_current_limit() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240225-regulator-mp8859-v1-8-68ee2c839ded@kernel.org> References: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> In-Reply-To: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org> To: Liam Girdwood Cc: linux-kernel@vger.kernel.org, Markus Reichl , Mark Brown X-Mailer: b4 0.13-dev-0438c X-Developer-Signature: v=1; a=openpgp-sha256; l=2676; i=broonie@kernel.org; h=from:subject:message-id; bh=RzDZHw2Jmq0oML0An+44XMs3/ybJDt8lUM/JUMitUeI=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBl21Xvkt3AbnJVC6B0dHO28eGIbra9Sc76Lh9gJ zR9FxqpNpSJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZdtV7wAKCRAk1otyXVSH 0GoxB/98FJyvogRK3pcXMl2VX2fZJ8Ub/CWKFeTbfdGIfbEauyO98V8AnaBngAZcL5JvXrwv1dw fJeJ2Gmb4W42jCIa7Rl+Wi4vbQdQ1WB/ktTDCHq8QX+m9SID3TP5FuuNmTlEwKIFgX+r1aRSoXl jisVEb3MpARO1oEinEruiStMBr9N3Kxy2p5xL2jFJMxWIPmcnpDnSG8Gc8vQgiN/G/ztBW3t78V 8ATSp0sk71pQdPihErxZnpkhc/dtRfpDK87MawPVov0GDvGo+KqJcZdKBNOcp7OElFGBbpn1OCP I1lfg5m1lAGOfHyAPDRTXRTddpkATtXvxFweD8/JkrBZ8yOo X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB The mp8859 implements support for current limiting, provide support for configuring this via the driver. The datasheet recommends that if the device has hit the current limit then any changes should be implemented via a ramp so we do so in the driver. Signed-off-by: Mark Brown Tested-by: Markus Reichl --- drivers/regulator/mp8859.c | 55 ++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 55 insertions(+) diff --git a/drivers/regulator/mp8859.c b/drivers/regulator/mp8859.c index 3e849e1a172f..ab105ffd6a2e 100644 --- a/drivers/regulator/mp8859.c +++ b/drivers/regulator/mp8859.c @@ -35,6 +35,8 @@ =20 #define MP8859_GO_BIT 0x01 =20 +#define MP8859_IOUT_LIM_MASK 0x7f + #define MP8859_ENABLE_MASK 0x80 #define MP8859_DISCHG_EN_MASK 0x10 #define MP8859_MODE_MASK 0x08 @@ -131,6 +133,58 @@ static int mp8859_set_mode(struct regulator_dev *rdev,= unsigned int mode) MP8859_MODE_MASK, val); } =20 +static int mp8859_set_current_limit(struct regulator_dev *rdev, + int min_uA, int max_uA) +{ + unsigned int cur_val, new_val; + int ret, i; + + /* Steps of 50mA */ + new_val =3D max_uA / 50000; + if (new_val > MP8859_IOUT_LIM_MASK) + return -EINVAL; + if (new_val =3D=3D 0) + return -EINVAL; + + /* + * If the regulator is limiting then ramp gradually as per + * datasheet, otherwise just set the value directly. + */ + ret =3D regmap_read(rdev->regmap, MP8859_STATUS_REG, &cur_val); + if (ret !=3D 0) + return ret; + if (!(cur_val & MP8859_CC_CV_MASK)) { + return regmap_update_bits(rdev->regmap, MP8859_IOUT_LIM_REG, + MP8859_IOUT_LIM_MASK, new_val); + } + + ret =3D regmap_read(rdev->regmap, MP8859_IOUT_LIM_REG, &cur_val); + if (ret !=3D 0) + return ret; + + if (cur_val >=3D new_val) { + for (i =3D cur_val; i >=3D new_val; i--) { + ret =3D regmap_update_bits(rdev->regmap, + MP8859_IOUT_LIM_REG, + MP8859_IOUT_LIM_MASK, + cur_val - i); + if (ret !=3D 0) + return ret; + } + } else { + for (i =3D cur_val; i <=3D new_val; i++) { + ret =3D regmap_update_bits(rdev->regmap, + MP8859_IOUT_LIM_REG, + MP8859_IOUT_LIM_MASK, + cur_val + i); + if (ret !=3D 0) + return ret; + } + } + + return 0; +} + static int mp8859_get_status(struct regulator_dev *rdev) { unsigned int val; @@ -241,6 +295,7 @@ static const struct regulator_ops mp8859_ops =3D { .set_mode =3D mp8859_set_mode, .get_mode =3D mp8859_get_mode, .set_active_discharge =3D regulator_set_active_discharge_regmap, + .set_current_limit =3D mp8859_set_current_limit, .get_status =3D mp8859_get_status, .get_error_flags =3D mp8859_get_error_flags, }; --=20 2.39.2