From nobody Sun Feb 8 07:08:24 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B02391493B4 for ; Fri, 23 Feb 2024 19:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; cv=none; b=AVs3wfUisDXS2lVc7IhvIYd2HV0CHh7I/5qu/9pewDreE11wLKyRkJW9DwhhefSnQhN9j2oJI7UQdpDmiGS53SWf9XRjf0/Ll0TAQ6e0RwyGFVoEgtXCWnuArbJxXyLZxatwN1XNdln8ZMMX9/eymr5bHmw0YMLFvVsXrnZLaAk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; c=relaxed/simple; bh=0PKdh4pEIrqDSQO7ZRWs0TVdP0lCYrCSx8iDEn/lkVs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=maaweI5YbJDzr8Tiipzdrz0X98zWYyAEe6oQeYXbmA7rVnxYuo1dHc5CCXQTSCDt1kUEXZ10Ax8EF14+mES3rc2W4vofZ/g7a9HXg10GA0Utb69BltyXHao+WzCLAv6NAMW1XQ0KibhKVrONhL7mY+3CRM47Ul9MEgFsg3ZfUB0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hAb3t4HU; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hAb3t4HU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708717882; x=1740253882; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0PKdh4pEIrqDSQO7ZRWs0TVdP0lCYrCSx8iDEn/lkVs=; b=hAb3t4HUBUl3zBlB/a7OjwUDRIEVS57tTUQSTyoyUYkHicJiD5sW+QMJ vlqoYr6aMmoAkClKqd0jVSUxwTgoCgJTEApLJuA0ApZyyvHj4IgjagnLI ou3ZpndePmqRA0/boK4gJcFPK/JYhVFPtHnvYHhwve3QmVg8tl2rZzNf7 ruIXNF5Ty5XD2cpK7KfrKA0ctK0kXf52U3q5Q0qg45k60NsZuwWk1W4z3 tJ1TjA0jsLk6otoCsmtNcH+Sed28VTdera68ZIVquohZ8K190hkv24fkZ yu8++u9VXTVX6ygYir6dbO+Fz0Rq+di5tOepU3LtXaDyJtbwVoKborM3G Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6837328" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6837328" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 11:51:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="937025653" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="937025653" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2024 11:51:15 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id AF78479A; Fri, 23 Feb 2024 21:51:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 3/6] mfd: kempld: Simplify device registration Date: Fri, 23 Feb 2024 21:49:52 +0200 Message-ID: <20240223195113.880121-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> References: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use platform_device_register_full() instead of open coding this function. Signed-off-by: Andy Shevchenko --- drivers/mfd/kempld-core.c | 33 +++++++++++++-------------------- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index e8ac30528085..e207a62d6577 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -6,6 +6,7 @@ * Author: Michael Brunner */ =20 +#include #include #include #include @@ -131,28 +132,20 @@ static struct platform_device *kempld_pdev; static int kempld_create_platform_device(const struct dmi_system_id *id) { const struct kempld_platform_data *pdata =3D id->driver_data; - int ret; + const struct platform_device_info pdevinfo =3D { + .name =3D "kempld", + .id =3D PLATFORM_DEVID_NONE, + .res =3D pdata->ioresource, + .num_res =3D 1, + .data =3D pdata, + .size_data =3D sizeof(*pdata), + }; =20 - kempld_pdev =3D platform_device_alloc("kempld", -1); - if (!kempld_pdev) - return -ENOMEM; - - ret =3D platform_device_add_data(kempld_pdev, pdata, sizeof(*pdata)); - if (ret) - goto err; - - ret =3D platform_device_add_resources(kempld_pdev, pdata->ioresource, 1); - if (ret) - goto err; - - ret =3D platform_device_add(kempld_pdev); - if (ret) - goto err; + kempld_pdev =3D platform_device_register_full(&pdevinfo); + if (IS_ERR(kempld_pdev)) + return PTR_ERR(kempld_pdev); =20 return 0; -err: - platform_device_put(kempld_pdev); - return ret; } =20 /** @@ -424,7 +417,7 @@ static int kempld_probe(struct platform_device *pdev) struct resource *ioport; int ret; =20 - if (kempld_pdev =3D=3D NULL) { + if (IS_ERR_OR_NULL(kempld_pdev)) { /* * No kempld_pdev device has been registered in kempld_init, * so we seem to be probing an ACPI platform device. --=20 2.43.0.rc1.1.gbec44491f096