From nobody Sun Feb 8 10:50:21 2026 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B69CCB657 for ; Fri, 23 Feb 2024 01:04:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708650294; cv=none; b=dFDlPwu9uIlxDUNLRf8mtw/g6Mq82+kXzshdC9u5Pk2BzWS+S/80ree3DhAdHExvKBhR8CNlXzDstrpQHK2VaFtWw/iZkdCOTRNbYXsaKFnZ4M1CBddQ7VQMyZ3ljfJ4JewY/k1gkhcq/AR96PCw/QTfp9Ybok08tT58spmF5CM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708650294; c=relaxed/simple; bh=z+h1yXxJcUa7Q+rt4Z5SzcMtHfpQaYLneY32ZhvvCDU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=c2HSOAaZBfj3z33yzd9mWcejIsVcYN11VEDwi4hX7z+AJc9IZJcD9EfReL+DsC/1IEpyWHIjyw2DxxezYb9Q58AZSsJ5dd1XvaI8i7Hv7jPwAar4pBY1LiKlz8nl3ROc6RIobaRPTLhgdr37KRd5LOaDR17wrYOhL5w2+8NRiVU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jthies.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=WA36HLS+; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jthies.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WA36HLS+" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dc6b2682870so570988276.0 for ; Thu, 22 Feb 2024 17:04:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708650291; x=1709255091; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=eXcGLp3XklPDGcQgU4Tvmf4Q43ky22vQ6sErhij3a6c=; b=WA36HLS+J5v+rQdbMhr2IpkjNfrT9BewdgAGiw3HJjBH/Yiyvza2XQVVutXYo72ZBe 5zhZzC5e2YMEyf5z0oCyX+irfTq3s6eavAsqI5N0NamkxlJgikK21wvwla40E6W2Sunv J9NRokaAi8oLPeJpc/sT+HlN6xMY/1JUXrSj94DzcZ7wl05IN7NYhlW6d8rJulCr6vzH 2epKbRkJQJWMpj8xEtJ/JfAVg5xGVJHr/Cv6bsKT2Uz3M0i1DGxcsSTrPBgAsp4sqSJu 8oCxa8iElsg/CN/aiY4M0+SXl93Epc47A7GrkORbrIwY4SC3g9yalOyxGjBxALmlTluw NFvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708650291; x=1709255091; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eXcGLp3XklPDGcQgU4Tvmf4Q43ky22vQ6sErhij3a6c=; b=U6exhF5FAjcEuV4M5walnh5ePqXxLJ7v4rLboTI6wRuhmlJ7ZRz0RDkADUSZ8DYh8d W5+F85k5iZ8M8aW9SrGxca/MruTsy7NE+rPN8V3AT9lLZNMsT+DgIQvhZZGvbtqLmVy9 MI+vl0fNFEJFSbyvI+5/maDH9qz6Cg7d1J6vbrbHuRJIyH2hTNCvb+24dTn0LNm/l+I5 cpsaz5eL4/KP9PVJ4g2jfitHSFSzKuwKbdXI2O3enpx1drtAwQsXvfusbDeVnaP2elV4 Ub5ZJOL6Q8hncnlRH448PQSSllrmPYB+pYPXWS4UF0iqKZm0X15GRGm2Fy36TILS9MMy Uuug== X-Forwarded-Encrypted: i=1; AJvYcCVG6AWApSzxiE7oNnQJmZ5h3BA/B7pgWiPG3G+/pKjXPB9x0kYW+xlBbWL3JLw3WtRUtZQA9uYmUjppdhJKJy98DkDgDK+deds7skld X-Gm-Message-State: AOJu0YwqDTBnzE1Z+VZXT98mDlJHjI87vSbwYk1r0u9QftJ0MACB89/D Ebbqy6EiIO/dnUQ8ZthGtyVogD3ee6CVgsZcEBi64oCs9mY78tarP8VSOFPk1uNrjbjdHXJcjJS B0g== X-Google-Smtp-Source: AGHT+IG03PrEw0HtTG4m+Bmf4i5fWw4eM9SL3vavSQOaa0Hr4Q3QsF3Zw3M2mOiSLiC8G1EsDy9aVF5f8J8= X-Received: from jthies.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:23db]) (user=jthies job=sendgmr) by 2002:a05:6902:18ce:b0:dc6:fec4:1c26 with SMTP id ck14-20020a05690218ce00b00dc6fec41c26mr202150ybb.1.1708650291721; Thu, 22 Feb 2024 17:04:51 -0800 (PST) Date: Fri, 23 Feb 2024 01:03:25 +0000 In-Reply-To: <20240223010328.2826774-1-jthies@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240223010328.2826774-1-jthies@google.com> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog Message-ID: <20240223010328.2826774-2-jthies@google.com> Subject: [PATCH 1/4] usb: typec: ucsi: Clean up UCSI_CABLE_PROP macros From: Jameson Thies To: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org Cc: jthies@google.com, pmalani@chromium.org, bleung@google.com, abhishekpandit@chromium.org, andersson@kernel.org, dmitry.baryshkov@linaro.org, fabrice.gasnier@foss.st.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, neil.armstrong@linaro.org, rajaram.regupathy@intel.com, saranya.gopal@intel.com, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Clean up UCSI_CABLE_PROP macros by fixing a bitmask shifting error for plug type and updating the modal support macro for consistent naming. Fixes: 3cf657f07918 ("usb: typec: ucsi: Remove all bit-fields") Signed-off-by: Jameson Thies Reviewed-by: Benson Leung Reviewed-by: Dmitry Baryshkov Reviewed-by: Prashant Malani --- Tested by building v6.6 kernel. drivers/usb/typec/ucsi/ucsi.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h index 7e35ffbe0a6f..469a2baf472e 100644 --- a/drivers/usb/typec/ucsi/ucsi.h +++ b/drivers/usb/typec/ucsi/ucsi.h @@ -259,12 +259,12 @@ struct ucsi_cable_property { #define UCSI_CABLE_PROP_FLAG_VBUS_IN_CABLE BIT(0) #define UCSI_CABLE_PROP_FLAG_ACTIVE_CABLE BIT(1) #define UCSI_CABLE_PROP_FLAG_DIRECTIONALITY BIT(2) -#define UCSI_CABLE_PROP_FLAG_PLUG_TYPE(_f_) ((_f_) & GENMASK(3, 0)) +#define UCSI_CABLE_PROP_FLAG_PLUG_TYPE(_f_) (((_f_) & GENMASK(4, 3)) >> 3) #define UCSI_CABLE_PROPERTY_PLUG_TYPE_A 0 #define UCSI_CABLE_PROPERTY_PLUG_TYPE_B 1 #define UCSI_CABLE_PROPERTY_PLUG_TYPE_C 2 #define UCSI_CABLE_PROPERTY_PLUG_OTHER 3 -#define UCSI_CABLE_PROP_MODE_SUPPORT BIT(5) +#define UCSI_CABLE_PROP_FLAG_MODE_SUPPORT BIT(5) u8 latency; } __packed; =20 --=20 2.44.0.rc0.258.g7320e95886-goog From nobody Sun Feb 8 10:50:21 2026 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6D0BBA34 for ; Fri, 23 Feb 2024 01:04:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708650297; cv=none; b=qcuf6P0CNIhzkKfKb6nP2Lya+3Zymr0R5538ZE0TP3c85l9Qpvbz+9YjsrQ3nbUhK7zVJyuE02BWIHCakcCl24ooOOosATunjVWcmDkqfadXBusXfYF2xm/SEWcb5YOn6D70WLm/lvsillshUF7gwQJQdubfLz3HX7Q8sNit7Vs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708650297; c=relaxed/simple; bh=AudtEw/bZJ4k+bg0BQXq7THY6fgEi4z3QFF3Hrqxw/o=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=oUKMO1OGE/pxcV15BmCIkemDoMKEXGwq5KJgGqvY5qgJll2InlT7mqerOXXYojldxXu0TYOkisbkuYMMy86hjVNK3AP9wzso0JGSgZyvTAY3wnNZaQvjctVn5Vkf2gLLUOI0R+z7IRLn/OBMBaTj1864frPlrkF07LKWC4v85iQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jthies.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=coZQTzsb; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jthies.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="coZQTzsb" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-5f38d676cecso18874507b3.0 for ; Thu, 22 Feb 2024 17:04:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708650294; x=1709255094; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=nQLpgxev/UCFVGLIwR3AMfjodJpmJGMqgmKMEJOc+QI=; b=coZQTzsb+j5y6+fDWV/GhQTsnEY2EaDPan0aE8Jd8U3rmuOvbzPhtiX6PZ6knZJWfH /7+ZMMWp1YggZW2i8CTzBdZD4VIDFnTlRztMzTq03XfXqf8E9Hy7y4j1ezQxKiqPpEJx Y3BsCnW40ugWxbpCf4vVCwcIrSGakvXQjxEq9/lP7DvI7xW4H6l7UX2XbyAEk8fCj6KT fFfLDbHLfaAYg9D0T81D/eYT/npOnEsjnkUcYt/KSjSlnUpyanNcPLeXQG7i2c1RgCTk POxTnx6E9NONYcaAE2cedOEXaevaUBA5gN0ZC0AIYlii1ARe8tVVpWMPY2P0kG73kfsw 8m8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708650294; x=1709255094; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nQLpgxev/UCFVGLIwR3AMfjodJpmJGMqgmKMEJOc+QI=; b=QSSjz5ERb9W1qNiyobJy2ykpngoVz7WM1oT231Jj/wCgSxuySwFuJwgSjawow0Idkn EfyMBT8sa31kRsIDAXdBXfh8naEY7osa3j/m2Bl8xa3/rKANWoviR/lvZW3t7NhjRgJK URtk4qtReLKz4W/tHS7ZAOQfmXGOsmgk/bd1mLiwnI3s6nflIutCADnEp4YJWamcITjv 3mx9iD8dZr4kxREnar0BHbhbX+MzFv0cT1g+rRgvBA6+LoFZbqGc45suwcWjECucg+MG /f8sznnE6WRsSvX6ioBUyZaEBEVxyJVg29hHBU99EeUU0OEhce5ylWga9ZMw7/MuxAIK 6R1A== X-Forwarded-Encrypted: i=1; AJvYcCV31yZDh7EktQlRmSiqSJDB0eET4KdMGUt1180xig1IqpoEn7Cy8ZRYsCMqhd6IwwpFHmFIrO/pRJtVi8p3kdVjP/R9nV/WTsyjCo5I X-Gm-Message-State: AOJu0YxDwujM/qoPNrojDr1A8I05TaAJLd4/ctvu3Kb5GRSbLoOPk0av /upvq417GGTqPEXS+0IkVFzctBvrjMzCAPDzcB7l7quYnOCDEhH7Y7QCXpv0POok7MyysDoPf9g Jsw== X-Google-Smtp-Source: AGHT+IH7+MqAZARcx1INh7j3pZVkMPgMbKUi15UsYSr52zBlvbI26cjbHg9VKykt97KsPD1Sdu7371KOR2Y= X-Received: from jthies.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:23db]) (user=jthies job=sendgmr) by 2002:a25:ab89:0:b0:dc6:e884:2342 with SMTP id v9-20020a25ab89000000b00dc6e8842342mr184752ybi.5.1708650294753; Thu, 22 Feb 2024 17:04:54 -0800 (PST) Date: Fri, 23 Feb 2024 01:03:26 +0000 In-Reply-To: <20240223010328.2826774-1-jthies@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240223010328.2826774-1-jthies@google.com> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog Message-ID: <20240223010328.2826774-3-jthies@google.com> Subject: [PATCH 2/4] usb: typec: ucsi: Register cables based on GET_CABLE_PROPERTY From: Jameson Thies To: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org Cc: jthies@google.com, pmalani@chromium.org, bleung@google.com, abhishekpandit@chromium.org, andersson@kernel.org, dmitry.baryshkov@linaro.org, fabrice.gasnier@foss.st.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, neil.armstrong@linaro.org, rajaram.regupathy@intel.com, saranya.gopal@intel.com, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Register cables with the Type-C Connector Class in the UCSI driver based on the PPM response to GET_CABLE_PROPERTY. Registered cable properties include plug type, cable type and major revision. Signed-off-by: Jameson Thies Reviewed-by: Benson Leung Reviewed-by: Dmitry Baryshkov Reviewed-by: Heikki Krogerus Reviewed-by: Prashant Malani --- Tested on v6.6 kernel. Expected cable properties populate the USB Type-C connector class sysfs paths: redrix-rev3 /sys/class/typec # ls port2-cable device identity plug_type port2-plug0 power subsystem type uevent usb_power_delivery_revision drivers/usb/typec/ucsi/ucsi.c | 69 +++++++++++++++++++++++++++++++++++ drivers/usb/typec/ucsi/ucsi.h | 5 +++ 2 files changed, 74 insertions(+) diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index ae105383e69e..15e82f5fab37 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -734,6 +734,50 @@ static void ucsi_unregister_partner_pdos(struct ucsi_c= onnector *con) con->partner_pd =3D NULL; } =20 +static int ucsi_register_cable(struct ucsi_connector *con) +{ + struct typec_cable *cable; + struct typec_cable_desc desc =3D {}; + + switch (UCSI_CABLE_PROP_FLAG_PLUG_TYPE(con->cable_prop.flags)) { + case UCSI_CABLE_PROPERTY_PLUG_TYPE_A: + desc.type =3D USB_PLUG_TYPE_A; + break; + case UCSI_CABLE_PROPERTY_PLUG_TYPE_B: + desc.type =3D USB_PLUG_TYPE_B; + break; + case UCSI_CABLE_PROPERTY_PLUG_TYPE_C: + desc.type =3D USB_PLUG_TYPE_C; + break; + default: + desc.type =3D USB_PLUG_NONE; + break; + } + + desc.active =3D !!(UCSI_CABLE_PROP_FLAG_ACTIVE_CABLE & con->cable_prop.fl= ags); + desc.pd_revision =3D UCSI_CABLE_PROP_FLAG_PD_MAJOR_REV_AS_BCD(con->cable_= prop.flags); + + cable =3D typec_register_cable(con->port, &desc); + if (IS_ERR(cable)) { + dev_err(con->ucsi->dev, + "con%d: failed to register cable (%ld)\n", con->num, + PTR_ERR(cable)); + return PTR_ERR(cable); + } + + con->cable =3D cable; + return 0; +} + +static void ucsi_unregister_cable(struct ucsi_connector *con) +{ + if (!con->cable) + return; + + typec_unregister_cable(con->cable); + con->cable =3D NULL; +} + static void ucsi_pwr_opmode_change(struct ucsi_connector *con) { switch (UCSI_CONSTAT_PWR_OPMODE(con->status.flags)) { @@ -807,6 +851,7 @@ static void ucsi_unregister_partner(struct ucsi_connect= or *con) typec_partner_set_usb_power_delivery(con->partner, NULL); ucsi_unregister_partner_pdos(con); ucsi_unregister_altmodes(con, UCSI_RECIPIENT_SOP); + ucsi_unregister_cable(con); typec_unregister_partner(con->partner); con->partner =3D NULL; } @@ -907,6 +952,28 @@ static int ucsi_check_connection(struct ucsi_connector= *con) return 0; } =20 +static int ucsi_check_cable(struct ucsi_connector *con) +{ + u64 command; + int ret; + + if (con->cable) + return 0; + + command =3D UCSI_GET_CABLE_PROPERTY | UCSI_CONNECTOR_NUMBER(con->num); + ret =3D ucsi_send_command(con->ucsi, command, &con->cable_prop, sizeof(co= n->cable_prop)); + if (ret < 0) { + dev_err(con->ucsi->dev, "GET_CABLE_PROPERTY failed (%d)\n", ret); + return ret; + } + + ret =3D ucsi_register_cable(con); + if (ret < 0) + return ret; + + return 0; +} + static void ucsi_handle_connector_change(struct work_struct *work) { struct ucsi_connector *con =3D container_of(work, struct ucsi_connector, @@ -948,6 +1015,7 @@ static void ucsi_handle_connector_change(struct work_s= truct *work) ucsi_register_partner(con); ucsi_partner_task(con, ucsi_check_connection, 1, HZ); ucsi_partner_task(con, ucsi_check_connector_capability, 1, HZ); + ucsi_partner_task(con, ucsi_check_cable, 1, HZ); =20 if (UCSI_CONSTAT_PWR_OPMODE(con->status.flags) =3D=3D UCSI_CONSTAT_PWR_OPMODE_PD) @@ -1346,6 +1414,7 @@ static int ucsi_register_port(struct ucsi *ucsi, stru= ct ucsi_connector *con) ucsi_register_partner(con); ucsi_pwr_opmode_change(con); ucsi_port_psy_changed(con); + ucsi_check_cable(con); } =20 /* Only notify USB controller if partner supports USB data */ diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h index 469a2baf472e..f0aabef0b7c6 100644 --- a/drivers/usb/typec/ucsi/ucsi.h +++ b/drivers/usb/typec/ucsi/ucsi.h @@ -265,6 +265,9 @@ struct ucsi_cable_property { #define UCSI_CABLE_PROPERTY_PLUG_TYPE_C 2 #define UCSI_CABLE_PROPERTY_PLUG_OTHER 3 #define UCSI_CABLE_PROP_FLAG_MODE_SUPPORT BIT(5) +#define UCSI_CABLE_PROP_FLAG_PD_MAJOR_REV(_f_) (((_f_) & GENMASK(7, 6)) >>= 6) +#define UCSI_CABLE_PROP_FLAG_PD_MAJOR_REV_AS_BCD(_f_) \ + UCSI_SPEC_REVISION_TO_BCD(UCSI_CABLE_PROP_FLAG_PD_MAJOR_REV(_f_)) u8 latency; } __packed; =20 @@ -400,6 +403,7 @@ struct ucsi_connector { =20 struct typec_port *port; struct typec_partner *partner; + struct typec_cable *cable; =20 struct typec_altmode *port_altmode[UCSI_MAX_ALTMODES]; struct typec_altmode *partner_altmode[UCSI_MAX_ALTMODES]; @@ -408,6 +412,7 @@ struct ucsi_connector { =20 struct ucsi_connector_status status; struct ucsi_connector_capability cap; + struct ucsi_cable_property cable_prop; struct power_supply *psy; struct power_supply_desc psy_desc; u32 rdo; --=20 2.44.0.rc0.258.g7320e95886-goog From nobody Sun Feb 8 10:50:21 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3F5DC2FE for ; Fri, 23 Feb 2024 01:04:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708650300; cv=none; b=jqAxQ6aQ0lUhAIvr19md3QnjQVY8of3eUzReCh9Jt7h6BEf6ufD3ERyu/i/IQUnnLHwzk6adbQC3KOUK3kY1oIrN1t8ozdVGIamvF7oGn4bCgEmtLioxMflfoILJJPqBuKWzu9FzaMzD0k47d80Cw2U8V0nCq5Mp1XJw6+cUn0w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708650300; c=relaxed/simple; bh=djqlNsa6R1dXZ3viePd2hZAocsyo8u3alB6TS2xk+fc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=CXr46ThMOCyobZ1xFdSofCNOsjjANteA0TXH5f0zF+pXwuHrzKSK0GJW/5GvNRtO+3CEzhMKsiALl9f6EvXi/NjoVUahxILcK3AHvf4to9LJHqCFwzWWOWjWG0vDNai871q4mvSrXqhirDJM0o8MSE3OGTL/jo2hIsS+GE86+Qk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jthies.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=4sMjwBCN; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jthies.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="4sMjwBCN" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dc693399655so566203276.1 for ; Thu, 22 Feb 2024 17:04:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708650298; x=1709255098; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=E/AmGDcfgM6pSbOLU88NIVIJmr/j1xj0yT5Nk8P+cUw=; b=4sMjwBCNo0/XmVxDVMWcjH0FcjZEvOB41tz9wHgC6JnxS3h11SGPl8vG9ApY0VYZxD wNN33XUemgWAais5SeIu0iqzcNM9hAJIN15FY5/unPgbaogqIqtkyIHh0Mbb6Q6aqxQw PWlYOllzTzpKzB1UJL8WpYliN7tUbKPH0B9QxUVx1C/KEsK+Peo0ubb/fqnJMVlx3FQ7 JLi558JE0NvoXxWqKmheq47q+fRjNrshO+0A7/kZQ4omu9eHlWFgkCnVnJtieRnHdTU3 sInSmaZpjIilfe2j2jR9I9VSPjMpgGvbrevMFJ/HXLg8Yqc7NHfKImMgATGfMn+ztP0V uLCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708650298; x=1709255098; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E/AmGDcfgM6pSbOLU88NIVIJmr/j1xj0yT5Nk8P+cUw=; b=oY+gzo/lHOvxBEjEGImwkGnlrujo4l4LsQ3QWro7gDFDuETDG3k2OzYSo5yhNRf5pZ ExoDvUtSAX9+K5Csnq5QZUb2Tr+7uRPljrsUJwfi42ZOHqxNtbbnveD3FFmJsB9JTGMi V2VpDttNckBZOLntbxSs4aZrfxAFH5NLNhgrWvawYD1mXw/LHs/vCioYaxusBIX4l3+m iqsrUPtKSZnP6sAQbQLD9aL9f9F+p0bjPDCQpCv10m6WXzP1vGIV5aaJbnfC+8K/rpfq akKLrx4abBJuX/gCzaJbzouIyWfTGuAP9QJatUhHdgk9ZST80R6xmFiqgwzOMRWHq5U1 e1tQ== X-Forwarded-Encrypted: i=1; AJvYcCULcjfDfaX2CfEnHsUDdMhxNNUNU8Ts04xpLSYSJiX2jgM1/vFWpJ1e15wT4ASlRokXoCwCY+qlHD4YSz0d0fl9Zxnms/39OuDmCFRz X-Gm-Message-State: AOJu0YyDeodFYnq+k6NBg9E2Rij3dttU1Vb1hL0cXKo4jZNg3re7IDih NiLvQVSe6f62KqiKj4qfFhCWumZufkI4cyYLyoFcmsV/BELiZd40S8idmc2LWWU1JX0WQ2GoHNk GmA== X-Google-Smtp-Source: AGHT+IE8KW+BV9Skf2PKiid4kOdLJB1IdEed7ZYX9DP0T1HouM2WC9WweAYs0HoDiJweNFtH83AFQh8xe9g= X-Received: from jthies.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:23db]) (user=jthies job=sendgmr) by 2002:a25:160b:0:b0:dc7:7ce9:fb4d with SMTP id 11-20020a25160b000000b00dc77ce9fb4dmr198675ybw.12.1708650297856; Thu, 22 Feb 2024 17:04:57 -0800 (PST) Date: Fri, 23 Feb 2024 01:03:27 +0000 In-Reply-To: <20240223010328.2826774-1-jthies@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240223010328.2826774-1-jthies@google.com> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog Message-ID: <20240223010328.2826774-4-jthies@google.com> Subject: [PATCH 3/4] usb: typec: ucsi: Register SOP/SOP' Discover Identity Responses From: Jameson Thies To: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org Cc: jthies@google.com, pmalani@chromium.org, bleung@google.com, abhishekpandit@chromium.org, andersson@kernel.org, dmitry.baryshkov@linaro.org, fabrice.gasnier@foss.st.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, neil.armstrong@linaro.org, rajaram.regupathy@intel.com, saranya.gopal@intel.com, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Register SOP and SOP' Discover Identity responses with the USB Type-C Connector Class as partner and cable identities, respectively. Discover Identity responses are requested from the PPM using the GET_PD_MESSAGE UCSI command. Signed-off-by: Jameson Thies Reviewed-by: Benson Leung Reviewed-by: Heikki Krogerus Reviewed-by: Prashant Malani --- Tested on v6.6 kernel. GET_PD_MESSAGE responses from the PPM populate partner and cable identity in sysfs. redrix-rev3 /sys/class/typec # ls port2-partner/identity/ cert_stat id_header product product_type_vdo1 product_type_vdo2 product_type_vdo3 redrix-rev3 /sys/class/typec # ls port2-cable/identity/ cert_stat id_header product product_type_vdo1 product_type_vdo2 product_type_vdo3 drivers/usb/typec/ucsi/ucsi.c | 77 +++++++++++++++++++++++++++++++++++ drivers/usb/typec/ucsi/ucsi.h | 29 +++++++++++++ 2 files changed, 106 insertions(+) diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index 15e82f5fab37..6d6443e61faa 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -646,6 +646,73 @@ static int ucsi_get_src_pdos(struct ucsi_connector *co= n) return ret; } =20 +static int ucsi_read_identity(struct ucsi_connector *con, u8 recipient, st= ruct usb_pd_identity *id) +{ + struct ucsi *ucsi =3D con->ucsi; + struct ucsi_pd_message_disc_id resp =3D {}; + u64 command; + int ret; + + /* + * Skip identity discovery and registration if UCSI version is less than + * v2.0. Before v2.0 MESSAGE_IN is 16 bytes which cannot fit a complete + * 24 byte identity response. + */ + if (ucsi->version < UCSI_VERSION_2_0) + return -EPROTO; + + command =3D UCSI_COMMAND(UCSI_GET_PD_MESSAGE) | UCSI_CONNECTOR_NUMBER(con= ->num); + command |=3D UCSI_GET_PD_MESSAGE_RECIPIENT(recipient); + /* VDM Header + 6 VDOs (0x1c bytes) without an offset */ + command |=3D UCSI_GET_PD_MESSAGE_OFFSET(0); + command |=3D UCSI_GET_PD_MESSAGE_BYTES(0x1c); + command |=3D UCSI_GET_PD_MESSAGE_TYPE(UCSI_GET_PD_MESSAGE_TYPE_IDENTITY); + + ret =3D ucsi_send_command(ucsi, command, &resp, sizeof(resp)); + if (ret < 0) { + dev_err(ucsi->dev, "UCSI_GET_PD_MESSAGE failed (%d)\n", ret); + return ret; + } + + id->id_header =3D resp.id_header; + id->cert_stat =3D resp.cert_stat; + id->product =3D resp.product; + id->vdo[0] =3D resp.vdo[0]; + id->vdo[1] =3D resp.vdo[1]; + id->vdo[2] =3D resp.vdo[2]; + return 0; +} + +static int ucsi_get_partner_identity(struct ucsi_connector *con) +{ + int ret; + + ret =3D ucsi_read_identity(con, UCSI_RECIPIENT_SOP, &con->partner_identit= y); + if (ret < 0) + return ret; + + ret =3D typec_partner_set_identity(con->partner); + if (ret < 0) + dev_err(con->ucsi->dev, "Failed to set partner identity (%d)\n", ret); + + return ret; +} + +static int ucsi_get_cable_identity(struct ucsi_connector *con) +{ + int ret; + + ret =3D ucsi_read_identity(con, UCSI_RECIPIENT_SOP_P, &con->cable_identit= y); + if (ret < 0) + return ret; + + ret =3D typec_cable_set_identity(con->cable); + if (ret < 0) + dev_err(con->ucsi->dev, "Failed to set cable identity (%d)\n", ret); + + return ret; +} + static int ucsi_check_altmodes(struct ucsi_connector *con) { int ret, num_partner_am; @@ -754,6 +821,7 @@ static int ucsi_register_cable(struct ucsi_connector *c= on) break; } =20 + desc.identity =3D &con->cable_identity; desc.active =3D !!(UCSI_CABLE_PROP_FLAG_ACTIVE_CABLE & con->cable_prop.fl= ags); desc.pd_revision =3D UCSI_CABLE_PROP_FLAG_PD_MAJOR_REV_AS_BCD(con->cable_= prop.flags); =20 @@ -776,6 +844,7 @@ static void ucsi_unregister_cable(struct ucsi_connector= *con) =20 typec_unregister_cable(con->cable); con->cable =3D NULL; + memset(&con->cable_identity, 0, sizeof(con->cable_identity)); } =20 static void ucsi_pwr_opmode_change(struct ucsi_connector *con) @@ -825,6 +894,7 @@ static int ucsi_register_partner(struct ucsi_connector = *con) break; } =20 + desc.identity =3D &con->partner_identity; desc.usb_pd =3D pwr_opmode =3D=3D UCSI_CONSTAT_PWR_OPMODE_PD; desc.pd_revision =3D UCSI_CONCAP_FLAG_PARTNER_PD_MAJOR_REV_AS_BCD(con->ca= p.flags); =20 @@ -854,6 +924,7 @@ static void ucsi_unregister_partner(struct ucsi_connect= or *con) ucsi_unregister_cable(con); typec_unregister_partner(con->partner); con->partner =3D NULL; + memset(&con->partner_identity, 0, sizeof(con->partner_identity)); } =20 static void ucsi_partner_change(struct ucsi_connector *con) @@ -971,6 +1042,10 @@ static int ucsi_check_cable(struct ucsi_connector *co= n) if (ret < 0) return ret; =20 + ret =3D ucsi_get_cable_identity(con); + if (ret < 0) + return ret; + return 0; } =20 @@ -1015,6 +1090,7 @@ static void ucsi_handle_connector_change(struct work_= struct *work) ucsi_register_partner(con); ucsi_partner_task(con, ucsi_check_connection, 1, HZ); ucsi_partner_task(con, ucsi_check_connector_capability, 1, HZ); + ucsi_partner_task(con, ucsi_get_partner_identity, 1, HZ); ucsi_partner_task(con, ucsi_check_cable, 1, HZ); =20 if (UCSI_CONSTAT_PWR_OPMODE(con->status.flags) =3D=3D @@ -1414,6 +1490,7 @@ static int ucsi_register_port(struct ucsi *ucsi, stru= ct ucsi_connector *con) ucsi_register_partner(con); ucsi_pwr_opmode_change(con); ucsi_port_psy_changed(con); + ucsi_get_partner_identity(con); ucsi_check_cable(con); } =20 diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h index f0aabef0b7c6..b89fae82e8ce 100644 --- a/drivers/usb/typec/ucsi/ucsi.h +++ b/drivers/usb/typec/ucsi/ucsi.h @@ -106,6 +106,7 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num); #define UCSI_GET_CABLE_PROPERTY 0x11 #define UCSI_GET_CONNECTOR_STATUS 0x12 #define UCSI_GET_ERROR_STATUS 0x13 +#define UCSI_GET_PD_MESSAGE 0x15 =20 #define UCSI_CONNECTOR_NUMBER(_num_) ((u64)(_num_) << 16) #define UCSI_COMMAND(_cmd_) ((_cmd_) & 0xff) @@ -159,6 +160,18 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num); #define UCSI_MAX_PDOS (4) #define UCSI_GET_PDOS_SRC_PDOS ((u64)1 << 34) =20 +/* GET_PD_MESSAGE command bits */ +#define UCSI_GET_PD_MESSAGE_RECIPIENT(_r_) ((u64)(_r_) << 23) +#define UCSI_GET_PD_MESSAGE_OFFSET(_r_) ((u64)(_r_) << 26) +#define UCSI_GET_PD_MESSAGE_BYTES(_r_) ((u64)(_r_) << 34) +#define UCSI_GET_PD_MESSAGE_TYPE(_r_) ((u64)(_r_) << 42) +#define UCSI_GET_PD_MESSAGE_TYPE_SNK_CAP_EXT 0 +#define UCSI_GET_PD_MESSAGE_TYPE_SRC_CAP_EXT 1 +#define UCSI_GET_PD_MESSAGE_TYPE_BAT_CAP 2 +#define UCSI_GET_PD_MESSAGE_TYPE_BAT_STAT 3 +#define UCSI_GET_PD_MESSAGE_TYPE_IDENTITY 4 +#define UCSI_GET_PD_MESSAGE_TYPE_REVISION 5 + /* -----------------------------------------------------------------------= --- */ =20 /* Error information returned by PPM in response to GET_ERROR_STATUS comma= nd. */ @@ -338,6 +351,18 @@ struct ucsi_connector_status { ((get_unaligned_le32(&(_p_)[5]) & GENMASK(16, 1)) >> 1) } __packed; =20 +/* + * Data structure filled by PPM in response to GET_PD_MESSAGE command with= the + * Response Message Type set to Discover Identity Response. + */ +struct ucsi_pd_message_disc_id { + u32 vdm_header; + u32 id_header; + u32 cert_stat; + u32 product; + u32 vdo[3]; +} __packed; + /* -----------------------------------------------------------------------= --- */ =20 struct ucsi_debugfs_entry { @@ -428,6 +453,10 @@ struct ucsi_connector { struct usb_power_delivery_capabilities *partner_sink_caps; =20 struct usb_role_switch *usb_role_sw; + + /* USB PD identity */ + struct usb_pd_identity partner_identity; + struct usb_pd_identity cable_identity; }; =20 int ucsi_send_command(struct ucsi *ucsi, u64 command, --=20 2.44.0.rc0.258.g7320e95886-goog From nobody Sun Feb 8 10:50:21 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE566F9E0 for ; Fri, 23 Feb 2024 01:05:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708650304; cv=none; b=USjw5f7mF0TTJTeT5u5qL0JpXNgOx4mMDc11T/krE80FFHvBwB3e3AplPD+JzgVxrJFwBWqnsDiF2AxCBkZv/pErmyrsJ29g7RBePyNp853ywEwk/zyVNpPYs14RSTVJoT8WmU1Q5RI3GfAcb7rp+Y+14IbTdt6z1XKjcP8JWpo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708650304; c=relaxed/simple; bh=qGvxPb9wBNo74qyixFNMzC5WpsOmHQBVgooo0liTEMQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=cB3CGyXigt59/70KpBtZC9L857Dt1ZA0YPCFWJj4YYZFqQESBrMBtq0E7BZ0UlF/GSybKoQLpAywzGclM/TtNVaS7XpiqXdogIWdmBiRxI/kqDDhkeP3g1j0zN7T3xg/emB6lJbqYDFluW/gAzfNJvt7pmMDzLD6/DPa+K+eS3A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jthies.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=RIawMauK; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jthies.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RIawMauK" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dccc49ef73eso511053276.2 for ; Thu, 22 Feb 2024 17:05:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708650302; x=1709255102; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=SfnrjBnv6BQLK9jEvV+2jcZHgVods2JgdI/a3aIK/Hg=; b=RIawMauK6dglklq7bJsuGxYAINPh+ApIup/nn8UfQwGvD4qL8UiAjniCbTMzJmWJo2 W+8+5DCvrEKo0QmHjhV8H18VKrK6o9gux2M1Lk4yn3XQVObd186qn/Y814HZtLp8Bga5 9PAnrcdxhnFvnfr0OCTS3QnDmWAE90fJ4mxu2o7tLWxhgVOMkTIvGfCrqJzdZOQnVkx/ C9XBpqzp9vK5FeTaKQlkVNfDP0Q4dReg9020u+QrrmNckcSFjwskbNQH4KSkf5sYZokY Harp8+YUM37m5mipGfmLJ8afDol6FJriPL9zGHSDNvD2wk+jMJpkHRp59wZTj0nH0RrD qUKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708650302; x=1709255102; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SfnrjBnv6BQLK9jEvV+2jcZHgVods2JgdI/a3aIK/Hg=; b=I2++fhi2V30VkjzMaDrRKlF9RD2umK4wPyr1H7A3+bXZvSSRhT5bZpvU4R4tgAibTE N9qorcSF3x0WCQQCeYTWPPWVyXfaoi9VJsrwryV48bJB7iAfeAILpMUv6QZmUbE6v3m2 Qe/TlbujVC1N/W2wE9nCkoqLGm/0kCZnGICfuePnB3i121zK2Tmyh0wX3EteinkUPHiR hoDUplSsgoNC6ySN9naAK7sbBM9QHcuycJEf6/RbLAudchzqMwuys5o4bFT+5wgnKc92 wuDkB6TFNN6s/n7SNLhExhS11EB7EJj8QnsPXjgdgabw0RzDXIAG9poLsFDu5sqqx20e ySDw== X-Forwarded-Encrypted: i=1; AJvYcCW1mBEGY7KKzgpoI5qotI6xOiucy3iOXC2WOtjM3MKFVJeUSJg3KQrKnkDclNhf6wwLfGFkDER7r+HdPv0yg0WF7RDJGWP2Vt/C1PCU X-Gm-Message-State: AOJu0YzsaEuVvVTB0pZz3RZmlDi0bGDiqK+miWfTzJsmMIFiWzYy4ElF zmTv5h4pTdsfUh0bg0D6LMFmkyvjVSosJ9GdBptzKAgJR/0jkdDlEN+BcuzOECGQJOljJ1/Au2g EGA== X-Google-Smtp-Source: AGHT+IHsrtZJ1Y2yJh2vWG/92/vGGtCGaCqZx8RLto3Oa1J1XPVKZ8hDFBaEnXp8vdfKzzBfgbY83a/+iyU= X-Received: from jthies.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:23db]) (user=jthies job=sendgmr) by 2002:a05:6902:1146:b0:dc6:d9eb:6422 with SMTP id p6-20020a056902114600b00dc6d9eb6422mr27236ybu.10.1708650301885; Thu, 22 Feb 2024 17:05:01 -0800 (PST) Date: Fri, 23 Feb 2024 01:03:28 +0000 In-Reply-To: <20240223010328.2826774-1-jthies@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240223010328.2826774-1-jthies@google.com> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog Message-ID: <20240223010328.2826774-5-jthies@google.com> Subject: [PATCH 4/4] usb: typec: ucsi: Register SOP' alternate modes with cable plug From: Jameson Thies To: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org Cc: jthies@google.com, pmalani@chromium.org, bleung@google.com, abhishekpandit@chromium.org, andersson@kernel.org, dmitry.baryshkov@linaro.org, fabrice.gasnier@foss.st.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, neil.armstrong@linaro.org, rajaram.regupathy@intel.com, saranya.gopal@intel.com, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Register SOP' alternate modes with a Type-C Connector Class cable plug. Alternate modes are queried from the PPM using the GET_ALTERNATE_MODES command with recipient set to SOP'. Signed-off-by: Jameson Thies Reviewed-by: Benson Leung Reviewed-by: Heikki Krogerus Reviewed-by: Prashant Malani --- Tested on v6.6 kernel. SOP' GET_ALTERNATE_MODE responses from the PPM are correctly registered as to the cable plug. redrix-rev3 /sys/class/typec # ls port2-cable/port2-plug0/ device port2-plug0.0 port2-plug0.1 power subsystem uevent drivers/usb/typec/ucsi/ucsi.c | 60 +++++++++++++++++++++++++++++++++++ drivers/usb/typec/ucsi/ucsi.h | 2 ++ 2 files changed, 62 insertions(+) diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index 6d6443e61faa..9b541547917b 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -399,6 +399,27 @@ static int ucsi_register_altmode(struct ucsi_connector= *con, =20 con->partner_altmode[i] =3D alt; break; + case UCSI_RECIPIENT_SOP_P: + i =3D ucsi_next_altmode(con->plug_altmode); + if (i < 0) { + ret =3D i; + goto err; + } + + ret =3D ucsi_altmode_next_mode(con->plug_altmode, desc->svid); + if (ret < 0) + return ret; + + desc->mode =3D ret; + + alt =3D typec_plug_register_altmode(con->plug, desc); + if (IS_ERR(alt)) { + ret =3D PTR_ERR(alt); + goto err; + } + + con->plug_altmode[i] =3D alt; + break; default: return -EINVAL; } @@ -566,6 +587,9 @@ static void ucsi_unregister_altmodes(struct ucsi_connec= tor *con, u8 recipient) case UCSI_RECIPIENT_SOP: adev =3D con->partner_altmode; break; + case UCSI_RECIPIENT_SOP_P: + adev =3D con->plug_altmode; + break; default: return; } @@ -801,6 +825,33 @@ static void ucsi_unregister_partner_pdos(struct ucsi_c= onnector *con) con->partner_pd =3D NULL; } =20 +static int ucsi_register_plug(struct ucsi_connector *con) +{ + struct typec_plug *plug; + struct typec_plug_desc desc =3D {.index =3D TYPEC_PLUG_SOP_P}; + + plug =3D typec_register_plug(con->cable, &desc); + if (IS_ERR(plug)) { + dev_err(con->ucsi->dev, + "con%d: failed to register plug (%ld)\n", con->num, + PTR_ERR(plug)); + return PTR_ERR(plug); + } + + con->plug =3D plug; + return 0; +} + +static void ucsi_unregister_plug(struct ucsi_connector *con) +{ + if (!con->plug) + return; + + ucsi_unregister_altmodes(con, UCSI_RECIPIENT_SOP_P); + typec_unregister_plug(con->plug); + con->plug =3D NULL; +} + static int ucsi_register_cable(struct ucsi_connector *con) { struct typec_cable *cable; @@ -842,6 +893,7 @@ static void ucsi_unregister_cable(struct ucsi_connector= *con) if (!con->cable) return; =20 + ucsi_unregister_plug(con); typec_unregister_cable(con->cable); con->cable =3D NULL; memset(&con->cable_identity, 0, sizeof(con->cable_identity)); @@ -1046,6 +1098,14 @@ static int ucsi_check_cable(struct ucsi_connector *c= on) if (ret < 0) return ret; =20 + ret =3D ucsi_register_plug(con); + if (ret < 0) + return ret; + + ret =3D ucsi_register_altmodes(con, UCSI_RECIPIENT_SOP_P); + if (ret < 0) + return ret; + return 0; } =20 diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h index b89fae82e8ce..32daf5f58650 100644 --- a/drivers/usb/typec/ucsi/ucsi.h +++ b/drivers/usb/typec/ucsi/ucsi.h @@ -429,9 +429,11 @@ struct ucsi_connector { struct typec_port *port; struct typec_partner *partner; struct typec_cable *cable; + struct typec_plug *plug; =20 struct typec_altmode *port_altmode[UCSI_MAX_ALTMODES]; struct typec_altmode *partner_altmode[UCSI_MAX_ALTMODES]; + struct typec_altmode *plug_altmode[UCSI_MAX_ALTMODES]; =20 struct typec_capability typec_cap; =20 --=20 2.44.0.rc0.258.g7320e95886-goog