From nobody Sun Feb 8 17:28:50 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B220111AD; Fri, 23 Feb 2024 03:49:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708660191; cv=none; b=GkMFxlqxfFx/3nALp0zmDN5tuM3WlDxIzGVUTZTKqIm2mpRKXc2M1mwq7STOiLt61POIDhyN32C8FymIopJY+lDJW7KvWcilQ1FiJiN90Yk9dQ5wzvLgEbVIbP4YDCd/zvdD//I2BLZBn5v5mBdNsLhp7SHBxdbZwAZOlDExx4Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708660191; c=relaxed/simple; bh=UboJhJ2Na49LW6G1cI5tL0fPvFZ/OZtE9CHN8NnGtQg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nAWm+2qFTos/DU/Jtfqyqon5Dpv+UFiAd8DGMldXQiOetroI/f79dcEd9x0ziHHtcV0EZvtMDF2Gu+7J1mZAiU2gnXJwJCyemM1FCVFwHqjYW8hZQyI9pMpGo+N5mFTvbv0fhcC0Tujv4sBF9Vgth5qERACkQIO5z7RdSy7tb0k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ya0ITmGn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ya0ITmGn" Received: by smtp.kernel.org (Postfix) with ESMTPS id 8F7E6C43390; Fri, 23 Feb 2024 03:49:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708660190; bh=UboJhJ2Na49LW6G1cI5tL0fPvFZ/OZtE9CHN8NnGtQg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Ya0ITmGnjSbud6eY+M2zJYNLSPlF/cHUyzAAwLl/fcuEGiN+S5QyQvNxNzXtpY0k1 y+OdiwNDq8OIpP8AcNXy2F+Bv7+PyX5P/oUI3MQ0Z/fbtQWgyl8nJwrJkluxHpz72w S6DRCL/8bcl7yGpSS/n7HBc9yY9PrA0zS/MGQ7tm8Wm0szgb3u6hrsk111OUdp9GW+ cyMHm3gEmg7aZ/AHh2K9ZgySOmGLJzAcdKMBrnD0QZo4b76rjekoQFNyFCb/iDIGCL An5dQBtVJHyQcXVLvqIDCiGl/inHk5ZgT1V54IxlVlpMzAv4yYrfW3gWRiQpeEbjni PBas63Jh1GzzQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D7F7C54E41; Fri, 23 Feb 2024 03:49:50 +0000 (UTC) From: Yang Xiwen via B4 Relay Date: Fri, 23 Feb 2024 11:49:46 +0800 Subject: [PATCH 1/2] dt-bindings: simple-pm-bus: Add optional resets Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240223-b4-bus-v1-1-2803c3ac4673@outlook.com> References: <20240223-b4-bus-v1-0-2803c3ac4673@outlook.com> In-Reply-To: <20240223-b4-bus-v1-0-2803c3ac4673@outlook.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Philipp Zabel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Xiwen X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1708660187; l=1458; i=forbidden405@outlook.com; s=20230724; h=from:subject:message-id; bh=eDExkZ8ch9F2IC6H0Bh6sbmnrZwqE83QU/hncSN1udA=; b=Ix+IGJnk37tLr6KiqN56bHt+twAmHGwLNjd3rCsPg1w/s3+c1zqNBQAm4VYR5tNYNB3gGUKd4 lH6Meg3a0efD6SNUtc6v4IvRoM3GZA/sMRdx2ufsfbT63ahePugNiRL X-Developer-Key: i=forbidden405@outlook.com; a=ed25519; pk=qOD5jhp891/Xzc+H/PZ8LWVSWE3O/XCQnAg+5vdU2IU= X-Endpoint-Received: by B4 Relay for forbidden405@outlook.com/20230724 with auth_id=67 X-Original-From: Yang Xiwen Reply-To: From: Yang Xiwen For some on-soc buses, it is also needed to deassert the resets before access. Document it in the binding. Signed-off-by: Yang Xiwen Reviewed-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/bus/simple-pm-bus.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml b/Doc= umentation/devicetree/bindings/bus/simple-pm-bus.yaml index 182134d7a6a3..430638104980 100644 --- a/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml +++ b/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml @@ -14,8 +14,9 @@ description: | driver, as it's typically initialized by the boot loader. =20 However, its bus controller is part of a PM domain, or under the control - of a functional clock. Hence, the bus controller's PM domain and/or - clock must be enabled for child devices connected to the bus (either + of a functional clock, and it might have a reset control signal. Hence, + the bus controller's PM domain and/or clock must be enabled, reset contr= ol + signal must be deasserted for child devices connected to the bus (either on-SoC or externally) to function. =20 While "simple-pm-bus" follows the "simple-bus" set of properties, as @@ -49,6 +50,8 @@ properties: # Required if clocks is absent, optional otherwise minItems: 1 =20 + resets: true + required: - compatible - '#address-cells' --=20 2.43.0 From nobody Sun Feb 8 17:28:50 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B256111B5; Fri, 23 Feb 2024 03:49:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708660191; cv=none; b=m6Gv8wP1R1wnrf/Hairuiv60/0tUenJA1UDIXvOnqSEqDhTIvbqVebzRUg1kDrXnvZDdnNB/EZlUrwxaNl6FukPD3ScDesGDEdiEjyd7Us4X1B8YrsDGGlcFVKhakaJJlH8k18wiRuBzL//jPpqT+r6Wgi2hr/yxohmc6bnI7Y8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708660191; c=relaxed/simple; bh=TWYzt4cWE702k5VOaGpWj9p2plXpYzNDkLilGGhbLfg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TTEH5YVBXzjxuVjcHy3WRjyT0Ug6AD5o325xNoz27jt2aRl/YMhK8Dwa9ibEdp2G3dpinLtV93km3ITK7vaPauxxGJKEnK6hdFmwdGEt+TwfMXQGfJyXu7rwXHDog7Iv0YZt9abVoKUdoihLmNaqMSB8w1oDlQ93YgcqPCbhZqM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jqc+9AuQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jqc+9AuQ" Received: by smtp.kernel.org (Postfix) with ESMTPS id 9B710C433A6; Fri, 23 Feb 2024 03:49:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708660190; bh=TWYzt4cWE702k5VOaGpWj9p2plXpYzNDkLilGGhbLfg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=jqc+9AuQt9R+RFyxDbEXLasVKrOHbloI3R9NUuBgLCLw7/qNkRGQx0FDzweBtoO72 h8brlCRB+MH8L+ZcTFyn5hme99s75Bi4yFwxKyGPpJ4Dj0L/tBbkaugzGVP/g4LT7D Bh5xkGwUVOqQrB4h7m3JUjxin/esA1qWVU0H3qXtdTAchnGWLRNcKiHzENybnHXQa0 a3vZczf0lGAJUw+60ovLSDoKFZS0KmDHZikCSuPGWL2NTUE3fDZkmzHKr/+i9DMuNP UYKuuqo0AXBvrepPVMMFUkCKqGgtXhxXOx2NvUUexnBYpwTMlAtAwGKrbCzHQcBGdR URzHf17w2vt4w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E373C54798; Fri, 23 Feb 2024 03:49:50 +0000 (UTC) From: Yang Xiwen via B4 Relay Date: Fri, 23 Feb 2024 11:49:47 +0800 Subject: [PATCH 2/2] drivers: bus: simple-pm-bus: Get and deassert resets exclusively Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240223-b4-bus-v1-2-2803c3ac4673@outlook.com> References: <20240223-b4-bus-v1-0-2803c3ac4673@outlook.com> In-Reply-To: <20240223-b4-bus-v1-0-2803c3ac4673@outlook.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Philipp Zabel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Xiwen X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1708660187; l=1979; i=forbidden405@outlook.com; s=20230724; h=from:subject:message-id; bh=JWFA4aEPe9UmKX/cnL2dAlkZhpNjtIvdqZ32qXjuGyM=; b=qcHy1AJ2U0hzEwKWQHgC3iK0+xqjk8WbWl2uq7fhr6LqaRXcHt0ct/VyrmF1YNi9UhZRUXtJi 6PhcXTFCv+eBZKsu7+gUxThU6jlKAvTTFu0oUsKCCNpUvnj66v+mIiW X-Developer-Key: i=forbidden405@outlook.com; a=ed25519; pk=qOD5jhp891/Xzc+H/PZ8LWVSWE3O/XCQnAg+5vdU2IU= X-Endpoint-Received: by B4 Relay for forbidden405@outlook.com/20230724 with auth_id=67 X-Original-From: Yang Xiwen Reply-To: From: Yang Xiwen Simple Power-Managed bus controller may need functional reset(s) to be deasserted before child devices connected to the bus can be accessed. Get the reset(s) as an array and assert/deassert the reset(s) when the bus is being power managed. One example is that HiSilicon USB2 INNO PHY test bus needs to deassert the reset to the bus before accessing its registers. Signed-off-by: Yang Xiwen Reviewed-by: Geert Uytterhoeven --- drivers/bus/simple-pm-bus.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/bus/simple-pm-bus.c b/drivers/bus/simple-pm-bus.c index 50870c827889..d84dbd61c02b 100644 --- a/drivers/bus/simple-pm-bus.c +++ b/drivers/bus/simple-pm-bus.c @@ -16,9 +16,11 @@ #include #include #include +#include =20 struct simple_pm_bus { struct clk_bulk_data *clks; + struct reset_control *rsts; int num_clks; }; =20 @@ -62,6 +64,10 @@ static int simple_pm_bus_probe(struct platform_device *p= dev) if (bus->num_clks < 0) return dev_err_probe(&pdev->dev, bus->num_clks, "failed to get clocks\n"= ); =20 + bus->rsts =3D devm_reset_control_array_get(dev, false, true); + if (IS_ERR(bus->rsts)) + return dev_err_probe(&pdev->dev, PTR_ERR(bus->rsts), "failed to get rese= ts\n"); + dev_set_drvdata(&pdev->dev, bus); =20 dev_dbg(&pdev->dev, "%s\n", __func__); @@ -92,7 +98,7 @@ static int simple_pm_bus_runtime_suspend(struct device *d= ev) =20 clk_bulk_disable_unprepare(bus->num_clks, bus->clks); =20 - return 0; + return reset_control_assert(bus->rsts); } =20 static int simple_pm_bus_runtime_resume(struct device *dev) @@ -106,6 +112,12 @@ static int simple_pm_bus_runtime_resume(struct device = *dev) return ret; } =20 + ret =3D reset_control_deassert(bus->rsts); + if (ret) { + dev_err(dev, "failed to deassert resets: %d\n", ret); + return ret; + } + return 0; } =20 --=20 2.43.0