From nobody Mon Feb 9 04:44:30 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5A8C12D21B for ; Thu, 22 Feb 2024 22:00:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708639262; cv=none; b=ip0CaxKLh5MhLWZokrONxeOgFfS+g0njsTRByNKAaCgKl2eYjRBSon4WwhlvdR/gYZEFIDpDEWz6UBm6ei2HcXuf2hIYF+qUuuotVPAZinNOyBIva2RGwcT9zLr+937e4zZLZNqOsxEPlZ9EGPUrUsHa7QhA940Nd2ebkcmclhE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708639262; c=relaxed/simple; bh=uhlU0x25jSC/q8kWZ2CYfZhoRlBn6ETL7DGvp44hrLQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JjKysw0rMSFg9/wDMnc7au9Wg7G50NhaBxSlvDcer4/i+1n/rrjjz6HAT9Gjk46ylWK2aGDpRSL72vuI/F66N4pstQiF1GA9ggNz6zIYt2zmYekk5ZLdWd+ZMiBs30GMxm5LywRAD7BGZmm49NYsNcjfFnYhVJBdO1SoQs8Osec= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=JGOW/mVS; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JGOW/mVS" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-299b92948a6so218970a91.3 for ; Thu, 22 Feb 2024 14:00:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708639257; x=1709244057; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XcbwdGDEaXBLUYjumpG+gsDxnRVJcIomd9ygoS90Aw8=; b=JGOW/mVSDOwED/5uKl5hS/1fbO18yhoJZjlAl/nKaWC9D3onMozCO6z/nL9HZR5WwY aLqOFBzPw9h6r1FqiqIA4lUOHUhlSOHS8lzv896X5ZlQvTatqET6i1e2bGCRzeg5+8ZE RBuUdOeY8uj/x05g0cLgzKhozGJTZcLWtTObs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708639257; x=1709244057; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XcbwdGDEaXBLUYjumpG+gsDxnRVJcIomd9ygoS90Aw8=; b=IUP+OBJEJBARoxgpioFo1/0Su4Y+B9GqM2FqFBKthaVGiazWruZKGukXC/bHU3x4AS kYWx+rS4KAcsQF4M3yTD2nRlPtaa7nvqn+al+I9wCfsr/4khI0V7eG9XqFFoQWNNZIXm 8gmOHQIzLXw4xIMMdC/OhuyrANx0/ny5rPf4QA7RBp7l9sDH50LPtsPdS+2Nznm4iwhr AZjn37h8gmt/nG5VmYyyvLRjTFrKAlx/WnEGmLRM9yBX0xYPQ/3z239am6xVMJGpUwGr PDlE9J2G3/ObHMeRIFbOdv40sERkbhQX/t8dJVZMBob443plaLg581IqYpJfIwNQizHw c+JQ== X-Forwarded-Encrypted: i=1; AJvYcCV/495tUxbhmZcl6eb2NLy4c7zq2f8KdwMUSL5fKgEv7kofifD7CqH/rt+o/irRI0l5nYtXgDZc/u1kH/wn2kKfWnjdLA/wK1G7NOsN X-Gm-Message-State: AOJu0Yy+KMK6pTH23bsZRkc15wVpMgkSPGL1MTFtidL4NTeXiUdGCmJ9 ARLfSTrQf64S1WPhsIWs/zZDm22EKKUiZkLpVgWbjOZGOBjg2j6AdtTDRTGiDQ== X-Google-Smtp-Source: AGHT+IGEnaDaYf0U9Tc/6ed2/idKNsq2JaDrlj/AU6Efhg5NWtvvNhaEDnNplUOrc4XSt3GIg9dA7w== X-Received: by 2002:a17:90a:d504:b0:299:4f5a:62d5 with SMTP id t4-20020a17090ad50400b002994f5a62d5mr105371pju.18.1708639257389; Thu, 22 Feb 2024 14:00:57 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id qn3-20020a17090b3d4300b00298f88c3e48sm4527739pjb.11.2024.02.22.14.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 14:00:54 -0800 (PST) From: Kees Cook To: Tycho Andersen Cc: Kees Cook , "Tobin C. Harding" , linux-hardening@vger.kernel.org, Greg Kroah-Hartman , Guixiong Wei , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/4] leaking_addresses: Use File::Temp for /tmp files Date: Thu, 22 Feb 2024 14:00:49 -0800 Message-Id: <20240222220053.1475824-2-keescook@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240222215755.it.764-kees@kernel.org> References: <20240222215755.it.764-kees@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1548; i=keescook@chromium.org; h=from:subject; bh=uhlU0x25jSC/q8kWZ2CYfZhoRlBn6ETL7DGvp44hrLQ=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBl18QSRxHv+PncBp1jAJSRPYWJFFgg3pzsNc/fN mCVDwrb19WJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCZdfEEgAKCRCJcvTf3G3A JjY1EACmTYoMq33mIDZg1J1ccpxT9rC05SHFddeTqn6AUUuJ2ooqezEOEfFFA27Ddk8ijg1xGM3 pp4Tl54ejn2YBtA10Jgllds3r5mmkKrfT2GkefLJzqOrNQSrWvohbvcv8kLDmDMeO+xEGf1hHr8 eGKI0ugKLeqPQ6fsCshEypj7+DRbcGmGjdU3/8yWhetBF2iD9R549t+vGn+CWEPvfiM6xTCq+ys doU62myz1PWLLntN8N5b09Hn0H2+ab4U+n8TOmOFV1eqNeIDI2jZFhRs1wBbfyCWdpanhHeOmse KboyhOh0Mw6EyT7FX/SC0uWN8lhCosFPLHScOu+HjwQTdn1b7jfZHCbLzkelij2t+00aZ15bMno G9Pxpi9NI7Wx4+K2iXkxDy9+wRcXr1ThOzZWrFDR1MB6PJ5YUFR2WT/jg+LgNmm8KGdcQyhRimt XVfXyHjAkkwmjJNMQpC/aJSXPiI40cTx2Lilx477BccSMsaiCjxbu6hKS91lNIiTikPOeZWZXo1 1ipvTqdK/uI7PP6reIDKhBHaqDKX/o6RRO5K1bOyGN+HJuBJPCvZUW1iwW8eyCaNQYSffKr2Z6o Bm1ejWbbi9wdH5jfO5G41DPQL/oKjxnpQ+fEnMvnE8obItWSmlcsJbRlTR8kolHtrcyAH1fapd1 8SXzHvi1BdKbcLw== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of using a statically named path in /tmp, use File::Temp to create (and remove) the temporary file used for parsing /proc/config.gz. Signed-off-by: Kees Cook --- Cc: Tycho Andersen Cc: "Tobin C. Harding" Cc: linux-hardening@vger.kernel.org --- scripts/leaking_addresses.pl | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl index e695634d153d..dd05fbcf15c5 100755 --- a/scripts/leaking_addresses.pl +++ b/scripts/leaking_addresses.pl @@ -23,6 +23,7 @@ use strict; use POSIX; use File::Basename; use File::Spec; +use File::Temp qw/tempfile/; use Cwd 'abs_path'; use Term::ANSIColor qw(:constants); use Getopt::Long qw(:config no_auto_abbrev); @@ -221,6 +222,7 @@ sub get_kernel_config_option { my ($option) =3D @_; my $value =3D ""; + my $tmp_fh; my $tmp_file =3D ""; my @config_files; =20 @@ -228,7 +230,8 @@ sub get_kernel_config_option if ($kernel_config_file ne "") { @config_files =3D ($kernel_config_file); } elsif (-R "/proc/config.gz") { - my $tmp_file =3D "/tmp/tmpkconf"; + ($tmp_fh, $tmp_file) =3D tempfile("config.gz-XXXXXX", + UNLINK =3D> 1); =20 if (system("gunzip < /proc/config.gz > $tmp_file")) { dprint("system(gunzip < /proc/config.gz) failed\n"); @@ -250,10 +253,6 @@ sub get_kernel_config_option } } =20 - if ($tmp_file ne "") { - system("rm -f $tmp_file"); - } - return $value; } =20 --=20 2.34.1