From nobody Sun Feb 8 12:15:01 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABA8353E1E; Mon, 19 Feb 2024 21:27:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708378079; cv=none; b=DFNcgaPgl0HewozGJF5kRhJ0d7ws7Ruo0PxKg7mQtO7ZreyOf3FAJr6lWFUIldX2GSquFRODGw+Mg2hdeAYW24cVpBbCeghHT+5Ru1+zN8Y1Hr3hC3sEqLcXPGwLC0PyYGtDRMG02ZEzsQMu/4yY8gD1Mg1tva7Bz++maPllhRM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708378079; c=relaxed/simple; bh=mxN1ZkEXW2mgTzfWWUyIZjDudn+fs3HVQgmWVyZDq4A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=A4VwMtfhiblIqwcWRn65ChSt1ZnGqsp+NODV5X7qFpeDVaQ4sB66nFJDnQzxr6kE8jXgO6wAPDUOxWWuSFNfiFEOVjoXQa9A6htSo2mNCh3CcmxUD1N9GKrqY7JW7rYzV+aEYLewXOh7FpS3snScPWght9YH7yx0a6Kg7TUgmrU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y2QOFmIR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y2QOFmIR" Received: by smtp.kernel.org (Postfix) with ESMTPS id 36231C433C7; Mon, 19 Feb 2024 21:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708378079; bh=mxN1ZkEXW2mgTzfWWUyIZjDudn+fs3HVQgmWVyZDq4A=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Y2QOFmIRHjyFbPkJMUN51fXL0P40hmihbedRpirrjAD3xk7igcPVnvCqOgPId1JVK LzRLk3KL1xOd0nLHmdLeuB673w5QCtnUgzWsJCk8cwl4C3iqmHcwbThPIRsVICe8Dl MkB+b9fM7JYVXO4oSYMjIALtwmNWq7WNFQl94t+Q7YZt6GRfTQ0qkf8+xFXd+K4Zqk ib2vZiYIDPw1ppwISvyVIGmP6DUWzc4dt4uVEnEDM2aoGt5CsEZWSi2np8O5xPQ3rK P7n0PuiIG1oqvXOKmhNcVwryCW9VNo8qgu9aPI4146oY5YaQDtzdNBkkWTI2er6DW2 DHXO6ixZQcmMA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D63C48BF8; Mon, 19 Feb 2024 21:27:59 +0000 (UTC) From: Yang Xiwen via B4 Relay Date: Tue, 20 Feb 2024 05:27:58 +0800 Subject: [PATCH RFC v3 1/5] dt-bindings: phy: hisi-inno-usb2: convert to YAML Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240220-inno-phy-v3-1-893cdf8633b4@outlook.com> References: <20240220-inno-phy-v3-0-893cdf8633b4@outlook.com> In-Reply-To: <20240220-inno-phy-v3-0-893cdf8633b4@outlook.com> To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jiancheng Xue , Shawn Guo , Philipp Zabel Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , David Yang , Yang Xiwen X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1708378078; l=5498; i=forbidden405@outlook.com; s=20230724; h=from:subject:message-id; bh=U6z/RQ0uF+ViR2t96pmwIWGjVhr4jNGIoMn6+B3Bm2E=; b=E5hi8gD7t05khy6nno5iubPtNEc5E3qKveeyoqOyV7D+B/Bnny83UrvRJVgHrakxYcTMKO4j2 TAIcn+qUQNRBiledFodaXR778qj8Zk5EJf3bKAYV+NlgJvttEPEvwxS X-Developer-Key: i=forbidden405@outlook.com; a=ed25519; pk=qOD5jhp891/Xzc+H/PZ8LWVSWE3O/XCQnAg+5vdU2IU= X-Endpoint-Received: by B4 Relay for forbidden405@outlook.com/20230724 with auth_id=67 X-Original-From: Yang Xiwen Reply-To: From: Yang Xiwen Add missing compatible "hisilicon,hi3798mv100-usb2-phy" to compatible list due to prior driver change. Also rename to hisilicon,inno-usb2-phy.yaml and add this name to compatible lists. Fixes: 3940ffc65492 ("phy: hisilicon: Add inno-usb2-phy driver for Hi3798MV= 100") Signed-off-by: Yang Xiwen --- .../bindings/phy/hisilicon,inno-usb2-phy.yaml | 95 ++++++++++++++++++= ++++ .../devicetree/bindings/phy/phy-hisi-inno-usb2.txt | 71 ---------------- 2 files changed, 95 insertions(+), 71 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.= yaml b/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml new file mode 100644 index 000000000000..1b57e0396209 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml @@ -0,0 +1,95 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/hisilicon,inno-usb2-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HiSilicon HiSTB SoCs INNO USB2 PHY device + +maintainers: + - Yang Xiwen + +properties: + compatible: + items: + - enum: + - hisilicon,hi3798cv200-usb2-phy + - hisilicon,hi3798mv100-usb2-phy + - const: hisilicon,inno-usb2-phy + + reg: + maxItems: 1 + description: Should be the address space for PHY configuration registe= r in + peripheral controller, e.g. PERI_USB0 for USB 2.0 PHY01 on Hi3798CV2= 00 SoC, + or direct MMIO address space. + + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + + clocks: + maxItems: 1 + description: reference clock + + resets: + maxItems: 1 + +patternProperties: + 'phy@[0-9a-f]+': + type: object + additionalProperties: false + description: individual ports provided by INNO PHY + + properties: + reg: + maxItems: 1 + descrption: should be the port index (if under a perictrl node) + or port address space + + '#phy-cells': + const: 0 + + resets: + maxItems: 1 + + required: + - reg + - '#phy-cells' + - resets + +required: + - compatible + - clocks + - reg + - '#address-cells' + - '#size-cells' + - resets + +additionalProperties: false + +examples: + - | + #include + + usb2-phy@120 { + compatible =3D "hisilicon,hi3798cv200-usb2-phy", "hisilicon,inno-u= sb2-phy"; + reg =3D <0x120 0x4>; + clocks =3D <&crg HISTB_USB2_PHY1_REF_CLK>; + resets =3D <&crg 0xbc 4>; + #address-cells =3D <1>; + #size-cells =3D <0>; + + phy@0 { + reg =3D <0>; + #phy-cells =3D <0>; + resets =3D <&crg 0xbc 8>; + }; + + phy@1 { + reg =3D <1>; + #phy-cells =3D <0>; + resets =3D <&crg 0xbc 9>; + }; + }; diff --git a/Documentation/devicetree/bindings/phy/phy-hisi-inno-usb2.txt b= /Documentation/devicetree/bindings/phy/phy-hisi-inno-usb2.txt deleted file mode 100644 index 104953e849e7..000000000000 --- a/Documentation/devicetree/bindings/phy/phy-hisi-inno-usb2.txt +++ /dev/null @@ -1,71 +0,0 @@ -Device tree bindings for HiSilicon INNO USB2 PHY - -Required properties: -- compatible: Should be one of the following strings: - "hisilicon,inno-usb2-phy", - "hisilicon,hi3798cv200-usb2-phy". -- reg: Should be the address space for PHY configuration register in perip= heral - controller, e.g. PERI_USB0 for USB 2.0 PHY01 on Hi3798CV200 SoC. -- clocks: The phandle and clock specifier pair for INNO USB2 PHY device - reference clock. -- resets: The phandle and reset specifier pair for INNO USB2 PHY device re= set - signal. -- #address-cells: Must be 1. -- #size-cells: Must be 0. - -The INNO USB2 PHY device should be a child node of peripheral controller t= hat -contains the PHY configuration register, and each device supports up to 2 = PHY -ports which are represented as child nodes of INNO USB2 PHY device. - -Required properties for PHY port node: -- reg: The PHY port instance number. -- #phy-cells: Defined by generic PHY bindings. Must be 0. -- resets: The phandle and reset specifier pair for PHY port reset signal. - -Refer to phy/phy-bindings.txt for the generic PHY binding properties - -Example: - -perictrl: peripheral-controller@8a20000 { - compatible =3D "hisilicon,hi3798cv200-perictrl", "simple-mfd"; - reg =3D <0x8a20000 0x1000>; - #address-cells =3D <1>; - #size-cells =3D <1>; - ranges =3D <0x0 0x8a20000 0x1000>; - - usb2_phy1: usb2-phy@120 { - compatible =3D "hisilicon,hi3798cv200-usb2-phy"; - reg =3D <0x120 0x4>; - clocks =3D <&crg HISTB_USB2_PHY1_REF_CLK>; - resets =3D <&crg 0xbc 4>; - #address-cells =3D <1>; - #size-cells =3D <0>; - - usb2_phy1_port0: phy@0 { - reg =3D <0>; - #phy-cells =3D <0>; - resets =3D <&crg 0xbc 8>; - }; - - usb2_phy1_port1: phy@1 { - reg =3D <1>; - #phy-cells =3D <0>; - resets =3D <&crg 0xbc 9>; - }; - }; - - usb2_phy2: usb2-phy@124 { - compatible =3D "hisilicon,hi3798cv200-usb2-phy"; - reg =3D <0x124 0x4>; - clocks =3D <&crg HISTB_USB2_PHY2_REF_CLK>; - resets =3D <&crg 0xbc 6>; - #address-cells =3D <1>; - #size-cells =3D <0>; - - usb2_phy2_port0: phy@0 { - reg =3D <0>; - #phy-cells =3D <0>; - resets =3D <&crg 0xbc 10>; - }; - }; -}; --=20 2.43.0 From nobody Sun Feb 8 12:15:01 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABA4F53E1B; Mon, 19 Feb 2024 21:27:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708378079; cv=none; b=qos12fHgmgMGgi/RMH8iscIf/SWZthKd8mbMmTKqhuAnk3QQCcpDNGV5QGWxq0hgvljneoWfWC/i2IdsJXoWU6nftOP2bJmwgadyxM1ndFiu4wLpy6ski+dkZH0HnnJ/KcSorRaVvEOfpY4nunnAmAB0iyZraJWjNPmRg5siaZk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708378079; c=relaxed/simple; bh=QALXNb0onLycYsgMBD77sidxYNcSFWXNGDA/ZI2hTFs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iHTl290DGb+Oq1cUmg9eyvyG+G3vaf0kk2PTv+oSIp252rTrqLYYpxJioMdpqB6HV+jt6sojuz2N9/X2vKSCD0srlB4ZsyXb92BI8Ts107wINRYlfKT3Z7/8MqTC+81ZrvJ54i6UVgdnZoXk2oOVGKvzg8PA357l3I4lojN53Rg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WY+2cyF8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WY+2cyF8" Received: by smtp.kernel.org (Postfix) with ESMTPS id 49721C43394; Mon, 19 Feb 2024 21:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708378079; bh=QALXNb0onLycYsgMBD77sidxYNcSFWXNGDA/ZI2hTFs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=WY+2cyF8KbO2esqkK//upSklFy9fdKQNieae1c1W9+bw4JoGjAS1Xg2K4nBdNCzkz Obnv5wb0aayVQmSqJmSB2atMUJPeojRc34aMUResDLnoQztvs0YgqdPfg3acqz5YRH FbbBxzdBmL9KA7wTzIoZOslS67VSwuIsvNJQEIQqpFp+anBkNDAVDbgawEALIbAKpQ 54qGzvgo7mDwJ2WNOxHSwFdQnPiKCYLQaXiVbC4zbQDKUd1JElBKhxNnOs1quZiT07 ss03Z2oEsFVkeNHAqcAaO9pU/pssbGv+omExgR+7IVq97B/fZzPjWlwRf2Mb8DcW5E stRXe4YextrJA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28650C54787; Mon, 19 Feb 2024 21:27:59 +0000 (UTC) From: Yang Xiwen via B4 Relay Date: Tue, 20 Feb 2024 05:27:59 +0800 Subject: [PATCH RFC v3 2/5] arm64: dts: hi3798cv200: add hisilicon,inno-usb2-phy to compatible list Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240220-inno-phy-v3-2-893cdf8633b4@outlook.com> References: <20240220-inno-phy-v3-0-893cdf8633b4@outlook.com> In-Reply-To: <20240220-inno-phy-v3-0-893cdf8633b4@outlook.com> To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jiancheng Xue , Shawn Guo , Philipp Zabel Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , David Yang , Yang Xiwen X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1708378078; l=1213; i=forbidden405@outlook.com; s=20230724; h=from:subject:message-id; bh=9vJGt8Ea6nDd4110Luo3uNaofm3Nie+YLh4/3aqzgKY=; b=G6dwipOzO7tIAyQn4WvhzD9c9rqV9ps0/6dGeA76lSMJBMrT0dJH/JkirMdy8SIQDVSc+ggtB y70Sgiw1jlyAAwqIqcwJKTAco24oWGn7DDyAwaasUOTGA/spqPteT2+ X-Developer-Key: i=forbidden405@outlook.com; a=ed25519; pk=qOD5jhp891/Xzc+H/PZ8LWVSWE3O/XCQnAg+5vdU2IU= X-Endpoint-Received: by B4 Relay for forbidden405@outlook.com/20230724 with auth_id=67 X-Original-From: Yang Xiwen Reply-To: From: Yang Xiwen This is required due to recent binding changes. Signed-off-by: Yang Xiwen --- arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi b/arch/arm64/bo= ot/dts/hisilicon/hi3798cv200.dtsi index ed1b5a7a6067..268d57eabce7 100644 --- a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi @@ -114,7 +114,8 @@ perictrl: peripheral-controller@8a20000 { ranges =3D <0x0 0x8a20000 0x1000>; =20 usb2_phy1: usb2_phy@120 { - compatible =3D "hisilicon,hi3798cv200-usb2-phy"; + compatible =3D "hisilicon,hi3798cv200-usb2-phy", + "hisilicon,inno-usb2-phy"; reg =3D <0x120 0x4>; clocks =3D <&crg HISTB_USB2_PHY1_REF_CLK>; resets =3D <&crg 0xbc 4>; @@ -135,7 +136,8 @@ usb2_phy1_port1: phy@1 { }; =20 usb2_phy2: usb2_phy@124 { - compatible =3D "hisilicon,hi3798cv200-usb2-phy"; + compatible =3D "hisilicon,hi3798cv200-usb2-phy", + "hisilicon,inno-usb2-phy"; reg =3D <0x124 0x4>; clocks =3D <&crg HISTB_USB2_PHY2_REF_CLK>; resets =3D <&crg 0xbc 6>; --=20 2.43.0 From nobody Sun Feb 8 12:15:01 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB9E85025C; Mon, 19 Feb 2024 21:27:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708378079; cv=none; b=hX22QpZFU8siKAt94sCvv0P+1TXCThkTTZ2BpnOBQqH7U14x6Dqs7ys6I0lar0UZUTwhNFijBSQUETH1D5HrrLvdZnwJgfc4MMwSebGPQ30U4v5gPDmivJL17Hwqp6YWXCV4WcSbFaC1PNx2rsKn1Hto6bbg7K3WWq1C8492EGA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708378079; c=relaxed/simple; bh=esSfqR/EN2uGgQJhZInB3gQ5IgggyIpQkCwvAPI4KIE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OnW/p7JuEVI3mR15eT728RqoiR95af8/oOD/mVcqQFIWs2nPYaokRSQw+jLfIhUCYC5cse+8T9FB+usHqnAdCInPdaYx2rKyhP68D6QoiWOoO+bAQKJQfrjO0jRVVj1tPqYdgbL7+iuuDXa6khJ0NiyediDRyIwgfLij2+1z228= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YbPciEzK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YbPciEzK" Received: by smtp.kernel.org (Postfix) with ESMTPS id 58CAFC433A6; Mon, 19 Feb 2024 21:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708378079; bh=esSfqR/EN2uGgQJhZInB3gQ5IgggyIpQkCwvAPI4KIE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=YbPciEzKQMYE7noRsTetjNj3S9+k7Ik1GeacWOOuS+ThMtoaO1ZkflWACao+7rYih gCHfwLLmHNN/b/6Ycu7whZhRHunuj5/m+hk0VxA6ClSAsqb9hwclvPSlBly+QPqG38 72KrvgDKyBiBzzbiUSeeaErXXsllCTohfyAq4+oW+JbAw+LmZlVvDe4aHvyVZn/QV4 sVsocx6VN0a+cYLAA4RfUOm6eu6f1QhMUSrTVRjLZDnTnn95k2+89H9npeFfBydnzY xmqvx0EC4HkrIEiFdQOpBe39nsrMEI/tbY97N4j0XKAhqMlxOfOwIDtxhxNFsscDyv 87YumtHsIvzxQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3594DC5478A; Mon, 19 Feb 2024 21:27:59 +0000 (UTC) From: Yang Xiwen via B4 Relay Date: Tue, 20 Feb 2024 05:28:00 +0800 Subject: [PATCH RFC v3 3/5] phy: hisilicon: hisi-inno-phy: enable clocks for every ports Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240220-inno-phy-v3-3-893cdf8633b4@outlook.com> References: <20240220-inno-phy-v3-0-893cdf8633b4@outlook.com> In-Reply-To: <20240220-inno-phy-v3-0-893cdf8633b4@outlook.com> To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jiancheng Xue , Shawn Guo , Philipp Zabel Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , David Yang , Yang Xiwen X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1708378078; l=971; i=forbidden405@outlook.com; s=20230724; h=from:subject:message-id; bh=jGUbESXsyAvU27nkXjLoTOKtwqcjOT068eM8RNJCWfs=; b=zs3Pye2H9yxnBHI/KFOaUXuqr2aivy0VIlFkP7na/Xbw3rIoaMubBcpeDNsVhE3207LPYz72J c2VRW0Hg+5MCQr8XwdaAjcx1MiDv9f2A/+Fv+yagKFNF/ujcU467b1S X-Developer-Key: i=forbidden405@outlook.com; a=ed25519; pk=qOD5jhp891/Xzc+H/PZ8LWVSWE3O/XCQnAg+5vdU2IU= X-Endpoint-Received: by B4 Relay for forbidden405@outlook.com/20230724 with auth_id=67 X-Original-From: Yang Xiwen Reply-To: From: Yang Xiwen This is needed for port1 to work. Fixes: ba8b0ee81fbb ("phy: add inno-usb2-phy driver for hi3798cv200 SoC") Signed-off-by: Yang Xiwen --- drivers/phy/hisilicon/phy-hisi-inno-usb2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/phy/hisilicon/phy-hisi-inno-usb2.c b/drivers/phy/hisil= icon/phy-hisi-inno-usb2.c index c138cd4807d6..b7e740eb4752 100644 --- a/drivers/phy/hisilicon/phy-hisi-inno-usb2.c +++ b/drivers/phy/hisilicon/phy-hisi-inno-usb2.c @@ -86,8 +86,10 @@ static void hisi_inno_phy_write_reg(struct hisi_inno_phy= _priv *priv, =20 static void hisi_inno_phy_setup(struct hisi_inno_phy_priv *priv) { + int i; /* The phy clk is controlled by the port0 register 0x06. */ - hisi_inno_phy_write_reg(priv, 0, 0x06, PHY_CLK_ENABLE); + for (i =3D 0; i < INNO_PHY_PORT_NUM; i++) + hisi_inno_phy_write_reg(priv, i, 0x06, PHY_CLK_ENABLE); msleep(PHY_CLK_STABLE_TIME); } =20 --=20 2.43.0 From nobody Sun Feb 8 12:15:01 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFC6F53E22; Mon, 19 Feb 2024 21:27:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708378079; cv=none; b=mbY4zbFnZ5CajkiUZ9/SB6aqT9a5YEpw4B1PYpBSt7umP+QdaW0toCZ5ImEpFZWzwPsrNpcrOKSFBdud+tbxfP0jpmfgyhGS0Eenxu8msnB5rGrEZ5l5DwlW1llyfb+y1tCp8wotGvEM8xO9sK05JnAealHYTKUsbYYT2WnKk2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708378079; c=relaxed/simple; bh=fSZGw8CHrtheqHYmGL9yCRQ6avDh/svcGOMbahUkH18=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CZwsOHGk3a0jCpzYu6QoOgHmZlNnaoXPaTcuYspdEEd/AUhlqHR2luoTqci8/JV9SCeGN3qxgnXT1XBnZGg8a8dozsN0lYwrv2j0seAyFDeC+QTv7yFts7i6s0Uv+y17pdPno1K8IbN5q4FqHTvO1HohrBGBeIrenVaralEoLeQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kkotpivV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kkotpivV" Received: by smtp.kernel.org (Postfix) with ESMTPS id 5D79FC4166A; Mon, 19 Feb 2024 21:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708378079; bh=fSZGw8CHrtheqHYmGL9yCRQ6avDh/svcGOMbahUkH18=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=kkotpivV3qBGtd35q7KqBauD+c7x3sscudQ5oB9JtiEVemDmyNadxo0oNnUh1npEc E9HJqgEkQOlchjjTWp+OW4+A6deuOFnu+tETp3SsOqDQYJ8knnsDtOpNvTkVkclr6f KpcwQT/4pYX4SLn3Hp+RdHwne+XU2PqTfwf2sAIAmkGeuQXpb1f1MMhdc5zgDVxo65 gO4qvVa2RyRi8lVhwCVbDdVwsw8Tb9KKZEE4hIvz0In3aqv7SL7E2s6/CldF1xvBOd jUmEGMoZ+HCJNdfk1u8tQ1HaBxiq1IJfRqrs3BGiSqPKQwhEmVRMivMdd4Ge+UAgFH DLuToMwXIjYFA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47607C54788; Mon, 19 Feb 2024 21:27:59 +0000 (UTC) From: Yang Xiwen via B4 Relay Date: Tue, 20 Feb 2024 05:28:01 +0800 Subject: [PATCH RFC v3 4/5] phy: hisilicon: hisi-inno-phy: add support for Hi3798MV200 INNO PHY Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240220-inno-phy-v3-4-893cdf8633b4@outlook.com> References: <20240220-inno-phy-v3-0-893cdf8633b4@outlook.com> In-Reply-To: <20240220-inno-phy-v3-0-893cdf8633b4@outlook.com> To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jiancheng Xue , Shawn Guo , Philipp Zabel Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , David Yang , Yang Xiwen X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1708378078; l=4896; i=forbidden405@outlook.com; s=20230724; h=from:subject:message-id; bh=GrCYJatgoRWu7Bx47GQoBXbcdNOq+uSu0U+veti+reE=; b=ou3NyvShEGVdWHjXOWZHUrDCDkQq0AwopgQeh6RbfmD6RJSnEFQ8RhcVdlRIzycIJ7DskzFF8 PmGGLHUwY9oBtCsuDnvrcIQBJRY2W7HhlRxK7ag6YVYY/WSRcVROpGM X-Developer-Key: i=forbidden405@outlook.com; a=ed25519; pk=qOD5jhp891/Xzc+H/PZ8LWVSWE3O/XCQnAg+5vdU2IU= X-Endpoint-Received: by B4 Relay for forbidden405@outlook.com/20230724 with auth_id=67 X-Original-From: Yang Xiwen Reply-To: From: Yang Xiwen Direct MMIO resgiter access is used by Hi3798MV200. For other models, of_iomap() returns 0 due to insufficient length. So they are unaffected. Also Hi3798MV200 INNO PHY has an extra reset required to be deasserted, switch to reset_control_bulk_() APIs to resolve this. Signed-off-by: Yang Xiwen --- drivers/phy/hisilicon/phy-hisi-inno-usb2.c | 65 ++++++++++++++++++--------= ---- 1 file changed, 39 insertions(+), 26 deletions(-) diff --git a/drivers/phy/hisilicon/phy-hisi-inno-usb2.c b/drivers/phy/hisil= icon/phy-hisi-inno-usb2.c index b7e740eb4752..5175e5a351ac 100644 --- a/drivers/phy/hisilicon/phy-hisi-inno-usb2.c +++ b/drivers/phy/hisilicon/phy-hisi-inno-usb2.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -43,6 +44,7 @@ #define PHY_CLK_ENABLE BIT(2) =20 struct hisi_inno_phy_port { + void __iomem *base; struct reset_control *utmi_rst; struct hisi_inno_phy_priv *priv; }; @@ -50,7 +52,7 @@ struct hisi_inno_phy_port { struct hisi_inno_phy_priv { void __iomem *mmio; struct clk *ref_clk; - struct reset_control *por_rst; + struct reset_control *rsts; unsigned int type; struct hisi_inno_phy_port ports[INNO_PHY_PORT_NUM]; }; @@ -62,26 +64,31 @@ static void hisi_inno_phy_write_reg(struct hisi_inno_ph= y_priv *priv, u32 val; u32 value; =20 - if (priv->type =3D=3D PHY_TYPE_0) - val =3D (data & PHY_TEST_DATA) | - ((addr << PHY_TEST_ADDR_OFFSET) & PHY0_TEST_ADDR) | - ((port << PHY0_TEST_PORT_OFFSET) & PHY0_TEST_PORT) | - PHY0_TEST_WREN | PHY0_TEST_RST; - else - val =3D (data & PHY_TEST_DATA) | - ((addr << PHY_TEST_ADDR_OFFSET) & PHY1_TEST_ADDR) | - ((port << PHY1_TEST_PORT_OFFSET) & PHY1_TEST_PORT) | - PHY1_TEST_WREN | PHY1_TEST_RST; - writel(val, reg); - - value =3D val; - if (priv->type =3D=3D PHY_TYPE_0) - value |=3D PHY0_TEST_CLK; - else - value |=3D PHY1_TEST_CLK; - writel(value, reg); - - writel(val, reg); + if (priv->ports[port].base) + // stride is 4 + writel(data, (u32 *)priv->ports[port].base + addr); + else { + if (priv->type =3D=3D PHY_TYPE_0) + val =3D (data & PHY_TEST_DATA) | + ((addr << PHY_TEST_ADDR_OFFSET) & PHY0_TEST_ADDR) | + ((port << PHY0_TEST_PORT_OFFSET) & PHY0_TEST_PORT) | + PHY0_TEST_WREN | PHY0_TEST_RST; + else + val =3D (data & PHY_TEST_DATA) | + ((addr << PHY_TEST_ADDR_OFFSET) & PHY1_TEST_ADDR) | + ((port << PHY1_TEST_PORT_OFFSET) & PHY1_TEST_PORT) | + PHY1_TEST_WREN | PHY1_TEST_RST; + writel(val, reg); + + value =3D val; + if (priv->type =3D=3D PHY_TYPE_0) + value |=3D PHY0_TEST_CLK; + else + value |=3D PHY1_TEST_CLK; + writel(value, reg); + + writel(val, reg); + } } =20 static void hisi_inno_phy_setup(struct hisi_inno_phy_priv *priv) @@ -104,7 +111,7 @@ static int hisi_inno_phy_init(struct phy *phy) return ret; udelay(REF_CLK_STABLE_TIME); =20 - reset_control_deassert(priv->por_rst); + reset_control_deassert(priv->rsts); udelay(POR_RST_COMPLETE_TIME); =20 /* Set up phy registers */ @@ -122,7 +129,7 @@ static int hisi_inno_phy_exit(struct phy *phy) struct hisi_inno_phy_priv *priv =3D port->priv; =20 reset_control_assert(port->utmi_rst); - reset_control_assert(priv->por_rst); + reset_control_assert(priv->rsts); clk_disable_unprepare(priv->ref_clk); =20 return 0; @@ -158,15 +165,16 @@ static int hisi_inno_phy_probe(struct platform_device= *pdev) if (IS_ERR(priv->ref_clk)) return PTR_ERR(priv->ref_clk); =20 - priv->por_rst =3D devm_reset_control_get_exclusive(dev, NULL); - if (IS_ERR(priv->por_rst)) - return PTR_ERR(priv->por_rst); + priv->rsts =3D devm_reset_control_array_get(dev, false, false); + if (IS_ERR(priv->rsts)) + return PTR_ERR(priv->rsts); =20 priv->type =3D (uintptr_t) of_device_get_match_data(dev); =20 for_each_child_of_node(np, child) { struct reset_control *rst; struct phy *phy; + void __iomem *base; =20 rst =3D of_reset_control_get_exclusive(child, NULL); if (IS_ERR(rst)) { @@ -174,7 +182,10 @@ static int hisi_inno_phy_probe(struct platform_device = *pdev) return PTR_ERR(rst); } =20 + base =3D of_iomap(child, 0); + priv->ports[i].utmi_rst =3D rst; + priv->ports[i].base =3D base; priv->ports[i].priv =3D priv; =20 phy =3D devm_phy_create(dev, child, &hisi_inno_phy_ops); @@ -205,6 +216,8 @@ static const struct of_device_id hisi_inno_phy_of_match= [] =3D { .data =3D (void *) PHY_TYPE_0 }, { .compatible =3D "hisilicon,hi3798mv100-usb2-phy", .data =3D (void *) PHY_TYPE_1 }, + { .compatible =3D "hisilicon,hi3798mv200-usb2-phy", + .data =3D (void *) PHY_TYPE_0 }, { }, }; MODULE_DEVICE_TABLE(of, hisi_inno_phy_of_match); --=20 2.43.0 From nobody Sun Feb 8 12:15:01 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D65554770; Mon, 19 Feb 2024 21:27:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708378080; cv=none; b=qLTfAhwHyKoJCTk+e/akv99TqpZANmXSVLZW+Wg0+FuwarlUGZYn1NjqAWdBFgwWtLUHqlZi7YuSZ1eczngjFtW2TFWLGjDSv9jeiOvLW10kRd77l2TTNVclAu0mVZLFGQghfjog/UcJGqliBsFk968FEJvmYZ0nKOvpcbkKuIU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708378080; c=relaxed/simple; bh=bubzY9/Q81Ml7PldAcrUeOkRxvvoWWMJMf+jhZFDA1s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VRMaJ3HIHCkX3nSxyxrUQvClYeZqikuERYc/lCyTZKiV2ifZtHRxKoEfOHgbmu1fhrenErz6HjnM6Az6LQAxdLW2ToGDsQAZGlAsgZPjDHSCdectuwL3O6kfRNFkZaVOYJ+CTlL6i5wzrkKLKPfwX31fWMgYIF/Q4zhuKDznVMM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OcvjZdSX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OcvjZdSX" Received: by smtp.kernel.org (Postfix) with ESMTPS id 6C9C6C4166B; Mon, 19 Feb 2024 21:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708378079; bh=bubzY9/Q81Ml7PldAcrUeOkRxvvoWWMJMf+jhZFDA1s=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=OcvjZdSXTUQpicinGKWLlKRUdttBhzQoryWSwgH+x/FBTFVIak/f/s8jJacvGs93z 8l+KQT0s9XmzcR7bNeGOci0jOcUP2Yn+qCFoVx77mWH320r23D3cliX+M07XeOFcA6 zqorjNs5D/sivfkdUTb1FCL8Qs1U/7fDPrJEuoFnNgtmXg5099Q1f28We6QtepsLcX YQDUvuW/ql4+akdghsOBhG6dKK/9gpH5/w7MDb5PyIpJTgr8M/slfG/Z+PwGYGFjfw zEiaJ1X6N4rnOhOocp9VgrZ2qyPQ4R81l9NHbDsDQCkKphdg2s4iMgq1KAvW8K0V0f hrPjO8fcOJ3EA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 565A5C48BC3; Mon, 19 Feb 2024 21:27:59 +0000 (UTC) From: Yang Xiwen via B4 Relay Date: Tue, 20 Feb 2024 05:28:02 +0800 Subject: [PATCH RFC v3 5/5] dt-bindings: phy: hisi-inno-usb2: add compatible of hisilicon,hi3798mv200-usb2-phy Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240220-inno-phy-v3-5-893cdf8633b4@outlook.com> References: <20240220-inno-phy-v3-0-893cdf8633b4@outlook.com> In-Reply-To: <20240220-inno-phy-v3-0-893cdf8633b4@outlook.com> To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jiancheng Xue , Shawn Guo , Philipp Zabel Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , David Yang , Yang Xiwen X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1708378078; l=2027; i=forbidden405@outlook.com; s=20230724; h=from:subject:message-id; bh=avj4AQctpHODHrI4Gj2Nnv22VVypJnyWPLnjEGJEEdE=; b=xZ9uDnvgbLGc44UOmznpNLi5rmjnlS/9CKX9jmNtOvRqOBPi6PeuTIZpq5jyKB4Ty1XXjQjBh x660NzaUFhPD8H222qtB1e2SROUGiE+AjJFtRO97Ci2oNfsllIBvmhi X-Developer-Key: i=forbidden405@outlook.com; a=ed25519; pk=qOD5jhp891/Xzc+H/PZ8LWVSWE3O/XCQnAg+5vdU2IU= X-Endpoint-Received: by B4 Relay for forbidden405@outlook.com/20230724 with auth_id=67 X-Original-From: Yang Xiwen Reply-To: From: Yang Xiwen It is accessed by direct MMIO, making "ranges" property mandatory for it. Also there is an extra clock for the phy. Signed-off-by: Yang Xiwen --- .../bindings/phy/hisilicon,inno-usb2-phy.yaml | 32 ++++++++++++++++++= ++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.= yaml b/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml index 1b57e0396209..969fd3fb7537 100644 --- a/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml +++ b/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml @@ -15,6 +15,7 @@ properties: - enum: - hisilicon,hi3798cv200-usb2-phy - hisilicon,hi3798mv100-usb2-phy + - hisilicon,hi3798mv200-usb2-phy - const: hisilicon,inno-usb2-phy =20 reg: @@ -23,18 +24,27 @@ properties: peripheral controller, e.g. PERI_USB0 for USB 2.0 PHY01 on Hi3798CV2= 00 SoC, or direct MMIO address space. =20 + ranges: + maxItems: 1 + '#address-cells': const: 1 =20 '#size-cells': - const: 0 + enum: [0, 1] =20 clocks: maxItems: 1 description: reference clock =20 resets: - maxItems: 1 + minItems: 1 + maxItems: 2 + + reset-names: + items: + - const: port + - const: test =20 patternProperties: 'phy@[0-9a-f]+': @@ -54,6 +64,9 @@ patternProperties: resets: maxItems: 1 =20 + phy_type: + const: utmi + required: - reg - '#phy-cells' @@ -67,6 +80,21 @@ required: - '#size-cells' - resets =20 +allOf: + - if: + properties: + compatible: + contains: + const: hisilicon,hi3798mv200-usb2-phy + then: + required: + - ranges + - reset-names + else: + properties: + ranges: false + reset-names: false + additionalProperties: false =20 examples: --=20 2.43.0