From nobody Sun Feb 8 14:12:06 2026 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E2FB67A17 for ; Tue, 20 Feb 2024 11:44:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708429486; cv=none; b=VurmfXDYNqtW2V41oi9gokSJPKzf8Vj/wuXjKW0aaep3ucnCK6vBaoYzMtvzWxMRIamDyr0dr4HVeI5SQ/W/eE8nQ9bNpH6uR1zed4YYWvYVEmTw6QQupQ0pzz80oaP5up5yPNxHwQac1ebDqdWpQO8baE7hgi1ORj+/2TC5Eyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708429486; c=relaxed/simple; bh=BFuh+CfNDOzD1S00lsGqAqSSiu2o1MPg0aixlXGfmos=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=V8nLM7uMa30viyjX1cqaCIWpunU2mX+KDLcm05XJAZ5FuAnhQtGkvX/mocAaSp0uqSq5/SemC+t4TBfwnc2eyN6PUOfHHnLfr4C259BaCgJDO1ktBfu6S+/GEUPzR9G1zooI1tgAkb+lkz3oVeCIig2QDl8vxjpFl10VZ6a0C2E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=g0nQyEhc; arc=none smtp.client-ip=95.215.58.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="g0nQyEhc" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708429482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=frGjyVgHupGD7XyoLjuBNXl6egeagHTj4tQawTxfLDk=; b=g0nQyEhc0uv+uyH42ziPQ1j9bhr8hQRZCCD1pT3uRaE0h01LgIKi7xFEjBfKNbh47w5tba emvlznq1s+LOnT3Lw9TXWIogMbzkBgFeeOLy8fgJ2ioyd72Q8p+oL3w56Dqvf7WbgzC07F xS30vIqd5dGOK4fSMvu6DsMCjzJH//c= From: Chengming Zhou Date: Tue, 20 Feb 2024 11:44:30 +0000 Subject: [PATCH RESEND 2/3] mm/zsmalloc: remove_zspage() don't need fullness parameter Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240220-b4-zsmalloc-cleanup-v1-2-b7e9cbab9541@linux.dev> References: <20240220-b4-zsmalloc-cleanup-v1-0-b7e9cbab9541@linux.dev> In-Reply-To: <20240220-b4-zsmalloc-cleanup-v1-0-b7e9cbab9541@linux.dev> To: hannes@cmpxchg.org, Andrew Morton , Sergey Senozhatsky , nphamcs@gmail.com, yosryahmed@google.com, Minchan Kim Cc: linux-mm@kvack.org, Chengming Zhou , linux-kernel@vger.kernel.org X-Developer-Signature: v=1; a=ed25519-sha256; t=1708429476; l=2152; i=chengming.zhou@linux.dev; s=20240220; h=from:subject:message-id; bh=GQWspwGCFRIlLWu+jB/4L2Vh7hNigRDA/nhdzUelvTs=; b=HfKohdQBHsp+yH25vS97QDG5EljLYcLDRXNqctQwnwKj01ORLuWu4tU2UdBSKwG84P3sebhh0 +EDf/e7QoXHDzKOZQ3ztPMFYVZxHPOhdOxb/wSKcAv5ObGPWQggBTCa X-Developer-Key: i=chengming.zhou@linux.dev; a=ed25519; pk=5+68Wfci+T30FoQos5RH+hfToF6SlC+S9LMPSPBFWuw= X-Migadu-Flow: FLOW_OUT From: Chengming Zhou We must remove_zspage() from its current fullness list, then use insert_zspage() to update its fullness and insert to new fullness list. Obviously, remove_zspage() doesn't need the fullness parameter. Signed-off-by: Chengming Zhou Reviewed-by: Sergey Senozhatsky --- mm/zsmalloc.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index a6653915bf17..c39fac9361d7 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -687,10 +687,10 @@ static void insert_zspage(struct size_class *class, * This function removes the given zspage from the freelist identified * by . */ -static void remove_zspage(struct size_class *class, - struct zspage *zspage, - int fullness) +static void remove_zspage(struct size_class *class, struct zspage *zspage) { + int fullness =3D zspage->fullness; + VM_BUG_ON(list_empty(&class->fullness_list[fullness])); =20 list_del_init(&zspage->list); @@ -716,7 +716,7 @@ static int fix_fullness_group(struct size_class *class,= struct zspage *zspage) if (newfg =3D=3D currfg) goto out; =20 - remove_zspage(class, zspage, currfg); + remove_zspage(class, zspage); insert_zspage(class, zspage, newfg); out: return newfg; @@ -878,7 +878,7 @@ static void free_zspage(struct zs_pool *pool, struct si= ze_class *class, return; } =20 - remove_zspage(class, zspage, ZS_INUSE_RATIO_0); + remove_zspage(class, zspage); __free_zspage(pool, class, zspage); } =20 @@ -1609,7 +1609,7 @@ static struct zspage *isolate_src_zspage(struct size_= class *class) zspage =3D list_first_entry_or_null(&class->fullness_list[fg], struct zspage, list); if (zspage) { - remove_zspage(class, zspage, fg); + remove_zspage(class, zspage); return zspage; } } @@ -1626,7 +1626,7 @@ static struct zspage *isolate_dst_zspage(struct size_= class *class) zspage =3D list_first_entry_or_null(&class->fullness_list[fg], struct zspage, list); if (zspage) { - remove_zspage(class, zspage, fg); + remove_zspage(class, zspage); return zspage; } } --=20 b4 0.10.1