From nobody Sat Feb 7 15:11:58 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 540AC405D3 for ; Mon, 19 Feb 2024 16:40:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708360810; cv=none; b=cWVJX92PbXMgL38fwBvPovdpqXbvvbqFgTOmOnjCx3bxtIJuPKNB0fpiB4dRvVIO789QSoWtDi9kBq4CbzYv77AN12g1kQOe739HRZw2PyVLISDhMQ9ml8DYrkzw6ENFWLX91vxVl72qg5wNzmTkjgQBD6qLjdRARy4quFEe7vc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708360810; c=relaxed/simple; bh=95GvX6IkRKyNVrApn51thQj4Nye8v5hz784wB2DCO04=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=TRW1IEV0q0JcWNN1TKkgp3V6eaYmfIsKLK/Cf9rZXYj1fVEvqL7Aso2ezTHGmfsEq6RVC0UKJwxfr+VVhlZpzqfcvjSFpMr7LoIyYdCmztl9ZiccLQd5p4wY/yanYfSG/a6l/lpV/OaufxgUw6RtVcYuQxU001Q8zk7utMTJ53E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Birp0xit; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Birp0xit" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708360807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aWnNccAiTUjVXKX2RmHz2334a0dYfqfAPgkPcqZqo7E=; b=Birp0xitCPl4MeEf+wXUlklgjwWgks7hD//N0uGhZVPH+LMxLucBzbm12kd1NRgm+0Q4r5 TUHH4KrxLm3pP4KBRTRAUkrl+lY5LHcvi72IP04R6+BIvSwi6qW13ku/iLCVqF+v34U4pg RQV0uyiPugiSjxz/+SccKq/GzpebOrc= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-301-vNaxvvWQOqem7xRflWcJIQ-1; Mon, 19 Feb 2024 11:40:05 -0500 X-MC-Unique: vNaxvvWQOqem7xRflWcJIQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F0B3C280FEC9; Mon, 19 Feb 2024 16:40:04 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id A15F6492BE3; Mon, 19 Feb 2024 16:40:03 +0000 (UTC) From: Thomas Huth To: linux-m68k@lists.linux-m68k.org, Greg Kroah-Hartman , Greg Ungerer , Jiri Slaby , Geert Uytterhoeven Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: [PATCH] drivers/tty/serial: Remove unused function early_mcf_setup Date: Mon, 19 Feb 2024 17:40:02 +0100 Message-ID: <20240219164002.520342-1-thuth@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 Compiling a kernel for the ColdFire causes a compiler warning: drivers/tty/serial/mcf.c:473:12: warning: no previous prototype for =E2=80=98early_mcf_setup=E2=80=99 [-Wmissing-prototypes] 473 | int __init early_mcf_setup(struct mcf_platform_uart *platp) | ^~~~~~~~~~~~~~~ This function seems to be completely unused, so let's remove it to silence the warning. Signed-off-by: Thomas Huth Acked-by: Greg Ungerer Reviewed-by: Geert Uytterhoeven Reviewed-by: Jiri Slaby --- drivers/tty/serial/mcf.c | 27 --------------------------- 1 file changed, 27 deletions(-) diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c index 8690a45239e09..b0604d6da0257 100644 --- a/drivers/tty/serial/mcf.c +++ b/drivers/tty/serial/mcf.c @@ -470,33 +470,6 @@ static struct mcf_uart mcf_ports[4]; #if defined(CONFIG_SERIAL_MCF_CONSOLE) /*************************************************************************= ***/ =20 -int __init early_mcf_setup(struct mcf_platform_uart *platp) -{ - struct uart_port *port; - int i; - - for (i =3D 0; ((i < MCF_MAXPORTS) && (platp[i].mapbase)); i++) { - port =3D &mcf_ports[i].port; - - port->line =3D i; - port->type =3D PORT_MCF; - port->mapbase =3D platp[i].mapbase; - port->membase =3D (platp[i].membase) ? platp[i].membase : - (unsigned char __iomem *) port->mapbase; - port->iotype =3D SERIAL_IO_MEM; - port->irq =3D platp[i].irq; - port->uartclk =3D MCF_BUSCLK; - port->flags =3D UPF_BOOT_AUTOCONF; - port->rs485_config =3D mcf_config_rs485; - port->rs485_supported =3D mcf_rs485_supported; - port->ops =3D &mcf_uart_ops; - } - - return 0; -} - -/*************************************************************************= ***/ - static void mcf_console_putc(struct console *co, const char c) { struct uart_port *port =3D &(mcf_ports + co->index)->port; --=20 2.43.2