From nobody Sat Feb 7 16:06:14 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C94F38F80; Mon, 19 Feb 2024 15:06:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355198; cv=none; b=J5fzb3ToWcyQCgdhj9Ob24z1hqiuW19eDY7lLbKyAzqcuWTfnzgUsRLIsO4mCNw2F+DwPHAQNUTRDepwh7MifeniYWE73UlaO+zRi85n/LmLPUuPMi3fyUEfM7mVtded2yfP4YW9WqLtd+wI5yeCi5l2dRL6pfkFnf9qJW3iN/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355198; c=relaxed/simple; bh=82ATjiA+fWRlO+HzDk15/yNSFBbE2hQxY9S14sFvXLs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jrb7oexmK5SNPmsxOzPctSyJvUml+OQionLuGNrtrlX9tpStD0WZEFrIRoAOlOirkYWyzURuuZzSONFtrpbS2+bFRpZxqY59JfJBGL8/CTfHgUXEE4Tj6DN3Ir8r0WLjR1tb4O5s/39r6hDwJ2Q4JhFEjOJn34s9dCHzvHhh5RY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XrYqS8b+; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XrYqS8b+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708355197; x=1739891197; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=82ATjiA+fWRlO+HzDk15/yNSFBbE2hQxY9S14sFvXLs=; b=XrYqS8b+fs09PdbIJVRt/UAeBsS+WTU9bcGeI3pO01nLcd5xOAtSM+DO 1lCUOtU5bxDAs94VQcrIAIGsQ+3aiuBJjvGGjxAhNhFY29JH/1z+aJZBB gnsIScVX7oeVVINbQCnUtHkSC74HuhnnuwnjwtEV1CT+Esg8JORkvmrbN fIVDKq1n/izAJZHkdIFY06kJa/S9yDYKYgltdZLMXt89zCWaw2EGMvFvd fMEyMBABCBLehuFD3lFhNbwveq2vAf1IWY2W+z1TY2pbwo/C70fnvPmxI gnWYYBQegS1Ix7SDlyl4STplvJty2LohK7CYzHCEBDnDhPFBLBRsoefEh Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2543777" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="2543777" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:06:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936302991" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="936302991" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2024 07:06:30 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id DA9152BE; Mon, 19 Feb 2024 17:06:28 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby Subject: [PATCH v2 1/7] serial: 8250_exar: Don't remove GPIO device on suspend Date: Mon, 19 Feb 2024 17:04:57 +0200 Message-ID: <20240219150627.2101198-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> References: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It seems a copy&paste mistake that suspend callback removes the GPIO device. There is no counterpart of this action, means once suspended there is no more GPIO device available untile full unbind-bind cycle is performed. Remove suspicious GPIO device removal in suspend. Fixes: d0aeaa83f0b0 ("serial: exar: split out the exar code from 8250_pci") Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/= 8250_exar.c index 1be838122bca..6580265e1763 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -741,6 +741,7 @@ static void exar_pci_remove(struct pci_dev *pcidev) for (i =3D 0; i < priv->nr; i++) serial8250_unregister_port(priv->line[i]); =20 + /* Ensure that every init quirk is properly torn down */ if (priv->board->exit) priv->board->exit(pcidev); } @@ -755,10 +756,6 @@ static int __maybe_unused exar_suspend(struct device *= dev) if (priv->line[i] >=3D 0) serial8250_suspend_port(priv->line[i]); =20 - /* Ensure that every init quirk is properly torn down */ - if (priv->board->exit) - priv->board->exit(pcidev); - return 0; } =20 --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 16:06:14 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00A18383A6; Mon, 19 Feb 2024 15:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355196; cv=none; b=mjQltGgd77T0FIrsWqtrBThDTm3gVNmXvelju2bh5/NrWMwpKsTul5UvbDVNrun0MpoXrQumz5ZNgu+ud1R+h0Sf4UUEEdkHIPQ32bT+r/TusRzZdSudvACQILKeVv8twmcrX2lNHOBIdmQiuDMNuFTZJD0+l8Otj5xuPqS5Pfg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355196; c=relaxed/simple; bh=07e8tH5p33pOlIv3860uVekz8GN+sz+b+6ZdzYF0wWw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FOoJNTHPsGOA8slEidraBtOLMWK6ol/N/E8sFmBE4UCAZDyMsExsQAdr6bEK/e/nK3wBhsI19SxeiNGzzjzpDz8WQ06pAGYHUO1x2rYXPD7o91swZOdfU3dZhaLDdlXF5mc6LcpSSbfH2TesOeJt0Ljx75AKDAaWxlStaUFFUDU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nvytw4WL; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nvytw4WL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708355195; x=1739891195; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=07e8tH5p33pOlIv3860uVekz8GN+sz+b+6ZdzYF0wWw=; b=nvytw4WL8gECXRr8O1YGPJrOu97xNLFHzPW7yxTQW5pObK8lgm1d7BXv /hWgyFmakgvrClNbVVUVrNJzcmDj9B0dXh2spCJIYvtdstgfVi4tGGjtm XXBSl8xzKphgA2er8+ltE8TG1ayopFYk0dLzAGFhS4gfgsKWgkC8Sg0x5 c4kPKWXuCfahNE1gg6BuZlsDhlOAiFc+B+p6WweyamRoHv52RMfq9H6bA QJqy/alrB9p/GFiPGnvwEGYpQOS3HVqtHptRmn9cffpj8PKdUe63/vSii b2RNkk3vVLYrxpqlt451sl7CaG8d8tf/2Ig2TJ0MTDBLeM3fIDb/YRPTI Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2543775" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="2543775" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:06:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936302990" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="936302990" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2024 07:06:30 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id EA87A3E5; Mon, 19 Feb 2024 17:06:28 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby Subject: [PATCH v2 2/7] serial: 8250_exar: Use dev_get_drvdata() directly in PM callbacks Date: Mon, 19 Feb 2024 17:04:58 +0200 Message-ID: <20240219150627.2101198-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> References: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" PM callbacks take struct device pointer as a parameter, use dev_get_drvdata() to retrieve it instead of unneeded double loop of referencing via pci_get_drvdata(to_pci_dev(dev)). Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/= 8250_exar.c index 6580265e1763..28478b9c537b 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -748,8 +748,7 @@ static void exar_pci_remove(struct pci_dev *pcidev) =20 static int __maybe_unused exar_suspend(struct device *dev) { - struct pci_dev *pcidev =3D to_pci_dev(dev); - struct exar8250 *priv =3D pci_get_drvdata(pcidev); + struct exar8250 *priv =3D dev_get_drvdata(dev); unsigned int i; =20 for (i =3D 0; i < priv->nr; i++) --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 16:06:14 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 505FE381C8; Mon, 19 Feb 2024 15:06:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355199; cv=none; b=STGwZXrD//bBtknf+Ltba1WbbxXdffhbhidnm/ASmf/AZhS5OBoOm0Owrl6u3lma52PhU85QHYpG0KRY8AhYp5oCnHbEkJWjo/LzBeGM1lwHMvENsmZ+1UsMW7PiNvz2CCnhf4PVZtS1QRU/MVBID17iJktkpknujeWbq3iusPQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355199; c=relaxed/simple; bh=Oubb+Ppgmcr6fsN+mjfb+NkY8mywNOxbf3wmKOoo4jE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GYq+3YYpMiFJIxXYUx3OvCs9eAEoY6SVHlc3PxnoFo/kLNbF9wGtucLSEE27aA42l9GeoA44+3N6Wjzl7sn3D86AjDn5dzS2+fAbLIbpSMbwUzvhnINh7OqzID3zsE8TatXdrM+KOoSUs00CMmiSuxcAP5oLCBi8uno7rGn9KlM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Jei8VxlL; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Jei8VxlL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708355197; x=1739891197; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Oubb+Ppgmcr6fsN+mjfb+NkY8mywNOxbf3wmKOoo4jE=; b=Jei8VxlLwYtgZ/aITZAG2uRUN4A3WPXlMdgKnSMN6iHAH17CkNuvil04 YiRHib6DtthcXrA8M4zP+a2j74gwZTsgrYZ37r0rshyU3y7L1UhFaIXBk QIBy9MZ20uoovh4CVe97TjU9kJsJjcbLBVpoD5rZAxrUJIhWmrXNxbAoh qUPBdcmojryhu29UzeOz6lVOianqoT7CciL2wfL2aOiaZ53EturQGGMHV 7mjEeC4Pfy3MS/T1xSA8dSMEa941JbFuHQE2N0GeomNVzP4Zw1FfidHvB yVC+4855ui6o/pcQmWtBBogOzOlFtmEy2ob6Zg9FbOqZprFJJ9rfA2+gA Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2543779" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="2543779" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:06:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936302992" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="936302992" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2024 07:06:30 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 00BCA403; Mon, 19 Feb 2024 17:06:28 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby Subject: [PATCH v2 3/7] serial: 8250_exar: Clear interrupts before registering handler Date: Mon, 19 Feb 2024 17:04:59 +0200 Message-ID: <20240219150627.2101198-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> References: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" While now there is no issue if IRQ is fired before we clearing the interrupts as the handler does the same, but strictly speaking it might be problematic if IRQ handler wants to do something more. Move clearing interrupt code to be called before registering the IRQ handler. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/= 8250_exar.c index 28478b9c537b..c7afa06a420e 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -701,14 +701,14 @@ exar_pci_probe(struct pci_dev *pcidev, const struct p= ci_device_id *ent) uart.port.irq =3D pci_irq_vector(pcidev, 0); uart.port.dev =3D &pcidev->dev; =20 + /* Clear interrupts */ + exar_misc_clear(priv); + rc =3D devm_request_irq(&pcidev->dev, uart.port.irq, exar_misc_handler, IRQF_SHARED, "exar_uart", priv); if (rc) return rc; =20 - /* Clear interrupts */ - exar_misc_clear(priv); - for (i =3D 0; i < nr_ports && i < maxnr; i++) { rc =3D board->setup(priv, pcidev, &uart, i); if (rc) { --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 16:06:14 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 541DB3770C; Mon, 19 Feb 2024 15:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355196; cv=none; b=u5BKMC2evDkBaH0AKfCFLPSL3CCVWl5XhZsLqJhiW1nxXdEs7kzGv1PxH9h36cFPYWig3VASPFxgyJw3/zG4oah4OntVkJC+29KJxj9E3fCuldWZawGj4pVQ0FIYHL3mNgVMLhTqqqphnruiJKziAGGyef5xs1B2NN85pln6AVo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355196; c=relaxed/simple; bh=1O2LCsHcutszivKQ7ugn2zdlp1ZqgFp0cxdBQ8mkIts=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sm5rOqyFly8fFFqkMEREVmpgyuDNwPX1QfZgL4jzZ1wbcq5YxtOVrwhqMnFQQDP3SduZe9V2ni3fMtKVsSdAQdFWkan8EXNlnPYoMKbZrmHi9O+om4Azo4FPYEe+DVkkhc4WmaVyw3CRDey2h3vfeladAaNQ1EnbMZ+CErzw/ts= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OckLUJsP; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OckLUJsP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708355194; x=1739891194; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1O2LCsHcutszivKQ7ugn2zdlp1ZqgFp0cxdBQ8mkIts=; b=OckLUJsPov4WkVhIXveZTO9AzLvZ2gX7wYVwI3seJyEvJTcRtTAyHyEA DI0E5UnC4AYMhSximBisuKKf1bTy2UGROhcvf2N/LmFL/TDB3IcwfPn4+ G65pMuHY0dBWg0BICbfluO4Qw20y8mQBv0eKLPidC/zLa4s5E/Weu1gQc AqUxCtV1vlAH/pN5QCoBwGIhy5nA71GK5QEKBRssvseX8RQPVZdXMgwPX P+WCKTmHor++UC6DifXPg9vhWuijvEu8U6k6vTlMUWiK5sSrhHPkYk8mr amaGZu0b+mptl6byAmp1+9wCsRlZk9eroieQeuEpH73Yw0Pho7TO9+QZx w==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2543773" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="2543773" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:06:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936302989" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="936302989" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2024 07:06:30 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 09D433C7; Mon, 19 Feb 2024 17:06:29 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby Subject: [PATCH v2 4/7] serial: 8250_exar: Use generic function to set firmware node Date: Mon, 19 Feb 2024 17:05:00 +0200 Message-ID: <20240219150627.2101198-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> References: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use generic function to set firmware node instead of ACPI specific one. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/= 8250_exar.c index c7afa06a420e..2a0c1f7e87f5 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -6,12 +6,12 @@ * * Copyright (C) 2017 Sudip Mukherjee, All Rights Reserved. */ -#include #include #include #include #include #include +#include #include #include #include @@ -363,7 +363,7 @@ static struct platform_device *__xr17v35x_register_gpio= (struct pci_dev *pcidev, return NULL; =20 pdev->dev.parent =3D &pcidev->dev; - ACPI_COMPANION_SET(&pdev->dev, ACPI_COMPANION(&pcidev->dev)); + device_set_node(&pdev->dev, dev_fwnode(&pcidev->dev)); =20 if (device_add_software_node(&pdev->dev, node) < 0 || platform_device_add(pdev) < 0) { --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 16:06:14 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 675343A8FB; Mon, 19 Feb 2024 15:06:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355200; cv=none; b=MxFdzfZd/7hMYgWWP+YVc2QC7SWZ7NLZRdCy+j2jp0drlgLu5BjAVoJ4cWaX4W2MHZzKiml/zwDncLy3pY7mBf9NwlBjHK/jbSH0cMZWywvRa61B9GP+ffINx5DFYsM9S1DtThhdXtc+X7cJ0EPzdIZhPC0Bb2LB6NGi3poArJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355200; c=relaxed/simple; bh=z+Ws30rfAliHI0b46QssEAM2g90mM8I8G/D4OgscpxM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z8BxXs9qt8O2Z2XJRBoRPkPXT9ogKWLsf0brkXtZiNiWP/2vsQ7+cBe1WUd9Ec012exT4JLS8HQOZg0NlnF0Tx+Ubja6eB2Ov6y7hdCGMKXZod6/qQPTejz9D4K398o6ubplp6V2CLWgum3srgAUzbVOvqwtGHIkDOrWJ88AT9o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WE/GeHz/; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WE/GeHz/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708355198; x=1739891198; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=z+Ws30rfAliHI0b46QssEAM2g90mM8I8G/D4OgscpxM=; b=WE/GeHz/V/u0/+UoSyfjEerK74UNtM5leEoYjsOOCSEQ74eMr68titx+ dTY+h8SAhUzk/h44QlwsFvDWJ8YgTNJXOxe13BQb6zJWf1gclowvtLMC/ FbNB6QQ7fFwedbfRYByriSMj7YY3dahhBRltui4W4kiB2lbhVRZKTz1II XRIobB1OpfCL79aiDWSmANuAMb0xI2TAe66qL8GYG1LC+sHN+XP/d6Fkv uR4TFexIT+Lwl9KsSVP4lshH6063ChkFnAUyeAMg9Di7Z3RPxDsn/6ezc fqtgBPxuC7GX/dpIJ9oMlBh+yJbwXN/y90qaOrq+VjAtToeanjUVcQlL4 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2543809" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="2543809" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:06:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936302995" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="936302995" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2024 07:06:32 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2130445B; Mon, 19 Feb 2024 17:06:29 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby Subject: [PATCH v2 5/7] serial: 8250_exar: switch to DEFINE_SIMPLE_DEV_PM_OPS() Date: Mon, 19 Feb 2024 17:05:01 +0200 Message-ID: <20240219150627.2101198-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> References: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" SIMPLE_DEV_PM_OPS() is deprecated, replace it with DEFINE_SIMPLE_DEV_PM_OPS= () and use pm_sleep_ptr() for setting the driver's PM routines. We can now remove the __maybe_unused qualifier in the suspend and resume functions. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/= 8250_exar.c index 2a0c1f7e87f5..53c5ff49e83c 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -746,7 +747,7 @@ static void exar_pci_remove(struct pci_dev *pcidev) priv->board->exit(pcidev); } =20 -static int __maybe_unused exar_suspend(struct device *dev) +static int exar_suspend(struct device *dev) { struct exar8250 *priv =3D dev_get_drvdata(dev); unsigned int i; @@ -758,7 +759,7 @@ static int __maybe_unused exar_suspend(struct device *d= ev) return 0; } =20 -static int __maybe_unused exar_resume(struct device *dev) +static int exar_resume(struct device *dev) { struct exar8250 *priv =3D dev_get_drvdata(dev); unsigned int i; @@ -772,7 +773,7 @@ static int __maybe_unused exar_resume(struct device *de= v) return 0; } =20 -static SIMPLE_DEV_PM_OPS(exar_pci_pm, exar_suspend, exar_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(exar_pci_pm, exar_suspend, exar_resume); =20 static const struct exar8250_board pbn_fastcom335_2 =3D { .num_ports =3D 2, @@ -922,7 +923,7 @@ static struct pci_driver exar_pci_driver =3D { .probe =3D exar_pci_probe, .remove =3D exar_pci_remove, .driver =3D { - .pm =3D &exar_pci_pm, + .pm =3D pm_sleep_ptr(&exar_pci_pm), }, .id_table =3D exar_pci_tbl, }; --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 16:06:14 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09BE439AEB; Mon, 19 Feb 2024 15:06:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355198; cv=none; b=eGSwEG/9zOigdwygqg2gXv3SQBLHebPTnhpuui33PIW1ZCG1JFPAVGeSMvKydvc7f/SMvh6EIs0jgUAMCoTgjAjlscf5LJFHFYmmAz4vHHoLAMElMj4eGq4d/3ysnVau+Ta+rfKMuhiI1d31PopOh3vzK98gbjew4AUjChOaguU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355198; c=relaxed/simple; bh=XhwsDorFFCDFsHo4F14gBApk9LhtQz1RvNmzKOWEAn8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lBBV+riIx1NOz/4VlvY0lk1aA+upB8KtwEb+s3cUUYnukJeaRrh2PL8cM3880kshlQ9fNfViYKcdchfOI6NLleeh4tO4ixBJ6xjk5mZQllhIx8V3KDr1PTFCvQUNLI4RuBjsT3a9w/W4qfXdQdt1h3dByUNKrV25l2AVKKMp1Z4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VBFgojoN; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VBFgojoN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708355197; x=1739891197; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=XhwsDorFFCDFsHo4F14gBApk9LhtQz1RvNmzKOWEAn8=; b=VBFgojoNeCZtFyl9GsHBi9ZivZcGZbUDzFwwaPHc1S8x+5qHisxxeMLb FV+I94GHi/hQUphR/DvYJY1mwhRClIzvZoay8EfSiBhOZ4iNV7GFW6Rk5 tRgzCBztj2rDDXx6KAqKa+n2isj+JmGJvQVgPJGopeofz67vSKBnD8AWh qS313h+9AzBrQaLwxrsE89h7Lm01zTrPNkl6qW71p8E8wnOMJnLgIEZNZ HYp6D4NgZr8N9p4INkfDe6SLx3T7jJGVhg0qly5xCRHNiIwwip9YbbRMU yXiYTEq09uDZPO9JpobqS4XV64EQg3m/aJGcg3bUGRbwcLgGYR7s1cs5z g==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2543791" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="2543791" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:06:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936302994" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="936302994" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2024 07:06:32 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2A45E456; Mon, 19 Feb 2024 17:06:29 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby Subject: [PATCH v2 6/7] serial: 8250_exar: Use 8250 PCI library to map and assign resources Date: Mon, 19 Feb 2024 17:05:02 +0200 Message-ID: <20240219150627.2101198-7-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> References: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 8250 PCI library provides a common code to map and assign resources. Use it in order to deduplicate existing code and support IO port variants. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 11 ++++++----- drivers/tty/serial/8250/Kconfig | 1 + 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/= 8250_exar.c index 53c5ff49e83c..cf1abe2fc28a 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -24,6 +24,7 @@ #include =20 #include "8250.h" +#include "8250_pcilib.h" =20 #define PCI_DEVICE_ID_ACCESSIO_COM_2S 0x1052 #define PCI_DEVICE_ID_ACCESSIO_COM_4S 0x105d @@ -219,13 +220,12 @@ static int default_setup(struct exar8250 *priv, struc= t pci_dev *pcidev, struct uart_8250_port *port) { const struct exar8250_board *board =3D priv->board; - unsigned int bar =3D 0; unsigned char status; + int err; =20 - port->port.iotype =3D UPIO_MEM; - port->port.mapbase =3D pci_resource_start(pcidev, bar) + offset; - port->port.membase =3D priv->virt + offset; - port->port.regshift =3D board->reg_shift; + err =3D serial8250_pci_setup_port(pcidev, port, 0, offset, board->reg_shi= ft); + if (err) + return err; =20 /* * XR17V35x UARTs have an extra divisor register, DLD that gets enabled @@ -929,6 +929,7 @@ static struct pci_driver exar_pci_driver =3D { }; module_pci_driver(exar_pci_driver); =20 +MODULE_IMPORT_NS(SERIAL_8250_PCI); MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("Exar Serial Driver"); MODULE_AUTHOR("Sudip Mukherjee "); diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kcon= fig index 8b9a2c4902e2..47ff50763c04 100644 --- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig @@ -149,6 +149,7 @@ config SERIAL_8250_PCI config SERIAL_8250_EXAR tristate "8250/16550 Exar/Commtech PCI/PCIe device support" depends on SERIAL_8250 && PCI + select SERIAL_8250_PCILIB default SERIAL_8250 help This builds support for XR17C1xx, XR17V3xx and some Commtech --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 16:06:14 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D77503BB38; Mon, 19 Feb 2024 15:06:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355200; cv=none; b=XJmc/4+EcFeE7SPrc2AoQOVeP2Ft/3OGoqEjo5I8xSk+YR2Mc2qWpZaJ2Whpfu3TkL3GVH89pkIJkxscbRnINS++FPdn5WyqZ4RHVrJIep/TqSyDWd3xOUCq16ifWXZw/zMyyeJfNVFfaGKZuqQfR6fT3J5CQYgjMM1okL7NLik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355200; c=relaxed/simple; bh=DCAxzfXqTax5T11aXU0gJP0t0VjNv7GMA3otlVXbuV0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Er4f8b6cazcqhxqk5l/qQUODQe3M9gkMf60MF1Aa6PKRa/F4gEzAprKOqhThwKobgPDchZlFz6az/WrdxlZEBAJv6gaLF+GlNLzY9PrK2ymkQGajaPAk6XuAKGqj5/zIYaBHrzLKmvtMY9b8wJzGMZwUxtvZGdjy2QU782IuAZs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=NbelpyT0; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NbelpyT0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708355199; x=1739891199; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DCAxzfXqTax5T11aXU0gJP0t0VjNv7GMA3otlVXbuV0=; b=NbelpyT08Fn9zO5T7boXSV3UD+RCUzalRxnq00otNEaIzmBIpoOHi3wR qMBZ4nWjeeA4xJGjHXqTQM6TczDOfU0c1dWJ/zvqYkXt7WxKJZQyLsnPk 7UqJAe336U8yIqASBGaUkc3RBIKMyoLhBStqC7aCNrrI5ih4jk93QD6Cd 0RJXIKe6XwGavlodwip8JEHtJNdXPbbuEbFbogwyyBT0lQJs1h9Wg0ymZ TcXdjqo15xb86cxQUfqHW2oR2KehnLiwDRoQfMhcShK7FgiY1N8Rp4QGF Hclp+LfxulRIyeYYeAO9N/AvAiPOK7o4F6Yno6XiCmwb/W6VV3HGhnx3p A==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2543808" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="2543808" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:06:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936302996" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="936302996" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2024 07:06:32 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3BB8F499; Mon, 19 Feb 2024 17:06:29 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby Subject: [PATCH v2 7/7] serial: 8250_exar: Don't use "proxy" headers Date: Mon, 19 Feb 2024 17:05:03 +0200 Message-ID: <20240219150627.2101198-8-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> References: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Update header inclusions to follow IWYU (Include What You Use) principle. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/= 8250_exar.c index cf1abe2fc28a..2df2c9ea7b34 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -6,20 +6,24 @@ * * Copyright (C) 2017 Sudip Mukherjee, All Rights Reserved. */ +#include +#include +#include #include +#include #include -#include +#include #include #include #include #include #include +#include +#include + +#include #include #include -#include -#include -#include -#include =20 #include =20 --=20 2.43.0.rc1.1.gbec44491f096