From nobody Sat Feb 7 18:15:46 2026 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70CA12C19C for ; Mon, 19 Feb 2024 11:23:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708341796; cv=none; b=OO1uMi/DAWunLjKY1igPKnW4jlG2ABFJ+vyoaN2igKcZmdUCkKaOIWr5ml0/YVHmqpPbbDtnj9CBOUzPKBMPM/0UltTgo5QUEmU5Y8vd9pFkY7fWCjMghTyjTe98M51bH2VnLMuCwpj5YAs1MpQ5ZBQwB6x59zt8e9u0+5F5Gyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708341796; c=relaxed/simple; bh=iK0e+c0J9gt3ZVOym87zEAk44jIgYaxHSgdf2FUECRw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jqNauk8ARJSJPuRGNRkAEydI+0khiU3jvDBCYTeQCNxIz5Et2snq0pPzZh7pEimaYpeAXe736UAxco47hpc45JJ9S21OvXV+vtewYznRYy3sCqs2S2XeeKSZbblX8Qp4+KBctxEFBQQfUHaaYnY39o4BDttwq3u3NRoBstM9OtM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k1tWZsvP; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k1tWZsvP" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a3ea7616097so79126966b.1 for ; Mon, 19 Feb 2024 03:23:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708341792; x=1708946592; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bmDgTWHbaX2qtPcYpGBlJHczQDop2U5oSFjT56bWXAk=; b=k1tWZsvP6+EhZF3EYQU9PdNKRjCW2fruMb/4VodJhuCKbaWaL4b7pFnfOxqfaD1+xj jpv/o0+IsGKugAvh559voarcZomM4jP25snDpYZq+XM1S7W3tPK+kC9hKIxKyhY9b1MG DsfjYXA0JslChqFwH5odIRbDkqf/LGkOZzlgLXdZb+EfoeZ79K7XlGYTAnxJT9izEf6e dakJ+ykZcDzoCnMhrI6yKclySSsRYkvAjxQXQ+Y2D2WReubj9DDy13xTuYh09Y0j0R94 h1itVKS6ljipAp7RlVohh6GKeGiywHWYpXVa8BjpYdbKSnPyq+bNXX3wp99eoabK3XhN u4qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708341792; x=1708946592; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bmDgTWHbaX2qtPcYpGBlJHczQDop2U5oSFjT56bWXAk=; b=M3H8sNV1aIUPXa/KWOatDJFOOC/rT6Bf+tPvgCWhSazc8VG550e27EhiaUrHWx28KV 0IbTLc9nzJrwrYNFF0AxstdChuub+ONKr02vTDqo/+NTv5xc75jGyp9j15Q0W8jtOf/r DiEND3h18jdq14q16W97AGqK49sZXVvZi0CH7iCELApbEU3mUlfJHeXmOQsWG9q9VRRJ CEzur8FkvUR+8IN8olt1TxmlVltvKkU3iSagSWdkn2iJpbM5YjrgCciW7Pvo09oanZUD 1F/mxypMC2mNkH3HLNqCeXIdgodgt7S4/haby7wIUiCsdSJpj/YnxIDWm7K8hGA2vdAm z8ww== X-Forwarded-Encrypted: i=1; AJvYcCUqGLuoVrRFDYbRAwPEN2Gtk8x23+V2sC5orM0Zm/apDYTDuSdr9sbPCvdpmlXkOPNkhGg10QEWhQzL6lLSvSK5dUmXrUi4GX4KZZEV X-Gm-Message-State: AOJu0Yw5Em/XRWEu9l6rLgQ1SIbXGxJ0cL9NsA6VHrxT1gDgNOBrkgUN WIAcGdZZCWMGL2TUxqKoVGH9ZrGPx0sYYb2G5jkvCMZJfk38tAG4 X-Google-Smtp-Source: AGHT+IF0+e8nNULuQdit5i/onzkhM2XG35UGS6l/IhtByN/m7Oo7XmQAuUWffmZBjcClq8nu1hedEA== X-Received: by 2002:a17:906:2ad4:b0:a3e:19cc:16a with SMTP id m20-20020a1709062ad400b00a3e19cc016amr3606631eje.52.1708341792503; Mon, 19 Feb 2024 03:23:12 -0800 (PST) Received: from pinguine.lan (ip-176-198-146-182.um43.pools.vodafone-ip.de. [176.198.146.182]) by smtp.gmail.com with ESMTPSA id ti12-20020a170907c20c00b00a3d581658bfsm2826495ejc.24.2024.02.19.03.23.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 03:23:12 -0800 (PST) From: "Moritz C. Weber" To: florian.fainelli@broadcom.com Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Moritz C. Weber" Subject: [PATCH v3 1/2] Staging: vc04_services: bcm2835-camera: fix blank line style check Date: Mon, 19 Feb 2024 12:22:33 +0100 Message-Id: <20240219112234.8673-2-mo.c.weber@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240219112234.8673-1-mo.c.weber@gmail.com> References: <236d985c-1835-410f-b0b5-cacbd5fbf930@moroto.mountain> <20240219112234.8673-1-mo.c.weber@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove blank line to fix checkpatch check: Increase readability and consistency Signed-off-by: Moritz C. Weber Reviewed-by: Dan Carpenter --- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c = b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index e6e89784d..e6ff5ea04 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -1006,7 +1006,6 @@ static int vidioc_try_fmt_vid_cap(struct file *file, = void *priv, return 0; } =20 - static int mmal_setup_video_component(struct bcm2835_mmal_dev *dev, struct v4l2_format *f) { --=20 2.30.2 From nobody Sat Feb 7 18:15:46 2026 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0A062C1A4 for ; Mon, 19 Feb 2024 11:23:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708341796; cv=none; b=eUgUorJ2ge64X8dRE9L20rENFLXmsakA83OkV4e1dEeBja8x5QZEqVpW2HJy9QnacEJWaI/8XplTc4x6fLOyalwgydbfQwU07mK06n4jgQ1trulIN20NE6xcKAhioR7lMzXE+zyu74uMap2fZIFcp6sb0IlvRXq4NbiGcuY7fU0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708341796; c=relaxed/simple; bh=WJhan3UP9Z7GAaBjgIiNA/IqDSv3J6aKXJJ9PHj+wuI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SvLnVLmTvMHGFQBFm06xtdsaEbAI9JEPHSEi7btHuQXlwLrZV5KeVhRW3l26HIVqSvXptmNmV93oAwmfoDROR4L1Piv9NPqWHCaNi9FGjbuIX5QCa0td9yPKKjVEpWlegUDOB1pSemFjFfbR1oQe9HE/zQxcihaPYZu6SmYEBmQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BcDMNwAv; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BcDMNwAv" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a3122b70439so498989166b.3 for ; Mon, 19 Feb 2024 03:23:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708341793; x=1708946593; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YuW0tA1+gOLBqnUIoohkzCyIMBvVnloNgoNFu8SX/5U=; b=BcDMNwAvpAQuQBhFKoX8J/LsyIaXWH/r5Zf4A7hjGDKwykBlOONppCi97gLWrEHMxr eZvzJhSEfGwoAcKKNkLmLfLn/HywEAeYL7xKguEcTCrCpX67mH4JyAS2pm9xrSeAyxOl GzAzOhz1w0hHbfW7DUfYPoQi23NDns3dasiOlP21uhf2qsH8n4EAg2tNXSzxhNR7yjeb tTP85Bx3ueGPOzL8/xiMJFQfAnJGbT7FdWC2BwYNFTMvzgZM66hCgIr4Rp0K1J95KKwq yYY+uEcaOSlNVuWRQxU+bjQy8R4QZE2m0ND/tSRBLQ2R/ji7WKEh1H+mk6n7rLSn7jJY 4Hlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708341793; x=1708946593; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YuW0tA1+gOLBqnUIoohkzCyIMBvVnloNgoNFu8SX/5U=; b=mZYHspwBdXrl1trSeRzztm2PSm5oIK3Dh99Qm4tLtSr4S13EZ7dNrvPLRuCKNJeCRa FTKKQyJiBP4deFWOYobxkrtry4WaddBgmjCCuKSlNZDB4jR2KIKk9e2RbBSmj+pHFAqI OiK7AZXeJNIikStskUCwlcjT0NUxcupkdMsx+3AywbvBn5OeyhaPxJsFUMZwojFWRAaK vbE5AuIsAykNKmTDD7FtaEFAD+VnvfbeAAUJHWoKEa8m9Qw4vmR/YdWdZogz7jS5E11D 0LOyllV+R6oWm6eRVvf94BveKf+9NgSLPt7CZn8WQoHPHd6rLMdpGRjOzN9g8kUR5DIR Duww== X-Forwarded-Encrypted: i=1; AJvYcCXiU7FGXgsMp45gBFXArug83Jy0b7cj0NKbl2PLhNnhet+BTtjA1bXXRg8n4L2PlW+9tY2BZ8EuXm9JgsfAlondEVr13v+Xof4lZp7i X-Gm-Message-State: AOJu0YyW0OpRP1P6v9IrjabbmxCq7u24ijG8m+9gZSJrVq5U79k0Zygm Iu87K7ZET9NHCvMTRee/EtLYM5B0qa0Guk1z86ooh2i5H2BDsnvp X-Google-Smtp-Source: AGHT+IGSD3jTvmpSu9lWqJy92v3b8wbBP8Kn6inBcfLvx/7Fp4KrXtljJvlVnzhlgszKc5IkdfBLKg== X-Received: by 2002:a17:906:a1cd:b0:a3d:6eb4:9768 with SMTP id bx13-20020a170906a1cd00b00a3d6eb49768mr7088156ejb.46.1708341793096; Mon, 19 Feb 2024 03:23:13 -0800 (PST) Received: from pinguine.lan (ip-176-198-146-182.um43.pools.vodafone-ip.de. [176.198.146.182]) by smtp.gmail.com with ESMTPSA id ti12-20020a170907c20c00b00a3d581658bfsm2826495ejc.24.2024.02.19.03.23.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 03:23:12 -0800 (PST) From: "Moritz C. Weber" To: florian.fainelli@broadcom.com Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Moritz C. Weber" Subject: [PATCH v3 2/2] Staging: vc04_services: bcm2835-camera: fix brace code style check Date: Mon, 19 Feb 2024 12:22:34 +0100 Message-Id: <20240219112234.8673-3-mo.c.weber@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240219112234.8673-1-mo.c.weber@gmail.com> References: <236d985c-1835-410f-b0b5-cacbd5fbf930@moroto.mountain> <20240219112234.8673-1-mo.c.weber@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reformat function parameters to fix checkpatch check: Increase readability and consistency Signed-off-by: Moritz C. Weber Reviewed-by: Dan Carpenter --- .../bcm2835-camera/bcm2835-camera.c | 60 +++++++++---------- 1 file changed, 28 insertions(+), 32 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c = b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index e6ff5ea04..c3ba490e5 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -350,12 +350,11 @@ static void buffer_cb(struct vchiq_mmal_instance *ins= tance, if (is_capturing(dev)) { v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev, "Grab another frame"); - vchiq_mmal_port_parameter_set( - instance, - dev->capture.camera_port, - MMAL_PARAMETER_CAPTURE, - &dev->capture.frame_count, - sizeof(dev->capture.frame_count)); + vchiq_mmal_port_parameter_set(instance, + dev->capture.camera_port, + MMAL_PARAMETER_CAPTURE, + &dev->capture.frame_count, + sizeof(dev->capture.frame_count)); } if (vchiq_mmal_submit_buffer(instance, port, &buf->mmal)) @@ -406,12 +405,11 @@ static void buffer_cb(struct vchiq_mmal_instance *ins= tance, is_capturing(dev)) { v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev, "Grab another frame as buffer has EOS"); - vchiq_mmal_port_parameter_set( - instance, - dev->capture.camera_port, - MMAL_PARAMETER_CAPTURE, - &dev->capture.frame_count, - sizeof(dev->capture.frame_count)); + vchiq_mmal_port_parameter_set(instance, + dev->capture.camera_port, + MMAL_PARAMETER_CAPTURE, + &dev->capture.frame_count, + sizeof(dev->capture.frame_count)); } } =20 @@ -420,11 +418,10 @@ static int enable_camera(struct bcm2835_mmal_dev *dev) int ret; =20 if (!dev->camera_use_count) { - ret =3D vchiq_mmal_port_parameter_set( - dev->instance, - &dev->component[COMP_CAMERA]->control, - MMAL_PARAMETER_CAMERA_NUM, &dev->camera_num, - sizeof(dev->camera_num)); + ret =3D vchiq_mmal_port_parameter_set(dev->instance, + &dev->component[COMP_CAMERA]->control, + MMAL_PARAMETER_CAMERA_NUM, &dev->camera_num, + sizeof(dev->camera_num)); if (ret < 0) { v4l2_err(&dev->v4l2_dev, "Failed setting camera num, ret %d\n", ret); @@ -468,11 +465,11 @@ static int disable_camera(struct bcm2835_mmal_dev *de= v) "Failed disabling camera, ret %d\n", ret); return -EINVAL; } - vchiq_mmal_port_parameter_set( - dev->instance, - &dev->component[COMP_CAMERA]->control, - MMAL_PARAMETER_CAMERA_NUM, &i, - sizeof(i)); + vchiq_mmal_port_parameter_set(dev->instance, + &dev->component[COMP_CAMERA]->control, + MMAL_PARAMETER_CAMERA_NUM, + &i, + sizeof(i)); } v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev, "Camera refcount now %d\n", dev->camera_use_count); @@ -786,9 +783,8 @@ static int vidioc_overlay(struct file *file, void *f, u= nsigned int on) ret =3D vchiq_mmal_port_connect_tunnel(dev->instance, src, NULL); if (ret >=3D 0) - ret =3D vchiq_mmal_component_disable( - dev->instance, - dev->component[COMP_PREVIEW]); + ret =3D vchiq_mmal_component_disable(dev->instance, + dev->component[COMP_PREVIEW]); =20 disable_camera(dev); return ret; @@ -1041,8 +1037,8 @@ static int mmal_setup_video_component(struct bcm2835_= mmal_dev *dev, =20 if (overlay_enabled) { ret =3D vchiq_mmal_port_connect_tunnel(dev->instance, - preview_port, - &dev->component[COMP_PREVIEW]->input[0]); + preview_port, + &dev->component[COMP_PREVIEW]->input[0]); if (ret) return ret; =20 @@ -1719,11 +1715,11 @@ static int mmal_init(struct bcm2835_mmal_dev *dev) { unsigned int enable =3D 1; =20 - vchiq_mmal_port_parameter_set( - dev->instance, - &dev->component[COMP_VIDEO_ENCODE]->control, - MMAL_PARAMETER_VIDEO_IMMUTABLE_INPUT, - &enable, sizeof(enable)); + vchiq_mmal_port_parameter_set(dev->instance, + &dev->component[COMP_VIDEO_ENCODE]->control, + MMAL_PARAMETER_VIDEO_IMMUTABLE_INPUT, + &enable, + sizeof(enable)); =20 vchiq_mmal_port_parameter_set(dev->instance, &dev->component[COMP_VIDEO_ENCODE]->control, --=20 2.30.2