From nobody Thu Sep 19 00:59:05 2024 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A06B1419A1 for ; Thu, 15 Feb 2024 21:58:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708034289; cv=none; b=sOSRSuvQu18KIEB3nxz88xFRZk7DoQi489acWYOC17nGAHUdx6GO9NmXfxK5S7qqboTG1GMoxHk78Bc/RYhFALuEGIk+yXTzy0lugLNnSBS0/Ywq/6O6dr8+QWM8oh2Ctg7Z/KB+7nPhLcCwMauKgTJW8gXnCbycMlDDo30j3aM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708034289; c=relaxed/simple; bh=Ys61LhwK5bbvxeNYU9dsScoosMza3Uynl66l8gUyVwo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WdtJMDtLA85oAloxT/61aCpZPxPHeyeD+SsYhdcsgWlcLtkxjQWiRdHdXY4CkeUQJA6ucMy+mSQWTHBB9RvU3alAJTDSuaXyQu6fzs34eAUUK6rYKPheo1yRrKx5RSwFqET1mAfCaXEC98Ar4BGdnfbJsPaG+UxvrwrGJNaEu7w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Lq1CI18k; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=j2jTR4Fa; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Lq1CI18k; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=j2jTR4Fa; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Lq1CI18k"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="j2jTR4Fa"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Lq1CI18k"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="j2jTR4Fa" Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7E948220D6; Thu, 15 Feb 2024 21:58:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SgcBd7sH7Nb1byG5FyFq1szLLWX/BwNgi8qAPvNM0FU=; b=Lq1CI18k0Hlj84sJ6RGhkACsx+tVYQwKlKFcvoo+QvOizDFbET+y9Ru43hskhgx0Kor8mP jNRe0QFTA/E/wFVq/UZ69Nlqs/04LPD/EvFjdc8TmbedPYcuuptm/Pq56gk3nrx8Ky2Pen dd9jpObJx8kK4xra/4GWYZXQDzuQfXI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SgcBd7sH7Nb1byG5FyFq1szLLWX/BwNgi8qAPvNM0FU=; b=j2jTR4Fas0JFvwlYlzbtAxn3+b1OmQMTIE1FhifzQU/inbnZgVuPjzeb9E6zFUApxFuH8E SnYk16tt0hMQIXCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SgcBd7sH7Nb1byG5FyFq1szLLWX/BwNgi8qAPvNM0FU=; b=Lq1CI18k0Hlj84sJ6RGhkACsx+tVYQwKlKFcvoo+QvOizDFbET+y9Ru43hskhgx0Kor8mP jNRe0QFTA/E/wFVq/UZ69Nlqs/04LPD/EvFjdc8TmbedPYcuuptm/Pq56gk3nrx8Ky2Pen dd9jpObJx8kK4xra/4GWYZXQDzuQfXI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SgcBd7sH7Nb1byG5FyFq1szLLWX/BwNgi8qAPvNM0FU=; b=j2jTR4Fas0JFvwlYlzbtAxn3+b1OmQMTIE1FhifzQU/inbnZgVuPjzeb9E6zFUApxFuH8E SnYk16tt0hMQIXCw== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id EF6891346A; Thu, 15 Feb 2024 21:58:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id eFbCN+2IzmXPAQAAn2gu4w (envelope-from ); Thu, 15 Feb 2024 21:58:05 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v10 5/7] mm,page_owner: Display all stacks and their count Date: Thu, 15 Feb 2024 22:59:05 +0100 Message-ID: <20240215215907.20121-6-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240215215907.20121-1-osalvador@suse.de> References: <20240215215907.20121-1-osalvador@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: 0.70 X-Spamd-Result: default: False [0.70 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_MISSING_CHARSET(2.50)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_SEVEN(0.00)[9]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[vger.kernel.org,kvack.org,suse.com,suse.cz,google.com,gmail.com,suse.de]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-3.00)[100.00%] X-Spam-Flag: NO Content-Type: text/plain; charset="utf-8" This patch adds a new directory called 'page_owner_stacks' under /sys/kernel/debug/, with a file called 'show_stacks' in it. Reading from that file will show all stacks that were added by page_owner followed by their counting, giving us a clear overview of stack <-> count relationship. E.g: prep_new_page+0xa9/0x120 get_page_from_freelist+0x801/0x2210 __alloc_pages+0x18b/0x350 alloc_pages_mpol+0x91/0x1f0 folio_alloc+0x14/0x50 filemap_alloc_folio+0xb2/0x100 __filemap_get_folio+0x14a/0x490 ext4_write_begin+0xbd/0x4b0 [ext4] generic_perform_write+0xc1/0x1e0 ext4_buffered_write_iter+0x68/0xe0 [ext4] ext4_file_write_iter+0x70/0x740 [ext4] vfs_write+0x33d/0x420 ksys_write+0xa5/0xe0 do_syscall_64+0x80/0x160 entry_SYSCALL_64_after_hwframe+0x6e/0x76 stack_count: 4578 The seq stack_{start,next} functions will iterate through the list stack_list in order to print all stacks. Signed-off-by: Oscar Salvador Acked-by: Marco Elver Reviewed-by: Vlastimil Babka --- mm/page_owner.c | 93 ++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 92 insertions(+), 1 deletion(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index df6a923af5de..e99fbf822dd6 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -171,7 +171,13 @@ static void add_stack_record_to_list(struct stack_reco= rd *stack_record, =20 spin_lock_irqsave(&stack_list_lock, flags); stack->next =3D stack_list; - stack_list =3D stack; + /* + * This pairs with smp_load_acquire() from function + * stack_start(). This guarantees that stack_start() + * will see an updated stack_list before starting to + * traverse the list. + */ + smp_store_release(&stack_list, stack); spin_unlock_irqrestore(&stack_list_lock, flags); } =20 @@ -805,8 +811,90 @@ static const struct file_operations proc_page_owner_op= erations =3D { .llseek =3D lseek_page_owner, }; =20 +static void *stack_start(struct seq_file *m, loff_t *ppos) +{ + struct stack *stack; + + if (*ppos =3D=3D -1UL) + return NULL; + + if (!*ppos) { + /* + * This pairs with smp_store_release() from function + * add_stack_record_to_list(), so we get a consistent + * value of stack_list. + */ + stack =3D smp_load_acquire(&stack_list); + } else { + stack =3D m->private; + stack =3D stack->next; + } + + m->private =3D stack; + + return stack; +} + +static void *stack_next(struct seq_file *m, void *v, loff_t *ppos) +{ + struct stack *stack =3D v; + + stack =3D stack->next; + *ppos =3D stack ? *ppos + 1 : -1UL; + m->private =3D stack; + + return stack; +} + +static int stack_print(struct seq_file *m, void *v) +{ + int i, stack_count; + struct stack *stack =3D v; + unsigned long *entries; + unsigned long nr_entries; + struct stack_record *stack_record =3D stack->stack_record; + + nr_entries =3D stack_record->size; + entries =3D stack_record->entries; + stack_count =3D refcount_read(&stack_record->count) - 1; + + if (!nr_entries || nr_entries < 0 || stack_count < 1) + return 0; + + for (i =3D 0; i < nr_entries; i++) + seq_printf(m, " %pS\n", (void *)entries[i]); + seq_printf(m, "stack_count: %d\n\n", stack_count); + + return 0; +} + +static void stack_stop(struct seq_file *m, void *v) +{ +} + +static const struct seq_operations page_owner_stack_op =3D { + .start =3D stack_start, + .next =3D stack_next, + .stop =3D stack_stop, + .show =3D stack_print +}; + +static int page_owner_stack_open(struct inode *inode, struct file *file) +{ + return seq_open_private(file, &page_owner_stack_op, 0); +} + +static const struct file_operations page_owner_stack_operations =3D { + .open =3D page_owner_stack_open, + .read =3D seq_read, + .llseek =3D seq_lseek, + .release =3D seq_release, +}; + static int __init pageowner_init(void) { + struct dentry *dir; + if (!static_branch_unlikely(&page_owner_inited)) { pr_info("page_owner is disabled\n"); return 0; @@ -814,6 +902,9 @@ static int __init pageowner_init(void) =20 debugfs_create_file("page_owner", 0400, NULL, NULL, &proc_page_owner_operations); + dir =3D debugfs_create_dir("page_owner_stacks", NULL); + debugfs_create_file("show_stacks", 0400, dir, NULL, + &page_owner_stack_operations); =20 return 0; } --=20 2.43.0