From nobody Sat Feb 7 22:06:29 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0583D6088E; Wed, 14 Feb 2024 17:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707930655; cv=none; b=olGfz4lvbVNZMXLZznOymKvl/At2ywjZ38//RAeSZuAf9oLg+X19rJN93ptnPoo7nEbnENVBFy7RVi/szbNT2zFLLpNlgagY20SQVxNYDup/k0VQgQgYTTfbSVigym/j0Nz59U71QEn9+wjVM0ZWUP0fznkd44Ikg99oWHWvCbo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707930655; c=relaxed/simple; bh=6SSOUnIBqCm1UlIPDdIu3o/LhTRQZBXFqS1PUYB3XUQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IvxlkhqysQyIU68Nwjlm9S8G6YFSf2zt+QfanJCOERZea3jStT7MPYp6bBaWZrh4r4tBTpU7976mUw8kxPgsXU94hzYAjHHaQndhDBCFJDCBHQrBj5y47PeDp5haqP5hc7qwO7pTzb/wLae7LeDu/scxHWdZhIF1qhus4KPmkoA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jil45KuT; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jil45KuT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707930654; x=1739466654; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6SSOUnIBqCm1UlIPDdIu3o/LhTRQZBXFqS1PUYB3XUQ=; b=jil45KuTZP8wEccwSX/Avc2xP4QG07kUPh5aY1NubwKO8S5NFnIsCy9U 45rz8w6SXtvOjZQ+jP6XdktjgzlHgHu7jwuhGk32B1ijJeJ0vsC7yNNzu y8YPSOh6RdVLbOB3okOnDE4DHvXpmGgyBbHqQYi6FRtOAUwxyY8x8PAw+ i+a0aqiKIBazoo9t4VCtD2G4qpIdRktTk/hL7bnTBqcVORmZeOjmPbyOV Nr8boVZvrkeSH2/SjD9wIKCH/ENEgPwVBo9hs0i+S3GTcDFkmoUOiUSHR Wl0Bk4BQIfpzMv8DtHsr5Zirst3dsupMPo0mUjdcqk9RzEFwGG62ZZogW w==; X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="24458023" X-IronPort-AV: E=Sophos;i="6.06,160,1705392000"; d="scan'208";a="24458023" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2024 09:10:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="935617216" X-IronPort-AV: E=Sophos;i="6.06,160,1705392000"; d="scan'208";a="935617216" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 14 Feb 2024 09:10:49 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id A70A6A3; Wed, 14 Feb 2024 19:10:48 +0200 (EET) From: Andy Shevchenko To: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko Subject: [PATCH v1 1/5] serial: 8250_exar: Clear interrupts before registering handler Date: Wed, 14 Feb 2024 19:09:34 +0200 Message-ID: <20240214171044.3551032-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240214171044.3551032-1-andriy.shevchenko@linux.intel.com> References: <20240214171044.3551032-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" While now there is no issue if IRQ is fired before we clearing the interrupts as the handler does the same, but strictly speaking it might be problematic if IRQ handler wants to do something more. Move clearing interrupt code to be called before registering the IRQ handler. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/= 8250_exar.c index 23366f868ae3..32a56ce626b5 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -713,14 +713,14 @@ exar_pci_probe(struct pci_dev *pcidev, const struct p= ci_device_id *ent) uart.port.irq =3D pci_irq_vector(pcidev, 0); uart.port.dev =3D &pcidev->dev; =20 + /* Clear interrupts */ + exar_misc_clear(priv); + rc =3D devm_request_irq(&pcidev->dev, uart.port.irq, exar_misc_handler, IRQF_SHARED, "exar_uart", priv); if (rc) return rc; =20 - /* Clear interrupts */ - exar_misc_clear(priv); - for (i =3D 0; i < nr_ports && i < maxnr; i++) { rc =3D board->setup(priv, pcidev, &uart, i); if (rc) { --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 22:06:29 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6189A60BA5; Wed, 14 Feb 2024 17:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707930655; cv=none; b=g0Q+diDJFjnP2W2GSTiwoUt0k/BLyAQ1liPR7tGVlz3i5wNgg0nl3QnkYKHITZUdLJwXIQf6t9cJ20SwHqhp26N1DkTmmiGq8we+TR7Un4Hy3pvO0C/3eLOsFRrNzGP7lb7JEXe29irE7HljniT/AdC1Ts7MbXiz3Ue8Z497dmU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707930655; c=relaxed/simple; bh=kUiZbiEMkh/Xz3+hmq1lLEQ7AxDT02YREhPln3pQnvs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=donvmMCErqWbOAci3x9+XweYAvRtX1R6Au4uQRsZsEZmmi7LFTdQPmZQEBvZoatMArKKz4TuK+wwzmPppLNeMS3iTF6BfBDi3oo+FjLkx5hK8AlR8MtYTWhpDMC9qYOFmMwR/BbZbS8502ARs5ggLsxuHQI6TRGbt+BgFdPZlf8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nAaAs3/K; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nAaAs3/K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707930655; x=1739466655; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kUiZbiEMkh/Xz3+hmq1lLEQ7AxDT02YREhPln3pQnvs=; b=nAaAs3/Ky88yt1uqfJVfCufWYYnvlsVSCtBbwakDfuFpvsAdZ5W1SNoE veubS1Pr0Icuo0vrTOflqGo6q27AQ+pdgJ0fQzUJilDDmvGpX9SoCCICn f6QReehPW4Gj7mXjSDixiDg9qnigmTeoCKkCSDqLoUL27HnB0a1oL1L0O P/99hd45ZDRizIBp0TxLWqH7FArx/uh78w2yc3iFziDkX+X8MCN0lwppO OKgLMrrSOXP5kzas9sRQHLaSSbpiEAaCXbVkldmHJuxFAWvTJV3ug7cm9 lr4sAoCsivnwO5Rqv/kdPnXeNgNYDIS905lg6vzXMILSvMzfjK+gPkris Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="24458026" X-IronPort-AV: E=Sophos;i="6.06,160,1705392000"; d="scan'208";a="24458026" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2024 09:10:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="935617217" X-IronPort-AV: E=Sophos;i="6.06,160,1705392000"; d="scan'208";a="935617217" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 14 Feb 2024 09:10:49 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id B5BE926D; Wed, 14 Feb 2024 19:10:48 +0200 (EET) From: Andy Shevchenko To: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko Subject: [PATCH v1 2/5] serial: 8250_exar: Use generic function to set firmware node Date: Wed, 14 Feb 2024 19:09:35 +0200 Message-ID: <20240214171044.3551032-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240214171044.3551032-1-andriy.shevchenko@linux.intel.com> References: <20240214171044.3551032-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use generic function to set firmware node instead of ACPI specific one. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/= 8250_exar.c index 32a56ce626b5..7dfb995ec927 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -6,12 +6,12 @@ * * Copyright (C) 2017 Sudip Mukherjee, All Rights Reserved. */ -#include #include #include #include #include #include +#include #include #include #include @@ -375,7 +375,7 @@ static struct platform_device *__xr17v35x_register_gpio= (struct pci_dev *pcidev, return NULL; =20 pdev->dev.parent =3D &pcidev->dev; - ACPI_COMPANION_SET(&pdev->dev, ACPI_COMPANION(&pcidev->dev)); + device_set_node(&pdev->dev, dev_fwnode(&pcidev->dev)); =20 if (device_add_software_node(&pdev->dev, node) < 0 || platform_device_add(pdev) < 0) { --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 22:06:29 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92D5F6087C; Wed, 14 Feb 2024 17:10:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707930655; cv=none; b=cfikmelu81OGadJSceyyUNxQ+mgO//6jtn/NI3u4QJjuQcKMCaO9G4S6p8Ha+tt2w1VKO97CHM9AhQTehIXU20IfKn0wUg8jGjAsjCzdU3BdDBuIRDxxj/MgUuh3DYP9T6e9ha2ToZ0opUb/r89co2jsLkBZ0Kr+0I3z83H65mc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707930655; c=relaxed/simple; bh=lh/6QP+fLjWx7NnRnuGXCG0uePmFC6Mmb21smh0lUm4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KDq/szPi6ApbeqK9Gglc3t1++gEtKstOzLZc9XMPsw1KHWtDSX9C38BDaL+isA1HJAKQOHTBJAyz+ryYVxmPIvBdAXNVgkKmlyhQcdVCq4sAucoSTmmUJzTgC3LpPY/NIez67wrOnI85uP0ua+8QDRbOInSDMkY1lZwM5sZRjNc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=EzwMNcYx; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EzwMNcYx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707930654; x=1739466654; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=lh/6QP+fLjWx7NnRnuGXCG0uePmFC6Mmb21smh0lUm4=; b=EzwMNcYxXHO12VzOFfLoLm3P6TmNQyy4XzYCQ7eg/Dlyo3vy61iw7UMM MATd7EVwwKKDYkUf3tbosClxHNiLLI38z2l/DBpzfiDYn/EGkm4ZZASJy 7fihBGH6tocPhWVYybXtuW1eEDZLeRKGPCj8t13E9nnnnQ6GzKfdMAdMu ytjMH/zCvmrSxEut8GLT/2olvmRbuvShjcDCHzN0m3+bPFTpV9gEwD4C0 QX/GGVFav5rO5oiv1h3lmEOmSY+vSqiQb9IYmG7eXZZaGRCOT48Au6psr N0CS5BONn/vq58L86RUdVKuzJ4c4C2ModabF+pVRfshg3JozjdL+i2PID g==; X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="24458020" X-IronPort-AV: E=Sophos;i="6.06,160,1705392000"; d="scan'208";a="24458020" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2024 09:10:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="935617214" X-IronPort-AV: E=Sophos;i="6.06,160,1705392000"; d="scan'208";a="935617214" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 14 Feb 2024 09:10:49 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id BE3FC2DC; Wed, 14 Feb 2024 19:10:48 +0200 (EET) From: Andy Shevchenko To: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko Subject: [PATCH v1 3/5] serial: 8250_exar: switch to DEFINE_SIMPLE_DEV_PM_OPS() Date: Wed, 14 Feb 2024 19:09:36 +0200 Message-ID: <20240214171044.3551032-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240214171044.3551032-1-andriy.shevchenko@linux.intel.com> References: <20240214171044.3551032-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" SIMPLE_DEV_PM_OPS() is deprecated, replace it with DEFINE_SIMPLE_DEV_PM_OPS= () and use pm_sleep_ptr() for setting the driver's PM routines. We can now remove the __maybe_unused qualifier in the suspend and resume functions. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/= 8250_exar.c index 7dfb995ec927..fa750c586b1f 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -757,7 +758,7 @@ static void exar_pci_remove(struct pci_dev *pcidev) priv->board->exit(pcidev); } =20 -static int __maybe_unused exar_suspend(struct device *dev) +static int exar_suspend(struct device *dev) { struct pci_dev *pcidev =3D to_pci_dev(dev); struct exar8250 *priv =3D pci_get_drvdata(pcidev); @@ -774,7 +775,7 @@ static int __maybe_unused exar_suspend(struct device *d= ev) return 0; } =20 -static int __maybe_unused exar_resume(struct device *dev) +static int exar_resume(struct device *dev) { struct exar8250 *priv =3D dev_get_drvdata(dev); unsigned int i; @@ -788,7 +789,7 @@ static int __maybe_unused exar_resume(struct device *de= v) return 0; } =20 -static SIMPLE_DEV_PM_OPS(exar_pci_pm, exar_suspend, exar_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(exar_pci_pm, exar_suspend, exar_resume); =20 static const struct exar8250_board pbn_fastcom335_2 =3D { .num_ports =3D 2, @@ -938,7 +939,7 @@ static struct pci_driver exar_pci_driver =3D { .probe =3D exar_pci_probe, .remove =3D exar_pci_remove, .driver =3D { - .pm =3D &exar_pci_pm, + .pm =3D pm_sleep_ptr(&exar_pci_pm), }, .id_table =3D exar_pci_tbl, }; --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 22:06:29 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48FFD60DC4; Wed, 14 Feb 2024 17:10:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707930656; cv=none; b=N1M7lGuHvoG37VWEoRS4j1IaBzhXrS1GhviKrFFJ8Ugn5WCCpSOGW8p2DnJbczVCTXZNFOrWk+1dUSlnjLE6qLHj6o3DAiOq5keZdW+y0TdpUpfmcan9n9PMyfb0n8Facw0oRIROXFpWQs8LQqLHcM8m2OUqPBP/ONZRyyy/IR4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707930656; c=relaxed/simple; bh=iqu0R7URicehdQ5woAZiYQWwq+ZkriMjICQ++/Ppr5c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KRFI8oGMOxNbQjSLKk1Zlwbdl8Yof16nm4EctETbmpzjDKhD3npOsEAoiYCfoEBnrJ2WO7FfWigLhvRpC8eGnu8P7pEvMq/eXmvOXU5UpqMXGbvpnCZTEPPZVWwHKJGTWf6/W9mkhNZV5pDBvakMUou0mDDXZ1fIxqRDKJ3Ocj4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=T0TZ4zlh; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="T0TZ4zlh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707930656; x=1739466656; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=iqu0R7URicehdQ5woAZiYQWwq+ZkriMjICQ++/Ppr5c=; b=T0TZ4zlhTdZqL4/snzN9WRUlMxCUYyNKHjTS266XxMmsVLSYiB29zRFk n0qdWk6YSnTQf+rooH/XsPU8MDKCLCLKM3x9Lvu5C27RxQAFIU2f819X3 PbeIz8PP/zBzBYbwdXPnGWCa4zo0qMTKWFnukdkLQz4utYgZc6u0QLUJx 2K6p5ClAiOql5RcK3RrqtpfLBLnVQk4ur2XS0XbTX7WZ63hUKtJ8J4y1M q5F8GFKDJ1vPMlwSau0kJrhNB7YGSSzXwREauiqvpW7QXsnHujzeLuOcR Ng1BpQAYiiARiFv5ofOGhXxKsHJ/nWgo4O9/iU35XNn0ql8BzYAKKgHr+ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="24458029" X-IronPort-AV: E=Sophos;i="6.06,160,1705392000"; d="scan'208";a="24458029" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2024 09:10:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="935617218" X-IronPort-AV: E=Sophos;i="6.06,160,1705392000"; d="scan'208";a="935617218" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 14 Feb 2024 09:10:49 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id C6A572E9; Wed, 14 Feb 2024 19:10:48 +0200 (EET) From: Andy Shevchenko To: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko Subject: [PATCH v1 4/5] serial: 8250_exar: Use 8250 PCI library to map and assign resources Date: Wed, 14 Feb 2024 19:09:37 +0200 Message-ID: <20240214171044.3551032-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240214171044.3551032-1-andriy.shevchenko@linux.intel.com> References: <20240214171044.3551032-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 8250 PCI library provides a common code to map and assign resources. Use it in order to deduplicate existing code and support IO port variants. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 10 +++++----- drivers/tty/serial/8250/Kconfig | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/= 8250_exar.c index fa750c586b1f..3913b8a99161 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -24,6 +24,7 @@ #include =20 #include "8250.h" +#include "8250_pcilib.h" =20 #define PCI_DEVICE_ID_ACCESSIO_COM_2S 0x1052 #define PCI_DEVICE_ID_ACCESSIO_COM_4S 0x105d @@ -230,13 +231,12 @@ static int default_setup(struct exar8250 *priv, struc= t pci_dev *pcidev, struct uart_8250_port *port) { const struct exar8250_board *board =3D priv->board; - unsigned int bar =3D 0; unsigned char status; + int err; =20 - port->port.iotype =3D UPIO_MEM; - port->port.mapbase =3D pci_resource_start(pcidev, bar) + offset; - port->port.membase =3D priv->virt + offset; - port->port.regshift =3D board->reg_shift; + err =3D serial8250_pci_setup_port(pcidev, port, 0, offset, board->reg_shi= ft); + if (err) + return err; =20 /* * XR17V35x UARTs have an extra divisor register, DLD that gets enabled diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kcon= fig index a5eb2657f279..52d8589f1dbe 100644 --- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig @@ -149,6 +149,7 @@ config SERIAL_8250_PCI config SERIAL_8250_EXAR tristate "8250/16550 Exar/Commtech PCI/PCIe device support" depends on SERIAL_8250 && PCI + select SERIAL_8250_PCILIB default SERIAL_8250 help This builds support for XR17C1xx, XR17V3xx and some Commtech --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 22:06:29 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C6ED60DD7; Wed, 14 Feb 2024 17:10:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707930657; cv=none; b=dmfXkG4c8Bijn7QRZbR0OQ/QIpA5CU+slWN4fUksXnQbi3Iyg4wzSad9B4OT2rr+CMjOBgkVQPfw1cKpICXZMD9CAlGtTT2mMU1iMKh7f+ZatKVurgvR9MWykwCpSY3i4ioI83V2GBxLUyxEXqmPjp0OByMtaisrSx2eJVN947I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707930657; c=relaxed/simple; bh=cWneu4cGadnP43AtfM005VSnasQf0LJKmBQueS3iyM0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VDCX1cReGgi/JWzaJe7xWgi03QFNdWcsQS7FHoiQZC2SH6J5NW/9EJTAlPTsqYakc0gF2ZvkLipcANqmsimWkBU5tyQMsaqDVs/fYAFKPFOmcjhTCVeM1Ps+XBvGX+Un/nSot+AXyXeZPuum5s6JIHCGZdYjrO3ox3loQzeP3DQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=lwVTDd3L; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lwVTDd3L" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707930656; x=1739466656; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cWneu4cGadnP43AtfM005VSnasQf0LJKmBQueS3iyM0=; b=lwVTDd3L01cP5pIsqSOlhggcwtfyQMNKyN3xpayznZXYpx5n4kw/Y9go 6ly/VQnMNlX28+bSrtYZuwUTxgRDYGRZ4XeLp4fo5b9CxL48Ub0einC1M GNKp6kVEvqhd3JNmcD2BuRQrjy+Kd6SdCAt7NPkRB4kORcF+6/Z1VRCxN kMgf5Jd4fa4hOn8ItgWIeDqpn4wWp0jrdSlkye6kpUY3QREl5+bBLJFLz bMW9fmqQsLikGMC9XSbtEcuKK9kDYdHc7bP5poG3N4KqlHqdmYGOM6I4g 98oFO4M69YBBrvrrpunOoPfbFX2iRUQ4K+CjG9XRRBfySonqbWw6w0MMy w==; X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="24458033" X-IronPort-AV: E=Sophos;i="6.06,160,1705392000"; d="scan'208";a="24458033" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2024 09:10:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="935617219" X-IronPort-AV: E=Sophos;i="6.06,160,1705392000"; d="scan'208";a="935617219" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 14 Feb 2024 09:10:52 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id CF7E9338; Wed, 14 Feb 2024 19:10:48 +0200 (EET) From: Andy Shevchenko To: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko Subject: [PATCH v1 5/5] serial: 8250_exar: Don't use "proxy" headers Date: Wed, 14 Feb 2024 19:09:38 +0200 Message-ID: <20240214171044.3551032-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240214171044.3551032-1-andriy.shevchenko@linux.intel.com> References: <20240214171044.3551032-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Update header inclusions to follow IWYU (Include What You Use) principle. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/= 8250_exar.c index 3913b8a99161..0afd33a9cf0d 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -6,20 +6,24 @@ * * Copyright (C) 2017 Sudip Mukherjee, All Rights Reserved. */ +#include +#include +#include #include +#include #include -#include +#include #include #include #include #include #include +#include +#include + +#include #include #include -#include -#include -#include -#include =20 #include =20 --=20 2.43.0.rc1.1.gbec44491f096