From nobody Sun Feb 8 05:30:18 2026 Received: from mail-out.aladdin-rd.ru (mail-out.aladdin-rd.ru [91.199.251.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C02C38DCC for ; Sun, 11 Feb 2024 15:06:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.199.251.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707663990; cv=none; b=uBduq8UBcn2Ra7m87Nl7U/X5DNUGOAVpqRS0Tolj3bjrG1r2kkuiheLbIsHX7Gdcm8Jd6nodW175ISm4Spr6ZXbM5d9IUwYLzFDsFspNmJWzmFqr62a7Hkx9HbOZbvFEXC7HrzetisaOMWjylfoQ3ZzoXnTXxjR2Kjr2OrQwQXA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707663990; c=relaxed/simple; bh=Ir5CIoqwF8eijYYjiBBP67sbxpfEg7mSHXBnmcSdXBA=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=GkoCtk4cIaonP7q0H+GUktt6pnWuKvdA2fD3nZkt/pIASZidvkeHBkoZS2awKAIj48dyYQNv1lBOmVdsRBFRZBj/TKgsLawmgWLs++wccgLEQGRJHfnr7rpWI8jkPpeJp8kIWlM+ZC/puOCeBvMI3WTvSAt4uZldxS3LwwwCYUM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aladdin.ru; spf=pass smtp.mailfrom=aladdin.ru; arc=none smtp.client-ip=91.199.251.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aladdin.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aladdin.ru From: Daniil Dulov To: David Airlie CC: Daniil Dulov , =?UTF-8?q?Christian=20K=C3=B6nig?= , Alex Deucher , Daniel Vetter , Evan Quan , , , , Subject: [PATCH] drm/amdgpu/swsmu: Fix if statement in smu_baco_get_state() Date: Sun, 11 Feb 2024 07:06:13 -0800 Message-ID: <20240211150613.3583-1-d.dulov@aladdin.ru> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: EXCH-2016-04.aladdin.ru (192.168.1.104) To EXCH-2016-01.aladdin.ru (192.168.1.101) Content-Type: text/plain; charset="utf-8" In smu_baco_get_state() smu->ppt_funcs->baco_get_state is checked for NULL. If it is NULL then the pointer is dereferenced. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 6c45e480fe23 ("drm/amd/powerplay: clear the swSMU code layer") Signed-off-by: Daniil Dulov --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/am= d/pm/swsmu/amdgpu_smu.c index ee27970cfff9..0fadb6aacd4b 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c @@ -2497,7 +2497,7 @@ bool smu_baco_is_support(struct smu_context *smu) =20 int smu_baco_get_state(struct smu_context *smu, enum smu_baco_state *state) { - if (smu->ppt_funcs->baco_get_state) + if (!smu->ppt_funcs->baco_get_state) return -EINVAL; =20 mutex_lock(&smu->mutex); --=20 2.25.1