From nobody Fri Sep 20 03:42:22 2024 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 854DB3D55A; Sat, 10 Feb 2024 11:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707566092; cv=none; b=TeppF9CWBxzSemtCY/KsuaKrK2lPv2hA4Yxph7GWnT+1s63IzOk1NISiQjKbPM5C/Yz8Abtn2mCwrz45Az/LL9HyobyA0JpxycmaarbYnvnKpo6bll1ID0U6l3Ec6lwXLIld3Klxq/glFywAioBBo19dX03HGnsY2OenDmz+dtQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707566092; c=relaxed/simple; bh=i7Tn34SbTS6bmF5O365GMlOv/Z7BFkNMdFAugMnz3tI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YhYuY/OobfdqrzaoKItgY8Cpw0g8rnIC46bKhp0t1ncofXbarIdm+NUpOv3wD3LrZXB4sj1GZOunN2yb/pRSusQiWhWAQdvQ/grsxhnLPYAFns/cR+tAp4oVkThDuQriq6ZVqa6RWX/P7GUoHM0dnQJ66DuGs/SZ0KGpkxy/0fg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bFoDlFFw; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bFoDlFFw" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5116b540163so2607635e87.1; Sat, 10 Feb 2024 03:54:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707566088; x=1708170888; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cXhoDwLT/QYD+UR1ERqNXhI5lFq76XtXf/m+zKMIMKk=; b=bFoDlFFwhsLo22LubslsQCIX0B7wqa5YI08T07WtQIokD61LHXsVbgDgtpHDz6Z4v1 JogL/A3nSZPL/7fNVnMq6uaK3wh1cajfCMKZQcX+ra5whegCq5k3cBfpauDoIuHkDc9S 6bUOgZhvwcOebFa4MiQnh8vvZE0sWCRPUXiG4kbwk5yHxqH+08ttOrMG9bni3D0m1MlB gqtf2GfUQxpPqP7ieeIZW7JtWBNuH/Css6juRxt/0OuzEzFVpXKFmkpdWMKuYjU/OmdX VMVQREUdzg+pjg3s1OiU228vj7eaZIQoGfJPABuI6n8eEKuXv4pGme6RSUBK9onmdnVI Lwlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707566088; x=1708170888; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cXhoDwLT/QYD+UR1ERqNXhI5lFq76XtXf/m+zKMIMKk=; b=KPB2XyVBe2GEoxSiHqpbsFL73676Azb6evVcSh6zO72dt/15pfBlRGIPpE/O4b5eOP +1/uFG9lGD+AOm4l6VpJ80piREboPtfhCWD93Wlp4pNeDr5xjqwjVAZYW4WS/kvUTArK TETAX5UEftVrG/EhhXMWHac9e00dp8mfEloO7fbhr4/bq+pr0df47xndzfFELFPMLpvk CEINUQKzA06VFTwTlNBjXwWGIP2n3OhhsNzNO3JH19qcl7iiWdT6PwuBDMoHz3Wmxy1l XpXP0bDfKYcEzMyT9ccZxZogQmsWC8NW67haeY8JoOb714417TG7dTFFIsi1BhrIhGny YOPA== X-Forwarded-Encrypted: i=1; AJvYcCXky05+a4mYjnNv5yAuqltDmQ1NS+UJMl3rtKkFYptMmD2A7cwiqgSB2DqUBbbEO7UFLV7zapU0tOCWzhWQF4XqFDR/funYjktTMQaLM+bwd1lwGTuwNjWnERbKAo0BqVeV5UTb X-Gm-Message-State: AOJu0YxE904NAPcjruBdUwJvup1U4VDas6DK7m6DhhfNRfSgl9V9nW/B b0qRImGYyzvJsfzmPuyHC03YGh0gV8VSuhGcbhRWHYroXGoSgrWEPYPWmlNLJ7Q= X-Google-Smtp-Source: AGHT+IGVgXBWrJR8HBBYCiONz9iH2SciZ+IXkQzOT5GRVjrwv4vx1xk3l+nlNmheGw0J22mDFBP90w== X-Received: by 2002:ac2:4ac9:0:b0:511:7b35:9563 with SMTP id m9-20020ac24ac9000000b005117b359563mr916952lfp.19.1707566088232; Sat, 10 Feb 2024 03:54:48 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUZ4HxutTqL5srSrYVT8MnyaxBLcnWI3owl87NpddswlsfSM89KKKUDmP+V2WPikdUsWjIs/cyOBGeze50lQrDswbo8bz/abdCGUU/8W9nl5lzvfsMCzyUcOBfSifI3oBv9z87zBoBgpoCdxcf5TfsR612k42CogQ/Mwdf2uAbruKTWanK5FSrF/EnxDq924wEK4nKYeQVW9ef4FxBkfKeCJx6iloiJ5yYeTZjEqG3l5CAVKQ7Xk7WfAHTYI4eSYCKRlcyuE/vDI7tVWP3Re5sIsZ49rii2mMR2YmWcdi+vujT3Yhv1gBPvAh6qRB7Q+9HAaPIfQzzTieulwWIkdKPp/fAhDxvT4I3kO+NDKgzWuGOoXgt96IcVh9o/16ksMSomVp7TlQntzMh2j2GXG/OEbkmZQcGMPA0bVWTsVGA6gt4/hANOGG0D8yZCNJPwqTn+XOMRWVmXthqC+nNdcAvqxOCXdFn/aX3O7gxrn8j47umPqAgiX8gpupquGsDS8AOreJX+ijQWU4+Xlc4ESGCdxL0MAkNynl4nvUhjxGsc1Vx/2jliCrja Received: from localhost.localdomain ([176.230.105.209]) by smtp.gmail.com with ESMTPSA id bo9-20020a056000068900b0033affaade9csm1694164wrb.68.2024.02.10.03.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Feb 2024 03:54:47 -0800 (PST) From: Elad Yifee To: Cc: eladwf@gmail.com, Felix Fietkau , Sean Wang , Mark Lee , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH net-next v2] net: ethernet: mtk_eth_soc: ppe: add support for multiple PPEs Date: Sat, 10 Feb 2024 13:53:28 +0200 Message-ID: <20240210115420.27003-1-eladwf@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240130160854.5221-1-eladwf@gmail.com> References: <20240130160854.5221-1-eladwf@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add the missing pieces to allow multiple PPEs units, one for each GMAC. mtk_gdm_config has been modified to work on targted mac ID, the inner loop moved outside of the function to allow unrelated operations like setting the MAC's PPE index. Signed-off-by: Elad Yifee --- v2: fixed CI warnings --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 86 +++++++++++-------- drivers/net/ethernet/mediatek/mtk_eth_soc.h | 15 +++- .../net/ethernet/mediatek/mtk_ppe_offload.c | 6 +- 3 files changed, 68 insertions(+), 39 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethe= rnet/mediatek/mtk_eth_soc.c index a6e91573f8da..5a50c22179af 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -2175,9 +2175,11 @@ static int mtk_poll_rx(struct napi_struct *napi, int= budget, skb_dst_set_noref(skb, ð->dsa_meta[port]->dst); } =20 - if (reason =3D=3D MTK_PPE_CPU_REASON_HIT_UNBIND_RATE_REACHED) - mtk_ppe_check_skb(eth->ppe[0], skb, hash); + if (reason =3D=3D MTK_PPE_CPU_REASON_HIT_UNBIND_RATE_REACHED) { + unsigned int ppe_index =3D eth->mac[mac]->ppe_idx; =20 + mtk_ppe_check_skb(eth->ppe[ppe_index], skb, hash); + } skb_record_rx_queue(skb, 0); napi_gro_receive(napi, skb); =20 @@ -3267,37 +3269,27 @@ static int mtk_start_dma(struct mtk_eth *eth) return 0; } =20 -static void mtk_gdm_config(struct mtk_eth *eth, u32 config) +static void mtk_gdm_config(struct mtk_eth *eth, u32 id, u32 config) { - int i; + u32 val; =20 if (MTK_HAS_CAPS(eth->soc->caps, MTK_SOC_MT7628)) return; =20 - for (i =3D 0; i < MTK_MAX_DEVS; i++) { - u32 val; - - if (!eth->netdev[i]) - continue; - - val =3D mtk_r32(eth, MTK_GDMA_FWD_CFG(i)); + val =3D mtk_r32(eth, MTK_GDMA_FWD_CFG(id)); =20 - /* default setup the forward port to send frame to PDMA */ - val &=3D ~0xffff; + /* default setup the forward port to send frame to PDMA */ + val &=3D ~0xffff; =20 - /* Enable RX checksum */ - val |=3D MTK_GDMA_ICS_EN | MTK_GDMA_TCS_EN | MTK_GDMA_UCS_EN; + /* Enable RX checksum */ + val |=3D MTK_GDMA_ICS_EN | MTK_GDMA_TCS_EN | MTK_GDMA_UCS_EN; =20 - val |=3D config; + val |=3D config; =20 - if (netdev_uses_dsa(eth->netdev[i])) - val |=3D MTK_GDMA_SPECIAL_TAG; + if (eth->netdev[id] && netdev_uses_dsa(eth->netdev[id])) + val |=3D MTK_GDMA_SPECIAL_TAG; =20 - mtk_w32(eth, val, MTK_GDMA_FWD_CFG(i)); - } - /* Reset and enable PSE */ - mtk_w32(eth, RST_GL_PSE, MTK_RST_GL); - mtk_w32(eth, 0, MTK_RST_GL); + mtk_w32(eth, val, MTK_GDMA_FWD_CFG(id)); } =20 =20 @@ -3369,6 +3361,7 @@ static int mtk_open(struct net_device *dev) /* we run 2 netdevs on the same dma ring so we only bring it up once */ if (!refcount_read(ð->dma_refcnt)) { const struct mtk_soc_data *soc =3D eth->soc; + const u32 ppe_num =3D mtk_get_ppe_num(eth); u32 gdm_config; int i; =20 @@ -3381,18 +3374,39 @@ static int mtk_open(struct net_device *dev) for (i =3D 0; i < ARRAY_SIZE(eth->ppe); i++) mtk_ppe_start(eth->ppe[i]); =20 - gdm_config =3D soc->offload_version ? soc->reg_map->gdma_to_ppe - : MTK_GDMA_TO_PDMA; - mtk_gdm_config(eth, gdm_config); + for (i =3D 0; i < MTK_MAX_DEVS; i++) { + if (!eth->netdev[i]) + break; + struct mtk_mac *target_mac; + + target_mac =3D netdev_priv(eth->netdev[i]); + if (!soc->offload_version) { + target_mac->ppe_idx =3D 0; + gdm_config =3D MTK_GDMA_TO_PDMA; + } else if (ppe_num >=3D 3 && target_mac->id =3D=3D 2) { + target_mac->ppe_idx =3D 2; + gdm_config =3D MTK_GDMA_TO_PPE2; + } else if (ppe_num >=3D 2 && target_mac->id =3D=3D 1) { + target_mac->ppe_idx =3D 1; + gdm_config =3D MTK_GDMA_TO_PPE1; + } else { + target_mac->ppe_idx =3D 0; + gdm_config =3D soc->reg_map->gdma_to_ppe; + } + mtk_gdm_config(eth, target_mac->id, gdm_config); + } + /* Reset and enable PSE */ + mtk_w32(eth, RST_GL_PSE, MTK_RST_GL); + mtk_w32(eth, 0, MTK_RST_GL); =20 napi_enable(ð->tx_napi); napi_enable(ð->rx_napi); mtk_tx_irq_enable(eth, MTK_TX_DONE_INT); mtk_rx_irq_enable(eth, soc->txrx.rx_irq_done_mask); refcount_set(ð->dma_refcnt, 1); - } - else + } else { refcount_inc(ð->dma_refcnt); + } =20 phylink_start(mac->phylink); netif_tx_start_all_queues(dev); @@ -3469,7 +3483,8 @@ static int mtk_stop(struct net_device *dev) if (!refcount_dec_and_test(ð->dma_refcnt)) return 0; =20 - mtk_gdm_config(eth, MTK_GDMA_DROP_ALL); + for (i =3D 0; i < MTK_MAX_DEVS; i++) + mtk_gdm_config(eth, i, MTK_GDMA_DROP_ALL); =20 mtk_tx_irq_disable(eth, MTK_TX_DONE_INT); mtk_rx_irq_disable(eth, eth->soc->txrx.rx_irq_done_mask); @@ -4945,23 +4960,24 @@ static int mtk_probe(struct platform_device *pdev) } =20 if (eth->soc->offload_version) { - u32 num_ppe =3D mtk_is_netsys_v2_or_greater(eth) ? 2 : 1; + u32 num_ppe =3D mtk_get_ppe_num(eth); =20 num_ppe =3D min_t(u32, ARRAY_SIZE(eth->ppe), num_ppe); for (i =3D 0; i < num_ppe; i++) { - u32 ppe_addr =3D eth->soc->reg_map->ppe_base + i * 0x400; + u32 ppe_addr =3D eth->soc->reg_map->ppe_base; =20 + ppe_addr +=3D (i =3D=3D 2 ? 0xC00 : i * 0x400); eth->ppe[i] =3D mtk_ppe_init(eth, eth->base + ppe_addr, i); =20 if (!eth->ppe[i]) { err =3D -ENOMEM; goto err_deinit_ppe; } - } + err =3D mtk_eth_offload_init(eth, i); =20 - err =3D mtk_eth_offload_init(eth); - if (err) - goto err_deinit_ppe; + if (err) + goto err_deinit_ppe; + } } =20 for (i =3D 0; i < MTK_MAX_DEVS; i++) { diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethe= rnet/mediatek/mtk_eth_soc.h index 9ae3b8a71d0e..7654fa74e7fc 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.h +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.h @@ -124,6 +124,8 @@ #define MTK_GDMA_UCS_EN BIT(20) #define MTK_GDMA_STRP_CRC BIT(16) #define MTK_GDMA_TO_PDMA 0x0 +#define MTK_GDMA_TO_PPE1 0x4444 +#define MTK_GDMA_TO_PPE2 0xcccc #define MTK_GDMA_DROP_ALL 0x7777 =20 /* GDM Egress Control Register */ @@ -1286,7 +1288,7 @@ struct mtk_eth { =20 struct metadata_dst *dsa_meta[MTK_MAX_DSA_PORTS]; =20 - struct mtk_ppe *ppe[2]; + struct mtk_ppe *ppe[3]; struct rhashtable flow_table; =20 struct bpf_prog __rcu *prog; @@ -1311,6 +1313,7 @@ struct mtk_eth { struct mtk_mac { int id; phy_interface_t interface; + unsigned int ppe_idx; int speed; struct device_node *of_node; struct phylink *phylink; @@ -1421,6 +1424,14 @@ static inline u32 mtk_get_ib2_multicast_mask(struct = mtk_eth *eth) return MTK_FOE_IB2_MULTICAST; } =20 +static inline u32 mtk_get_ppe_num(struct mtk_eth *eth) +{ + if (!eth->soc->offload_version) + return 0; + + return eth->soc->version; +} + /* read the hardware status register */ void mtk_stats_update_mac(struct mtk_mac *mac); =20 @@ -1432,7 +1443,7 @@ int mtk_gmac_sgmii_path_setup(struct mtk_eth *eth, in= t mac_id); int mtk_gmac_gephy_path_setup(struct mtk_eth *eth, int mac_id); int mtk_gmac_rgmii_path_setup(struct mtk_eth *eth, int mac_id); =20 -int mtk_eth_offload_init(struct mtk_eth *eth); +int mtk_eth_offload_init(struct mtk_eth *eth, int id); int mtk_eth_setup_tc(struct net_device *dev, enum tc_setup_type type, void *type_data); int mtk_flow_offload_cmd(struct mtk_eth *eth, struct flow_cls_offload *cls, diff --git a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c b/drivers/net/= ethernet/mediatek/mtk_ppe_offload.c index fbb5e9d5af13..220685f6daaa 100644 --- a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c +++ b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c @@ -570,7 +570,7 @@ mtk_eth_setup_tc_block_cb(enum tc_setup_type type, void= *type_data, void *cb_pri if (type !=3D TC_SETUP_CLSFLOWER) return -EOPNOTSUPP; =20 - return mtk_flow_offload_cmd(eth, cls, 0); + return mtk_flow_offload_cmd(eth, cls, mac->ppe_idx); } =20 static int @@ -633,7 +633,9 @@ int mtk_eth_setup_tc(struct net_device *dev, enum tc_se= tup_type type, } } =20 -int mtk_eth_offload_init(struct mtk_eth *eth) +int mtk_eth_offload_init(struct mtk_eth *eth, int id) { + if (!eth->ppe[id] || !eth->ppe[id]->foe_table) + return 0; return rhashtable_init(ð->flow_table, &mtk_flow_ht_params); } --=20 2.43.0