From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A62E5A0EE for ; Wed, 7 Feb 2024 12:04:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307485; cv=none; b=IUk+9tDVIv50rWDDgke4XoJ8jvY5929zUrlXJAuG/eScyIbKMadqRP3sxNa/aJfR/gu0r60KmHI8ucmA9iFBKfS1W5NdS4onxASduwmkGqKgPO1UYIZXoCQkkYXJWGu4Lhh2gB8hv2nk3LUCI+aLRYzAe11/lOQBsemjN2nX6ks= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307485; c=relaxed/simple; bh=cUYKFiaaaNIsippBKnm1eD5vm9eIcx8figxCCL6UVUs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TH5XFZHH5kpyis6l848iIAJAgNd8zmWxz51Hs9ogTRLsqovprdN60aRmsnV2zfe+YMPD/VjrVN1UA7TOPD9IEv9L2KqRN6leEJFSGFIBKxwaOcPo8W71Z++fGcxRQOn7mvC268tw4KPsfkVFTobVoLldYtHqfEN3MvWKy2HANIE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Q4ucYHDK; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q4ucYHDK" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4101eb5a115so1122355e9.1 for ; Wed, 07 Feb 2024 04:04:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307477; x=1707912277; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3PkOeTiV9Vr1e3YEJjpMzE9wK8R9Udngne0PKYOLQyo=; b=Q4ucYHDKM0GYhygK9yMtYX5ZEeD89imUFy13GWshcCNqxeUdM44sUWSoP0b9CJcF7/ FguGAoKGvNmM6RevtJD3AwK4sGc9zsscR8igWw7w+Ss4uCxfePbenHGKE0poStAkxdsy 9f2V5EYdviaUwS9SHruvAyssdiwzmhKzJWNJDatbXvbNZvuLTDEcbwLiBJRrEwn88Ll9 RvPxaQIXEll+ObGSdY8p0W+zBRZB3AHzob5GDb5oqnuBNhR80ZnzspWd7zlnpJjHt2l/ EEL/B1yxCM8U726cG5ea14nc0feXr4R0ERGJvG8uw21jG4+awnCSFlqJlHhsxldBAH+e OWvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307477; x=1707912277; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3PkOeTiV9Vr1e3YEJjpMzE9wK8R9Udngne0PKYOLQyo=; b=LWfZm/J77d8ZGomzec8t2PrPj4WP3QuKTCvPQ9ZfLZNxh42ir70Oa0se+SrE+nj2b0 vvBjMqKnnHhCvcd5GUXGhk7NNq2YGBwP0zAs+FIfjVMnqT+8jl3pAOkGNTeQfxoHVHK6 yYXN2/tg1i6EARet3xOwqLieJChG2PxEs0jb3qsi9VO+57NcSGlUBkB+EKRBa4T62+PI y8JzuQDPhctM3yTMnPrMXj4plGkcso0kRb4J+mPfUbA0exPSaZL6ACH9Uxy77zBGeTaf R9ynMXKoczR6PebVqzSMy9Rou5eHxWvF9/9+hG0NFsGmpqrIaOjY+9s8GBu8LQ7GDLOm uD2g== X-Forwarded-Encrypted: i=1; AJvYcCVJFe/Swm45h0p1tC1VXOXO56he3O13/+Mjv3YXRbfdj3SAZGGatgHBBdVndYvUDOzSXwXdbOKgiD2Pytv3pIamfbmdnq4elBCZQMPW X-Gm-Message-State: AOJu0Yx/iVrVJ0u2A1GC0WmwVo9s3SJrjmL12i/VleXPG14P/m+brKmr ou816EtkcO9LRuZ+6LDA1wn2mlVt5FeoPJL16ypT6cLV/e3wu9adiBnBoRiPMUo= X-Google-Smtp-Source: AGHT+IHizISQgkpwBJ/ZOu+j/DpNp3CwOOqT46l5+PQ6v2brq0tpCpNqXigNsovkUwiz2s1PwCsJrg== X-Received: by 2002:a5d:5051:0:b0:33a:ef65:172f with SMTP id h17-20020a5d5051000000b0033aef65172fmr3038397wrt.65.1707307477460; Wed, 07 Feb 2024 04:04:37 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWB+BM8Mhb8VFL2sq2sCoTDS49kqgPhevZMeajZjUn2tespElYOon/prHpdepPcDpw+LIoKsrMsDFOFqDCHkVQTsTXhzEoiUyQ2WfxV2qfJ/JLuHHNcAHOq28Nek8tLRyO7m1wpXRmV5aT9pPlCTw5/ZukkMFFG4geVBDz9+6I3C7KmZ+IJLE5mGpGesi1z197Z28tgdtovCzDxggqgJADb6iAfU3/xSI3HmMOqX2Dy+rufzbfkr4nuwpghpo10xMsNYwgT+x4skWwyPHM+T7gaC7f1+F9LzYUBBTKwRGNpxcaj6cnnZdey7tgd9T5rsumdp7Rr68J75Uy0tA0xkrOISXohHWkJb9Ky0fAV+08ClLRZEA+ORzczJej53bA8bfLq5fYYXFzysdkpoEyaYrBFa4zJxVPLiW/lWZVSNp521pGoPFLzYRp6veWfbtzoWAfnUlfFHIY2I6fk6Ix6flRg2wYMuu0ivMPlAf/aJ5cDQY+VNjov/F7BBwTa6g== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:37 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 01/17] spi: s3c64xx: sort headers alphabetically Date: Wed, 7 Feb 2024 12:04:15 +0000 Message-ID: <20240207120431.2766269-2-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Sorting headers alphabetically helps locating duplicates, and makes it easier to figure out where to insert new headers. Reviewed-by: Andi Shyti Reviewed-by: Peter Griffin Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 7ab3f3c2e9aa..1455cbd2fa8d 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -3,19 +3,18 @@ // Copyright (c) 2009 Samsung Electronics Co., Ltd. // Jaswinder Singh =20 -#include -#include -#include -#include #include +#include #include #include +#include +#include +#include +#include +#include #include #include #include -#include - -#include =20 #define MAX_SPI_PORTS 16 #define S3C64XX_SPI_QUIRK_CS_AUTO (1 << 1) --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61D515A0F0 for ; Wed, 7 Feb 2024 12:04:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307483; cv=none; b=sIcdgrPy8K7X2ONc5Cir9y9MnVd2FijgVJsEbVnhKFoHQ4mR46FScNwHbaFHF8Z+mBls9aHVta0GoozVJcOzcS3sVEwSqrc1e7uBw7mcZbuN6XNX0B9FYojGcobN5pNsA9weyu9lJoPZuJkuVewMwzfZ1Il0Spvr+OWFSxJn8u4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307483; c=relaxed/simple; bh=JzXPRHVlj4kMqFgLLajSwxxBue7T3bsxJTGhEF3WWDY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hI5VOR1r3NXfHkXCswiUNLJyOQnysK0ZdMzgJSGjcEviIsPq1yl8oz9+8xOYNnCCh2G2zN9jbvxBUrk1ptaGtt+ckylmq17vvNB8/VMOJ77+nYl4mWfTpuf5LosB8WrXQsx9whBRBr4KmV/0PSPJwmL19C3s+F/YhxomOH9g3cE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=my4M3EB0; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="my4M3EB0" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-33b4e06c239so421030f8f.0 for ; Wed, 07 Feb 2024 04:04:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307478; x=1707912278; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=souH4fszIHhl+7lfvTkAEtznZt5fFUz7qZaAcpHpDRU=; b=my4M3EB0DSPRbD5A6Qg5j6EX56/wypw6EV4gTa2HAVAg0g5ZMswgU03WY3M0y802O0 AfFk7PzqIMB7+WBiSU1ykixSzEXHj5/SNszWBR73kdxqhe1634nKKmewNBTj1Lr8sniQ rZuq8WMAGlYoYpk+A1GcX4bl1Q+XOXovqHcn/d/1qnNy772DTtRg6/uxLa0m8pBjCZVa +jF6AOkIpZdbmAbxUB8XltIcGYXnQVPrD/PAICZGG9uQWRM+StOHKcXDmVSRW4Mxn7CL awZH75b/uFy8WJC/E6xrmWHpklmWbVGbaWUXNE0EyzVeNjqTMod6kVCOMWKT4+oubL8e hZFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307478; x=1707912278; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=souH4fszIHhl+7lfvTkAEtznZt5fFUz7qZaAcpHpDRU=; b=ZWrF1WrGQGaQVEZeVLkOi6hC8dWWIUzGo6pf2HFCgUF7+8LdcLvgJHwmGTguVZ4+PV 1q3Al66VReyEC67g2IkRUfc5KQlEyDl/KxCQqX4EIvNTLaLyhazLghC3VMcF1lSk5sn7 n3416SRyxsgHQOgnQfgSmjQGEboYpt4B2L8mMVuWjqn8YWqL3wfyPPthMCbNANjt0a5W B8TNgiUJE8wx4aLyZaz5lI/6/I9JcWahEgUyduI5vsBZSNonfOfvevITMRtmd18l6lT6 Fe6kkWjS9RBzRI0tk2pLy71oSMZvVVzcJceByouRlTlONCFxHrkal7gOkntIDnTXMwOE ZPCQ== X-Gm-Message-State: AOJu0YzQlJXHW14wUKfjNg8dfqNbTFOG8rfWZpgIrMLuIPZ+fXG8Z9qC wndpxi7EAN9RXLtN1hqB1fTdYiWyyTYB4pmpxJeE8HvNGhmXPKEBZVs6Vz8XN/M= X-Google-Smtp-Source: AGHT+IGFAtOw1qhjZckIfIOZZA6LDfXKXdro8MKlf13WGl1nFl3I1Ds/CFMhfACjQyDW7Ng2Q7vQpw== X-Received: by 2002:adf:e643:0:b0:33b:1c1e:3e5f with SMTP id b3-20020adfe643000000b0033b1c1e3e5fmr3850519wrn.16.1707307478768; Wed, 07 Feb 2024 04:04:38 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVEFqJKyWijUEzhbJRb74h2KdtPJux/+fuKK07LYNtY+mMmKVgLvpxl1mOnsS+0GP/LQ6RGT/rP/2ouqOYd8BDJu+w22E1Iit2rIBbvfJQ/RhXAgbVXTjlPGykU72wy5jfmLjQ1sohfh8T+OIM9iN5l6MugccbbO3fQdIi7WFk0E0wNy7U9clh3jFVG+iXZUqPeOjQxa/wKhx0pcf7INIk83Nq69iaw3Cr9FVjoHooq8vAYNs+uv0vPZZMPWOC/WGoDqL7dmagp4DgDvgaT0aP5hSUJ4tC377Tsj6vNpXwXoXCb1o+zA8wxYpZUgLV5R0fpqEQmU130/XHBiBhJd/kLsCjNRQ9InQJPvaidJKoyjMuh8ALsi2l7Q2008zppRfI8M8UQZlL4uKr37bM2e8uAEPL6zGy54VcOwutS0LlvrHGGS8XJ2A1pK9QwZmRtjFZdQZ+lorY/jFqFYQboJrsWRowKETmuzx14/k3mnPrHYyvz7QYTA3XvwL1AQQ== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:37 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 02/17] spi: s3c64xx: explicitly include Date: Wed, 7 Feb 2024 12:04:16 +0000 Message-ID: <20240207120431.2766269-3-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver uses readl() but does not include . It is good practice to directly include all headers used, it avoids implicit dependencies and spurious breakage if someone rearranges headers and causes the implicit include to vanish. Include the missing header. Reviewed-by: Peter Griffin Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 1455cbd2fa8d..9882eb0f4bea 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6F4059B7F for ; Wed, 7 Feb 2024 12:04:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307490; cv=none; b=D0KVyn6gRjx4CjoJclm6Ha0CvqAZEFOzQa+WCDtnU5e8TRySTXZiorObhTc2Y35L1Jnw3zdaf9AnZI+sitnkJWL7Te5YL4TGIatpKqdsun4Pf4prUru+pxafGOMDHruAmBFGOmwvupcjVTB4Myc57GPDeuhWDOA9+nAsAovuB7Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307490; c=relaxed/simple; bh=OAR+jflIcBL2EHFTipuv3y92m5gNFedEiIr1Hts137I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=un5rgzVjL7F34lQo+XBPKAq8yhWtDrrN86Gl+ESxrCXKlEupTyNPZSqvs2xrOtolppWiZBk4C45Z2Cr90rT3DSjZta8Caluf+9vtAWDIppBis7KlMRz7DQ9PCcq8cjawXxA3I29Vd2/XnnjUc5PKWukggGUvamKp26+JJpXnE3w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Thho7Im7; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Thho7Im7" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-33b4e06c239so421042f8f.0 for ; Wed, 07 Feb 2024 04:04:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307480; x=1707912280; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LKeYZPmRarVNrSgEJ2RA2bfdFMbY5j4/f0z54RK04Ro=; b=Thho7Im7CV0D5HeaNOtLVl6Msqh1VKkHacS+mDqfYO/Or/kCGh9TYlR3DAQl/w7QUZ 3pD+0M710NDNtmQ6bwvgVb8Zjw8ueG61lR7zGmKM2Cxd+NkxBPGxsYY+1ASbPqIK/fZL TE9wpkd0FxGf1E2RShTJuCfCPfCaq1t1GLAJyzQUqOV4M9yX+ydQPbOmUr0SZcOxFJKA hYAdNpS7sd2SU9auiuMbXpIUyP9IA3cx1k/RfEPRGtpoliN3Mj6TjraHZxmWiJeQx7Gd 8U8vRVXHQR/aCy266xtWMuY5bF5vribM3x8zIKxvMit4pyRoGTBTeD+wjXNhi/MVdi3p kcVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307480; x=1707912280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LKeYZPmRarVNrSgEJ2RA2bfdFMbY5j4/f0z54RK04Ro=; b=xSc5tez+bu0Iaq37VnhpoGv13kYpdnfGfLmPTX9Hm+aMuRPReHQdogFhTjzGvH8RTf N4TANhsT5hffu8U6zhR44f7dUwpDgZEASshtIPiRqHQ6O+98WlKkBVZfij0bzRRXtPF/ BzHlGPdsPWspTAmc/yzSo0C5mfnuFjyMUIrJoIxjImm8SwqeSUD1LMlh/z2UQpyMvjnZ nGxTvhhDrhF3NN/sj9oOlLXWvLVaes3zGug9ETiTeOYOWa4N7Aqk301DFtri3r0VeyV/ tcWPQAnrICtSzb8mSi5oLs71XWIbXbB37TZpLVMNRuY/PRrtPfxzKnyYMaDY8xwsE7oq VD9w== X-Gm-Message-State: AOJu0YzeJ9q90aWthJ1lO5RysVvNR3pYun7WnWFTSRUgjSLg3YG29igQ DwiLO1kPXSkQFH3RVk8ZW1K/UJWronLti3Frob9AwJHt1LU4PI1g4NX/9wgGtHA= X-Google-Smtp-Source: AGHT+IG16uBtP/M/WcNTRS4NKYzE2Pqd80TW+6h6PqJHRZbcdctP+Xdid+Q2vkXyjtwIFRC0HIeXWw== X-Received: by 2002:a5d:4e85:0:b0:33b:21f9:cd9a with SMTP id e5-20020a5d4e85000000b0033b21f9cd9amr4166717wru.19.1707307479786; Wed, 07 Feb 2024 04:04:39 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWJZLqXZGprlWHssMRP5fdnmrfhy0M3YUKVltJCl9cXKPIU9OH+nkcpmuG08whVcjYfQ44PPKJAvTP8e+z3Yfas0wMg/pZWw2jt9F0DI1xNx4m1TV6VZp9pUzsU33UB1xX90TYpm3d5vaqja8oBWLprftGrR346L09q1s+DXi7RZ0UkD/cYVQTdgrMSZRYap048Tr8yqGKW2xY9rg/tWivX5UY4wS39DFTBeYCyl2anxhZ2SIEd8GOAw5lmj47RbUrPWaNBO00RZiGhoUJwI5pAeWXvWufKfTLeRAgqG7ces6Xna0W3ASwxZ34KILqu8swr8N3OE9AqcVOnjM/9JpJf6YI2oReXixhyeOBUMPnqY+LhglZrz6RsoKKCUUhiJkCLW1Q0lnRDjcQo+QMR0u1F+UvVe7PejgtSgaVrxhctqUqPH8kbwQvoXOZ0sqex/PLXYcY0lM6QhMBVA+1Yt5Xj9J211Olk05G+O5K+JDfR1msfhlCZD7q/+W4YXg== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:38 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 03/17] spi: s3c64xx: explicitly include Date: Wed, 7 Feb 2024 12:04:17 +0000 Message-ID: <20240207120431.2766269-4-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver uses GENMASK() but does not include . It is good practice to directly include all headers used, it avoids implicit dependencies and spurious breakage if someone rearranges headers and causes the implicit include to vanish. Include the missing header. Reviewed-by: Peter Griffin Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 9882eb0f4bea..b1564a447a6e 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -3,6 +3,7 @@ // Copyright (c) 2009 Samsung Electronics Co., Ltd. // Jaswinder Singh =20 +#include #include #include #include --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73FA65A0EA for ; Wed, 7 Feb 2024 12:04:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307494; cv=none; b=uT0xqHD+A7OUCVWf3FbY1T4+JNMyDPZZSbSEoWODogHZtd4nOGJFOb3KjnofIDSw4wTfo2w/UeaiiOh3WYPS2M4jc5p0FvJsz5Wzijs4BedTJDpHZqV762s6JFVQRYJaGcfpqzCnP3dKeHL/ZjIMzn3q42rHrufo6+VXAv+lYuk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307494; c=relaxed/simple; bh=r4K8vV5hlsfDw5ywNfN10FQ/vhQV2berw8NklQKyxSk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VkCVymSr8Ji5dRz6QK+cbgfQLuFvJ88Ea0KtjLmRdYEXaf54q9rGMhwq+00uFtWJPrXOZLdKyerHpOmPjieLU7hNyjRpQcRJ68wHRarGZAMZar3ugBpFBf7hiQ2EWZjH18y322CGMbh4UdiSE/ljExa0t703FshqvE/0L6GEXaw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fCJ6QAjv; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fCJ6QAjv" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-40fdc63f4feso4725025e9.3 for ; Wed, 07 Feb 2024 04:04:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307480; x=1707912280; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yI0XGnXFUeGyPrdGimOqJnqeOPorDQn4uPXnM/OBJYI=; b=fCJ6QAjv5ypSIgAoZ/C7isGZMR2OeSSqfTwUTarUWjwUqo0vJ7jQodYmHLAOz1OtsG 9QUFW2WMKAYGwP3P0duQ8j3FqA0GYBUCKIccEumPlZ+II2zJTHhK/3pR1r7AQmn1BKAE YE+nZ8YtLJVDX+YVHcqda4CmgsObG0yDj36bH2en+uc6GvmOqYg63xQNX1jGFU/fO/Lv ea+DT/aV8mzE5CYyEMeVabpGHZ7wtZBbui7DcPkkR/nsdXNUl3jqekRHNjqWGtzvulWX 51eNx+joG+RrZy7jnn6J+pP8ew6/57KOe6kxRMyM41gKc6uLq/0lI4ob+6VQtPrGrn5n FoEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307480; x=1707912280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yI0XGnXFUeGyPrdGimOqJnqeOPorDQn4uPXnM/OBJYI=; b=ZC+i20arUTjxgBDvRV7ONrMgQ+JcrlYeHz/FjUNbgbIlCH6bo1kLVN9O6TbTSB1q/k nrvClkdPJlQVHp9x7mWdFPJCHD4ZosERgbH1nLRVI7biPlOuSeAZxYkaVOZuIu9EQasb PQMjDStPpUI6GGkD9Xbo9ZbDKDhhBk8kDactnRKU6AaFyASgkrbUiI9zR+yP6/YNhNfP peGyhZ4djmuoxuHsjMpdsSAfNQpIwLcsd7Wnf6khk69ZLwpWrsWmo9K0NiEMjZlIiiZq +gP940XH6fxJJN6/Dw0WNSy36KBySEflj2T/K7MIZjpDWkdjZ3LVIlMRRmmR6gjljafT uy3w== X-Gm-Message-State: AOJu0YwCtv3uCPrG4VhA5amblCyn6tK8x4iMZPFEvzGMm1rTeiVz6CGZ aOYMC6e8QUCud5ByxJKEoGvSzDDP7XPkT6x5PGU5mIuCcrQtZQVj/BgjcYP4Y7Y= X-Google-Smtp-Source: AGHT+IEzOauR1QCen0vBXFzjms6qTiywBdD82cqpw42ffLN+8RpFlsZOmAUT0myNuGQ3y729cTXgng== X-Received: by 2002:a05:600c:510b:b0:40e:b9fb:103 with SMTP id o11-20020a05600c510b00b0040eb9fb0103mr3758517wms.23.1707307480664; Wed, 07 Feb 2024 04:04:40 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCX2clzqkIRwq5SydoLx7yLk3NTnY9gMjjVS6k9FBDzOZEbGVRvMfarAx1a8KKhon8gTb10h2OH6QQPEQM7g4sSKFuXNcwt+2hOHEDl5CU/iR7VTDaOHDuWgGID7WmcCIj8Hd+9zYVdyzUIbWJ7pJo3IcyRM5CK9zQbs/SGukOsf+g5sBVYWK2Uu2CY9QTeg4Qurq/PdPhEt6zWJgCJNH193tyQRgBJCYysbHG6yVCtwoebNtpgaGSXUrVO9OwHjv57oWQOgRrhBRKVWTYu7M+6a/KxxErrp38jI5ebkS1qba/+aIrIYsVXVAagO49Mat8NdJkIDUJu4FmioLV7UkaUZbyPxhrbJ+0Q9dxoEb1A1RVWcuGOdjFj5v2zdkeD5mA7yGQwtRIjJk+FLwTVWHgHzEoeA+PHNKf7YFNVG4HZDkW2s/Qfj+k2fMAQrJzTN2uTeTh3OjPqfdFkIjagOh7KHPyw+aD7jrh6f6YW2bKM7/CaPl7lxV2uoGApXdA== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:40 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 04/17] spi: s3c64xx: explicitly include Date: Wed, 7 Feb 2024 12:04:18 +0000 Message-ID: <20240207120431.2766269-5-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver uses u32 and relies on an implicit inclusion of . It is good practice to directly include all headers used, it avoids implicit dependencies and spurious breakage if someone rearranges headers and causes the implicit include to vanish. Include the missing header. Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index b1564a447a6e..0a30d034e288 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -17,6 +17,7 @@ #include #include #include +#include =20 #define MAX_SPI_PORTS 16 #define S3C64XX_SPI_QUIRK_CS_AUTO (1 << 1) --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E523D5A11C for ; Wed, 7 Feb 2024 12:04:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307490; cv=none; b=Zn2MYlYm442F6e+BKNpPar6EjAiZfKU2c7i8A8cEbjgs0Au/L2ZwRZSldAGy9MR8N1EhAHFbVAnywD/ZcIjEcIZ4Mjh4KKtco9IBUjNV30GFhqpinKApm5GEbW9+MV/Ne/St8S0y2kNjJf7S8pxjSTlQn1aHZPFsHboeGTPpHrc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307490; c=relaxed/simple; bh=TBx1M+Fba6cWfMz81SybTjKqSJmQaQpPFiDkoNL5c9Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FUrtPK3zoVUe1MOLnx6lA4l1nX0x2MZ/55OKs2++HEdlMovfw+9bXa+WwawmeuJP2JjlVHxfRQzCH4HdMkpM0nHSgF75Z9cD61qmmeruATCFxmfS2S2xaoLsE544hSF1qjD854o58hp8xHhBCw6DvU/yjtMggwtBIJloZIZSJsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wXlCH8nK; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wXlCH8nK" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-511538be947so596846e87.3 for ; Wed, 07 Feb 2024 04:04:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307482; x=1707912282; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9Bzl1XVd4VG7OC9yiL2j94dw6vCN8qDUED8GxJICOsA=; b=wXlCH8nK5Yl5vB4XKNY/dWd3KeZVR6MMkS8/lD0GxEEtHrDVawK+aKAq0/fAdOWZn+ 6q/yqJNva0DsXG4vtdGnJ5meu25e6LZAbT/aFYfSyQm+geLVmCEWvQ+mFTWXkjS72niv OB+5xGdImj5QvkPvFGbBQU2qX08q6SHLiKbtNI+lQDlKzb5PPbPpG9ZuXU+QiyafuIu2 z2w7tdsfTFWl2cJhRKA5i6+kiIUr1xvCtEGCGCF1c+rh1BUJUKKoyrCupaFYB3cPZ6jF G9+5Kc3Y06zMv8Vn9D3YBvawWJ3e89T8fJU4Wb7RuXCHfLTFbPSclihB67cu1yQXo3s8 +l/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307482; x=1707912282; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9Bzl1XVd4VG7OC9yiL2j94dw6vCN8qDUED8GxJICOsA=; b=FXnFzc+MAxWLZ18vCKL+FxKkkvBxWj1Q9v7Cr7nNHI188bwNCt9ki1Mbw5cGDyPvpl nA/CoODiILOcy83jndWLt9nOFaLDSWghlSqvOu8IGtIp33uUrPGR2UNV5MfUf0cEsAwY 59xwOWBHZiXd9KlutMQsPExh9wl/DosAIrdd7/RuRlk41t1mggOyA2Y565PvYHIXbpFg 2Lw5VrIDmW4h26bR/+q7YTRWnrrSmxcog487bQ59+hKz+gEwnkdpcB5i2Hg9+F2gxbZz BoGsXL5pcf1NGq6mHqE/YJTN3TsohyRXZgBL4ynTfM9IOaKIy6ndLq+7LiO0bouG9JkU GD0g== X-Forwarded-Encrypted: i=1; AJvYcCU8MudkeTr3zx/HfUgMSz6+FQkXtvRvfh7cCSt56W1FGTLNfqYHTZvnIsryB4zMMHqnHE4HJRDu5aCH1+xb3ZoHqDm56Kg9J390YkZV X-Gm-Message-State: AOJu0Yx14UQo5r+/TV3BFaXZnPdeHqxXuvtyfa10tNLCBJMiFlv3PXQL E4LnYaalOfdeZ6YRE+nPaGM6QnfAWXIz8Zzp2qTKTkrSNSbEKA0mDwpx+bvqELc= X-Google-Smtp-Source: AGHT+IGcck/xmUicyK/uSuRdySCd6lMKVJAEjrg4NVjjnDTt9057DOq1RhPNTzrfhuYWeIgmMq9WnA== X-Received: by 2002:a05:6512:31c7:b0:511:4e64:fe09 with SMTP id j7-20020a05651231c700b005114e64fe09mr4393588lfe.43.1707307481710; Wed, 07 Feb 2024 04:04:41 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUQv6Y3rp8ha8/1pYWIrhm+SSEwXtyTCHxObJ+7Ec7urGBGiCErba4U9qGVl0fQMRgdootm7T/BpCm8MPhq9X3a1QZ2sw4/eiosfzFJsXtPDeLqGwIPX2yskvLe2RtPMU7yi/h+PWaU7yVpqnIIyBwGnOgrEYlXe9De1jQ/vWs6raG/hjYtUeofYZ4BQ2pY9Ks3MwWtmU976uew+KP7gBsqzCk1DuXFUlo60/csbqywTZcB7vBeJ2s8YXn0g8nIfphWKpuqkkbiI4UlK7D/A2TJX1KgsnaFpnGue9dXTTrLTRGX0Rt5LeQ5p1MMX7mbttA81TfmAsq8neWBmTI09soUUih5hy/fZWx8xN3N6y2vbCXQZ9ZGCbi8sofdpmry0WflT+B6QLaw250aN0bLXZTGjzdu6uYboFTjuTH5GJFrZ0ZsBA/ScVlfzAJnNpF4r/OF6RoRgbpbchVl/u4syxaWTf2Z3MWkjAadY3Z+xUVwoFpcRsjgm+z9t5T+VQ== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:40 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 05/17] spi: s3c64xx: avoid possible negative array index Date: Wed, 7 Feb 2024 12:04:19 +0000 Message-ID: <20240207120431.2766269-6-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The platform id is used as an index into the fifo_lvl_mask array. Platforms can come with a negative device ID, PLATFORM_DEVID_NONE (-1), thus we risked a negative array index. Catch such cases and fail to probe. Reviewed-by: Sam Protsenko Reviewed-by: Peter Griffin Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 0a30d034e288..dfe78ddfa233 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1228,6 +1228,9 @@ static int s3c64xx_spi_probe(struct platform_device *= pdev) "Failed to get alias id\n"); sdd->port_id =3D ret; } else { + if (pdev->id < 0) + return dev_err_probe(&pdev->dev, -EINVAL, + "Negative platform ID is not allowed\n"); sdd->port_id =3D pdev->id; } =20 --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 141CF59B71 for ; Wed, 7 Feb 2024 12:04:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307497; cv=none; b=mlqerE1kgbY+NEFnhZn8FVKs6n5FvDftaDMD9tycpvlbvrllIGo13nSFPQ/CbNJ5LohynWPsmRCdOarcDCQd2Vf6VHb8Eg2ezC/i+B/ZF2zi3AeJa8KvTKpb3IOTLaTPUFTNFvmQuC6d6en1XAvaHyFQK4AbXxhY3gePCAtUv28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307497; c=relaxed/simple; bh=PPm4DlAfp85sniPjf5hXivYfBycvC/yIAOilieHqH6c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XE+1iOJaDX7udRbdx3j+W+f/GZGBmc8py7TV/zsbKt/1VqF4W4Kp+RZMX5Y55Ju+TuLHgzE/W9Pweso2wlbB4KbdlmerOAjOVkhAhcY3VQSbe0bx3I/XTgv1cONXR1pJx2VZwM25sy5TBrivmqSyGwG8CLtWZHBvnXLghEfrVcA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EmHrfdAV; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EmHrfdAV" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3394bec856fso968124f8f.0 for ; Wed, 07 Feb 2024 04:04:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307483; x=1707912283; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1q8cSxh6TrpypO1wLgThCm1+mYzOLff+IUVZOlpZ3vk=; b=EmHrfdAVId5MunvoG7KGkeWT9o488d06Zf9wHg54KyTKQC4ZZoOs4Voz17+RQjruu+ NMboEPNyfCfDMNvuaaE/SAL0U/uOW2uyREAtxJpp27Z0hrhKiedNA01aY7a3FSOHe3xk wp7Y9w0IxH/dbaGSN8vJ8xIafqgguabZwercgIWYLvS7ns4U0OFTEcxXJnGNRKRqBA9s UV90Kpr4ODZ1sl2DoH56eid9OKLGu4d5j0OG9idDTras0cehOpzKVjgQYq5Dcbgj/YW2 7UwubKfM2DuxUBLo2DisqztReA6FfIXN4+Sku1q5k5nmS3IpqRfQooA2JCNvFDH4afqQ 3evg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307483; x=1707912283; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1q8cSxh6TrpypO1wLgThCm1+mYzOLff+IUVZOlpZ3vk=; b=sTNfV211OmO1KVbkH4ctxY5Sbhmsi1uH4ueymHftk4Bzb6yhOrIfQ6YJj0dJboCFOu clFmeHkVUAp2KImpslp6Nsu6vSmUzxYwd59WURUjVrXy+UD70Ryd6Iy/vJ3dYyMnl2o0 9E9LulkssYlcnlDtnr77QiasnQhdPk/babKxzVMr0v8RdB8ljAFAhNhNUoebI+y7Mre/ Nrdh0dDnXiaB9zcPnhq2gwD0kPo5xXX0iGd8vCA1fVnUiLKQtf1ItHFFm9kAoko7kYvO AkLtZLj9Gb536FoN9WTGrh4eQ7pD+JNh+ofPO7Oz/V7ZujLAji3zkJUAg2R48nSXccR1 FdAg== X-Gm-Message-State: AOJu0YxES3X66Gtt77Q37h7vyZUGdN92pCf80D1vBjKeYzhgbdAZKnMZ ydPMVFaAyJdpVegwJUmxYtgVogbuN42KNkM6E5gTNiAXbvNEnrAqMT4/WqUrPVA= X-Google-Smtp-Source: AGHT+IFVobAsTSE3Uc/CG+Ky2imtFMA2qH3wf0hCDIYvSbPcVABLR9T6lhsZJei1D7b2E4AFsxdrCg== X-Received: by 2002:a5d:668d:0:b0:33a:e9d5:a760 with SMTP id l13-20020a5d668d000000b0033ae9d5a760mr2947738wru.14.1707307482943; Wed, 07 Feb 2024 04:04:42 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUjUIH2HOb3+v7DmYuHoRwUvrh09L89YHciI+ZCWSLcJmGofKMWoB6zUYAffjtzi9pOI0QqS9UZIF9xFutPY+taQ2lbl4joIY6ZHMQCdAlF0BDoCoVAM706ao++eRucDEUupgSNrUMI6UkAKvOVJplYfzDgXoWBgzfpm+DQ8/LdBAbHPbLXCJKFZ3Vxjdqij7KcjbDqM1MR7I/JqElof1ZQ7vGf4U7aKJpqrfCchA6HQZhyO1oj+u2cEOXMPu6Xi8WHikMTL7KTPCgaFsW/mc99t5wMdAl1s14PVGotT6iziI24ONeTqX9cXgzr1YK1cDn/2GJWYfYf68OykP9Q/jc4E0bP8KeA6CFLrNZ30o2uVMNgwL7WkgBDxW0IHYzNmUIs9azXACpoVVqlQ1Eh6v6yoaxDjmTxM6cLD0WgjowwCqWVV7pI1bKvn36GrEeQ80BJGaLvdOiIA4m5GmXt6qGrvE+ONXgNyaNhTqzMepfr0i9nLAOpEjnwGpcX/g== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:42 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 06/17] spi: s3c64xx: fix typo, s/configuartion/configuration Date: Wed, 7 Feb 2024 12:04:20 +0000 Message-ID: <20240207120431.2766269-7-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix typo, s/configuartion/configuration. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index dfe78ddfa233..93d0e55e1249 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -182,7 +182,7 @@ struct s3c64xx_spi_port_config { * @cur_speed: Current clock speed * @rx_dma: Local receive DMA data (e.g. chan and direction) * @tx_dma: Local transmit DMA data (e.g. chan and direction) - * @port_conf: Local SPI port configuartion data + * @port_conf: Local SPI port configuration data * @port_id: Port identification number */ struct s3c64xx_spi_driver_data { --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F0E25A4CC for ; Wed, 7 Feb 2024 12:04:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307492; cv=none; b=os77LQ4jx7n4/inP7GX3C0gquetBa8o3Nn6Nppqpqk0XrGQRALGSkBP6VkGEU0cPLYFX7nJp9wZFU/NQa1p2Ql6lbhiR8Sqn/DiDi1z0CcixeOdXLXyeHy/EEfsSHYET1MPWQPvrsFjFtV4MO9fV1U0pgFXXmisiDJDLuwXxAkM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307492; c=relaxed/simple; bh=MCBLaiXFLZ7M+NK59Ukh3NrRPGTmDqv8CpxlLWx/SgI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gBmKx5GtOCQ1xwvtICMjtXv6iYpm2S57iIzj6ugyVAROK+qPYNJe/fsiag1YtiWutRVqWlxr1B0KtesxhbERjmQZokyv4oIvJuUeTZ8BpEqd4JgJYsp9/ORVXpAKW5AlH3IapJMvXbW6xkz8CgIic2kiZh/qpmYLFRqIyNVtges= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=E5vAc+8I; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E5vAc+8I" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-40fe2ed8746so4469035e9.3 for ; Wed, 07 Feb 2024 04:04:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307484; x=1707912284; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zo986RUHJCgw8tyGE74Q2IatMWC+g/lf4ayZlSvDSkw=; b=E5vAc+8I7HYhWe66VPk274J9seOEBt0grY4LrDI1Fggiqf+t8DhgVIz2H61skjsC9y zzYrvWUYqllJfCakLVyCfe7c8OYcB7FoaZSst5Kwd4y0LNr5UX12giTvuhlRJXMsv83X XCag3IEvZB1+VJYVq8VckmmQ5cQ/SASdj3hgNn3MUqV4UspXSelUfuVVRDL1B7lIf2Wf hmbg1BPqX1bG5trOQ9e7zpthOddLQrltLrI3aQe5VL9EnZF7yFxGwK9AWuJjeMl+Lk3C 5JTGMqZTMkcHByTDvnE7S0ze1Xj/IlCaa8Tu0c+7B83EdeA/67O6hB4xSaN2Lo6pknZh rHDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307484; x=1707912284; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zo986RUHJCgw8tyGE74Q2IatMWC+g/lf4ayZlSvDSkw=; b=hHTU0ymbqu/vGDiiibmdpn8s38AkmFE/Z7Q98UAFhl+FL7GWWDwwAcCPsSTPF8DLU9 gyRK0c4mX7uk5NT1mp+H1NPF0eoXAH6bZiR+bTCnGnIfxDYpwjar9iBD37erORtmv39Z S7HGaLI54FJfQghBvkrrD6Ez8c2HyZ0GE2lKW8nsLIOx4KM3u2z2faIVlUW3xMy2CoJr t1EhVV5X0zYRQjPkbHXASDUYS6gvOlChc9wFwd8NVG3nKRtAElaq8GOHdU9TMOtE56ns /ff4HXJmq8E8lRu+ezbjQmB6AF+AGsX1dLZCxhiCxn+Jn5stBLB8zTB4H0awZ67IF7BB 0XVA== X-Gm-Message-State: AOJu0Yxf7nCOA6hmiY8OXsw6nqhIuQIUFuDqvusnuzeS36VVWyKj1Qq+ wPMKi9LLT8TCf7h6JnAjY0sg7UnrPevnkm7SsL+5uPztwVpHRBxUfXcBqbx/Uwk= X-Google-Smtp-Source: AGHT+IGWSum8JjV4ymxYiYXXEAM7kyACzbsi6K6VdwjjNADXGPscXXjdSHj+++738Z8/fcUVjpYPgA== X-Received: by 2002:adf:ea85:0:b0:33b:525a:8e11 with SMTP id s5-20020adfea85000000b0033b525a8e11mr130793wrm.5.1707307483927; Wed, 07 Feb 2024 04:04:43 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV9QS2v6p0kI4fnIqq9lhLW9G9N37bMjCl+FN9zcjTiKvKr9xC1kZOr24JeZVOt+8dloUI7MyxZa0M1CKuZLHj/o3/ZzYP1yEoRlbwXUZ0tV8Kzaf+mWVhbIaOV2V4MoLHNSM4bNa9vC4v4nhEF4RfpYrFpPJFMljwPi/uFIrQ54Gx1GJIiovTyOMp2F83PA6myulA7+gxulYdvscrd40y/bZbno+UMBIWFoMECoRJMuP37h1Z5XwDuejjiBNqsvCGPQX29xEwOIsxSBYuEOC8MAFGSSZFZV089G2oWelE3q6c6gxSFLIi2pxitiDnU+fCTxbBYFPtiLESIaaStNnm8WjZ0HlcZsS+Wc97kglcwv04vSR5X3gV8cKGaExSa9lI9zM6N7naWum9ufYVqNGcQPjp+o2s7uENXPgLs9aPUiVAXqV8daCAadneyMCI4uikqX0Tz5b48evSDNnuuQdLJOwo/PqBknRjvF3bR/tO2Y8HiN0UohR7fkVEI7A== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:43 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 07/17] spi: s3c64xx: remove unneeded (void *) casts in of_match_table Date: Wed, 7 Feb 2024 12:04:21 +0000 Message-ID: <20240207120431.2766269-8-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" of_device_id::data is an opaque pointer. No explicit cast is needed. Remove unneeded (void *) casts in of_match_table. Reviewed-by: Andi Shyti Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 93d0e55e1249..e3e7d625f3fe 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1568,31 +1568,31 @@ static const struct of_device_id s3c64xx_spi_dt_mat= ch[] =3D { .data =3D &gs101_spi_port_config, }, { .compatible =3D "samsung,s3c2443-spi", - .data =3D (void *)&s3c2443_spi_port_config, + .data =3D &s3c2443_spi_port_config, }, { .compatible =3D "samsung,s3c6410-spi", - .data =3D (void *)&s3c6410_spi_port_config, + .data =3D &s3c6410_spi_port_config, }, { .compatible =3D "samsung,s5pv210-spi", - .data =3D (void *)&s5pv210_spi_port_config, + .data =3D &s5pv210_spi_port_config, }, { .compatible =3D "samsung,exynos4210-spi", - .data =3D (void *)&exynos4_spi_port_config, + .data =3D &exynos4_spi_port_config, }, { .compatible =3D "samsung,exynos7-spi", - .data =3D (void *)&exynos7_spi_port_config, + .data =3D &exynos7_spi_port_config, }, { .compatible =3D "samsung,exynos5433-spi", - .data =3D (void *)&exynos5433_spi_port_config, + .data =3D &exynos5433_spi_port_config, }, { .compatible =3D "samsung,exynos850-spi", - .data =3D (void *)&exynos850_spi_port_config, + .data =3D &exynos850_spi_port_config, }, { .compatible =3D "samsung,exynosautov9-spi", - .data =3D (void *)&exynosautov9_spi_port_config, + .data =3D &exynosautov9_spi_port_config, }, { .compatible =3D "tesla,fsd-spi", - .data =3D (void *)&fsd_spi_port_config, + .data =3D &fsd_spi_port_config, }, { }, }; --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 903193C6BF for ; Wed, 7 Feb 2024 12:04:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307492; cv=none; b=HEUbfu03YGOYAnpVsC3RVShULGN38VRuECl9ONOo1Jf3Bd3lag5FakUOccWRr5uCtZbZILvEQNqgCOSOU/kQN0Sr1tgdhf5mko9CDxje4SM0T3HcRNwxC9DOgkHft6KBIPLeZ46wuhWfzUkSlUQIQmCOy+zRNDWCJtcFoB5WtxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307492; c=relaxed/simple; bh=tcvkG3IuArguTBs5+oJ4pHS+pBXtBmiVEQi3ZFzSJVw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eIGo2iAiHGp/ngpFCJv1yS9K7S3QBo93ZuWHYcnpX0fYzqJ6/3xjQ7UX2dIhqCyltgElkNbm0BIRlYTscr/mi5YzbYmEGdqyNyex97QZeZuZdisM5QQCbFgHRozNZgSTQrzKHDy5ndx6O/f28KwqAHOpnjptvq/blLSMKcqMqh4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WEzeKvAi; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WEzeKvAi" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-33aea66a31cso347825f8f.1 for ; Wed, 07 Feb 2024 04:04:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307485; x=1707912285; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FVi6POW2wsm4t/zvRlXFF0rH5aMJzAofhX+zIRsv7I8=; b=WEzeKvAiBYJ11nViHOd83qD6En8/8FvY/Lrt7E6VmP5kHWpJWAiPNteXf781b8Z0KN M4I2rLgW5y6J/6Fvt1anoT6ljNBAGFy7jYVAh9efx0mz9x10C6m1FLCzEYWrN6oYHMAA EhdzIqLCU/Y3FoeDJaqB0nlXtMEcF4Nxyw6qVyVVzeesbhr0C/W01UiUZ+5M7SpAnY52 TaEfgEvb+yGxuZvbGpj2Yk7eF3RkcNq7Wmg+rwif7ubLxstwLpBwvppRMZ4QJ9eYNltx G83rR9UcTw0ZV99b1Q9zVLZ8951tyKOJgiKnY+CoszvUWLkVCeX1QXThYziM48Wvi8SJ wB0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307485; x=1707912285; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FVi6POW2wsm4t/zvRlXFF0rH5aMJzAofhX+zIRsv7I8=; b=pLca3Xnxi/sNiCzUszKORjyp/kKVEuRYBws6rvRsO/pHpfRM+UMBjfIPK5x9iGwolI AiFUUPuIXn3T4BPY21bkLpLRgsZ0xeUkXI18Ej4J0YIRx9JVgmCWyahU+B/BBZlZPkeT 8isfMA+4CGWXhMsIOE3cQ+OUvHUudb/pyhBUp9zt3+OMy1H80BJn24ApNzJCHDkjQyjo 45GBLSB50pCzSYzXGnnaMrj/soEg2AgUHkOac2mbXJHx+tCkMHyi20W7ijAu0lEyPLWK gYf9sAAK9BG2zvjlPypNcKGBR0fy7Xlzn2KtKreHgj/CFY98v7L5cq4Vdc6zA5TOKyUI ctgw== X-Gm-Message-State: AOJu0Yz+uuPvFEUrNpBVpHHNNaUYl5uJFcKQ3TJoiDEN5G3n8OOt2J3Q yfOZ21j2+Xq6zFBra9PeEojz7XyrtwrmZSoico+M7ktBLaxgxvwNRMnj78BlZhpLmFA8BWZlc7T Opu8= X-Google-Smtp-Source: AGHT+IEiKXZUvH731o7GliloWXlxKgtG4B9CbYUf5uY0sP6JI94NUhDGFRu1cbzz0NaYABDxc/IaVA== X-Received: by 2002:a5d:4607:0:b0:33b:470b:a377 with SMTP id t7-20020a5d4607000000b0033b470ba377mr3299506wrq.14.1707307485006; Wed, 07 Feb 2024 04:04:45 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXi65c/JIRFTcB5no6O1BT/UfOn7r6G5SsTR4Z1TpJ0xLXYSEO2dQ8pmguXkT9/GofcRmzGYPdz0fLqHy9WI4a9XJLu3ZnH2Y9FhQi4PDPTefydw/FXp0JQtGr82udzshBWEwHTq/ukZqEGmTgQDxXgZKKcMQz4293qjEAvXeXRXEjw+2LJFJFzkMCAjUPIy2EwFnSSn1Rcf3TD4M9DSGgPluoqPt7AOM3bC8R3yqBTqe257ajA3dLN+Nb9xI1RvZ3e8jl5a0QbUHAU/4cqLTRo9wqmHEMMeE+sp293eRNHt+Pb26Q9/k8suUDvadfCyMwnnfIlezqEhf5mn+b0C9ciQO/h6jcD6zZICEw8NhICH3JYbAJvPF2oW3veyX2zvgE2xfCgHAsF58hu8iAECJH5ek3RQOAwpxUnoez02e0fHyx6RJVrC5Ol2XZ5DCo6HWiI/P7Q+Y7q+ObowYJyZv0UtKdvVf1kNWBr9zFS+g9ndwPxU+PgHm2AjDBBYQ== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:44 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 08/17] spi: s3c64xx: remove else after return Date: Wed, 7 Feb 2024 12:04:22 +0000 Message-ID: <20240207120431.2766269-9-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Else case is not needed after a return, remove it. Reviewed-by: Andi Shyti Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index e3e7d625f3fe..0b42d28d2019 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -410,12 +410,10 @@ static bool s3c64xx_spi_can_dma(struct spi_controller= *host, { struct s3c64xx_spi_driver_data *sdd =3D spi_controller_get_devdata(host); =20 - if (sdd->rx_dma.ch && sdd->tx_dma.ch) { + if (sdd->rx_dma.ch && sdd->tx_dma.ch) return xfer->len > FIFO_DEPTH(sdd); - } else { - return false; - } =20 + return false; } =20 static void s3c64xx_iowrite8_32_rep(volatile void __iomem *addr, --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65CCF5A785 for ; Wed, 7 Feb 2024 12:04:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307492; cv=none; b=VrmecR1LYozJIPjJsnjhVYlmfAwvRPI3SkW3HEafpOIz7bedit9fPXTJ6ZlmroxhfM53yqqvAtK1p+j3NcB3CcXQCS+Hr6o8qZdvCp7w6R1LxRNYkx0zkN+7MeKj0+T4Mwq5IV3LiewZvhUz5rMLScFrnsgbhvNbVxZwPXQyTcM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307492; c=relaxed/simple; bh=hUdT3mG5LBvT4BVl+800NzK/cEAylaH8t6mVOewWosU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n6wDm/ubNyJw0a7dweJE3q0FkMW8HxqzRjcsmEjOrHYSJzf56rVKxHgPT/0MdNVTc7YAxtWAfF3OnzW7G8WilOzMvaRwhFnxV2EZ445Qn5gvDyafWdGbM0UvpIF4IvQ/uAbmqouT9STX+CG7kqNLRLXFZp6QGJM38SWh5qCVg1Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LgyQfNoE; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LgyQfNoE" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-40fe03cd1caso4844605e9.0 for ; Wed, 07 Feb 2024 04:04:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307486; x=1707912286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AmZwPJi4/crk/e7JVHaewrMAfpkKxE489+JbcSaSVHE=; b=LgyQfNoEUilZXMMU2w7WAb4M5/buGcOTBHmu4MM3u15A0HtIbKUOeWJAplYQ6rj3Ky edGkNVyj00dfgTCwK2052Q5ApFwRaFWRBYNnxGgQHbRXuYSkeL1AJ8cqZaNyP/e/cw+C o56iDa9X0YoFfx3lcsJARsyULvKITkp0ajvcXs/g1arFfJjIBKq9L/dB7c8eoOkqAG0R pZO3FAy2iCUruHHYmnjlOjh/+Ug2tfqRiLb8+mwq3rN5XFsEouQ3BgeZoZ8wO2DlvT8T JScWtzfxMiHFtc9sZEDkeA364I3u/XKYb2cLMwNrtDOgtjniy1CdTLMGq0uNvyYqZ6Hl Gbqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307486; x=1707912286; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AmZwPJi4/crk/e7JVHaewrMAfpkKxE489+JbcSaSVHE=; b=ugEePE3yBmj1ErhRFHTudthuUKi7zvlH/nA73Be4/EkQRnkpWQzYkCz2+hUpN4jOjt Tc+bMXANzQakmmgoVQjYEdempxa0S9R5P9zUE2qTynE4Vr8JSyCAEv1qF7kgf+m8s7Qx rcf/1mpYNau8afcLcF36jM2E17pGU8H0AyYaOBPyfF4lFt2LVlTRkWg7Q9UOKrtklU4d gTg7qi+9gd1hZ8zwSdmcohW0qx41dWsRQWHm79pi7+eNH9P1e2F4HIhSdBC2iUIo9NKR e3W4NZo8mCxMKsI2PEuO5tm0tGrmvGFwXQABaig7up6XXccrCRS1RUeWiUojRy2puQ3h fr+Q== X-Gm-Message-State: AOJu0YwIg3Oql8wbmzEhY5hFF/nxwlRS7/y3+jj5Lp3NNoA1eTvDBYoS JoUwcdmCtwY0qxil2CGIozShWH3BGVRG6QjrNIyQSwV/bDnWcnVThyk36oyY4LE= X-Google-Smtp-Source: AGHT+IHmmMpg7y1ljPpAMnyZ14o8FS7S/PH5KbVyCVDh5pUlgHetiQ6wRGO7fPXOnM8iUIbbDdGRFw== X-Received: by 2002:a5d:42cc:0:b0:33b:2fba:1ea8 with SMTP id t12-20020a5d42cc000000b0033b2fba1ea8mr3192011wrr.52.1707307486148; Wed, 07 Feb 2024 04:04:46 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVK4JPDc4iDMmGLIARBd4DhgeTGua/l6VbPFhSXw0UCakv/hGsahC4rjyeLrlUE1mLdXcbtM/+chMVezRIIXgxMl62fbmh9orhyACFJvEW25SZwyXuWDqbAmCNhAX2748XWiAkaVvdhH9DaHXDNvgG3ik6hEhlohBdQPJrCGmtC8pnEpH9AnH/b8ZgXhQjk41sThzoiUnjHEaPJA1pkh8/XGlJ7R3wWyfvugWeCgsA/rC9VONkWqcSEE/2C2HcBFfF/xRDy8P4pWXppH1pZ8GGKWPWpwM9trNTw/NGY6mHDFRaK4ne2a4F9b51Tj3FR88dYbmwVsu7x4QToJrKl+vGfsNK+zj9EgF9yjgIH/CH/SMz9IsqdUOpjQjD17fHWJpFkxlL24fj6RNpcaNc732qYzK0TPYGcCMMSdDDW5y9N9C9SQgNmyTuKH6sF8khgyB0xhKDi17at+bga1nNJ+Gg2vIT2fEUhO7og7b9BAT79VWcUfrGP2A7ezidzzQ== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:45 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 09/17] spi: s3c64xx: move common code outside if else Date: Wed, 7 Feb 2024 12:04:23 +0000 Message-ID: <20240207120431.2766269-10-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move common code outside if else to avoid code duplication. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 0b42d28d2019..4ce6cb3b43f6 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -294,20 +294,18 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *d= ma, if (dma->direction =3D=3D DMA_DEV_TO_MEM) { sdd =3D container_of((void *)dma, struct s3c64xx_spi_driver_data, rx_dma); - config.direction =3D dma->direction; config.src_addr =3D sdd->sfr_start + S3C64XX_SPI_RX_DATA; config.src_addr_width =3D sdd->cur_bpw / 8; config.src_maxburst =3D 1; - dmaengine_slave_config(dma->ch, &config); } else { sdd =3D container_of((void *)dma, struct s3c64xx_spi_driver_data, tx_dma); - config.direction =3D dma->direction; config.dst_addr =3D sdd->sfr_start + S3C64XX_SPI_TX_DATA; config.dst_addr_width =3D sdd->cur_bpw / 8; config.dst_maxburst =3D 1; - dmaengine_slave_config(dma->ch, &config); } + config.direction =3D dma->direction; + dmaengine_slave_config(dma->ch, &config); =20 desc =3D dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents, dma->direction, DMA_PREP_INTERRUPT); --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 906055A795 for ; Wed, 7 Feb 2024 12:04:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307494; cv=none; b=NJrBlhoLchIyFvr6d6Zg2fHq0E6OasNietOcQZ0OEdayq9GGthhpHACxc78RkYRSqj233PyXFrOlVak4ocI0UBGUotTe0FhctsYDzj9icZqC4YnQqss3/jU9G2MYYKjHmDyOq9/TOhbtb+iMgcYURyjiMzPj9a/oRFEARHf41qg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307494; c=relaxed/simple; bh=5yblC4DYa+83TmHABcaUQaBMypAvRcd5PI82cq++E78=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DZh1Q25CJ8MDbdZPbHdrWW8QoFnKIGuZiQJx6GwLrBQspFoI/+J0ziJObLDlIX3Gei7/hLxcDZ5HO7nR72jXgkEC5ydhw5eTKQTwRMlpih4aQUhg3OMvDNrbebbETvuw0ejMBNRpNDMRyJ1BMSpXdfPinHH4jVhwKSkcF27MMh8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nfWbWomj; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nfWbWomj" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-33b4e06c239so421128f8f.0 for ; Wed, 07 Feb 2024 04:04:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307487; x=1707912287; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WYOYbNjp8q3KZ9J1S3sEcmw6gmM/Szj8HuSkdRWXI4k=; b=nfWbWomjMQRtFji2KWC9OmZUrDPTDjSJ+hFW8GnPTy6OdlHyujHHZLhijbFBBZ/9le 4BRKDqZQxlrA6u38Kl/E8bF5maappV3awqRf0A3giBk2BRldMYWBZQ016z51lIPm5i3u T8owm8U3HsAr4D9bYPg758ELrEjbUPdIonXQpMsU3u79/55e49zibxalFJB/TTsqRVkr MxgOFr1aA2x6WhX3nuML9C/tdxZ129s0Qq9DbGReUuIZNHQMe6/EKDRhPvGLQ8GnNn1F KH8oLMILy+MqdR5pBR7zJ5xodXpr30Pv5tcebFLGWbFgp7uX0xBsCFHXXu9Jcja3vYRN Scgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307487; x=1707912287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WYOYbNjp8q3KZ9J1S3sEcmw6gmM/Szj8HuSkdRWXI4k=; b=xOVhLarEIY6BL0DDLqyWeTYU8C+QRzY8zVbJNg4PR3hkml7nncZiwpQI4dR0UoHpRl pwbzv7beA+InyrDEcdECxrsMPOaIDnAePUoBmJdE4nHJwfwyiCzd+VoO/0v30jdsXe+1 Nl0Mwi6TOjLdufB9asyoRUOVIkUJo6YDiSkpDaMMt2d5dIRopHdiR1d+e/09dboMOX5u nw8Ow52u2Johz355AFrRuoZLVZp6tVLJuql81XWBxroLSBKeGhOrBsai9ISegoT6Bf1F wTMGLN+e/QDx07jFGNsC9nthaMsCxyT0+zaAtxoSbm0YYqHkxnhffh/kHTai/Vg0BHr9 0sUw== X-Gm-Message-State: AOJu0Yy9pb42byU7UR6A+oz5xXFVkMzVFkWnJVoZj8jJmWD8JdF7xzzv UWOz8R/wz2OOfw9ZLOnczHDKEYMzD9RXadjDGwHCSq2NXBK2eYlGS16qt1LHgkk= X-Google-Smtp-Source: AGHT+IHZddiwCD4E4fn4x0Ro9O6jst0BaUSZMFu9cJdM1Z4p21wwP8+SqVAjqMHPluqWfYL1ZsQ+pw== X-Received: by 2002:adf:e80a:0:b0:33b:10f6:151c with SMTP id o10-20020adfe80a000000b0033b10f6151cmr3549908wrm.53.1707307487237; Wed, 07 Feb 2024 04:04:47 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWtMozbSsRdSCEaMFMJZbFv9kuZr/hjz6zmp7GQ6L59dxFOzKCW8fwDm72xAABI7DneH2cyu5SCP8KdpzK7MmnD+C2LU9gIBj/b30sBsVUi35Mhhop51et2L6wzoyc9PsRyssPwwT2tWMe0jmMTA4WLGA0UGXuUK8YWr5U0O9cs3XwxCeoB1iWT/PdGaoju1pXkvQQDYrSQZb9132pT53pPbSeFnr3TNLdXBg+wUqgpPS5d422XU1cASprBkpP3mon6KuSs2TwqBbgXp05nG/BdHbQMuYJB3ClWthJ4xXE3sT0nYdUoN58Za5EJ2CRYBC7ABA+HQaGFCI7LYgtwRC9+t7thRx9+lYCeHef25wzQvInOf5lDECH3Mbzj9LlcT6nKgvnByzPdJMFQI9JBCo42f/XZuWzvcF/FTnWducUf7RjQkUpPXupwOKOMlKStpGULv2z/UEM3bvyZsghrkal9aJVmIl9s9mpsgvcim+95ZpFBQExi8Ouvt20VpA== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:46 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 10/17] spi: s3c64xx: check return code of dmaengine_slave_config() Date: Wed, 7 Feb 2024 12:04:24 +0000 Message-ID: <20240207120431.2766269-11-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Check the return code of dmaengine_slave_config(). Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 4ce6cb3b43f6..1f7356f6e5d2 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -305,7 +305,9 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma, config.dst_maxburst =3D 1; } config.direction =3D dma->direction; - dmaengine_slave_config(dma->ch, &config); + ret =3D dmaengine_slave_config(dma->ch, &config); + if (ret) + return ret; =20 desc =3D dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents, dma->direction, DMA_PREP_INTERRUPT); --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FAE75A7AA for ; Wed, 7 Feb 2024 12:04:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307495; cv=none; b=tXq6NFnm1gyb7A0DnV/2GB/a7+4okKM7sQGbmCikDfYMqguZ7vCzmfwAk9fm2Bg+u8UV4swoE3uhsnGzHWEfNI/XIofYrw5TfjimuI5MD8vsHO93tCHuw4hfiN0t5/m0kLirS34t6YWbNFNBJ2m3wLsMyUlH3ncx5/mRnIaoaqw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307495; c=relaxed/simple; bh=UUTdIh3Xj1RnoDrVpRDf7wnRZi1N2KMZYs/hAqRGeLE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iUOXIdJIx7lfnlLw7D72gIO4OUddRkovK1O/+5MOLuNgoLGyD5h54JwOMfMQ02CeW2YnuFQ9Tzk+nuXz8GSlQUO7WKJ5N59lWqWr5RMNA0NmoOjPaprjX3T/KZjXd8MHZ7JzfFdvjTnjVBTkEX0fmOKNHVvU2XyUzzL7Q3XdmIs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zHC9BZ2V; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zHC9BZ2V" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-33b45e8a670so325565f8f.3 for ; Wed, 07 Feb 2024 04:04:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307489; x=1707912289; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QyB/rIEWzg0qFsjqRP7XGwF0lM74d/iwYjphW748AMs=; b=zHC9BZ2VYIAuvCjT7sGQrvpL5XP0IlBLVfn+E3qKoNvV0C0ItjsMO1huR7mlFp4AWM xKhR7vsFeoVDOo5Sq6VVE/YAPtl6mwcQ+SiJ6HEbh1np9Cody/ChjoygE7mKI0CUfKvL DWjBbhSuZS1ywJJH1UwWerJEd89cWx5JtZ9wmJ20Sh/D+UOfLcIi5IEoFazw1ydR8zea 1v6QZYGrU6LnH2lOBJLJz1Cx+FQmruUAhvzgLTIFbWhLl4vESbbyEzkIkeKv6BvLA5ny lJMtOGzWSWZjd2gGlUlFZv71ttPkcWnb2G9JtWjVcE/Rspq/w1sc6Ora+w7z+0BpXqwD tRxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307489; x=1707912289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QyB/rIEWzg0qFsjqRP7XGwF0lM74d/iwYjphW748AMs=; b=jUYMHyjqD0BhCTrMPFgDcGbiyjGn+tPD8fh5SAfMbvTjuN61bBgrDup24jVjHRaWIU LF2P0e9jU5sRVzBlf1YfF0EYkLWKpbywwNWSKAfSxqRIANx9Bms4AP0XWNYQ7NOq/skm UD0Phyj5oTYIrFMmMHSnUw6lE7aYHcYNd4LlGm7vvIWY+XV7lCyFLhI008DwXiVS/486 NK1VxTA3g2miwmO0+fdxYv0CJSdL9do9jTUNmG4NHC0mgMdjxaaZU64GgTc5/M7RBVdW H/b8fgYIFGZGIsrP2wiZPbE5PcIR1NUj/iXhxUQHvtSQH787UhFcCpNsAOCwPw3qDv4E yiQQ== X-Forwarded-Encrypted: i=1; AJvYcCW+VJiwd7wFmC6noJnv0FBULpkpEwHYZFlC6Ag1Vag/ssiChHuQTthboVW9a9eGemK/fA4wEJOxSMShl15Y7OSG/IMGQekA93d9ekkS X-Gm-Message-State: AOJu0YynEZx6FMwlAyWHUMd7tQFIyggm0j9i4fnnfeKAzplGnoqZwI7J 2IMr1ywGUSRz5EEZZpJmcnPFdBL1NGscV/SIG5+DvOrzbw8dLsyJV84CWVcDw7g= X-Google-Smtp-Source: AGHT+IHLdYTOpuM6YVl5VQ8KSmozpR6YZJf1vCyR7Jm7pldciiKf3Zxcsp8BxcHt6HVkzpmmahJfLA== X-Received: by 2002:a5d:6989:0:b0:33b:1ae4:10be with SMTP id g9-20020a5d6989000000b0033b1ae410bemr3112553wru.46.1707307488917; Wed, 07 Feb 2024 04:04:48 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWPoi9waljrhcc9Du9f7ChdJiFb7bX6DdMzhB6TZiVx1S6gG/nPe729BwNqPKcVyZuuPdA0jWoPjSZwBlPwgoGv4/+7VcutaOWWT7HZ/3E8KzjuD0LOtpjL0KJJBvdcnNnl7DjKH9MgkFM+oOQxMagBpYbUSNp+A0jDqH8NN2oxDXjkv9Czp7X62NXW5WDOIraHpUkXlQrhFTumVMhvNi2/fuvQOmrhzuwXTN5b0Xg+BD8zux/iMilXXTbwuTHqAP03e4h0gtwf0TXw8YZnH5aDaUAcLltEVIOw3dI8iuambt30B7iLPUkTQcl5whcPC6+OBnzA0glExTxAon0OgcvfTnCNygZplHw+HOEJkdkfLPNEFmao4a8VIZQiPLVaARwFsy4ppTJHvaD9+xssFBf4zYZUcC60X4vqjIWfKWGON6SA6CBFPOQg56CTSps8XueWb71vVnuDitaohl0PNzBRtFUQfoQZtyrmFl5+hfaKawwtkHi2Hh19s739xw== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:47 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 11/17] spi: s3c64xx: propagate the dma_submit_error() error code Date: Wed, 7 Feb 2024 12:04:25 +0000 Message-ID: <20240207120431.2766269-12-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" DMA submit should just add the dma descriptor to a queue, without firing it. EIO is misleading and hides what happens in DMA. Propagate the dma_submit_error() error code, don't overwrite it. Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 1f7356f6e5d2..ba17c5a04eef 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -324,7 +324,7 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma, ret =3D dma_submit_error(dma->cookie); if (ret) { dev_err(&sdd->pdev->dev, "DMA submission failed"); - return -EIO; + return ret; } =20 dma_async_issue_pending(dma->ch); --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD7965B1F5 for ; Wed, 7 Feb 2024 12:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307494; cv=none; b=UV1uVj00Zf9wGasYlQDgVGGaoj25RVs9EISPEeL3djsWajG0gi+pS9fnwP8ZbiiPst+4UIJU7BuJVU4C8whL4daYG28/CJJ+9XfJ09NlTvLGQLh/54WuZJdGVuRl412/VDUcFV8tV0/HQJl7uuJPVPYegbeNaMOkt7sXXoU0F+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307494; c=relaxed/simple; bh=kdGbLF6iJyDmWdAvnXmpZOdcHLnnYqMOt0A/+Z5JkEA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LWwxpnzYnQenFfe4asWasmlLKPeZ4km//DfB8cPzA0qoTS6N2cj17TDpf7vdpIba3RIEc8IrgIPLGXfXJuj8+T/EpXOVrWaTAA8VNxvpfYqm+ukqP2ZuuGKJ2BQKOtoTvfX1qBw/Dkf/uCxKrAXTfM0Jbxjnn5TTCLcakfPo4JA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PvXK7X5o; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PvXK7X5o" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-33b0f36b808so412042f8f.3 for ; Wed, 07 Feb 2024 04:04:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307490; x=1707912290; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=txkWFjXph9hZknSg86bxlVXLA+ATzTdcjT+xz3ha6R8=; b=PvXK7X5oAvFmPhMllHcYsSA3rb50BXRzON1PV+4Avv5jhHBKMhm0AgIOZTcyuPVi5E 60YPXNRXq+ZEB7sOUeYLCfZaBlvCWBTnU8D7ykiIE7kfYyw/DWXNoyp9udaWMnHyM8Ll ogQW9Ke1Kb4bYlZxpLab8mgYQ5ZsLmA8B13wHBJZtxCsZ1IG8YF18Yvw65ycBu4GdikH mXpwsb49L/nlszOMY6BZkURjd8fEFUYwpjRuir1QXrTNcwVsTr7YQ79sFmyUBtU4hj4w yWlJXmhgNCEMdyYZ/VMckthroyea73QNGy+jxAgFGtJowYGJtmnTnvhvKKjT3Xh9Wkbw KsuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307490; x=1707912290; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=txkWFjXph9hZknSg86bxlVXLA+ATzTdcjT+xz3ha6R8=; b=I+2eNrPa0n27YSANT5MmupWSPYOHDmkTJ683LDLhQl6su/KodiMJfaLu9ztLSF62gI JWENSEfGQOLoeepzeyq21fqq+vcsrjaQt5gYzugY1OUWJVI0NqPopuIvM/7KMrZVMpdS p5KTgFrqm1P4drOfLhteGygDbb9GiO6kx2QMxm7KA0dI7K1PQGY3wx5Ly/X9YKXhVxH6 Fb/3PWA8+Pr9YBDfR0dN0RG8DuO2ejwNOtTCVCEZsuQCAqXOe7L+NL3r7ciFnCUcQ+Ha 7AUjcAvag4uVjj1eClodkH+xNFLCQN5ANnGIFPJfRxeRg5gIHtov5ZvgT+NkAegDcSXv pd4A== X-Gm-Message-State: AOJu0Yxhyd8gNYrgbVmFuFYQYYeHzGtf169wwjojXxnlW7pGCTJQfNlm RbVSgMib1ns9JLg1QOSaWBv+U2NbQrOS6Q03w5oWA0QVEDpCE1t0hcbBb8EEzvE= X-Google-Smtp-Source: AGHT+IFeTN6wfhaVpSblA8kzgrtFG9R6BE/gQX+sizE+n5nfcFk6BEFcG9gAge0rSlWZksqj6bg/EQ== X-Received: by 2002:a5d:64eb:0:b0:33b:48f5:b5c7 with SMTP id g11-20020a5d64eb000000b0033b48f5b5c7mr4711508wri.11.1707307489970; Wed, 07 Feb 2024 04:04:49 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCW0S+0NvDpeYaqtK0kX4HKNTyeuKIoCbhT9JX2zrhoZtTAFLxzrio96HJOnqS/xPkTRnyrxxlaximNFjgK0d5eoLo/TAsq6pAG7RPkopLgXTje2TNr5s0Qw9K/1iblYAJT/Nvul/kMncvzBRAeefTXyGaFlIUO5dopvRxyBlxo5pgvA6JsaD8NxCdiBmhy8xvaNRnXyTG5Dcrw1iavjn2VLscWZyMN7rqJ9Vv6aT4vh5WW6kSGU2Ts3zR/ECU8/6/q93PRn3jfUWHTSJm71953zzYld/METrS5ApsxPuxK9cxWLP73dzADRtRj0mn39jBRG6B7q7NUVouU0KHPok7gYmFZL+9urqZ9yJDk13hMoqMJWowfTiiywP1o9m595/rLEHzbOPvZG82mkUt0JzdAyKicjJW4WJimVp6IyU1qTIDAj8UHkD37w1C89HdLmYMuL0L36Ik68Pp+7F3dp2h0HL6tGPs9Nt9J97KDtlMOg4kgcS3IRUFKXRm769Q== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:49 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 12/17] spi: s3c64xx: rename prepare_dma() to s3c64xx_prepare_dma() Date: Wed, 7 Feb 2024 12:04:26 +0000 Message-ID: <20240207120431.2766269-13-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Don't monopolize the name. Prepend the driver prefix to the function name. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index ba17c5a04eef..4cafec877931 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -281,8 +281,8 @@ static void s3c64xx_spi_dmacb(void *data) spin_unlock_irqrestore(&sdd->lock, flags); } =20 -static int prepare_dma(struct s3c64xx_spi_dma_data *dma, - struct sg_table *sgt) +static int s3c64xx_prepare_dma(struct s3c64xx_spi_dma_data *dma, + struct sg_table *sgt) { struct s3c64xx_spi_driver_data *sdd; struct dma_slave_config config; @@ -497,7 +497,7 @@ static int s3c64xx_enable_datapath(struct s3c64xx_spi_d= river_data *sdd, chcfg |=3D S3C64XX_SPI_CH_TXCH_ON; if (dma_mode) { modecfg |=3D S3C64XX_SPI_MODE_TXDMA_ON; - ret =3D prepare_dma(&sdd->tx_dma, &xfer->tx_sg); + ret =3D s3c64xx_prepare_dma(&sdd->tx_dma, &xfer->tx_sg); } else { s3c64xx_iowrite_rep(sdd, xfer); } @@ -516,7 +516,7 @@ static int s3c64xx_enable_datapath(struct s3c64xx_spi_d= river_data *sdd, writel(((xfer->len * 8 / sdd->cur_bpw) & 0xffff) | S3C64XX_SPI_PACKET_CNT_EN, regs + S3C64XX_SPI_PACKET_CNT); - ret =3D prepare_dma(&sdd->rx_dma, &xfer->rx_sg); + ret =3D s3c64xx_prepare_dma(&sdd->rx_dma, &xfer->rx_sg); } } =20 --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8619B5B20F for ; Wed, 7 Feb 2024 12:04:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307496; cv=none; b=niEV2V+Z1ne38D+lzAKbeqq956FDumvYIoRsIpNbygm+eeUQv5jNWl99NjuMxFLcI3e6mx1jWYS9730wvICe+A5JsZLeQJwhef2Gy9Y2M0rGe6d++PW/o33lrmRn/3/Ye8KZy2jIojsMoe25LEB5DPpJ7x5xjrLyxyKuO6OSnLk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307496; c=relaxed/simple; bh=m1U2ibNS2o4vQmNNZdCySzHxJgiI2IGiRefG6tMF48Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i62mm6omW+8Mqef0HJWJ78nlSODJQPiLefcE1FDHv0pNlOfKSS0oLR9rDcqoKNTHRyf/RkqStpWiFtcb4pETMIRhGuqDr77RkbTcMREWe8faiNKcIKmMiij3RPXUJrSTxsWNZSuH0G/rULG6NvEaTqiOWnYwQzKWTuS9E5rItWs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CHA7CYIG; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CHA7CYIG" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-33b29b5eab5so367361f8f.2 for ; Wed, 07 Feb 2024 04:04:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307491; x=1707912291; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lw2MVCnXePoaGoFwhILfXnUXamqqjuyMAhC06ZDA+Mc=; b=CHA7CYIGDFaxAthUuyoMT4LtUHxzxqyWQAXJT2cRYhunpf3xXRsmTby+HcFl6n25yV HSdwbUlesUq2QerWOEntSP2s+BCvbEYlFYJgqyQWw/FjvuU5FFj8qelh1gp/m8SerICC okKnR77bONbx7QOrMEv1NSFYrtmfDfxX87l/yu1Zqv57YnKYhiyXfQkw2MEv3oPSJ0d7 yIr8+sOnKKPmptxXL5RxHE7xIbuBK5I051Z1sGnR2IidQgW4YTdn9oYhK7iRuJlO2sF0 Khs4omdTNWL5qiyT9Aa9VZdTRiIb2Pqd9q3LmWbayekDJ83xOAKffIZzMG+u1J6Te7YG AAyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307491; x=1707912291; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lw2MVCnXePoaGoFwhILfXnUXamqqjuyMAhC06ZDA+Mc=; b=GySNISP/7Ljd2E72KD4RubMlJepI8n6ruKqCyoGKc97WRyV9S1mAVjmWn4blStKWsO wHI8dpHqSv7GO7WNyxzpQIOg84ym9XPQklGXL8iCi6F0otXWElzfV+SQlDzvdt7q/HOt x92ugNRzYpP5vVFZrHAYcxUNJ2HrhaJUY+8XZIilDAHOI7qhcNgPCS67/BC3oVMTHP9D vRO3hXzNm6klQAPUlc+o/rSQ2yFl6nx8gAiQu+r573lOWlDTi4Z7GTXWLOnqsnh+3Kkg vlXRZ1V6g8waDfsFJIDupRu2v3PdoNJ01JlnHVYQNChCkrwsykc9DIyODuJARKl0vha8 /P6w== X-Gm-Message-State: AOJu0Ywg8n6deu+U/2Fx4N3zlRNosVDZxLHr2TTh0DOMSE6ORc0lIg7D LUO9mFQ84W9uq4KUJpF9XR4wSgjmn9Wlqfggk9PcBcFXDAyIljQF4fIgD/6N1LU= X-Google-Smtp-Source: AGHT+IHAYlMgGVbJm1ulTdNKa/+d0RgWGvnEGEpkGS2NLVlo4ZSIijWb3cfglDfGFwxik/TiWE7lGQ== X-Received: by 2002:adf:9b88:0:b0:33b:216d:70bc with SMTP id d8-20020adf9b88000000b0033b216d70bcmr3033646wrc.42.1707307490826; Wed, 07 Feb 2024 04:04:50 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUAVMzVycVD1s6muTwkHOso64lMG/emDU5TiblalPWX7ZMHPJ5//3sDLDgEuNNZ2aejKW5KK9QN7rDbCTgQ2Wj/UBuVCg2IXUOVzlU5gB6mNN1onRg/Jsmvj9MNWKST7hrSIBv2qCpxV4AxqG6CDKNAZqjBq3PsymshtpNimVbZJPX4GC7xX/WWsSaTzZknsKwN1XOo5G8bnWTdaVmBfDL/TIeiHwE7NYFnJRI5RXe+k5TSIk4H33xzDkNeqod5v4+3vhsGtBzwrYiLOywBnRWzgl04dRvB5kwuD/+yuqmjC9UqOizl+brwqNY4GqGKADdhdSrMxTH01oc8sE5ntbRmHTtCKTLkl7joeouwRxmGAACiPA6Qq98RFng40UhReyhxs3JGqC4atlIgyOnV7ERYsOdt6gLbFhEJOucDrjhUWqPFNPIJjVRLs6ty16nLLqdFiX+paCeYJouUXhqtJtN8c0Y9l1OiQPYQyCkFWJocTIClBepJQa2sqjQceA== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:50 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 13/17] spi: s3c64xx: return ETIMEDOUT for wait_for_completion_timeout() Date: Wed, 7 Feb 2024 12:04:27 +0000 Message-ID: <20240207120431.2766269-14-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ETIMEDOUT is more specific than EIO, use it for wait_for_completion_timeout(). Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 4cafec877931..bcc00cb5e0d1 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -566,7 +566,7 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driv= er_data *sdd, =20 /* * If the previous xfer was completed within timeout, then - * proceed further else return -EIO. + * proceed further else return -ETIMEDOUT. * DmaTx returns after simply writing data in the FIFO, * w/o waiting for real transmission on the bus to finish. * DmaRx returns only after Dma read data from FIFO which @@ -587,7 +587,7 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driv= er_data *sdd, =20 /* If timed out while checking rx/tx status return error */ if (!val) - return -EIO; + return -ETIMEDOUT; =20 return 0; } @@ -617,7 +617,7 @@ static int s3c64xx_wait_for_pio(struct s3c64xx_spi_driv= er_data *sdd, if (use_irq) { val =3D msecs_to_jiffies(ms); if (!wait_for_completion_timeout(&sdd->xfer_completion, val)) - return -EIO; + return -ETIMEDOUT; } =20 val =3D msecs_to_loops(ms); --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AC2E5B5AE for ; Wed, 7 Feb 2024 12:04:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307497; cv=none; b=Gz+VORMofFufRxhGTf0tGRJCyJ9Bd+N/PxD33HRgAgZ8AMKc7ppmAvUt+ZpuodoSHpdVyznm1spufL4A2V6jLlzcESvWHpNhD0y2ArvpJJMcZccX/C1PCkf2q9vfNLzwqFkcjqg/coNw0X1yGXJtSspI4vPelrcKVycBaJQBRjM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307497; c=relaxed/simple; bh=OIp9JH/BebRZSk0u8jiRPSS3x+B/WlpXIe18LZxE+e4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HAT5RfC6d053hHSkewxQq8NgrPpS1TyUQnRiKxXSN6C29mmMYhTdvJfDi9Kvo1uqYc0xLrH2ovWTfdSv0uffeXVyMGedVGGI9kGugCnyFXcWRQVkEjv3s6uOuMnQZwXW972zwGVncvdyp1/O63OPFXQHxjE4xP7N+7mb/YXVIS8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mS4nqEmd; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mS4nqEmd" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-33929364bdaso365041f8f.2 for ; Wed, 07 Feb 2024 04:04:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307491; x=1707912291; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F6pV2GvkwiGM8sZS3wOj9QdqoXevBRStq9r4pHeBHjM=; b=mS4nqEmd4esmINx3t5Ynvx3+BTOB4c9Ne3lZQx75bHZiEZbhOyhpOTnZfUailb6b+T F+5ENTZkIMAvJRhueXHlHmO/i/tfpaM73mLjm6JCYedZp2giECtcCVs3SJdbpiS2ebfA VujsDNdw/9GCLRVZnBVs5vDhfB3KxmpH2ItHGOFgzb58ZN1qBxKWZ3+SkbTlqXgTK71A V5apmOpxJ56EfymnuXNHk8ngQSrWIE6lfuxvE/i7Y9cJoDStZ0cu8Qy13mcioQvxnzDW 3bTJZxeYpFhRQwTU1vTJjflWjVzCDAWCkkJ2wMBS7U6RtJowPDC7zicy8R/I71tjjqoV VTpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307491; x=1707912291; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F6pV2GvkwiGM8sZS3wOj9QdqoXevBRStq9r4pHeBHjM=; b=AEBa+LE18Vobu1UXsahTLBmSsPvKjY9ZQzC1srKpxpjE0p+AoTnzwbex7N1VEk0D2b NlNIX952mvh8gKlGfaqgaHNHnuWlsLMSeJz2vpuPmHOGvUf9q1s5cxkeTx1Ow5548PXr utvxAyn2Pmp7O2vXtQS3fK/5xOcIY7Y4aW6uGntM6baXGWSzYod3DEaDCVmN7CaEizMy YB1kv133ezqg511BlMB5HGD3isZA2GBkakOzhYqhYIwcnjG61j2fW1aY8Y0pQfUIljbb DjOjsHhbHP73cZHduEiyAJkGAzLXHoCXkOelyCieMOIWsSegnTBbyDdn1USNaDpylVLE BRJA== X-Gm-Message-State: AOJu0YxjNLERtwr9IWncFcgOu9Oirei+B99m+E4ZA8+TnNBI64xaapVT k5XZKCQw4scMjrdKz1eKgRHNc24w+4H9XAgWG8N4jal1gvDsz4zvKtMuLjfrFGA= X-Google-Smtp-Source: AGHT+IEdlw8JH/QSRtZd610quS8/RIT1PIG99ZFWjrLwu4MmQXZ8BT3xN451LK0X9PBzhn/DnxzkDw== X-Received: by 2002:adf:ffce:0:b0:33a:e9b5:b14d with SMTP id x14-20020adfffce000000b0033ae9b5b14dmr2977897wrs.65.1707307491634; Wed, 07 Feb 2024 04:04:51 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV9mcRhUWoZkdqVD1YlZ6mDdMCTzp1K/WKzzPN4YOBL5kh2SFeTNNxJZf1WDk1W6nxUSQmICF1O6KtpyZarM4cbiucm88AXeVYKYiuI+uqjA8Pp05Bpm64G2BCdofnYzEG6DmG4KqN191ATxgJWReswzMyc/nnJOCseTlvj5o1G73v8XSCr6Kx8veIaeF1Z+id3kC3qqBTdRl2yOfTQM1p94DZmpY3FQ9wcR/Y588JOHAwabMZL4posJJnzDTijw3mPQUcOkXyqiD7jO5vbiUIJBCa8kHXNZfsIVsmyvpmdoM3HTA74Vq42TkhtIfbdVfqqKjMsVLNyuap1GuNGx6TiXFGmZ5lRD89Bd5vXETxVKdGLQI1Vu5KPVRl4eZ76GKjumcZbNppknmACOU9ujo7bcbtowkHm5azyJVZeIaGECyW9I9fYYtiKufG6vZouxyW0geiFIuOBN1JW0rkOb90zn/G8qizQ5DO4UnNTzuQAHLQ3Jt7VwVy4cfR1yA== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:51 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 14/17] spi: s3c64xx: drop blank line between declarations Date: Wed, 7 Feb 2024 12:04:28 +0000 Message-ID: <20240207120431.2766269-15-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Drop the blank line and move the logical operation in the body of the function rather than in initialization list. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index bcc00cb5e0d1..d257c4f5623e 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1360,8 +1360,9 @@ static int s3c64xx_spi_suspend(struct device *dev) { struct spi_controller *host =3D dev_get_drvdata(dev); struct s3c64xx_spi_driver_data *sdd =3D spi_controller_get_devdata(host); + int ret; =20 - int ret =3D spi_controller_suspend(host); + ret =3D spi_controller_suspend(host); if (ret) return ret; =20 --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3D0F5B5A2 for ; Wed, 7 Feb 2024 12:04:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307499; cv=none; b=qunbIkH0C70Vs4FlzHKXYcj/7QFc/npBGWlGdxp46Pg02MJvZvotWLEWeyJsT4sp0aQiQJqX1XBU5kB02ZQvmJR53fEliZQjxTLE1Qo4L6W6keaCO10fVfb+EXTL/bbiieI+LvYIde+SHk0xDpjBFF7rnUvNsj11mgzU947DloI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307499; c=relaxed/simple; bh=ndhNV4HBTo+8b5MlnFEeygRckLePuGteV+8p8h6/7hM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lVk4/aoWlKSfPRDtVUrA0BllKrksTPXNElSN1QUurxSL7LvSwh4f09IW1C5grbAzAVIdFmXbkjae0EiPXz63tKkyEtOn4ET/vbK1WTcHtqeu1YIrs1mxL8dS5UnIsmwsZSOAUQy9u5wDay4E0s4CfZdrdSxmortPINO/8/NIAGA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Wyd4CKhD; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Wyd4CKhD" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-33b40208735so399855f8f.3 for ; Wed, 07 Feb 2024 04:04:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307493; x=1707912293; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=esOoTMwtz9mK2VZUJDBgnsqINevzj8Tua/LgvZgzfIE=; b=Wyd4CKhDvLwiQprKGAsL6MYYJ3DVRHGjRM8lwitH5tGtCXguQzg9IkYE8qmeUvSZ5i 9HpxWBuHr79MjKjnNsGSsYHDRdU4DLRiAAEPzioeVVeByMSDFhVOYs7s1+uUWDAE/W/n B+8X/fZSdh9cTB77mfvvo9Zp0jD8GSeoznJdbcYhcwMFB678nKM7vGN2rS+4nAq7zTJx 5sprnsgxr5IHzPhE3WnAHMYSEpVLZG4wcXbzHUrp8gzugA5CpopVqvwUg4kBb3UOct9q RQFKPxHSY9bh9eoQnCh0Y14yLFYy61kJYFBjYqHBLluBHhIxLwAmgj+tI6pq2LMRHBJW oqzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307493; x=1707912293; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=esOoTMwtz9mK2VZUJDBgnsqINevzj8Tua/LgvZgzfIE=; b=AKW2t6QZabc70SQWNO6+JYxF7vV3KiVogZMtlZbzGM6U2bZKtk7Y2Y4gA/yN4Aknln SOH273YvR9Ubp50voZi1oaHeZqaysCR2fqohTV8D24iEE/nSppDFswAV0pDLXORQorxv 8AVAFWxxJ2rDRjb0HG2eYDcmm1YF9o9147TCARWkcYQkFYGgL6v6HHsH3alNg5GPsU99 9TXVHPg5ggTzic/R4R/Q8FbwbIHqp0d3WCUJM+lMSlOn71G86VGW3LqUwmrkTOC87i+5 UlEgEHbC7nOjB1FQQFKUFsVD6JtWU+es5ehXZC/3/qqkV/y7WMua52vuEkmHKSr1WyDs uyaA== X-Gm-Message-State: AOJu0YzIcmMsOCyxBjdBafyceNvzLnrMxvutEqkdiIXOAMZnS2bv6TiB RO3EhaIySIQUstdjpYc3rzIEokSzh6xiG8uOBPsJOOYHRQIukxPqTVu0TBxX5H8= X-Google-Smtp-Source: AGHT+IHNYokoEWrUMav45IyumWp2ABhQV7nc/ooQblNWaAvOKDxW2vN6k5GYusoa1cL9/U7spakTgA== X-Received: by 2002:adf:f151:0:b0:33b:4020:8710 with SMTP id y17-20020adff151000000b0033b40208710mr3001464wro.61.1707307492917; Wed, 07 Feb 2024 04:04:52 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWaal8oeOj9vES+9cljMw75JIEHiHMH3H2LXvh2RoTFVHMIyKN9cv6Rx4JqYjLBbgr8zJ1fECV+9sBx5uJEneYgGhYxv+sP1lLP3Sv2/TK8eNZh/kPkCN7XVNJaVpIaZ/3DpmTdMDbkH+O3hjPUrnigL9fUh0+EewK4LyupWyhsgqttJgx2/abu2cLoz8kkkcHw8tjSw8AVFKij6m6P7c9UVgIilzmlrhMyQvHfDmetnxveqpn/PlnYPVLQeUtgUdMFH9NjLdxIcD+uwQr7ff3Unjl6CbqJ4ieTj34kZY/J2GKprMlYfXRZDH3bPw7sY+MVDxWnnWNUzB1oMDM45qMphfUf9iTlxHEWlCFPjP18iIeCQ9PdqjP3U2zLqhOKyV016trQ7AX6M3XWCLgr8tXo3hA9OaTCdWet8K4CNWomLFogCYdMOSZIAcxjxAOT57NppAnEcGxegzz1Dv7v3wEB40lJEL9F5qWia9kCfaUTJbk9QQIV98S9UAcX0A== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:51 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 15/17] spi: s3c64xx: downgrade dev_warn to dev_dbg for optional dt props Date: Wed, 7 Feb 2024 12:04:29 +0000 Message-ID: <20240207120431.2766269-16-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" "samsung,spi-src-clk" and "num-cs" are optional dt properties. Downgrade the message from warning to debug message. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index d257c4f5623e..8ad28ec3e6c1 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1149,14 +1149,14 @@ static struct s3c64xx_spi_info *s3c64xx_spi_parse_d= t(struct device *dev) return ERR_PTR(-ENOMEM); =20 if (of_property_read_u32(dev->of_node, "samsung,spi-src-clk", &temp)) { - dev_warn(dev, "spi bus clock parent not specified, using clock at index = 0 as parent\n"); + dev_dbg(dev, "spi bus clock parent not specified, using clock at index 0= as parent\n"); sci->src_clk_nr =3D 0; } else { sci->src_clk_nr =3D temp; } =20 if (of_property_read_u32(dev->of_node, "num-cs", &temp)) { - dev_warn(dev, "number of chip select lines not specified, assuming 1 chi= p select line\n"); + dev_dbg(dev, "number of chip select lines not specified, assuming 1 chip= select line\n"); sci->num_cs =3D 1; } else { sci->num_cs =3D temp; --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3A965BAF3 for ; Wed, 7 Feb 2024 12:04:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307497; cv=none; b=kdzN22wdMcdt9u6V/5LTioR8dp8Y9Q/BARdrj8gFIh8DTXuHAOsu6g+TZB6pYHjKhz0ORHKiYlW9IjI/1b7uStGLYjnvtORAexvJI2MiqVv/P1TNj3q1fS6vWQFSKpq4Bw60X7aTOsyNftTVq+av32p3mCe/pjABBtkfptXaDfY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307497; c=relaxed/simple; bh=7G2GlqK62V886iyFZZshyXOs/6SvUTM52aE4t6xMb4Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SL9nS0L+fbqWnN/iHpmr2aZT4S7FSKS7/F1w/m6NvA5yDTITzYHu4w4Jf9WAatIFvRPgzE+lmqHUmWSNQncXlCpLFeHnZx4vDTR42nlF/5i3UKhWOjn4T64McDBrq7Dh81Pg70Ezd1G8B9s3KYgGROS9GbEZx4YMusa2UNAcd7U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HMSNrQGA; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HMSNrQGA" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3394ca0c874so440309f8f.2 for ; Wed, 07 Feb 2024 04:04:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307494; x=1707912294; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4ufnZbtzqByKMCHA6c4FVXpl44oTWg4jCcYWjZ5sNSY=; b=HMSNrQGAWGZKONwbf5NCDZjNrBZyc3EjyMb71QoOprug4CwbzO8NMVdZ/sP+K1AWGy 4FRYJhPYgg4LvxlPGnisi6GwuScfAROD3ESZGYMIFcaRLteLqpRg/eTuMnqnBJfW7w0N yhpoW793BWEoh2bjjdBnA3PRI7HOvwZb0fk9HlQLL1flwH6k+/6S3sRxAZXAarR1R6n6 Iss7Dyw6kyqCRkcutm1h6k6TN2vmRx2hgUA7Tt08UoTyFUF2k1sYWMAYB+xBu4Q8YWWm V5inO2Qo+0tQl5vNXhWyNnCoUoCUNUKyomAF8/mgpvPwXcOpVSQ7JTrI2NrTdKQc90v9 lVAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307494; x=1707912294; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4ufnZbtzqByKMCHA6c4FVXpl44oTWg4jCcYWjZ5sNSY=; b=ciYeKheNfWSn9Na4MCx0LZe6r6wMV6cSiu4qBMnjuVqxvi4iAVqCdXmFf15Ql/XFnK MoH6JrLcA9E9ijjDzELn29xJU3p4X+XQ71fR+5lRFAtjN9zApInf2A0a/OpXxlKnX3Jt CWD7Llj3dBIwuXjcINVtgff8iNdALHQ4BHCEZjFjGWS3wT4Sa/fS2XqI6JR+ud4BT1FR jQkkMpJ+RZWGd7vQUnpoyU1CivKaV7zdwx1MI+jEyw4PyodUuCQNsHWONssECZSHdcBd g6qdqwdzslq6MHjcXE/6NLaeE/ibfNPT6M30r1BeLFcTqA5OILuiAI1Bpzephspg/Elq EdZw== X-Gm-Message-State: AOJu0Yx1K7SZeO6UgLHD5HMCr04u1fm9zkJwOgsyf1gJR5wMHhOYOVTQ E88maNgabhdQ6v26sb5ix0oi90USozkzki57NmX4/dyDIIqK8RjhdoaKCUOtE70= X-Google-Smtp-Source: AGHT+IFZT5HUj9Ch4rJSbpsip/HdNmr4oB4W9qCQPJGoBiXBqnNcx3ls5M2NAsHLNwHzFc9V7e/f8g== X-Received: by 2002:a5d:678a:0:b0:33b:28ee:645d with SMTP id v10-20020a5d678a000000b0033b28ee645dmr3154982wru.68.1707307494003; Wed, 07 Feb 2024 04:04:54 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUNBdOIH9bdH2mdNGvnteDdhtUtg423gHhRiIU8EipuSYxB4Jnvvy22Q4JUM6af/vtArLs6sopAQyYgAGNfcDYmd53wkvBPISfzd0y2hz3Ek8HK82t5uw1PU2fLLv/hJBZQA8Qo5Qky9n2NsHsAM/yazfDafaDpQvIr1jQvtkxKDVthlEomBOD9wlt3mKqkNm7g/75X3+drUsCUY9qwQi9RwlE7kLFWk42CTQcAYtcv/18q11HfXqHNSzv4nIRR2QlRQXd421oB+UQl6aAhoQ0hVxnf0C4EhAROGBBr93NOlVU0PFQ0DF+cpJwm2ZKcGvzeZQxaJjAE9f6sVbg/OF17uJWCXSpTAK/PgprTd9oYC3hF70hM2Jc5SEgZESMTUQPv/657od8oQU7q0I2xQsbNP9V83hjk2ENO0fTTf+ZMuQKgJzvPG8P3BA71+veRH+i+KtJ0dPd1y+vLf+0/iHPVa2GL8hiJ+zr68QTWM+n69yK9iQiuHnnW9cir4Q== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:53 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 16/17] spi: s3c64xx: remove duplicated definition Date: Wed, 7 Feb 2024 12:04:30 +0000 Message-ID: <20240207120431.2766269-17-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" S3C64XX_SPI_TRAILCNT brings no benefit in terms of name over S3C64XX_SPI_MAX_TRAILCNT. Remove the duplicated definition. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 8ad28ec3e6c1..b618efba0509 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -116,8 +116,6 @@ #define S3C64XX_SPI_MAX_TRAILCNT 0x3ff #define S3C64XX_SPI_TRAILCNT_OFF 19 =20 -#define S3C64XX_SPI_TRAILCNT S3C64XX_SPI_MAX_TRAILCNT - #define S3C64XX_SPI_POLLING_SIZE 32 =20 #define msecs_to_loops(t) (loops_per_jiffy / 1000 * HZ * t) @@ -1132,7 +1130,7 @@ static void s3c64xx_spi_hwinit(struct s3c64xx_spi_dri= ver_data *sdd) val =3D readl(regs + S3C64XX_SPI_MODE_CFG); val &=3D ~S3C64XX_SPI_MODE_4BURST; val &=3D ~(S3C64XX_SPI_MAX_TRAILCNT << S3C64XX_SPI_TRAILCNT_OFF); - val |=3D (S3C64XX_SPI_TRAILCNT << S3C64XX_SPI_TRAILCNT_OFF); + val |=3D (S3C64XX_SPI_MAX_TRAILCNT << S3C64XX_SPI_TRAILCNT_OFF); writel(val, regs + S3C64XX_SPI_MODE_CFG); =20 s3c64xx_flush_fifo(sdd); --=20 2.43.0.687.g38aa6559b0-goog From nobody Wed Dec 24 10:08:46 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD3405C61C for ; Wed, 7 Feb 2024 12:04:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307499; cv=none; b=EroWRBbcoTLGqUe++kGmDw70OqLMcrnKPzkPNUctaBtH4b72dPfOx/yrAp17FND0oUHw+XnjJ+SW+MKnpjVKxHYTw8zmET1W3zkN5o+A44U2ndA6GEcVWinrNMtfHEd4UuIIGc9YRIXLsWmq1lQhc5mIRBOb+daRkzH9TbzppLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707307499; c=relaxed/simple; bh=ckulXwazTQx7hzX1rzxZLEmGDEusbVQn7uqk6rAXD60=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RB3y3rs88x6SOlMjAZqWat+2Vv66ZTk9bYLB1VyCQthRSTqAh7URc0xz/YtRsgy15XesQ1avqZfWyxVbxPwpCtugg/HBrOCP4YYYVkkk6B6oJuCSnwvxb1Phf7UPcGpS7g16IXEtKgHP5mQsXaO44XovzdqTu1PJ6om/tnjxetQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mT5v4Ocz; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mT5v4Ocz" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-33b29b5eab5so367406f8f.2 for ; Wed, 07 Feb 2024 04:04:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307495; x=1707912295; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MUmZIG7rbdoejZJeYccC+uC3nddcIt5ul4UQ/BCMGCc=; b=mT5v4Oczlh8E6ZPv+NMOSRtCA/6I+kf2+RHgdjQjupbQgqts1wH0FDeYHzzijk8abc FzZUBxoml8gMKq8041w0xGhasVn55I4SgVIPds8Vei/l8qEmw4x3v2YDV/rtjoXl+MZU DN2i4m36kCKnIHltCTyeC0+3KJNN+zKuh2adY5O9lwlTdXu/fFwTOuedcXGhNcqJd1HS 5HYSOw5IQ7JQ7eWf1bBxUfm9iO5nYj6FffK8ycAk7/ySpS3O8P3Y6F4z7bmovOzTpy3Z Pfsy8KacguRNYy7hPqbpMAQPyFjen9JJ7yckwLWkhaadTGYEIY7mdzAvqSkXOa6y7YnN KEIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307495; x=1707912295; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MUmZIG7rbdoejZJeYccC+uC3nddcIt5ul4UQ/BCMGCc=; b=hCCjsK/YBAGEUsmmaQYY7e7KEbh2na3HMF9sfI9OZOhjT/I2qy7NRkJtynTKVZ1qfM u/euRsCxH789gjIRVVQoArIaeKyrkkKifWk1NDTYORPsolS30G9l1hnGiSgO/2SBVAMc hFu4uDIvlz58tA4o+x0flKfdo05T42qPwAixIPmQ/fg0iJBT2I85uWTYJQ3YoWp+m8VY xpTKi4nBGPTnfbd21VREu0erGzboHLUBZ+32sLyif7/pceXRZeYpfzMwnKtj5+Fomxyx QWvd3NplmLuldzCg73F6rXgiWMuLwLoh20oMYSUbuxKRsVwdItpcquFOJAnG35A2pWHF CC5w== X-Forwarded-Encrypted: i=1; AJvYcCVU/jixC4FmwosIV0PDLcUo44qzvyrtW5L+xg8Kw3YtvcKRgSd79LNkIFCf+/zik2eUVOZo6Oxh9r1F5UMO3I2EH/osE1Db9lc5ucgl X-Gm-Message-State: AOJu0YwQyH5q/E/KG+/1oomjKvIQgI1Mn3SzxnAGktNQGD1KefhsMICG p24+0CdIiLlop76aThoOZbBr1kehDFWvRsakausNb8ZssZvbECSm7RtnlSay4Aw= X-Google-Smtp-Source: AGHT+IFD11KuiTyToxxU7V5ynwF5qtWYXKNpZ+ojCpcavXuhHfNCiW/EREgR8+OsmdJvTBADWjVmyQ== X-Received: by 2002:adf:ef04:0:b0:33a:ecd6:1c71 with SMTP id e4-20020adfef04000000b0033aecd61c71mr3025707wro.56.1707307495029; Wed, 07 Feb 2024 04:04:55 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVYQvziI5mjEusSUaPhP14qhlm9p6zZIwfAk9T60Ma8Qt9fo0WfkTkJE5aFzp5O0QnfJ9FsuPRg5L3EWDvoHxvS1u2LIHGmb9+GaXZGkalH96i1KuSzJ2PHrFzC1Z9ZSG7ULlemCcI4HWyUgGHyxfI3p31aAQqC4KUwNvA4YRmsxASse05A+LOIXIxFW4wCuE5svHwtKBbHzek3At+QYTTmMnk5w9CivZkq9eYHcGU6dz4YznaGGNPH2iqZUnhPV/9SUexh9ATwMobHeHQjWeF9zlVTKItiotmBwHDCmDLPO5JWYkbfXb3fBTuKNtqc+7cdVxKhtr7N3teqFKtgHMx3CGHIj9NE3WYL+3szXb0N16BXyfWYXWKfSOLdfklfCCoCvuHHNydQwU7AitaevZyAS6vS2Mi5M1rtscaMdFlZoFMcfQyBNq5YTx6/QNEqQ3EnUEkfNT8JRcSL6UZBlge+a104Zc/3rABjxGaZSyyqJ84lPqBhJRAU9D6BAA== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:54 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 17/17] spi: s3c64xx: drop a superfluous bitwise NOT operation Date: Wed, 7 Feb 2024 12:04:31 +0000 Message-ID: <20240207120431.2766269-18-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" val &=3D ~mask; val |=3D mask; is equivalent to: val |=3D mask; Drop the superfluous bitwise NOT operation. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index b618efba0509..6f29dca68491 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1129,7 +1129,6 @@ static void s3c64xx_spi_hwinit(struct s3c64xx_spi_dri= ver_data *sdd) =20 val =3D readl(regs + S3C64XX_SPI_MODE_CFG); val &=3D ~S3C64XX_SPI_MODE_4BURST; - val &=3D ~(S3C64XX_SPI_MAX_TRAILCNT << S3C64XX_SPI_TRAILCNT_OFF); val |=3D (S3C64XX_SPI_MAX_TRAILCNT << S3C64XX_SPI_TRAILCNT_OFF); writel(val, regs + S3C64XX_SPI_MODE_CFG); =20 --=20 2.43.0.687.g38aa6559b0-goog