From nobody Sun Feb 8 22:05:29 2026 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C279E132C24 for ; Tue, 6 Feb 2024 14:38:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707230282; cv=none; b=IcQe77jAMn1MZx1eryw5yL29Nol7JNWSBzKtjiMaqNuAkZTsGva0TewT6X20M7LKaRicoOeA61wpzjn/25WC9TqKVT1Hrgf3A73iZXmgn5+pjwG8B4pYw55dPEiPnePss28rUtfvwGYRl6GkhIQ8jCCpWGN1GPprsgncMguPyPE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707230282; c=relaxed/simple; bh=xtB3eH2nc7TbBl5//VOpSw/2z14pXQ/9Y8lHi5/2iUE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X0hV4n9OHJcOazOdTLVDeBgH07ySpnjBZjiWoHJ3Duw5l8oIrkj20+uDvmBKeBl+UXSMiK54vWsKvYGiwZEoKQGiHzuIArgiimd4NyirTIlJTDXUG6pSPJoUOLH1G8cBZ1esoxClTZnJoFPYcpjzaNvae7Qz2+BkzWuLvQgfu5w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=qsGMkixy; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="qsGMkixy" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a380c98e824so124708066b.2 for ; Tue, 06 Feb 2024 06:38:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1707230279; x=1707835079; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9NBgzZuNQ3XMEUB9jdo795d+Eu/PODGnrBF33YaDmlo=; b=qsGMkixyaX0y7ygfx4CsJcsLyjvGJ08Hc88xHf6lCGFLwDfaX/AsFwUNISR/3u1qr0 1wR6f6jeDs3/Ej3xenpls0RmMCJ9uiRNLzCa0Vdm18lWkl2WYNmwvwUZP+RK98+nR1qz pwvBBUruKviPEnWBwM7wnlCIeNKpLxf4ZLy1ELCYkb7jDRcDLbBdaSNNqhFPJvCCABhY fQbPYUdsUrl3FnuWyOKtPeoXSwK2ytcT4wfPjUXJb18BtOP1UHkmbrhj7fH2ZzPknX5C 8aYItpOv3VDhK2yaXaN6AkgFDgXQW8ILbSmPswp4mS/4dNAwrm4WK8JNthjp90Mn6LWH VSVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707230279; x=1707835079; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9NBgzZuNQ3XMEUB9jdo795d+Eu/PODGnrBF33YaDmlo=; b=aKfz2OH4w20BanPh8UN/eshMkCxfCAIA8lbJ0RpP5hhH/2sgpeDu/jCXqXnJ4tts0+ zMR73Zsdmb2P1MJEW7BPkuzr524cjeWVQ/lhCJ3Y2ifF8JlCUHAWZewrnrg3ANGVtelC 0KFE2/I11aSaZ67XJfQLl+mDdmcB6vz2SpB96jExIjmN8jUbFrPY1gJdbDp/3xOpEGgg X6Cw3TXci5vBewh5N/GE0baKRAM0ZMmEt9ph242KoY1ybNZvJ+dg5WNzr/wyUvD7njhA chlLpcywg42l7Ab2ofDN+EfFm+d0sF3hQvRrogURbEjhujA1mhdMtj8AgRXzK9E/ZFNS YRwg== X-Gm-Message-State: AOJu0YziKE5RTJkLdZbLDwn8qj9DRIwjZOVRVBCHfrWSwAiUfUiauVX/ fEmP+rR6FkRIJgKV9S3hk0zSgcvKgYQw4c40NUc+HZRQs2mFuV1XiSoZUbSj/L0= X-Google-Smtp-Source: AGHT+IGfDZNzDhZuGgrHFiDW0n00Aay00UsysXT9f8og4QdjPZfVrVGEK3zbMvScDpk7GfwUUzj0kw== X-Received: by 2002:a17:906:2e8c:b0:a37:b496:f0ab with SMTP id o12-20020a1709062e8c00b00a37b496f0abmr1833327eji.14.1707230278865; Tue, 06 Feb 2024 06:37:58 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXg8CxjHULLVpZPgZYWeojozwzAg92plTJtWd81a+UmkuTg8Qx3/8fQJBUIPRiYarOw0M/r2WrIaR3HQHuAV/Hx4TvqSIXWRy/pfYfrIN1sbHW5GF2QtBQOxtgDV6judqjqkCBjAllXbA43szdyaoJysbOJPfjXmu/SnFPi5IcitGSrbRMco1K4ouSinHqmemKn5L5H4mfA5sZAuu0XdtwwoDa037B7f8MY7GxcJ4aLYu2Fg4R31HygCq9LNxXuIePFzbANj4TJlfaoxKnpQaIxCDkoAuXab0E3XO8/h5i39vD4p5R3Efipux3/xxnfyTf5jmTLiO4EC/stLIqa5dm/H4/llKHxmPXulRSxsOrKhVE5ZhRUtE148PwUnBKN+mi0afsVBkpnZnyzGCMNilcpjeU7TN3I0lD5hPs3HBZpurQUX1iR Received: from blmsp.fritz.box ([2001:4091:a246:821e:6f3b:6b50:4762:8343]) by smtp.gmail.com with ESMTPSA id e22-20020a1709062c1600b00a37585d5dcesm1224418ejh.51.2024.02.06.06.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 06:37:58 -0800 (PST) From: Markus Schneider-Pargmann To: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , Santosh Shilimkar Cc: Andrew Davis , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH 1/4] nvmem: core: Read into buffers larger than data Date: Tue, 6 Feb 2024 15:37:08 +0100 Message-ID: <20240206143711.2410135-2-msp@baylibre.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240206143711.2410135-1-msp@baylibre.com> References: <20240206143711.2410135-1-msp@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The actual size that nvmem is using internally on a specific platform with a specific devicetree may not be known in the consumer code. The maximum size may be available at the same time. Allow the use of larger buffers in nvmem_cell_read_common() by setting buffers that are too large to zero before copying into them. Signed-off-by: Markus Schneider-Pargmann --- drivers/nvmem/core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 980123fb4dde..6fa061ede605 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -1806,12 +1806,14 @@ static int nvmem_cell_read_common(struct device *de= v, const char *cell_id, nvmem_cell_put(cell); return PTR_ERR(buf); } - if (len !=3D count) { + if (len > count) { kfree(buf); nvmem_cell_put(cell); return -EINVAL; + } else if (len < count) { + memset(val + len, 0, count - len); } - memcpy(val, buf, count); + memcpy(val, buf, len); kfree(buf); nvmem_cell_put(cell); =20 --=20 2.43.0 From nobody Sun Feb 8 22:05:29 2026 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A809238DFE for ; Tue, 6 Feb 2024 14:38:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707230283; cv=none; b=VBqBANGFpnwRscMdQ1ppPBbZGfN2OYCgTuzLnNvjIe5e1gGeMtnaRWg/MEjhIg3p4NNBDR2RGa8/fP0H4WWsicXj1TSiUR2fPfiCS02Uj1Yz+4Id6d6UwtMELBjbHy5CHZW5UD/zVbXg7tADOFxzTAKRXRqLGwuXTksm0sc+2Wc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707230283; c=relaxed/simple; bh=HO6KVEaHf/T7d9XWP5w/68iUgcAaz0HDcz/jMuokJ9Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hypwvVRJ0xAKqweRK9zqKSgsXEMhGiJX+aglMeMNC0qM63DgQ9KKsgkGTnZ7S4tnJ1tMP+Re4Az1khMelDarVzT7nHpYoNHF8VuN2efFybKQv8aCJ/TYHA+HS6iUGhHDirD8hqMqpCfhVjMAZ0M33mxd2t7Kt52OHqUPidnxMi0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=F5HaZh7r; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="F5HaZh7r" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a36126ee41eso719925166b.2 for ; Tue, 06 Feb 2024 06:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1707230280; x=1707835080; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MGo2FC7WYDd1/me+URO9ZglcapL0YwY+tHoSxOqlK5Q=; b=F5HaZh7rV77AxY79Qfo2D4Cf+bc6TPNq5udZI5pfaXFRgILHCQYQJgsAeHVJPWy/dY xw2XKilNBUxKGHR47MF/X5y0IVk7uNStKVcFfQ1YqXnJy4n8wCvTO3u7EZm+PNGQl8Al yH3CC3DdZuEMes2/r++1evXf2xPlAoGibe81SGBmk/Wiw3pbIG6QhPlz1rITx7BdrqXr Kaovwzif94lhOZTaVzqDrSqMdppNwcsP4P8IRQFDSuN2fM2EXjruBHKLilENcPw4E/30 QxiuQn1SAg1IKH0M6s3Rhyoqucg5i41iFFYIjiD/Ece9e4QaiIbApjyEPKoZbXjW0h3j DvXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707230280; x=1707835080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MGo2FC7WYDd1/me+URO9ZglcapL0YwY+tHoSxOqlK5Q=; b=Xafj58wsZPDIFn2SfTV8LWbnApgvEYPPafvXcQ7H9E9dOR/fgjqrm/jeHkhJ4gMu+t sloSejb+B83qt87iqS/3rL1gq3fcC2TzMOgnQLGPmFp6M7t8QYd+LLIPixo5RYG4yZEJ VJg/b6j+hOOGpP7fwYyUGoHq+EbEQyFcOxl8F0iUYIUMBNoDcQs2bhUd/1qrJb0jH7q5 /LlM1IQgMSBEP0Q5vd+Gc12WtYlAYoXiwrMAP8XLdnylfoIT2NvDyo/kvRfH4yTijkNG 7zz8X7lmCaNhkpl2gUF5t/kAUNbaUyB+OUPzHjAF57uRfjfzeSsBxZTZpNvLTa5P0y+9 86zg== X-Gm-Message-State: AOJu0Yx7DxQ8/GgLd5SqikHjg1ixc3prWKBktR6VgkpmdnAP79r9hlf9 OGeQt4yMk4uMSmuYCfpgNaJofWE9yKr3T1W4EKvvehlq0JTOGX0FdPCWWRXelic= X-Google-Smtp-Source: AGHT+IF7ec8YioOi3EaMdtpeBC/tpUFWxSwkWotQEzkbOgfiI46OKfwCr9u0v04m/mJCpsTEhBAYMw== X-Received: by 2002:a17:907:785a:b0:a37:ee9c:273e with SMTP id lb26-20020a170907785a00b00a37ee9c273emr1653077ejc.53.1707230279829; Tue, 06 Feb 2024 06:37:59 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUXWFMbNZogEPZ1ITtLgkoEB7IkPokqz7J5Zt/rg5GPnr0bIPNBNVMhc624wKDa5A4GCh+nu2y+4j91OIUDKBeYcPb763wn0zCzf+F+1dxkqRWMQuIiOsT+HjZQs2XzqnT/RtRe+fROtFviI8I5XsL1+TjoUyZX1Ppr+qEdbCTSHS51JvSSxdjpXj5b35O5pDmDdi9DBxL7bhAAhkTvQKLUWyAO+yxWzXa/uW+zRaPkRF2YYxXrEELv120fyFcSmARQQaWi/zJF5vUEqpqp+uiX8oGPqWNflVriBNezI0dGq6mIKRnXla7t2QQBQRANso9sMHj4/QHnXaKpSAZrLJmtjmY23JuV0kUOihwPSezjpdYHvOL5aQqw8GNNSXb6KfvypgWmTeVTpl0srxEFQPZzIrLq/PvdamOx/FZyRlDVzlMgfUla Received: from blmsp.fritz.box ([2001:4091:a246:821e:6f3b:6b50:4762:8343]) by smtp.gmail.com with ESMTPSA id e22-20020a1709062c1600b00a37585d5dcesm1224418ejh.51.2024.02.06.06.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 06:37:59 -0800 (PST) From: Markus Schneider-Pargmann To: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , Santosh Shilimkar Cc: Andrew Davis , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH 2/4] dt-bindings: hwinfo: ti,k3-socinfo: Add nvmem-cells Date: Tue, 6 Feb 2024 15:37:09 +0100 Message-ID: <20240206143711.2410135-3-msp@baylibre.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240206143711.2410135-1-msp@baylibre.com> References: <20240206143711.2410135-1-msp@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The information k3-socinfo requires is stored in an efuse area. This area is required by other devices/drivers as well, so using nvmem-cells can be a cleaner way to describe which information are used. If nvmem-cells are supplied, the address range is not required. Cells chipvariant, chippartno and chipmanufacturer are introduced to cover all required information. Signed-off-by: Markus Schneider-Pargmann Reviewed-by: Andrew Davis --- .../bindings/hwinfo/ti,k3-socinfo.yaml | 23 ++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/hwinfo/ti,k3-socinfo.yaml b/= Documentation/devicetree/bindings/hwinfo/ti,k3-socinfo.yaml index dada28b47ea0..f085b7275b7d 100644 --- a/Documentation/devicetree/bindings/hwinfo/ti,k3-socinfo.yaml +++ b/Documentation/devicetree/bindings/hwinfo/ti,k3-socinfo.yaml @@ -26,9 +26,24 @@ properties: reg: maxItems: 1 =20 + nvmem-cells: + $ref: /schemas/types.yaml#/definitions/phandle-array + + nvmem-cell-names: + items: + - const: chipvariant + - const: chippartno + - const: chipmanufacturer + required: - compatible - - reg + +oneOf: + - required: + - reg + - required: + - nvmem-cells + - nvmem-cell-names =20 additionalProperties: false =20 @@ -38,3 +53,9 @@ examples: compatible =3D "ti,am654-chipid"; reg =3D <0x43000014 0x4>; }; + - | + chipid: chipid@14 { + compatible =3D "ti,am654-chipid"; + nvmem-cells =3D <&chip_variant>, <&chip_partno>, <&chip_manufactur= er>; + nvmem-cell-names =3D "chipvariant", "chippartno", "chipmanufacture= r"; + }; --=20 2.43.0 From nobody Sun Feb 8 22:05:29 2026 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2245132C39 for ; Tue, 6 Feb 2024 14:38:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707230284; cv=none; b=rcR9qKx7qbtVtXk8P7W6DjLXNMggrqtK++xT6r6sNLz27TVf4c9ZRMNhKpAfi0uEmElJsbSW9JE4jUcqFpb7OpaGadMFaME+GEONNeHTLv6KF2F+7g5yX5Y0J4BEHn4Je1/IrEVuGwMySwQ+8L7xzaCgwJwOiYpikhQezIaAjfQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707230284; c=relaxed/simple; bh=JSA+JTxZwyy4vGSW5/N+RDxQNtaOg/Fg9ZTWoKkSIvc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E+ar8OTcENLCKvEgj4wWaOzGWbaHNlyIoroiZw6ShCtqTTZ+0+IXfERX9VJ33PZY2FyoEgMqGsO+eH7aZJlvuYpoCrV6+FeqKcFkKPENZikngjXULmDvLrHYgn5OBIHeWFkdTpjqI9I6fSi68K90c3mOwMg3m1ERKxqHOYDHS/c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=pIO21g6D; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="pIO21g6D" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-51025cafb51so8430704e87.2 for ; Tue, 06 Feb 2024 06:38:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1707230281; x=1707835081; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2W+bhvv0j8yck+8GT/uP++ViHHwBweYBoHrSumeE15A=; b=pIO21g6DwTfnp6YimaXLBSBWFgadK8O8cYB0d+aV717JRS0dMUkeLY2zox8sO4Gikd a3gaHeV1QQTrGP2AcfTR8B9IU4geZoY/Lac0et8y0FhojuOxTqY2U5gCGsIZaJc/XQU2 wlIRmZ7hj6riSBhLSNaC3NN0MWYk/UuYC9u0lp64r2+cU0lMKBobusfCy9NVUYR6I1qa vbeZJGsd4Zd4RgRArCfWuo5JKhLqx/kxYUVHDkiGGO/y1zclvEkYmiHAqnVch2YQxrLX V1fSEbwI6zxztIb4obKvK8mtDBKPP3NreSCrrGL19ZOlNE5lsOXIeGUwvPKvuPNM+JuQ Kd4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707230281; x=1707835081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2W+bhvv0j8yck+8GT/uP++ViHHwBweYBoHrSumeE15A=; b=A3KUqDh0UUFLDwk4T87JTibf8eMV1o9lkAk0NSXGiIETyvqROXKiLsP9l+g2o9qKQl 4RiNRRPTLyIATbKvUn2huyU4hd1WsEAQ8VrurQ71NQBPMrf3Pvr6ITCp195d1ttCJhri fR1bVERHKQPj9NFM70fehufJsDPgEKF5ojZHaqfHcSb+leVd4gLYEaYuhNs7jmsw8swc yXOpQXbGUlyuE7lEV6bc7OyKpyUzIeeylxaN48spnlGkXCU5YsUatoPB4WN+Qj/Keb4l HESmijJq0qT3B7rhQdJmEd+q+i91kYsw8iFDOLT9FoXOa4LrBXcj/HVdLMsYdTjxpcPB Z9Jg== X-Gm-Message-State: AOJu0YzBET5DDOj1qFD7Bbh5xqhhuSRchp82H5PdDy5QOHRTO/KfNtxf ZX9kQhyYEjsV8PMdH08+w6srDB5Ak7j9XPMAFUBqMvR/hYVmouMw4u8Y63CtQNw= X-Google-Smtp-Source: AGHT+IFq40p5PGRZgK2PDID88ekIhXGdOYju/iR3pvUeF7F3dzHYw/J6u+QgBb2DegU7Af/HkHjnCw== X-Received: by 2002:a05:6512:31c7:b0:511:54e8:b82e with SMTP id j7-20020a05651231c700b0051154e8b82emr2165876lfe.47.1707230280818; Tue, 06 Feb 2024 06:38:00 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWA4bduWkPXsrwXkvP0AHmjMJ9kVUsar3ZVfJ6PAFzztWBt2XGLA/HzTQ6kKQA2T2M0Vz3Tvtm9r4I1EInMLHaOwmsXzoXCHER82pTbiprCITW7TUc/O+baBK0j3xcC7EgLztJSgxkqxbKHFq42s2O8XnO9xWIfiJws9S1IRFCGb4LeYD+TNSOpTtuEihJAiPrWAGEWgcn7PhGGQdOKheWHIJGGHxMkc5hLlbr/3X0TWkGLbIlFkJrSu6f+vWYZ1sbX/ZWiJB1grXNb2xwWroT1eR2lN0WY5o3Wd/fPj2NOePxj572MJUiNU6PI1Gf/ASEYH14JsZRfsyHelKP/KFfKkT0QHAlPKTK3xJBcwbsWiRFeN0UVsm7riXT/P8shLWjTVmssYHVIJJIObse8UfoeZyNuMXBQCLHsQxUbkTXlUB4jjQb8 Received: from blmsp.fritz.box ([2001:4091:a246:821e:6f3b:6b50:4762:8343]) by smtp.gmail.com with ESMTPSA id e22-20020a1709062c1600b00a37585d5dcesm1224418ejh.51.2024.02.06.06.37.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 06:38:00 -0800 (PST) From: Markus Schneider-Pargmann To: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , Santosh Shilimkar Cc: Andrew Davis , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH 3/4] soc: ti: k3-socinfo: Add support for nvmem cells Date: Tue, 6 Feb 2024 15:37:10 +0100 Message-ID: <20240206143711.2410135-4-msp@baylibre.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240206143711.2410135-1-msp@baylibre.com> References: <20240206143711.2410135-1-msp@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Support nvmem cells to retrieve chip variant, part number and manufacturer. As multiple different devices depend on these information it is cleaner to abstract efuse fields with nvmem cells. If chipvariant nvmem cell is found, the driver assumes nvmem cells are being used and tries to find the other fields as well. If it can't find 'chipvariant' it will try to create a regmap. Some prints had to be updated as I don't read the full jtagid anymore. Signed-off-by: Markus Schneider-Pargmann Acked-by: Andrew Davis --- drivers/soc/ti/k3-socinfo.c | 67 +++++++++++++++++++++++++------------ 1 file changed, 46 insertions(+), 21 deletions(-) diff --git a/drivers/soc/ti/k3-socinfo.c b/drivers/soc/ti/k3-socinfo.c index 59101bf7cf23..99794aeb6206 100644 --- a/drivers/soc/ti/k3-socinfo.c +++ b/drivers/soc/ti/k3-socinfo.c @@ -6,6 +6,7 @@ */ =20 #include +#include #include #include #include @@ -114,45 +115,68 @@ static int k3_chipinfo_probe(struct platform_device *= pdev) struct regmap *regmap; u32 partno_id; u32 variant; - u32 jtag_id; u32 mfg; int ret; =20 - regmap =3D device_node_to_regmap(node); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D regmap_read(regmap, CTRLMMR_WKUP_JTAGID_REG, &jtag_id); - if (ret < 0) - return ret; - - mfg =3D (jtag_id & CTRLMMR_WKUP_JTAGID_MFG_MASK) >> - CTRLMMR_WKUP_JTAGID_MFG_SHIFT; + ret =3D nvmem_cell_read_u32(dev, "chipvariant", &variant); + if (ret && ret !=3D -ENOENT) + return dev_err_probe(dev, ret, + "Failed to read nvmem cell 'chipvariant': %pe", + ERR_PTR(ret)); + + if (ret !=3D -ENOENT) { + ret =3D nvmem_cell_read_u32(dev, "chippartno", &partno_id); + if (ret) + return dev_err_probe(dev, ret, + "Failed to read nvmem cell 'chippartno': %pe", + ERR_PTR(ret)); + + ret =3D nvmem_cell_read_u32(dev, "chipmanufacturer", &mfg); + if (ret) + return dev_err_probe(dev, ret, + "Failed to read nvmem cell 'chipmanufacturer': %pe", + ERR_PTR(ret)); + } else { + u32 jtag_id; + + regmap =3D device_node_to_regmap(node); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); + + ret =3D regmap_read(regmap, CTRLMMR_WKUP_JTAGID_REG, &jtag_id); + if (ret < 0) + return ret; + + mfg =3D (jtag_id & CTRLMMR_WKUP_JTAGID_MFG_MASK) >> + CTRLMMR_WKUP_JTAGID_MFG_SHIFT; + + variant =3D (jtag_id & CTRLMMR_WKUP_JTAGID_VARIANT_MASK) >> + CTRLMMR_WKUP_JTAGID_VARIANT_SHIFT; + + partno_id =3D (jtag_id & CTRLMMR_WKUP_JTAGID_PARTNO_MASK) >> + CTRLMMR_WKUP_JTAGID_PARTNO_SHIFT; + } =20 if (mfg !=3D CTRLMMR_WKUP_JTAGID_MFG_TI) { dev_err(dev, "Invalid MFG SoC\n"); return -ENODEV; } =20 - variant =3D (jtag_id & CTRLMMR_WKUP_JTAGID_VARIANT_MASK) >> - CTRLMMR_WKUP_JTAGID_VARIANT_SHIFT; - - partno_id =3D (jtag_id & CTRLMMR_WKUP_JTAGID_PARTNO_MASK) >> - CTRLMMR_WKUP_JTAGID_PARTNO_SHIFT; - soc_dev_attr =3D kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL); if (!soc_dev_attr) return -ENOMEM; =20 ret =3D k3_chipinfo_partno_to_names(partno_id, soc_dev_attr); if (ret) { - dev_err(dev, "Unknown SoC JTAGID[0x%08X]: %d\n", jtag_id, ret); + dev_err(dev, "Unknown SoC JTAGID[variant=3D0x%X, partno=3D0x%X]: %d\n", + variant, partno_id, ret); goto err; } =20 ret =3D k3_chipinfo_variant_to_sr(partno_id, variant, soc_dev_attr); if (ret) { - dev_err(dev, "Unknown SoC SR[0x%08X]: %d\n", jtag_id, ret); + dev_err(dev, "Unknown SoC SR[variant=3D0x%X, partno=3D0x%X]: %d\n", + variant, partno_id, ret); goto err; } =20 @@ -166,9 +190,10 @@ static int k3_chipinfo_probe(struct platform_device *p= dev) goto err_free_rev; } =20 - dev_info(dev, "Family:%s rev:%s JTAGID[0x%08x] Detected\n", + dev_info(dev, "Family:%s rev:%s JTAGID[variant=3D0x%X, partno=3D0x%X] Det= ected\n", soc_dev_attr->family, - soc_dev_attr->revision, jtag_id); + soc_dev_attr->revision, + variant, partno_id); =20 return 0; =20 --=20 2.43.0 From nobody Sun Feb 8 22:05:29 2026 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EFF912D157 for ; Tue, 6 Feb 2024 14:38:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707230285; cv=none; b=YmccoXWTHYW/Xy9VDIVN32qr/lb+71wvapJEd8M/0vJikzSPWvxmwJiTuQr6Flf8S5ciRYs/nuLq47uZgmPUJZKe4AzWGPsh4PIz1lpNbeKp7ZLnJ+A84URIaQmNsFAc/NJ1fOkUsCRpgYtggdMhzFuN3AYYEOaZjCPXwNwVwtw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707230285; c=relaxed/simple; bh=f/2cueG3Db+hUw8yHz3480LbSCbMp3PrxDGJJ7LSl0E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ry7DO01fiYCWRlBgB7M5JJGXulue51Ck9UnPksaLgl3Vvh4IChPcFANLU2N/RmW/A1lvEnvU0xBKb2WNn2N93e+FwwfyjwUqTzJO+vjdpKiIjpRrdOMkBBSi5WgAK1ZzRRgkjwVoYE9WFqomM0GZvS4Zgzo7A+EW9z5D72pZhYg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=jBmxg05D; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="jBmxg05D" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a384a7e6103so30326666b.1 for ; Tue, 06 Feb 2024 06:38:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1707230282; x=1707835082; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mF/Kh9xpZHCKBcFBIr8xXoDa+aUxtWpcGMnQGhXMLkY=; b=jBmxg05Dm5E3NktloA/xRoS5uZ4xl9neYw7iVqBflK4DDvmOBKVQbeyaYJr+mG/F2C VqrZ6wukyCEE0Xmbw7Zye7P0LJHoTdQRhDJ1AxyFrS1ExZtBGR3uxR8a6RkNOYkBR9UL BzoWeaSsAVH89tnU+zlM+Mteu41EqGXtY2urXDE5Nzav4KVEExQ4U3K/IONgYw972l1j TvZWESFtxEg5EN1S1v/j0uiG4Kh6Y9mTVAFqe6lZIkBqpOBYM8FMXLuSn0tkacD0YUiL RBJxjHkTSez4RBHVdc40CDoXffC+bRNMrvAvhN5jdL5rN6wgejQ1GunvUh3vy2mfYhqc IVog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707230282; x=1707835082; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mF/Kh9xpZHCKBcFBIr8xXoDa+aUxtWpcGMnQGhXMLkY=; b=lJXFp7SmgKE9SsaXb9ZV9uR9044NbeZ2su7GSZYwRgKECzTPnpA6iwl+9QmCgPPUgj vSKJiEsukddNYbchwizedkX/U4EueM/ZrVRu2d4tiqDiAK59IMEId+bBqtI2t1cFDWX+ CYSseem9GS3siwgdWfyB0gWbzB5tLBtvmd9HrZXyBXcaBhbURy4NtZXGKo5uljAUppBk XIpmx1c6osgFVDBQSwF8a0zGNKT6Hno7srUbGDetaAvhZ16Zbvx371rVYbVuK3zTOczl 0Fc+x+TtCI9WimnQ/1l5b2p5WGaEJtpOF34fbF6gt/GJS+J4mC1GfhuQZkBUAxo1iz7X MCSg== X-Gm-Message-State: AOJu0YxTs1olcHFRx+eXncMZaQfq6WhT0Q2o7FCMaU1AvpuYwlhe2zel AVzYCtIch2gBt9OJ4P03R+DrJcD5PZntStIlr8sRtpq34KyNx4UWSNsxbDA3Ulo= X-Google-Smtp-Source: AGHT+IHZfXlRztOFWyUn+W5rBXN6rG8fTnzJ55i3wn/3ulNLFu5Yebta9oiXtBwhzBua28ZaBdpg+g== X-Received: by 2002:a17:906:3153:b0:a38:52f0:4c49 with SMTP id e19-20020a170906315300b00a3852f04c49mr62055eje.64.1707230281826; Tue, 06 Feb 2024 06:38:01 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWF7Gbu3yiSZnF1ETXTHDiJ8j6rUVsH9sOiCmFo5k2yFXDoldLJ1izSQQaA9RXmZZmNp+qLlULjPfXHqm7ogWNcOZLhw4IC9HCMNsX46i+jfx322iexmcNPklL+RqQP9Rg/+jCY4jPJa0TVRmAQk2YWTarNeFdv26AMZgPkx4hORRzSNXMUqjRxJj51rLnsFUTcF9w9laW/S33d8koZvlJiQIT+W3XrF9B0vtMhIkEg6D0Op46FxUbc1MxMn7JZC25/a3IUxGGhj0iUNaEywe0KGk1UTlKXXIETHfBKfPV/+fSkJOXrwU20C+2qsMDmEEK2+e37VY6obU7yaYO3/1PcWC0hhSX69LkUoGujCEpVGA77Zg3NkL0f7o289CNaocrofjeVb0PQ4oYTGI9EI/dKhbUTmMIlVXXMWUEZ510E+j1M78VE Received: from blmsp.fritz.box ([2001:4091:a246:821e:6f3b:6b50:4762:8343]) by smtp.gmail.com with ESMTPSA id e22-20020a1709062c1600b00a37585d5dcesm1224418ejh.51.2024.02.06.06.38.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 06:38:01 -0800 (PST) From: Markus Schneider-Pargmann To: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , Santosh Shilimkar Cc: Andrew Davis , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH 4/4] arm64: dts: ti: k3-am62-wakeup: Add chip efuse nodes Date: Tue, 6 Feb 2024 15:37:11 +0100 Message-ID: <20240206143711.2410135-5-msp@baylibre.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240206143711.2410135-1-msp@baylibre.com> References: <20240206143711.2410135-1-msp@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add efuse nodes describing chip variant and speed grade. Signed-off-by: Markus Schneider-Pargmann --- arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 36 +++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi b/arch/arm64/boot/d= ts/ti/k3-am62-wakeup.dtsi index fef76f52a52e..14419df43624 100644 --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi @@ -14,10 +14,44 @@ wkup_conf: syscon@43000000 { #size-cells =3D <1>; ranges =3D <0x0 0x00 0x43000000 0x20000>; =20 + wkup_efuse: efuse@0 { + compatible =3D "socionext,uniphier-efuse"; + #address-cells =3D <1>; + #size-cells =3D <1>; + reg =3D <0x0 0x200>; + + nvmem-layout { + compatible =3D "fixed-layout"; + #address-cells =3D <1>; + #size-cells =3D <1>; + + chip_manufacturer: jtagidmfg@14 { + reg =3D <0x14 0x2>; + bits =3D <1 11>; + }; + + chip_partno: jtagidpartno@15 { + reg =3D <0x15 0x3>; + bits =3D <4 16>; + }; + + chip_variant: jtagidvariant@17 { + reg =3D <0x17 0x1>; + bits =3D <4 4>; + }; + + chip_speed: jtaguseridspeed@18 { + reg =3D <0x18 0x4>; + bits =3D <6 5>; + }; + }; + }; + chipid: chipid@14 { bootph-all; compatible =3D "ti,am654-chipid"; - reg =3D <0x14 0x4>; + nvmem-cells =3D <&chip_variant>, <&chip_partno>, <&chip_manufacturer>; + nvmem-cell-names =3D "chipvariant", "chippartno", "chipmanufacturer"; }; }; =20 --=20 2.43.0