From nobody Mon Feb 9 22:59:50 2026 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B70612BEBE; Tue, 6 Feb 2024 08:37:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.191 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707208652; cv=none; b=WFsajuHjMuhVWkMcCmrDyPoRxvtk/shGX+pS9OcnGDI+EMzFfOXaBUC1V1p+cPfO7a8TcIaG4OfL8gSBXz4ShaoFJ5Ubkjl9GnpJVXVnv7avXpE92/GeK4cDaz4uHfiTuUiYo/Eg7dD0UmY2nI19EPF7pUCZrKgGnG/nCRDju0U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707208652; c=relaxed/simple; bh=pGKy0/JDwlucTovijWCK5UFwzkM9x2dYOV+LQPogVlE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RCXn07qZuEphKfM+R1NA2e1tLYlDFB64XKhkXxhahP8K9iL5BbqIqT9j2BgYfb66h1Ju9vuxsGzeeqZbLxZ6P6+BuOtLwOmfaMX+AoqLKdZGO3j7Mt6GsygWA9dY0TAT32Jhr79MBmJFx5jjLlfWoy1J7/qjVzmpCtOoN2uWfmc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4TTc2C5FVdz1FKN3; Tue, 6 Feb 2024 16:32:51 +0800 (CST) Received: from kwepemm600003.china.huawei.com (unknown [7.193.23.202]) by mail.maildlp.com (Postfix) with ESMTPS id 2E5791A0178; Tue, 6 Feb 2024 16:37:27 +0800 (CST) Received: from ubuntu2204.huawei.com (10.67.174.22) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 6 Feb 2024 16:37:26 +0800 From: Yang Jihong To: , , , , , , , , , , CC: Subject: [PATCH v2 3/5] perf sched: Move curr_thread initialization to perf_sched__map() Date: Tue, 6 Feb 2024 08:32:26 +0000 Message-ID: <20240206083228.172607-4-yangjihong1@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240206083228.172607-1-yangjihong1@huawei.com> References: <20240206083228.172607-1-yangjihong1@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600003.china.huawei.com (7.193.23.202) Content-Type: text/plain; charset="utf-8" The curr_thread is used only for the 'perf sched map'. Put initialization in perf_sched__map() to reduce unnecessary actions in other commands. Simple functional testing: # perf sched record perf bench sched messaging # Running 'sched/messaging' benchmark: # 20 sender and receiver processes per group # 10 groups =3D=3D 400 processes run Total time: 0.197 [sec] [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 15.526 MB perf.data (140095 samples) ] # perf sched map *A0 45126= 4.532445 secs A0 =3D> migration/0:15 *. 45126= 4.532468 secs . =3D> swapper:0 . *B0 45126= 4.532537 secs B0 =3D> migration/1:21 . *. 45126= 4.532560 secs . . *C0 45126= 4.532644 secs C0 =3D> migration/2:27 . . *. 45126= 4.532668 secs . . . *D0 45126= 4.532753 secs D0 =3D> migration/3:33 . . . *. 45126= 4.532778 secs . . . . *E0 45126= 4.532861 secs E0 =3D> migration/4:39 . . . . *. 45126= 4.532886 secs . . . . . *F0 45126= 4.532973 secs F0 =3D> migration/5:45 A7 A7 A7 A7 A7 *A7 . . . . . . . . . . 45126= 4.790785 secs A7 A7 A7 A7 A7 A7 *A7 . . . . . . . . . 45126= 4.790858 secs A7 A7 A7 A7 A7 A7 A7 *A7 . . . . . . . . 45126= 4.790934 secs A7 A7 A7 A7 A7 A7 A7 A7 *A7 . . . . . . . 45126= 4.791004 secs A7 A7 A7 A7 A7 A7 A7 A7 A7 *A7 . . . . . . 45126= 4.791075 secs A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 *A7 . . . . . 45126= 4.791143 secs A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 *A7 . . . . 45126= 4.791232 secs A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 *A7 . . . 45126= 4.791336 secs A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 *A7 . . 45126= 4.791407 secs A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 *A7 . 45126= 4.791484 secs A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 A7 *A7 45126= 4.791553 secs # echo $? 0 Signed-off-by: Yang Jihong --- tools/perf/builtin-sched.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c index 1513e87ce4f2..b56a573ed06c 100644 --- a/tools/perf/builtin-sched.c +++ b/tools/perf/builtin-sched.c @@ -3266,9 +3266,13 @@ static int perf_sched__map(struct perf_sched *sched) { int rc =3D -1; =20 - if (setup_map_cpus(sched)) + sched->curr_thread =3D calloc(MAX_CPUS, sizeof(*(sched->curr_thread))); + if (!sched->curr_thread) return rc; =20 + if (setup_map_cpus(sched)) + goto out_free_curr_thread; + if (setup_color_pids(sched)) goto out_put_map_cpus; =20 @@ -3291,6 +3295,9 @@ static int perf_sched__map(struct perf_sched *sched) out_put_map_cpus: zfree(&sched->map.comp_cpus); perf_cpu_map__put(sched->map.cpus); + +out_free_curr_thread: + zfree(&sched->curr_thread); return rc; } =20 @@ -3576,11 +3583,6 @@ int cmd_sched(int argc, const char **argv) unsigned int i; int ret =3D 0; =20 - sched.curr_thread =3D calloc(MAX_CPUS, sizeof(*sched.curr_thread)); - if (!sched.curr_thread) { - ret =3D -ENOMEM; - goto out; - } sched.cpu_last_switched =3D calloc(MAX_CPUS, sizeof(*sched.cpu_last_switc= hed)); if (!sched.cpu_last_switched) { ret =3D -ENOMEM; @@ -3662,7 +3664,6 @@ int cmd_sched(int argc, const char **argv) out: free(sched.curr_pid); free(sched.cpu_last_switched); - free(sched.curr_thread); =20 return ret; } --=20 2.34.1