From nobody Sat Feb 7 08:23:10 2026 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2075.outbound.protection.outlook.com [40.107.7.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB7DA4F5F7; Mon, 5 Feb 2024 23:34:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.7.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707176052; cv=fail; b=lDvM+LSrpioG0zsi6JQMzup/1sIO77mGWsmfuSo/rqHx+LAbDu295soyN192kilw4quqJ2zwH/eFjSZnxu4J3dBbcu9+oe7bw4ruFLplCp9yhrrL1hTXEALv1va9wrcE/wGnYq+NEdTHCdh1DlikH2L/sftW0nhYjXSiimvtWhA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707176052; c=relaxed/simple; bh=9VaJz0jV8iISR9bDLARjvoM0gfP0uJSGwpX9bwu8e3A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=GSePkZrFWsEj/mVwXQ55ZfTEPJXv+VZyY3wP9s6OMFugfFUHrce3dG5cES/WrzNMxVsa4D1C8eiYox3qLEJ1jlSWUAX9CUvrOHVu0di1KrqYFESpEbwqIMWLlMx8+mYf2ivJ2dnkvQVAYdg0ATNXldLuQJZdj2Dzk0upYQ7eIDc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=mzHqe6Oz; arc=fail smtp.client-ip=40.107.7.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="mzHqe6Oz" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FBalsepZqocGRwsKUBScEKbjO3Wpq2L5WI08IuoKht+lawVmX9w6Sw1ytE4ejvjmVFvdn0yyLmNWfKz9zoeSkF2pHsJDVgWN2MNzvMilOMUTr/eh0NVkwd4TgECnPRnPHq4JVhZSl/mVHT5NwIQm56kGSuwAQ2liOBuhIwfrv4GJKFbkA35K5h4ER4SkkTElCxw0f8ABPMETE+tzXIaU6X/e8PNaRgG9qFObjK5txuX4HoYu3Yrne/pF73iJCt/YKukGNlsJP5q/5Hb/Li4NIH/F6+x9CmVhB4Ln05J6AaRCtfP2bGiGVzzyV12J52c87WPnnoIoJVyIm0Rm27c23Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QESR9L6t6O0yzNn/IrZAQybUKtJ6125WOFbicGq+1AM=; b=N2VMWO7cFYFnRCDorm26iqMED4meM54VuZRtL7ukB5MWL3W/ULos/99zuHse1qNrjPSmba0oAeLUV+O2pDSLn8i/Wng21uATdvXUZJjqfrWU495dxC622Erx8Sr2hpbs8qSmsIPDDiFvummgzz9ydQFrBALmLFOFEbJEzfI/HGWJd2j3SLUxuC582CA6OdP1C4mT/2IfEbQsmmJN1ioUmLzWzOz+qWIjPqAuwPRdppk+G4hnot2gbsVivfncGp1O7oYiZqm1nrLPNd2l/zoeBZdQYsF7Py22m1v4AyX1SIrvE9TUJPcExY5pCfBmrdNM0/g4cjpksZtZYJ1wU8cxZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QESR9L6t6O0yzNn/IrZAQybUKtJ6125WOFbicGq+1AM=; b=mzHqe6OzBKRWUNgDCC1TOBuAtPsOeQNnW+DZDhYfLp3yH2oAIKhonUbwD2kRO6ZgERfEBE5jGmR7nDEU47MxLn3geuO0h/Iuvaq/vEcVkV6Y8HhKRq5qqXLomHN39TfFLkQOEXD7U3BFxlkj9hy13jVdury/X5z+dyjNptwWeOA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AS8PR04MB9205.eurprd04.prod.outlook.com (2603:10a6:20b:44c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.34; Mon, 5 Feb 2024 23:34:03 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::c8b4:5648:8948:e85c]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::c8b4:5648:8948:e85c%3]) with mapi id 15.20.7249.032; Mon, 5 Feb 2024 23:34:03 +0000 From: Frank Li To: frank.li@nxp.com Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, ilpo.jarvinen@linux.intel.com, imx@lists.linux.dev, jirislaby@kernel.org, joe@perches.com, krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, miquel.raynal@bootlin.com, robh@kernel.org, zbigniew.lukwinski@linux.intel.com Subject: [PATCH v7 5/8] i3c: target: add svc target controller support Date: Mon, 5 Feb 2024 18:33:23 -0500 Message-Id: <20240205233326.552576-6-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240205233326.552576-1-Frank.Li@nxp.com> References: <20240205233326.552576-1-Frank.Li@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BYAPR02CA0005.namprd02.prod.outlook.com (2603:10b6:a02:ee::18) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AS8PR04MB9205:EE_ X-MS-Office365-Filtering-Correlation-Id: 557e897a-40d4-4bff-3041-08dc26a2f027 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AkYQ5duw2PU3JQSJYtUfZscb9irlYo6tpyVhg1aee1YF0hd25WcLiMb0ppRHOKylUWQNYjBtAUFQNKR2scE6wkUhyy9dsyiPybnazEvZ8qJGlOayiDCRzPTpMlwS/dZSZv247/H1eIxKRCWJNXLtRhimikecJa1KjhD5/fe7UoponRQWBtJfgmvgJMDq5rihzw8xA4/YKQBF8na1rj3JxLri7qJ8gk/4k5dA4oTkm8AJ5p/tKY6hRucqc7IgAVt9ThwqC2BO5w73kHb3+krteOl/5N+wJxCkIcjggoXQvCWd/aYKmFe6Bt25r6JRKipPY1562GcldqOFh/JyEVCZt4aTF0iJ1dQgWWVbHkS6lGsSw+/EtmIce7ZMt7V9vC49qEAbtUFlhEhB5DMoxJZZapTty889/fgnzYILpqdPuSZHU7r29LSKNtygKYJ12qcpvzrYW+ntISvLxbr0Ehpa9LA7boSSPugWjPBNSXz0bUl9jR6jQRKFEIQJ2KEj7IaBl+eFCqDwbYOxo+9Ki4aoWoR6FVzohPTEFSesGeyVyWDn/K0A6112K9RVrjVwIL/eUrv5Mk296ZEy6Nh9gBeMKtfJFyAXTDZr3+sRw40ykJ0vK2GTtktvwEWzCTnebplO X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(136003)(346002)(396003)(376002)(366004)(230273577357003)(230922051799003)(186009)(451199024)(1800799012)(64100799003)(1076003)(2616005)(26005)(86362001)(41300700001)(7416002)(30864003)(6486002)(5660300002)(2906002)(38350700005)(316002)(37006003)(66476007)(66556008)(66946007)(478600001)(8676002)(34206002)(4326008)(8936002)(36756003)(6512007)(6506007)(52116002)(6666004)(38100700002)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?r9+qcoyJKxcV05GUknaVOjSINgo7Dz5OtPKd+lgaF7L3gHNVGShVnTvjY69Z?= =?us-ascii?Q?WlI0Nt3HnJgnldx6nO7GRfyEl/gbIEjhhJ9xyImqiREFEkcvSyLLVE8NjaLR?= =?us-ascii?Q?jP1E1FdSZ4JWBZFijpdllangOLSvtSBOTYTKJMLLm5bVtfalQ7QEPhZ5BUPh?= =?us-ascii?Q?ko7OqD1FoUTJh/plYeKeVKvH7C/jozljQdMNsbUGUE9v77JvxhHm1qwGzPKu?= =?us-ascii?Q?H10JIWs6wjn1V1hpcfz2sMPnv2tJst9UpfAMra5RvJpBS1WixOH+S9LArT/M?= =?us-ascii?Q?H5E28ELn436wyC23MLoyLPbXEqEaPLX8+nLkbG4WZxovq3m5ps27dZqKCK0I?= =?us-ascii?Q?R1cnrtg+iRr88mGWeXBU7cNc3s3nv8/tOCdlVneTr+KqYqrHfF1srXOC79sB?= =?us-ascii?Q?OSj/RCQgaf9GOzQOc12ujDiaRt4P3KfZI8nAlwuq8plz4AmixAMH2w7Jl5np?= =?us-ascii?Q?Rxg0as70XoS1XgYngX/QmydK3el5kACfC6zmHx6D5Gq3JHRH5PfRVJFRvxbq?= =?us-ascii?Q?/Ors6kX819ip4J+RXJsdwM9J6rDLtTrbnc/1nO4HIC7zNuOlTjaugF23Rj/Z?= =?us-ascii?Q?q6IlQ+8PxLWdMiOM2Cx1xDDhcnk0x1I0Lq4K/mJ0gFXlWGPmvZ3lTXWPTQ8P?= =?us-ascii?Q?IT64leDpywz5u45N/cUQzEB3DNfGjj/91QylAqRtabXgEyRmSFcXfYBxXwIu?= =?us-ascii?Q?mI0ahKr/tosjdVG3MGkclJJZvIrGvZ+bJLzSejFRpIAipRo2U87ieGP41vWQ?= =?us-ascii?Q?HO1xssgO0eRRXyG27BpT2ZYqrJLP1Y57vE9IQijt4faMBXqUJKOlcB3/lVT/?= =?us-ascii?Q?fgsuMr05gKUr0mKkqQVCFZGGbCUT3F+eQuALCE/eSftV2hK/rD28Kqtsa+tn?= =?us-ascii?Q?/HoB5T7Haee9xCmPTwl4QXzHp3bQMAdM3Z3tFvLgyUD1vYf8CL+km/K4wsn5?= =?us-ascii?Q?+NbnWux/Hph2TCupUhVoZw3A9kCMa6yp08TbYhSEtMCFF9ktG9R9a28KDtiw?= =?us-ascii?Q?689X6lAS5+9noL/CKyxzxhQoQktOGCuH1Lnn7vdX1fwqNSeekj5dDvO/W46C?= =?us-ascii?Q?9tmOjufoydFq4jjk2/2eXPjmYxA/JG2izqdTAPM1Ei0P6RJOlH4th17Yi48C?= =?us-ascii?Q?BuoLNnUDQln1xM3tXxE0p0TVHcQ3ryYupwgJMn9hFWmcUIPLRg2jbJCYhnuy?= =?us-ascii?Q?ah2sP4R4x7ImZee9DwCy6nJke2GsOkUD+xx0HMygraHiibInrfhBi7l6i4kc?= =?us-ascii?Q?pkFa2hjNlOSBq/E/Dy7oTqLlAwzhS3/J5ss6pr0rasi2M3tvb25/jmcVtLMd?= =?us-ascii?Q?Rv4wxlwjf+sB+2uUpdlQZl4w04t6OUqUK8n321cq51gFgtm6SoFt9qzpssIg?= =?us-ascii?Q?3B6UMYq0lfNYycO6gFJ8hZxEW3WFaLyHm8sZmSa7WYgc31/JQ0ut+gCGrM4H?= =?us-ascii?Q?HU4JACQOMUI2UU3IMi+uz75lwEmhVoNAPYsYphyqeGDvrt9A87p8y1PAo4Nn?= =?us-ascii?Q?xWogjRboHjxARBmm1bVWpe+b8PfcIar0494yjtL2r7W1eICuEaLxABSMmALu?= =?us-ascii?Q?EbtUnAflC3LCwS6PN/XKUCl6Z/Xm8a+/83xQlkvi?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 557e897a-40d4-4bff-3041-08dc26a2f027 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 23:34:03.8126 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qoDIavn1/3Dc/cDckNQU+tRSWZ2ttCtfQ0Ak3ZvDydX5mdVkFGRHL40eC2nw7VwHtcuj9qq88pSwM/vlrWlogQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9205 Content-Type: text/plain; charset="utf-8" Add Silvaco I3C target controller support Signed-off-by: Frank Li --- Notes: Change from v2 to v3 - fix build warning drivers/i3c/master/Makefile | 2 +- drivers/i3c/master/svc-i3c-main.c | 35 +- drivers/i3c/master/svc-i3c-target.c | 776 ++++++++++++++++++++++++++++ drivers/i3c/master/svc-i3c.h | 3 + 4 files changed, 811 insertions(+), 5 deletions(-) create mode 100644 drivers/i3c/master/svc-i3c-target.c diff --git a/drivers/i3c/master/Makefile b/drivers/i3c/master/Makefile index 484cb81f45821..b9ed6c9e7be13 100644 --- a/drivers/i3c/master/Makefile +++ b/drivers/i3c/master/Makefile @@ -2,6 +2,6 @@ obj-$(CONFIG_CDNS_I3C_MASTER) +=3D i3c-master-cdns.o obj-$(CONFIG_DW_I3C_MASTER) +=3D dw-i3c-master.o obj-$(CONFIG_AST2600_I3C_MASTER) +=3D ast2600-i3c-master.o -svc-i3c-objs +=3D svc-i3c-main.o svc-i3c-master.o +svc-i3c-objs +=3D svc-i3c-main.o svc-i3c-master.o svc-i3c-target.o obj-$(CONFIG_SVC_I3C_MASTER) +=3D svc-i3c.o obj-$(CONFIG_MIPI_I3C_HCI) +=3D mipi-i3c-hci/ diff --git a/drivers/i3c/master/svc-i3c-main.c b/drivers/i3c/master/svc-i3c= -main.c index 6be6a576cdf7a..e34b128ab274a 100644 --- a/drivers/i3c/master/svc-i3c-main.c +++ b/drivers/i3c/master/svc-i3c-main.c @@ -7,24 +7,51 @@ =20 #include "svc-i3c.h" =20 +static bool svc_i3c_is_master(struct device *dev) +{ + const char *mode =3D NULL; + + device_property_read_string(dev, "mode", &mode); + + if (!mode) + return true; + + if (strncmp(mode, "target", 6) =3D=3D 0) + return false; + + return true; +} + static int svc_i3c_probe(struct platform_device *pdev) { - return svc_i3c_master_probe(pdev); + if (svc_i3c_is_master(&pdev->dev)) + return svc_i3c_master_probe(pdev); + + return svc_i3c_target_probe(pdev); } =20 static void svc_i3c_remove(struct platform_device *pdev) { - svc_i3c_master_remove(pdev); + if (svc_i3c_is_master(&pdev->dev)) + return svc_i3c_master_remove(pdev); + + svc_i3c_target_remove(pdev); } =20 static int __maybe_unused svc_i3c_runtime_suspend(struct device *dev) { - return svc_i3c_master_runtime_suspend(dev); + if (svc_i3c_is_master(dev)) + return svc_i3c_master_runtime_suspend(dev); + + return -EINVAL; } =20 static int __maybe_unused svc_i3c_runtime_resume(struct device *dev) { - return svc_i3c_master_runtime_resume(dev); + if (svc_i3c_is_master(dev)) + return svc_i3c_master_runtime_resume(dev); + + return -EINVAL; } =20 static const struct dev_pm_ops svc_i3c_pm_ops =3D { diff --git a/drivers/i3c/master/svc-i3c-target.c b/drivers/i3c/master/svc-i= 3c-target.c new file mode 100644 index 0000000000000..094efb60cb404 --- /dev/null +++ b/drivers/i3c/master/svc-i3c-target.c @@ -0,0 +1,776 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright 2023 NXP. + * + * Author: Frank Li + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "svc-i3c.h" + +enum i3c_clks { + PCLK, + FCLK, + SCLK, + MAXCLK, +}; + +struct svc_i3c_target { + struct device *dev; + void __iomem *regs; + int irq; + struct clk_bulk_data clks[MAXCLK]; + + struct list_head txq; + spinlock_t txq_lock; /* protect tx queue */ + struct list_head rxq; + spinlock_t rxq_lock; /* protect rx queue */ + struct list_head cq; + spinlock_t cq_lock; /* protect complete queue */ + + struct work_struct work; + struct workqueue_struct *workqueue; + + struct completion dacomplete; + struct i3c_target_ctrl_features features; + + spinlock_t ctrl_lock; /* protext access SCTRL register */ +}; + +#define I3C_SCONFIG 0x4 +#define I3C_SCONFIG_SLVENA_MASK BIT(0) +#define I3C_SCONFIG_OFFLINE_MASK BIT(9) +#define I3C_SCONFIG_SADDR_MASK GENMASK(31, 25) + +#define I3C_SSTATUS 0x8 +#define I3C_SSTATUS_STNOTSTOP_MASK BIT(0) +#define I3C_SSTATUS_STOP_MASK BIT(10) +#define I3C_SSTATUS_RX_PEND_MASK BIT(11) +#define I3C_SSTATUS_TXNOTFULL_MASK BIT(12) +#define I3C_SSTATUS_DACHG_MASK BIT(13) +#define I3C_SSTATUS_EVDET_MASK GENMASK(21, 20) +#define I3C_SSTATUS_EVDET_ACKED 0x3 +#define I3C_SSTATUS_IBIDIS_MASK BIT(24) +#define I3C_SSTATUS_HJDIS_MASK BIT(27) + +#define I3C_SCTRL 0xc +#define I3C_SCTRL_EVENT_MASK GENMASK(1, 0) +#define I3C_SCTRL_EVENT_IBI 0x1 +#define I3C_SCTRL_EVENT_HOTJOIN 0x3 +#define I3C_SCTRL_EXTDATA_MASK BIT(3) +#define I3C_SCTRL_IBIDATA_MASK GENMASK(15, 8) + +#define I3C_SINTSET 0x10 +#define I3C_SINTCLR 0x14 +#define I3C_SINT_START BIT(8) +#define I3C_SINT_MATCHED BIT(9) +#define I3C_SINT_STOP BIT(10) +#define I3C_SINT_RXPEND BIT(11) +#define I3C_SINT_TXSEND BIT(12) +#define I3C_SINT_DACHG BIT(13) +#define I3C_SINT_CCC BIT(14) +#define I3C_SINT_ERRWARN BIT(15) +#define I3C_SINT_DDRMAATCHED BIT(16) +#define I3C_SINT_CHANDLED BIT(17) +#define I3C_SINT_EVENT BIT(18) +#define I3C_SINT_SLVRST BIT(19) + +#define I3C_SDATACTRL 0x2c +#define I3C_SDATACTRL_RXEMPTY_MASK BIT(31) +#define I3C_SDATACTRL_TXFULL_MASK BIT(30) +#define I3C_SDATACTRL_RXCOUNT_MASK GENMASK(28, 24) +#define I3C_SDATACTRL_TXCOUNT_MASK GENMASK(20, 16) +#define I3C_SDATACTRL_FLUSHFB_MASK BIT(1) +#define I3C_SDATACTRL_FLUSHTB_MASK BIT(0) + +#define I3C_SWDATAB 0x30 +#define I3C_SWDATAB_END_ALSO_MASK BIT(16) +#define I3C_SWDATAB_END_MASK BIT(8) + +#define I3C_SWDATAE 0x34 +#define I3C_SRDATAB 0x40 + +#define I3C_SCAPABILITIES 0x60 +#define I3C_SCAPABILITIES_FIFOTX_MASK GENMASK(27, 26) +#define I3C_SCAPABILITIES_FIFORX_MASK GENMASK(29, 28) + +#define I3C_SMAXLIMITS 0x68 +#define I3C_SMAXLIMITS_MAXRD_MASK GENMASK(11, 0) +#define I3C_SMAXLIMITS_MAXWR_MASK GENMASK(27, 16) + +#define I3C_SIDPARTNO 0x6c + +#define I3C_SIDEXT 0x70 +#define I3C_SIDEXT_BCR_MASK GENMASK(23, 16) +#define I3C_SIDEXT_DCR_MASK GENMASK(15, 8) +#define I3C_SVENDORID 0x74 + +#define I3C_SMAPCTRL0 0x11c +#define I3C_SMAPCTRL0_ENA_MASK BIT(0) +#define I3C_SMAPCTRL0_DA_MASK GENMASK(7, 1) + +#define I3C_IBIEXT1 0x140 +#define I3C_IBIEXT1_CNT_MASK GEN_MASK(2, 0) +#define I3C_IBIEXT1_MAX_MASK GEN_MASK(4, 6) +#define I3C_IBIEXT1_EXT1_SHIFT 8 +#define I3C_IBIEXT1_EXT2_SHIFT 16 +#define I3C_IBIEXT1_EXT3_SHIFT 24 + +#define I3C_IBIEXT2 0x144 +#define I3C_IBIEXT2_EXT4_SHIFT 0 +#define I3C_IBIEXT2_EXT5_SHIFT 8 +#define I3C_IBIEXT2_EXT6_SHIFT 16 +#define I3C_IBIEXT2_EXT7_SHIFT 24 + +static int svc_i3c_target_enable(struct i3c_target_ctrl *ctrl) +{ + struct svc_i3c_target *svc; + u32 val; + + svc =3D dev_get_drvdata(&ctrl->dev); + + val =3D readl_relaxed(svc->regs + I3C_SCONFIG); + val |=3D I3C_SCONFIG_SLVENA_MASK; + writel_relaxed(val, svc->regs + I3C_SCONFIG); + + return 0; +} + +static int svc_i3c_target_disable(struct i3c_target_ctrl *ctrl) +{ + struct svc_i3c_target *svc; + u32 val; + + svc =3D dev_get_drvdata(&ctrl->dev); + + val =3D readl_relaxed(svc->regs + I3C_SCONFIG); + val &=3D ~I3C_SCONFIG_SLVENA_MASK; + writel_relaxed(val, svc->regs + I3C_SCONFIG); + + return 0; +} + +static int svc_i3c_target_set_config(struct i3c_target_ctrl *ctrl, struct = i3c_target_func *func) +{ + struct svc_i3c_target *svc; + u32 val; + u32 wm, rm; + + svc =3D dev_get_drvdata(&ctrl->dev); + + if (func->static_addr > 0x7F) + return -EINVAL; + + val =3D readl_relaxed(svc->regs + I3C_SCONFIG); + val &=3D ~I3C_SCONFIG_SLVENA_MASK; + val |=3D FIELD_PREP(I3C_SCONFIG_SADDR_MASK, func->static_addr); + writel_relaxed(val, svc->regs + I3C_SCONFIG); + + if (func->part_id) + writel_relaxed((func->part_id << 16) | + ((func->instance_id << 12) & GENMASK(15, 12)) | + (func->ext_id & GENMASK(11, 0)), svc->regs + I3C_SIDPARTNO); + + writel_relaxed(FIELD_PREP(I3C_SIDEXT_BCR_MASK, func->bcr) | + FIELD_PREP(I3C_SIDEXT_DCR_MASK, func->dcr), + svc->regs + I3C_SIDEXT); + + wm =3D func->max_write_len =3D=3D 0 ? + FIELD_GET(I3C_SMAXLIMITS_MAXWR_MASK, I3C_SMAXLIMITS_MAXWR_MASK) : fu= nc->max_write_len; + + wm =3D max_t(u32, val, 8); + + rm =3D func->max_read_len =3D=3D 0 ? + FIELD_GET(I3C_SMAXLIMITS_MAXRD_MASK, I3C_SMAXLIMITS_MAXRD_MASK) : fu= nc->max_read_len; + rm =3D max_t(u32, val, 16); + + val =3D FIELD_PREP(I3C_SMAXLIMITS_MAXRD_MASK, rm) | FIELD_PREP(I3C_SMAXLI= MITS_MAXWR_MASK, wm); + writel_relaxed(val, svc->regs + I3C_SMAXLIMITS); + + writel_relaxed(func->vendor_id, svc->regs + I3C_SVENDORID); + return 0; +} + +static const struct i3c_target_ctrl_features *svc_i3c_get_features(struct = i3c_target_ctrl *ctrl) +{ + struct svc_i3c_target *svc; + + svc =3D dev_get_drvdata(&ctrl->dev); + + if (!svc) + return NULL; + + return &svc->features; +} + +static void svc_i3c_queue_complete(struct svc_i3c_target *svc, struct i3c_= request *complete) +{ + unsigned long flags; + + spin_lock_irqsave(&svc->cq_lock, flags); + list_add_tail(&complete->list, &svc->cq); + spin_unlock_irqrestore(&svc->cq_lock, flags); + queue_work(svc->workqueue, &svc->work); +} + +static void svc_i3c_fill_txfifo(struct svc_i3c_target *svc) +{ + struct i3c_request *req, *complete =3D NULL; + unsigned long flags; + int val; + + spin_lock_irqsave(&svc->txq_lock, flags); + while ((!!(req =3D list_first_entry_or_null(&svc->txq, struct i3c_request= , list))) && + !((readl_relaxed(svc->regs + I3C_SDATACTRL) & I3C_SDATACTRL_TXFULL= _MASK))) { + while (!(readl_relaxed(svc->regs + I3C_SDATACTRL) + & I3C_SDATACTRL_TXFULL_MASK)) { + val =3D *(u8 *)(req->buf + req->actual); + + if (req->actual + 1 =3D=3D req->length) + writel_relaxed(val, svc->regs + I3C_SWDATAE); + else + writel_relaxed(val, svc->regs + I3C_SWDATAB); + + req->actual++; + + if (req->actual =3D=3D req->length) { + list_del(&req->list); + complete =3D req; + spin_unlock_irqrestore(&svc->txq_lock, flags); + + svc_i3c_queue_complete(svc, complete); + return; + + spin_lock_irqsave(&svc->txq_lock, flags); + break; + } + } + } + spin_unlock_irqrestore(&svc->txq_lock, flags); +} + +static int svc_i3c_target_queue(struct i3c_request *req, gfp_t gfp) +{ + struct svc_i3c_target *svc; + struct list_head *q; + unsigned long flags; + spinlock_t *lk; + + svc =3D dev_get_drvdata(&req->ctrl->dev); + if (!svc) + return -EINVAL; + + if (req->tx) { + q =3D &svc->txq; + lk =3D &svc->txq_lock; + } else { + q =3D &svc->rxq; + lk =3D &svc->rxq_lock; + } + + spin_lock_irqsave(lk, flags); + list_add_tail(&req->list, q); + spin_unlock_irqrestore(lk, flags); + + if (req->tx) + svc_i3c_fill_txfifo(svc); + + if (req->tx) + writel_relaxed(I3C_SINT_TXSEND, svc->regs + I3C_SINTSET); + else + writel_relaxed(I3C_SINT_RXPEND, svc->regs + I3C_SINTSET); + + return 0; +} + +static int svc_i3c_dequeue(struct i3c_request *req) +{ + struct svc_i3c_target *svc; + unsigned long flags; + spinlock_t *lk; + + svc =3D dev_get_drvdata(&req->ctrl->dev); + if (!svc) + return -EINVAL; + + if (req->tx) + lk =3D &svc->txq_lock; + else + lk =3D &svc->rxq_lock; + + spin_lock_irqsave(lk, flags); + list_del(&req->list); + spin_unlock_irqrestore(lk, flags); + + return 0; +} + +static void svc_i3c_target_fifo_flush(struct i3c_target_ctrl *ctrl, bool t= x) +{ + struct svc_i3c_target *svc; + u32 val; + + svc =3D dev_get_drvdata(&ctrl->dev); + + val =3D readl_relaxed(svc->regs + I3C_SDATACTRL); + + val |=3D tx ? I3C_SDATACTRL_FLUSHTB_MASK : I3C_SDATACTRL_FLUSHFB_MASK; + + writel_relaxed(val, svc->regs + I3C_SDATACTRL); +} + +static int +svc_i3c_target_raise_ibi(struct i3c_target_ctrl *ctrl, void *p, u8 size) +{ + struct svc_i3c_target *svc; + unsigned long flags; + u8 *ibidata =3D p; + u32 ext1 =3D 0, ext2 =3D 0; + u32 val; + int ret; + + svc =3D dev_get_drvdata(&ctrl->dev); + + if (size && !p) + return -EINVAL; + + if (size > 8) + return -EINVAL; + + val =3D readl_relaxed(svc->regs + I3C_SSTATUS); + if (val & I3C_SSTATUS_IBIDIS_MASK) + return -EINVAL; + + ret =3D readl_relaxed_poll_timeout(svc->regs + I3C_SCTRL, val, + !(val & I3C_SCTRL_EVENT_MASK), 0, 10000); + if (ret) { + dev_err(&ctrl->dev, "Timeout when polling for NO event pending"); + val &=3D ~I3C_SCTRL_EVENT_MASK; + writel_relaxed(val, svc->regs + I3C_SCTRL); + return -ENAVAIL; + } + + spin_lock_irqsave(&svc->ctrl_lock, flags); + + val =3D readl_relaxed(svc->regs + I3C_SCTRL); + + val &=3D ~I3C_SCTRL_EVENT_MASK | I3C_SCTRL_IBIDATA_MASK; + val |=3D FIELD_PREP(I3C_SCTRL_EVENT_MASK, I3C_SCTRL_EVENT_IBI); + + if (size) { + val |=3D FIELD_PREP(I3C_SCTRL_IBIDATA_MASK, *ibidata); + ibidata++; + + if (size > 1) + val |=3D I3C_SCTRL_EXTDATA_MASK; + + size--; + if (size > 0) { + ext1 |=3D (size + 2); + ext1 |=3D (*ibidata++) << I3C_IBIEXT1_EXT1_SHIFT; + size--; + } + + if (size > 0) { + ext1 |=3D (*ibidata++) << I3C_IBIEXT1_EXT2_SHIFT; + size--; + } + + if (size > 0) { + ext1 |=3D (*ibidata++) << I3C_IBIEXT1_EXT3_SHIFT; + size--; + } + + writel_relaxed(ext1, svc->regs + I3C_IBIEXT1); + + if (size > 0) { + ext2 |=3D (*ibidata++) << I3C_IBIEXT2_EXT4_SHIFT; + size--; + } + + if (size > 0) { + ext2 |=3D (*ibidata++) << I3C_IBIEXT2_EXT5_SHIFT; + size--; + } + + if (size > 0) { + ext2 |=3D (*ibidata++) << I3C_IBIEXT2_EXT6_SHIFT; + size--; + } + + if (size > 0) { + ext2 |=3D (*ibidata++) << I3C_IBIEXT2_EXT7_SHIFT; + size--; + } + + writeb_relaxed(ext2, svc->regs + I3C_IBIEXT2); + } + + /* Issue IBI*/ + writel_relaxed(val, svc->regs + I3C_SCTRL); + spin_unlock_irqrestore(&svc->ctrl_lock, flags); + + ret =3D readl_relaxed_poll_timeout(svc->regs + I3C_SCTRL, val, + !(val & I3C_SCTRL_EVENT_MASK), 0, 1000000); + if (ret) { + dev_err(&ctrl->dev, "Timeout when polling for IBI finish\n"); + + //clear event to above hang bus + spin_lock_irqsave(&svc->ctrl_lock, flags); + val =3D readl_relaxed(svc->regs + I3C_SCTRL); + val &=3D ~I3C_SCTRL_EVENT_MASK; + writel_relaxed(val, svc->regs + I3C_SCTRL); + spin_unlock_irqrestore(&svc->ctrl_lock, flags); + + return -ENAVAIL; + } + + return 0; +} + +static void svc_i3c_target_complete(struct work_struct *work) +{ + struct svc_i3c_target *svc =3D container_of(work, struct svc_i3c_target, = work); + struct i3c_request *req; + unsigned long flags; + + spin_lock_irqsave(&svc->cq_lock, flags); + while (!list_empty(&svc->cq)) { + req =3D list_first_entry(&svc->cq, struct i3c_request, list); + list_del(&req->list); + spin_unlock_irqrestore(&svc->cq_lock, flags); + req->complete(req); + + spin_lock_irqsave(&svc->cq_lock, flags); + } + spin_unlock_irqrestore(&svc->cq_lock, flags); +} + +static irqreturn_t svc_i3c_target_irq_handler(int irq, void *dev_id) +{ + struct i3c_request *req, *complete =3D NULL; + struct svc_i3c_target *svc =3D dev_id; + unsigned long flags; + u32 statusFlags; + + statusFlags =3D readl(svc->regs + I3C_SSTATUS); + writel(statusFlags, svc->regs + I3C_SSTATUS); + + if (statusFlags & I3C_SSTATUS_DACHG_MASK) + complete_all(&svc->dacomplete); + + if (statusFlags & I3C_SSTATUS_RX_PEND_MASK) { + spin_lock_irqsave(&svc->rxq_lock, flags); + req =3D list_first_entry_or_null(&svc->rxq, struct i3c_request, list); + + if (!req) { + writel_relaxed(I3C_SINT_RXPEND, svc->regs + I3C_SINTCLR); + } else { + while (!(readl_relaxed(svc->regs + I3C_SDATACTRL) & + I3C_SDATACTRL_RXEMPTY_MASK)) { + *(u8 *)(req->buf + req->actual) =3D + readl_relaxed(svc->regs + I3C_SRDATAB); + req->actual++; + + if (req->actual =3D=3D req->length) { + complete =3D req; + list_del(&req->list); + break; + } + } + + if (req->actual !=3D req->length && (statusFlags & I3C_SSTATUS_STOP_MAS= K)) { + complete =3D req; + list_del(&req->list); + } + } + spin_unlock_irqrestore(&svc->rxq_lock, flags); + + if (complete) { + spin_lock_irqsave(&svc->cq_lock, flags); + list_add_tail(&complete->list, &svc->cq); + spin_unlock_irqrestore(&svc->cq_lock, flags); + queue_work(svc->workqueue, &svc->work); + complete =3D NULL; + } + } + + if (statusFlags & I3C_SSTATUS_TXNOTFULL_MASK) { + svc_i3c_fill_txfifo(svc); + spin_lock_irqsave(&svc->txq_lock, flags); + if (list_empty(&svc->txq)) + writel_relaxed(I3C_SINT_TXSEND, svc->regs + I3C_SINTCLR); + spin_unlock_irqrestore(&svc->txq_lock, flags); + } + + return IRQ_HANDLED; +} + +static void svc_i3c_cancel_all_reqs(struct i3c_target_ctrl *ctrl, bool tx) +{ + struct svc_i3c_target *svc; + struct i3c_request *req; + struct list_head *q; + unsigned long flags; + spinlock_t *lk; + + svc =3D dev_get_drvdata(&ctrl->dev); + if (!svc) + return; + + if (tx) { + q =3D &svc->txq; + lk =3D &svc->txq_lock; + } else { + q =3D &svc->rxq; + lk =3D &svc->rxq_lock; + } + + spin_lock_irqsave(lk, flags); + while (!list_empty(q)) { + req =3D list_first_entry(q, struct i3c_request, list); + list_del(&req->list); + spin_unlock_irqrestore(lk, flags); + + req->status =3D I3C_REQUEST_CANCEL; + req->complete(req); + spin_lock_irqsave(lk, flags); + } + spin_unlock_irqrestore(lk, flags); +} + +static int svc_i3c_hotjoin(struct i3c_target_ctrl *ctrl) +{ + struct svc_i3c_target *svc; + int ret; + u32 val; + u32 cfg; + + svc =3D dev_get_drvdata(&ctrl->dev); + if (!svc) + return -EINVAL; + + reinit_completion(&svc->dacomplete); + + val =3D readl_relaxed(svc->regs + I3C_SSTATUS); + if (val & I3C_SSTATUS_HJDIS_MASK) { + dev_err(&ctrl->dev, "Hotjoin disabled by i3c master\n"); + return -EINVAL; + } + + ret =3D readl_relaxed_poll_timeout(svc->regs + I3C_SCTRL, val, + !(val & I3C_SCTRL_EVENT_MASK), 0, 10000); + if (ret) { + dev_err(&ctrl->dev, "Timeout when polling for none event pending"); + return -ENAVAIL; + } + + cfg =3D readl_relaxed(svc->regs + I3C_SCONFIG); + cfg |=3D I3C_SCONFIG_OFFLINE_MASK; + writel_relaxed(cfg, svc->regs + I3C_SCONFIG); + + val &=3D ~(I3C_SCTRL_EVENT_MASK | I3C_SCTRL_IBIDATA_MASK); + val |=3D FIELD_PREP(I3C_SCTRL_EVENT_MASK, I3C_SCTRL_EVENT_HOTJOIN); + /* Issue hotjoin*/ + writel_relaxed(val, svc->regs + I3C_SCTRL); + + ret =3D readl_relaxed_poll_timeout(svc->regs + I3C_SCTRL, val, + !(val & I3C_SCTRL_EVENT_MASK), 0, 100000); + if (ret) { + val &=3D ~FIELD_PREP(I3C_SCTRL_EVENT_MASK, I3C_SCTRL_EVENT_MASK); + writel_relaxed(val, svc->regs + I3C_SCTRL); + dev_err(&ctrl->dev, "Timeout when polling for HOTJOIN finish\n"); + return -EINVAL; + } + + val =3D readl_relaxed(svc->regs + I3C_SSTATUS); + val =3D FIELD_GET(I3C_SSTATUS_EVDET_MASK, val); + if (val !=3D I3C_SSTATUS_EVDET_ACKED) { + dev_err(&ctrl->dev, "Master NACKED hotjoin request\n"); + return -EINVAL; + } + + writel_relaxed(I3C_SINT_DACHG, svc->regs + I3C_SINTSET); + ret =3D wait_for_completion_timeout(&svc->dacomplete, msecs_to_jiffies(10= 0)); + writel_relaxed(I3C_SINT_DACHG, svc->regs + I3C_SINTCLR); + if (!ret) { + dev_err(&ctrl->dev, "wait for da assignment timeout\n"); + return -EIO; + } + + val =3D readl_relaxed(svc->regs + I3C_SMAPCTRL0); + val =3D FIELD_GET(I3C_SMAPCTRL0_DA_MASK, val); + dev_info(&ctrl->dev, "Get dynamtic address 0x%x\n", val); + return 0; +} + +static int svc_i3c_set_status_format1(struct i3c_target_ctrl *ctrl, u16 st= atus) +{ + struct svc_i3c_target *svc; + unsigned long flags; + u32 val; + + svc =3D dev_get_drvdata(&ctrl->dev); + + spin_lock_irqsave(&svc->ctrl_lock, flags); + val =3D readl_relaxed(svc->regs + I3C_SCTRL); + val &=3D 0xFFFF; + val |=3D status << 16; + writel_relaxed(val, svc->regs + I3C_SCTRL); + spin_unlock_irqrestore(&svc->ctrl_lock, flags); + + return 0; +} + +static u16 svc_i3c_get_status_format1(struct i3c_target_ctrl *ctrl) +{ + struct svc_i3c_target *svc; + + svc =3D dev_get_drvdata(&ctrl->dev); + + return readl_relaxed(svc->regs + I3C_SCTRL) >> 16; +} + +static u8 svc_i3c_get_addr(struct i3c_target_ctrl *ctrl) +{ + struct svc_i3c_target *svc; + int val; + + svc =3D dev_get_drvdata(&ctrl->dev); + + val =3D readl_relaxed(svc->regs + I3C_SMAPCTRL0); + + if (val & I3C_SMAPCTRL0_ENA_MASK) + return FIELD_GET(I3C_SMAPCTRL0_DA_MASK, val); + + return 0; +} + +static int svc_i3c_fifo_status(struct i3c_target_ctrl *ctrl, bool tx) +{ + struct svc_i3c_target *svc; + int val; + + svc =3D dev_get_drvdata(&ctrl->dev); + + val =3D readl_relaxed(svc->regs + I3C_SDATACTRL); + + if (tx) + return FIELD_GET(I3C_SDATACTRL_TXCOUNT_MASK, val); + else + return FIELD_GET(I3C_SDATACTRL_RXCOUNT_MASK, val); +} + +static struct i3c_target_ctrl_ops svc_i3c_target_ops =3D { + .set_config =3D svc_i3c_target_set_config, + .enable =3D svc_i3c_target_enable, + .disable =3D svc_i3c_target_disable, + .queue =3D svc_i3c_target_queue, + .dequeue =3D svc_i3c_dequeue, + .raise_ibi =3D svc_i3c_target_raise_ibi, + .fifo_flush =3D svc_i3c_target_fifo_flush, + .cancel_all_reqs =3D svc_i3c_cancel_all_reqs, + .get_features =3D svc_i3c_get_features, + .hotjoin =3D svc_i3c_hotjoin, + .fifo_status =3D svc_i3c_fifo_status, + .set_status_format1 =3D svc_i3c_set_status_format1, + .get_status_format1 =3D svc_i3c_get_status_format1, + .get_addr =3D svc_i3c_get_addr, +}; + +int svc_i3c_target_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct i3c_target_ctrl *target; + struct svc_i3c_target *svc; + int ret; + u32 val; + + svc =3D devm_kzalloc(dev, sizeof(*svc), GFP_KERNEL); + if (!svc) + return -ENOMEM; + + svc->regs =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(svc->regs)) + return PTR_ERR(svc->regs); + + svc->clks[PCLK].id =3D "pclk"; + svc->clks[FCLK].id =3D "fast_clk"; + svc->clks[SCLK].id =3D "slow_clk"; + + ret =3D devm_clk_bulk_get(dev, MAXCLK, svc->clks); + if (ret < 0) { + dev_err(dev, "fail get clks: %d\n", ret); + return ret; + } + + ret =3D clk_bulk_prepare_enable(MAXCLK, svc->clks); + if (ret < 0) { + dev_err(dev, "fail enable clks: %d\n", ret); + return ret; + } + + svc->irq =3D platform_get_irq(pdev, 0); + if (svc->irq < 0) + return svc->irq; + + INIT_LIST_HEAD(&svc->txq); + INIT_LIST_HEAD(&svc->rxq); + INIT_LIST_HEAD(&svc->cq); + spin_lock_init(&svc->txq_lock); + spin_lock_init(&svc->rxq_lock); + spin_lock_init(&svc->cq_lock); + spin_lock_init(&svc->ctrl_lock); + + init_completion(&svc->dacomplete); + + INIT_WORK(&svc->work, svc_i3c_target_complete); + svc->workqueue =3D alloc_workqueue("%s-cq", 0, 0, dev_name(dev)); + if (!svc->workqueue) + return -ENOMEM; + + /* Disable all IRQ */ + writel_relaxed(0xFFFFFFFF, svc->regs + I3C_SINTCLR); + + val =3D readl_relaxed(svc->regs + I3C_SCAPABILITIES); + svc->features.tx_fifo_sz =3D FIELD_GET(I3C_SCAPABILITIES_FIFOTX_MASK, va= l); + svc->features.tx_fifo_sz =3D 2 << svc->features.tx_fifo_sz; + + svc->features.rx_fifo_sz =3D FIELD_GET(I3C_SCAPABILITIES_FIFORX_MASK, val= ); + svc->features.rx_fifo_sz =3D 2 << svc->features.rx_fifo_sz; + + ret =3D devm_request_irq(dev, svc->irq, svc_i3c_target_irq_handler, 0, "s= vc-i3c-irq", svc); + if (ret) + return -ENOENT; + + target =3D devm_i3c_target_ctrl_create(dev, &svc_i3c_target_ops); + if (!target) + return -ENOMEM; + + dev_set_drvdata(&target->dev, svc); + + return 0; +} + +void svc_i3c_target_remove(struct platform_device *pdev) +{ +} diff --git a/drivers/i3c/master/svc-i3c.h b/drivers/i3c/master/svc-i3c.h index b9e1dce4b2109..1bb77474f36eb 100644 --- a/drivers/i3c/master/svc-i3c.h +++ b/drivers/i3c/master/svc-i3c.h @@ -8,5 +8,8 @@ void svc_i3c_master_remove(struct platform_device *pdev); int svc_i3c_master_runtime_suspend(struct device *dev); int svc_i3c_master_runtime_resume(struct device *dev); =20 +int svc_i3c_target_probe(struct platform_device *pdev); +void svc_i3c_target_remove(struct platform_device *pdev); + #endif =20 --=20 2.34.1