From nobody Sun Feb 8 05:41:45 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A497E18027 for ; Mon, 5 Feb 2024 09:34:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707125684; cv=none; b=AOBAY7eRnCbxWAD+wBf6fCCr/J5gAo67zfsE+2sdXU7bawMbz1schTU/8ZdqPlukaox95laGa/jtdIbcWx4PaR9J69Z+PQRnksZXPqxRd4VB1b+0Fz9UPEii3EFGhtJjAdF8wygYEgZJx/fJry7u79UG7XVt5TXqt2MIs0b/V0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707125684; c=relaxed/simple; bh=DEm4ivJPwvyJQ3+rwUCzWKrs05E/BVn3gRvUWmQAFN4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=g1X/phDb2CefR8o/aGgPkaD65pgWqi+jKO/9rs2KLtaCDVXO29XmhtO1yOTZz8/HCP5npccDEMXg/jKmveZw/wzW3QBtjonKrhrJA8ZybLrHraLxZVLRQiprLuUSTEkr1J5B+cc/WDfFnn94tjGY/D//ucHwxPBH72tpdfK8yzY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=PZyb4/wu; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="PZyb4/wu" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40f033c2e30so37965675e9.0 for ; Mon, 05 Feb 2024 01:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1707125681; x=1707730481; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VJfsBLVML9p9Iy9pV/o7OjQ6GeZUjbwVmk3zuZ2HyJg=; b=PZyb4/wuX4TCaUqA4Wksz+TjJoDLgA6L5b8sSBHxg97dbH9jJvwzBYcViteljdnNo6 x05CA8lPWScieQnZqqU4XU/GezrSTB/kjA3nwCS7mB+Lx/vS4Iheh/UCYjp5yMvFiHs8 hlskGtu64Jd78pUsQlKayd0Jucl9lwSzMEBPdBm3O8A6mlHcxI6SirOd6cM8q9YANbtC 0pfOtdFi5xMINaBetaDjhKy9/yBSt7F1xupntsv4CHPuyqNmI0/aSainfEi9+/eJ3T0V mN3T5GRBS5SI5970UTFl/lyd/RWSkbpUuPr34PKoQ9xt7Mqgdpqi70Gj70lvXlfhHF3H DoUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707125681; x=1707730481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VJfsBLVML9p9Iy9pV/o7OjQ6GeZUjbwVmk3zuZ2HyJg=; b=hmreysZCXCloqnxX3J+QjChFJ2OcNwie6R9XrDAN7KaW8TL8TUnNXg8BFUL619ix0u JrjsEqXUDRKyNXUO8dauwXYF1/DYgNe8vBkD5kp8FUmDsiZ9fYXDPSTLJ1OAQD88CsPi fvAnc7CXiQxIPoiAeul4pwx28di2hrhfXEVWAAgc3QPpkrFHiGXax8F6GnW+DJLF/RHj aN/9U4QEW6k6dUTanosoO3xoici3tjHDGi8g6QdF5wcNmX6OO32MJYR1SpoU+byorYo4 C5CooJFwB/FkuVRaHNPyy0KDXGQ36Uq/UlAhZvvdNYALEYxxD5yLKT/CeP3O7f2Ip1+s /bFw== X-Gm-Message-State: AOJu0Yx26TBE1EFIvzM4LtGjmCovP3QNVoIDzXpSb6Q81AFLeKaoHnZ4 WtbYCWaYft/w0gjlTvOuxI23ZPbxO4EFYoBxxrN83Evx+MdvA326bJKdl2pca0g= X-Google-Smtp-Source: AGHT+IFTk75p4T7YsB2qUfoM1Ugfl9KI9GBfXAbd4boWpGB3sTqz4xEuekxq7k9bDL7O579RyRi3fg== X-Received: by 2002:a05:600c:518e:b0:40f:ddda:4e19 with SMTP id fa14-20020a05600c518e00b0040fddda4e19mr506479wmb.9.1707125680992; Mon, 05 Feb 2024 01:34:40 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWjvm/tk38/dR++2+UOg7NwEVKczDnNOK22kyYjVAFTkO2DGlirfusYq123N8IU068HPfieFUIS/yUiCJFZTy9WOkfcVWCrbummQyXl9mA/PV7fIWijg1B9R3vFGjlEAtxZx5gZ3iQ/VWrexNNQWoZzoLJJaL+DHoYabAl+A9YY7DrudpTECMIi9ih+itfdWNQDKvFY92j7z3QCPeZWjBpij/e1nkZ9RRsYG+zVwIrR5lxfnbfcZhR4QbMBf1i3+sLXiP02vnoMs7JCZPRIjZ4Q2S/+G6GoXyf9F21akdE4JyhXh6cA/VMuU1ldTbkWVDY6+6zxuYu4ExuNGWAyrzxPPeSu8cyZfQ== Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:d929:10db:5b5c:b49d]) by smtp.gmail.com with ESMTPSA id f15-20020a05600c154f00b0040fc771c864sm7980397wmg.14.2024.02.05.01.34.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 01:34:40 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Kent Gibson , Alex Elder , Geert Uytterhoeven , "Paul E . McKenney" , Andy Shevchenko , Wolfram Sang Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v2 17/23] gpio: reduce the functionality of validate_desc() Date: Mon, 5 Feb 2024 10:34:12 +0100 Message-Id: <20240205093418.39755-18-brgl@bgdev.pl> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240205093418.39755-1-brgl@bgdev.pl> References: <20240205093418.39755-1-brgl@bgdev.pl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Bartosz Golaszewski Checking desc->gdev->chip for NULL without holding it in place with some serializing mechanism is pointless. Remove this check. Also don't check desc->gdev for NULL as it can never happen. We'll be protecting gdev->chip with SRCU soon but we will provide a dedicated, automatic class for that. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpiolib.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index f8d53ebbf25b..7d897c807e95 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -2251,19 +2251,12 @@ static int validate_desc(const struct gpio_desc *de= sc, const char *func) { if (!desc) return 0; + if (IS_ERR(desc)) { pr_warn("%s: invalid GPIO (errorpointer)\n", func); return PTR_ERR(desc); } - if (!desc->gdev) { - pr_warn("%s: invalid GPIO (no device)\n", func); - return -EINVAL; - } - if (!desc->gdev->chip) { - dev_warn(&desc->gdev->dev, - "%s: backing chip is gone\n", func); - return 0; - } + return 1; } =20 @@ -2339,12 +2332,7 @@ static bool gpiod_free_commit(struct gpio_desc *desc) =20 void gpiod_free(struct gpio_desc *desc) { - /* - * We must not use VALIDATE_DESC_VOID() as the underlying gdev->chip - * may already be NULL but we still want to put the references. - */ - if (!desc) - return; + VALIDATE_DESC_VOID(desc); =20 if (!gpiod_free_commit(desc)) WARN_ON(1); --=20 2.40.1