From nobody Sun Feb 8 07:25:23 2026 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89F586FA8 for ; Sun, 4 Feb 2024 04:46:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707021997; cv=none; b=HPbpDryiNI7SidDvWt9nZHv330871qsryTIYGSLGPTasddOvNO1xMyldweUFklKFfK6jJ9/SruapIW+TOfC84fI8/MtOBtREeDQHm8bvkmIMDd2uhpjs8cxNGa9AZcGIUT57zDBYeyn4gANzyd/q3yWRFWkgrzFibf7iRPnzDzs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707021997; c=relaxed/simple; bh=esJff9D3QxDKh73OdhoQpybzSp8tl3pv5yUOn5L2Or0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oPhyZx6BCcBjOGiOILtAU3t6dFBNB55ProfJIs41NTNWLD6DurfB19PdRnJ38efnPDiLkIR7J9lN2OtL4RyDfiZQugQHPmt/o7MoYP6thcLsD7xkM0azVPCdOXXT0Elz0UVomfPEa+eQn42o+f4KYreqyB9DObuIT1meMmY2k14= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=manifault.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=manifault.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-783ef8ae70aso247544485a.2 for ; Sat, 03 Feb 2024 20:46:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707021994; x=1707626794; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hTl2D4iOo0GV1DAY/ZjWEvwTNDLK6aFt78YqxSZPvBQ=; b=C1Z0tjsMTcXNvyQ0l4P5j3ERERGxJDEWDAe9WaVgxYx7sZ2fKD757JmlTu6qFT35fv HI5SsLeWyU+aFld7AgQpL9bXE8rjgnHkeFNX1DssmcMQkoEYnCInMxex2OvnoRRg9EOb VkyK1gJpd5ktvMYAeZ1i9BOBfpZLOwPIVPCnwWoyGC/j5kOwOQznNZzlqAM6TwLD7+pv /AE65wFTbm2lY+ImoWwCdUgLJGRQcey+cZgpm8FgbarkJgL2mSeBX7y76h2ocfWKPT3t edm5JbqZTFAvOVoLKXrU4bkpmt9hdtTlczUwst2N93dSi+dXJbkgtusuni2UiRy+Xkgk C/xw== X-Gm-Message-State: AOJu0Yz9SDsXM7gRj44wfxhmH/pyGXy+4+vWtxS5K6MO01qa5WHV4pDY p5XshD+0CUqQRHVoeRcfSjdnD1sUTZ7vjAzCDkqrW2NU0iYQbsrRuUXCRlZu9Y8= X-Google-Smtp-Source: AGHT+IHY+ayHYkGzoNKi9AUfjjJw3yZrERG3kPAAS6HF43SQ7uMfILchiNl4eEuK5xIxARONgntRxQ== X-Received: by 2002:a0c:e082:0:b0:686:a185:dc11 with SMTP id l2-20020a0ce082000000b00686a185dc11mr2339381qvk.55.1707021993889; Sat, 03 Feb 2024 20:46:33 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXEw3NEGoax1wKTMcPEjLAOa+mI6JFt9Fn9dr/BacCCq/KLmBIwJglX11ETVmzHeqLm7qluTBvMjTx5KBbBEH0DMJPk25rtJEbif1AowmGxrK+a4z7BcUSxCyG+3mL01bcsMIBa5JkJ6gDplxUMnmB0FLMflqp7e7ggdpiUgx8rdVJPhJXXKcehp1s1+Nkh+bNs71h9J4th8kHpGOjm8cL7QoLc8hokaQW3GFcDmy9oqqsSug+rvKmpt/7xvkfig5eY9dcbLb1TE67qK+kncPpzAb2KoZnbh/samfk5Z2puv4O+FH/Cyw2KoZSG3ieGGeSWN1w7f1/sg0uQuZHjMZsKHxna27YLbiaX7A== Received: from localhost (c-24-1-27-177.hsd1.il.comcast.net. [24.1.27.177]) by smtp.gmail.com with ESMTPSA id ny6-20020a056214398600b00681785c95e0sm2434781qvb.46.2024.02.03.20.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 20:46:33 -0800 (PST) From: David Vernet To: linux-kernel@vger.kernel.org Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, kernel-team@meta.com Subject: [PATCH v2 1/3] sched/fair: Remove unnecessary goto in update_sd_lb_stats() Date: Sat, 3 Feb 2024 22:46:16 -0600 Message-ID: <20240204044618.46100-2-void@manifault.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240204044618.46100-1-void@manifault.com> References: <20240204044618.46100-1-void@manifault.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In update_sd_lb_stats(), when we're iterating over the sched groups that comprise a sched domain, we're skipping the call to update_sd_pick_busiest() for the sched group that contains the local / destination CPU. We use a goto to skip the call, but we could just as easily check !local_group, as there's no other logic that we need to skip with the goto. Let's remove the goto, and check for !local_group in the if statement instead. Reviewed-by: Valentin Schneider Signed-off-by: David Vernet Reviewed-by: Vincent Guittot --- kernel/sched/fair.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index b803030c3a03..e7519ea434b1 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10578,16 +10578,11 @@ static inline void update_sd_lb_stats(struct lb_e= nv *env, struct sd_lb_stats *sd =20 update_sg_lb_stats(env, sds, sg, sgs, &sg_status); =20 - if (local_group) - goto next_group; - - - if (update_sd_pick_busiest(env, sds, sg, sgs)) { + if (!local_group && update_sd_pick_busiest(env, sds, sg, sgs)) { sds->busiest =3D sg; sds->busiest_stat =3D *sgs; } =20 -next_group: /* Now, start updating sd_lb_stats */ sds->total_load +=3D sgs->group_load; sds->total_capacity +=3D sgs->group_capacity; --=20 2.43.0 From nobody Sun Feb 8 07:25:23 2026 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FD6579E0 for ; Sun, 4 Feb 2024 04:46:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707021999; cv=none; b=mHfvmkjHC/PIiMUoc6Dd+qd9DUW28aY94Ys3mDw2H/Al9kf4BQ7EbAQxSnK/SoIatKAPULcAHfu68QdUjW0kDkME0oLBTqTA/lrTshY59ssmzjewJdBbJrbHhhStH0XcBI5ZeT4Tr6ioe5tv2hDaSmnTl40/bVlW5149lQXkAfI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707021999; c=relaxed/simple; bh=vui/RYMxtvLSlzIZx1ihMqsZNVVUacQvQp4BnYDnMfg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q/rZ0pWLRwWm+rGqxB13o6qGEP4UV9gmqVMfAccGiiQXWHGs3i6GZmHvHFOxOuw2kOZb+3UyEJqtO4IIQQt6DD7VAz7Wuh4h5GRMO/gNA17yPlxwD04b3opgYleltUqdSJzKt2Zb3zIWqILU4P/BjCv0ygKJ/sYMjNh6bxM0ZKg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=manifault.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=manifault.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-783d4b3ad96so221592785a.3 for ; Sat, 03 Feb 2024 20:46:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707021996; x=1707626796; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KQTMIMuLSrSdNFkBQ8JACN0LFlSoVQIArYjoabFjhtU=; b=H1aRUYjTjIvs6E1cO0QMg9tm7ilcpa1Evq0TKdSIvxGlmYdDCQtyvn4/wHndkt05gJ HyBN8oQ79SnVj1XlWLpbPfaIqxTMvvedW21c55HQw0MoxlPXXhqIxOt+TAX4GaeCg/yJ BMpiALOFH2Gl3VD97mbLsGiF99MuTQ5Z6UA4UvoZCGhOMi8t428LZjyZ0PYZ6k7au85Y hVsz42FWHhQxxkj/68MLu2tY0UHu2fzSsGZcHAkjq+cKs+fnrGLcFK2+MB95EaNNf+rb i0/YYPzMw9MdFDKpxeFut27jYSYaI8HHTNd0gwOdLQj5ZhsPmJRlBabyBBUTVOEhjbWW 5hmQ== X-Gm-Message-State: AOJu0YxbTYvPkgkYFGN5Px+p1hOVSAZ5lV7R+DPIBRgDMXCQt+alLivG y77cBqxlF7DGiuO3s8AePuGx2U2jHjxvYftOkGBvAoXFXBXeJxJRLMmIjPZpaO8= X-Google-Smtp-Source: AGHT+IE60+G8bx/mkj6dzFfYM3I0ibACAoFVvsennF8TbsItIYmUKLv/0XUpk7O5uXYdxN5Y9c1lBw== X-Received: by 2002:a05:620a:1211:b0:785:3abd:ce51 with SMTP id u17-20020a05620a121100b007853abdce51mr6774160qkj.58.1707021995706; Sat, 03 Feb 2024 20:46:35 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWes6Z47uXeC7KAMZiu/aOWDJN7lH4ycbqLnWSbxMmv7lO1Uvkm+VjGE+ykgfVR9R7TDBROhV3KwNYNshSMZBtmek9J+FklPq4njOuarTeYHCPrE4P30x4PsA20HrRBvRMVWX/2bRct4H4YvQuISR5V3ugcnzcsQ8L1wq3rCsi+l38fxkLHL2DKeUEfn6AukBfsexhqA8KmWb4j/Q4jDCQwVbDBKTdPnfWsesQog8Y/u3j8nH80elmDb+ZxP83pv6YAvSwP3DdiVilq7eR4xWtStLEnvMQfF/WORBlPVJYapy9xMCzITpH5iZd2LJVSohrnI2hEJmX2hojnEM94CSojXwnA5pVx3YbyLQ== Received: from localhost (c-24-1-27-177.hsd1.il.comcast.net. [24.1.27.177]) by smtp.gmail.com with ESMTPSA id h7-20020a05620a21c700b007853eb72c49sm1925688qka.46.2024.02.03.20.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 20:46:35 -0800 (PST) From: David Vernet To: linux-kernel@vger.kernel.org Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, kernel-team@meta.com Subject: [PATCH v2 2/3] sched/fair: Do strict inequality check for busiest misfit task group Date: Sat, 3 Feb 2024 22:46:17 -0600 Message-ID: <20240204044618.46100-3-void@manifault.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240204044618.46100-1-void@manifault.com> References: <20240204044618.46100-1-void@manifault.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In update_sd_pick_busiest(), when comparing two sched groups that are both of type group_misfit_task, we currently consider the new group as busier than the current busiest group even if the new group has the same misfit task load as the current busiest group. We can avoid some unnecessary writes if we instead only consider the newest group to be the busiest if it has a higher load than the current busiest. This matches the behavior of other group types where we compare load, such as two groups that are both overloaded. Let's update the group_misfit_task type comparison to also only update the busiest group in the event of strict inequality. Signed-off-by: David Vernet Reviewed-by: Vincent Guittot --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index e7519ea434b1..76d03106040d 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10028,7 +10028,7 @@ static bool update_sd_pick_busiest(struct lb_env *e= nv, * If we have more than one misfit sg go with the biggest * misfit. */ - if (sgs->group_misfit_task_load < busiest->group_misfit_task_load) + if (sgs->group_misfit_task_load <=3D busiest->group_misfit_task_load) return false; break; =20 --=20 2.43.0 From nobody Sun Feb 8 07:25:23 2026 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D760AD2C for ; Sun, 4 Feb 2024 04:46:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707022000; cv=none; b=bBdm4oGIU1LEySEuDbthW4zJQbP3t7Pan0MZpEGG8ruiNDEh4MAPB2LfgqVvKc6gEZw+959BNpQ9CmYYZgvNDQBIy5fOv5diIPEAmW0Y2JYynWsrO+lU1FARkLEzF5BTrgT0qKZSrYJUIKy6R2zWirkT1jvXxRqL1NCQdv7usa4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707022000; c=relaxed/simple; bh=GBDuC2MMlodSGYgMpqhLqVLYKeiXXyE2UugGI1ne59c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N59MPrW4hDra+nylt6Zlhp8ZRvPD1CcudzUb23DGVdWVpYj0aseZHG50iji2lEyQC/OAW+T6pmK8Knephgd86UWG5T78csWt+Jl4mYsxxLc74jJUuJErZUZ8/TtXk/kZjy90VdJcFDzRTGFyVddEXgWuIlY41VWOirKltY78sY8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=manifault.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=manifault.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-7853fcc314bso230585785a.1 for ; Sat, 03 Feb 2024 20:46:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707021998; x=1707626798; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HK9De5V8Wj4AOhyTbBnyxY3PU+lWzfPRkJg9zP8Toqw=; b=H0D0V+2VxUpBbYLWYonbgaxWPt4c3JseQIAgzOb4hcHviSr++WqYtMwlBv0MacpwFk j2n3LnRKtEydngXyvRF3pMJcc1nbI4pr/VbAnvy0Kw/SyM45XoFA353ldiHf/3U0ivmb 25qBy8JR3AMBC+TZLykFoEKqR8LE921n8dU1XqWGcSkVQfNH5EYaSuOYPi1ElaVOCdxd V28H5Q3FkRLBEWoQZCTKGFMnLsxRtWJTyvPVllT6bynGL5ad/thtlAiUe8jlJjDP1Y4i qmyLB0k/fqaHUxuZgLJ+rIZ/PXjzQyq2nbl443M47u3Wt2TgKiBW8artxResv5gxo4sO j5mg== X-Gm-Message-State: AOJu0YxE2QoD+s33zxCyIgObcJyu2EaRpfOZKgTPOv1mTt31TOynF3j8 09ixS2LjCxBnBFVSoiqAJ5OzGny/6K1n8OjkNQdwse7Q7bKXQQ7zPWVq5EmqlEo= X-Google-Smtp-Source: AGHT+IF2bp4VaWwcqfok5xwgDgXd0enf3F0oDenCa3fHN8G9A1HKYe5WD0vCUrHmKSBHYIRfjKePQA== X-Received: by 2002:a05:620a:4491:b0:785:74f5:62c6 with SMTP id x17-20020a05620a449100b0078574f562c6mr2054025qkp.75.1707021997687; Sat, 03 Feb 2024 20:46:37 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXGl3JbzLVNqpgamXMxGC9Ktt0InVG7HyzAo5fpqIsVtpQB3xxR3TmlZ+Gv2Q8VkttKpMEdfkL/hjEETJzapPDONom4RAysBdlOxaHwbgm/Vo39se8va+YPG4khpJFCV1A/MafdL9t4xlUwD7khEq/5ENYjW+ZPREUIcPhdCkXzZcrFbWyd8tHbvop9LG1u+webymOLAGNhlVDS80oItv4JG9Gp+ZnrQTRoqlfwbyl5scOUmf0EBfieitvfyVA7FYACTC1GcrKqmW++xingPkprbz0rBkEKa8Y23VoyB4NvnkungDrvGkH1+2n1PblJ0raHzkcJ+JU9KnrL6+aoiGOYdl2cdymcW6KIJg== Received: from localhost (c-24-1-27-177.hsd1.il.comcast.net. [24.1.27.177]) by smtp.gmail.com with ESMTPSA id c15-20020a05620a11af00b007840137670csm1923778qkk.24.2024.02.03.20.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 20:46:36 -0800 (PST) From: David Vernet To: linux-kernel@vger.kernel.org Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, kernel-team@meta.com Subject: [PATCH v2 3/3] sched/fair: Simplify some logic in update_sd_pick_busiest() Date: Sat, 3 Feb 2024 22:46:18 -0600 Message-ID: <20240204044618.46100-4-void@manifault.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240204044618.46100-1-void@manifault.com> References: <20240204044618.46100-1-void@manifault.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When comparing the current struct sched_group with the yet-busiest domain in update_sd_pick_busiest(), if the two groups have the same group type, we're currently doing a bit of unnecessary work for any group >=3D group_misfit_task. We're comparing the two groups, and then returning only if false (the group in question is not the busiest). Othewise, we break, do an extra unnecessary conditional check that's vacuously false for any group type > group_fully_busy, and then always return true. Let's just return directly in the switch statement instead. This doesn't change the size of vmlinux with llvm 17 (not surprising given that all of this is inlined in load_balance()), but it does shrink load_balance() by 88 bytes on x86. Given that it also improves readability, this seems worth doing. As a bonus, remove an unnecessary goto in update_sd_lb_stats(). Reviewed-by: Valentin Schneider Signed-off-by: David Vernet Reviewed-by: Vincent Guittot --- kernel/sched/fair.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 76d03106040d..fa049f866461 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10006,9 +10006,7 @@ static bool update_sd_pick_busiest(struct lb_env *e= nv, switch (sgs->group_type) { case group_overloaded: /* Select the overloaded group with highest avg_load. */ - if (sgs->avg_load <=3D busiest->avg_load) - return false; - break; + return sgs->avg_load > busiest->avg_load; =20 case group_imbalanced: /* @@ -10019,18 +10017,14 @@ static bool update_sd_pick_busiest(struct lb_env = *env, =20 case group_asym_packing: /* Prefer to move from lowest priority CPU's work */ - if (sched_asym_prefer(sg->asym_prefer_cpu, sds->busiest->asym_prefer_cpu= )) - return false; - break; + return sched_asym_prefer(sds->busiest->asym_prefer_cpu, sg->asym_prefer_= cpu); =20 case group_misfit_task: /* * If we have more than one misfit sg go with the biggest * misfit. */ - if (sgs->group_misfit_task_load <=3D busiest->group_misfit_task_load) - return false; - break; + return sgs->group_misfit_task_load > busiest->group_misfit_task_load; =20 case group_smt_balance: /* --=20 2.43.0