From nobody Sun Feb 8 08:27:33 2026 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF6E01640B for ; Sat, 3 Feb 2024 23:36:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.77.166.138 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707003366; cv=none; b=iQENOG+J74VvqZZlqZIBj3YecEm8qRt8GEHczpOhmL/OglyvTOlbjYQTc0HZkcwT9SvM/7gC3b36cb/IXjiIFIEO3DYHlJLRstiJ5YfJ6oO+6iczk3PVopE4wX2OoY5Co9yfV3ULJCFMQ7k/Bgu0bWvd1WBtnSmdX37g1Azu15c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707003366; c=relaxed/simple; bh=9QAMVE7vIgYbhc9zYIQ6LwGCGWiggyyOA9kPhC2rVTc=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=L18mWVJUjiFSWVYniN8OQSzha64dDYqoXH3nBG6+U9f7X5YdEU7vFBraASYMDIv7FCL3w6M9uUA3s1wQJllZ+/Uj2j5XqPugqX35+E6sYupVmXM+XK9v0LF5YgX8NJQSB2EBDv2XD1q+Sr1ftL6f7mr35LJ7POlrOljboZ8n2aE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org; arc=none smtp.client-ip=140.77.166.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 3E888A0317; Sun, 4 Feb 2024 00:36:01 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d_HqECJQ4n_A; Sun, 4 Feb 2024 00:36:01 +0100 (CET) Received: from begin (aamiens-653-1-111-57.w83-192.abo.wanadoo.fr [83.192.234.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id B1A99A022B; Sun, 4 Feb 2024 00:36:00 +0100 (CET) Received: from samy by begin with local (Exim 4.97) (envelope-from ) id 1rWPYG-00000003Vbv-0tIp; Sun, 04 Feb 2024 00:36:00 +0100 Date: Sun, 4 Feb 2024 00:36:00 +0100 From: Samuel Thibault To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, speakup@linux-speakup.org Subject: [PATCH] speakup: Fix 8bit characters from direct synth Message-ID: <20240203233600.gu4qci36fpnro3ui@begin> Mail-Followup-To: Samuel Thibault , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, speakup@linux-speakup.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170609 (1.8.3) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When userland echoes 8bit characters to /dev/synth with e.g. echo -e '\xe9' > /dev/synth synth_write would get characters beyond 0x7f, and thus negative when char is signed. When given to synth_buffer_add which takes a u16, this would sign-extend and produce a U+ffxy character rather than U+xy. Users thus get garbled text instead of accents in their output. Let's fix this by making sure that we read unsigned characters. Signed-off-by: Samuel Thibault Fixes: 89fc2ae80bb1 ("speakup: extend synth buffer to 16bit unicode charact= ers") Cc: stable@vger.kernel.org --- drivers/accessibility/speakup/synth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/accessibility/speakup/synth.c +++ b/drivers/accessibility/speakup/synth.c @@ -208,8 +208,9 @@ void spk_do_flush(void) wake_up_process(speakup_task); } =20 -void synth_write(const char *buf, size_t count) +void synth_write(const char *_buf, size_t count) { + const unsigned char *buf =3D (const unsigned char *) _buf; while (count--) synth_buffer_add(*buf++); synth_start();