From nobody Sat Feb 7 10:08:32 2026 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AD9679DB6; Wed, 31 Jan 2024 12:59:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706705991; cv=none; b=Di7Czr7514ZplA8Wo78nvqxzPFRkZnQz4+t7VWyrIXC1IscsHq12jm8CkQ+htaFzNG6F0Paz03XyT66b/QNLefCPl5LyxAKled0XqzjiebOrxnfFi9BWCwG6twbergjEZkqGLFwi8IjOcaH7XMCAiCNvmaYafdycXN4yh47HmPg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706705991; c=relaxed/simple; bh=aLyVaR3VlTqu1yreTEdjOgowwX3EMmNbGcznpWFuzsA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BtnyEWFk7PCoCgao38+64X6WwHVmTDZjOCvof6TLmlZE8smha2acESvxN5vOCUsGN1CZNy9bhHk74niDb1JSgNZ3PlQ2jAbww2SUcOfZ+YXThoWNbJVFqclouAk+Mzh0p7Mh1tummCozfkeLu3TIlNboT2NxJtPpy2N2JSXnyLQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S5afw3y8; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S5afw3y8" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-511207d62b6so2041522e87.1; Wed, 31 Jan 2024 04:59:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706705987; x=1707310787; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oAfvNX5JYKiOP5F5+HHWWQpkc2VYumz0VDstxq+2dC0=; b=S5afw3y8sanbcQ75UHwzUePNdOi1+D9tpg37xS3eyi8fxgdhDnjBOVeFHql/+gNvNo dE4nkxUuCV+3f3cNCaLhSc7Gpa9xFbtcU1sl/Rx1dhQDL5ApOCmb0whsyHvZ38V8wyJk TavFtZyvvX76SAyV3Cwy+f4BsSMfxOefxykQdNkVOq3t9vn8R6XJIu/sOEmlT2xTHxLH 6QUkU4KafjJAQSrA+RvaN3uvC3/vp8qGm3ryXfmZmbuHooK830hj8todhtHnOuMf9XbH 5Tu/eJq1q9O3kEtE7e1vBNvgEbfn+2Zi1hE6+tl+Np0DcslULoOoGdGD6stzpr4yS4HI 3ntQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706705987; x=1707310787; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oAfvNX5JYKiOP5F5+HHWWQpkc2VYumz0VDstxq+2dC0=; b=jxJBudquYOcJxrcWbmClEmpFE4OytUDqaDLwC1+QZSq6Pl+ZXFQPD5PyEtaPSq8MAd Vu5p2wiMDw0Hu1DCVrgHRX64uGdhqY5K9U1qh4SiunBR2qRfHkLYwCw8HKy59PVYtvWu J0pCA0BHTtcbcZrKGfPGDpVSQzONU+h7HytdhS9HR6IpLYbrMqE8G/4RhHTpVtiB/2uz Ba9dbC4Wt26QrNSYe6/7SsV9B01SWOVQHAZRN104XQfV6ivwJK+keVESUBJRrNnZ3hv4 gn1Vk6BV3laJxpjMNBbZnzrNMfTYEeqeiXAEqUxDi2ebQr4krZWEVisBiYWorM+6mXCJ 5++w== X-Gm-Message-State: AOJu0YyYeA5UqQfFSsZMmoeeWeSPjT2e8tJT5xyFchibJmTOv7BgTqxZ 6tYzU87kDk8IprxFjZU38rjkwgyYykb2+kDR3ekYWzLVR6F3prm/xXc5GxW1g7OE38w= X-Google-Smtp-Source: AGHT+IHozbh85wcnYCXZXYDLJCLM9XGLrWwtHro3SkQvoxBuxVb086cAn/J1lYCBdkXRqYub3zJ7qw== X-Received: by 2002:ac2:4950:0:b0:50e:9355:a24b with SMTP id o16-20020ac24950000000b0050e9355a24bmr1003200lfi.22.1706705986343; Wed, 31 Jan 2024 04:59:46 -0800 (PST) Received: from localhost.localdomain ([188.162.49.60]) by smtp.gmail.com with ESMTPSA id h25-20020a19ca59000000b00510faaa62cfsm1361135lfj.222.2024.01.31.04.59.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 04:59:45 -0800 (PST) From: Aleksandr Shubin To: linux-kernel@vger.kernel.org Cc: Aleksandr Shubin , Conor Dooley , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Marc Kleine-Budde , Maksim Kiselev , Cristian Ciocaltea , John Watts , Cheo Fusi , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-riscv@lists.infradead.org Subject: [PATCH v8 1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller Date: Wed, 31 Jan 2024 15:59:14 +0300 Message-Id: <20240131125920.2879433-2-privatesub2@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240131125920.2879433-1-privatesub2@gmail.com> References: <20240131125920.2879433-1-privatesub2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Allwinner's D1, T113-S3 and R329 SoCs have a new pwm controller witch is different from the previous pwm-sun4i. The D1 and T113 are identical in terms of peripherals, they differ only in the architecture of the CPU core, and even share the majority of their DT. Because of that, using the same compatible makes sense. The R329 is a different SoC though, and should have a different compatible string added, especially as there is a difference in the number of channels. D1 and T113s SoCs have one PWM controller with 8 channels. R329 SoC has two PWM controllers in both power domains, one of them has 9 channels (CPUX one) and the other has 6 (CPUS one). Add a device tree binding for them. Signed-off-by: Aleksandr Shubin Reviewed-by: Conor Dooley --- .../bindings/pwm/allwinner,sun20i-pwm.yaml | 88 +++++++++++++++++++ 1 file changed, 88 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/allwinner,sun20i-= pwm.yaml diff --git a/Documentation/devicetree/bindings/pwm/allwinner,sun20i-pwm.yam= l b/Documentation/devicetree/bindings/pwm/allwinner,sun20i-pwm.yaml new file mode 100644 index 000000000000..716f75776006 --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/allwinner,sun20i-pwm.yaml @@ -0,0 +1,88 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/allwinner,sun20i-pwm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Allwinner D1, T113-S3 and R329 PWM + +maintainers: + - Aleksandr Shubin + - Brandon Cheo Fusi + +properties: + compatible: + oneOf: + - const: allwinner,sun20i-d1-pwm + - items: + - const: allwinner,sun20i-r329-pwm + - const: allwinner,sun20i-d1-pwm + + reg: + maxItems: 1 + + "#pwm-cells": + const: 3 + + clocks: + items: + - description: Bus clock + - description: 24 MHz oscillator + - description: APB0 clock + + clock-names: + items: + - const: bus + - const: hosc + - const: apb0 + + resets: + maxItems: 1 + + allwinner,pwm-channels: + $ref: /schemas/types.yaml#/definitions/uint32 + description: The number of PWM channels configured for this instance + enum: [6, 9] + +allOf: + - $ref: pwm.yaml# + + - if: + properties: + compatible: + contains: + const: allwinner,sun20i-r329-pwm + + then: + required: + - allwinner,pwm-channels + + else: + properties: + allwinner,pwm-channels: false + +unevaluatedProperties: false + +required: + - compatible + - reg + - "#pwm-cells" + - clocks + - clock-names + - resets + +examples: + - | + #include + #include + + pwm: pwm@2000c00 { + compatible =3D "allwinner,sun20i-d1-pwm"; + reg =3D <0x02000c00 0x400>; + clocks =3D <&ccu CLK_BUS_PWM>, <&dcxo>, <&ccu CLK_APB0>; + clock-names =3D "bus", "hosc", "apb0"; + resets =3D <&ccu RST_BUS_PWM>; + #pwm-cells =3D <0x3>; + }; + +... --=20 2.25.1 From nobody Sat Feb 7 10:08:32 2026 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C37D7AE6E; Wed, 31 Jan 2024 12:59:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706705998; cv=none; b=en3qVm9A05IpLC7Oj5IyIWBDdOibK3CeyU940NNlf4ruu1wnw3qFWqXp10Q96CdWVWtkDRitA2GqlhlbKtNy8YsBphu4/1Y8ljiLIPIgQWwn8dTybwyHsJ1WtClOFxkoyDD2jcBB7sMoGeCVpX6WJ86gFsHJYwhZD4GBZ3YhG5U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706705998; c=relaxed/simple; bh=xFqyPNU2KHz1qLMNwJZ4t8KZ+4wyTC5riEk2Yf4bAKg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=WoCwuv3NZ0NvjQH+FXnfi+ZjKr7lxBmIQMwI/0vscp1rShVyF3bwkYTP6wh7cDlhFkxr22pIS02184vVuD1qbAtJPAbk6z8uR8LdoOzGRpUjsiWHcQPsjg90jFF5QnDcHNGi2HNEfMPunLvTosX64RtzTvLYS81WvRtfMeqNTOE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FuH0GVBo; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FuH0GVBo" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5102a877d50so5820868e87.0; Wed, 31 Jan 2024 04:59:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706705994; x=1707310794; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LJEpMRsYLlgFAcmZofqzHXt8kLBT+ut7O+m2hghOxj0=; b=FuH0GVBoov+q437vLJ3ah8sCao696SzTdWLSy3n6wNG/MvzRcrxOKKXpp9GDoJu6Jr USVeYfLMzXLReVSQjjW+3iI7mU1yjdD4P79etHduBzqUdsUi8kCAXiM14xyYqObqsH/n Al1770mDnCysb8u3OPOgKSCjyDuYmFUdz/y11LD1dVr+Ni5U6nWRdPDINqbkrw1VZvFx lZoLN1aQMyiq1CDvp9GyUymPt6/ONWhR1YurrRdF7AguxQoEIbHyljXU0W43oVghKa/C 0T4C1ZOgTov8p8/5TFczNhDMz28V8lxXxD9InPrwnCuylqI4U3dn9pYY29IKgjcp3baL OAWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706705994; x=1707310794; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LJEpMRsYLlgFAcmZofqzHXt8kLBT+ut7O+m2hghOxj0=; b=o3HByIYMvgIQNi2tnG/U2YZ80OaXpWKPX9/ZTqhW9kZLFmi4OJVHTdzH8musHzRKh1 YBRwgJXaaF8PicpDqHXdIIZHzV0rOLJLL+jendJbxuaIWtOiSAq8mOgeSoXeQ0c9MDGv yIpT08sJ1U1en+ZQc5XHp0ZlYLhfK1AerOCExzOtO76W8wfV9aZHKNIo02gDc57l/aco 9VZtNH2wmE3DzWiK6ZSprz+zkECCM1C/P9CNgQ4XB9r5HC5KEOw673skOed2rjmXV5WV eYeW0AGe4IyIB33+/zdGKTYS38YLEEg5YlNNA64TSvu7zsnzNtOU8PqLHNAmM85ltPKY c1jQ== X-Gm-Message-State: AOJu0YzsL1AMxjtT8OySbSWUaXu0FVHZqyILP5YNF9LrzQ4l4I1/ahvl Gtcu6VGIkVVTyyDnx/iOJwesGswa9MWr161HGXsP7JNvNzJbSMaub/ke1GPuG+LhOqA= X-Google-Smtp-Source: AGHT+IGtgxJeyTQhG/aZasLr02uoyai6dB5Gw7iYCnTUM1O222ECB10oOjsvDI3WT6CNzRqjzcrFkA== X-Received: by 2002:a05:6512:ea0:b0:510:1b51:e431 with SMTP id bi32-20020a0565120ea000b005101b51e431mr1592192lfb.4.1706705993605; Wed, 31 Jan 2024 04:59:53 -0800 (PST) Received: from localhost.localdomain ([188.162.49.60]) by smtp.gmail.com with ESMTPSA id h25-20020a19ca59000000b00510faaa62cfsm1361135lfj.222.2024.01.31.04.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 04:59:53 -0800 (PST) From: Aleksandr Shubin To: linux-kernel@vger.kernel.org Cc: Aleksandr Shubin , Brandon Cheo Fusi , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Cristian Ciocaltea , John Watts , Marc Kleine-Budde , Maksim Kiselev , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-riscv@lists.infradead.org Subject: [PATCH v8 2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support Date: Wed, 31 Jan 2024 15:59:15 +0300 Message-Id: <20240131125920.2879433-3-privatesub2@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240131125920.2879433-1-privatesub2@gmail.com> References: <20240131125920.2879433-1-privatesub2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Allwinner's D1, T113-S3 and R329 SoCs have a quite different PWM controllers with ones supported by pwm-sun4i driver. This patch adds a PWM controller driver for Allwinner's D1, T113-S3 and R329 SoCs. The main difference between these SoCs is the number of channels defined by the DT property. Co-developed-by: Brandon Cheo Fusi Signed-off-by: Brandon Cheo Fusi Signed-off-by: Aleksandr Shubin --- drivers/pwm/Kconfig | 10 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-sun20i.c | 380 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 391 insertions(+) create mode 100644 drivers/pwm/pwm-sun20i.c diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index 4b956d661755..d2e0a080eb3c 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -625,6 +625,16 @@ config PWM_SUN4I To compile this driver as a module, choose M here: the module will be called pwm-sun4i. =20 +config PWM_SUN20I + tristate "Allwinner D1/T113s/R329 PWM support" + depends on ARCH_SUNXI || COMPILE_TEST + depends on COMMON_CLK + help + Generic PWM framework driver for Allwinner D1/T113s/R329 SoCs. + + To compile this driver as a module, choose M here: the module + will be called pwm-sun20i. + config PWM_SUNPLUS tristate "Sunplus PWM support" depends on ARCH_SUNPLUS || COMPILE_TEST diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile index c5ec9e168ee7..dcad0d5a2430 100644 --- a/drivers/pwm/Makefile +++ b/drivers/pwm/Makefile @@ -58,6 +58,7 @@ obj-$(CONFIG_PWM_STM32) +=3D pwm-stm32.o obj-$(CONFIG_PWM_STM32_LP) +=3D pwm-stm32-lp.o obj-$(CONFIG_PWM_STMPE) +=3D pwm-stmpe.o obj-$(CONFIG_PWM_SUN4I) +=3D pwm-sun4i.o +obj-$(CONFIG_PWM_SUN20I) +=3D pwm-sun20i.o obj-$(CONFIG_PWM_SUNPLUS) +=3D pwm-sunplus.o obj-$(CONFIG_PWM_TEGRA) +=3D pwm-tegra.o obj-$(CONFIG_PWM_TIECAP) +=3D pwm-tiecap.o diff --git a/drivers/pwm/pwm-sun20i.c b/drivers/pwm/pwm-sun20i.c new file mode 100644 index 000000000000..19bf3f495155 --- /dev/null +++ b/drivers/pwm/pwm-sun20i.c @@ -0,0 +1,380 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * PWM Controller Driver for sunxi platforms (D1, T113-S3 and R329) + * + * Limitations: + * - When the parameters change, current running period will not be comple= ted + * and run new settings immediately. + * - It output HIGH-Z state when PWM channel disabled. + * + * Copyright (c) 2023 Aleksandr Shubin + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define SUN20I_PWM_CLK_CFG(chan) (0x20 + (((chan) >> 1) * 0x4)) +#define SUN20I_PWM_CLK_CFG_SRC GENMASK(8, 7) +#define SUN20I_PWM_CLK_CFG_DIV_M GENMASK(3, 0) +#define SUN20I_PWM_CLK_DIV_M_MAX 8 + +#define SUN20I_PWM_CLK_GATE 0x40 +#define SUN20I_PWM_CLK_GATE_BYPASS(chan) BIT((chan) + 16) +#define SUN20I_PWM_CLK_GATE_GATING(chan) BIT(chan) + +#define SUN20I_PWM_ENABLE 0x80 +#define SUN20I_PWM_ENABLE_EN(chan) BIT(chan) + +#define SUN20I_PWM_CTL(chan) (0x100 + (chan) * 0x20) +#define SUN20I_PWM_CTL_ACT_STA BIT(8) +#define SUN20I_PWM_CTL_PRESCAL_K GENMASK(7, 0) +#define SUN20I_PWM_CTL_PRESCAL_K_MAX 0xff + +#define SUN20I_PWM_PERIOD(chan) (0x104 + (chan) * 0x20) +#define SUN20I_PWM_PERIOD_ENTIRE_CYCLE GENMASK(31, 16) +#define SUN20I_PWM_PERIOD_ACT_CYCLE GENMASK(15, 0) + +#define SUN20I_PWM_PCNTR_SIZE BIT(16) + +/** + * SUN20I_PWM_MAGIC is used to quickly compute the values of the clock div= iders + * div_m (SUN20I_PWM_CLK_CFG_DIV_M) & prescale_k (SUN20I_PWM_CTL_PRESCAL_K) + * without using a loop. These dividers limit the # of cycles in a period + * to SUN20I_PWM_PCNTR_SIZE by applying a scaling factor of + * 1/(div_m * (prescale_k + 1)) to the clock source. + * + * SUN20I_PWM_MAGIC is derived by solving for div_m and prescale_k + * such that for a given requested period, + * + * i) div_m is minimized for any prescale_k =E2=89=A4 SUN20I_PWM_CTL_PRESC= AL_K_MAX, + * ii) prescale_k is minimized. + * + * The derivation proceeds as follows, with val =3D # of cycles for reqest= ed + * period: + * + * for a given value of div_m we want the smallest prescale_k such that + * + * (val >> div_m) // (prescale_k + 1) =E2=89=A4 65536 (SUN20I_PWM_PCNTR_SI= ZE) + * + * This is equivalent to: + * + * (val >> div_m) =E2=89=A4 65536 * (prescale_k + 1) + prescale_k + * =E2=9F=BA (val >> div_m) =E2=89=A4 65537 * prescale_k + 65536 + * =E2=9F=BA (val >> div_m) - 65536 =E2=89=A4 65537 * prescale_k + * =E2=9F=BA ((val >> div_m) - 65536) / 65537 =E2=89=A4 prescale_k + * + * As prescale_k is integer, this becomes + * + * ((val >> div_m) - 65536) // 65537 =E2=89=A4 prescale_k + * + * And is minimized at + * + * ((val >> div_m) - 65536) // 65537 + * + * Now we pick the smallest div_m that satifies prescale_k =E2=89=A4 255 + * (i.e SUN20I_PWM_CTL_PRESCAL_K_MAX), + * + * ((val >> div_m) - 65536) // 65537 =E2=89=A4 255 + * =E2=9F=BA (val >> div_m) - 65536 =E2=89=A4 255 * 65537 + 65536 + * =E2=9F=BA val >> div_m =E2=89=A4 255 * 65537 + 2 * 65536 + * =E2=9F=BA val >> div_m < (255 * 65537 + 2 * 65536 + 1) + * =E2=9F=BA div_m =3D fls((val) / (255 * 65537 + 2 * 65536 + 1)) + * + * Suggested by Uwe Kleine-K=C3=B6nig + */ +#define SUN20I_PWM_MAGIC (255 * 65537 + 2 * 65536 + 1) + +struct sun20i_pwm_chip { + struct clk *clk_bus, *clk_hosc, *clk_apb0; + struct reset_control *rst; + struct pwm_chip chip; + void __iomem *base; + /* Mutex to protect pwm apply state */ + struct mutex mutex; +}; + +static inline struct sun20i_pwm_chip *to_sun20i_pwm_chip(struct pwm_chip *= chip) +{ + return container_of(chip, struct sun20i_pwm_chip, chip); +} + +static inline u32 sun20i_pwm_readl(struct sun20i_pwm_chip *chip, + unsigned long offset) +{ + return readl(chip->base + offset); +} + +static inline void sun20i_pwm_writel(struct sun20i_pwm_chip *chip, + u32 val, unsigned long offset) +{ + writel(val, chip->base + offset); +} + +static int sun20i_pwm_get_state(struct pwm_chip *chip, + struct pwm_device *pwm, + struct pwm_state *state) +{ + struct sun20i_pwm_chip *sun20i_chip =3D to_sun20i_pwm_chip(chip); + u16 ent_cycle, act_cycle, prescale_k; + u64 clk_rate, tmp; + u8 div_m; + u32 val; + + mutex_lock(&sun20i_chip->mutex); + + val =3D sun20i_pwm_readl(sun20i_chip, SUN20I_PWM_CLK_CFG(pwm->hwpwm)); + div_m =3D FIELD_GET(SUN20I_PWM_CLK_CFG_DIV_M, val); + if (div_m > SUN20I_PWM_CLK_DIV_M_MAX) + div_m =3D SUN20I_PWM_CLK_DIV_M_MAX; + + if (FIELD_GET(SUN20I_PWM_CLK_CFG_SRC, val) =3D=3D 0) + clk_rate =3D clk_get_rate(sun20i_chip->clk_hosc); + else + clk_rate =3D clk_get_rate(sun20i_chip->clk_apb0); + + val =3D sun20i_pwm_readl(sun20i_chip, SUN20I_PWM_CTL(pwm->hwpwm)); + state->polarity =3D (SUN20I_PWM_CTL_ACT_STA & val) ? + PWM_POLARITY_NORMAL : PWM_POLARITY_INVERSED; + + prescale_k =3D FIELD_GET(SUN20I_PWM_CTL_PRESCAL_K, val) + 1; + + val =3D sun20i_pwm_readl(sun20i_chip, SUN20I_PWM_ENABLE); + state->enabled =3D (SUN20I_PWM_ENABLE_EN(pwm->hwpwm) & val) ? true : fals= e; + + val =3D sun20i_pwm_readl(sun20i_chip, SUN20I_PWM_PERIOD(pwm->hwpwm)); + + mutex_unlock(&sun20i_chip->mutex); + + act_cycle =3D FIELD_GET(SUN20I_PWM_PERIOD_ACT_CYCLE, val); + ent_cycle =3D FIELD_GET(SUN20I_PWM_PERIOD_ENTIRE_CYCLE, val); + + /* + * The duration of the active phase should not be longer + * than the duration of the period + */ + if (act_cycle > ent_cycle) + act_cycle =3D ent_cycle; + + tmp =3D ((u64)(act_cycle) * prescale_k << div_m) * NSEC_PER_SEC; + state->duty_cycle =3D DIV_ROUND_UP_ULL(tmp, clk_rate); + tmp =3D ((u64)(ent_cycle) * prescale_k << div_m) * NSEC_PER_SEC; + state->period =3D DIV_ROUND_UP_ULL(tmp, clk_rate); + + return 0; +} + +static int sun20i_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, + const struct pwm_state *state) +{ + struct sun20i_pwm_chip *sun20i_chip =3D to_sun20i_pwm_chip(chip); + u64 bus_rate, hosc_rate, val, ent_cycle, act_cycle; + u32 clk_gate, clk_cfg, pwm_en, ctl, reg_period; + u32 prescale_k, div_m; + bool use_bus_clk; + int ret =3D 0; + + mutex_lock(&sun20i_chip->mutex); + + pwm_en =3D sun20i_pwm_readl(sun20i_chip, SUN20I_PWM_ENABLE); + + if (state->enabled !=3D pwm->state.enabled) { + clk_gate =3D sun20i_pwm_readl(sun20i_chip, SUN20I_PWM_CLK_GATE); + + if (!state->enabled) { + clk_gate &=3D ~SUN20I_PWM_CLK_GATE_GATING(pwm->hwpwm); + pwm_en &=3D ~SUN20I_PWM_ENABLE_EN(pwm->hwpwm); + sun20i_pwm_writel(sun20i_chip, pwm_en, SUN20I_PWM_ENABLE); + sun20i_pwm_writel(sun20i_chip, clk_gate, SUN20I_PWM_CLK_GATE); + } + } + + if (state->polarity !=3D pwm->state.polarity || + state->duty_cycle !=3D pwm->state.duty_cycle || + state->period !=3D pwm->state.period) { + ctl =3D sun20i_pwm_readl(sun20i_chip, SUN20I_PWM_CTL(pwm->hwpwm)); + clk_cfg =3D sun20i_pwm_readl(sun20i_chip, SUN20I_PWM_CLK_CFG(pwm->hwpwm)= ); + hosc_rate =3D clk_get_rate(sun20i_chip->clk_hosc); + bus_rate =3D clk_get_rate(sun20i_chip->clk_apb0); + if (pwm_en & SUN20I_PWM_ENABLE_EN(pwm->hwpwm ^ 1)) { + /* if the neighbor channel is enable, check period only */ + use_bus_clk =3D FIELD_GET(SUN20I_PWM_CLK_CFG_SRC, clk_cfg) !=3D 0; + val =3D mul_u64_u64_div_u64(state->period, + (use_bus_clk ? bus_rate : hosc_rate), + NSEC_PER_SEC); + + div_m =3D FIELD_GET(SUN20I_PWM_CLK_CFG_DIV_M, clk_cfg); + } else { + /* check period and select clock source */ + use_bus_clk =3D false; + val =3D mul_u64_u64_div_u64(state->period, hosc_rate, NSEC_PER_SEC); + if (val <=3D 1) { + use_bus_clk =3D true; + val =3D mul_u64_u64_div_u64(state->period, bus_rate, NSEC_PER_SEC); + if (val <=3D 1) { + ret =3D -EINVAL; + goto unlock_mutex; + } + } + div_m =3D fls(DIV_ROUND_DOWN_ULL(val, SUN20I_PWM_MAGIC)); + if (div_m > SUN20I_PWM_CLK_DIV_M_MAX) { + ret =3D -EINVAL; + goto unlock_mutex; + } + + /* set up the CLK_DIV_M and clock CLK_SRC */ + clk_cfg =3D FIELD_PREP(SUN20I_PWM_CLK_CFG_DIV_M, div_m); + clk_cfg |=3D FIELD_PREP(SUN20I_PWM_CLK_CFG_SRC, use_bus_clk); + + sun20i_pwm_writel(sun20i_chip, clk_cfg, SUN20I_PWM_CLK_CFG(pwm->hwpwm)); + } + + /* calculate prescale_k, PWM entire cycle */ + ent_cycle =3D val >> div_m; + prescale_k =3D DIV_ROUND_DOWN_ULL(ent_cycle, 65537); + if (prescale_k > SUN20I_PWM_CTL_PRESCAL_K_MAX) + prescale_k =3D SUN20I_PWM_CTL_PRESCAL_K_MAX; + + do_div(ent_cycle, prescale_k + 1); + + /* for N cycles, PPRx.PWM_ENTIRE_CYCLE =3D (N-1) */ + reg_period =3D FIELD_PREP(SUN20I_PWM_PERIOD_ENTIRE_CYCLE, ent_cycle - 1); + + /* set duty cycle */ + val =3D mul_u64_u64_div_u64(state->duty_cycle, + (use_bus_clk ? bus_rate : hosc_rate), + NSEC_PER_SEC); + act_cycle =3D val >> div_m; + do_div(act_cycle, prescale_k + 1); + + /* + * The formula of the output period and the duty-cycle for PWM are as fo= llows. + * T period =3D (PWM01_CLK / PWM0_PRESCALE_K)^-1 * (PPR0.PWM_ENTIRE_CYCL= E + 1) + * T high-level =3D (PWM01_CLK / PWM0_PRESCALE_K)^-1 * PPR0.PWM_ACT_CYCLE + * Duty-cycle =3D T high-level / T period + */ + reg_period |=3D FIELD_PREP(SUN20I_PWM_PERIOD_ACT_CYCLE, act_cycle); + sun20i_pwm_writel(sun20i_chip, reg_period, SUN20I_PWM_PERIOD(pwm->hwpwm)= ); + + ctl =3D FIELD_PREP(SUN20I_PWM_CTL_PRESCAL_K, prescale_k); + if (state->polarity =3D=3D PWM_POLARITY_NORMAL) + ctl |=3D SUN20I_PWM_CTL_ACT_STA; + + sun20i_pwm_writel(sun20i_chip, ctl, SUN20I_PWM_CTL(pwm->hwpwm)); + } + + if (state->enabled !=3D pwm->state.enabled && state->enabled) { + clk_gate &=3D ~SUN20I_PWM_CLK_GATE_BYPASS(pwm->hwpwm); + clk_gate |=3D SUN20I_PWM_CLK_GATE_GATING(pwm->hwpwm); + pwm_en |=3D SUN20I_PWM_ENABLE_EN(pwm->hwpwm); + sun20i_pwm_writel(sun20i_chip, pwm_en, SUN20I_PWM_ENABLE); + sun20i_pwm_writel(sun20i_chip, clk_gate, SUN20I_PWM_CLK_GATE); + } + +unlock_mutex: + mutex_unlock(&sun20i_chip->mutex); + + return ret; +} + +static const struct pwm_ops sun20i_pwm_ops =3D { + .apply =3D sun20i_pwm_apply, + .get_state =3D sun20i_pwm_get_state, +}; + +static const struct of_device_id sun20i_pwm_dt_ids[] =3D { + { .compatible =3D "allwinner,sun20i-d1-pwm" }, + { }, +}; +MODULE_DEVICE_TABLE(of, sun20i_pwm_dt_ids); + +static int sun20i_pwm_probe(struct platform_device *pdev) +{ + struct sun20i_pwm_chip *sun20i_chip; + int ret; + + sun20i_chip =3D devm_kzalloc(&pdev->dev, sizeof(*sun20i_chip), GFP_KERNEL= ); + if (!sun20i_chip) + return -ENOMEM; + + sun20i_chip->base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(sun20i_chip->base)) + return PTR_ERR(sun20i_chip->base); + + sun20i_chip->clk_bus =3D devm_clk_get_enabled(&pdev->dev, "bus"); + if (IS_ERR(sun20i_chip->clk_bus)) + return dev_err_probe(&pdev->dev, PTR_ERR(sun20i_chip->clk_bus), + "failed to get bus clock\n"); + + sun20i_chip->clk_hosc =3D devm_clk_get_enabled(&pdev->dev, "hosc"); + if (IS_ERR(sun20i_chip->clk_hosc)) + return dev_err_probe(&pdev->dev, PTR_ERR(sun20i_chip->clk_hosc), + "failed to get hosc clock\n"); + + sun20i_chip->clk_apb0 =3D devm_clk_get_enabled(&pdev->dev, "apb0"); + if (IS_ERR(sun20i_chip->clk_apb0)) + return dev_err_probe(&pdev->dev, PTR_ERR(sun20i_chip->clk_apb0), + "failed to get apb0 clock\n"); + + sun20i_chip->rst =3D devm_reset_control_get_exclusive(&pdev->dev, NULL); + if (IS_ERR(sun20i_chip->rst)) + return dev_err_probe(&pdev->dev, PTR_ERR(sun20i_chip->rst), + "failed to get bus reset\n"); + + ret =3D of_property_read_u32(pdev->dev.of_node, "allwinner,pwm-channels", + &sun20i_chip->chip.npwm); + if (ret) + sun20i_chip->chip.npwm =3D 8; + + if (sun20i_chip->chip.npwm > 16) + sun20i_chip->chip.npwm =3D 16; + + /* Deassert reset */ + ret =3D reset_control_deassert(sun20i_chip->rst); + if (ret) + return dev_err_probe(&pdev->dev, ret, "failed to deassert reset\n"); + + sun20i_chip->chip.dev =3D &pdev->dev; + sun20i_chip->chip.ops =3D &sun20i_pwm_ops; + + mutex_init(&sun20i_chip->mutex); + + ret =3D pwmchip_add(&sun20i_chip->chip); + if (ret < 0) { + reset_control_assert(sun20i_chip->rst); + return dev_err_probe(&pdev->dev, ret, "failed to add PWM chip\n"); + } + + platform_set_drvdata(pdev, sun20i_chip); + + return 0; +} + +static void sun20i_pwm_remove(struct platform_device *pdev) +{ + struct sun20i_pwm_chip *sun20i_chip =3D platform_get_drvdata(pdev); + + pwmchip_remove(&sun20i_chip->chip); + + reset_control_assert(sun20i_chip->rst); +} + +static struct platform_driver sun20i_pwm_driver =3D { + .driver =3D { + .name =3D "sun20i-pwm", + .of_match_table =3D sun20i_pwm_dt_ids, + }, + .probe =3D sun20i_pwm_probe, + .remove_new =3D sun20i_pwm_remove, +}; +module_platform_driver(sun20i_pwm_driver); + +MODULE_AUTHOR("Aleksandr Shubin "); +MODULE_DESCRIPTION("Allwinner sun20i PWM driver"); +MODULE_LICENSE("GPL"); --=20 2.25.1 From nobody Sat Feb 7 10:08:32 2026 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7A4B7AE77; Wed, 31 Jan 2024 13:00:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706706004; cv=none; b=NWD/r6mat4lxyeULnFo7Kdk/Z5/skFY48Taw1lSyVTclohbYsO2IQKcYztMDIMn4L4iGptsDQmgwl9rfrM60qJzDFuNgzXfPl+gt+p5Vl93t/Q7Q8R/uo4TNVxj4B5Hbx6JcSVaD8iydp8vcDEl7g198+dy969ILh7IihLrdC68= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706706004; c=relaxed/simple; bh=o9E9ecVEg59roajJUTj0tBIXTNYmbmyw1ntarzjaXAA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WLdX7pzu8TR9h+3iUuq0yM3mjDRSjUMXTnDDjp+nweKOIsIObJ8sTcE/InS6R1Dws3SbkzqHnkdGKIN9XzKDJ+Q8RsKR/eWjWKcP39f6WpJvQ1XddccJBovgsiu07RXj4IB4N8xvuvtRj5hZe/T49XBPxhg7CuJuAWzjbtLIdcs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TWryhVC6; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TWryhVC6" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2d043160cd1so41995511fa.1; Wed, 31 Jan 2024 05:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706706000; x=1707310800; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qk5axihAKFS9+0dIUTMZ/jrL2YTkFropx3eyJ2mG6qU=; b=TWryhVC66Q3S0YPXg3zoZJMIvLpNudHoTn2NUWbTvVFxELIGKK6PA0IK1oAUPxeoOP ZCstzxmsfSkyr+rsRdXE4/n1QKidHq1lZKrIJBZbVc6ibZWUmO4b+iTOUTeUzr8n5316 WRUER4qODGIzSXXJzGUaLiiZSStX29yTrt+f38bbOpiOmlmyLmdL4STywrDT2kG16tof FdzpVjL57Ciq4p5T1fEpsCysJLX3T9yb2LlCEk3od2iNYq10jJdv2u5WBfeV0FRo+LV/ ln+I7YytLa2vtvNE/eQwJXV9xoDwOyNCLVgnIQKZ8UsaUvxc25JMGyqDrUBE6l9VlsjV pz7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706706000; x=1707310800; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qk5axihAKFS9+0dIUTMZ/jrL2YTkFropx3eyJ2mG6qU=; b=a60JoV5vS7xovzPWoJukXVpau2iur8Av7yyNyUrW0jdNP0qqWTdKv5aAIov7VepbrL QMS3tw6DyVLsUVZqYqnU+9OYRIyh6yQwDelI/NSy3LoNX7dTkT62bM9K/KurAMvOmPmq 4ZQ9vCKMQ/r03gZIH++4u1kjBcGDqL/t/MyvCoXxL2Or5tM0Qs2dgZk/OUQPZNZqWJnY e/Z8EXeZSCweNQ4rG/44p3X02UOZAIffk5fi4wpHZwbZim1WY0WobjuAamCq5uc+UvXy xjWUfC551B68gu5Vlq1SdM2otI7WxwpjwbplHVSwXheRHSUZCgJmyZQVxfDzXdJi8WVe ABZw== X-Gm-Message-State: AOJu0YzNplm8IyXrXhune1BvFjarkLWnZ4771zIcEuG6ZCIGdD7Fzo6s EWxkr1G/5rwZDvefHr0F5UeshjlwkA3wdIPI+bFJtZJtnkypVJFbhmHKTvNd8OsIKyo= X-Google-Smtp-Source: AGHT+IFlj/2UQlXVTsP85U+sX9Z4Xg+m+7M8urgFGxXNNIrMtV2ixCb6BE8A2Y9DZeChVhyFjSIIgA== X-Received: by 2002:a05:6512:3b93:b0:511:1ed7:61bd with SMTP id g19-20020a0565123b9300b005111ed761bdmr1608967lfv.54.1706706000644; Wed, 31 Jan 2024 05:00:00 -0800 (PST) Received: from localhost.localdomain ([188.162.49.60]) by smtp.gmail.com with ESMTPSA id h25-20020a19ca59000000b00510faaa62cfsm1361135lfj.222.2024.01.31.04.59.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 04:59:59 -0800 (PST) From: Aleksandr Shubin To: linux-kernel@vger.kernel.org Cc: Aleksandr Shubin , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Maksim Kiselev , Cristian Ciocaltea , Marc Kleine-Budde , John Watts , Cheo Fusi , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-riscv@lists.infradead.org Subject: [PATCH v8 3/3] riscv: dts: allwinner: d1: Add pwm node Date: Wed, 31 Jan 2024 15:59:16 +0300 Message-Id: <20240131125920.2879433-4-privatesub2@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240131125920.2879433-1-privatesub2@gmail.com> References: <20240131125920.2879433-1-privatesub2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" D1 and T113s contain a pwm controller with 8 channels. This controller is supported by the sun20i-pwm driver. Add a device tree node for it. Signed-off-by: Aleksandr Shubin Reviewed-by: Andre Przywara --- arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi b/arch/riscv= /boot/dts/allwinner/sunxi-d1s-t113.dtsi index 5a9d7f5a75b4..435a1e66aa6a 100644 --- a/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi +++ b/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi @@ -145,6 +145,18 @@ uart3_pb_pins: uart3-pb-pins { }; }; =20 + pwm: pwm@2000c00 { + compatible =3D "allwinner,sun20i-d1-pwm"; + reg =3D <0x02000c00 0x400>; + clocks =3D <&ccu CLK_BUS_PWM>, + <&dcxo>, + <&ccu CLK_APB0>; + clock-names =3D "bus", "hosc", "apb0"; + resets =3D <&ccu RST_BUS_PWM>; + status =3D "disabled"; + #pwm-cells =3D <0x3>; + }; + ccu: clock-controller@2001000 { compatible =3D "allwinner,sun20i-d1-ccu"; reg =3D <0x2001000 0x1000>; --=20 2.25.1