From nobody Tue Dec 23 22:07:53 2025 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B08310793 for ; Wed, 31 Jan 2024 03:55:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706673349; cv=none; b=ULhjCDkD96aN5HcOvIcwPZO0Dd5dJHbD5xgLk830ntvLs2iEtVEMaoKOUXhImdWfOv2XK9/FRU3t/W1BtGlKzCdxTeKRPyHZwtuVfyA/TEX+laJvPf4IUk2Tjje6ZWbFFzUliQyROnjht8FsUaHgaxm8oZO82L2NVsQdm9zVl7o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706673349; c=relaxed/simple; bh=3eYmQ3dJsBvcxiCOUDPVxQ8QBgs7NpCaIY0MsgBedKg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Vq0K19qI6UskcHOhUQ/s+qQ75m70XICL4/jCkSg5L4B6VEH1HQw/wXAAKg7CQ99R+moOKNweojYdoAhz7Ut37+4pK3AEtuC2YC9MOHu4v0jeZFQe4Nbt91g4ukCBqIzyido7sGGU9ZO8/m2L8GLWXjqPoQi42i5N3hzvz0rdMnY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SoINa1df; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SoINa1df" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6de0f53f8e8so388685b3a.0 for ; Tue, 30 Jan 2024 19:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706673347; x=1707278147; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=i0RiB2J9TsGrKN0zmH0Y/9LtHAwiNldnnpE0kXLBAF4=; b=SoINa1dfVQdWv5PDLPmkqqyplZEl6L8CP8StTrTcdeJQ+3C6xfZ69g0ESDZTz1oY49 4VLIlnWE6gw3ulUy4JNOD59d0STUA6VW/fQCQSDOYoN4h+xbOPFn0uQeCICTrBeiQgPo HkFUCIO0+ITjvYeTn27S1C+1/iJUCXkxpTDfpTvnN/p3XI26zwOUB0mXgIs7DSlt1Cdu k2ycTBlMhVVyWNCXREfS6Igubv4VXEF6ct1ErwrvTOmmuFRiAM72OW6iduqQecJkloXh 9j2kIM7LWvtI3e9bVPBDn3F7+iLCrvQpcPvbl/OpQeKbNuv5IqndR344HRiBfbJ+6kHn 31Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706673347; x=1707278147; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i0RiB2J9TsGrKN0zmH0Y/9LtHAwiNldnnpE0kXLBAF4=; b=SZxALV2UfCnr63i2hR4Up6yksRSjh9eDASPS0JE4aORJbBSeB0JqOKhjrgy5DrZzx3 OACbvilLe7BMFqU+YmQSrbrEBBOovNaYcqkynyZAodVtH+x/X0BNHpXeT7q06PyH2UWh ACg4G2ZZ3uK9TCsO+X+qoqzlah2Bz/7bpHNWfYS14Vu+lpgkuGfQ3RpLWxhibrpTyD/4 sjoSuq590ZkeuMlzOcVLi8KkMdi5dkpx5h3HIjrbKBinWc5wzmdnLQEo0Wo/y4zrOvFj wXYALexOrXKWhdU+JSN4pr8IHoEgjDZVDyUhgEObw4WXT9fD2/COx5aqtnaxICvLtf/R v1bw== X-Gm-Message-State: AOJu0YzBWhBdo8UTf6H/BDp2Cv0yziy4L0TpSmAjjjA/u/cPXBF/saps FrhLCRnaB3TLdKU6HdnrESO5dWc0aVwc2STW53zDwCSZxKoPQx5h X-Google-Smtp-Source: AGHT+IHAHWpfSaKyH8nbEySVvrjEY4tH5GSlSxBkHYdxI86U3rTdtKh2lP8QDwzl47bD1g8DVf3OWQ== X-Received: by 2002:a05:6a00:995:b0:6de:2470:92e1 with SMTP id u21-20020a056a00099500b006de247092e1mr627835pfg.15.1706673346505; Tue, 30 Jan 2024 19:55:46 -0800 (PST) Received: from localhost.localdomain ([111.199.1.183]) by smtp.googlemail.com with ESMTPSA id j8-20020a056a00234800b006d6b91c6eb6sm8988344pfj.13.2024.01.30.19.55.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 19:55:45 -0800 (PST) From: Liang Chen To: mst@redhat.com, jasowang@redhat.com, hengqi@linux.alibaba.com, xuanzhuo@linux.alibaba.com Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, liangchen.linux@gmail.com Subject: [PATCH v4] virtio_net: Support RX hash XDP hint Date: Wed, 31 Jan 2024 11:55:35 +0800 Message-Id: <20240131035535.22258-1-liangchen.linux@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The RSS hash report is a feature that's part of the virtio specification. Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost (still a work in progress as per [1]) support this feature. While the capability to obtain the RSS hash has been enabled in the normal path, it's currently missing in the XDP path. Therefore, we are introducing XDP hints through kfuncs to allow XDP programs to access the RSS hash. 1. https://lore.kernel.org/all/20231015141644.260646-1-akihiko.odaki@daynix.co= m/#r Signed-off-by: Liang Chen Reviewed-by: Xuan Zhuo Acked-by: Jason Wang --- drivers/net/virtio_net.c | 98 +++++++++++++++++++++++++++++++++++----- 1 file changed, 86 insertions(+), 12 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index d7ce4a1011ea..7ce666c86ee0 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -349,6 +349,12 @@ struct virtio_net_common_hdr { }; }; =20 +struct virtnet_xdp_buff { + struct xdp_buff xdp; + __le32 hash_value; + __le16 hash_report; +}; + static void virtnet_sq_free_unused_buf(struct virtqueue *vq, void *buf); =20 static bool is_xdp_frame(void *ptr) @@ -1033,6 +1039,16 @@ static void put_xdp_frags(struct xdp_buff *xdp) } } =20 +static void virtnet_xdp_save_rx_hash(struct virtnet_xdp_buff *virtnet_xdp, + struct net_device *dev, + struct virtio_net_hdr_v1_hash *hdr_hash) +{ + if (dev->features & NETIF_F_RXHASH) { + virtnet_xdp->hash_value =3D hdr_hash->hash_value; + virtnet_xdp->hash_report =3D hdr_hash->hash_report; + } +} + static int virtnet_xdp_handler(struct bpf_prog *xdp_prog, struct xdp_buff = *xdp, struct net_device *dev, unsigned int *xdp_xmit, @@ -1199,9 +1215,10 @@ static struct sk_buff *receive_small_xdp(struct net_= device *dev, unsigned int headroom =3D vi->hdr_len + header_offset; struct virtio_net_hdr_mrg_rxbuf *hdr =3D buf + header_offset; struct page *page =3D virt_to_head_page(buf); + struct virtnet_xdp_buff virtnet_xdp; struct page *xdp_page; + struct xdp_buff *xdp; unsigned int buflen; - struct xdp_buff xdp; struct sk_buff *skb; unsigned int metasize =3D 0; u32 act; @@ -1233,17 +1250,20 @@ static struct sk_buff *receive_small_xdp(struct net= _device *dev, page =3D xdp_page; } =20 - xdp_init_buff(&xdp, buflen, &rq->xdp_rxq); - xdp_prepare_buff(&xdp, buf + VIRTNET_RX_PAD + vi->hdr_len, + xdp =3D &virtnet_xdp.xdp; + xdp_init_buff(xdp, buflen, &rq->xdp_rxq); + xdp_prepare_buff(xdp, buf + VIRTNET_RX_PAD + vi->hdr_len, xdp_headroom, len, true); =20 - act =3D virtnet_xdp_handler(xdp_prog, &xdp, dev, xdp_xmit, stats); + virtnet_xdp_save_rx_hash(&virtnet_xdp, dev, (void *)hdr); + + act =3D virtnet_xdp_handler(xdp_prog, xdp, dev, xdp_xmit, stats); =20 switch (act) { case XDP_PASS: /* Recalculate length in case bpf program changed it */ - len =3D xdp.data_end - xdp.data; - metasize =3D xdp.data - xdp.data_meta; + len =3D xdp->data_end - xdp->data; + metasize =3D xdp->data - xdp->data_meta; break; =20 case XDP_TX: @@ -1254,7 +1274,7 @@ static struct sk_buff *receive_small_xdp(struct net_d= evice *dev, goto err_xdp; } =20 - skb =3D virtnet_build_skb(buf, buflen, xdp.data - buf, len); + skb =3D virtnet_build_skb(buf, buflen, xdp->data - buf, len); if (unlikely(!skb)) goto err; =20 @@ -1591,10 +1611,11 @@ static struct sk_buff *receive_mergeable_xdp(struct= net_device *dev, int num_buf =3D virtio16_to_cpu(vi->vdev, hdr->num_buffers); struct page *page =3D virt_to_head_page(buf); int offset =3D buf - page_address(page); + struct virtnet_xdp_buff virtnet_xdp; unsigned int xdp_frags_truesz =3D 0; struct sk_buff *head_skb; unsigned int frame_sz; - struct xdp_buff xdp; + struct xdp_buff *xdp; void *data; u32 act; int err; @@ -1604,16 +1625,19 @@ static struct sk_buff *receive_mergeable_xdp(struct= net_device *dev, if (unlikely(!data)) goto err_xdp; =20 - err =3D virtnet_build_xdp_buff_mrg(dev, vi, rq, &xdp, data, len, frame_sz, + xdp =3D &virtnet_xdp.xdp; + err =3D virtnet_build_xdp_buff_mrg(dev, vi, rq, xdp, data, len, frame_sz, &num_buf, &xdp_frags_truesz, stats); if (unlikely(err)) goto err_xdp; =20 - act =3D virtnet_xdp_handler(xdp_prog, &xdp, dev, xdp_xmit, stats); + virtnet_xdp_save_rx_hash(&virtnet_xdp, dev, (void *)hdr); + + act =3D virtnet_xdp_handler(xdp_prog, xdp, dev, xdp_xmit, stats); =20 switch (act) { case XDP_PASS: - head_skb =3D build_skb_from_xdp_buff(dev, vi, &xdp, xdp_frags_truesz); + head_skb =3D build_skb_from_xdp_buff(dev, vi, xdp, xdp_frags_truesz); if (unlikely(!head_skb)) break; return head_skb; @@ -1626,7 +1650,7 @@ static struct sk_buff *receive_mergeable_xdp(struct n= et_device *dev, break; } =20 - put_xdp_frags(&xdp); + put_xdp_frags(xdp); =20 err_xdp: put_page(page); @@ -4579,6 +4603,55 @@ static void virtnet_set_big_packets(struct virtnet_i= nfo *vi, const int mtu) } } =20 +static int virtnet_xdp_rx_hash(const struct xdp_md *_ctx, u32 *hash, + enum xdp_rss_hash_type *rss_type) +{ + const struct virtnet_xdp_buff *virtnet_xdp =3D (void *)_ctx; + + if (!(virtnet_xdp->xdp.rxq->dev->features & NETIF_F_RXHASH)) + return -ENODATA; + + switch (__le16_to_cpu(virtnet_xdp->hash_report)) { + case VIRTIO_NET_HASH_REPORT_TCPv4: + *rss_type =3D XDP_RSS_TYPE_L4_IPV4_TCP; + break; + case VIRTIO_NET_HASH_REPORT_UDPv4: + *rss_type =3D XDP_RSS_TYPE_L4_IPV4_UDP; + break; + case VIRTIO_NET_HASH_REPORT_TCPv6: + *rss_type =3D XDP_RSS_TYPE_L4_IPV6_TCP; + break; + case VIRTIO_NET_HASH_REPORT_UDPv6: + *rss_type =3D XDP_RSS_TYPE_L4_IPV6_UDP; + break; + case VIRTIO_NET_HASH_REPORT_TCPv6_EX: + *rss_type =3D XDP_RSS_TYPE_L4_IPV6_TCP_EX; + break; + case VIRTIO_NET_HASH_REPORT_UDPv6_EX: + *rss_type =3D XDP_RSS_TYPE_L4_IPV6_UDP_EX; + break; + case VIRTIO_NET_HASH_REPORT_IPv4: + *rss_type =3D XDP_RSS_TYPE_L3_IPV4; + break; + case VIRTIO_NET_HASH_REPORT_IPv6: + *rss_type =3D XDP_RSS_TYPE_L3_IPV6; + break; + case VIRTIO_NET_HASH_REPORT_IPv6_EX: + *rss_type =3D XDP_RSS_TYPE_L3_IPV6_EX; + break; + case VIRTIO_NET_HASH_REPORT_NONE: + default: + *rss_type =3D XDP_RSS_TYPE_NONE; + } + + *hash =3D __le32_to_cpu(virtnet_xdp->hash_value); + return 0; +} + +static const struct xdp_metadata_ops virtnet_xdp_metadata_ops =3D { + .xmo_rx_hash =3D virtnet_xdp_rx_hash, +}; + static int virtnet_probe(struct virtio_device *vdev) { int i, err =3D -ENOMEM; @@ -4704,6 +4777,7 @@ static int virtnet_probe(struct virtio_device *vdev) VIRTIO_NET_RSS_HASH_TYPE_UDP_EX); =20 dev->hw_features |=3D NETIF_F_RXHASH; + dev->xdp_metadata_ops =3D &virtnet_xdp_metadata_ops; } =20 if (vi->has_rss_hash_report) --=20 2.42.0