From nobody Wed Dec 24 19:53:59 2025 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C195C171B6 for ; Wed, 24 Jan 2024 07:36:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081810; cv=none; b=OVz7Cmbmp13kROluevGVSvmvrC2GN3DDs4DWMPPu+n1l8mesqHoSfgkjAefHpLv+extXwYvjnbAuwKykTH8TGXGxyvlsFxC2l1y5RJXR0nUi9sAH82XTtp1jdjaJC5x/1Af69tPLG4000F8pPjjbabh047cbewD89AabntYOfVw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081810; c=relaxed/simple; bh=/R7t+UW6ZmKuKk7MIzT+d0YPo+66e3175rDe543o5Ic=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=otK9XPV6ArTjniCgoKEjiYYIh7NQf1qum6igYMWftELKOcn8EjRMR+1ITYN/4/cHQmB3AbOeiu7EsDRXozp2LkiKprbR4wBoSGoVR/0stR8lMk/3s8uSCMNb9YTPCbKW+DzjKqlgMeW/7aOJOuET7W2b+BkeX5uKXC80DSJqZFQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xw7XR1sz; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xw7XR1sz" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-5c65ca2e1eeso2604237a12.2 for ; Tue, 23 Jan 2024 23:36:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081808; x=1706686608; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=acrJlYqUICjl/fNKMSHxOuQG7AfEPQFGVB71vx3dR1c=; b=xw7XR1sziAZ9Fekybmr6IJJmuasmXwcJaqZq7Y/6G34PwyVCTEBRE6U0PA84yEyUS2 fc+9IUxX/312U7dKSdaD9Tv209aho6w2SuXYM9WSFTzGv8lgyV9dG8YzItvKFsmtfLwo /yut60Qs+SYf6ovj67P1iEBX4dNBtQ3vDEMsETSqphZdycWJAR9s6Lhm7a8QeemqBb9T ISLEqMkenTpk41zjccCXaqXjAQ2Zd6WIN0bTNxMoJybvdl/Xzyk/zC/7K/szpk4tuCdv yB7l0LL35hx7pHiAxEsqy78kM+v4B3DYMuQKlEedF1Aj1OJTiru0VAMEuaEWSkdEDdtW 63Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081808; x=1706686608; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=acrJlYqUICjl/fNKMSHxOuQG7AfEPQFGVB71vx3dR1c=; b=bTcqTIRiX3IaIZzLftO5IutWwOaex+4QfiST3H5L9z6y8gX5S5zd5i1WXqZejoYBJz hEJeHi7oiik646e4XjQdzG6aenq/HOTysWRYt6dEM/iYuh6+nbKRj6vxp6rbyjhNyPSj R4djhloQKv8MTmECfCS7IZXuD2eD8xlweIL0P4y7b+N8y/VuRIme4QsCWqWZJ1S5lIaL uXYHJFsedaCtnRnUd7TeAaMQCfPQxHO9pISAou/WADTcXZLrcOH+hUr1hmApZh6Q3Usu 8+S1pNi2KxzsbOGbckXTpSeMB+m0BwRxKR1//7YpgqCTi6f7lJZz6g7t9CEdvUHoNIcK DfKQ== X-Gm-Message-State: AOJu0YyVnMgzt14P0nNp5R90ux8HuzOazWVgY0cIz3uV0IwxwiG1VeGy P/D4mC9Az2e0CFOLEn1tMm6GGgTznlSH4W3RlkF1yNDZZbZz3+2uCHrab+qfFw== X-Google-Smtp-Source: AGHT+IHMZADYbjyE70v0RtIuM4joKlEWmfgzB62tpW1UDbeUqXCniEdLIob+5sbOtqxUtYoqeFybMg== X-Received: by 2002:a05:6a20:bf03:b0:199:aeaf:cd3b with SMTP id gc3-20020a056a20bf0300b00199aeafcd3bmr270676pzb.42.1706081808139; Tue, 23 Jan 2024 23:36:48 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.36.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:36:47 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:29 +0530 Subject: [PATCH 01/14] dt-bindings: phy: qcom,ipq8074-qmp-pcie: Drop PCIE_AUX_CLK from pcie_phy node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240124-pcie-aux-clk-fix-v1-1-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1433; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=/R7t+UW6ZmKuKk7MIzT+d0YPo+66e3175rDe543o5Ic=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4CiEXvEQ+narxvebS5XjcYmsO6QpgRHqHvp rAqTcXLWsyJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+AgAKCRBVnxHm/pHO 9eoUB/9jif/45s9Im3bQE1b5z3netk6pqcfdn67RHHTYUyCIixCOxMKgvmqEN9n48XIP/d9RFRt R7IlQxs2liAg57al7DMCRjYQUeAkMXAu+cF43aY+PxK+xXa/QBy1Tb1KT08qC5AhLmaGDjYLlmL EwnWwzX43aet5J+7NxdvgbtPxlVkGGDAKrroJeWin7T02c47+/915MJ+mjIFnWdHUX2b+NfFjm/ bnSiNEf73NJRZjPFsug7zRq63JB5dG2dONZPsogzL6Plym+hinqwcGQnzOTpSJBU8QFy9SUJRAy SDiAHnJUf63xHOazM9doqVZJe5OXjdAJoRCwSitEo6Dr2A1I X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from the binding. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-phy.yaml | 9 +++--= ---- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-ph= y.yaml b/Documentation/devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-phy.ya= ml index 634cec5d57ea..a953ac197dfd 100644 --- a/Documentation/devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-phy.yaml @@ -25,11 +25,10 @@ properties: - description: serdes =20 clocks: - maxItems: 3 + maxItems: 2 =20 clock-names: items: - - const: aux - const: cfg_ahb - const: pipe =20 @@ -72,11 +71,9 @@ examples: compatible =3D "qcom,ipq6018-qmp-pcie-phy"; reg =3D <0x00084000 0x1000>; =20 - clocks =3D <&gcc GCC_PCIE0_AUX_CLK>, - <&gcc GCC_PCIE0_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE0_AHB_CLK>, <&gcc GCC_PCIE0_PIPE_CLK>; - clock-names =3D "aux", - "cfg_ahb", + clock-names =3D "cfg_ahb", "pipe"; =20 clock-output-names =3D "gcc_pcie0_pipe_clk_src"; --=20 2.25.1 From nobody Wed Dec 24 19:53:59 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 750DB17580 for ; Wed, 24 Jan 2024 07:36:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081815; cv=none; b=ZXmJOUmC8yc5so3ZM5iCNhhlQB6EVOmJyJawgpmvmPvtlQqT8xANNqZg5Rx/T5q4x16a+s/Jmhj3D4Vm5sPkRAccMUN5951Nvr2/uog/RaucXvS1TM+vTfPG/Nt/7//nybJHOYq2ZO9TYDvqlmmU3aGB+2YD5Xjw518ugOJQLrU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081815; c=relaxed/simple; bh=fGj8Hc8YGkorO50XWw23uE3LCV1avN5lQsXZGvyanM8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TzOS0Kx6FvTqX6CI130W9vUpjMPUhECo0ZRnmL5D+nRRC3ZrLF82vMURtRm4gi/YRS+/drX/xPJ1CTimiPcX2bY3dV4yN5Z5ZFQVjpXczvgI9olPn00e8VIs6v2Vb6/I+ptBHAIxJYPnOAlg/hpaezL4Mp5uMk1iEJjJYSAw66U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jaiLRkh+; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jaiLRkh+" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d7232dcb3eso23407645ad.2 for ; Tue, 23 Jan 2024 23:36:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081814; x=1706686614; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NEnCFhhmwsb7wajVYXLbkhkhFCstNg2EJe/RBvp+MYA=; b=jaiLRkh+G9oeuYq5xDC194NAeEZ1X0oFtK+FMyKiaOREI2NMW6FGetaHc8w8iorTVv f5/YGeXFEk61kAdJf66yaDwWay3All1rKZLRzD+x6JHPkn/HR2NXlC9jWjTDSGxzf/UH UXrXDLepj4L+eEVdBJ9BGjcaegHATAhp7j3VIydil3NECe6Th+Sa7+9yZ5Hv8bdSfmBB iIid2ug1eTJpjXTmS2mGhS2gJ3E64O3CgR9+83It4KT5zJxztYTMdWSHJusjonf/Qgds Ewx/AVZCgIRzpDhy4xu0VKgd4f8w4TH0CubUwivXNTQKpSYrS5QVUIV8ACp+1uMZtVp2 9Flw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081814; x=1706686614; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NEnCFhhmwsb7wajVYXLbkhkhFCstNg2EJe/RBvp+MYA=; b=QZ0+w0PFM+lan5WbwkyzRl6U3eCgOig813uqsKdAE0lB+C+HUoZrlpurWik3qUkfbp jHCbTzQ6SkXpNvSAH48wVb55pXvrJHGBAhKRMKYkjcs0U6fj0hZam2qhvgFsDPDyIpRa 5Jr71Nd35+m8CKlBeu+wIWwYw/JNor11aHmvPnRQDPfPROALibU2XntkI9AK5oJa0wyl fquLcerDWOxED3bgNVvSELAwsxIAY0UNkMuCh7Pn6YQBvcdiXs5SQTPt6pGul5iIV/lN 07uV/MSZ3z06dG2PNT4NpNg0sdnE9W9FMVtmuiiug5J0eYde8ozC3uSTAEfBtdLBvgJz 0mYA== X-Gm-Message-State: AOJu0YznxqgkOhvGBJDEL5hZyQvYmC64N6bM4KD/EPnDixrooqCSWFkv GJatKRTznS6zd17PEcJwPR4zw0uagUmj5RAFV+Vrv+OlwaDvB+f6rDK7ImzQtQ== X-Google-Smtp-Source: AGHT+IF5vLJU2eGh5b5arpYHW5lYcd7oWV3PajDcJ2tAy3xBarUKGSR/ATJC0UF0GUZB4gYaeGJ2JA== X-Received: by 2002:a17:903:120a:b0:1d4:2330:85a3 with SMTP id l10-20020a170903120a00b001d4233085a3mr341846plh.20.1706081813873; Tue, 23 Jan 2024 23:36:53 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.36.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:36:53 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:30 +0530 Subject: [PATCH 02/14] arm64: dts: qcom: ipq6018: Drop PCIE_AUX_CLK from pcie_phy node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240124-pcie-aux-clk-fix-v1-2-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=979; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=fGj8Hc8YGkorO50XWw23uE3LCV1avN5lQsXZGvyanM8=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4CGTLW5PHE4v+QOjUwEzMEiiZ5MfA5DaNcj cyvMk7JDkGJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+AgAKCRBVnxHm/pHO 9fWvB/42xwjITFqhAyVbIdl55fGwYHKR5rjdxAep68tNBpd/TDx47zwOB4CQorP44+PsGLFCCuJ Kd+miwAqOtGDcUbCdlmEtGByRdfJ4lYIJSThJHw+8cZMHdJfPOTbQgQx72cRm21eTxP62gerfNU ghiEAGHcO4Cn7M0s4yznO6JUcBxCJJh2ZvD0Xrq1pMZXtErnpGMvMTxcI2qlSzVHLqCFvfUVViK 1lMyaKbezsLE8Erot6tjnO8oqu+s8kQL2Fz/eSWOPxygbqdJhwiBM5sfhFSJjeu91I3ZFhfE7Jv 1SRvB5M7rigAG/cuuo3CWLPvKtwZAMZt/sdlvK8ka2s6b+m6 X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy node. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qc= om/ipq6018.dtsi index 5e1277fea725..1767e5abd76d 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -283,11 +283,9 @@ pcie_phy: phy@84000 { reg =3D <0x0 0x00084000 0x0 0x1000>; status =3D "disabled"; =20 - clocks =3D <&gcc GCC_PCIE0_AUX_CLK>, - <&gcc GCC_PCIE0_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE0_AHB_CLK>, <&gcc GCC_PCIE0_PIPE_CLK>; - clock-names =3D "aux", - "cfg_ahb", + clock-names =3D "cfg_ahb", "pipe"; =20 clock-output-names =3D "gcc_pcie0_pipe_clk_src"; --=20 2.25.1 From nobody Wed Dec 24 19:53:59 2025 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9CA51759F for ; Wed, 24 Jan 2024 07:36:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081821; cv=none; b=bvD555D920nT7VfOlqSBvmk1HN7hid4fLK40/40xTHcFh4lMqpdYeFnEFghem8yoA9rv0GHTH9DIP6vRMxV43iNtS62cmRrozuqwRTZtgkYX3K4GXgIy/6hfOlattG/Wttz3nfc9Pb51xVnU6lRM6ya/i8HcTUdhjI/7p0b9UvA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081821; c=relaxed/simple; bh=tYw91gWuWNXo6BYZKlOtQvxOlV3OGyDBw5hpVkCGZg4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Mpk4Y0Mf9uYV9VW1Tz4ZsKW5TTnkGdRaxCi9+bDCB7tzYMmTbohqVlBNh7M77h56mGI3wTLVDa6QOfrCBYdgg2IBFsDHloQWhDFAwAXBXcTyQZb9SBbZP+BO93BqdpmOLuDJj2kCD8MYT3hUEnwAD5Bg2JBg0/5EgZ7BcDCqpEI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YQgse18S; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YQgse18S" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1d746ce7d13so25123655ad.0 for ; Tue, 23 Jan 2024 23:36:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081819; x=1706686619; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fBFfSaJckS21En/NRtO5B8XnRhjsR2n6FJYjapBTDSs=; b=YQgse18S5N6YJm6QLhjb0Kl8+md7loIjWvjN+3ee4MRTn8HJv4+jyTvTe37+jmpJbc W/gRdnSUTq/c3iYCx6a9JJ4efuXMf79KrTylvnz6Zax9/1c0fPrctKtFhDBktFyxUxAm O815fCvZ8UUP3SYSuAjN2OPxAMrlLDXubfg+TrXIcCKeUYXJ8dGEovl09GkkDCWlYCsN syG70Tv0C7jp4V6OpFMZiZLT0rXh81sMyWmUiOnO98gC4bXZ6+QsYyz99V11OpsNjlsb y36IaF5ddkDBeQNKSsz8IqnwZe0QJLl7lwvrbFp8G74fPLz1hH+pqS5oJ55Df3MCDaXC 9YkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081819; x=1706686619; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fBFfSaJckS21En/NRtO5B8XnRhjsR2n6FJYjapBTDSs=; b=nWXyH4Vyq6D/ll0ZsWRS9al6YIbEcpf6EX5F5UQsny/uRuMn2uTgCtdhoKMnowxnvN mxUEBwotmvkHB2arUoFqjOanrIbCBufI64qT6tAJh8vJNdcdNPsIcGDwDWruXrzN4quR Bg+kLCFwWmS50h38Ik6JroNpXIhz1F91Sgvq4OAsC+nWfLHlCuCbFi7FRWmvC9tLaSeQ 4p2ZhboJqyX8dsjo6WaCnIzUEcODxgv/lUN5br5yrkoj1jn8T4Zc14OFMd7o+Z8ddbKD 5rKyBvBq4/7FFrOIqOMrB2a5IU2ip+zMDT6LG0AdAEwlCNX7LCeVYC0+AuS5nQeXs0Zb kbUw== X-Gm-Message-State: AOJu0Ywu7trSyk8OSvep/fLxMZJ+g8M8FmxalWjgELz0y9ra8DNMwF9Z GhLkZEEgF2opVZoLxqY9U93A8PX6qx5jxTcY7GrKtvfSh3hCVF+J//VH6IbK+w== X-Google-Smtp-Source: AGHT+IE/wIYSrBooEZbLDcaYsE02CGekV66QkvsrVyx5eIErSHKRtYDq10wSgZoYRynCa5FasB0XrA== X-Received: by 2002:a17:902:b086:b0:1d7:450c:be68 with SMTP id p6-20020a170902b08600b001d7450cbe68mr420926plr.66.1706081819311; Tue, 23 Jan 2024 23:36:59 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.36.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:36:58 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:31 +0530 Subject: [PATCH 03/14] arm64: dts: qcom: ipq8074: Drop PCIE_AUX_CLK from pcie_phy nodes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240124-pcie-aux-clk-fix-v1-3-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1432; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=tYw91gWuWNXo6BYZKlOtQvxOlV3OGyDBw5hpVkCGZg4=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4D9c6rL/7BFeef/cHzRgNKqQG03Iu+2lSju AQE1U2qnCKJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+AwAKCRBVnxHm/pHO 9VhrB/wP2eETp8NYOX5qto7ovhKQ2P4/3bYol1vt6g4fztAd3bHWpS9MUKd8KRh3dClCjYyXF9a apf4vWrS7pBAcxfIuzNWKyMkGJXN2o9LaIUgxayNJh5NpKHQx6ayHxd5fPlfOc/LMgLV8Fxodys m4oB3HB5yJZGlIlI3gNFKGVej//Rl1/QlkmKIiTQgQGgQwBLOGPrOssNn5QQ77PKahrqwMmr48C iBeoWdT/2cIhJwLBlknzbJzv+SL6LoPOIATBDo8PXmens/WyDVPzR+djCAU2FMsRcwN9sCgo4lR jx1HO0hJ4jMe+fAcjZ/XabH6wlUWpH1A37pQNWQpLqZgkDX7 X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy nodes. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qc= om/ipq8074.dtsi index cf295bed3299..6ae6833e8969 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi @@ -201,11 +201,9 @@ pcie_qmp0: phy@84000 { compatible =3D "qcom,ipq8074-qmp-gen3-pcie-phy"; reg =3D <0x00084000 0x1000>; =20 - clocks =3D <&gcc GCC_PCIE0_AUX_CLK>, - <&gcc GCC_PCIE0_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE0_AHB_CLK>, <&gcc GCC_PCIE0_PIPE_CLK>; - clock-names =3D "aux", - "cfg_ahb", + clock-names =3D "cfg_ahb", "pipe"; =20 clock-output-names =3D "pcie20_phy0_pipe_clk"; @@ -224,11 +222,9 @@ pcie_qmp1: phy@8e000 { compatible =3D "qcom,ipq8074-qmp-pcie-phy"; reg =3D <0x0008e000 0x1000>; =20 - clocks =3D <&gcc GCC_PCIE1_AUX_CLK>, - <&gcc GCC_PCIE1_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE1_AHB_CLK>, <&gcc GCC_PCIE1_PIPE_CLK>; - clock-names =3D "aux", - "cfg_ahb", + clock-names =3D "cfg_ahb", "pipe"; =20 clock-output-names =3D "pcie20_phy1_pipe_clk"; --=20 2.25.1 From nobody Wed Dec 24 19:53:59 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DF2017738 for ; Wed, 24 Jan 2024 07:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081826; cv=none; b=rTWveEJS4RA+KES0Ln4ldEwBnmh1YaUIEJ2OeQ7D+3tg7RLWwyCcuB6V3rFH3fFfzlJMVXdfqJ8fIdnKVu2x+5VjWvfoDbCwD7A0FXz0A7mbAqmUUP8qKlHB4m0r11BeeHRuQlhg20LdTZ+4p/tA24Ltx86Ys+FdkLOV5OKGX/c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081826; c=relaxed/simple; bh=FUkkiV+2vDk+h8Fu4sCklCuzOARyg+ribP0i686xTfw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OWJPmTEsadhREksOam9fgeiSHOACqOdxWZe14sModbBtxBcXu45c7t4wl6wfVFpwcVwCFy/6N+EvoHiSAF9iKJFwhyr/oD/xnEUYeItKhZVV+WQw1jqxycFWsNkZWNxwX6F4gSH7U7T7jBqX7wCafTHVwB9WmecHksgu4euYIec= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=R7vxYCsY; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R7vxYCsY" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d7354ba334so30721595ad.1 for ; Tue, 23 Jan 2024 23:37:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081824; x=1706686624; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TYkvTvEMLj4JoaODxeTHusWVUfI5+qI8qMmzgmBVEBE=; b=R7vxYCsYdbDys9lO8RMdXOwDRxRfguI1j28N+bI3dvFL2bkROK5AtVIj+GXQQSjNa4 h5zVWTZ9o2TZHgpIhOxuCvoJwk4Eo1L15UDAfPfQD0iqHM1W1jLdSyEmjbxS+HsMF5eb EGeLQ/OdZrt0w+cag4jxczjuwC0sXCmdNop7acpdiKHoszQDnX4l/fcp9RQyLMif81/i qKwt6ZbXIIwmLzwrt+0mKYKheup5gCjka3H6Is5Z5ydntTYcIJEZMdv4VGYkvvyiMXCT ilP5S0n0pQTZxIGew4nTXrQO2PTZy2jMCAkDB5D7TgYls9zSHWrULKnrgQznGCcFbK/h R78A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081824; x=1706686624; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TYkvTvEMLj4JoaODxeTHusWVUfI5+qI8qMmzgmBVEBE=; b=xFwhV2203WosRMAFjDq/6cjmvEhdxODcCrGO2EBkHUNSGkQRsVO3PptpxlPk2ssH3+ uSwGd7WOvjhKHf4YadrnZ0t+zj6o8QhsnanJNDaio5wTN3X6bKvnt+IFqXM0UAXs24uK YuuU5xUI9Sh6/njj2qo8itw9bkzMFWiF8mXINfivxrINPJREPU01mwpQ7PR2jSd1iAL5 crSKpHAqs58KCjiKSHO45/n6PuBKOk5c7NqtkS//VcJSCXsd16SiqAxrhShCe3+Y2Oiy 1ALVcOOGOGPl6jewITScX0qmM9Pi6ptEO8HwXW12jmSerdcP3mVCvqMRfiC3kOKsLwQi DvUg== X-Gm-Message-State: AOJu0YyJh+TkwY8d14cBYnIul/ghcp3NNsx/apdt1AeDcNn+DSv5r5GF HTnpqHLq1VEA3UGcZxyDk02rGx78Pzn3Yl24WVg/9RtFzK0qvWSQp2CTVzw+3g== X-Google-Smtp-Source: AGHT+IGTjeibUHV4ILPDRl0hWCHWuyMofMnIPtbp+2gsEYpQvq4noe4HRVKYN4q12hIlzAyNaf3Y4g== X-Received: by 2002:a17:902:7401:b0:1d7:e84:4ede with SMTP id g1-20020a170902740100b001d70e844edemr494893pll.67.1706081824565; Tue, 23 Jan 2024 23:37:04 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.36.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:04 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:32 +0530 Subject: [PATCH 04/14] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Fix the usage of aux clk Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240124-pcie-aux-clk-fix-v1-4-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=6248; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=FUkkiV+2vDk+h8Fu4sCklCuzOARyg+ribP0i686xTfw=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4DHLbLRu4/rLPOQs1IQsAM94Al1MnHSEL/G wX5JYbKC+uJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+AwAKCRBVnxHm/pHO 9V8RB/4lFYgeiPK6H+XbHF+JN0qyPo58sySDUBLf/BX0tIhPOzwJ6npj041l/nk5ec9gDfo+CaN tJN7h8IN6S8zqtRZrIy2JpUo2nctn7HEPPoeRuk2DLVh6rTPwxGcFa01gSuDGZ+ajytR+/0Z+wd 3ZtZXVcUaHBxJXJEznY8SUrE24e99wXNhCJBIvKGT9+b/6eo0RPdy9m+dDm6a0R4zbL8QQg60Mb e2WBw9v+QGK8KSPyaBupTaM4ycBHxC82P3Ryvw7RmdJTuym6QexRpM5wLaAqPrStq4S4NXq95Il 5yImBNw7KWTyGuutHy0uYxDMv9X3sk3SwQGY3o6cFYpOehfw X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 On some platforms, PHY block requires PCIE_PHY_AUX_CLK to be used when the PCIe link enters L1SS state. On those platforms, a dedicated PCIE_PHY_AUX_CLK is available from GCC. Other than this, the PHY block doesn't require any other "aux" clock, including PCIE_AUX_CLK which only required by the PCIe controller. Historically, the DTs of the platforms requiring "aux" clock passed PCIE_PHY_AUX_CLK as "aux" clock. But over the period of time, platforms that do not require this dedicated "aux" clock mistakenly started passing the PCIE_AUX_CLK as the "aux" clock. More recently, SA8775P platform passed both "aux" (PCIE_AUX_CLK) and "phy_aux" (PCIE_PHY_AUX_CLK) clocks. So to clean up this mess, let's remove the newly introduced "phy_aux" clock and just use "aux" clock to supply PCIE_PHY_AUX_CLK for platforms that require it. For the platforms that do not require a dedicated "aux" clock, the clock is removed from DT. While at it, let's also define "qcom,sc7280-qmp-pcie-phy" compatible for SC7280 SoC which was earlier using the compatible "qcom,sm8250-qmp-gen3x2-pcie-phy" as the clock requirement has changed and also restructure the "clock-names" property for the affected platforms. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Krzysztof Kozlowski --- .../bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 79 ++++++++++++++----= ---- 1 file changed, 52 insertions(+), 27 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-p= hy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.= yaml index 6c03f2d5fca3..2396a457f9c8 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml @@ -18,6 +18,7 @@ properties: enum: - qcom,sa8775p-qmp-gen4x2-pcie-phy - qcom,sa8775p-qmp-gen4x4-pcie-phy + - qcom,sc7280-qmp-pcie-phy - qcom,sc8180x-qmp-pcie-phy - qcom,sc8280xp-qmp-gen3x1-pcie-phy - qcom,sc8280xp-qmp-gen3x2-pcie-phy @@ -44,19 +45,12 @@ properties: maxItems: 2 =20 clocks: - minItems: 5 - maxItems: 7 + minItems: 4 + maxItems: 6 =20 clock-names: - minItems: 5 - items: - - const: aux - - const: cfg_ahb - - const: ref - - enum: [rchng, refgen] - - const: pipe - - const: pipediv2 - - const: phy_aux + minItems: 4 + maxItems: 6 =20 power-domains: maxItems: 1 @@ -130,6 +124,28 @@ allOf: reg: maxItems: 1 =20 + - if: + properties: + compatible: + contains: + enum: + - qcom,sc7280-qmp-pcie-phy + - qcom,sm8350-qmp-gen3x1-pcie-phy + - qcom,sm8450-qmp-gen3x1-pcie-phy + - qcom,sm8450-qmp-gen3x2-pcie-phy + - qcom,sm8550-qmp-gen3x2-pcie-phy + - qcom,sm8650-qmp-gen3x2-pcie-phy + then: + properties: + clocks: + maxItems: 4 + clock-names: + items: + - const: cfg_ahb + - const: ref + - enum: [rchng, refgen] + - const: pipe + - if: properties: compatible: @@ -144,19 +160,19 @@ allOf: - qcom,sm8250-qmp-gen3x1-pcie-phy - qcom,sm8250-qmp-gen3x2-pcie-phy - qcom,sm8250-qmp-modem-pcie-phy - - qcom,sm8350-qmp-gen3x1-pcie-phy - - qcom,sm8450-qmp-gen3x1-pcie-phy - - qcom,sm8450-qmp-gen3x2-pcie-phy - - qcom,sm8550-qmp-gen3x2-pcie-phy - qcom,sm8550-qmp-gen4x2-pcie-phy - - qcom,sm8650-qmp-gen3x2-pcie-phy - qcom,sm8650-qmp-gen4x2-pcie-phy then: properties: clocks: maxItems: 5 clock-names: - maxItems: 5 + items: + - const: aux + - const: cfg_ahb + - const: ref + - enum: [rchng, refgen] + - const: pipe =20 - if: properties: @@ -169,9 +185,14 @@ allOf: then: properties: clocks: - minItems: 6 + maxItems: 5 clock-names: - minItems: 6 + items: + - const: cfg_ahb + - const: ref + - const: rchng + - const: pipe + - const: pipediv2 =20 - if: properties: @@ -183,9 +204,15 @@ allOf: then: properties: clocks: - minItems: 7 + minItems: 6 clock-names: - minItems: 7 + items: + - const: aux + - const: cfg_ahb + - const: ref + - const: rchng + - const: pipe + - const: pipediv2 =20 - if: properties: @@ -215,13 +242,12 @@ examples: compatible =3D "qcom,sc8280xp-qmp-gen3x2-pcie-phy"; reg =3D <0x01c18000 0x2000>; =20 - clocks =3D <&gcc GCC_PCIE_2B_AUX_CLK>, - <&gcc GCC_PCIE_2B_CFG_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE_2B_CFG_AHB_CLK>, <&gcc GCC_PCIE_2A2B_CLKREF_CLK>, <&gcc GCC_PCIE2B_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_2B_PIPE_CLK>, <&gcc GCC_PCIE_2B_PIPEDIV2_CLK>; - clock-names =3D "aux", "cfg_ahb", "ref", "rchng", + clock-names =3D "cfg_ahb", "ref", "rchng", "pipe", "pipediv2"; =20 power-domains =3D <&gcc PCIE_2B_GDSC>; @@ -242,13 +268,12 @@ examples: compatible =3D "qcom,sc8280xp-qmp-gen3x4-pcie-phy"; reg =3D <0x01c24000 0x2000>, <0x01c26000 0x2000>; =20 - clocks =3D <&gcc GCC_PCIE_2A_AUX_CLK>, - <&gcc GCC_PCIE_2A_CFG_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE_2A_CFG_AHB_CLK>, <&gcc GCC_PCIE_2A2B_CLKREF_CLK>, <&gcc GCC_PCIE2A_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_2A_PIPE_CLK>, <&gcc GCC_PCIE_2A_PIPEDIV2_CLK>; - clock-names =3D "aux", "cfg_ahb", "ref", "rchng", + clock-names =3D "cfg_ahb", "ref", "rchng", "pipe", "pipediv2"; =20 power-domains =3D <&gcc PCIE_2A_GDSC>; --=20 2.25.1 From nobody Wed Dec 24 19:53:59 2025 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 536501775E for ; Wed, 24 Jan 2024 07:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081831; cv=none; b=eAYR8d3oqDkHTf8ZnP2jnpemgCl05mkutwkH3Ohm1EsSqyqVx92/WoE4DJFie2ofZIbmwuy6yIovX3mQk840ZThNEeQ11BfbpwB7s8Yy4WltIlc3HXc8S7ZYygXp70V22w8xnN5GNNqzIuz624seOXojo7vWlyNEhKcJulR0O6o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081831; c=relaxed/simple; bh=w51HxUcd7PIFxEJ6OgE0FVVFmZ15T0vvM8776BQDfiI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HCAHbBvkIR9D7vHDm0mmRNg5r6MB3yTDnv/BsaAlkVIIM1t5yyncxKJMIv2pnSoNVcsCe9q/A/pbR/TiE+gEt4TLKc4UyOQs36d9/Xnpg05PMwQtO++ulo7vTfnL3hNJxz30PBWAQWSLHH4F6MxfMmUhaa+2q5K1NBiC4gt3EGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=P0vSR7s9; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="P0vSR7s9" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1d750660a0aso15087125ad.0 for ; Tue, 23 Jan 2024 23:37:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081830; x=1706686630; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OZuZcdUnAaZplEI/q0+jQccDNm87eHwhpTq9IdQtppg=; b=P0vSR7s9hNe/6eS8BWQLHtN+Ewjd5AjE0ComrDZYbeeROhPnOtuO01ki0oDu7q+X1T crBqjXJfsBsHqTx4Uww0PWdTxtIBGiH8nHqvL8uisvkPqdztYtTlLkRMqdSYuC5IO/b4 thpSSvSsVgfnsmZm2ncu6U8x6MXIDYTrgI/fU/iMmsVvnyogmTepWnkmEi/V6PHa3mQF 0Oyur5YxEz/PUFpYkyqGNNNxUni/F/mNv0y8uqByQyRHjDttpznSQY43X17Dyk/ZxX3D GFa7dH8V4LG4b8y0iCAYzWLVlcJ9R5bWEeRAqJTzySCSW4CfbIOrGKTf7izRAEzpPclu Y+jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081830; x=1706686630; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OZuZcdUnAaZplEI/q0+jQccDNm87eHwhpTq9IdQtppg=; b=KFDI7crTEOyhoI9a8ztGHyTpZXTS/uFYf/lXXssSryBcIRnauZ+MqzYdjxE8+apKdD QVhJ/NAN/Dk5cvOLwV8Uv/V7NlGXSVpo8fy+FgjGSLZeZMVHtRC9j/4/kKehe/yic3XJ OdK0UI+WttHXczLkW1TSiqydy5IuezM+HBjwV94hXmCp66JzWSlcqAqplFu5RN/OKshx p67b3wpVPFRqoBx0TXnFMtg2kdsyOTItnpko48KQ9fg1rZzvfalyYynlKcjS9Uwu+IVn u9ChKBhUqK/PD46+fER3tIRcsuUcleQ3MYJkgrZZLla6IqtBrkfM2LLMRZQJUPlz4BX8 CPpA== X-Gm-Message-State: AOJu0YzR0UiC6HDt7xUFTN/ORbz5uiPUFyWyHNmG0RFMA12b4xyq34Cb 08M4BjRIAtVSm4KQBE6LJp2OQK99OlKQaEJmPDRnQsvX1Z0fq8YWXPCqOLABCQ== X-Google-Smtp-Source: AGHT+IG/mhM1tXpIYDJ+QgSt5kfSy06HMtXU3+wdXvqf7yd/1q4iuQ8Li1G5PSzHd1qUO9SSeGiszQ== X-Received: by 2002:a17:902:a9ca:b0:1d7:599d:ed25 with SMTP id b10-20020a170902a9ca00b001d7599ded25mr293175plr.39.1706081829738; Tue, 23 Jan 2024 23:37:09 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:09 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:33 +0530 Subject: [PATCH 05/14] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document missing compatible for SM8350 3x2 PHY Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240124-pcie-aux-clk-fix-v1-5-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1285; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=w51HxUcd7PIFxEJ6OgE0FVVFmZ15T0vvM8776BQDfiI=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4Do/rhrRxBBcGh4nzbe8uTfLLa/A6k1e8Nm cQmYLYOUzuJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+AwAKCRBVnxHm/pHO 9WSnB/wMBNvlf+Eb1MLAZ8tHAt7hDQbZWgUDPDi2vLIc8inCjo3y79EjNMOBDVB8rvgiO6TDEkF TvJIRY+rMb+1aAPNL/PGpk9TQHAOUHj9jIbQEHkZf3Ff+x0HThfGIQjSEiqTqWSwFZE8p1o/Z7u DVsMJL4cpCICemBXdHgOZW354scZhFwG4lJevvjElux9zZ1ZP6yeme47movn5L0e8oI8FMhHg6L gHZCqGC+Z3AeNALkvgGj89QPtz1x69XxWUmRzRn6mvdyXsyzC6fxRhikZ5fttFyaLW3sRKrHqXb 8fHNzR6BVRYNQcBT9Qs3tlIUuRWNVfn4Dce4+rcsM568XqXA X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 Document the compatible for SM8350 PCIe Gen3 x2 lane PHY. Signed-off-by: Manivannan Sadhasivam Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 2 = ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-p= hy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.= yaml index 2396a457f9c8..77338184cdb4 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml @@ -33,6 +33,7 @@ properties: - qcom,sm8250-qmp-gen3x2-pcie-phy - qcom,sm8250-qmp-modem-pcie-phy - qcom,sm8350-qmp-gen3x1-pcie-phy + - qcom,sm8350-qmp-gen3x2-pcie-phy - qcom,sm8450-qmp-gen3x1-pcie-phy - qcom,sm8450-qmp-gen4x2-pcie-phy - qcom,sm8550-qmp-gen3x2-pcie-phy @@ -131,6 +132,7 @@ allOf: enum: - qcom,sc7280-qmp-pcie-phy - qcom,sm8350-qmp-gen3x1-pcie-phy + - qcom,sm8350-qmp-gen3x2-pcie-phy - qcom,sm8450-qmp-gen3x1-pcie-phy - qcom,sm8450-qmp-gen3x2-pcie-phy - qcom,sm8550-qmp-gen3x2-pcie-phy --=20 2.25.1 From nobody Wed Dec 24 19:53:59 2025 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 990FB1799B for ; Wed, 24 Jan 2024 07:37:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081836; cv=none; b=H+ZprUV1/wAqQzP2FySZTlP/x26bhl71su0Ye2APcZCY1tMv38exlXl87xgDYVHnpZDNau8lvTlTAqD5To0Zr+hDXUwbp++eKRs6jJOM9AyA7TrWAqac4duFgtXvJAudzLWsjsEs7airefXHCnTSdPceWODqQ9uf11So/gUodBo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081836; c=relaxed/simple; bh=zeX+jh65HInrDo/RwQDt8aTaE8xiSCz2Utb21fD2lmY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZGNpfyXgIVAcZGra08al4cJvjFVpjOJI+ph5qOzx2U3H+LbgMUJ+0ydWdMeBldyeX7LoscX7WN9WhCnq15+f1zS0DwNS3aRXPD/fDSKqfp2qWQL6KE8XkMk1BocPhPw2Vsdyn/bhR/0v7g3OwsDI2zEpsLWHdrmW9WdLMu7HOXs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bOiVoWCP; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bOiVoWCP" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1d7431e702dso21746165ad.1 for ; Tue, 23 Jan 2024 23:37:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081835; x=1706686635; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CNpTFIF16BG7YGRQCCrKfm7GwY9WoZx+GmuixbAdH6M=; b=bOiVoWCP5ubGhCirCyhK2VBjJs1q9w/iFJmT16KGM4cc3NRRs5ADyBj8MgErfV8Qo+ fwu6A0je3kLLYvhXrMnwT0xxSoIF45G3iFZb8WrBB9InAZL2yfTPUHf0MUwc9Q95DO40 Ieat7EVDu655j+DbRykBg796e6u2ADr+IhGD2BcnMZVMVGSn/GwNN96+xsFBW/nvw2MX PAPHUtEkd7XR93qwsKfv6fmD77GA6MfGKFoBxfNtIxt8UVVVV6FOzLJRbNHZUuNvs2/t cC2zQlUNnllMGCLJgnLFdQbPqTDNyS5cInjiz5r8SuBEypHzbmJp8YTbqkhycqb5iR/i 84ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081835; x=1706686635; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CNpTFIF16BG7YGRQCCrKfm7GwY9WoZx+GmuixbAdH6M=; b=RYl1VDktowgj9RDPk4O9j3dSOqSRNBzx+cwUDFvlboMoE8ERCajeb5h3OX6VtZWuir qQA54CaqXA8gRnGGhRAymfJrGnFKcWKHukGUk64JE0ekE00s/Jc1aKHlrClUOp3dotXY IIhP6nksA4JtF8Sv/P3WS5u6UC6CiJFV3YrLFTWF1n8LrtrnAs2ZKB9xzzGDXgiWeRe3 iGZmxJPfQHxq3K1+70LLoO8a8cp64OQ4Y4hfjrTNogqGVmsjCIk2sP+KzV/RCnw6iwPx YzSDnpxvbLSQP89Ak7yWa0WtwFQl5q9CiB0TgGnqmE8kgxw+nxyyusB8mJL/KuPRXsJG /ybA== X-Gm-Message-State: AOJu0YyrF5CG2Dnrkl3Q9n3L1TT/1oi8/rUN0dhtiJJqaTnBsoLQAmL4 2C/RhpNlMyt/zISHG0YYCuszCHpK9dLcHmWqZpE1QaR4fQj0oy4YNUcvY9yQqg== X-Google-Smtp-Source: AGHT+IE3jPeSwyuGuMyRlRHopR8kJWwDY/R6l4wnlHb2ZcILwydWkelUDnM75QY0zsO1jxoWEPgN7g== X-Received: by 2002:a17:902:e802:b0:1d7:6f5a:d390 with SMTP id u2-20020a170902e80200b001d76f5ad390mr360391plg.55.1706081835084; Tue, 23 Jan 2024 23:37:15 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:14 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:34 +0530 Subject: [PATCH 06/14] phy: qcom: qmp-pcie: Add a new compatible for SC7280 SoC Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240124-pcie-aux-clk-fix-v1-6-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=941; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=zeX+jh65HInrDo/RwQDt8aTaE8xiSCz2Utb21fD2lmY=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4DPIrhoZpasm0P2lW3phBrp9L8uQenezf2i GE6tEIxzAGJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+AwAKCRBVnxHm/pHO 9ei7B/9RToHX5l2RmHvp4lJTQYUyyAWAKvGhetr7g8UkSowxxLzt9SI0p28kQVEWSeR5q2TlaOE fAwneBwub3bWVMESD+kmppRH5QblNn09PQHyw0yHQat1Zd73WI+qADs5cH6epiSkGxXnbOleJKN lD7oo9jgQ2AXnpVt7PU+dKYjgWakTEGwoXwX+Uv3FgbQnU8UonNs/7al7khJ2BPIXIuqUUw8iz5 vBX8JYDX6nDOW7ER8lYt7R9Ku47EUof15a3zXe1K5et4wHusFYsAt5jKx6XgSzZg7Bx4fjR3YSn bUmZ7IF5jCwOuX+6J21ks3UoA4mLdVR8pqbmT5zUMCSxYKfb X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 Since this platform requires different clocks compared to SM8250, use a different compatible. But the drvdata of SM8250 can be reused safely. Signed-off-by: Manivannan Sadhasivam --- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcom= m/phy-qcom-qmp-pcie.c index 2af7115ef968..9a220cbd9615 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c @@ -3822,6 +3822,9 @@ static const struct of_device_id qmp_pcie_of_match_ta= ble[] =3D { }, { .compatible =3D "qcom,sa8775p-qmp-gen4x4-pcie-phy", .data =3D &sa8775p_qmp_gen4x4_pciephy_cfg, + }, { + .compatible =3D "qcom,sc7280-qmp-pcie-phy", + .data =3D &sm8250_qmp_gen3x2_pciephy_cfg, }, { .compatible =3D "qcom,sc8180x-qmp-pcie-phy", .data =3D &sc8180x_pciephy_cfg, --=20 2.25.1 From nobody Wed Dec 24 19:53:59 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E031817BA4 for ; Wed, 24 Jan 2024 07:37:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081842; cv=none; b=UoHx/U05m07tN0xyrX5OHVR3fBoCF9ZtI2PJXVs1A/YTfFRRNjILcPCJkIKfR+1qZBNtZY95grJT6mfFBisGuouh7zArnh+jJ3RPLbCVjE5qHJCAcWqlEO6/UtrKFONPiGEaoH2/1jxvUpUlCDHIugONY6uyEHIxzMtqEWhC1Ao= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081842; c=relaxed/simple; bh=SMDJRGbt8Jv9ABIlOfDcm2JYxpzZQjqrX46K5L5t/xk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jiBlBEp9N/4xqws27mqDPXX4cbWGKGska9MdQZSQDPnFXdnMG33a9kCTRlvja5s+cb5FW+U2yeHPafz2vpFMKlc5RAp6wmDR4BGwkkkqY35SjjmDLYqpVUbO+cSs/6sCgVrbRvjyUcfyxMpcUtVpLc4UkmhqO9Mlx+zIcLsLCjE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ef25jQVK; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ef25jQVK" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d70a98c189so30092665ad.1 for ; Tue, 23 Jan 2024 23:37:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081840; x=1706686640; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oJnupBgFvOzDewfsN2fbqfoXAijS1cIjpRbgOobXJnE=; b=Ef25jQVKTs1NV/SOt3b1Ov7l22+0+Ki1oZFBXxKof/9+dEMvwJQJXm6XU5eOJf0vLE RTB61OVOwkfN4eG/ktcOAnLrNy73mnDK7trot6OCUdXdt4TD9nz6pQlldiyiDpll1JGb BBT0LW9i64GfwjazODgWYloNVr6ASjXasgdhwFPImvLPSm1kYnFy7OjlllPuvOP8VVuW Jv/ZLlwpw5YmDbv9ZJ4xbToen4mjpz7I5IGbhrmHmZxHNSyXAlxTJ5ah3tGmxPrXGQ1L QQJ75dIIuTQzW+6NZSOSFBa+HZiem2cLjKaN4sLMQ5PWyJ06u3y6NzGek3inqr4E29Ta JVsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081840; x=1706686640; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oJnupBgFvOzDewfsN2fbqfoXAijS1cIjpRbgOobXJnE=; b=nvmD9HpEvQMF5YbnAkW0YDlxjhhH1WFvwRtVHQNFn6CgL0pWyoMdBe2Q+AQ00zAY6u P/zablFiKHqvNeGV8CGtvc5AJ+57QtOECb9yZAFZFY7SKzyGwq6+HE1fHBWU4oHymdb7 YyvA6ziu3NNVfLXLK1nO91GbwObni2KTNXOwyyKYZVMWFFl5ZhI9FloBuSgQ1QxRUDhn WWUKa3miPY9k2FaANNumeu69Pg2CIPoZ+5TKUjV8l3nmkheMSMEVm+cCnprRIG2NUSnr ZMrvXvtb0xnDpZhamkDQDoToUwViqkGqijiy/0UN0880UwA30ebhRYwSz/Lmd3HvySY6 56MA== X-Gm-Message-State: AOJu0Yz0IfGuF/PCPNL1ER3XhY/zaJ2le/AsJoKCxmQCMwmjv2IknTso 7IUg+qklXq1Z+GbwSuayyjdle87vq6HtmOsTfI5zyd5HlPtZwMqGb73zamZ/zA== X-Google-Smtp-Source: AGHT+IFgsPWxZquxFDzz8I+/ShqqZin/JEW0/exyiv5vB1JusQRtCefw4n6e95w8cWZvyOJd08aWdQ== X-Received: by 2002:a17:903:8d0:b0:1d5:f255:d386 with SMTP id lk16-20020a17090308d000b001d5f255d386mr363745plb.11.1706081840194; Tue, 23 Jan 2024 23:37:20 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:19 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:35 +0530 Subject: [PATCH 07/14] phy: qcom: qmp-pcie: Add a comment to clarify the use of "aux and "phy_aux" clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240124-pcie-aux-clk-fix-v1-7-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1589; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=SMDJRGbt8Jv9ABIlOfDcm2JYxpzZQjqrX46K5L5t/xk=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4Ey0uoNqHHYLtSpRKMWtRALxolVDEIjsBe1 zYzwB5mGOmJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BAAKCRBVnxHm/pHO 9WzXCACg8RokdsMoSt1cI+uOd7qIPPW8HvoqXvRdXwF/FVdYRM+4YTHK6EJJElspwuRhLnphsdy I/+Z8lnLaKfuPLCXoircyEnF9PPdsGKbcCCII0YGpCWaSmLIkvRddCBfZvXKsN9gaegvATDg9Pe xA7iGWN9VVDOmdVyOJdadAtul4vlv3KrUW8QdLJL0vCouWa/OJx9m6CwnZ5A+iUMXO7gmWvgCrj WQsUUQfmlRWqZAmEkT1p8XoYs7Fwo5a7T8LDXcKSdbbkQTHNI0FbpTPq9IDoWqkqv/hGznNtaVb BKEJ7RfVUA3wOjPqCq86Shm4jUiYP6nbnLRDjXzXLdFxdPKZ X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 PCIe PHY hw on some SoCs require PCIE_PHY_AUX_CLK when the link enters L1SS state. Historically, DTs of those SoCs passed this clock as "aux" clock. But, SA8775P passed PCIE_PHY_AUX_CLK as "phy_aux" and PCIE_AUX_CLK as "aux" mistakenly as the latter is not needed at all. Even though the SA8775P DT got fixed, both of these clocks are kept here for backwards compatibility. So add a comment to make it clear. Signed-off-by: Manivannan Sadhasivam --- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcom= m/phy-qcom-qmp-pcie.c index 9a220cbd9615..044e3c5ba341 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c @@ -2328,7 +2328,15 @@ static inline void qphy_clrbits(void __iomem *base, = u32 offset, u32 val) readl(base + offset); } =20 -/* list of clocks required by phy */ +/* list of clocks required by phy + * + * PCIe PHY hw on some SoCs require PCIE_PHY_AUX_CLK when the link enters = L1SS + * state. Historically, DTs of those SoCs passed this clock as "aux" clock= . But, + * SA8775P passed PCIE_PHY_AUX_CLK as "phy_aux" and PCIE_AUX_CLK as "aux" + * mistakenly as the latter is not needed at all. Even though the SA8775P = DT got + * fixed, both of these clocks are kept here for backwards compatibility. + */ + static const char * const qmp_pciephy_clk_l[] =3D { "aux", "cfg_ahb", "ref", "refgen", "rchng", "phy_aux", }; --=20 2.25.1 From nobody Wed Dec 24 19:53:59 2025 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7713817BC6 for ; Wed, 24 Jan 2024 07:37:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081847; cv=none; b=hb7WRU/eqw2qf1LgbqrsgYKyOwXrDut1tLFkZYkNQnbsN/bX4rZv4FvUW+DqvwPpY83sBz+1RaA5DGTCfflo7dz8snfrQnJ7XsV7CwXo2hOmY1cxHelv/krfe42LzJtbyQWRVbaGUyieJ/vJb6fOV3lzLFjR+gtixxWN2tjaYqI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081847; c=relaxed/simple; bh=xQGmJ609x5rY5WnQZu2UiuYBmCFSMa/qh9a8EVqrblk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fzdZoCml8sg6KNvw9zLag196NSf69XLP7bHQXOjuVM0AcMR/FL5I05W6vDx3dKve8Ln4YIXvM44eQTIVzJeQOeIlFz9RyVlow4y7mtikOQLpg0UtujRt32FqHI19T+TsMTWDHC9Sd0Rv/eSNcvrPRhwV/0uC9IA1SD3UKVBDx5U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xL8LYXcP; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xL8LYXcP" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1d70b0e521eso37482125ad.1 for ; Tue, 23 Jan 2024 23:37:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081845; x=1706686645; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CXDDfi064rCtRThZJZGkVDjzRTpEFvKlRw59+OoT04Y=; b=xL8LYXcPThBZjEpIdgbUzrJaGjMucTd0ujeTI93aWpzfhKLoTh/B2HW7q9OKdGfGeD bqvBxTPe8ZZYNA2eQTBMxqD0BhB5VS9Fd2UiO5ziUPz4u+MFdEd8r+exHenLSrKvlQs7 IM0LBclemzguteRIyb7wdbu8i07w3410ZifYwp78tkfusX8L60t99cax50g2zHDH2MeW 2OTcZkjg+1LWwPsJ59wrn2EmqMldLYDl0w9rkNpmnTRHoYmBRNhmlM4zN9Ph9FKHKhfT Qrj1grLqlGk89S/haO3JNb0jcPVXzodhwY3xxB2iDTtsCGw++X9ySVOcJjUnKyEKVQu4 jc7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081845; x=1706686645; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CXDDfi064rCtRThZJZGkVDjzRTpEFvKlRw59+OoT04Y=; b=WAAk6uaBjopZYlsa/v+0h6dXr5VIW4cf3l934uekhCgycvlNfrGmf20mLe+kLHvjWc T5yuvGhxB/z5yhnAOhCS2IjCT9KNyC+iSj4ixpAlEFu5OTh2W+6Gr5OfrnXakyZvn1Bt ZuB4xfnyRZSHBtJBWq/MwEjZ6iP1sTc9F/ZraXzvuznPnTQaq3WBvcDkzBe/Nbeeh1rn jAY2mwPHwh6iQoVbWPFIM85a1DXUeA9MDvqn1uU3l2zJv9BzmzkAQ6fcFaPbr/t6tnbc K0psfbFHhpLFYxoiUX662f0+6Gr9l+Eaiqq7saKEohSWU9JxNCrkPHJiaApwByLyX01A h4Gw== X-Gm-Message-State: AOJu0YxxH5nBRjnyfFDlz0si+GHRbOsO3N9Chz9Z0jD0trgn3ClCd8S7 Ttvo8zzKNbyMSE9+G5pw/ceZeKZW8LVJDk/2T5XTv2XWcVW4/WWSdMJyg8LjOA== X-Google-Smtp-Source: AGHT+IF99KK54fuqFFMfmzqMybtJrANjExFeTmDyL1Qt8Q4Zi7bMzYpz82W5D68CZj4gDoCyRGD5yA== X-Received: by 2002:a17:903:1206:b0:1d7:5b9a:c121 with SMTP id l6-20020a170903120600b001d75b9ac121mr632265plh.20.1706081845404; Tue, 23 Jan 2024 23:37:25 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:25 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:36 +0530 Subject: [PATCH 08/14] arm64: dts: qcom: sc7280: Drop PCIE_AUX_CLK from pcie_phy node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240124-pcie-aux-clk-fix-v1-8-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1245; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=xQGmJ609x5rY5WnQZu2UiuYBmCFSMa/qh9a8EVqrblk=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4E35ElitvKxvgn52B7cnJz0JUaxM9PnNc0A YZLT3RUs1+JATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BAAKCRBVnxHm/pHO 9WzEB/9AWVJHzHB6yiYRzLzH5QMJyCI3Uey/WEyC9zrlInlCFP8ttR0TRYGIqNPMtlsudajr4Gh RwpC8CAwS3A4Jf0oosP/6RXE1zNUfu2UjlcdqwOOxHs8AHMNKKM3toEfV0hFTdMklLboKyoEpgW sj2l+ax0lyo1k2+nMyO9dzjY/ydeqp96BnCqc+N/TRwcJ3md0oC/ZejQjOYqewn84720yaqyduf kstWJuleC/arnJeAq0oQL/W/vG4KnHN0bm+4Do+Ab2t+dKkViydZvkDALc8juNUZ0jUrVUJ5ndh KHNGEK7XglGMRE/SqBmQdOXjH9s7XvhAlHttDhKii90je4kW X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy node. This also warrants a new compatible as the clocks differ between SC7280 and SM8250. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qco= m/sc7280.dtsi index 83b5b76ba179..00fa14777417 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -2238,15 +2238,13 @@ pcie1: pcie@1c08000 { }; =20 pcie1_phy: phy@1c0e000 { - compatible =3D "qcom,sm8250-qmp-gen3x2-pcie-phy"; + compatible =3D "qcom,sc7280-qmp-pcie-phy"; reg =3D <0 0x01c0e000 0 0x1000>; - clocks =3D <&gcc GCC_PCIE_1_AUX_CLK>, - <&gcc GCC_PCIE_1_CFG_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE_1_CFG_AHB_CLK>, <&gcc GCC_PCIE_CLKREF_EN>, <&gcc GCC_PCIE1_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_1_PIPE_CLK>; - clock-names =3D "aux", - "cfg_ahb", + clock-names =3D "cfg_ahb", "ref", "refgen", "pipe"; --=20 2.25.1 From nobody Wed Dec 24 19:53:59 2025 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EC3C17C65 for ; Wed, 24 Jan 2024 07:37:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081852; cv=none; b=M+be/tK6pky/zm4jteNOJ2XNTtfmcUnXVvqnAbXCSLKimS/sjUO1tCEcQiTlj1a/VzQ+rg7eAYYtnL1mX6Syw7ZzoY0HEG4e4JWgM9BWMQJUqi2DkC3swucu7J1OfBVIMj7HsYwt8Pea+VNZQgKsHCMtV8NXBVhLT5IxctgJ7/8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081852; c=relaxed/simple; bh=5NPwNoYz985HYek6uHJDI/5wY+uuiyXnKa4opvBCJj8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=P9eevNGNYfEGX06l82AJf2KNpHket4IPzRfE+DbYE4ZuMi/E+s0zAd9Z1xEQe3nt10NjULwyFx8GzIUj6QsPkqpLR8N0MXZDX1ATvWKzUfgPWuC/qLVvZB1wL9J1MXgSXZHpq9rkt4XMUD6+gyCymZ4H799m4WiCWI6onFLkXVs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OJdebiI4; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OJdebiI4" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1d746ce7d13so25126675ad.0 for ; Tue, 23 Jan 2024 23:37:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081850; x=1706686650; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7tKk/gUA2vZt4YWRFyEnjgkAtVvTsiFIxZN8q5DEuUk=; b=OJdebiI4f0B1iL3Di2wlf/6pKIOa+3ut/BFGdP/kD6jpjK4IgvDq79GRlK4GbPgXtQ YpQkjY0XYF/TMyGc2huRoqH5S0sjBm+xiKY/DZh6OgGGFkce0YjD/75rDyXq0CODJj5x /n1/mFpbaWAMfPb0nRxJm7mPCQdB1w0WST+O7LINf+/BqCL6l3ohviTcZXQXSsJm6c+a DnHbx7LGg+z5sAK3HwzJ/4Jqgzg20xBU5J8V56zgUZVJFpaYOGnFq1Fg9xfiXJAm55Yf v6R0WNS6+n6Ojv1aZpm2c7T/d5dwkeZlFp82LCcqpzlQKdumq7s8C3IMJBf7GqmM2KTe 8acQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081850; x=1706686650; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7tKk/gUA2vZt4YWRFyEnjgkAtVvTsiFIxZN8q5DEuUk=; b=VCaWnhb8/dNccwB1Pftj2CvpVae1tjSvtqmVIrCNFwGVXdplbv0D7IOH1414IxiJaX 42JMI1vtHxeIGV0OYke0AMg4GxSYeAyRjCAJxBy8s74joypOv4gIu6r8vy+kkwU55gTv RSc47HNIYIWYYbms9wqwL2lhpfskyO9Nec1zB71vepwTbCkbWDBi9IpIpJgPBvIOG2X/ XeXAf1AilGWBgbXVXjVuL1OP6NWXHPz+lPX4x06XXRQt3js2CzyYROG5EFK2cX0mHx1X juDxfxg6xS+zl+ponXW587qMvBYQgFsrDSDLdRMBp9pyttgjPdQaBE3HxwB6ITi34Ua1 bxoA== X-Gm-Message-State: AOJu0Yx8MtEfGv/heR+AxTcIiWP1HNU6cuYofMJs1UMntTfbbCYzqqv2 Nfcr2nq6r74aAminXbR1WGLXHT6s2q/P44+LtZYWMhw8P3czpswiTYr/CuiIrA== X-Google-Smtp-Source: AGHT+IE5gSR9S1hNumT5Gs9vRn/HrJ2yq2svOakpJLMn1E1SeeC1nBHi/YQbyiTo51gPSYVY5Nv8ug== X-Received: by 2002:a17:903:492:b0:1d3:d27f:77c9 with SMTP id jj18-20020a170903049200b001d3d27f77c9mr390645plb.14.1706081850722; Tue, 23 Jan 2024 23:37:30 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:30 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:37 +0530 Subject: [PATCH 09/14] arm64: dts: qcom: sc8280xp: Drop PCIE_AUX_CLK from pcie_phy nodes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240124-pcie-aux-clk-fix-v1-9-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=3664; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=5NPwNoYz985HYek6uHJDI/5wY+uuiyXnKa4opvBCJj8=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4EVGO3TtV6DQzvJ/PExud2tothVXBlk9nJc KgeDCk+AGuJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BAAKCRBVnxHm/pHO 9ae/B/45By/VPGVbVxv8n0z7xSGfU/JGiMFrTjUS69Gmsob8PF7fxftlTWwZCLkrUgIuJRBzdkb ZkHzrSGbdR0j2Foxfp/j51A4pVzGBC45wverE1WOVAm7SXjE1RiAe+KFpN70Jnciy0gDs0voIsC I8h+my8LE3a9yTp9A2F0se8GWbdtNlTIXQLB3l5n1QNEohi+6AaJMXKXo2RAZ0T91aPbtOmcn9z tkxrffCFt8jriWYRyJB7Nw1aHfs7LoWB70dND9G+MqYRK9dMhufB9K7BXZgQniBJZ9xkoe29Tzt jJRaUqkSIdQFvvfxsXfrJN5i+O0TgUj8StTbu76AE2zXoRtv X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy nodes. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 25 ++++++++++--------------- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/q= com/sc8280xp.dtsi index febf28356ff8..cc33ef47d5a7 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -1785,13 +1785,12 @@ pcie4_phy: phy@1c06000 { compatible =3D "qcom,sc8280xp-qmp-gen3x1-pcie-phy"; reg =3D <0x0 0x01c06000 0x0 0x2000>; =20 - clocks =3D <&gcc GCC_PCIE_4_AUX_CLK>, - <&gcc GCC_PCIE_4_CFG_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE_4_CFG_AHB_CLK>, <&gcc GCC_PCIE_4_CLKREF_CLK>, <&gcc GCC_PCIE4_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_4_PIPE_CLK>, <&gcc GCC_PCIE_4_PIPEDIV2_CLK>; - clock-names =3D "aux", "cfg_ahb", "ref", "rchng", + clock-names =3D "cfg_ahb", "ref", "rchng", "pipe", "pipediv2"; =20 assigned-clocks =3D <&gcc GCC_PCIE4_PHY_RCHNG_CLK>; @@ -1883,13 +1882,12 @@ pcie3b_phy: phy@1c0e000 { compatible =3D "qcom,sc8280xp-qmp-gen3x2-pcie-phy"; reg =3D <0x0 0x01c0e000 0x0 0x2000>; =20 - clocks =3D <&gcc GCC_PCIE_3B_AUX_CLK>, - <&gcc GCC_PCIE_3B_CFG_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE_3B_CFG_AHB_CLK>, <&gcc GCC_PCIE_3A3B_CLKREF_CLK>, <&gcc GCC_PCIE3B_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_3B_PIPE_CLK>, <&gcc GCC_PCIE_3B_PIPEDIV2_CLK>; - clock-names =3D "aux", "cfg_ahb", "ref", "rchng", + clock-names =3D "cfg_ahb", "ref", "rchng", "pipe", "pipediv2"; =20 assigned-clocks =3D <&gcc GCC_PCIE3B_PHY_RCHNG_CLK>; @@ -1982,13 +1980,12 @@ pcie3a_phy: phy@1c14000 { reg =3D <0x0 0x01c14000 0x0 0x2000>, <0x0 0x01c16000 0x0 0x2000>; =20 - clocks =3D <&gcc GCC_PCIE_3A_AUX_CLK>, - <&gcc GCC_PCIE_3A_CFG_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE_3A_CFG_AHB_CLK>, <&gcc GCC_PCIE_3A3B_CLKREF_CLK>, <&gcc GCC_PCIE3A_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_3A_PIPE_CLK>, <&gcc GCC_PCIE_3A_PIPEDIV2_CLK>; - clock-names =3D "aux", "cfg_ahb", "ref", "rchng", + clock-names =3D "cfg_ahb", "ref", "rchng", "pipe", "pipediv2"; =20 assigned-clocks =3D <&gcc GCC_PCIE3A_PHY_RCHNG_CLK>; @@ -2082,13 +2079,12 @@ pcie2b_phy: phy@1c1e000 { compatible =3D "qcom,sc8280xp-qmp-gen3x2-pcie-phy"; reg =3D <0x0 0x01c1e000 0x0 0x2000>; =20 - clocks =3D <&gcc GCC_PCIE_2B_AUX_CLK>, - <&gcc GCC_PCIE_2B_CFG_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE_2B_CFG_AHB_CLK>, <&gcc GCC_PCIE_2A2B_CLKREF_CLK>, <&gcc GCC_PCIE2B_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_2B_PIPE_CLK>, <&gcc GCC_PCIE_2B_PIPEDIV2_CLK>; - clock-names =3D "aux", "cfg_ahb", "ref", "rchng", + clock-names =3D "cfg_ahb", "ref", "rchng", "pipe", "pipediv2"; =20 assigned-clocks =3D <&gcc GCC_PCIE2B_PHY_RCHNG_CLK>; @@ -2181,13 +2177,12 @@ pcie2a_phy: phy@1c24000 { reg =3D <0x0 0x01c24000 0x0 0x2000>, <0x0 0x01c26000 0x0 0x2000>; =20 - clocks =3D <&gcc GCC_PCIE_2A_AUX_CLK>, - <&gcc GCC_PCIE_2A_CFG_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE_2A_CFG_AHB_CLK>, <&gcc GCC_PCIE_2A2B_CLKREF_CLK>, <&gcc GCC_PCIE2A_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_2A_PIPE_CLK>, <&gcc GCC_PCIE_2A_PIPEDIV2_CLK>; - clock-names =3D "aux", "cfg_ahb", "ref", "rchng", + clock-names =3D "cfg_ahb", "ref", "rchng", "pipe", "pipediv2"; =20 assigned-clocks =3D <&gcc GCC_PCIE2A_PHY_RCHNG_CLK>; --=20 2.25.1 From nobody Wed Dec 24 19:53:59 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2AEB18036 for ; Wed, 24 Jan 2024 07:37:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081858; cv=none; b=ClBIGS2esFs2BuR5G7pEbNJ5v2EOwFY4jZCMUN99wwL3FbedE0k69n/9iWfM3p40nMxIEzAp/eyL2dK02U9k6/fVaye2E/oogJk0yHMdQhAxDJSn0gJ8klchEOqwKv2znY8GUCJgSE95C9JM0I3TFvRTjkSH5WCfdt4JsQz5kFQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081858; c=relaxed/simple; bh=49EHGJo+BF0aAusaw6YV9QxMus+FF03TSQS/+RfWzT8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jZViqLkkAcflWPUU09h1LuIYjHi3bZx0p/HUYtRSLG+IggOjSnkZT4XSTCAoA2KqP837ggdhsLqLofv8U98rni6p4s3VmdSKjDzL2ruh/vsHGAE59D1wB8vuO76QXBD1+mDXBTWPQRv/5JasxWDhoas74wnS4Oj6Ql58Het+n9Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=f6n0ox3Y; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f6n0ox3Y" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d76943baafso16005245ad.2 for ; Tue, 23 Jan 2024 23:37:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081856; x=1706686656; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=l7zLlm6d5CA8X7mFvOVBpegHqSNqfCtqpbevUvsC+dc=; b=f6n0ox3Ye0bBgUyud1D+I8nRBT87hhyONbKULfaA4t8eZmWEFrNQAN6cvBTY8+n6Tq IpAeQh7Wrp36z9hBRUGBdcE4ULSBGkW+ujYpwGiIlZirJXmB22ASUHVPKlfcXpVyC/Bj TFQXrOYSIwPJH9wvnic5gPzA+CNByEWwIDqPxQQQbSFw9v89djL8RqKuknL2l5JiBbVg CeYcC8aw/YnLbRTO5cLlRCB2WZCJL8wXEB6NTptyTppXaxL2Wc2jiqrHSxsqI2S+SC+L xmtehyDS/o/DC7SFwE1MFgVlVkV3Njanl2TjX9sGjX5elH9dWXJEuk+x9d+xShqo8Vm/ jcsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081856; x=1706686656; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l7zLlm6d5CA8X7mFvOVBpegHqSNqfCtqpbevUvsC+dc=; b=rsKsI/bDBIp1nkz7L8MQQfhhIT5BZ+5IkxQ/0Hp0cKK9qYPJus8RAZxfy6qrsSM8G/ 13+RiMlh07ggD6HWpJb0NZJ7K1ozCaljj55dmxkYpdDFME1LB+Fw5K0tyqrtNPYYnhcT 6CIcqQcO9YtITkOk723j7rEQjq/ygH9R7zkVpRwqIqPTfBBLIca30grQqvhULB7472n9 jLphpgYUtf/4OCRks33fh9mBfPRiRbA3296qXL2IXMECQDk6o/uG+lmYVNiFua9pu+29 Jiv/nUPASaRZtYFwuHggiELSwzOP9XdkYXGFoUbSdtMhJGqDbn+iVQyj9PJvSZNvtrSv vk8g== X-Gm-Message-State: AOJu0YzhH0r8wDxDmrxNH2th1Q2tvEIiJJWrVTED+oPJSvtDIBRz4pwl Lhj1yLPgggY2n2mD0B05cuP80GmRsDorhKIf2nrPc9dYjZAQj/Yk/ftFo8uA4CA7e8MDeu+ZtaQ = X-Google-Smtp-Source: AGHT+IHlsAL4NqkYacbzZuLMy3cYbkj5DCyJUwh+SajhTTNjeDpitNlfwHG4VfJa42WgZplyNBAqSw== X-Received: by 2002:a17:903:11cc:b0:1d7:46a2:9383 with SMTP id q12-20020a17090311cc00b001d746a29383mr326721plh.33.1706081856061; Tue, 23 Jan 2024 23:37:36 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:35 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:38 +0530 Subject: [PATCH 10/14] arm64: dts: qcom: sm8350: Drop PCIE_AUX_CLK from pcie_phy nodes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240124-pcie-aux-clk-fix-v1-10-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1736; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=49EHGJo+BF0aAusaw6YV9QxMus+FF03TSQS/+RfWzT8=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4EBMA0JPQ+taWm5D5iCJHV6WyXEqHPIoZZD U6GiyBn8wSJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BAAKCRBVnxHm/pHO 9Tf9B/wNcnSzONZ35yT0CY2kXhWYHcTu/lh+g6/zyMICDLDyuUoIMb84lVoC1rzB15CMmHG5HYL uc14OFvnZFRmLblaowYZ/f5Gc/MX1XdfLaBrkYtj5V4xNaBjlT3cOdSRxXbtW8dda2fkIz2CJ48 CcESQ81hAKgTLVk0h4dD0nAy/7E32DB/JFTlLbbe6CcTCpY4lBw/o3JSZuA+5xqXgJMGl2SkwM8 1IJb0QfcO1jIR2kcVwtinNom162H83LDvSZhcvgCf0WQlH802OzK6Mv+nDTLUUEPlvNrMRgul5z VFa01hCGZD73rM3RkRBHO3v8SvvcXVIl/u4NTdYV5umIymGM X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy nodes. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qco= m/sm8350.dtsi index e78c83a897c2..23a9060f21d9 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -1571,12 +1571,11 @@ pcie0: pcie@1c00000 { pcie0_phy: phy@1c06000 { compatible =3D "qcom,sm8350-qmp-gen3x1-pcie-phy"; reg =3D <0 0x01c06000 0 0x2000>; - clocks =3D <&gcc GCC_PCIE_0_AUX_CLK>, - <&gcc GCC_PCIE_0_CFG_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE_0_CFG_AHB_CLK>, <&gcc GCC_PCIE_0_CLKREF_EN>, <&gcc GCC_PCIE0_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_0_PIPE_CLK>; - clock-names =3D "aux", "cfg_ahb", "ref", "rchng", "pipe"; + clock-names =3D "cfg_ahb", "ref", "rchng", "pipe"; =20 resets =3D <&gcc GCC_PCIE_0_PHY_BCR>; reset-names =3D "phy"; @@ -1654,12 +1653,11 @@ pcie1: pcie@1c08000 { pcie1_phy: phy@1c0e000 { compatible =3D "qcom,sm8350-qmp-gen3x2-pcie-phy"; reg =3D <0 0x01c0e000 0 0x2000>; - clocks =3D <&gcc GCC_PCIE_1_AUX_CLK>, - <&gcc GCC_PCIE_1_CFG_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE_1_CFG_AHB_CLK>, <&gcc GCC_PCIE_1_CLKREF_EN>, <&gcc GCC_PCIE1_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_1_PIPE_CLK>; - clock-names =3D "aux", "cfg_ahb", "ref", "rchng", "pipe"; + clock-names =3D "cfg_ahb", "ref", "rchng", "pipe"; =20 resets =3D <&gcc GCC_PCIE_1_PHY_BCR>; reset-names =3D "phy"; --=20 2.25.1 From nobody Wed Dec 24 19:53:59 2025 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0C79182C5 for ; Wed, 24 Jan 2024 07:37:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081863; cv=none; b=Sj+QmD5OFy742YJeaOlMpGsWjf0LbhezD3FyHMlkM6RNxTyr60mTCcSQh9RPqLUKupWzkRboCI8X1di2pHSNXuuUN40XSM+GSUdjyKFyUJC1ceuL3WMKn9iuBAY/MLEc9TJqHIGy9rqt7/pdGtu+UyW/nuf9NZ6GL6LqWqVmwvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081863; c=relaxed/simple; bh=q4REQuD/EeSNLvb14a6jAbCKy8un8bWTNayXDrd2sPM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ug7RwP2OzjJ9hHhiTWgcsO1bBumgVFA5gIqtHdd5vgwilYn0mSNMKtW4cAj7IWTp/YMnbbRlR14/58lFCtl4D+CosrDmbz+Lnc1c5OxGcW8lqyzacRBZjqUx8MZq69OXby0Z6jWAYe5CMOj7lZhCs27A5oOvb5JPRZfTcj2FYB8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FeS/Mc3O; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FeS/Mc3O" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1d74678df08so17903885ad.1 for ; Tue, 23 Jan 2024 23:37:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081861; x=1706686661; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=iKf4wr/PhU8C8jJcjTd70SR5SaHAZ16yhIfEOdFxtCU=; b=FeS/Mc3O+PkDme03Q3I6psF2rQLLGCib4DK4sbfXEQw/clSxP+ZV7kZBEb07olE91X pk6agObsYg2eEjfpGpvHI7WWkgYXE2ee0Q4S5l7+sCHiCFkZXl/B810DN9EYsUFI1e82 2KyszLR4NGW8GwH+Y3A9vZQpWm8A2DFSaygWAj0CEarB9ZjcmjJhABQhcUt7fB+ocCmD kQQ6V2HtawQp4l/vey0BwCDn+QBoRLBjJAhueVVIPOmKYMswIWOYOuC2wEPuTlZFTWj2 q+8p1uVAv0kPkZyoLZEv/hshJgDkpJbV0SId8Rdpo1eyu6CX+zTHwFFJihsCZshVnhLF Z00Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081861; x=1706686661; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iKf4wr/PhU8C8jJcjTd70SR5SaHAZ16yhIfEOdFxtCU=; b=Tigvm3WQB28pd+DUbjKNC4mzHwmY0hQjgW6iLC2697Fey3D48OmTWOpnHXBpezVLM2 iOzavEu2gY4Khi5vzIW9l3na7AAvtViW7xqqcOqRlYp/O1SRWygCjVoOfikeF1OQFic6 oS5Qxl4P56/jxBCAaz/QvY6nXxi/hFOUA2ftgUPqe6NAOUUdRg5TpjI1wKpO5KW5CIPv e/7vJpA8C0RXwniaC5LJlyetnhqEO8s0qmEcu3LBRHeDtlgaCiaGcxE99KbxdpnqEvBU 9AvB7sUuPmQfLOu8AiH3yMg8mHjiwvZNg8xoN1aCEjei7mn/vY9OtE8xPo5PgBasAgAp iOTg== X-Gm-Message-State: AOJu0YwGoXQTW0SSgeDELKi7ZgYmLTeiesLVElKDOHVYc9gUa98rHlqK cSJbpD1ABiZR2X0epFCb9fGTsBHh8t8tGH4P/j14rQLRcmyEtgC7Ng81Th8rAQ== X-Google-Smtp-Source: AGHT+IFzkjDdfXVH1eFhiSZ/tTh3VQLR3Zc4fY3VVxilv+uGwzMM7MRyx1ANpgPtt9PStovNzoxI6A== X-Received: by 2002:a17:902:d34c:b0:1d7:17ce:cc5b with SMTP id l12-20020a170902d34c00b001d717cecc5bmr300844plk.133.1706081861253; Tue, 23 Jan 2024 23:37:41 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:40 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:39 +0530 Subject: [PATCH 11/14] arm64: dts: qcom: sm8450: Drop PCIE_AUX_CLK from pcie_phy node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240124-pcie-aux-clk-fix-v1-11-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1078; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=q4REQuD/EeSNLvb14a6jAbCKy8un8bWTNayXDrd2sPM=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4FuIFWugJBxWD5/8i6mcSozobTq0w7ntmVL VXJIpEnfTKJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BQAKCRBVnxHm/pHO 9QAsB/9WNzb2oQg0/MVu/Ww+cCD6j6lVrfmW+ehkb9jNlHHSOJbLRlu3JI1T39wTq26klASZlbZ +7h2sNu4y+h4T1zNFyxE+sqhAXkOkO4E0wiLMcFaDg2Hh2YOnAC2wMe5ieylobU/Oy33OuJCMTE GqSttxJ8dfRJjr8Ks9tH8r02I5kPEGjwHaOg8d3YzlddoOyM8ywBOFiTMHNcqNj6nk+J8FylhvB lY96HKZx28DIjqFR8z1vQ2ft8VlwJgjXfK/u2ckDV7GYilXZM9PCSY6Jn2b1tpeVsr8HJR1RGuH uCMB1vw4LnwteK6iPQABiiocCqFgYw6wNNC9cZ0mPbTgubXw X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy node. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qco= m/sm8450.dtsi index 01e4dfc4babd..1e0091dabaf1 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -1830,13 +1830,11 @@ pcie0_phy: phy@1c06000 { compatible =3D "qcom,sm8450-qmp-gen3x1-pcie-phy"; reg =3D <0 0x01c06000 0 0x2000>; =20 - clocks =3D <&gcc GCC_PCIE_0_AUX_CLK>, - <&gcc GCC_PCIE_0_CFG_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE_0_CFG_AHB_CLK>, <&gcc GCC_PCIE_0_CLKREF_EN>, <&gcc GCC_PCIE_0_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_0_PIPE_CLK>; - clock-names =3D "aux", - "cfg_ahb", + clock-names =3D "cfg_ahb", "ref", "rchng", "pipe"; --=20 2.25.1 From nobody Wed Dec 24 19:53:59 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 005021862B for ; Wed, 24 Jan 2024 07:37:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081868; cv=none; b=WZQUkpnfoNMnUkoaN3tOKnVpFqa2QatWbNb9dMFSPvKQqGFJhWCcrqCzRBKTSRMqizunK174cXHn8mFRnBD/+oGRpvTtnCqEznFk1sqxdKRmRqH2prYNY18IavtJ+zXzv8Y81KRkF5r+wlOJbZvLD/Qi+yzjzUKblREHMyxkhf4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081868; c=relaxed/simple; bh=qbS3T4RFVlJivCmN4hJ4Xsqqhf8ddqNIBdThgGXkGnY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YlVgJS5PEWXApNCviTcwRfD3pwjrY1bhsv6xjZ+eGcbhMYeTgKjzVHhbWjRKJMw5CV1p3GcqVlkYBLlk0fMk9CJ183JVmduuoX8yfehn7gstpEKeO3gTBS7uOAZLu/wa0qBhFOOAAG7ZB6gDNjQQYtpBQbL0lUnwhDEc46wJCV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fDR0ooxz; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fDR0ooxz" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d76671e5a4so16799375ad.0 for ; Tue, 23 Jan 2024 23:37:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081866; x=1706686666; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Mr0QFQLGsGU3UCE22ZWg0GRl1d55JhYRsXZlu7CT5Ek=; b=fDR0ooxzPgOb5seJqk5RyZfQ7uOmbZtOO4VXDxjS2GlhZGDF7+ur3PzMKb9icrbUeu mvfAsdDgD4vc7ow6FVyEB6X4l0ohhWG4l+z+bVF0Tazuou7Csin/LD2zmhmEUQIodPGf voinQqXVb+nDPIPuk+6s1tT9zu6JkGDfsm5h8OfpJy4WD3mQo5uk6KwSVaYF0MiLZ0Tp WinvzsWBQW2G5Yegdsmcbt8eU1mZYfuFVBnRAvu75kcJrNvsITkNrLILWDpiSyzX/+mt KNS5HY6rYAqBg24VkYtopPKUDqPwi7JExG48tl0vZkQEdAd7BxlHGMYVfbDGwuofv8w+ ao6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081866; x=1706686666; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mr0QFQLGsGU3UCE22ZWg0GRl1d55JhYRsXZlu7CT5Ek=; b=qmcOy09jnSMu1w2x7D5tJCLrZtLBVDMQdtOovtpb+Dd+/FIH6IJnBr4Joxnc4j5sok tuQZq59fBJH5bAouo2Hx/Xy4jUsPSHE7MOIy9IQqyZRU0LwLzqJIjTVZckL+4jcEseFT hKd5UnQqqTNeUceTaxEPdtkFEjcnrqy+YK3qo3NFCIABLTM/OUSjcG1HorQYFACL+zqj GG5mw3xk5rjcKampV1Hmu4Vb7u8dJbpFtG5QYxamteGCfWgmGz5ntG7ZxmYZHMU03t2w Xcc5j4pOFuZltZ2wlieYmtByCagzQK447uHtFyQqTZNmXdzUTyv6YSWd5kiRxgoIpSE3 LlAw== X-Gm-Message-State: AOJu0YzHm80VY5vOzF14c9YmE+GT8MYJdVMnyW7xIQxy9CSAugI0qu3v G2RAcJrzurOXJ+nxrt2hcaws4BFlpPjCLgAA7iQwkJuTg1EmpHVhj26529vINA== X-Google-Smtp-Source: AGHT+IEemWCxH9v5TmBpKga6APSBH20NfGHRPu+nLdozyRscwokzFFdRSMk/PTPGdmr44O68Z+RdUw== X-Received: by 2002:a17:902:a616:b0:1d0:6ffe:a1a with SMTP id u22-20020a170902a61600b001d06ffe0a1amr440390plq.120.1706081866524; Tue, 23 Jan 2024 23:37:46 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:46 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:40 +0530 Subject: [PATCH 12/14] arm64: dts: qcom: sm8550: Drop PCIE_AUX_CLK from pcie_phy node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240124-pcie-aux-clk-fix-v1-12-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1138; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=qbS3T4RFVlJivCmN4hJ4Xsqqhf8ddqNIBdThgGXkGnY=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4FTWuUoQIXeVx6vSsYrfv+1E10lScR+ZHtL eUWXb94QZmJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BQAKCRBVnxHm/pHO 9dc8B/98bZbvZy8V9hBe0ncd/s65E4uiIGidQTmD+Dz0V9tH1ytXtu/tD2tpMNqK+QTIAJJq59X 3cuKmhgSQDgXiiz98Shz+xCq8TjmqYMNfyjopeq7+mHoGbS3y54BhY8pW7V+cpQmzMDJ/UcZNMp X1+8h+POmcY90EJ38NkAv16uOlwkv1dNyv/SpsV1vBSuc2OQ0tZhf2HGq7ukHPlPspq+0YO5ibA ABdoRog+r63cOF0yzw9CvkVacAQNkPK9y4qOhgNjk2AtcHR1Lt3K28V07t0RiIqWQK1X/kf9xvw T835vebbz9UYnVxLEPB23lI58DzhZjWFzE50unZQ6Wmdhubs X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy node. Signed-off-by: Manivannan Sadhasivam Tested-by: Neil Armstrong # on SM8550-HDK --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qco= m/sm8550.dtsi index ee1ba5a8c8fc..f074683f7940 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -1760,13 +1760,11 @@ pcie0_phy: phy@1c06000 { compatible =3D "qcom,sm8550-qmp-gen3x2-pcie-phy"; reg =3D <0 0x01c06000 0 0x2000>; =20 - clocks =3D <&gcc GCC_PCIE_0_AUX_CLK>, - <&gcc GCC_PCIE_0_CFG_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE_0_CFG_AHB_CLK>, <&tcsr TCSR_PCIE_0_CLKREF_EN>, <&gcc GCC_PCIE_0_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_0_PIPE_CLK>; - clock-names =3D "aux", "cfg_ahb", "ref", "rchng", - "pipe"; + clock-names =3D "cfg_ahb", "ref", "rchng", "pipe"; =20 resets =3D <&gcc GCC_PCIE_0_PHY_BCR>; reset-names =3D "phy"; --=20 2.25.1 From nobody Wed Dec 24 19:53:59 2025 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 391A41865A for ; Wed, 24 Jan 2024 07:37:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081873; cv=none; b=EHBibgwkQjhJ/d9Fo56Zn8ALSp4XS6uRnbFSb4Om7+0z7/AFVr0lZSnFq/4kXzts+70rA8khpYH3/uCt/yKhNzMh0XoOFXnhfnCDkEjmi+hioDBRASXhgrhVmK8kSRpkLLkldnQSPVJZC6su76ep49a+DoBaEhDQSkbJ/triGHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081873; c=relaxed/simple; bh=xR8wvtP+QITH8T8kLA9WFdRX9QC0BEnzA8VfMLDLOeM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ji4ftv7uT6IP/rqvqxD3x6QvRfg5wtVVMvF43K8c7xcUkydP9wh3Y88YLilV556E4Oo+aKMbF+8GwABbq3HIIfWC3oW0tqCHlgZfK0mTvnQuD7C0luUrUQcENk8Pbxfj3T7jT7vpXzwYDlD4c0K5/aWGSYobmyKRt/YAMLFaNqU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BefsVD9Q; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BefsVD9Q" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1d750660a0aso15089365ad.0 for ; Tue, 23 Jan 2024 23:37:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081871; x=1706686671; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=x/+eeHXYW9j18ErdmeKAUblHZYPts3oUBFN9HRjn0+o=; b=BefsVD9Q9hn5K6N0kUYSsaH/Hpn3BTvQNweDIw3Jw4n5P5HrAS8bXD1CUZT19iO4BN DdqiA5aC2/G3nxGSP0y5co17/rByAgFPyD6GErKuVybPTQYh/FzaPJ2zh4/jBQZCvxD8 Y/NGIEO47X5oQkY/kxplWxJbMgIWpwh6KPwrSA5Da2qSKv8ncEt+2YhEJEeBzMOmWd+6 v3DjIZoXkdlWEvghUM7q8tH0IWC9bY9zvjJZH4Kf8B1Fj35yZTkMDVPVmfOLE2jsRSwM yd8TRhnVIx7L1ZOcnJSnkkbmaSVAiScRArbxtPlr21NgWUS7XRiVah/mQwLyhUNBqlTu zQsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081871; x=1706686671; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x/+eeHXYW9j18ErdmeKAUblHZYPts3oUBFN9HRjn0+o=; b=MsRFYyLnfanVYg3auJxjwVXg1o0fB10rUexba0upWhGclLMuO/71x5lJKFriqEOwTi 54ZeQ0iYw/1tfxOg8lPINON9553CvsogpFaNAAiz4z1BPYgeCwj5clHkJzXLC2IQ6XOF +rAmhQDCCYPVed7YpNUusxtXAKEVXO9v2gyb66He6Azy8wjGYXG82CdhwhchMeMChMDz AhvT6oLQThxLvvmtfJk2p8ueCM5DgHZmTPNbgGv96nIk6Zm61M6uoJL5ZCrv/FwFOw4D /y5xyKrjAQuO3yKPp4VwfHlzXLDA87KMio80i8DXUBhdw7JUQUW+lkZhhXHZbjkxDUfI jyeA== X-Gm-Message-State: AOJu0Yww0AguQH/1xA5D35IE239fuVuUTbofpdts0k4V3nTZ4tSEX6G0 f9U3e6WUV29Od1qoz1VDotEYnyPDbR5L3g6uulwvsHTcY3UhvqDbznQmgvVi8g== X-Google-Smtp-Source: AGHT+IGj8U0OzY/bykwYZTLT4LfvcdMXaEwp0Y2P7Vpl0XFVBweFCBMR4mKw+7UkPyjrZCQ91xNUoA== X-Received: by 2002:a17:902:f687:b0:1d7:4c1a:2058 with SMTP id l7-20020a170902f68700b001d74c1a2058mr253915plg.105.1706081871600; Tue, 23 Jan 2024 23:37:51 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:51 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:41 +0530 Subject: [PATCH 13/14] arm64: dts: qcom: sm8650: Drop PCIE_AUX_CLK from pcie_phy node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240124-pcie-aux-clk-fix-v1-13-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1080; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=xR8wvtP+QITH8T8kLA9WFdRX9QC0BEnzA8VfMLDLOeM=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4F9I2jnHfAODN1h6LhID1P5M4ffX5SDTNOK tmbdlVDGn2JATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BQAKCRBVnxHm/pHO 9e9HB/9IOUcSo3ViZRQJMCk/7G0FlXlhNFCiC5rUFKMDKuWujGHro13gDGJjTczje/BKnWxULGQ xvxbYT108gLh5mEcp90g5HVfToMp1AArsS3Fqnai8z0TkKnd+2dfxOFFow35x16YJnZmlE502Ae gw/DKa8Yi3+H7Pogj6id8NcfMHlRwkwwzBE6psr1YYv4uIIdIlKAqJvtav8irLGgRCHnD+IfL2L wYgrv/PZB13YCBXxVS2lSTYEgTY9HHM2SpVutjUixxncsHPi+v+Ic0I6Wu5T8Y+f2yaBax3w9Ll E80RfnrBnVFBA/a+DyEiXU1+AXBZ1W0D07uUrZBUR2iYa8GH X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy node. Signed-off-by: Manivannan Sadhasivam Tested-by: Neil Armstrong # on SM8650-QRD --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qco= m/sm8650.dtsi index 2df77123a8c7..b31e60599891 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -2276,13 +2276,11 @@ pcie0_phy: phy@1c06000 { compatible =3D "qcom,sm8650-qmp-gen3x2-pcie-phy"; reg =3D <0 0x01c06000 0 0x2000>; =20 - clocks =3D <&gcc GCC_PCIE_0_AUX_CLK>, - <&gcc GCC_PCIE_0_CFG_AHB_CLK>, + clocks =3D <&gcc GCC_PCIE_0_CFG_AHB_CLK>, <&tcsr TCSR_PCIE_0_CLKREF_EN>, <&gcc GCC_PCIE_0_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_0_PIPE_CLK>; - clock-names =3D "aux", - "cfg_ahb", + clock-names =3D "cfg_ahb", "ref", "rchng", "pipe"; --=20 2.25.1 From nobody Wed Dec 24 19:53:59 2025 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E38318E0E for ; Wed, 24 Jan 2024 07:37:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081879; cv=none; b=TJ05lh/6sHzRhAOJHZ3+5ihm5Q9/rkndr0Cl62/nrMTFkj5V9dJT1GaJeGThfWwYWBlqo1o9whlxrelC497/2Ms6P3eW4wWWqGfi+qI1J1mha9EXWA0ylFmWkfLv6oPFfw/a86h4B6nbJte4lbtiRrIcUTkkNcoxgdWyvOvXwPQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706081879; c=relaxed/simple; bh=AV0AQVKEuKDRIth7QZV7qLd22LfBtighoMaozbvkXAg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VMugxCtAoDom/Xfal87d1STkhaPDTlBqT5VurG9OvsjIJUyPJg0By1crKyrDjZgw1f8yBz80TGXdr/xaACsroBlOMxolMvS+/Z6+dV/8J4WQKf2x/dIFIu/MHa+ICum2wNRLXbr99gfBmJyFPw7ll4MEHz9GOZ2AWsYECidnNaA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BUMJTqUT; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BUMJTqUT" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1d746856d85so17837955ad.0 for ; Tue, 23 Jan 2024 23:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081877; x=1706686677; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DJs+PMBAGDBvXkVQNcVnd/NTo5VAtnKOcQ/VzO4TVvE=; b=BUMJTqUT5sRYVUQaeLoW2vTU7TuokWuQNP1M2NMeHj2u1OloZTp5TEl2lj7m0deM4e 7I5nro+ldwNoWH77gLGlQmMSjxTMmrMR/8+sNutxZLD1usBZUVpY/LpxtWJnWxSbMQhi YoUdZwZwByYseX4q9vjy9Ko5QaA3P2PlQEa0UmafhyMMsklkh9Jt5but1NoXdBTY4IzO H5bnqrC6jOJdVaVH3WVHOdtTogpZvqywCXRwTzckR2xeZpOTuNAID9eOSv3X5+osqGGI y3rZVlUX3c42Fg2ew7/xSuOvsNxnX18oJs3vzcTl4Ix25DDOj/cZ039MWzGJMnp9d3Fd n5Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081877; x=1706686677; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DJs+PMBAGDBvXkVQNcVnd/NTo5VAtnKOcQ/VzO4TVvE=; b=HEEl03GLIwm6pxpcYV2NJ/10cW9EtBYQp1JU/urLsSNugThLpR4kfor/XQHH+jIcJT H58Fu4jOmX/rfVha1/wnIhlghE3oinjYYiR7MzANbQ1e05HhQRHd216OpKgAwqZ6rJm4 3IqMVuKAHkPaaWd65/Mv6oXh5PV0ErwLPVYCtSipPj+0tWdVp3mpj0QLH78Qtlp6zhEg 8NCwZSzkRCHZvqHoqUMgCSn3rEiUOE3WPVnkvhyJNofWjLHybrib3XdhGNvxhqCKq3ye Si5BrFtXf75JBss9c4ZNKiqJHzEh2V4WkPxNM7HwXowPNynXf2gzP7kSl60qA8rxMEvh qhEg== X-Gm-Message-State: AOJu0YzbjQBfAF+0SgexUsk9/DbVh3mlbprXpw/wFkP4HKrtbEnibeOO pRkleojY1zBRFlIaw+q/F8O2CIv4vvxund+KqPPGA0vKJmfW8+FV0MfyoRuqcw== X-Google-Smtp-Source: AGHT+IEE2l1wj9BXbay2mDG16hgBi9RNBmfBy9y9+PIFIVWJ/aOh9+lHuObbBTLFHE3YbFHRDrktmQ== X-Received: by 2002:a17:902:728c:b0:1d7:199:cfb3 with SMTP id d12-20020a170902728c00b001d70199cfb3mr292163pll.70.1706081876913; Tue, 23 Jan 2024 23:37:56 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:56 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:42 +0530 Subject: [PATCH 14/14] arm64: dts: qcom: sa8775p: Drop PCIE_AUX_CLK from pcie_phy nodes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240124-pcie-aux-clk-fix-v1-14-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=2114; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=AV0AQVKEuKDRIth7QZV7qLd22LfBtighoMaozbvkXAg=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4Fhhiw+ROelMo4VRCj1+Kx7T9cS2AThYZkc DknKia3ul+JATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BQAKCRBVnxHm/pHO 9bthCACRQjvyFRVJy3hTYxwCqypCA959YVl640Spi+/5TQUxSwUS5HOza3ZjI6ZCE6ZAV0awrPp Ma31wRRoKSgL0QcvLroRMpG1W5pN5E1/CJq/7joMoTGV0Gytn1w4fGIB6/kSXkiPqOPMbNMCVFF Ngelg4E2chxrplR8oOICcl/mKuhw922a3poiiA+oCWhEqfmYWYYtsF2apAswH19tebHdmBaK1SZ R6CuqE5X5TaD+C9YLOpC2/R0IwNZhXa5IF44UqN+Z2XWohLPbBrvLIpcPH81pLIQtrGgFaeeM8N gbnY/iNcmWsx9j3N5iilOXhEMCW5MWYCIzifzYfgmlKRHqBf X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy nodes. While at it, let's also rename "phy_aux" clock to "aux" clock and move it to first entry to maintain uniformity with other SoCs. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qc= om/sa8775p.dtsi index a7eaca33d326..b99626c52800 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -3590,16 +3590,15 @@ pcie0_phy: phy@1c04000 { compatible =3D "qcom,sa8775p-qmp-gen4x2-pcie-phy"; reg =3D <0x0 0x1c04000 0x0 0x2000>; =20 - clocks =3D <&gcc GCC_PCIE_0_AUX_CLK>, + clocks =3D <&gcc GCC_PCIE_0_PHY_AUX_CLK>, <&gcc GCC_PCIE_0_CFG_AHB_CLK>, <&gcc GCC_PCIE_CLKREF_EN>, <&gcc GCC_PCIE_0_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_0_PIPE_CLK>, - <&gcc GCC_PCIE_0_PIPEDIV2_CLK>, - <&gcc GCC_PCIE_0_PHY_AUX_CLK>; + <&gcc GCC_PCIE_0_PIPEDIV2_CLK>; =20 clock-names =3D "aux", "cfg_ahb", "ref", "rchng", "pipe", - "pipediv2", "phy_aux"; + "pipediv2"; =20 assigned-clocks =3D <&gcc GCC_PCIE_0_PHY_RCHNG_CLK>; assigned-clock-rates =3D <100000000>; @@ -3690,16 +3689,15 @@ pcie1_phy: phy@1c14000 { compatible =3D "qcom,sa8775p-qmp-gen4x4-pcie-phy"; reg =3D <0x0 0x1c14000 0x0 0x4000>; =20 - clocks =3D <&gcc GCC_PCIE_1_AUX_CLK>, + clocks =3D <&gcc GCC_PCIE_1_PHY_AUX_CLK>, <&gcc GCC_PCIE_1_CFG_AHB_CLK>, <&gcc GCC_PCIE_CLKREF_EN>, <&gcc GCC_PCIE_1_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_1_PIPE_CLK>, - <&gcc GCC_PCIE_1_PIPEDIV2_CLK>, - <&gcc GCC_PCIE_1_PHY_AUX_CLK>; + <&gcc GCC_PCIE_1_PIPEDIV2_CLK>; =20 clock-names =3D "aux", "cfg_ahb", "ref", "rchng", "pipe", - "pipediv2", "phy_aux"; + "pipediv2"; =20 assigned-clocks =3D <&gcc GCC_PCIE_1_PHY_RCHNG_CLK>; assigned-clock-rates =3D <100000000>; --=20 2.25.1