From nobody Thu Dec 25 01:28:06 2025 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4541551C52 for ; Tue, 23 Jan 2024 06:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705990680; cv=none; b=N4PAGgLUX9rv+L6sgMn0/nGYHoUG5vn0NSMg3KpWr9KF/tz9wGd2Tp9u72BlKmbkeJ9KTBfljwK2J2pTUxBpD9GazE5tPP8jTzqgbo6XD+2tpRMnGX4BNrpsNAwqalQeYhvwSQnvB9TCXo+H6PXkmzgJF0B8OwoQPJqGLZ1X8ro= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705990680; c=relaxed/simple; bh=1bu5VdLVFE0vJHO/4YwoTnP20DXloan9l7QgOTTeZVQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GD9WTmK1YsPG/1gkM58Tn2XTxvm2DoheEonW/lLm5mQ1j/WXhcVB7WbJQygJyOAUVVpnBPBRlcH6xzM0coJaJWK3zZ/EYcKcSz2K9R2Z/r5f4lj8bTQzpF/EsMTnvB6toi7zFzLFW+Up5hFjJPgxZDQdi9YJDqMbP9Y54wAuEMg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=aphb7JZz; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="aphb7JZz" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-5cfa71498feso3468815a12.1 for ; Mon, 22 Jan 2024 22:17:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1705990678; x=1706595478; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ME8YwPbdKoUEBb8pwsupWQGlI6P3cfXncKX/A/ie+p0=; b=aphb7JZzFwmTJdMlCCY9FGsd4ysrwgqQduQH5NJHxM4CgLKK6OMz2vPSKuCstyuvdb 0eReCnXKNP4CMjxslc7efJa7lXUxDG5AG2XEHZGsK1G3yRdi+nMjPImW5M12iaSmYDnS Vn9CpWmvGE+XZSkh7NnnimZP1lz+JCxhxBVN8nr9ujj65yl1x37wCBW4XZ4fQeFyQ+fu +gSykohJ3A1qjL1T0SaaGUnaL95uTj4HkdZxOuGoJrgNzQe2E8pXOZSQvr8v8QVkbyVg sHWAHfrHuPq2Ai281voMCEHDUCzuIG/xn6Rmo5h/wIQS+hkMV4Nrh9ljRQFT2YlDzDoa EAIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705990678; x=1706595478; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ME8YwPbdKoUEBb8pwsupWQGlI6P3cfXncKX/A/ie+p0=; b=vUNsVpRu8+ID7D+kPbnu/wx9dXNEeao5ldkAJI52HeXfspopA+2PeEBCOVDksd7JpH HZ+ROodCXNR7MAN0ov+D6zIAWLssriYU2MAImFnHJQGDStyOoZYqM78Qs1QZtyVSJure rHiYQZ/J9G4uOThknLAWQsRgZXMC34EbR96VBiCPshUhfCi34p/BUOta6SUnsPs3uPyI ysmZZOEWVX8w7lBKYvtWVvjIrFxRgLLT6qR7cnFmbqfxfzVfs0E05wV9FqH/9mNbPFUD DpizNXkjXXg6QjwgVFpJdGFZ/kePX0+2T7t/qFM8cnU2yNeNG2rQAaHD6taivup6qFy5 Rgjg== X-Gm-Message-State: AOJu0Yx8uJCLoscW0WGz84nH6YTknpStvM45q02Fg32juwE64tvx0FwJ p3iTR4W2a71lc2njmMYb1Wc68PTxzcHLsdcbFzUBJ9Lq5fkCgwBlixGtCVUQExk= X-Google-Smtp-Source: AGHT+IGilp1NHJ+bOxCNhyXEG/4JAD2rrjQuIW5uobXx3C9HXC0+T93+AoaL+nis4sBdTei7ICbDBA== X-Received: by 2002:a05:6a20:4387:b0:19c:4fcd:fab6 with SMTP id i7-20020a056a20438700b0019c4fcdfab6mr1483066pzl.40.1705990678572; Mon, 22 Jan 2024 22:17:58 -0800 (PST) Received: from hsinchu15.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id p7-20020a170902b08700b001d733c88646sm4425376plr.216.2024.01.22.22.17.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 22:17:58 -0800 (PST) From: Nylon Chen To: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, conor@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de Cc: vincent.chen@sifive.com, zong.li@sifve.com, nylon.chen@sifive.com, nylon7717@gmail.com Subject: [PATCH v7 1/3] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties Date: Tue, 23 Jan 2024 14:17:46 +0800 Message-ID: <20240123061748.8844-2-nylon.chen@sifive.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240123061748.8844-1-nylon.chen@sifive.com> References: <20240123061748.8844-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This removes the active-low properties of the PWM-controlled LEDs in the HiFive Unmatched device tree. The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematic= s-v3.pdf[1]. Link: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f= 8698_hifive-unleashed-a00-schematics-1.pdf [0] Link: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f= 4192_hifive-unmatched-schematics-v3.pdf [1] Co-developed-by: Zong Li Signed-off-by: Zong Li Co-developed-by: Vincent Chen Signed-off-by: Vincent Chen Signed-off-by: Nylon Chen --- arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 12 ++++-------- arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++-------- 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/ris= cv/boot/dts/sifive/hifive-unleashed-a00.dts index 900a50526d77..06731b8c7bc3 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts @@ -49,32 +49,28 @@ led-controller { compatible =3D "pwm-leds"; =20 led-d1 { - pwms =3D <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 0 7812500 0>; color =3D ; max-brightness =3D <255>; label =3D "d1"; }; =20 led-d2 { - pwms =3D <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 1 7812500 0>; color =3D ; max-brightness =3D <255>; label =3D "d2"; }; =20 led-d3 { - pwms =3D <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 2 7812500 0>; color =3D ; max-brightness =3D <255>; label =3D "d3"; }; =20 led-d4 { - pwms =3D <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 3 7812500 0>; color =3D ; max-brightness =3D <255>; label =3D "d4"; diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/ris= cv/boot/dts/sifive/hifive-unmatched-a00.dts index 07387f9c135c..b328ee80693f 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts @@ -51,8 +51,7 @@ led-controller-1 { compatible =3D "pwm-leds"; =20 led-d12 { - pwms =3D <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 0 7812500 0>; color =3D ; max-brightness =3D <255>; label =3D "d12"; @@ -68,20 +67,17 @@ multi-led { label =3D "d2"; =20 led-red { - pwms =3D <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 2 7812500 0>; color =3D ; }; =20 led-green { - pwms =3D <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 1 7812500 0>; color =3D ; }; =20 led-blue { - pwms =3D <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 3 7812500 0>; color =3D ; }; }; --=20 2.42.0 From nobody Thu Dec 25 01:28:06 2025 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 481C9524A3 for ; Tue, 23 Jan 2024 06:18:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705990684; cv=none; b=mw15vGPs9kbbOjmFNCKjaMq/M6VU6GN/DXIyUFkg9f02INxHKYjnnpeFNndvhGCNyZf+cvHVzXhpkym1Jd1ZQb/vMWj6MBi6Oxz8P+LTIvbgW7wbb6rOk5szHL4wocYRQo54BSjNZdVHapZbJtAmSUq2yWtvqewvfpREv32zOr4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705990684; c=relaxed/simple; bh=d06KhWfzzNhEwLATG5EAKVuMF8lG+Vj1y10Kz7W9+ck=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XJlgN/KV8W0VbFjyI574VBe8CviNmOYA60oEZYsiYhRsA42tJzvtnVc3GK1UMHft2U67dQIXSPFCqJZtxMca6ucFYtErQiHeO3/87N3A8Ib9nyVPb1jj+YixoBQTh7lmS9rd3Tlfcfar4Vw/OX1X85AJ+ASnEuNEsfo7nHYVKxI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=Jh0u21DP; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="Jh0u21DP" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6dbb26ec1deso4084243b3a.0 for ; Mon, 22 Jan 2024 22:18:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1705990682; x=1706595482; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cvJrbymRDVqsWiIagFJrDLqKjAGvymGFfMj4nY9d7Jo=; b=Jh0u21DPLVeCt7bQ7t/gweGDNXqOIZ5NRYS6eqCkWL5cT7gUmUT+5y0UATXHigJZ5+ iFqRl/liZyKbF4+/xmK7B3n9yIxiYXXYmFFt2xytr+I59FUluy3OgfH8bfv0awAEVWnr ymMGgyF2MFzbvJA7/hXosVGu33yJmwz8hqV5mlQ03ZTrg17xSsI8zi2iSGZWyMH/IitL 9VRD5rdlus9AjhzZ3eKdA6k9QQUbblYltd+Q0zRB0oXx0wqRU35A8XKmBjloa3D58RAd pJ3u9eysWacsiIt3mYVXcr9gfCq5IR49Ig9ycFpZJn7dTYVZtqN6IIivlMu8zp3Ampby hrwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705990682; x=1706595482; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cvJrbymRDVqsWiIagFJrDLqKjAGvymGFfMj4nY9d7Jo=; b=MD+syt3xuNDSWy8fzsdZ9f2/LveWf+cyAisZJMcyq4Yq71c7ZlpcU3g2Dl40ivHJ0h PWz4iPPGky9Xb5yCDdXVXARjKw5sGlhuTvA5ErMAkjWIa5jCze8eqK1cupfPca0YYBLW /9ltHWyOdeHGzpNr/sLFXtQgmSrxGJRzA0l9FKBlxYCtyiOFH08Z0fzskPwpLSfnU2RS zxbpPPzx9LOlNkRbJMpv0+5RrwUWOPdRjWfa4DP+MBTbZvc5OMCR9OB7bbCXh0yQB/J+ Tfwsbb8L+UEhYhBF13/BmkjfqfzuCw6oXDVe6GE3bAVg8ZQEqsw+wRWIk72sgx+LroKj 41ug== X-Gm-Message-State: AOJu0YwYkhZO00FCTISbT+zy/1zKIsaRP4vzNaqcA9bF0WmUrLQauDW8 YEa30ynvH5zN91TZUYxXaZTUy1z8qmr5aICeE1OEzjYN8O3JQf8tWndxlI0EtM13iWuCRI9jBF0 r X-Google-Smtp-Source: AGHT+IEOZE+FU/vU9PCxfaGkCTPgaFa/4ycXAtuyVM2ziXvmuqSrHD4wV/6kejsabMmCEqh/hFuYzQ== X-Received: by 2002:a05:6a20:3d96:b0:19a:da41:9da with SMTP id s22-20020a056a203d9600b0019ada4109damr6938288pzi.13.1705990682643; Mon, 22 Jan 2024 22:18:02 -0800 (PST) Received: from hsinchu15.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id p7-20020a170902b08700b001d733c88646sm4425376plr.216.2024.01.22.22.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 22:18:02 -0800 (PST) From: Nylon Chen To: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, conor@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de Cc: vincent.chen@sifive.com, zong.li@sifve.com, nylon.chen@sifive.com, nylon7717@gmail.com Subject: [PATCH v7 2/3] pwm: sifive: change the PWM controlled LED algorithm Date: Tue, 23 Jan 2024 14:17:47 +0800 Message-ID: <20240123061748.8844-3-nylon.chen@sifive.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240123061748.8844-1-nylon.chen@sifive.com> References: <20240123061748.8844-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The `frac` variable represents the pulse inactive time, and the result of this algorithm is the pulse active time. Therefore, we must reverse the = result. The reference is SiFive FU740-C000 Manual[0] Link: https://sifive.cdn.prismic.io/sifive/1a82e600-1f93-4f41-b2d8-86ed8b16= acba_fu740-c000-manual-v1p6.pdf [0] Co-developed-by: Zong Li Signed-off-by: Zong Li Co-developed-by: Vincent Chen Signed-off-by: Vincent Chen Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index eabddb7c7820..b07c8598bb21 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -113,6 +113,7 @@ static int pwm_sifive_get_state(struct pwm_chip *chip, = struct pwm_device *pwm, u32 duty, val; =20 duty =3D readl(ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); + duty =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - duty; =20 state->enabled =3D duty > 0; =20 @@ -123,11 +124,10 @@ static int pwm_sifive_get_state(struct pwm_chip *chip= , struct pwm_device *pwm, state->period =3D ddata->real_period; state->duty_cycle =3D (u64)duty * ddata->real_period >> PWM_SIFIVE_CMPWIDTH; - state->polarity =3D PWM_POLARITY_INVERSED; + state->polarity =3D PWM_POLARITY_NORMAL; =20 return 0; } - static int pwm_sifive_apply(struct pwm_chip *chip, struct pwm_device *pwm, const struct pwm_state *state) { @@ -139,7 +139,7 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, int ret =3D 0; u32 frac; =20 - if (state->polarity !=3D PWM_POLARITY_INVERSED) + if (state->polarity !=3D PWM_POLARITY_NORMAL) return -EINVAL; =20 cur_state =3D pwm->state; @@ -159,6 +159,7 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, frac =3D DIV64_U64_ROUND_CLOSEST(num, state->period); /* The hardware cannot generate a 100% duty cycle */ frac =3D min(frac, (1U << PWM_SIFIVE_CMPWIDTH) - 1); + frac =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - frac; =20 mutex_lock(&ddata->lock); if (state->period !=3D ddata->approx_period) { --=20 2.42.0 From nobody Thu Dec 25 01:28:06 2025 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4FDD53E21 for ; Tue, 23 Jan 2024 06:18:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705990689; cv=none; b=hhpX3PbvV6jMp6I3cMLLTB9pdSuK9YpCjY8azIx9VPQW29Swdl4TcjMspeU5c/wfwva6EFXfAEUNvv6AESUJ23tqnswGIDSpc5iJL84munufHBeQc3EJiasYE+USvTsYvo0KRzyj0l6M6ih/7eHxdaiEDzrhpZ3NFS+ogjAZq8g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705990689; c=relaxed/simple; bh=apn60oQs5B60ozKkNhLxgpW/v7Nd7OMtzE1ceBaZjWU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qgHyG7aNPOPBoqCuJWqVQ32T8C8Uns9Jojvaigr5Z1VzPoG0pJxvMLMYjHjqdD6Y8/GZc6JXjCCCAcaxSONXObREY6kmq5SFZOS3z0gGL64fuS1KPrIeiu1ZQDkhDVShyNuMgWnnsHRTNJ0C2G57HiarjnpNonp1BKRlVJtV0Wg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=Gx07QkKR; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="Gx07QkKR" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1d71c844811so17514675ad.3 for ; Mon, 22 Jan 2024 22:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1705990687; x=1706595487; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nYo9wXWOZdh4xBQbuTEOxrcqZQMwofEU/9c/S0MDuwU=; b=Gx07QkKRumLLwy5aHCC5hu1QhH/Ct1ZNLcLPaXeEoTR3twwFffROiEiTfYnfVI87dr T379wkWKJyIClB5ZpyCL9hzI6sgT+liIEb2NEEpfWcJLLSXCxLnFNCzxzP676dGCp6IB 2JXfkPJr8cGcc46nub3Pd4GXWp+pRzTMXpuaNiEiOGpkiGjA/bgpBMHRyZK6KmxdQMBn gZh2DnItigv6aGbDELZiE8qtb66JPz87u9me2M2l/KGsHNkOusknS2hy7V3NHDMu0txj OLBVTfVRkVcbkmLZ7olgHK0E60oP/eX3bT3pT2LGB6SW4FhmF2FyF/XulI/VojHoFtPl vgCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705990687; x=1706595487; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nYo9wXWOZdh4xBQbuTEOxrcqZQMwofEU/9c/S0MDuwU=; b=BsCevPqdXaweRSFHak7IzcoUM0J3IWRkiUw9HDp1PIm7jYYUODv/2qQFkQ3+5wCdBP 892KWnRGD6GghQyeJgWh59+/o629njuQC+YlQMg+FfFdZeTvrqfSfoZ7tyVmXKyr9sTy yR8NULmhrhL/bfAntVeuQ5AvFf5N6ZRHQNqF+2UzTmB5XLXNdIclWG2g+v8almGGpYB0 jnd+1iclnjeo0YFx5X3uj2OIF6j+uK4nRhgu8AShGce0+SPXvUPksfg9upMqwPF52JKt eWcuO+ZK374nD2ZN1e8stFtv9GzNgazkB/oiz/wfhY7XX5WDvoClF6Kytyaf4akqim1j tqIA== X-Gm-Message-State: AOJu0YxPAzWq2xV5xYCyR3IIwBjkaQoAqrZcW1+C/Zy0HbossAdHVfBE d+ZY0ziqtN4xU8ydD55zNfTDzITZPC16geB8l1ROJ2If1Guma+pdHoSJlE9dJfk= X-Google-Smtp-Source: AGHT+IFlNaztc63RI2VKYB9Y8YhdR8gD5UHFIk3F8bWliL75YvC4TOWoaqQeAhmdUbkd+zXMJ9ZT6w== X-Received: by 2002:a17:902:7897:b0:1d5:78db:4293 with SMTP id q23-20020a170902789700b001d578db4293mr3043550pll.29.1705990686972; Mon, 22 Jan 2024 22:18:06 -0800 (PST) Received: from hsinchu15.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id p7-20020a170902b08700b001d733c88646sm4425376plr.216.2024.01.22.22.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 22:18:06 -0800 (PST) From: Nylon Chen To: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, conor@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de Cc: vincent.chen@sifive.com, zong.li@sifve.com, nylon.chen@sifive.com, nylon7717@gmail.com Subject: [PATCH v7 3/3] pwm: sifive: Fix the error in the idempotent test within the pwm_apply_state_debug function Date: Tue, 23 Jan 2024 14:17:48 +0800 Message-ID: <20240123061748.8844-4-nylon.chen@sifive.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240123061748.8844-1-nylon.chen@sifive.com> References: <20240123061748.8844-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Round the result to the nearest whole number. This ensures that real_period is always a reasonable integer that is not lower than the actual value. e.g. $ echo 110 > /sys/devices/platform/led-controller-1/leds/d12/brightness $ .apply is not idempotent (ena=3D1 pol=3D0 1739692/4032985) -> (ena=3D1 po= l=3D0 1739630/4032985) Co-developed-by: Zong Li Signed-off-by: Zong Li Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index b07c8598bb21..7cf7a76cdb44 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -101,7 +101,7 @@ static void pwm_sifive_update_clock(struct pwm_sifive_d= data *ddata, =20 /* As scale <=3D 15 the shift operation cannot overflow. */ num =3D (unsigned long long)NSEC_PER_SEC << (PWM_SIFIVE_CMPWIDTH + scale); - ddata->real_period =3D div64_ul(num, rate); + ddata->real_period =3D DIV_ROUND_UP_ULL(num, rate); dev_dbg(ddata->chip.dev, "New real_period =3D %u ns\n", ddata->real_period); } --=20 2.42.0