From nobody Thu Dec 25 05:19:52 2025 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8420B17E8 for ; Tue, 23 Jan 2024 03:47:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.111.4.26 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705981632; cv=none; b=artyljp53kFDxTJEPyQsES4jfQfGv+DS2dPIoQ8h/EiuEIs5jYMq4KRMZvr9CC04me35qb0CBAwQ/FMklDdNBozlShUergkjeGzmKDBlcdpKqd2WqB+NmhM2KBthxbADwFScZwvWe9M4x+4SNk9loeZm1IQYQ1SldA3zfGJ1NBQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705981632; c=relaxed/simple; bh=ebuXU93NWE5l7bMJomxhtlmk69J+qiMDRuYxlKKxW4k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Y4oP2tM/tV9WW4BiZ2vzaGsyEyLMV6QQWOxkjYECbkbvmGIJ/Riw/g1ftsjfI73tNbMSK97tMKQgvLmIksh86H8dXuZD7sBER1hSxAX2UiotbEuegEsCGjfTFCr2oU+8D8naPUfWe+SxP0kCvDn0JE/zh5Tit900SZFnQV8F8RY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sent.com; spf=pass smtp.mailfrom=sent.com; dkim=pass (2048-bit key) header.d=sent.com header.i=@sent.com header.b=TGPjcuaB; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=tqVvXjVA; arc=none smtp.client-ip=66.111.4.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sent.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sent.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sent.com header.i=@sent.com header.b="TGPjcuaB"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="tqVvXjVA" Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id 940C55C0330; Mon, 22 Jan 2024 22:47:09 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 22 Jan 2024 22:47:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to; s=fm3; t= 1705981629; x=1706068029; bh=OGWh8nwjD+/F70nRvDY2KROL0h10J6GLLU2 GjbyVFgk=; b=TGPjcuaByLyZV1Rdhrq/FKYymI5xvg9LZGK/2tn2BbtF7NofOLA ixPOWHNiSULzRbh5ytOTGxCQqMqYZy+oJjmMfUlH6t4UwhxJ8Drhtx+Av0tmz+pv 0YOwL9pSXtgkBZpqGX65exujNB+tyOYY7QyXPvopEPNbBCF7omPF/hu6p5ewahmv tdJkl1c/RjOztczeoywOxv0BJgZeKCfzm8/S7wOAodpTfNJAd6xzPHqQgG4vcDDl 9kAk0FNhx6Z33gYsI20JBF68okJAnKCsDndtlqT1khjqCcAlMnrCI5ZSetMP5I8i C04PoKW6qj1AdlyDZN2qiAKe2Rv7YINE1tw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1705981629; x=1706068029; bh=OGWh8nwjD+/F70nRvDY2KROL0h10J6GLLU2 GjbyVFgk=; b=tqVvXjVAhViwWsuQ0tXVg3IvxjqMdLLDDo5Oxbel+wxtcu7m7Tw 71MNXYVST7GLueUgO5y8nYsOv5AdILI7aNevErF9mp5D/arDq7PwON567x10SuKp a2Z7zMiQJQ6Xl5hoS0b94lZCwVVJN7etujpA0qgvmWxmN9UpofxfR7j+ZQduik4G EzcK++YZXFgp5xuHnyOPXhyjw++gDJ0Lfk4G99+cjeIyRlLEA7wcmLrwFGb83T0k 5GaaJGBYAuKxv6eUuODMymZauhCfHQY3PjBSNEpXeL1wfnNuc9FCo5/REAefzSR3 jTTo1Ir3ifb8VRN4Tt3dRGgK3RotXqq+7Qg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdekjedgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhhrgggtgfesthekredtredtjeenucfhrhhomhepkghi ucgjrghnuceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepje ekteekffelleekudfftdefvddtjeejuedtuedtteegjefgvedtfedujeekieevnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepiihirdihrghnse hsvghnthdrtghomh X-ME-Proxy: Feedback-ID: iccd040f4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Jan 2024 22:47:08 -0500 (EST) From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Zi Yan , "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: [PATCH v2 2/3] mm/compaction: add support for >0 order folio memory compaction. Date: Mon, 22 Jan 2024 22:46:34 -0500 Message-ID: <20240123034636.1095672-3-zi.yan@sent.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240123034636.1095672-1-zi.yan@sent.com> References: <20240123034636.1095672-1-zi.yan@sent.com> Reply-To: Zi Yan Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Zi Yan Before last commit, memory compaction only migrates order-0 folios and skips >0 order folios. Last commit splits all >0 order folios during compaction. This commit migrates >0 order folios during compaction by keeping isolated free pages at their original size without splitting them into order-0 pages and using them directly during migration process. What is different from the prior implementation: 1. All isolated free pages are kept in a NR_PAGE_ORDERS array of page lists, where each page list stores free pages in the same order. 2. All free pages are not post_alloc_hook() processed nor buddy pages, although their orders are stored in first page's private like buddy pages. 3. During migration, in new page allocation time (i.e., in compaction_alloc()), free pages are then processed by post_alloc_hook(). When migration fails and a new page is returned (i.e., in compaction_free()), free pages are restored by reversing the post_alloc_hook() operations using newly added free_pages_prepare_fpi_none(). Step 3 is done for a latter optimization that splitting and/or merging free pages during compaction becomes easier. Note: without splitting free pages, compaction can end prematurely due to migration will return -ENOMEM even if there is free pages. This happens when no order-0 free page exist and compaction_alloc() return NULL. Signed-off-by: Zi Yan --- mm/compaction.c | 148 +++++++++++++++++++++++++++++------------------- mm/internal.h | 9 ++- mm/page_alloc.c | 6 ++ 3 files changed, 103 insertions(+), 60 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 61389540e1f1..11f9898e39da 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -66,45 +66,67 @@ static inline void count_compact_events(enum vm_event_i= tem item, long delta) #define COMPACTION_HPAGE_ORDER (PMD_SHIFT - PAGE_SHIFT) #endif =20 -static unsigned long release_freepages(struct list_head *freelist) +static void init_page_list(struct page_list *p) { - struct page *page, *next; - unsigned long high_pfn =3D 0; - - list_for_each_entry_safe(page, next, freelist, lru) { - unsigned long pfn =3D page_to_pfn(page); - list_del(&page->lru); - __free_page(page); - if (pfn > high_pfn) - high_pfn =3D pfn; - } - - return high_pfn; + INIT_LIST_HEAD(&p->pages); + p->nr_pages =3D 0; } =20 -static void split_map_pages(struct list_head *list) +static void split_map_pages(struct page_list *freepages) { - unsigned int i, order, nr_pages; + unsigned int i, order, total_nr_pages; struct page *page, *next; LIST_HEAD(tmp_list); =20 - list_for_each_entry_safe(page, next, list, lru) { - list_del(&page->lru); + for (order =3D 0; order < NR_PAGE_ORDERS; order++) { + total_nr_pages =3D freepages[order].nr_pages * (1 << order); + freepages[order].nr_pages =3D 0; + + list_for_each_entry_safe(page, next, &freepages[order].pages, lru) { + unsigned int nr_pages; + + list_del(&page->lru); =20 - order =3D page_private(page); - nr_pages =3D 1 << order; + nr_pages =3D 1 << order; =20 - post_alloc_hook(page, order, __GFP_MOVABLE); - if (order) - split_page(page, order); + post_alloc_hook(page, order, __GFP_MOVABLE); + if (order) + split_page(page, order); =20 - for (i =3D 0; i < nr_pages; i++) { - list_add(&page->lru, &tmp_list); - page++; + for (i =3D 0; i < nr_pages; i++) { + list_add(&page->lru, &tmp_list); + page++; + } } + freepages[0].nr_pages +=3D total_nr_pages; + list_splice_init(&tmp_list, &freepages[0].pages); } +} =20 - list_splice(&tmp_list, list); +static unsigned long release_free_list(struct page_list *freepages) +{ + int order; + unsigned long high_pfn =3D 0; + + for (order =3D 0; order < NR_PAGE_ORDERS; order++) { + struct page *page, *next; + + list_for_each_entry_safe(page, next, &freepages[order].pages, lru) { + unsigned long pfn =3D page_to_pfn(page); + + list_del(&page->lru); + /* + * Convert free pages into post allocation pages, so + * that we can free them via __free_page. + */ + post_alloc_hook(page, order, __GFP_MOVABLE); + __free_pages(page, order); + if (pfn > high_pfn) + high_pfn =3D pfn; + } + freepages[order].nr_pages =3D 0; + } + return high_pfn; } =20 #ifdef CONFIG_COMPACTION @@ -583,7 +605,7 @@ static bool compact_unlock_should_abort(spinlock_t *loc= k, static unsigned long isolate_freepages_block(struct compact_control *cc, unsigned long *start_pfn, unsigned long end_pfn, - struct list_head *freelist, + struct page_list *freelist, unsigned int stride, bool strict) { @@ -657,7 +679,8 @@ static unsigned long isolate_freepages_block(struct com= pact_control *cc, nr_scanned +=3D isolated - 1; total_isolated +=3D isolated; cc->nr_freepages +=3D isolated; - list_add_tail(&page->lru, freelist); + list_add_tail(&page->lru, &freelist[order].pages); + freelist[order].nr_pages++; =20 if (!strict && cc->nr_migratepages <=3D cc->nr_freepages) { blockpfn +=3D isolated; @@ -722,7 +745,11 @@ isolate_freepages_range(struct compact_control *cc, unsigned long start_pfn, unsigned long end_pfn) { unsigned long isolated, pfn, block_start_pfn, block_end_pfn; - LIST_HEAD(freelist); + int order; + struct page_list tmp_freepages[NR_PAGE_ORDERS]; + + for (order =3D 0; order < NR_PAGE_ORDERS; order++) + init_page_list(&tmp_freepages[order]); =20 pfn =3D start_pfn; block_start_pfn =3D pageblock_start_pfn(pfn); @@ -753,7 +780,7 @@ isolate_freepages_range(struct compact_control *cc, break; =20 isolated =3D isolate_freepages_block(cc, &isolate_start_pfn, - block_end_pfn, &freelist, 0, true); + block_end_pfn, tmp_freepages, 0, true); =20 /* * In strict mode, isolate_freepages_block() returns 0 if @@ -770,15 +797,15 @@ isolate_freepages_range(struct compact_control *cc, */ } =20 - /* __isolate_free_page() does not map the pages */ - split_map_pages(&freelist); - if (pfn < end_pfn) { /* Loop terminated early, cleanup. */ - release_freepages(&freelist); + release_free_list(tmp_freepages); return 0; } =20 + /* __isolate_free_page() does not map the pages */ + split_map_pages(tmp_freepages); + /* We don't use freelists for anything. */ return pfn; } @@ -1462,7 +1489,7 @@ fast_isolate_around(struct compact_control *cc, unsig= ned long pfn) if (!page) return; =20 - isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false= ); + isolate_freepages_block(cc, &start_pfn, end_pfn, cc->freepages, 1, false); =20 /* Skip this pageblock in the future as it's full or nearly full */ if (start_pfn =3D=3D end_pfn && !cc->no_set_skip_hint) @@ -1591,7 +1618,7 @@ static void fast_isolate_freepages(struct compact_con= trol *cc) nr_scanned +=3D nr_isolated - 1; total_isolated +=3D nr_isolated; cc->nr_freepages +=3D nr_isolated; - list_add_tail(&page->lru, &cc->freepages); + list_add_tail(&page->lru, &cc->freepages[order].pages); count_compact_events(COMPACTISOLATED, nr_isolated); } else { /* If isolation fails, abort the search */ @@ -1668,13 +1695,12 @@ static void isolate_freepages(struct compact_contro= l *cc) unsigned long isolate_start_pfn; /* exact pfn we start at */ unsigned long block_end_pfn; /* end of current pageblock */ unsigned long low_pfn; /* lowest pfn scanner is able to scan */ - struct list_head *freelist =3D &cc->freepages; unsigned int stride; =20 /* Try a small search of the free lists for a candidate */ fast_isolate_freepages(cc); if (cc->nr_freepages) - goto splitmap; + return; =20 /* * Initialise the free scanner. The starting point is where we last @@ -1734,7 +1760,7 @@ static void isolate_freepages(struct compact_control = *cc) =20 /* Found a block suitable for isolating free pages from. */ nr_isolated =3D isolate_freepages_block(cc, &isolate_start_pfn, - block_end_pfn, freelist, stride, false); + block_end_pfn, cc->freepages, stride, false); =20 /* Update the skip hint if the full pageblock was scanned */ if (isolate_start_pfn =3D=3D block_end_pfn) @@ -1775,10 +1801,6 @@ static void isolate_freepages(struct compact_control= *cc) * and the loop terminated due to isolate_start_pfn < low_pfn */ cc->free_pfn =3D isolate_start_pfn; - -splitmap: - /* __isolate_free_page() does not map the pages */ - split_map_pages(freelist); } =20 /* @@ -1789,23 +1811,22 @@ static struct folio *compaction_alloc(struct folio = *src, unsigned long data) { struct compact_control *cc =3D (struct compact_control *)data; struct folio *dst; + int order =3D folio_order(src); =20 - /* this makes migrate_pages() split the source page and retry */ - if (folio_test_large(src) > 0) - return NULL; - - if (list_empty(&cc->freepages)) { + if (!cc->freepages[order].nr_pages) { isolate_freepages(cc); - - if (list_empty(&cc->freepages)) + if (!cc->freepages[order].nr_pages) return NULL; } =20 - dst =3D list_entry(cc->freepages.next, struct folio, lru); + dst =3D list_first_entry(&cc->freepages[order].pages, struct folio, lru); + cc->freepages[order].nr_pages--; list_del(&dst->lru); - cc->nr_freepages--; - - return dst; + post_alloc_hook(&dst->page, order, __GFP_MOVABLE); + if (order) + prep_compound_page(&dst->page, order); + cc->nr_freepages -=3D 1 << order; + return page_rmappable_folio(&dst->page); } =20 /* @@ -1816,9 +1837,17 @@ static struct folio *compaction_alloc(struct folio *= src, unsigned long data) static void compaction_free(struct folio *dst, unsigned long data) { struct compact_control *cc =3D (struct compact_control *)data; + int order =3D folio_order(dst); + struct page *page =3D &dst->page; + + folio_set_count(dst, 0); + free_pages_prepare_fpi_none(page, order); =20 - list_add(&dst->lru, &cc->freepages); - cc->nr_freepages++; + INIT_LIST_HEAD(&dst->lru); + + list_add(&dst->lru, &cc->freepages[order].pages); + cc->freepages[order].nr_pages++; + cc->nr_freepages +=3D 1 << order; } =20 /* possible outcome of isolate_migratepages */ @@ -2442,6 +2471,7 @@ compact_zone(struct compact_control *cc, struct captu= re_control *capc) const bool sync =3D cc->mode !=3D MIGRATE_ASYNC; bool update_cached; unsigned int nr_succeeded =3D 0; + int order; =20 /* * These counters track activities during zone compaction. Initialize @@ -2451,7 +2481,8 @@ compact_zone(struct compact_control *cc, struct captu= re_control *capc) cc->total_free_scanned =3D 0; cc->nr_migratepages =3D 0; cc->nr_freepages =3D 0; - INIT_LIST_HEAD(&cc->freepages); + for (order =3D 0; order < NR_PAGE_ORDERS; order++) + init_page_list(&cc->freepages[order]); INIT_LIST_HEAD(&cc->migratepages); =20 cc->migratetype =3D gfp_migratetype(cc->gfp_mask); @@ -2637,7 +2668,7 @@ compact_zone(struct compact_control *cc, struct captu= re_control *capc) * so we don't leave any returned pages behind in the next attempt. */ if (cc->nr_freepages > 0) { - unsigned long free_pfn =3D release_freepages(&cc->freepages); + unsigned long free_pfn =3D release_free_list(cc->freepages); =20 cc->nr_freepages =3D 0; VM_BUG_ON(free_pfn =3D=3D 0); @@ -2656,7 +2687,6 @@ compact_zone(struct compact_control *cc, struct captu= re_control *capc) =20 trace_mm_compaction_end(cc, start_pfn, end_pfn, sync, ret); =20 - VM_BUG_ON(!list_empty(&cc->freepages)); VM_BUG_ON(!list_empty(&cc->migratepages)); =20 return ret; diff --git a/mm/internal.h b/mm/internal.h index f309a010d50f..886040a907d3 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -447,6 +447,8 @@ extern void prep_compound_page(struct page *page, unsig= ned int order); =20 extern void post_alloc_hook(struct page *page, unsigned int order, gfp_t gfp_flags); +extern bool free_pages_prepare_fpi_none(struct page *page, unsigned int or= der); + extern int user_min_free_kbytes; =20 extern void free_unref_page(struct page *page, unsigned int order); @@ -473,6 +475,11 @@ int split_free_page(struct page *free_page, /* * in mm/compaction.c */ + +struct page_list { + struct list_head pages; + unsigned long nr_pages; +}; /* * compact_control is used to track pages being migrated and the free pages * they are being migrated to during memory compaction. The free_pfn starts @@ -481,7 +488,7 @@ int split_free_page(struct page *free_page, * completes when free_pfn <=3D migrate_pfn */ struct compact_control { - struct list_head freepages; /* List of free pages to migrate to */ + struct page_list freepages[NR_PAGE_ORDERS]; /* List of free pages to migr= ate to */ struct list_head migratepages; /* List of pages being migrated */ unsigned int nr_freepages; /* Number of isolated free pages */ unsigned int nr_migratepages; /* Number of pages to migrate */ diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 5be4cd8f6b5a..c7c135e6d5ee 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1179,6 +1179,12 @@ static __always_inline bool free_pages_prepare(struc= t page *page, return true; } =20 +__always_inline bool free_pages_prepare_fpi_none(struct page *page, + unsigned int order) +{ + return free_pages_prepare(page, order, FPI_NONE); +} + /* * Frees a number of pages from the PCP lists * Assumes all pages on list are in same zone. --=20 2.43.0